insightly 0.2.7 → 0.2.8

data/lib/insightly/address_helper.rb

@@ -1,22 +1,24 @@
 module Insightly
   module AddressHelper
     def addresses
-      return [] if !@data["ADDRESSES"]
-         @data["ADDRESSES"].collect {|a| Insightly::Address.build(a)}
-     end
-     def addresses=(list)
-       @data["ADDRESSES"] = list.collect {|a| a.remote_data}
-     end
-     def add_address(address)
-       @data["ADDRESSES"] ||= []
-       @data["ADDRESSES"].each do |a|
-         if  address.same_address?(Insightly::Address.build(a))
+      @data["ADDRESSES"] ||= []
+      @data["ADDRESSES"].collect { |a| Insightly::Address.build(a) }
+    end
 
-           return false
-         end
-       end
-       @data["ADDRESSES"] << address.remote_data
-       true
-     end
+    def addresses=(list)
+      @data["ADDRESSES"] = list ? list.collect { |a| a.remote_data }  : []
+    end
+
+    def add_address(address)
+      @data["ADDRESSES"] ||= []
+      @data["ADDRESSES"].each do |a|
+        if  address.same_address?(Insightly::Address.build(a))
+
+          return false
+        end
+      end
+      @data["ADDRESSES"] << address.remote_data
+      true
+    end
   end
 end

data/lib/insightly/contact_info_helper.rb

@@ -1,16 +1,18 @@
 module Insightly
   module ContactInfoHelper
     def contact_infos
-      return [] if !@data["CONTACTINFOS"]
-         @data["CONTACTINFOS"].collect {|a| Insightly::ContactInfo.build(a)}
-     end
-     def contact_infos=(list)
-       @data["CONTACTINFOS"] = list.collect {|a| a.remote_data}
-     end
-     def add_contact_info(contact_info)
-       @data["CONTACTINFOS"] ||= []
-       @data["CONTACTINFOS"] << contact_info.remote_data
-       true
-     end
+      @data["CONTACTINFOS"] ||= []
+      @data["CONTACTINFOS"].collect { |a| Insightly::ContactInfo.build(a) }
+    end
+
+    def contact_infos=(list)
+      @data["CONTACTINFOS"] = list ?  list.collect { |a| a.remote_data }  : []
+    end
+
+    def add_contact_info(contact_info)
+      @data["CONTACTINFOS"] ||= []
+      @data["CONTACTINFOS"] << contact_info.remote_data
+      true
+    end
   end
 end

data/lib/insightly/link_helper.rb

@@ -1,11 +1,11 @@
 module Insightly
   module LinkHelper
     def links
-        return [] if !@data["LINKS"]
+      @data["LINKS"] ||= []
          @data["LINKS"].collect {|a| Insightly::Link.build(a)}
      end
      def links=(list)
-       @data["LINKS"] = list.collect {|a| fix_for_link(a).remote_data}
+       @data["LINKS"] = list ? list.collect {|a| fix_for_link(a).remote_data} : []
      end
      def add_link(link)
        @data["LINKS"] ||= []

data/lib/insightly/tag_helper.rb

@@ -1,11 +1,11 @@
 module Insightly
   module TagHelper
     def tags
-      return [] if !@data["TAGS"]
+         @data["TAGS"]  ||= []
          @data["TAGS"].collect {|a| Insightly::Tag.build(a)}
      end
      def tags=(list)
-       @data["TAGS"] = list.collect {|a| a.remote_data}
+       @data["TAGS"] = list ? list.collect {|a| a.remote_data} : []
      end
      def add_tag(tag)
        @data["TAGS"]  ||= []

data/lib/insightly/task_link_helper.rb

@@ -1,11 +1,11 @@
 module Insightly
   module TaskLinkHelper
     def task_links
-      return [] if !@data["TASKLINKS"]
+      @data["TASKLINKS"] ||= []
          @data["TASKLINKS"].collect {|a| Insightly::TaskLink.build(a)}
      end
      def task_links=(list)
-       @data["TASKLINKS"] = list.collect {|a| fix_for_link(a).remote_data}
+       @data["TASKLINKS"] = list ? list.collect {|a| fix_for_link(a).remote_data} : []
      end
      def add_task_link(link)
        @data["TASKLINKS"] ||= []

data/lib/insightly/version.rb

@@ -4,7 +4,7 @@ module Insightly
   module Version
     Major = 0
     Minor = 2
-    Tiny = 7
+    Tiny = 8
     String = "#{Major}.#{Minor}.#{Tiny}"
   end
 end

data/spec/unit/organisation_spec.rb

@@ -44,7 +44,7 @@ describe Insightly::Organisation do
   #
   #  @organisation.visible_to = "EVERYONE"
   #  @organisation.organisation_name = "000 Dummy Test Org"
-  #  @organisation.background =  "This organisation was created for test purposes and can be deleted."
+  #  @organisation.background =  "This organisation was crtaskeated for test purposes and can be deleted."
   #
   #  @organisation.save
   #
@@ -75,6 +75,10 @@ describe Insightly::Organisation do
         @address.postcode = "46112"
         @address.country = "US"
       end
+      it "should let you set it to nil" do
+        @org.addresses = nil
+        @org.addresses.should == []
+      end
       it "should allow you to update an address" do
         @org.addresses.should == []
         @org.add_address(@address)
@@ -142,6 +146,10 @@ describe Insightly::Organisation do
         @contact_info.detail = "bob@aol.com"
 
       end
+      it "should let you set it to nil" do
+         @org.contact_infos = nil
+         @org.contact_infos.should == []
+       end
       it "should allow you to update an contact_info" do
         @org.contact_infos.should == []
         @org.add_contact_info(@contact_info)
@@ -195,6 +203,10 @@ describe Insightly::Organisation do
         @link = Insightly::Link.add_contact(2982194, "Janitor", "Recent Hire")
         # @link = Insightly::Link.add_opportunity(968613,"Janitor", "Recent Hire")
       end
+      it "should let you set it to nil" do
+         @org.links = nil
+         @org.links.should == []
+       end
       it "should allow you to update an link" do
         @org.links.should == []
         @org.add_link(@link)
@@ -249,6 +261,10 @@ describe Insightly::Organisation do
         @tag2 = Insightly::Tag.build("Freebie")
 
       end
+      it "should let you set it to nil" do
+         @org.tags = nil
+         @org.tags.should == []
+       end
       it "should allow you to update an tag" do
         @org.tags.should == []
         @org.add_tag(@tag)

data/spec/unit/task_spec.rb

@@ -173,14 +173,20 @@ describe Insightly::Task do
 
   context "TaskLinks" do
      before(:each) do
-       @task = Insightly::Task.new(3263739)
+      # @task = Insightly::Task.new(3263739)
+        @task = Insightly::Task.new
        @task.task_links = []
-       @task.save
+      # @task.save
  
  
        @link = Insightly::TaskLink.add_organisation(8936117)
        @link2 = Insightly::TaskLink.add_opportunity(968613)
      end
+     it "should allow you to try to set it to nil" do
+       @task = Insightly::Task.new
+       @task.task_links = nil
+       @task.task_links.should == []
+     end
      it "should allow you to update an link" do
        @task.task_links.should == []
        @task.add_task_link(@link)

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: insightly
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 7
   prerelease: 
   segments: 
   - 0
   - 2
-  - 7
-  version: 0.2.7
+  - 8
+  version: 0.2.8
 platform: ruby
 authors: 
 - Dirk Elmendorf