inqlude 0.0.8 → 0.7.0

data/spec/manifest_handler_spec.rb

@@ -1,5 +1,7 @@
 require File.expand_path('../spec_helper', __FILE__)
 
+include GivenFilesystemSpecHelpers
+
 describe ManifestHandler do
 
   let(:settings) do
@@ -16,27 +18,51 @@ describe ManifestHandler do
   end
   
   it "reads manifests" do
-    mh.manifests.count.should == 2
-    mh.libraries.count.should == 2
+    expect(mh.manifests.count).to eq 5
+    expect(mh.libraries.count).to eq 5
     mh.read_remote
-    mh.manifests.count.should == 2
-    mh.libraries.count.should == 2
+    expect(mh.manifests.count).to eq 5
+    expect(mh.libraries.count).to eq 5
   end
 
   it "provides access to manifests" do
-    mh.manifest("awesomelib").class.should == Hash
+    expect(mh.manifest("awesomelib").class).to be Hash
     expect { mh.manifest("nonexisting") }.to raise_error
   end
+
+  it "reads schema type" do
+    expect(mh.manifest("awesomelib")["schema_type"]).to eq "release"
+    expect(mh.manifest("newlib")["schema_type"]).to eq "generic"
+    expect(mh.manifest("proprietarylib")["schema_type"]).to eq "proprietary-release"
+  end
+
+  context "default manifest path" do
+    before(:each) do
+      @handler = ManifestHandler.new Settings.new
+    end
+
+    it "returns generic manifest path" do
+      manifest = create_generic_manifest( "mylib" )
+      expect( @handler.manifest_path( manifest ) ).to eq(
+        File.expand_path( "~/.local/share/inqlude/manifests/mylib/mylib.manifest" ) )
+    end
+
+    it "returns release manifest path" do
+      manifest = create_manifest( "mylib", "2014-02-01", "1.0" )
+      expect( @handler.manifest_path( manifest ) ).to eq(
+        File.expand_path( "~/.local/share/inqlude/manifests/mylib/mylib.2014-02-01.manifest" ) )
+    end
+  end
   
-  context "#libraries" do
+  describe "#libraries" do
 
     it "returns all libraries" do
-      expect( mh.libraries.count ).to eq 2
+      expect( mh.libraries.count ).to eq 5
     end
     
     it "returns stable libraries" do
       libraries = mh.libraries :stable
-      expect( libraries.count ).to eq 1
+      expect( libraries.count ).to eq 2
       expect( libraries.first.manifests.last["name"] ).to eq "awesomelib"
       expect( libraries.first.manifests.last["version"] ).to eq "0.2.0"
     end
@@ -47,7 +73,75 @@ describe ManifestHandler do
       expect( libraries.first.manifests.last["name"] ).to eq "bleedingedge"
       expect( libraries.first.manifests.last["version"] ).to eq "edge"
     end
+    
+    it "returns unreleased libraries" do
+      libraries = mh.unreleased_libraries
+      expect( libraries.count ).to eq 1
+      expect( libraries.first.manifests.last["name"] ).to eq "newlib"
+    end
+    
+    it "returns commercial libraries" do
+      libraries = mh.commercial_libraries
+      expect( libraries.count ).to eq 3
+      expect( libraries.first.manifests.last["name"] ).to eq "awesomelib"
+      expect( libraries[1].manifests.last["name"] ).to eq "commercial"
+    end
 
   end
   
+  describe "#group" do
+    it "returns all libraries of a group" do
+      libraries = mh.group("kde-frameworks")
+      expect( libraries.count ).to eq 2
+      expect( libraries.first.manifests.last["name"] ).to eq "awesomelib"
+    end
+  end
+  
+  describe "#library" do
+    
+    it "returns one library" do
+      library = mh.library "awesomelib"
+      expect( library.name ).to eq "awesomelib"
+    end
+    
+  end
+  
+  context "library with generic and release manifest" do
+    use_given_filesystem
+
+    before(:each) do
+      @manifest_path = given_directory do
+        given_directory "karchive" do
+          given_file "karchive.manifest", :from => "karchive-generic.manifest"
+          given_file "karchive.2014-02-01.manifest", :from => "karchive-release-beta.manifest"
+        end
+      end
+      
+      s = Settings.new
+      s.manifest_path = @manifest_path
+      s.offline = true
+      @manifest_handler = ManifestHandler.new s
+      @manifest_handler.read_remote
+    end
+    
+    it "reads generic manifest" do
+      expect( @manifest_handler.library("karchive").manifests.count ).to eq 2
+      generic_manifest = @manifest_handler.library("karchive").generic_manifest
+      expect( generic_manifest["name"] ).to eq "karchive"
+      expect( generic_manifest["schema_type"] ).to eq "generic"
+    end
+    
+    it "lists development versions" do
+      libraries = @manifest_handler.libraries :beta
+      expect( libraries.count ).to eq 1
+      expect( libraries.first.latest_manifest["name"] ).to eq "karchive"
+      expect( libraries.first.latest_manifest["version"] ).to eq "4.9.90"
+    end
+    
+    it "lists unreleased libraries" do
+      libraries = @manifest_handler.unreleased_libraries
+      expect( libraries.count ).to eq 0
+    end
+  end
+  
 end

data/spec/manifest_spec.rb

@@ -0,0 +1,63 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+describe Manifest do
+
+  include_context "manifest_files"
+  
+  it "provides schema identifier" do
+    expect(Manifest.release_schema_id).to include("inqlude.org")
+    expect(Manifest.release_schema_id).to include("release")
+
+    expect(Manifest.generic_schema_id).to include("inqlude.org")
+    expect(Manifest.generic_schema_id).to include("generic")
+
+    expect(Manifest.proprietary_release_schema_id).to include("inqlude.org")
+    expect(Manifest.proprietary_release_schema_id).to include("proprietary")
+  end
+  
+  it "parses schema id" do
+    expect{Manifest.parse_schema_id("xxx")}.to raise_error StandardError
+
+    type, version = Manifest.parse_schema_id(
+      "http://inqlude.org/schema/release-manifest-v1#" )
+    expect(type).to eq "release"
+    expect(version).to eq 1
+
+    type, version = Manifest.parse_schema_id(
+      "http://inqlude.org/schema/release-manifest-v2#" )
+    expect(type).to eq "release"
+    expect(version).to eq 2
+
+    type, version = Manifest.parse_schema_id(
+      "http://inqlude.org/schema/generic-manifest-v1#" )
+    expect(type).to eq "generic"
+    expect(version).to eq 1
+  end
+  
+  it "parses release manifest" do
+    filename = File.join settings.manifest_path, awesomelib_manifest_file
+    manifest = Manifest.parse_file filename
+    expect(manifest["name"]).to eq "awesomelib"
+    expect(manifest["version"]).to eq "0.2.0"
+    expect(manifest["filename"]).to eq "awesomelib.2013-09-08.manifest"
+    expect(manifest["libraryname"]).to eq "awesomelib"
+    expect(manifest["schema_type"]).to eq "release"
+    expect(manifest["schema_version"]).to eq 1
+  end
+
+  it "parses generic manifest" do
+    filename = File.join settings.manifest_path, newlib_manifest_file
+    manifest = Manifest.parse_file filename
+    expect(manifest["name"]).to eq "newlib"
+    expect(manifest.has_key? "version").to eq false
+    expect(manifest["filename"]).to eq "newlib.manifest"
+    expect(manifest["schema_type"]).to eq "generic"
+    expect(manifest["schema_version"]).to eq 1
+  end
+
+  it "writes JSON" do
+    filename = File.join settings.manifest_path, awesomelib_manifest_file
+    manifest = Manifest.parse_file filename
+    expect( Manifest.to_json( manifest ) ).to eq File.read( filename )
+  end
+end

data/spec/rpm_manifestizer_spec.rb

@@ -4,8 +4,8 @@ describe RpmManifestizer do
 
   it "detects libraries" do
     m = RpmManifestizer.new Settings.new
-    m.is_library?( "libjson" ).should be_true
-    m.is_library?( "kontact" ).should be_false
+    expect(m.is_library?( "libjson" )).to be true
+    expect(m.is_library?( "kontact" )).to be false
   end
 
 end

data/spec/settings_spec.rb

@@ -2,14 +2,63 @@ require File.expand_path('../spec_helper', __FILE__)
 
 describe Settings do
 
-  it "has default manifest path" do
-    Settings.new.manifest_path.should == File.join( ENV["HOME"], ".inqlude/manifests" )
-  end
+  include GivenFilesystemSpecHelpers
 
   it "lets manifest path to be set" do
     s = Settings.new
     s.manifest_path = "abc/xyz"
-    s.manifest_path.should == "abc/xyz"
+    expect(s.manifest_path).to eq "abc/xyz"
+  end
+
+  it "has default xdg data path" do
+    s = Settings.new
+    expected_path = File.join(ENV["HOME"], ".local/share/inqlude")
+    received_path = s.xdg_data_path.to_s
+    expect(received_path).to eq expected_path
+  end
+
+  it "has default xdg cache path" do
+    s = Settings.new
+    expected_path = File.join(ENV["HOME"], ".cache/inqlude")
+    received_path = s.xdg_cache_path.to_s
+    expect(received_path).to eq expected_path
+  end
+
+  it "has default manifest path" do
+    expect(Settings.new.manifest_path).to eq(
+      File.join( ENV["HOME"], ".local/share/inqlude/manifests"))
+  end
+
+
+  context "fake HOME" do
+    use_given_filesystem
+
+    before(:each) do
+      @old_home = ENV["HOME"]
+
+      @home = given_directory
+      ENV["HOME"] = @home
+    end
+
+    after(:each) do
+      ENV["HOME"] = @old_home
+    end
+
+    it "creates manifest dir" do
+      s = Settings.new
+
+      expect(s.manifest_dir).to eq File.join(@home,
+        ".local/share/inqlude/manifests")
+      expect(File.exist?(s.manifest_dir)).to be true
+    end
+
+    it "creates cache dir" do
+      s = Settings.new
+
+      expect(s.cache_dir).to eq File.join(@home,
+        ".cache/inqlude")
+      expect(File.exist?(s.cache_dir)).to be true
+    end
   end
 
 end

data/spec/spec_helper.rb

@@ -1,9 +1,48 @@
+require 'given_filesystem/spec_helpers'
+
 require File.expand_path('../../lib/inqlude', __FILE__)
 
-def create_manifest name, version
+def test_data_path file_name
+  File.expand_path(File.join('../data/', file_name), __FILE__)
+end
+
+def create_manifest name, release_date, version
   m = Hash.new
+  m["schema_type"] = "release"
   m["name"] = name
   m["version"] = version
+  m["release_date" ] = release_date
+  m["description"] = "#{name} is a nice library."
+  m
+end
+
+def create_generic_manifest name
+  m = Hash.new
+  m["schema_type"] = "generic"
+  m["name"] = name
   m["description"] = "#{name} is a nice library."
   m
 end
+
+shared_context "manifest_files" do
+
+  let(:settings) do
+    s = Settings.new
+    s.manifest_path = File.expand_path('spec/data/')
+    s.offline = true
+    s
+  end
+
+  let(:awesomelib_manifest_file) do
+    "awesomelib/awesomelib.2013-09-08.manifest"
+  end
+
+  let(:newlib_manifest_file) do
+    "newlib/newlib.manifest"
+  end
+
+  let(:proprietarylib_manifest_file) do
+    "proprietarylib/proprietarylib.2013-12-22.manifest"
+  end
+
+end

data/spec/verifier_spec.rb

@@ -2,33 +2,28 @@ require File.expand_path('../spec_helper', __FILE__)
 
 describe Verifier do
 
-  let(:settings) do
-    s = Settings.new
-    s.manifest_path = File.expand_path('spec/data/')
-    s.offline = true
-    s
-  end
-
+  include_context "manifest_files"
+  
   it "defines result class" do
     r = Verifier::Result.new
-    r.valid?.should be_false
-    r.errors.class.should == Array
+    expect(r.valid?).to be false
+    expect(r.errors.class).to be Array
   end
   
   it "verifies read manifests" do
     handler = ManifestHandler.new settings
     handler.read_remote
-    
+
     verifier = Verifier.new settings
-    verifier.verify( handler.manifest("awesomelib") ).class.should == Verifier::Result
-    verifier.verify( handler.manifest("awesomelib") ).valid?.should be_true
+    expect(verifier.verify( handler.manifest("awesomelib") ).class).to be Verifier::Result
+    expect(verifier.verify( handler.manifest("awesomelib") ).valid?).to be true
   end
 
   it "detects incomplete manifest" do
     verifier = Verifier.new settings
 
     manifest = Hash.new
-    verifier.verify( manifest ).valid?.should be_false
+    expect(verifier.verify( manifest ).valid?).to be false
   end
       
   it "detects invalid entries" do
@@ -37,11 +32,11 @@ describe Verifier do
     verifier = Verifier.new settings
 
     manifest = handler.manifest("awesomelib")
-    verifier.verify(manifest).valid?.should be_true
+    expect(verifier.verify(manifest).valid?).to be true
 
     manifest["invalidentry"] = "something"
-    verifier.verify(manifest).valid?.should be_false
-    verifier.verify(manifest).errors.count.should == 1
+    expect(verifier.verify(manifest).valid?).to be false
+    expect(verifier.verify(manifest).errors.count).to eq 1
   end
 
   it "detects name mismatch" do
@@ -50,19 +45,55 @@ describe Verifier do
     verifier = Verifier.new settings
 
     manifest = handler.manifest("awesomelib")
-    verifier.verify(manifest).valid?.should be_true
+    expect(verifier.verify(manifest).valid?).to be true
     
     manifest["filename"] = "wrongname"
-    verifier.verify(manifest).valid?.should be_false
+    expect(verifier.verify(manifest).valid?).to be false
+  end
+
+  it "verifies release manifest file" do
+    filename = File.join settings.manifest_path, awesomelib_manifest_file
+    
+    verifier = Verifier.new settings
+
+    expect( verifier.verify_file( filename ).valid? ).to be true
+  end
+
+  it "verifies generic manifest file" do
+    filename = File.join settings.manifest_path, newlib_manifest_file
+    
+    verifier = Verifier.new settings
+
+    verification_result = verifier.verify_file( filename )
+    expect( verification_result.valid? ).to be true
   end
+  
+  it "verifies proprietary release manifest file" do
+    filename = File.join settings.manifest_path, proprietarylib_manifest_file
+    
+    verifier = Verifier.new settings
 
-  it "verifies file" do
-    filename = File.join settings.manifest_path,
-      "awesomelib/awesomelib.2013-09-08.manifest"
+    verification_result = verifier.verify_file( filename )
+    expect( verification_result.valid? ).to be true
+  end
+  
+  it "verifies schema" do
+    manifest = Hash.new
+    manifest["name"] = "mylib"
+    manifest["release_date"] = "2013-02-28"
+    manifest["filename"] = "mylib.2013-02-28.manifest"
+    manifest["libraryname"] = "mylib"
+    manifest["$schema"] = "http://inqlude.org/schema/release-manifest-v1#"
+    manifest["schema_type"] = "release"
+    manifest["schema_version"] = 1
     
     verifier = Verifier.new settings
+    
+    errors = verifier.verify(manifest).errors
 
-    expect( verifier.verify_file( filename ).valid? ).to be_true
+    expect( errors.class ).to be Array
+    expect(errors[0]).to match /^Schema validation error/
+    expect(errors.count).to eq 8
   end
   
 end