inline_translation 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 53cc9b45fed24636013c2424b96e2660bc225e03
-  data.tar.gz: 281e7519500a96ca6d8d45574c9b1c65b3e85da0
+  metadata.gz: 1712a04eec4217093462a4e8ce98265646adf6d5
+  data.tar.gz: 03182eb9ece86002f1334fdd89c4cba98e4f760b
 SHA512:
-  metadata.gz: 031e8bed2799e0e519dc759a468bfe016aae4680cda3648d5ebe69ad46b96fbfeb08eafb25bacab3489748b432b33043cce51626b4eda68aebfcc6eb6e062db1
-  data.tar.gz: b34f21a4917721af118d9a3eb924094957b48682a888f819646bd7e7313e9e94e10a9125bca2d67ab50d0a88e893a3157fffb15c125a343aee4c9e09b4b29878
+  metadata.gz: 6d18f77ae8291f105db60da48524990b5566c7038bb92402a16d166e0618618dc97fcc054d41fceffe6de15dbfc26362354c1a9e0f31d973205b1f53e873180b
+  data.tar.gz: df2bcc2e4a0f4e8d399598d9ce316d31ecab1ab519a14a0a7dd7c9ac36a3c231b6816c6d8d0b8584a886505fc7a7398b8b776d03a6ab4a04c95e7bcd2d665057

data/test/babbel_integration_test.rb

@@ -14,7 +14,7 @@ class InlineTranslationIntegrationTest < IntegrationTest
 
     describe "creating translations" do
       it "can create translations" do
-        post :create, translatable_type: "IntegrationModel", translatable_id: model.id, to: :fr
+        post :create, translatable_type: "IntegrationModel", translatable_id: model.id, to: :fr, format: :json
 
         created = Translation.where(translatable_type: "IntegrationModel")
 
@@ -23,6 +23,11 @@ class InlineTranslationIntegrationTest < IntegrationTest
         assert_equal created.where(translatable_type: "IntegrationModel").size, 2
         assert_equal created.where(translation: "this is a translation").size, 1
         assert_equal created.where(translation: "this is another translation").size, 1
+
+
+        before_count = Translation.count
+        post :create, translatable_type: "IntegrationModel", translatable_id: model.id, to: :fr, format: :json
+        assert_equal Translation.count, before_count
       end
     end
   end

data/test/lib/controllers/translations_controller_test.rb

@@ -14,41 +14,47 @@ class TranslationsControllerTest < ControllerTest
     end
 
     describe "POST create" do
-      it "returns the translation for successful translation for JS" do
+      it "returns the translation for successful translation for JSON" do
         InlineTranslation.stubs(:ready?).returns(true)
         InlineTranslation::Translators::Null.any_instance.stubs(:can_translate?).returns(true)
         InlineTranslation::Translators::Null.any_instance.stubs(:translate).returns("A translation!")
-        post :create, translatable_type: "ControllerModel", translatable_id: translatable.id, format: :js
+        post :create, translatable_type: "ControllerModel", translatable_id: translatable.id, format: :json
 
         assert_equal response.status, 200
         json = JSON.parse(response.body)
 
-        assert_equal json['translations']['column1'], translation_result[:column1]
-        assert_equal json['translations']['column2'], translation_result[:column2]
-        assert_equal json['translatable_id'], translatable.id.to_s
-        assert_equal json['translatable_type'], 'ControllerModel'
+        assert_equal json.length, translatable.translations.size
+        fields =             json.map { |t| t['field'] }
+        translatable_ids =   json.map { |t| t['translatable_id'] }
+        translatable_types = json.map { |t| t['translatable_type'] }
+
+        assert_includes fields, 'column1'
+        assert_includes fields, 'column2'
+        assert_includes translatable_ids, translatable.id
+        assert_includes translatable_types, 'ControllerModel'
       end
 
-      it "returns the translation for successful translation for JSON" do
-        InlineTranslation.stubs(:ready?).returns(true)
+      it "returns the translation for successful translation for JS" do
+        # TODO: stub out the call to render, which errors because we don't have a translations#create view
+        skip "Stub out render call so there's no 'cannot find translations#create view' error"
         InlineTranslation::Translators::Null.any_instance.stubs(:can_translate?).returns(true)
         InlineTranslation::Translators::Null.any_instance.stubs(:translate).returns("A translation!")
-        post :create, translatable_type: "ControllerModel", translatable_id: translatable.id, format: :json
+        ActionView::Renderer.any_instance.stubs(:render).with('translations/create').returns('wark')
+        post :create, translatable_type: "ControllerModel", translatable_id: translatable.id, format: :js
 
         assert_equal response.status, 200
-        assert_template 'translations/create'
       end
 
 
       it "returns unprocessable entity for unsuccessful translation" do
         InlineTranslation::Services::TranslationService.any_instance.stubs(:translate).returns(false)
-        post :create, translatable_type: "ControllerModel", translatable_id: translatable.id
+        post :create, translatable_type: "ControllerModel", translatable_id: translatable.id, format: :json
         assert_equal response.status, 422
       end
 
       it "returns unprocessable entity when translatable_type is not defined" do
         InlineTranslation::Services::TranslationService.any_instance.stubs(:translate).returns(false)
-        post :create
+        post :create, format: :json
         assert_equal response.status, 422
       end
     end

data/test/lib/generators/babbel_generator_install_test.rb

@@ -14,4 +14,9 @@ class InlineTranslationGeneratorInstallTest < Rails::Generators::TestCase
     run_generator
     assert_file "config/initializers/inline_translation.rb"
   end
+
+  test "generates a create js view file" do
+    run_generator
+    assert_file "app/views/translations/create.js.erb"
+  end
 end

data/test/lib/helpers/translations_helper_test.rb

@@ -50,7 +50,7 @@ class TranslationsHelperTest < UnitTest
     end
 
     it "returns a span with a InlineTranslation class" do
-      assert_match /InlineTranslation-translated/, translated_element_for(model, :column1)
+      assert_match /inline-translation-translated/, translated_element_for(model, :column1)
     end
 
     it "accepts an element parameter" do

data/test/lib/services/translation_service_test.rb

@@ -34,18 +34,6 @@ class InlineTranslationTranslationServiceTest < UnitTest
     end
   end
 
-  describe "translations_for" do
-    it "returns the translations for a given translatable" do
-      translatable.save
-      translatable.translations.create field: :column1, translation: 'Bon oui!', language: :fr
-      translatable.translations.create field: :column2, translation: 'Mon ser!', language: :fr
-      result = service.translations_for(translatable, to: :fr)
-      translatable.translations.each do |translation|
-        assert_equal result[translation.field], translation.translation
-      end
-    end
-  end
-
   describe "translate" do
     it "returns the results of translate!" do
       service.stubs(:translate!).returns("translation result")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: inline_translation
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - James Kiesel (gdpelican)
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-08 00:00:00.000000000 Z
+date: 2015-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bing_translator