inline_svg 1.8.0 → 1.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 23a2c45f1e25e4266196f0e2fc23a4384cb8513be840d2b676ae848b5be1d121
-  data.tar.gz: 8fdb1090f9037ed6c732469ffda28023e200d758533223d4bd9c85b5a20cfb72
+  metadata.gz: 66214539304b60e87e9263afb26531212492ca77957e9ce8cf89d015cef86239
+  data.tar.gz: 6ab9cb3d75a9f268728600edb48bf27b3503145c80f1addabe8bc484c88af545
 SHA512:
-  metadata.gz: c3d98f05ba0b9ea222d1b852f87f30584ba4b775d7b6848a2366341e5e85bb6c9912bc1f8441117d129db4d63506d54dcd8ef4d633a5140359e25f5a829a8a1c
-  data.tar.gz: 45eb7d5c8a30f0814e9c775924690825ad3b3ee9c3ada3c9694bf3af46499ababaa1ba81f696514e08dc09aa5ae6520094820fc528ee34fbb307b856dc16b3f4
+  metadata.gz: 1f8d4642dff97eb5bfc358fd1ce2257d5113a6f232c02f4ecd847007ee861b2537748539c689e5e2e67297951fdd158594740a754d49469cbd8c13c72002c290
+  data.tar.gz: 1b5cb2dfd5e7067d64ec0cc3449c2aeeead3a39cab42f8d51db33609a296478511fa9a24a965e32b10d7f01c98e5cb4b2ef8a6268fb055a7ad968068499eccd6

data/.github/workflows/integration_test.yml

@@ -4,11 +4,11 @@ on: [push]
 
 jobs:
   build:
-
     runs-on: ubuntu-latest
     strategy:
       matrix:
         test-branch: [rails5, rails6, rails7]
+    timeout-minutes: 20
     steps:
     - name: Checkout
       uses: actions/checkout@v2
@@ -19,9 +19,9 @@ jobs:
         ref: ${{ matrix.test-branch }}
         path: test_app
     - name: Set up Ruby 2.7
-      uses: actions/setup-ruby@v1
+      uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.7.x
+        ruby-version: 2.7.7
     - name: Build local gem
       run: |
         gem install bundler

data/.github/workflows/rails_6_webpacker_integration_tests.yaml

@@ -18,10 +18,10 @@ jobs:
         repository: jamesmartin/inline_svg_test_app
         ref: ${{ matrix.test-branch }}
         path: test_app
-    - name: Set up Ruby 2.7
-      uses: actions/setup-ruby@v1
+    - name: Set up Ruby 3.1
+      uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.7.x
+        ruby-version: 3.1
     - name: Build local gem
       run: |
         gem install bundler
@@ -46,10 +46,14 @@ jobs:
       with:
         node-version: 16
       if: matrix.test-branch == 'rails6-webpacker'
+    - name: Set up Python 2.7
+      uses: actions/setup-python@v4
+      with:
+        python-version: '2.7'
     - name: Generate Webpacker config
       run: |
         cd $GITHUB_WORKSPACE/test_app
-        yarn install --check-files
+        CXXFLAGS="--std=c++17" yarn install --check-files
         bundle exec rake webpacker:compile
       if: matrix.test-branch == 'rails6-webpacker'
     - name: Test

data/.github/workflows/ruby.yml

@@ -9,10 +9,10 @@ jobs:
 
     steps:
     - uses: actions/checkout@v2
-    - name: Set up Ruby 2.6
-      uses: actions/setup-ruby@v1
+    - name: Set up Ruby 2.7
+      uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.6.x
+        ruby-version: 2.7.7
     - name: Build and test with Rake
       run: |
         gem install bundler

data/CHANGELOG.md

@@ -6,6 +6,24 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 Nothing.
 
+## [1.10.0] - 2024-09-03
+### Added
+- Support for Shakapacker.  [#158](https://github.com/jamesmartin/inline_svg/pull/158). Thanks, [@tagliala](https://github.com/tagliala)
+
+### Fixed
+- Fixed documentation typos.  [#157](https://github.com/jamesmartin/inline_svg/pull/157). Thanks, [@tagliala](https://github.com/tagliala)
+- Fixed missing ActiveSupport require.  [#152](https://github.com/jamesmartin/inline_svg/pull/152). Thanks, [@xymbol](https://github.com/xymbol)
+- Remove wrapping whitespace from SVG tags.  [#150](https://github.com/jamesmartin/inline_svg/pull/150). Thanks, [@fredboyle](https://github.com/fredboyle)
+
+## [1.9.0] - 2023-03-29
+### Added
+- A new option: `view_box` adds a `viewBox` attribute to the SVG. [#142](https://github.com/jamesmartin/inline_svg/pull/142). Thanks [@sunny](https://github.com/sunny)
+
+### Fixed
+- Allow Propshaft assets to use fallbacks. [#140](https://github.com/jamesmartin/inline_svg/pull/140). Thanks, [@ohrite](https://github.com/ohrite)
+- Handling missing file when using static assets. [#141](https://github.com/jamesmartin/inline_svg/pull/141). Thanks, [@leighhalliday](https://github.com/leighhalliday)
+- Handle missing file when using Webpacker assets.
+
 ## [1.8.0] - 2022-01-09
 ### Added
 - Remove deprecation warning for `inline_svg`, as we intend to keep it in 2.0. [#131](https://github.com/jamesmartin/inline_svg/pull/131). Thanks [@DanielJackson-Oslo](https://github.com/DanielJackson-Oslo)
@@ -203,7 +221,7 @@ transformations](https://github.com/jamesmartin/inline_svg/blob/master/README.md
 
 ## [0.5.1] - 2015-03-30
 ### Warning
-** This version is NOT comaptible with Sprockets >= 3. **
+** This version is NOT compatible with Sprockets >= 3. **
 
 ### Fixed
 - Support for ActiveSupport (and hence, Rails) 4.2.x. Thanks, @jmarceli.
@@ -244,7 +262,8 @@ transformations](https://github.com/jamesmartin/inline_svg/blob/master/README.md
 ### Added
 - Basic Railtie and view helper to inline SVG documents to Rails views.
 
-[unreleased]: https://github.com/jamesmartin/inline_svg/compare/v1.8.0...HEAD
+[unreleased]: https://github.com/jamesmartin/inline_svg/compare/v1.9.0...HEAD
+[1.9.0]: https://github.com/jamesmartin/inline_svg/compare/v1.8.0...v1.9.0
 [1.8.0]: https://github.com/jamesmartin/inline_svg/compare/v1.7.2...v1.8.0
 [1.7.2]: https://github.com/jamesmartin/inline_svg/compare/v1.7.1...v1.7.2
 [1.7.1]: https://github.com/jamesmartin/inline_svg/compare/v1.7.0...v1.7.1

data/README.md

@@ -14,7 +14,7 @@ Inline SVG supports:
 
 - [Rails 5](http://weblog.rubyonrails.org/2016/6/30/Rails-5-0-final/) (from [v0.10.0](https://github.com/jamesmartin/inline_svg/releases/tag/v0.10.0))
 - [Rails 6](https://weblog.rubyonrails.org/2019/4/24/Rails-6-0-rc1-released/) with Sprockets or Webpacker (from [v1.5.2](https://github.com/jamesmartin/inline_svg/releases/tag/v1.5.2)).
-- [Rails 7](https://weblog.rubyonrails.org/2021/12/6/Rails-7-0-rc-1-released/) (experimental)
+- [Rails 7](https://weblog.rubyonrails.org/2021/12/6/Rails-7-0-rc-1-released/)
 
 Inline SVG no longer officially supports Rails 3 or Rails 4 (although they may still work). In order to reduce the maintenance cost of this project we now follow the [Rails Maintenance Policy](https://guides.rubyonrails.org/maintenance_policy.html).
 
@@ -97,6 +97,7 @@ key                     | description
 `desc`                  | add a \<desc\> node inside the top level of the SVG document
 `nocomment`             | remove comment tags from the SVG document
 `preserve_aspect_ratio` | adds a `preserveAspectRatio` attribute to the SVG
+`view_box`              | adds a `viewBox` attribute to the SVG
 `aria`                  | adds common accessibility attributes to the SVG (see [PR #34](https://github.com/jamesmartin/inline_svg/pull/34#issue-152062674) for details)
 `aria_hidden`           | adds the `aria-hidden=true` attribute to the SVG
 `fallback`              | set fallback SVG document
@@ -114,6 +115,7 @@ inline_svg_tag(
   desc: 'Some description',
   nocomment: true,
   preserve_aspect_ratio: 'xMaxYMax meet',
+  view_box: '0 0 100 100',
   aria: true,
   aria_hidden: true,
   fallback: 'fallback-document.svg'

data/lib/inline_svg/propshaft_asset_finder.rb

@@ -9,7 +9,8 @@ module InlineSvg
     end
 
     def pathname
-      ::Rails.application.assets.load_path.find(@filename).path
+      asset_path = ::Rails.application.assets.load_path.find(@filename)
+      asset_path.path unless asset_path.nil?
     end
   end
 end

data/lib/inline_svg/static_asset_finder.rb

@@ -16,7 +16,8 @@ module InlineSvg
 
     def pathname
       if ::Rails.application.config.assets.compile
-        Pathname.new(::Rails.application.assets[@filename].filename)
+        asset = ::Rails.application.assets[@filename]
+        Pathname.new(asset.filename) if asset.present?
       else
         manifest = ::Rails.application.assets_manifest
         asset_path = manifest.assets[@filename]

data/lib/inline_svg/transform_pipeline/transformations/view_box.rb

@@ -0,0 +1,9 @@
+module InlineSvg::TransformPipeline::Transformations
+  class ViewBox < Transformation
+    def transform(doc)
+      with_svg(doc) do |svg|
+        svg["viewBox"] = value
+      end
+    end
+  end
+end

data/lib/inline_svg/transform_pipeline/transformations.rb

@@ -10,11 +10,12 @@ module InlineSvg::TransformPipeline::Transformations
       class: { transform: ClassAttribute },
       style: { transform: StyleAttribute },
       data: { transform: DataAttributes },
-      height: { transform: Height },
       nocomment: { transform: NoComment },
       preserve_aspect_ratio: { transform: PreserveAspectRatio },
       size: { transform: Size },
       width: { transform: Width },
+      height: { transform: Height },
+      view_box: { transform: ViewBox },
     }
   end
 
@@ -83,8 +84,9 @@ require 'inline_svg/transform_pipeline/transformations/description'
 require 'inline_svg/transform_pipeline/transformations/size'
 require 'inline_svg/transform_pipeline/transformations/height'
 require 'inline_svg/transform_pipeline/transformations/width'
+require 'inline_svg/transform_pipeline/transformations/view_box'
 require 'inline_svg/transform_pipeline/transformations/id_attribute'
 require 'inline_svg/transform_pipeline/transformations/data_attributes'
 require 'inline_svg/transform_pipeline/transformations/preserve_aspect_ratio'
 require 'inline_svg/transform_pipeline/transformations/aria_attributes'
-require "inline_svg/transform_pipeline/transformations/aria_hidden_attribute"
+require "inline_svg/transform_pipeline/transformations/aria_hidden_attribute"

data/lib/inline_svg/transform_pipeline.rb

@@ -4,7 +4,7 @@ module InlineSvg
       document = Nokogiri::XML::Document.parse(svg_file)
       Transformations.lookup(transform_params).reduce(document) do |doc, transformer|
         transformer.transform(doc)
-      end.to_html
+      end.to_html.strip
     end
   end
 end

data/lib/inline_svg/version.rb

@@ -1,3 +1,3 @@
 module InlineSvg
-  VERSION = "1.8.0"
+  VERSION = "1.10.0"
 end

data/lib/inline_svg/webpack_asset_finder.rb

@@ -6,21 +6,31 @@ module InlineSvg
 
     def initialize(filename)
       @filename = filename
-      @asset_path = URI(Webpacker.manifest.lookup(@filename)).path
+      manifest_lookup = asset_helper.manifest.lookup(@filename)
+      @asset_path =  manifest_lookup.present? ? URI(manifest_lookup).path : ""
     end
 
     def pathname
       return if @asset_path.blank?
 
-      if Webpacker.dev_server.running?
+      if asset_helper.dev_server.running?
         dev_server_asset(@asset_path)
-      elsif Webpacker.config.public_path.present?
-        File.join(Webpacker.config.public_path, @asset_path)
+      elsif asset_helper.config.public_path.present?
+        File.join(asset_helper.config.public_path, @asset_path)
       end
     end
 
     private
 
+    def asset_helper
+      @asset_helper ||=
+        if defined?(::Shakapacker)
+          ::Shakapacker
+        else
+          ::Webpacker
+        end
+    end
+
     def dev_server_asset(file_path)
       asset = fetch_from_dev_server(file_path)
 
@@ -37,8 +47,8 @@ module InlineSvg
     end
 
     def fetch_from_dev_server(file_path)
-      http = Net::HTTP.new(Webpacker.dev_server.host, Webpacker.dev_server.port)
-      http.use_ssl = Webpacker.dev_server.https?
+      http = Net::HTTP.new(asset_helper.dev_server.host, asset_helper.dev_server.port)
+      http.use_ssl = asset_helper.dev_server.protocol == "https"
       http.verify_mode = OpenSSL::SSL::VERIFY_NONE
 
       http.request(Net::HTTP::Get.new(file_path)).body

data/lib/inline_svg.rb

@@ -10,6 +10,8 @@ require "inline_svg/transform_pipeline"
 require "inline_svg/io_resource"
 
 require "inline_svg/railtie" if defined?(Rails)
+require 'active_support'
+require 'active_support/core_ext/object/blank'
 require 'active_support/core_ext/string'
 require 'nokogiri'
 

data/spec/helpers/inline_svg_spec.rb

@@ -86,9 +86,7 @@ describe InlineSvg::ActionView::Helpers do
             with('missing.svg').
             and_raise(InlineSvg::AssetFile::FileNotFound.new)
 
-          fallback_file = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>
-SVG
+          fallback_file = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>'
           allow(InlineSvg::AssetFile).to receive(:named).with('fallback.svg').and_return(fallback_file)
           expect(helper.send(helper_method, 'missing.svg', fallback: 'fallback.svg')).to eq fallback_file
         end
@@ -99,9 +97,7 @@ SVG
 
       context "and no options" do
         it "returns a html safe version of the file's contents" do
-          example_file = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>
-SVG
+          example_file = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>'
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(example_file)
           expect(helper.send(helper_method, 'some-file')).to eq example_file
         end
@@ -109,12 +105,8 @@ SVG
 
       context "and the 'title' option" do
         it "adds the title node to the SVG output" do
-          input_svg = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"></svg>
-SVG
-          expected_output = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"><title>A title</title></svg>
-SVG
+          input_svg = '<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"></svg>'
+          expected_output = '<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"><title>A title</title></svg>'
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
           expect(helper.send(helper_method, 'some-file', title: 'A title')).to eq expected_output
         end
@@ -122,12 +114,8 @@ SVG
 
       context "and the 'desc' option" do
         it "adds the description node to the SVG output" do
-          input_svg = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"></svg>
-SVG
-          expected_output = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"><desc>A description</desc></svg>
-SVG
+          input_svg = '<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"></svg>'
+          expected_output = '<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"><desc>A description</desc></svg>'
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
           expect(helper.send(helper_method, 'some-file', desc: 'A description')).to eq expected_output
         end
@@ -135,12 +123,8 @@ SVG
 
       context "and the 'nocomment' option" do
         it "strips comments and other unknown/unsafe nodes from the output" do
-          input_svg = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>
-SVG
-          expected_output = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"></svg>
-SVG
+          input_svg = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>'
+          expected_output = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"></svg>'
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
           expect(helper.send(helper_method, 'some-file', nocomment: true)).to eq expected_output
         end
@@ -148,12 +132,8 @@ SVG
 
       context "and the 'aria_hidden' option" do
         it "sets 'aria-hidden=true' in the output" do
-          input_svg = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"></svg>
-SVG
-          expected_output = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en" aria-hidden="true"></svg>
-SVG
+          input_svg = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"></svg>'
+          expected_output = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en" aria-hidden="true"></svg>'
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
           expect(helper.send(helper_method, 'some-file', aria_hidden: true)).to eq expected_output
         end
@@ -161,12 +141,8 @@ SVG
 
       context "and all options" do
         it "applies all expected transformations to the output" do
-          input_svg = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>
-SVG
-          expected_output = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><title>A title</title><desc>A description</desc></svg>
-SVG
+          input_svg = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>'
+          expected_output = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><title>A title</title><desc>A description</desc></svg>'
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
           expect(helper.send(helper_method, 'some-file', title: 'A title', desc: 'A description', nocomment: true)).to eq expected_output
         end
@@ -184,12 +160,8 @@ SVG
         end
 
         it "applies custm transformations to the output" do
-          input_svg = <<-SVG
-<svg></svg>
-SVG
-          expected_output = <<-SVG
-<svg custom="some value"></svg>
-SVG
+          input_svg = '<svg></svg>'
+          expected_output = '<svg custom="some value"></svg>'
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
           expect(helper.send(helper_method, 'some-file', custom: 'some value')).to eq expected_output
         end
@@ -212,7 +184,7 @@ SVG
 
             allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
 
-            expect(helper.send(helper_method, 'some-file')).to eq "<svg custom=\"default value\"></svg>\n"
+            expect(helper.send(helper_method, 'some-file')).to eq "<svg custom=\"default value\"></svg>"
           end
         end
 
@@ -222,7 +194,7 @@ SVG
 
             allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
 
-            expect(helper.send(helper_method, 'some-file', custom: 'some value')).to eq "<svg custom=\"some value\"></svg>\n"
+            expect(helper.send(helper_method, 'some-file', custom: 'some value')).to eq "<svg custom=\"some value\"></svg>"
           end
         end
       end
@@ -251,17 +223,27 @@ SVG
         expect(InlineSvg::IOResource).to receive(:===).with(io_object).and_return(true)
         expect(InlineSvg::IOResource).to receive(:read).with(io_object).and_return("<svg><!-- Test IO --></svg>")
         output = helper.send(helper_method, io_object)
-        expect(output).to eq "<svg><!-- Test IO --></svg>\n"
+        expect(output).to eq "<svg><!-- Test IO --></svg>"
         expect(output).to be_html_safe
       end
 
       it 'return valid svg for file' do
         output = helper.send(helper_method, File.new(file_path))
-        expect(output).to eq "<svg xmlns=\"http://www.w3.org/2000/svg\" xml:lang=\"en\" role=\"presentation\"><!-- This is a test comment --></svg>\n"
+        expect(output).to eq "<svg xmlns=\"http://www.w3.org/2000/svg\" xml:lang=\"en\" role=\"presentation\"><!-- This is a test comment --></svg>"
         expect(output).to be_html_safe
       end
 
     end
+    
+    context 'default output' do
+      it "returns an SVG tag without any pre or post whitespace characters" do
+        input_svg = '<svg></svg>'
+        
+        allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
+        
+        expect(helper.send(helper_method, 'some-file')).to eq "<svg></svg>"
+      end
+    end
   end
 
   describe '#inline_svg' do

data/spec/inline_svg_spec.rb

@@ -47,7 +47,7 @@ describe InlineSvg do
     end
 
     context "configuring a custom asset file" do
-      it "falls back to the built-in asset file implementation by deafult" do
+      it "falls back to the built-in asset file implementation by default" do
         expect(InlineSvg.configuration.asset_file).to eq(InlineSvg::AssetFile)
       end
 

data/spec/propshaft_asset_finder_spec.rb

@@ -0,0 +1,23 @@
+require_relative '../lib/inline_svg'
+
+describe InlineSvg::PropshaftAssetFinder do
+  context "when the file is not found" do
+    it "returns nil" do
+      stub_const('Rails', double('Rails').as_null_object)
+      expect(::Rails.application.assets.load_path).to receive(:find).with('some-file').and_return(nil)
+
+      expect(InlineSvg::PropshaftAssetFinder.find_asset('some-file').pathname).to be_nil
+    end
+  end
+
+  context "when the file is found" do
+    it "returns fully qualified file paths from Propshaft" do
+      stub_const('Rails', double('Rails').as_null_object)
+      asset = double('Asset')
+      expect(asset).to receive(:path).and_return(Pathname.new('/full/path/to/some-file'))
+      expect(::Rails.application.assets.load_path).to receive(:find).with('some-file').and_return(asset)
+
+      expect(InlineSvg::PropshaftAssetFinder.find_asset('some-file').pathname).to eq Pathname('/full/path/to/some-file')
+    end
+  end
+end

data/spec/static_asset_finder_spec.rb

@@ -0,0 +1,25 @@
+require_relative '../lib/inline_svg'
+
+describe InlineSvg::StaticAssetFinder do
+  context "when the file is not found" do
+    it "returns nil" do
+      stub_const('Rails', double('Rails').as_null_object)
+      expect(::Rails.application.config.assets).to receive(:compile).and_return(true)
+
+      expect(described_class.find_asset('some-file').pathname).to be_nil
+    end
+  end
+
+  context "when the file is found" do
+    it "returns fully qualified file path from Sprockets" do
+      stub_const('Rails', double('Rails').as_null_object)
+      expect(::Rails.application.config.assets).to receive(:compile).and_return(true)
+      pathname = Pathname.new('/full/path/to/some-file')
+      asset = double('Asset')
+      expect(asset).to receive(:filename).and_return(pathname)
+      expect(::Rails.application.assets).to receive(:[]).with('some-file').and_return(asset)
+
+      expect(described_class.find_asset('some-file').pathname).to eq(pathname)
+    end
+  end
+end

data/spec/transformation_pipeline/transformations/view_box_spec.rb

@@ -0,0 +1,13 @@
+require 'inline_svg/transform_pipeline'
+
+describe InlineSvg::TransformPipeline::Transformations::ViewBox do
+  it "adds viewBox attribute to a SVG document" do
+    document = Nokogiri::XML::Document.parse('<svg>Some document</svg>')
+    transformation =
+      InlineSvg::TransformPipeline::Transformations::ViewBox
+        .create_with_value("0 0 100 100")
+    expect(transformation.transform(document).to_html).to eq(
+      "<svg viewBox=\"0 0 100 100\">Some document</svg>\n"
+    )
+  end
+end

data/spec/transformation_pipeline/transformations_spec.rb

@@ -21,6 +21,7 @@ describe InlineSvg::TransformPipeline::Transformations do
         size: 'irrelevant',
         height: 'irrelevant',
         width: 'irrelevant',
+        view_box: 'irrelevant',
         id: 'irrelevant',
         data: 'irrelevant',
         preserve_aspect_ratio: 'irrelevant',
@@ -37,6 +38,7 @@ describe InlineSvg::TransformPipeline::Transformations do
         InlineSvg::TransformPipeline::Transformations::Size,
         InlineSvg::TransformPipeline::Transformations::Height,
         InlineSvg::TransformPipeline::Transformations::Width,
+        InlineSvg::TransformPipeline::Transformations::ViewBox,
         InlineSvg::TransformPipeline::Transformations::IdAttribute,
         InlineSvg::TransformPipeline::Transformations::DataAttributes,
         InlineSvg::TransformPipeline::Transformations::PreserveAspectRatio,

data/spec/webpack_asset_finder_spec.rb

@@ -0,0 +1,23 @@
+require_relative '../lib/inline_svg'
+
+describe InlineSvg::WebpackAssetFinder do
+  context "when the file is not found" do
+    it "returns nil" do
+      stub_const('Rails', double('Rails').as_null_object)
+      stub_const('Webpacker', double('Webpacker').as_null_object)
+      expect(::Webpacker.manifest).to receive(:lookup).with('some-file').and_return(nil)
+
+      expect(described_class.find_asset('some-file').pathname).to be_nil
+    end
+  end
+
+  context "when Shakapacker is defined" do
+    it "uses the new spelling" do
+      stub_const('Rails', double('Rails').as_null_object)
+      stub_const('Shakapacker', double('Shakapacker').as_null_object)
+      expect(::Shakapacker.manifest).to receive(:lookup).with('some-file').and_return(nil)
+
+      expect(described_class.find_asset('some-file').pathname).to be_nil
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: inline_svg
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.10.0
 platform: ruby
 authors:
 - James Martin
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-01-09 00:00:00.000000000 Z
+date: 2024-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -167,6 +167,7 @@ files:
 - lib/inline_svg/transform_pipeline/transformations/style_attribute.rb
 - lib/inline_svg/transform_pipeline/transformations/title.rb
 - lib/inline_svg/transform_pipeline/transformations/transformation.rb
+- lib/inline_svg/transform_pipeline/transformations/view_box.rb
 - lib/inline_svg/transform_pipeline/transformations/width.rb
 - lib/inline_svg/version.rb
 - lib/inline_svg/webpack_asset_finder.rb
@@ -184,6 +185,8 @@ files:
 - spec/id_generator_spec.rb
 - spec/inline_svg_spec.rb
 - spec/io_resource_spec.rb
+- spec/propshaft_asset_finder_spec.rb
+- spec/static_asset_finder_spec.rb
 - spec/transformation_pipeline/transformations/aria_attributes_spec.rb
 - spec/transformation_pipeline/transformations/aria_hidden_attribute_spec.rb
 - spec/transformation_pipeline/transformations/class_attribute_spec.rb
@@ -196,13 +199,15 @@ files:
 - spec/transformation_pipeline/transformations/style_attribute_spec.rb
 - spec/transformation_pipeline/transformations/title_spec.rb
 - spec/transformation_pipeline/transformations/transformation_spec.rb
+- spec/transformation_pipeline/transformations/view_box_spec.rb
 - spec/transformation_pipeline/transformations/width_spec.rb
 - spec/transformation_pipeline/transformations_spec.rb
+- spec/webpack_asset_finder_spec.rb
 homepage: https://github.com/jamesmartin/inline_svg
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -217,8 +222,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: Embeds an SVG document, inline.
 test_files:
@@ -236,6 +241,8 @@ test_files:
 - spec/id_generator_spec.rb
 - spec/inline_svg_spec.rb
 - spec/io_resource_spec.rb
+- spec/propshaft_asset_finder_spec.rb
+- spec/static_asset_finder_spec.rb
 - spec/transformation_pipeline/transformations/aria_attributes_spec.rb
 - spec/transformation_pipeline/transformations/aria_hidden_attribute_spec.rb
 - spec/transformation_pipeline/transformations/class_attribute_spec.rb
@@ -248,5 +255,7 @@ test_files:
 - spec/transformation_pipeline/transformations/style_attribute_spec.rb
 - spec/transformation_pipeline/transformations/title_spec.rb
 - spec/transformation_pipeline/transformations/transformation_spec.rb
+- spec/transformation_pipeline/transformations/view_box_spec.rb
 - spec/transformation_pipeline/transformations/width_spec.rb
 - spec/transformation_pipeline/transformations_spec.rb
+- spec/webpack_asset_finder_spec.rb