inline_svg 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9af50a1ce42f8f67f9df531b740b4d0f8adedc2b
-  data.tar.gz: 4c4399fffe814ff7587851cefd33deb3cb1910ce
+  metadata.gz: a9a81169096b9823dbcfa1c77af928523339ae95
+  data.tar.gz: 6d04934494ecd9a788a6eeef697abf4571d5accb
 SHA512:
-  metadata.gz: d0facb0d977943f429edd52e7ac6307b3c092dd53a16bd694214048157a3b128cbdd6eb8c168f9a71889837a4427e30b1e97ffffd4b55fd353c87e6aae798fca
-  data.tar.gz: 1e3e2fe9c6f563bd654fbbba92a216eef5efa340f2d755807ad2934d4b1bccf1bb70877f8ee74e2e1c5192aa8edef894f175f19890c76e6882eeec9e25deab48
+  metadata.gz: a94a7a7478d42bb94162461b548741aa5ca04ffa962b1a32aafa60432670226e9b79065493fe932cc18b0f5182d3b66899b919a683d00177308705740dd2e2d3
+  data.tar.gz: 46920e1ee1bacc5f3225a61c3391c3457c278888346507fbee50f4e4ce9e4bf800bec1e76f7c1a060aa331220e4afde349de289c1a454756f34813927e611a64

data/.rubocop.yml

@@ -0,0 +1 @@
+inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -0,0 +1,421 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-10-10 17:17:56 -0400 using RuboCop version 0.50.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 17
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: leading, trailing
+Layout/DotPosition:
+  Exclude:
+    - 'spec/finds_asset_paths_spec.rb'
+    - 'spec/helpers/inline_svg_spec.rb'
+    - 'spec/id_generator_spec.rb'
+    - 'spec/transformation_pipeline/transformations/aria_attributes_spec.rb'
+    - 'spec/transformation_pipeline/transformations/data_attributes_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Layout/EmptyLineAfterMagicComment:
+  Exclude:
+    - 'inline_svg.gemspec'
+    - 'spec/cached_asset_file_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowAdjacentOneLineDefs, NumberOfEmptyLines.
+Layout/EmptyLineBetweenDefs:
+  Exclude:
+    - 'spec/inline_svg_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/EmptyLinesAroundAccessModifier:
+  Exclude:
+    - 'lib/inline_svg/cached_asset_file.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty_lines, no_empty_lines
+Layout/EmptyLinesAroundBlockBody:
+  Exclude:
+    - 'spec/helpers/inline_svg_spec.rb'
+    - 'spec/inline_svg_spec.rb'
+    - 'spec/io_resource_spec.rb'
+    - 'spec/transformation_pipeline/transformations_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
+Layout/EmptyLinesAroundClassBody:
+  Exclude:
+    - 'lib/inline_svg.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles, IndentationWidth.
+# SupportedStyles: special_inside_parentheses, consistent, align_brackets
+Layout/IndentArray:
+  EnforcedStyle: consistent
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
+Layout/IndentHeredoc:
+  Exclude:
+    - 'spec/helpers/inline_svg_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/LeadingCommentSpace:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: aligned, indented, indented_relative_to_receiver
+Layout/MultilineMethodCallIndentation:
+  Exclude:
+    - 'spec/transformation_pipeline/transformations/data_attributes_spec.rb'
+    - 'spec/transformation_pipeline/transformations/style_attribute_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles.
+# SupportedStyles: space, no_space
+Layout/SpaceAroundEqualsInParameterDefault:
+  EnforcedStyle: no_space
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces, SpaceBeforeBlockParameters.
+# SupportedStyles: space, no_space
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideBlockBraces:
+  Exclude:
+    - 'lib/inline_svg/transform_pipeline/transformations.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Layout/SpaceInsideBrackets:
+  Exclude:
+    - 'lib/inline_svg.rb'
+
+# Offense count: 20
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces.
+# SupportedStyles: space, no_space, compact
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideHashLiteralBraces:
+  Exclude:
+    - 'spec/helpers/inline_svg_spec.rb'
+    - 'spec/inline_svg_spec.rb'
+    - 'spec/transformation_pipeline/transformations/data_attributes_spec.rb'
+    - 'spec/transformation_pipeline/transformations_spec.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Layout/SpaceInsideParens:
+  Exclude:
+    - 'lib/inline_svg/transform_pipeline/transformations.rb'
+    - 'spec/helpers/inline_svg_spec.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Layout/TrailingWhitespace:
+  Exclude:
+    - 'spec/io_resource_spec.rb'
+
+# Offense count: 2
+Lint/AmbiguousOperator:
+  Exclude:
+    - 'spec/io_resource_spec.rb'
+
+# Offense count: 2
+Lint/ShadowingOuterLocalVariable:
+  Exclude:
+    - 'lib/inline_svg/transform_pipeline/transformations/description.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/title.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/UnneededSplatExpansion:
+  Exclude:
+    - 'lib/inline_svg.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
+Lint/UnusedBlockArgument:
+  Exclude:
+    - 'lib/inline_svg/railtie.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+Lint/UnusedMethodArgument:
+  Exclude:
+    - 'spec/inline_svg_spec.rb'
+
+# Offense count: 2
+Lint/UselessAssignment:
+  Exclude:
+    - 'spec/cached_asset_file_spec.rb'
+    - 'spec/transformation_pipeline/transformations/transformation_spec.rb'
+
+# Offense count: 1
+Metrics/AbcSize:
+  Max: 17
+
+# Offense count: 20
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 169
+
+# Offense count: 144
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 183
+
+# Offense count: 3
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 14
+
+# Offense count: 6
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, normalcase, non_integer
+Naming/VariableNumber:
+  Exclude:
+    - 'spec/cached_asset_file_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Performance/StringReplacement:
+  Exclude:
+    - 'lib/inline_svg/transform_pipeline/transformations/data_attributes.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: always, conditionals
+Style/AndOr:
+  Exclude:
+    - 'lib/inline_svg/cached_asset_file.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining
+# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
+# FunctionalMethods: let, let!, subject, watch
+# IgnoredMethods: lambda, proc, it
+Style/BlockDelimiters:
+  Exclude:
+    - 'lib/inline_svg/transform_pipeline/transformations.rb'
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: braces, no_braces, context_dependent
+Style/BracesAroundHashParameters:
+  Exclude:
+    - 'lib/inline_svg/transform_pipeline/transformations.rb'
+    - 'spec/helpers/inline_svg_spec.rb'
+    - 'spec/inline_svg_spec.rb'
+    - 'spec/transformation_pipeline/transformations/data_attributes_spec.rb'
+    - 'spec/transformation_pipeline/transformations_spec.rb'
+
+# Offense count: 6
+Style/CaseEquality:
+  Exclude:
+    - 'lib/inline_svg/action_view/helpers.rb'
+    - 'spec/io_resource_spec.rb'
+
+# Offense count: 14
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: nested, compact
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'lib/inline_svg/transform_pipeline/transformations.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/aria_attributes.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/class_attribute.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/data_attributes.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/description.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/height.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/id_attribute.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/no_comment.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/preserve_aspect_ratio.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/size.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/style_attribute.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/title.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/transformation.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/width.rb'
+
+# Offense count: 26
+Style/Documentation:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/EachWithObject:
+  Exclude:
+    - 'lib/inline_svg/transform_pipeline/transformations.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, AutoCorrectEncodingComment.
+# SupportedStyles: when_needed, always, never
+Style/Encoding:
+  Exclude:
+    - 'inline_svg.gemspec'
+
+# Offense count: 4
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'lib/inline_svg.rb'
+    - 'lib/inline_svg/action_view/helpers.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+Style/HashSyntax:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: MaxLineLength.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'lib/inline_svg/static_asset_finder.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/aria_attributes.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: InverseMethods, InverseBlocks.
+Style/InverseMethods:
+  Exclude:
+    - 'lib/inline_svg/transform_pipeline/transformations.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/MutableConstant:
+  Exclude:
+    - 'lib/inline_svg/asset_file.rb'
+    - 'lib/inline_svg/version.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: Whitelist.
+# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
+Style/NestedParenthesizedCalls:
+  Exclude:
+    - 'spec/io_resource_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: IncludeSemanticChanges.
+Style/NonNilCheck:
+  Exclude:
+    - 'lib/inline_svg/transform_pipeline/transformations.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'inline_svg.gemspec'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles.
+# SupportedStyles: compact, exploded
+Style/RaiseArgs:
+  EnforcedStyle: compact
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantBegin:
+  Exclude:
+    - 'lib/inline_svg.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+Style/RedundantSelf:
+  Exclude:
+    - 'lib/inline_svg/transform_pipeline/transformations/data_attributes.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/height.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/id_attribute.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/preserve_aspect_ratio.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/size.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/transformation.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/width.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+  Exclude:
+    - 'spec/transformation_pipeline/transformations/transformation_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: use_perl_names, use_english_names
+Style/SpecialGlobalVars:
+  Exclude:
+    - 'inline_svg.gemspec'
+
+# Offense count: 280
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoredMethods.
+# IgnoredMethods: respond_to, define_method
+Style/SymbolProc:
+  Exclude:
+    - 'lib/inline_svg/transform_pipeline/transformations/description.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/no_comment.rb'
+    - 'lib/inline_svg/transform_pipeline/transformations/title.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline, SupportedStylesForMultiline.
+# SupportedStylesForMultiline: comma, consistent_comma, no_comma
+Style/TrailingCommaInArguments:
+  Exclude:
+    - 'spec/transformation_pipeline/transformations_spec.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline, SupportedStylesForMultiline.
+# SupportedStylesForMultiline: comma, consistent_comma, no_comma
+Style/TrailingCommaInLiteral:
+  Exclude:
+    - 'lib/inline_svg/transform_pipeline/transformations.rb'
+    - 'spec/transformation_pipeline/transformations_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/UnneededPercentQ:
+  Exclude:
+    - 'inline_svg.gemspec'

data/CHANGELOG.md

@@ -5,6 +5,36 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 ## [Unreleased][unreleased]
 - Nothing
 
+## [1.2.4] - 2017-10-30
+### Added
+- Aria hidden attribute
+  [#78](https://github.com/jamesmartin/inline_svg/pull/78)
+  and [#79](https://github.com/jamesmartin/inline_svg/pull/79)
+- In-line CSS style attribute
+  [#71](https://github.com/jamesmartin/inline_svg/pull/71)
+
+### Fixed
+- Make aria ID attributes unique
+  [#77](https://github.com/jamesmartin/inline_svg/pull/77)
+
+## [1.2.3] - 2017-08-17
+### Fixed
+- Handle UTF-8 characters in SVG documents
+  [#60](https://github.com/jamesmartin/inline_svg/pull/69)
+
+## [1.2.2] - 2017-07-06
+### Fixed
+- Handle malformed documents that don't contain a root SVG element
+  [#60](https://github.com/jamesmartin/inline_svg/pull/65)
+### Added
+- Add configurable CSS class to empty SVG document
+  [#67](https://github.com/jamesmartin/inline_svg/pull/67)
+
+## [1.2.1] - 2017-05-02
+### Fixed
+- Select most exactly matching cached asset file when multiple files match
+  given asset name [#64](https://github.com/jamesmartin/inline_svg/pull/64)
+
 ## [1.2.0] - 2017-04-20
 ### Added
 - Cached asset file (load assets into memory at boot time)
@@ -154,7 +184,11 @@ transformations](https://github.com/jamesmartin/inline_svg/blob/master/README.md
 ### Added
 - Basic Railtie and view helper to inline SVG documents to Rails views.
 
-[unreleased]: https://github.com/jamesmartin/inline_svg/compare/v1.2.0...HEAD
+[unreleased]: https://github.com/jamesmartin/inline_svg/compare/v1.2.4...HEAD
+[1.2.4]: https://github.com/jamesmartin/inline_svg/compare/v1.2.3...v1.2.4
+[1.2.3]: https://github.com/jamesmartin/inline_svg/compare/v1.2.2...v1.2.3
+[1.2.2]: https://github.com/jamesmartin/inline_svg/compare/v1.2.1...v1.2.2
+[1.2.1]: https://github.com/jamesmartin/inline_svg/compare/v1.2.0...v1.2.1
 [1.2.0]: https://github.com/jamesmartin/inline_svg/compare/v1.1.0...v1.2.0
 [1.1.0]: https://github.com/jamesmartin/inline_svg/compare/v1.0.1...v1.1.0
 [1.0.1]: https://github.com/jamesmartin/inline_svg/compare/v1.0.0...v1.0.1

data/README.md

@@ -1,6 +1,6 @@
 # Inline SVG
 
-[![CircleCI](https://circleci.com/gh/jamesmartin/inline_svg.svg?style=svg)](https://circleci.com/gh/jamesmartin/inline_svg)
+[![Build Status](https://travis-ci.org/jamesmartin/inline_svg.svg?branch=master)](https://travis-ci.org/jamesmartin/inline_svg)
 
 Styling a SVG document with CSS for use on the web is most reliably achieved by
 [adding classes to the document and
@@ -71,12 +71,13 @@ blue:
 }
 ```
 
-## Options 
+## Options
 
 key                     | description
-:---------------------- | :---------- 
+:---------------------- | :----------
 `id`                    | set a ID attribute on the SVG
 `class`                 | set a CSS class attribute on the SVG
+`style`                 | set a CSS style attribute on the SVG
 `data`                  | add data attributes to the SVG (supply as a hash)
 `size`                  | set width and height attributes on the SVG <br/> Can also be set using `height` and/or `width` attributes, which take precedence over `size` <br/> Supplied as "{Width} * {Height}" or "{Number}", so "30px\*45px" becomes `width="30px"` and `height="45px"`, and "50%" becomes `width="50%"` and `height="50%"`
 `title`                 | add a \<title\> node inside the top level of the SVG document
@@ -84,12 +85,24 @@ key                     | description
 `nocomment`             | remove comment tags from the SVG document
 `preserve_aspect_ratio` | adds a `preserveAspectRatio` attribute to the SVG
 `aria`                  | adds common accessibility attributes to the SVG (see [PR #34](https://github.com/jamesmartin/inline_svg/pull/34#issue-152062674) for details)
+`aria_hidden`           | adds the `aria-hidden=true` attribute to the SVG
 
 Example:
 
 ```ruby
-inline_svg("some-document.svg", id: 'some-id', class: 'some-class', data: {some: "value"}, size: '30% * 20%', title: 'Some Title', desc:
-'Some description', nocomment: true, preserve_aspect_ratio: 'xMaxYMax meet', aria: true)
+inline_svg(
+  "some-document.svg",
+  id: 'some-id',
+  class: 'some-class',
+  data: {some: "value"},
+  size: '30% * 20%',
+  title: 'Some Title',
+  desc: 'Some description',
+  nocomment: true,
+  preserve_aspect_ratio: 'xMaxYMax meet',
+  aria: true,
+  aria_hidden: true
+)
 ```
 
 ## Accessibility
@@ -133,10 +146,9 @@ For example, inherit from `InlineSvg::CustomTransformation` and implement the `#
 
 class MyCustomTransform < InlineSvg::CustomTransformation
   def transform(doc)
-    doc = Nokogiri::XML::Document.parse(doc.to_html)
-    svg = doc.at_css 'svg'
-    svg['custom'] = value
-    doc
+    with_svg(doc) do |svg|
+      svg["custom"] = value
+    end
   end
 end
 ```
@@ -257,6 +269,31 @@ end
 restricted to as few paths as possible, and using the filter option to further
 restrict assets to only those likely to be used by `inline_svg`.
 
+## Missing SVG Files
+
+If the specified SVG file cannot be found a helpful, empty SVG document is
+embedded into the page instead. The embedded document contains a single comment
+displaying the filename of the SVG image the helper tried to render:
+
+```html
+<svg><!-- SVG file not found: 'some-missing-file.svg' --></svg>
+```
+
+You may apply a class to this empty SVG document by specifying the following
+configuration:
+
+```rb
+InlineSvg.configure do |config|
+  config.svg_not_found_css_class = 'svg-not-found'
+end
+```
+
+Which would instead render:
+
+```html
+<svg class='svg-not-found'><!-- SVG file not found: 'some-missing-file.svg' --></svg>
+```
+
 ## Contributing
 
 1. Fork it ( [http://github.com/jamesmartin/inline_svg/fork](http://github.com/jamesmartin/inline_svg/fork) )

data/Rakefile

@@ -1 +1,8 @@
 require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+
+RSpec::Core::RakeTask.new(:spec) do |t|
+  t.pattern = Dir.glob("spec/**/*_spec.rb")
+  #t.rspec_opts = "--format documentation"
+end
+task :default => :spec

data/inline_svg.gemspec

@@ -23,6 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 3.2"
   spec.add_development_dependency "rspec_junit_formatter", "0.2.2"
   spec.add_development_dependency "pry"
+  spec.add_development_dependency "rubocop"
 
   spec.add_runtime_dependency "activesupport", ">= 3.0"
   spec.add_runtime_dependency "nokogiri", ">= 1.6"

data/lib/inline_svg/action_view/helpers.rb

@@ -6,13 +6,17 @@ module InlineSvg
     module Helpers
       def inline_svg(filename, transform_params={})
         begin
-          svg_file = if InlineSvg::IOResource === filename
-            InlineSvg::IOResource.read filename
-          else
-            configured_asset_file.named filename
-          end
+          svg_file = read_svg(filename)
         rescue InlineSvg::AssetFile::FileNotFound
-          return "<svg><!-- SVG file not found: '#{filename}' #{extension_hint(filename)}--></svg>".html_safe
+          return placeholder(filename) unless transform_params[:fallback].present?
+
+          if transform_params[:fallback].present?
+            begin
+              svg_file = read_svg(transform_params[:fallback])
+            rescue InlineSvg::AssetFile::FileNotFound
+              placeholder(filename)
+            end
+          end
         end
 
         InlineSvg::TransformPipeline.generate_html_from(svg_file, transform_params).html_safe
@@ -20,6 +24,25 @@ module InlineSvg
 
       private
 
+      def read_svg(filename)
+        if InlineSvg::IOResource === filename
+          InlineSvg::IOResource.read filename
+        else
+          configured_asset_file.named filename
+        end
+      end
+
+      def placeholder(filename)
+        css_class = InlineSvg.configuration.svg_not_found_css_class
+        not_found_message = "'#{filename}' #{extension_hint(filename)}"
+
+        if css_class.nil?
+          return "<svg><!-- SVG file not found: #{not_found_message}--></svg>".html_safe
+        else
+          return "<svg class='#{css_class}'><!-- SVG file not found: #{not_found_message}--></svg>".html_safe
+        end
+      end
+
       def configured_asset_file
         InlineSvg.configuration.asset_file
       end

data/lib/inline_svg/cached_asset_file.rb

@@ -31,11 +31,25 @@ module InlineSvg
     end
 
     private
-    # Internal: Finds the key for a given asset name (using a Regex).
+    # Internal: Finds the key for a given asset name (using a Regex). In the
+    # event of an ambiguous asset_name matching multiple assets, this method
+    # ranks the matches by their full file path, choosing the shortest (most
+    # exact) match over all others.
     #
-    # Returns a String representing the key for the named asset.
+    # Returns a String representing the key for the named asset or nil if there
+    # is no match.
     def key_for_asset(asset_name)
-      assets.keys.map { |k| k.to_s }.select { |k| /#{asset_name}/.match(k) }.first
+      match = all_keys_matching(asset_name).sort do |a, b|
+        a.string.size <=> b.string.size
+      end.first
+      match && match.string
+    end
+
+    # Internal: Find all potential asset keys matching the given asset name.
+    #
+    # Returns an array of MatchData objects for keys matching the asset name.
+    def all_keys_matching(asset_name)
+      assets.keys.map { |k| /(#{asset_name})/.match(k.to_s) }.compact
     end
 
     # Internal: Recursively descends through current_paths reading each file it