inline_svg 1.0.0 → 1.10.0

data/spec/files/static_assets/assets0/known-document.svg

@@ -0,0 +1 @@
+<svg>interesting content</svg>

data/spec/files/static_assets/assets0/some-document.svg

@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"><path d="M3.273 7.151l-2.917-2.916c-.23.665-.356 1.361-.356 2.057 0 1.608.624 3.216 1.851 4.442 1.35 1.351 3.163 1.957 4.928 1.821.933-.072 1.851.268 2.513.93l9.646 9.646c.58.579 1.338.869 2.097.869 1.636 0 2.965-1.326 2.965-2.965 0-.759-.29-1.518-.868-2.097l-9.647-9.646c-.661-.662-1.002-1.581-.93-2.514.136-1.766-.47-3.578-1.821-4.928-.372-.372-.778-.686-1.209-.945l-6.252 6.246zm18.727 13.849c0 .552-.448 1-1 1s-1-.448-1-1 .448-1 1-1 1 .447 1 1zm-12.153-13.396l-3.061 3.061-2.566-2.567 3.062-3.061 2.565 2.567zm-.933.096l-.762.761-1.705-1.705.762-.762 1.705 1.706zm-2.991-.42l-.761.762 1.706 1.705.762-.762-1.707-1.705zm2.484-6.903l-2.893 2.893-2.412-2.412c.953-.556 2.044-.858 3.165-.858.707 0 1.425.12 2.128.373l.012.004z"/></svg>

data/spec/files/static_assets/assets1/known-document.svg

@@ -0,0 +1 @@
+<svg>Another known document</svg>

data/spec/files/static_assets/assets1/other-document.svg

@@ -0,0 +1,3 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
+<svg>Other document</svg>

data/spec/files/static_assets/assets1/some-file.txt

@@ -0,0 +1 @@
+Some file contents.

data/spec/finds_asset_paths_spec.rb

@@ -45,4 +45,49 @@ describe InlineSvg::FindsAssetPaths do
       expect(InlineSvg::FindsAssetPaths.by_filename('some-file')).to be_nil
     end
   end
+
+  context "when propshaft finder returns an object which supports only the pathname method" do
+    it "returns fully qualified file paths from Propshaft" do
+      propshaft = double('PropshaftDouble')
+
+      expect(propshaft).to receive(:find_asset).with('some-file').
+        and_return(double(pathname: Pathname('/full/path/to/some-file')))
+
+      InlineSvg.configure do |config|
+        config.asset_finder = propshaft
+      end
+
+      expect(InlineSvg::FindsAssetPaths.by_filename('some-file')).to eq Pathname('/full/path/to/some-file')
+    end
+  end
+
+  context "when webpack finder returns an object with a relative asset path" do
+    it "returns the fully qualified file path" do
+      webpacker = double('WebpackerDouble')
+
+      expect(webpacker).to receive(:find_asset).with('some-file').
+        and_return(double(filename: Pathname('/full/path/to/some-file')))
+
+      InlineSvg.configure do |config|
+        config.asset_finder = webpacker
+      end
+
+      expect(InlineSvg::FindsAssetPaths.by_filename('some-file')).to eq Pathname('/full/path/to/some-file')
+    end
+  end
+
+  context "when webpack finder returns an object with an absolute http asset path" do
+    it "returns the fully qualified file path" do
+      webpacker = double('WebpackerDouble')
+
+      expect(webpacker).to receive(:find_asset).with('some-file').
+        and_return(double(filename: Pathname('https://my-fancy-domain.test/full/path/to/some-file')))
+
+      InlineSvg.configure do |config|
+        config.asset_finder = webpacker
+      end
+
+      expect(InlineSvg::FindsAssetPaths.by_filename('some-file')).to eq Pathname('https://my-fancy-domain.test/full/path/to/some-file')
+    end
+  end
 end

data/spec/helpers/inline_svg_spec.rb

@@ -13,90 +13,138 @@ describe InlineSvg::ActionView::Helpers do
 
   let(:helper) { ( Class.new { include InlineSvg::ActionView::Helpers } ).new }
 
-  describe "#inline_svg" do
-    
+  shared_examples "inline_svg helper" do |helper_method:|
+
     context "when passed the name of an SVG that does not exist" do
+      after(:each) do
+        InlineSvg.reset_configuration!
+      end
+
+      context "and configured to raise" do
+        it "raises an exception" do
+          InlineSvg.configure do |config|
+            config.raise_on_file_not_found = true
+          end
+
+          allow(InlineSvg::AssetFile).to receive(:named).
+            with('some-missing-file.svg').
+            and_raise(InlineSvg::AssetFile::FileNotFound.new)
+
+          expect {
+            helper.send(helper_method, 'some-missing-file.svg')
+          }.to raise_error(InlineSvg::AssetFile::FileNotFound)
+        end
+      end
+
       it "returns an empty, html safe, SVG document as a placeholder" do
         allow(InlineSvg::AssetFile).to receive(:named).
           with('some-missing-file.svg').
           and_raise(InlineSvg::AssetFile::FileNotFound.new)
 
-        output = helper.inline_svg('some-missing-file.svg')
+        output = helper.send(helper_method, 'some-missing-file.svg')
         expect(output).to eq "<svg><!-- SVG file not found: 'some-missing-file.svg' --></svg>"
         expect(output).to be_html_safe
       end
 
+      it "escapes malicious input" do
+        malicious = "--></svg><script>alert(1)</script><svg>.svg"
+        allow(InlineSvg::AssetFile).to receive(:named).
+          with(malicious).
+          and_raise(InlineSvg::AssetFile::FileNotFound.new)
+
+        output = helper.send(helper_method, malicious)
+        expect(output).to eq "<svg><!-- SVG file not found: '--&gt;&lt;/svg&gt;&lt;script&gt;alert(1)&lt;/script&gt;&lt;svg&gt;.svg' --></svg>"
+        expect(output).to be_html_safe
+      end
+
       it "gives a helpful hint when no .svg extension is provided in the filename" do
         allow(InlineSvg::AssetFile).to receive(:named).
           with('missing-file-with-no-extension').
           and_raise(InlineSvg::AssetFile::FileNotFound.new)
 
-        output = helper.inline_svg('missing-file-with-no-extension')
+        output = helper.send(helper_method, 'missing-file-with-no-extension')
         expect(output).to eq "<svg><!-- SVG file not found: 'missing-file-with-no-extension' (Try adding .svg to your filename) --></svg>"
       end
+
+      it "allows the CSS class on the empty SVG document to be changed" do
+        InlineSvg.configure do |config|
+          config.svg_not_found_css_class = 'missing-svg'
+        end
+
+        allow(InlineSvg::AssetFile).to receive(:named).
+          with('some-other-missing-file.svg').
+          and_raise(InlineSvg::AssetFile::FileNotFound.new)
+
+        output = helper.send(helper_method, 'some-other-missing-file.svg')
+        expect(output).to eq "<svg class='missing-svg'><!-- SVG file not found: 'some-other-missing-file.svg' --></svg>"
+        expect(output).to be_html_safe
+      end
+
+      context "and a fallback that does exist" do
+        it "displays the fallback" do
+          allow(InlineSvg::AssetFile).to receive(:named).
+            with('missing.svg').
+            and_raise(InlineSvg::AssetFile::FileNotFound.new)
+
+          fallback_file = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>'
+          allow(InlineSvg::AssetFile).to receive(:named).with('fallback.svg').and_return(fallback_file)
+          expect(helper.send(helper_method, 'missing.svg', fallback: 'fallback.svg')).to eq fallback_file
+        end
+      end
     end
 
     context "when passed an existing SVG file" do
 
       context "and no options" do
         it "returns a html safe version of the file's contents" do
-          example_file = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>
-SVG
+          example_file = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>'
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(example_file)
-          expect(helper.inline_svg('some-file')).to eq example_file
+          expect(helper.send(helper_method, 'some-file')).to eq example_file
         end
       end
 
       context "and the 'title' option" do
         it "adds the title node to the SVG output" do
-          input_svg = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"></svg>
-SVG
-          expected_output = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"><title>A title</title></svg>
-SVG
+          input_svg = '<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"></svg>'
+          expected_output = '<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"><title>A title</title></svg>'
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
-          expect(helper.inline_svg('some-file', title: 'A title')).to eq expected_output
+          expect(helper.send(helper_method, 'some-file', title: 'A title')).to eq expected_output
         end
       end
 
       context "and the 'desc' option" do
         it "adds the description node to the SVG output" do
-          input_svg = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"></svg>
-SVG
-          expected_output = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"><desc>A description</desc></svg>
-SVG
+          input_svg = '<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"></svg>'
+          expected_output = '<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"><desc>A description</desc></svg>'
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
-          expect(helper.inline_svg('some-file', desc: 'A description')).to eq expected_output
+          expect(helper.send(helper_method, 'some-file', desc: 'A description')).to eq expected_output
         end
       end
 
       context "and the 'nocomment' option" do
         it "strips comments and other unknown/unsafe nodes from the output" do
-          input_svg = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>
-SVG
-          expected_output = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"></svg>
-SVG
+          input_svg = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>'
+          expected_output = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"></svg>'
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
-          expect(helper.inline_svg('some-file', nocomment: true)).to eq expected_output
+          expect(helper.send(helper_method, 'some-file', nocomment: true)).to eq expected_output
+        end
+      end
+
+      context "and the 'aria_hidden' option" do
+        it "sets 'aria-hidden=true' in the output" do
+          input_svg = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"></svg>'
+          expected_output = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en" aria-hidden="true"></svg>'
+          allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
+          expect(helper.send(helper_method, 'some-file', aria_hidden: true)).to eq expected_output
         end
       end
 
       context "and all options" do
         it "applies all expected transformations to the output" do
-          input_svg = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>
-SVG
-          expected_output = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><title>A title</title><desc>A description</desc></svg>
-SVG
+          input_svg = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>'
+          expected_output = '<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><title>A title</title><desc>A description</desc></svg>'
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
-          expect(helper.inline_svg('some-file', title: 'A title', desc: 'A description', nocomment: true)).to eq expected_output
+          expect(helper.send(helper_method, 'some-file', title: 'A title', desc: 'A description', nocomment: true)).to eq expected_output
         end
       end
 
@@ -112,14 +160,10 @@ SVG
         end
 
         it "applies custm transformations to the output" do
-          input_svg = <<-SVG
-<svg></svg>
-SVG
-          expected_output = <<-SVG
-<svg custom="some value"></svg>
-SVG
+          input_svg = '<svg></svg>'
+          expected_output = '<svg custom="some value"></svg>'
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
-          expect(helper.inline_svg('some-file', custom: 'some value')).to eq expected_output
+          expect(helper.send(helper_method, 'some-file', custom: 'some value')).to eq expected_output
         end
       end
 
@@ -140,7 +184,7 @@ SVG
 
             allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
 
-            expect(helper.inline_svg('some-file')).to eq "<svg custom=\"default value\"></svg>\n"
+            expect(helper.send(helper_method, 'some-file')).to eq "<svg custom=\"default value\"></svg>"
           end
         end
 
@@ -150,7 +194,7 @@ SVG
 
             allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
 
-            expect(helper.inline_svg('some-file', custom: 'some value')).to eq "<svg custom=\"some value\"></svg>\n"
+            expect(helper.send(helper_method, 'some-file', custom: 'some value')).to eq "<svg custom=\"some value\"></svg>"
           end
         end
       end
@@ -162,13 +206,13 @@ SVG
         expect(InlineSvg::IOResource).to receive(:===).with(argument).and_return(true)
         expect(InlineSvg::IOResource).to receive(:read).with(argument)
         expect(InlineSvg::AssetFile).to_not receive(:named)
-        helper.inline_svg(argument)
+        helper.send(helper_method, argument)
       end
       it 'accept filename' do
         expect(InlineSvg::IOResource).to receive(:===).with(argument).and_return(false)
         expect(InlineSvg::IOResource).to_not receive(:read)
         expect(InlineSvg::AssetFile).to receive(:named).with(argument)
-        helper.inline_svg(argument)
+        helper.send(helper_method, argument)
       end
     end
     context 'when passed IO object argument' do
@@ -178,17 +222,39 @@ SVG
       it 'return valid svg' do
         expect(InlineSvg::IOResource).to receive(:===).with(io_object).and_return(true)
         expect(InlineSvg::IOResource).to receive(:read).with(io_object).and_return("<svg><!-- Test IO --></svg>")
-        output = helper.inline_svg(io_object)
-        expect(output).to eq "<svg><!-- Test IO --></svg>\n"
+        output = helper.send(helper_method, io_object)
+        expect(output).to eq "<svg><!-- Test IO --></svg>"
         expect(output).to be_html_safe
       end
 
       it 'return valid svg for file' do
-        output = helper.inline_svg(File.new(file_path))
-        expect(output).to eq "<svg xmlns=\"http://www.w3.org/2000/svg\" xml:lang=\"en\" role=\"presentation\"><!-- This is a test comment --></svg>\n"
+        output = helper.send(helper_method, File.new(file_path))
+        expect(output).to eq "<svg xmlns=\"http://www.w3.org/2000/svg\" xml:lang=\"en\" role=\"presentation\"><!-- This is a test comment --></svg>"
         expect(output).to be_html_safe
       end
 
     end
+    
+    context 'default output' do
+      it "returns an SVG tag without any pre or post whitespace characters" do
+        input_svg = '<svg></svg>'
+        
+        allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
+        
+        expect(helper.send(helper_method, 'some-file')).to eq "<svg></svg>"
+      end
+    end
+  end
+
+  describe '#inline_svg' do
+    it_behaves_like "inline_svg helper", helper_method: :inline_svg
+  end
+
+  describe '#inline_svg_tag' do
+    it_behaves_like "inline_svg helper", helper_method: :inline_svg_tag
+  end
+
+  describe '#inline_svg_tag' do
+    it_behaves_like "inline_svg helper", helper_method: :inline_svg_pack_tag
   end
 end

data/spec/id_generator_spec.rb

@@ -1,8 +1,10 @@
 require_relative '../lib/inline_svg/id_generator'
 
 describe InlineSvg::IdGenerator do
-  it "generates a hexencoded ID based on a salt" do
-    expect(InlineSvg::IdGenerator.generate("some-base", "some-salt")).
-      to eq("ksiuuy1jduycacqpoj5smn2kyt9iv02")
+  it "generates a hexencoded ID based on a salt and a random value" do
+    randomizer = -> { "some-random-value" }
+
+    expect(InlineSvg::IdGenerator.generate("some-base", "some-salt", randomness: randomizer)).
+      to eq("at2c17mkqnvopy36iccxspura7wnreqf")
   end
 end

data/spec/inline_svg_spec.rb

@@ -13,6 +13,10 @@ class MyInvalidCustomTransformInstance
   def self.create_with_value(value); end
 end
 
+class MyCustomAssetFile
+  def self.named(filename); end
+end
+
 describe InlineSvg do
   describe "configuration" do
     context "when a block is not given" do
@@ -42,6 +46,50 @@ describe InlineSvg do
       end
     end
 
+    context "configuring a custom asset file" do
+      it "falls back to the built-in asset file implementation by default" do
+        expect(InlineSvg.configuration.asset_file).to eq(InlineSvg::AssetFile)
+      end
+
+      it "adds a collaborator that meets the interface specification" do
+        InlineSvg.configure do |config|
+          config.asset_file = MyCustomAssetFile
+        end
+
+        expect(InlineSvg.configuration.asset_file).to eq MyCustomAssetFile
+      end
+
+      it "rejects a collaborator that does not conform to the interface spec" do
+        bad_asset_file = double("bad_asset_file")
+
+        expect do
+          InlineSvg.configure do |config|
+            config.asset_file = bad_asset_file
+          end
+        end.to raise_error(InlineSvg::Configuration::Invalid, /asset_file should implement the #named method/)
+      end
+
+      it "rejects a collaborator that implements the correct interface with the wrong arity" do
+        bad_asset_file = double("bad_asset_file", named: nil)
+
+        expect do
+          InlineSvg.configure do |config|
+            config.asset_file = bad_asset_file
+          end
+        end.to raise_error(InlineSvg::Configuration::Invalid, /asset_file should implement the #named method with arity 1/)
+      end
+    end
+
+    context "configuring the default svg-not-found class" do
+      it "sets the class name" do
+        InlineSvg.configure do |config|
+          config.svg_not_found_css_class = 'missing-svg'
+        end
+
+        expect(InlineSvg.configuration.svg_not_found_css_class).to eq 'missing-svg'
+      end
+    end
+
     context "configuring custom transformation" do
       it "allows a custom transformation to be added" do
         InlineSvg.configure do |config|

data/spec/propshaft_asset_finder_spec.rb

@@ -0,0 +1,23 @@
+require_relative '../lib/inline_svg'
+
+describe InlineSvg::PropshaftAssetFinder do
+  context "when the file is not found" do
+    it "returns nil" do
+      stub_const('Rails', double('Rails').as_null_object)
+      expect(::Rails.application.assets.load_path).to receive(:find).with('some-file').and_return(nil)
+
+      expect(InlineSvg::PropshaftAssetFinder.find_asset('some-file').pathname).to be_nil
+    end
+  end
+
+  context "when the file is found" do
+    it "returns fully qualified file paths from Propshaft" do
+      stub_const('Rails', double('Rails').as_null_object)
+      asset = double('Asset')
+      expect(asset).to receive(:path).and_return(Pathname.new('/full/path/to/some-file'))
+      expect(::Rails.application.assets.load_path).to receive(:find).with('some-file').and_return(asset)
+
+      expect(InlineSvg::PropshaftAssetFinder.find_asset('some-file').pathname).to eq Pathname('/full/path/to/some-file')
+    end
+  end
+end

data/spec/static_asset_finder_spec.rb

@@ -0,0 +1,25 @@
+require_relative '../lib/inline_svg'
+
+describe InlineSvg::StaticAssetFinder do
+  context "when the file is not found" do
+    it "returns nil" do
+      stub_const('Rails', double('Rails').as_null_object)
+      expect(::Rails.application.config.assets).to receive(:compile).and_return(true)
+
+      expect(described_class.find_asset('some-file').pathname).to be_nil
+    end
+  end
+
+  context "when the file is found" do
+    it "returns fully qualified file path from Sprockets" do
+      stub_const('Rails', double('Rails').as_null_object)
+      expect(::Rails.application.config.assets).to receive(:compile).and_return(true)
+      pathname = Pathname.new('/full/path/to/some-file')
+      asset = double('Asset')
+      expect(asset).to receive(:filename).and_return(pathname)
+      expect(::Rails.application.assets).to receive(:[]).with('some-file').and_return(asset)
+
+      expect(described_class.find_asset('some-file').pathname).to eq(pathname)
+    end
+  end
+end

data/spec/transformation_pipeline/transformations/aria_attributes_spec.rb

@@ -1,8 +1,8 @@
-require 'inline_svg/transform_pipeline'
+require "inline_svg/transform_pipeline"
 
 describe InlineSvg::TransformPipeline::Transformations::AriaAttributes do
   it "adds a role attribute to the SVG document" do
-    document = Nokogiri::XML::Document.parse('<svg>Some document</svg>')
+    document = Nokogiri::XML::Document.parse("<svg>Some document</svg>")
     transformation = InlineSvg::TransformPipeline::Transformations::AriaAttributes.create_with_value({})
 
     expect(transformation.transform(document).to_html).to eq(
@@ -12,7 +12,7 @@ describe InlineSvg::TransformPipeline::Transformations::AriaAttributes do
 
   context "aria-labelledby attribute" do
     it "adds 'title' when a title element is present" do
-      document = Nokogiri::XML::Document.parse('<svg><title>Some title</title>Some document</svg>')
+      document = Nokogiri::XML::Document.parse("<svg><title>Some title</title>Some document</svg>")
       transformation = InlineSvg::TransformPipeline::Transformations::AriaAttributes.create_with_value(true)
 
       expect(InlineSvg::IdGenerator).to receive(:generate).with("title", "Some title").
@@ -24,7 +24,7 @@ describe InlineSvg::TransformPipeline::Transformations::AriaAttributes do
     end
 
     it "adds 'desc' when a description element is present" do
-      document = Nokogiri::XML::Document.parse('<svg><desc>Some description</desc>Some document</svg>')
+      document = Nokogiri::XML::Document.parse("<svg><desc>Some description</desc>Some document</svg>")
       transformation = InlineSvg::TransformPipeline::Transformations::AriaAttributes.create_with_value(true)
 
       expect(InlineSvg::IdGenerator).to receive(:generate).with("desc", "Some description").
@@ -36,7 +36,7 @@ describe InlineSvg::TransformPipeline::Transformations::AriaAttributes do
     end
 
     it "adds both 'desc' and 'title' when title and description elements are present" do
-      document = Nokogiri::XML::Document.parse('<svg><title>Some title</title><desc>Some description</desc>Some document</svg>')
+      document = Nokogiri::XML::Document.parse("<svg><title>Some title</title><desc>Some description</desc>Some document</svg>")
       transformation = InlineSvg::TransformPipeline::Transformations::AriaAttributes.create_with_value(true)
 
       expect(InlineSvg::IdGenerator).to receive(:generate).with("title", "Some title").
@@ -50,7 +50,7 @@ describe InlineSvg::TransformPipeline::Transformations::AriaAttributes do
     end
 
     it "uses existing IDs when they exist" do
-      document = Nokogiri::XML::Document.parse('<svg><title id="my-title">Some title</title><desc id="my-desc">Some description</desc>Some document</svg>')
+      document = Nokogiri::XML::Document.parse("<svg><title id='my-title'>Some title</title><desc id='my-desc'>Some description</desc>Some document</svg>")
       transformation = InlineSvg::TransformPipeline::Transformations::AriaAttributes.create_with_value(true)
 
       expect(InlineSvg::IdGenerator).to receive(:generate).with("my-title", "Some title").

data/spec/transformation_pipeline/transformations/aria_hidden_attribute_spec.rb

@@ -0,0 +1,12 @@
+require 'inline_svg/transform_pipeline'
+
+describe InlineSvg::TransformPipeline::Transformations::AriaHiddenAttribute do
+  it "adds an aria-hidden='true' attribute to a SVG document" do
+    document = Nokogiri::XML::Document.parse('<svg>Some document</svg>')
+    transformation = InlineSvg::TransformPipeline::Transformations::AriaHiddenAttribute.create_with_value(true)
+
+    expect(transformation.transform(document).to_html).to eq(
+      "<svg aria-hidden=\"true\">Some document</svg>\n"
+    )
+  end
+end

data/spec/transformation_pipeline/transformations/height_spec.rb

@@ -9,4 +9,13 @@ describe InlineSvg::TransformPipeline::Transformations::Height do
       "<svg height=\"5%\">Some document</svg>\n"
     )
   end
+
+  it "handles documents without SVG root elements" do
+    document = Nokogiri::XML::Document.parse("<foo>bar</foo><svg>Some document</svg>")
+    transformation = InlineSvg::TransformPipeline::Transformations::Height.create_with_value("5%")
+
+    expect(transformation.transform(document).to_html).to eq(
+      "<foo>bar</foo>\n"
+    )
+  end
 end

data/spec/transformation_pipeline/transformations/style_attribute_spec.rb

@@ -0,0 +1,26 @@
+require "inline_svg/transform_pipeline"
+
+describe InlineSvg::TransformPipeline::Transformations::ClassAttribute do
+  it "adds a style attribute to a SVG document" do
+    document = Nokogiri::XML::Document.parse('<svg>Some document</svg>')
+    transformation =
+      InlineSvg::TransformPipeline::Transformations::StyleAttribute
+        .create_with_value("padding: 10px")
+
+    expect(transformation.transform(document).to_html).to eq(
+      "<svg style=\"padding: 10px\">Some document</svg>\n"
+    )
+  end
+
+  it "preserves existing style attributes on a SVG document" do
+    xml = '<svg style="fill: red">Some document</svg>'
+    document = Nokogiri::XML::Document.parse(xml)
+    transformation =
+      InlineSvg::TransformPipeline::Transformations::StyleAttribute
+        .create_with_value("padding: 10px")
+
+    expect(transformation.transform(document).to_html).to eq(
+      "<svg style=\"fill: red;padding: 10px\">Some document</svg>\n"
+    )
+  end
+end

data/spec/transformation_pipeline/transformations/title_spec.rb

@@ -27,4 +27,13 @@ describe InlineSvg::TransformPipeline::Transformations::Title do
       "<svg><title>Some Title</title></svg>\n"
     )
   end
+
+  it "handles non-ASCII characters" do
+    document = Nokogiri::XML::Document.parse('<svg>Some document</svg>')
+    transformation = InlineSvg::TransformPipeline::Transformations::Title.create_with_value("åäö")
+
+    expect(transformation.transform(document).to_html).to eq(
+      "<svg><title>åäö</title>Some document</svg>\n"
+    )
+  end
 end

data/spec/transformation_pipeline/transformations/transformation_spec.rb

@@ -0,0 +1,39 @@
+require 'inline_svg'
+require 'inline_svg/transform_pipeline'
+
+describe InlineSvg::TransformPipeline::Transformations::Transformation do
+  context "#with_svg" do
+    it "returns a Nokogiri::XML::Document representing the parsed document fragment" do
+      document = Nokogiri::XML::Document.parse("<svg>Some document</svg>")
+
+      transformation = InlineSvg::TransformPipeline::Transformations::Transformation.new(:irrelevant)
+      expect(transformation.with_svg(document).to_html).to eq(
+        "<svg>Some document</svg>\n"
+      )
+    end
+
+    it "yields to the block when the document contains an SVG element" do
+      document = Nokogiri::XML::Document.parse("<svg>Some document</svg>")
+      svg = document.at_css("svg")
+
+      transformation = InlineSvg::TransformPipeline::Transformations::Transformation.new(:irrelevant)
+
+      returned_document = nil
+      expect do |b|
+        returned_document = transformation.with_svg(document, &b)
+      end.to yield_control
+
+      expect(returned_document.to_s).to match(/<svg>Some document<\/svg>/)
+    end
+
+    it "does not yield if the document does not contain an SVG element at the root" do
+      document = Nokogiri::XML::Document.parse("<foo>bar</foo><svg>Some document</svg>")
+
+      transformation = InlineSvg::TransformPipeline::Transformations::Transformation.new(:irrelevant)
+
+      expect do |b|
+        transformation.with_svg(document, &b)
+      end.not_to yield_control
+    end
+  end
+end

data/spec/transformation_pipeline/transformations/view_box_spec.rb

@@ -0,0 +1,13 @@
+require 'inline_svg/transform_pipeline'
+
+describe InlineSvg::TransformPipeline::Transformations::ViewBox do
+  it "adds viewBox attribute to a SVG document" do
+    document = Nokogiri::XML::Document.parse('<svg>Some document</svg>')
+    transformation =
+      InlineSvg::TransformPipeline::Transformations::ViewBox
+        .create_with_value("0 0 100 100")
+    expect(transformation.transform(document).to_html).to eq(
+      "<svg viewBox=\"0 0 100 100\">Some document</svg>\n"
+    )
+  end
+end