inline_svg 0.6.3 → 0.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 61bd9c6cf28c29ebf83c1ced886bf9454a2e3c18
-  data.tar.gz: f6ddecc2e711e872d8c0c62eb08876a1ccfff832
+  metadata.gz: 20cf938dedae16a9b3f2282f60666911ea31918d
+  data.tar.gz: 3e85ceba1e9306512ce5b6c8bf5e362449da05fb
 SHA512:
-  metadata.gz: 73e10466544c51fd1d52aa94a75520000da86d32c243440853f7e5cf7d330a35b55dac5508d954627d3bc3fd10e1e06f9eba155a3ed6e15c2cd3770a1b9bbb14
-  data.tar.gz: 44cff146215df03b09301c3b3bc8cd060b631250a619887a78ef67224ce42e78b2b970570be70e9a968c8725635110eaaeafccde236be1a269f89b3d998b11ec
+  metadata.gz: 913ca48724b6e124be585023a910568f7f7d850521f0e8294832160b84cd7c6e063b51cd5ddc097a22c92078c32f2f29be48c81ef0b300ff37f07fecd54c1ea6
+  data.tar.gz: ee22b302999f9bd020af932b4615a061cf3c8a14bb0a5bb5091f6f44edeb2f6fbd11e90fb82dba031d0161fe5e97a0fd368b6ed559246c0fd1b4e30fffe677be

data/CHANGELOG.md

@@ -5,6 +5,12 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 ## [Unreleased][unreleased]
 - Nothing.
 
+## [0.6.4] - 2016-04-23
+### Fixed
+- Don't duplicate the `title` element. Addresses issue
+  [#31](https://github.com/jamesmartin/inline_svg/issues/31).
+- Make the `title` element the first child node of the SVG document.
+
 ## [0.6.3] - 2016-04-19
 ### Added
 - Accept `IO` objects as arguments to `inline_svg`. Thanks,
@@ -74,8 +80,9 @@ transformations](https://github.com/jamesmartin/inline_svg/blob/master/README.md
 ### Added
 - Basic Railtie and view helper to inline SVG documents to Rails views.
 
-[unreleased]: https://github.com/jamesmartin/inline_svg/compare/v0.6.3...HEAD
-[0.6.2]: https://github.com/jamesmartin/inline_svg/compare/v0.6.2...v0.6.3
+[unreleased]: https://github.com/jamesmartin/inline_svg/compare/v0.6.4...HEAD
+[0.6.4]: https://github.com/jamesmartin/inline_svg/compare/v0.6.3...v0.6.4
+[0.6.3]: https://github.com/jamesmartin/inline_svg/compare/v0.6.2...v0.6.3
 [0.6.2]: https://github.com/jamesmartin/inline_svg/compare/v0.6.1...v0.6.2
 [0.6.1]: https://github.com/jamesmartin/inline_svg/compare/v0.6.0...v0.6.1
 [0.6.0]: https://github.com/jamesmartin/inline_svg/compare/v0.5.3...v0.6.0

data/README.md

@@ -13,7 +13,7 @@ Want to embed SVGs with Javascript? You might like [RemoteSvg](https://github.co
 
 ## Changelog
 
-All notable changes to this project are documented in the
+This project adheres to [Semantic Versioning](http://sermver.org). All notable changes are documented in the
 [CHANGELOG](https://github.com/jamesmartin/inline_svg/blob/master/CHANGELOG.md).
 
 ## Installation

data/inline_svg.gemspec

@@ -21,6 +21,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.2"
+  spec.add_development_dependency "rspec_junit_formatter", "0.2.2"
 
   spec.add_runtime_dependency "activesupport", ">= 4.0.4"
   spec.add_runtime_dependency "nokogiri", "~> 1.6", '~> 1.6'

data/lib/inline_svg/transform_pipeline/transformations/title.rb

@@ -4,7 +4,8 @@ module InlineSvg::TransformPipeline::Transformations
       doc = Nokogiri::XML::Document.parse(doc.to_html)
       node = Nokogiri::XML::Node.new('title', doc)
       node.content = value
-      doc.at_css('svg').add_child(node)
+      doc.search('svg title').each { |node| node.remove }
+      doc.at_css('svg').prepend_child(node)
       doc
     end
   end

data/lib/inline_svg/version.rb

@@ -1,3 +1,3 @@
 module InlineSvg
-  VERSION = "0.6.3"
+  VERSION = "0.6.4"
 end

data/spec/transformation_pipeline/transformations/title_spec.rb

@@ -0,0 +1,30 @@
+require 'inline_svg/transform_pipeline'
+
+describe InlineSvg::TransformPipeline::Transformations::Title do
+  it "adds a title element as the first element in the SVG document" do
+    document = Nokogiri::XML::Document.parse('<svg>Some document</svg>')
+    transformation = InlineSvg::TransformPipeline::Transformations::Title.create_with_value("Some Title")
+
+    expect(transformation.transform(document).to_html).to eq(
+      "<svg><title>Some Title</title>Some document</svg>\n"
+    )
+  end
+
+  it "overwrites the content of an existing title element" do
+    document = Nokogiri::XML::Document.parse('<svg><title>My Title</title>Some document</svg>')
+    transformation = InlineSvg::TransformPipeline::Transformations::Title.create_with_value("Some Title")
+
+    expect(transformation.transform(document).to_html).to eq(
+      "<svg><title>Some Title</title>Some document</svg>\n"
+    )
+  end
+
+  it "handles empty SVG documents" do
+    document = Nokogiri::XML::Document.parse('<svg></svg>')
+    transformation = InlineSvg::TransformPipeline::Transformations::Title.create_with_value("Some Title")
+
+    expect(transformation.transform(document).to_html).to eq(
+      "<svg><title>Some Title</title></svg>\n"
+    )
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: inline_svg
 version: !ruby/object:Gem::Version
-  version: 0.6.3
+  version: 0.6.4
 platform: ruby
 authors:
 - James Martin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-19 00:00:00.000000000 Z
+date: 2016-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.2.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.2.2
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -140,6 +154,7 @@ files:
 - spec/transformation_pipeline/transformations/id_attribute_spec.rb
 - spec/transformation_pipeline/transformations/preserve_aspect_ratio_spec.rb
 - spec/transformation_pipeline/transformations/size_spec.rb
+- spec/transformation_pipeline/transformations/title_spec.rb
 - spec/transformation_pipeline/transformations/width_spec.rb
 - spec/transformation_pipeline/transformations_spec.rb
 homepage: https://github.com/jamesmartin/inline_svg
@@ -178,5 +193,6 @@ test_files:
 - spec/transformation_pipeline/transformations/id_attribute_spec.rb
 - spec/transformation_pipeline/transformations/preserve_aspect_ratio_spec.rb
 - spec/transformation_pipeline/transformations/size_spec.rb
+- spec/transformation_pipeline/transformations/title_spec.rb
 - spec/transformation_pipeline/transformations/width_spec.rb
 - spec/transformation_pipeline/transformations_spec.rb