inline_svg 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b073abae9747da39a851cf848bb44a758601194b
-  data.tar.gz: 88e5783ea3586451675e40cec3086ed447c7c167
+  metadata.gz: d53e3e703f3681894bee4523d13869a70d9d8d85
+  data.tar.gz: 114b05c6779d93d8f8a8cd2f19b6c19f8e32dc2b
 SHA512:
-  metadata.gz: a31ca28cfbbc4ef367bb63b74fb2c72be55ae31c4fe0e68d61b723be83e8ba6137ee387ad7453c21d624bba9e4460567820a7b5bbacffe7a67ac77052bb9a3ee
-  data.tar.gz: 99b1f4e20d66372b8da7b3f486b56958a9b30db7f01a402557a1e6d92636ccfb41835fe86baf6e0627ad515f7508806bf8cf1ad43e991c768f5a33a65994dbe2
+  metadata.gz: a5f10abb1ebcff4ae18bda0f7600b14e0e8f2fb3123f100229e942fb63d8ea5cb6aaeb76a7f192dff2cbbfd1744370325c43e7a620000530d3b9877dad0a9fec
+  data.tar.gz: aa1a416596f428d0afd41e028f8e1ccd3003a3e292f08046d5d3166c2d32f3e5cf99c47799b6e209f0b979821a65e1ac9bd6c99c8c553a0bd559d518620e8dbf

data/CHANGELOG.md

@@ -3,7 +3,7 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased][unreleased]
-- Nothing.
+- Support Sprockets >= 3.0 and config.assets.precompile = false
 
 ## [0.6.1] - 2015-08-06
 ### Fixed

data/README.md

@@ -4,10 +4,13 @@ Styling a SVG document with CSS for use on the web is most reliably achieved by
 [adding classes to the document and
 embedding](http://css-tricks.com/using-svg/) it inline in the HTML.
 
-This gem is a little helper method (`inline_svg`) that reads an SVG document from a Rails
-image directory, applies a CSS class attribute to the root of the document and
+This gem is a little Rails helper method (`inline_svg`) that reads an SVG document (via Sprockets, so works with the Rails Asset Pipeline), applies a CSS class attribute to the root of the document and
 then embeds it into a view.
 
+Inline SVG supports [Rails version 4.0.4](http://weblog.rubyonrails.org/2014/3/14/Rails-4-0-4-has-been-released/) and newer.
+
+Want to embed SVGs with Javascript? You might like [RemoteSvg](https://github.com/jamesmartin/remote-svg), which features similar transforms but can also load SVGs from remote URLs (like S3 etc.).
+
 ## Changelog
 
 All notable changes to this project are documented in the
@@ -40,7 +43,7 @@ and fingerprint your SVG files like any other Rails asset.
 Here's an example of embedding an SVG document and applying a 'class' attribute in
 HAML:
 
-```
+```haml
  !!! 5 
   %html
     %head
@@ -54,7 +57,7 @@ HAML:
 Here's some CSS to target the SVG, resize it and turn it an attractive shade of
 blue:
 
-```
+```css
 .some-class {
   display: block;
   margin: 0 auto;
@@ -79,7 +82,7 @@ key                     | description
 
 Example:
 
-```
+```ruby
 inline_svg("some-document.svg", id: 'some-id', class: 'some-class', data: {some: "value"}, size: '30% * 20%', title: 'Some Title', desc:
 'Some description', nocomment: true, preserve_aspect_ratio: 'xMaxYMax meet')
 ```

data/lib/inline_svg/static_asset_finder.rb

@@ -0,0 +1,27 @@
+# Naive fallback asset finder for when sprockets >= 3.0 &&
+# config.assets.precompile = false
+# Thanks to @ryanswood for the original code:
+# https://github.com/AbleHealth/inline_svg/commit/661bbb3bef7d1b4bd6ccd63f5f018305797b9509
+module InlineSvg
+  class StaticAssetFinder
+    def self.find_asset(filename)
+      new(filename)
+    end
+
+    def initialize(filename)
+      @filename = filename
+    end
+
+    def pathname
+      if ::Rails.application.config.assets.compile
+        ::Rails.application.assets[@filename].pathname
+      else
+        manifest = ::Rails.application.assets_manifest
+        asset_path = manifest.assets[@filename]
+        unless asset_path.nil?
+          ::Rails.root.join(manifest.directory, asset_path)
+        end
+      end
+    end
+  end
+end

data/lib/inline_svg/version.rb

@@ -1,3 +1,3 @@
 module InlineSvg
-  VERSION = "0.6.1"
+  VERSION = "0.6.2"
 end

data/lib/inline_svg.rb

@@ -2,6 +2,7 @@ require "inline_svg/version"
 require "inline_svg/action_view/helpers"
 require "inline_svg/asset_file"
 require "inline_svg/finds_asset_paths"
+require "inline_svg/static_asset_finder"
 require "inline_svg/transform_pipeline"
 
 require "inline_svg/railtie" if defined?(Rails)
@@ -22,7 +23,10 @@ module InlineSvg
       if finder.respond_to?(:find_asset)
         @asset_finder = finder
       else
-        raise InlineSvg::Configuration::Invalid.new("Asset Finder should implement the #find_asset method")
+        # fallback to a naive static asset finder (sprokects >= 3.0 &&
+        # config.assets.precompile = false
+        # See: https://github.com/jamesmartin/inline_svg/issues/25
+        @asset_finder = InlineSvg::StaticAssetFinder
       end
       asset_finder
     end

data/spec/finds_asset_paths_spec.rb

@@ -1,3 +1,4 @@
+require 'pathname'
 require_relative '../lib/inline_svg'
 
 describe InlineSvg::FindsAssetPaths do

data/spec/inline_svg_spec.rb

@@ -33,12 +33,12 @@ describe InlineSvg do
         expect(InlineSvg.configuration.asset_finder).to eq sprockets
       end
 
-      it "complains when the provided asset finder does not implement #find_asset" do
-        expect do
-          InlineSvg.configure do |config|
-            config.asset_finder = 'Not a real asset finder'
-          end
-        end.to raise_error(InlineSvg::Configuration::Invalid, /asset finder.*find_asset/i)
+      it "falls back to StaticAssetFinder when the provided asset finder does not implement #find_asset" do
+        InlineSvg.configure do |config|
+          config.asset_finder = 'Not a real asset finder'
+        end
+
+        expect(InlineSvg.configuration.asset_finder).to eq InlineSvg::StaticAssetFinder
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: inline_svg
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - James Martin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-05 00:00:00.000000000 Z
+date: 2016-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -113,6 +113,7 @@ files:
 - lib/inline_svg/asset_file.rb
 - lib/inline_svg/finds_asset_paths.rb
 - lib/inline_svg/railtie.rb
+- lib/inline_svg/static_asset_finder.rb
 - lib/inline_svg/transform_pipeline.rb
 - lib/inline_svg/transform_pipeline/transformations.rb
 - lib/inline_svg/transform_pipeline/transformations/class_attribute.rb
@@ -159,7 +160,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.2.5
 signing_key: 
 specification_version: 4
 summary: Embeds an SVG document, inline.