inline_svg 0.11.0 → 1.7.2

data/lib/inline_svg/transform_pipeline/transformations/aria_hidden.rb

@@ -0,0 +1,9 @@
+module InlineSvg::TransformPipeline::Transformations
+  class AriaHidden < Transformation
+    def transform(doc)
+      with_svg(doc) do |svg|
+        svg["aria-hidden"] = self.value
+      end
+    end
+  end
+end

data/lib/inline_svg/transform_pipeline/transformations/aria_hidden_attribute.rb

@@ -0,0 +1,9 @@
+module InlineSvg::TransformPipeline::Transformations
+  class AriaHiddenAttribute < Transformation
+    def transform(doc)
+      with_svg(doc) do |svg|
+        svg["aria-hidden"] = self.value
+      end
+    end
+  end
+end

data/lib/inline_svg/transform_pipeline/transformations/class_attribute.rb

@@ -1,12 +1,11 @@
 module InlineSvg::TransformPipeline::Transformations
   class ClassAttribute < Transformation
     def transform(doc)
-      doc = Nokogiri::XML::Document.parse(doc.to_html)
-      svg = doc.at_css "svg"
-      classes = (svg["class"] || "").split(" ")
-      classes << value
-      svg["class"] = classes.join(" ")
-      doc
+      with_svg(doc) do |svg|
+        classes = (svg["class"] || "").split(" ")
+        classes << value
+        svg["class"] = classes.join(" ")
+      end
     end
   end
 end

data/lib/inline_svg/transform_pipeline/transformations/data_attributes.rb

@@ -1,16 +1,21 @@
 module InlineSvg::TransformPipeline::Transformations
   class DataAttributes < Transformation
     def transform(doc)
-      doc = Nokogiri::XML::Document.parse(doc.to_html)
-      svg = doc.at_css 'svg'
-      with_valid_hash_from(self.value).each_pair do |name, data|
-        svg["data-#{name}"] = data
+      with_svg(doc) do |svg|
+        with_valid_hash_from(self.value).each_pair do |name, data|
+          svg["data-#{dasherize(name)}"] = data
+        end
       end
-      doc
     end
 
+    private
+
     def with_valid_hash_from(hash)
       Hash.try_convert(hash) || {}
     end
+
+    def dasherize(string)
+      string.to_s.gsub(/_/, "-")
+    end
   end
 end

data/lib/inline_svg/transform_pipeline/transformations/description.rb

@@ -1,12 +1,13 @@
 module InlineSvg::TransformPipeline::Transformations
   class Description < Transformation
     def transform(doc)
-      doc = Nokogiri::XML::Document.parse(doc.to_html)
-      node = Nokogiri::XML::Node.new('desc', doc)
-      node.content = value
-      doc.search('svg desc').each { |node| node.remove }
-      doc.at_css('svg').prepend_child(node)
-      doc
+      with_svg(doc) do |svg|
+        node = Nokogiri::XML::Node.new("desc", doc)
+        node.content = value
+
+        svg.search("desc").each { |node| node.remove }
+        svg.prepend_child(node)
+      end
     end
   end
 end

data/lib/inline_svg/transform_pipeline/transformations/height.rb

@@ -1,10 +1,9 @@
 module InlineSvg::TransformPipeline::Transformations
   class Height < Transformation
     def transform(doc)
-      doc = Nokogiri::XML::Document.parse(doc.to_html)
-      svg = doc.at_css 'svg'
-      svg['height'] = self.value
-      doc
+      with_svg(doc) do |svg|
+        svg["height"] = self.value
+      end
     end
   end
 end

data/lib/inline_svg/transform_pipeline/transformations/id_attribute.rb

@@ -1,10 +1,9 @@
 module InlineSvg::TransformPipeline::Transformations
   class IdAttribute < Transformation
     def transform(doc)
-      doc = Nokogiri::XML::Document.parse(doc.to_html)
-      svg = doc.at_css 'svg'
-      svg['id'] = self.value
-      doc
+      with_svg(doc) do |svg|
+        svg["id"] = self.value
+      end
     end
   end
 end

data/lib/inline_svg/transform_pipeline/transformations/no_comment.rb

@@ -2,8 +2,11 @@ module InlineSvg::TransformPipeline
   module Transformations
     class NoComment < Transformation
       def transform(doc)
-        doc = Loofah::HTML::DocumentFragment.parse(doc.to_html)
-        doc.scrub!(:strip)
+        with_svg(doc) do |svg|
+          svg.xpath("//comment()").each do |comment|
+            comment.remove
+          end
+        end
       end
     end
   end

data/lib/inline_svg/transform_pipeline/transformations/preserve_aspect_ratio.rb

@@ -1,10 +1,9 @@
 module InlineSvg::TransformPipeline::Transformations
   class PreserveAspectRatio < Transformation
     def transform(doc)
-      doc = Nokogiri::XML::Document.parse(doc.to_html)
-      svg = doc.at_css 'svg'
-      svg['preserveAspectRatio'] = self.value
-      doc
+      with_svg(doc) do |svg|
+        svg["preserveAspectRatio"] = self.value
+      end
     end
   end
 end

data/lib/inline_svg/transform_pipeline/transformations/size.rb

@@ -1,11 +1,10 @@
 module InlineSvg::TransformPipeline::Transformations
   class Size < Transformation
     def transform(doc)
-      doc = Nokogiri::XML::Document.parse(doc.to_html)
-      svg = doc.at_css 'svg'
-      svg['width'] = width_of(self.value)
-      svg['height'] = height_of(self.value)
-      doc
+      with_svg(doc) do |svg|
+        svg["width"] = width_of(self.value)
+        svg["height"] = height_of(self.value)
+      end
     end
 
     def width_of(value)

data/lib/inline_svg/transform_pipeline/transformations/style_attribute.rb

@@ -0,0 +1,11 @@
+module InlineSvg::TransformPipeline::Transformations
+  class StyleAttribute < Transformation
+    def transform(doc)
+      with_svg(doc) do |svg|
+        styles = svg["style"].to_s.split(";")
+        styles << value
+        svg["style"] = styles.join(";")
+      end
+    end
+  end
+end

data/lib/inline_svg/transform_pipeline/transformations/title.rb

@@ -1,12 +1,13 @@
 module InlineSvg::TransformPipeline::Transformations
   class Title < Transformation
     def transform(doc)
-      doc = Nokogiri::XML::Document.parse(doc.to_html)
-      node = Nokogiri::XML::Node.new('title', doc)
-      node.content = value
-      doc.search('svg title').each { |node| node.remove }
-      doc.at_css('svg').prepend_child(node)
-      doc
+      with_svg(doc) do |svg|
+        node = Nokogiri::XML::Node.new("title", doc)
+        node.content = value
+
+        svg.search("title").each { |node| node.remove }
+        svg.prepend_child(node)
+      end
     end
   end
 end

data/lib/inline_svg/transform_pipeline/transformations/transformation.rb

@@ -13,6 +13,19 @@ module InlineSvg::TransformPipeline::Transformations
     def transform(*)
       raise "#transform should be implemented by subclasses of Transformation"
     end
+
+    # Parses a document and yields the contained SVG nodeset to the given block
+    # if it exists.
+    #
+    # Returns a Nokogiri::XML::Document.
+    def with_svg(doc)
+      doc = Nokogiri::XML::Document.parse(
+        doc.to_html(encoding: "UTF-8"), nil, "UTF-8"
+      )
+      svg = doc.at_css "svg"
+      yield svg if svg && block_given?
+      doc
+    end
   end
 
   class NullTransformation < Transformation

data/lib/inline_svg/transform_pipeline/transformations/width.rb

@@ -1,10 +1,9 @@
 module InlineSvg::TransformPipeline::Transformations
   class Width < Transformation
     def transform(doc)
-      doc = Nokogiri::XML::Document.parse(doc.to_html)
-      svg = doc.at_css 'svg'
-      svg['width'] = self.value
-      doc
+      with_svg(doc) do |svg|
+        svg["width"] = self.value
+      end
     end
   end
 end

data/lib/inline_svg/version.rb

@@ -1,3 +1,3 @@
 module InlineSvg
-  VERSION = "0.11.0"
+  VERSION = "1.7.2"
 end

data/lib/inline_svg/webpack_asset_finder.rb

@@ -0,0 +1,50 @@
+module InlineSvg
+  class WebpackAssetFinder
+    def self.find_asset(filename)
+      new(filename)
+    end
+
+    def initialize(filename)
+      @filename = filename
+      @asset_path = Webpacker.manifest.lookup(@filename)
+    end
+
+    def pathname
+      return if @asset_path.blank?
+
+      if Webpacker.dev_server.running?
+        dev_server_asset(@asset_path)
+      elsif Webpacker.config.public_path.present?
+        File.join(Webpacker.config.public_path, @asset_path)
+      end
+    end
+
+    private
+
+    def dev_server_asset(file_path)
+      asset = fetch_from_dev_server(file_path)
+
+      begin
+        Tempfile.new(file_path).tap do |file|
+          file.binmode
+          file.write(asset)
+          file.rewind
+        end
+      rescue StandardError => e
+        Rails.logger.error "[inline_svg] Error creating tempfile for #{@filename}: #{e}"
+        raise
+      end
+    end
+
+    def fetch_from_dev_server(file_path)
+      http = Net::HTTP.new(Webpacker.dev_server.host, Webpacker.dev_server.port)
+      http.use_ssl = Webpacker.dev_server.https?
+      http.verify_mode = OpenSSL::SSL::VERIFY_NONE
+
+      http.request(Net::HTTP::Get.new(file_path)).body
+    rescue StandardError => e
+      Rails.logger.error "[inline_svg] Error fetching #{@filename} from webpack-dev-server: #{e}"
+      raise
+    end
+  end
+end

data/spec/cached_asset_file_spec.rb

@@ -0,0 +1,73 @@
+# frozen_string_literal: true
+require 'pathname'
+require_relative '../lib/inline_svg'
+
+describe InlineSvg::CachedAssetFile do
+  let(:fixture_path) { Pathname.new(File.expand_path("../files/static_assets", __FILE__)) }
+
+  it "loads assets under configured paths" do
+    known_document = File.read(fixture_path.join("assets0", "known-document.svg"))
+
+    asset_loader = InlineSvg::CachedAssetFile.new(paths: fixture_path.join("assets0"))
+
+    expect(asset_loader.named("known-document.svg")).to eq(known_document)
+  end
+
+  it "does not include assets outside of configured paths" do
+    asset_loader = InlineSvg::CachedAssetFile.new(paths: fixture_path.join("assets0"))
+
+    expect(fixture_path.join("assets1", "other-document.svg")).to be_file
+    expect do
+      asset_loader.named("other-document.svg")
+    end.to raise_error InlineSvg::AssetFile::FileNotFound
+  end
+
+  it "differentiates two files with the same name" do
+    known_document_0 = File.read(fixture_path.join("assets0", "known-document.svg"))
+    known_document_1 = File.read(fixture_path.join("assets1", "known-document.svg"))
+
+    expect(known_document_0).not_to eq(known_document_1)
+
+    asset_loader = InlineSvg::CachedAssetFile.new(paths: fixture_path)
+
+    expect(known_document_0).to eq(asset_loader.named("assets0/known-document.svg"))
+    expect(known_document_1).to eq(asset_loader.named("assets1/known-document.svg"))
+  end
+
+  it "chooses the closest exact matching file when similar files exist in the same path" do
+    known_document = File.read(fixture_path.join("assets0", "known-document.svg"))
+    known_document_2 = File.read(fixture_path.join("assets0", "known-document-two.svg"))
+
+    expect(known_document).not_to eq(known_document_2)
+
+    asset_loader = InlineSvg::CachedAssetFile.new(paths: fixture_path.join("assets0"), filters: /\.svg/)
+
+    expect(asset_loader.named("known-document")).to eq(known_document)
+    expect(asset_loader.named("known-document-two")).to eq(known_document_2)
+  end
+
+  it "filters wanted files by simple string matching" do
+    known_document_0 = File.read(fixture_path.join("assets0", "known-document.svg"))
+    known_document_1 = File.read(fixture_path.join("assets1", "known-document.svg"))
+
+    asset_loader = InlineSvg::CachedAssetFile.new(paths: fixture_path, filters: "assets1")
+
+    expect do
+      asset_loader.named("assets0/known-document.svg")
+    end.to raise_error InlineSvg::AssetFile::FileNotFound
+
+    expect(known_document_1).to eq(asset_loader.named("assets1/known-document.svg"))
+  end
+
+  it "filters wanted files by regex matching" do
+    known_document_1 = File.read(fixture_path.join("assets1", "known-document.svg"))
+
+    asset_loader = InlineSvg::CachedAssetFile.new(paths: fixture_path, filters: ["assets1", /\.svg/])
+
+    expect do
+      asset_loader.named("assets1/some-file.txt")
+    end.to raise_error InlineSvg::AssetFile::FileNotFound
+
+    expect(known_document_1).to eq(asset_loader.named("assets1/known-document.svg"))
+  end
+end

data/spec/files/static_assets/assets0/known-document-two.svg

@@ -0,0 +1 @@
+<svg>other interesting content</svg>

data/spec/files/static_assets/assets0/known-document.svg

@@ -0,0 +1 @@
+<svg>interesting content</svg>

data/spec/files/static_assets/assets0/some-document.svg

@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"><path d="M3.273 7.151l-2.917-2.916c-.23.665-.356 1.361-.356 2.057 0 1.608.624 3.216 1.851 4.442 1.35 1.351 3.163 1.957 4.928 1.821.933-.072 1.851.268 2.513.93l9.646 9.646c.58.579 1.338.869 2.097.869 1.636 0 2.965-1.326 2.965-2.965 0-.759-.29-1.518-.868-2.097l-9.647-9.646c-.661-.662-1.002-1.581-.93-2.514.136-1.766-.47-3.578-1.821-4.928-.372-.372-.778-.686-1.209-.945l-6.252 6.246zm18.727 13.849c0 .552-.448 1-1 1s-1-.448-1-1 .448-1 1-1 1 .447 1 1zm-12.153-13.396l-3.061 3.061-2.566-2.567 3.062-3.061 2.565 2.567zm-.933.096l-.762.761-1.705-1.705.762-.762 1.705 1.706zm-2.991-.42l-.761.762 1.706 1.705.762-.762-1.707-1.705zm2.484-6.903l-2.893 2.893-2.412-2.412c.953-.556 2.044-.858 3.165-.858.707 0 1.425.12 2.128.373l.012.004z"/></svg>

data/spec/files/static_assets/assets1/known-document.svg

@@ -0,0 +1 @@
+<svg>Another known document</svg>

data/spec/files/static_assets/assets1/other-document.svg

@@ -0,0 +1,3 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
+<svg>Other document</svg>

data/spec/files/static_assets/assets1/some-file.txt

@@ -0,0 +1 @@
+Some file contents.

data/spec/helpers/inline_svg_spec.rb

@@ -13,27 +13,86 @@ describe InlineSvg::ActionView::Helpers do
 
   let(:helper) { ( Class.new { include InlineSvg::ActionView::Helpers } ).new }
 
-  describe "#inline_svg" do
-    
+  shared_examples "inline_svg helper" do |helper_method:|
+
     context "when passed the name of an SVG that does not exist" do
+      after(:each) do
+        InlineSvg.reset_configuration!
+      end
+
+      context "and configured to raise" do
+        it "raises an exception" do
+          InlineSvg.configure do |config|
+            config.raise_on_file_not_found = true
+          end
+
+          allow(InlineSvg::AssetFile).to receive(:named).
+            with('some-missing-file.svg').
+            and_raise(InlineSvg::AssetFile::FileNotFound.new)
+
+          expect {
+            helper.send(helper_method, 'some-missing-file.svg')
+          }.to raise_error(InlineSvg::AssetFile::FileNotFound)
+        end
+      end
+
       it "returns an empty, html safe, SVG document as a placeholder" do
         allow(InlineSvg::AssetFile).to receive(:named).
           with('some-missing-file.svg').
           and_raise(InlineSvg::AssetFile::FileNotFound.new)
 
-        output = helper.inline_svg('some-missing-file.svg')
+        output = helper.send(helper_method, 'some-missing-file.svg')
         expect(output).to eq "<svg><!-- SVG file not found: 'some-missing-file.svg' --></svg>"
         expect(output).to be_html_safe
       end
 
+      it "escapes malicious input" do
+        malicious = "--></svg><script>alert(1)</script><svg>.svg"
+        allow(InlineSvg::AssetFile).to receive(:named).
+          with(malicious).
+          and_raise(InlineSvg::AssetFile::FileNotFound.new)
+
+        output = helper.send(helper_method, malicious)
+        expect(output).to eq "<svg><!-- SVG file not found: '--&gt;&lt;/svg&gt;&lt;script&gt;alert(1)&lt;/script&gt;&lt;svg&gt;.svg' --></svg>"
+        expect(output).to be_html_safe
+      end
+
       it "gives a helpful hint when no .svg extension is provided in the filename" do
         allow(InlineSvg::AssetFile).to receive(:named).
           with('missing-file-with-no-extension').
           and_raise(InlineSvg::AssetFile::FileNotFound.new)
 
-        output = helper.inline_svg('missing-file-with-no-extension')
+        output = helper.send(helper_method, 'missing-file-with-no-extension')
         expect(output).to eq "<svg><!-- SVG file not found: 'missing-file-with-no-extension' (Try adding .svg to your filename) --></svg>"
       end
+
+      it "allows the CSS class on the empty SVG document to be changed" do
+        InlineSvg.configure do |config|
+          config.svg_not_found_css_class = 'missing-svg'
+        end
+
+        allow(InlineSvg::AssetFile).to receive(:named).
+          with('some-other-missing-file.svg').
+          and_raise(InlineSvg::AssetFile::FileNotFound.new)
+
+        output = helper.send(helper_method, 'some-other-missing-file.svg')
+        expect(output).to eq "<svg class='missing-svg'><!-- SVG file not found: 'some-other-missing-file.svg' --></svg>"
+        expect(output).to be_html_safe
+      end
+
+      context "and a fallback that does exist" do
+        it "displays the fallback" do
+          allow(InlineSvg::AssetFile).to receive(:named).
+            with('missing.svg').
+            and_raise(InlineSvg::AssetFile::FileNotFound.new)
+
+          fallback_file = <<-SVG
+<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>
+SVG
+          allow(InlineSvg::AssetFile).to receive(:named).with('fallback.svg').and_return(fallback_file)
+          expect(helper.send(helper_method, 'missing.svg', fallback: 'fallback.svg')).to eq fallback_file
+        end
+      end
     end
 
     context "when passed an existing SVG file" do
@@ -41,10 +100,10 @@ describe InlineSvg::ActionView::Helpers do
       context "and no options" do
         it "returns a html safe version of the file's contents" do
           example_file = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"><!-- This is a comment --></svg>
+<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>
 SVG
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(example_file)
-          expect(helper.inline_svg('some-file')).to eq example_file
+          expect(helper.send(helper_method, 'some-file')).to eq example_file
         end
       end
 
@@ -57,7 +116,7 @@ SVG
 <svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"><title>A title</title></svg>
 SVG
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
-          expect(helper.inline_svg('some-file', title: 'A title')).to eq expected_output
+          expect(helper.send(helper_method, 'some-file', title: 'A title')).to eq expected_output
         end
       end
 
@@ -70,34 +129,46 @@ SVG
 <svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"><desc>A description</desc></svg>
 SVG
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
-          expect(helper.inline_svg('some-file', desc: 'A description')).to eq expected_output
+          expect(helper.send(helper_method, 'some-file', desc: 'A description')).to eq expected_output
         end
       end
 
       context "and the 'nocomment' option" do
         it "strips comments and other unknown/unsafe nodes from the output" do
           input_svg = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"><!-- This is a comment --></svg>
+<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>
 SVG
           expected_output = <<-SVG
 <svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"></svg>
 SVG
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
-          expect(helper.inline_svg('some-file', nocomment: true)).to eq expected_output
+          expect(helper.send(helper_method, 'some-file', nocomment: true)).to eq expected_output
+        end
+      end
+
+      context "and the 'aria_hidden' option" do
+        it "sets 'aria-hidden=true' in the output" do
+          input_svg = <<-SVG
+<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"></svg>
+SVG
+          expected_output = <<-SVG
+<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en" aria-hidden="true"></svg>
+SVG
+          allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
+          expect(helper.send(helper_method, 'some-file', aria_hidden: true)).to eq expected_output
         end
       end
 
       context "and all options" do
         it "applies all expected transformations to the output" do
           input_svg = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" role="presentation" xml:lang="en"><!-- This is a comment --></svg>
+<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><!-- This is a comment --></svg>
 SVG
           expected_output = <<-SVG
-<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><title>A title</title>
-<desc>A description</desc></svg>
+<svg xmlns="http://www.w3.org/2000/svg" xml:lang="en"><title>A title</title><desc>A description</desc></svg>
 SVG
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
-          expect(helper.inline_svg('some-file', title: 'A title', desc: 'A description', nocomment: true)).to eq expected_output
+          expect(helper.send(helper_method, 'some-file', title: 'A title', desc: 'A description', nocomment: true)).to eq expected_output
         end
       end
 
@@ -120,7 +191,7 @@ SVG
 <svg custom="some value"></svg>
 SVG
           allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
-          expect(helper.inline_svg('some-file', custom: 'some value')).to eq expected_output
+          expect(helper.send(helper_method, 'some-file', custom: 'some value')).to eq expected_output
         end
       end
 
@@ -141,7 +212,7 @@ SVG
 
             allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
 
-            expect(helper.inline_svg('some-file')).to eq "<svg custom=\"default value\"></svg>\n"
+            expect(helper.send(helper_method, 'some-file')).to eq "<svg custom=\"default value\"></svg>\n"
           end
         end
 
@@ -151,7 +222,7 @@ SVG
 
             allow(InlineSvg::AssetFile).to receive(:named).with('some-file').and_return(input_svg)
 
-            expect(helper.inline_svg('some-file', custom: 'some value')).to eq "<svg custom=\"some value\"></svg>\n"
+            expect(helper.send(helper_method, 'some-file', custom: 'some value')).to eq "<svg custom=\"some value\"></svg>\n"
           end
         end
       end
@@ -163,13 +234,13 @@ SVG
         expect(InlineSvg::IOResource).to receive(:===).with(argument).and_return(true)
         expect(InlineSvg::IOResource).to receive(:read).with(argument)
         expect(InlineSvg::AssetFile).to_not receive(:named)
-        helper.inline_svg(argument)
+        helper.send(helper_method, argument)
       end
       it 'accept filename' do
         expect(InlineSvg::IOResource).to receive(:===).with(argument).and_return(false)
         expect(InlineSvg::IOResource).to_not receive(:read)
         expect(InlineSvg::AssetFile).to receive(:named).with(argument)
-        helper.inline_svg(argument)
+        helper.send(helper_method, argument)
       end
     end
     context 'when passed IO object argument' do
@@ -179,17 +250,29 @@ SVG
       it 'return valid svg' do
         expect(InlineSvg::IOResource).to receive(:===).with(io_object).and_return(true)
         expect(InlineSvg::IOResource).to receive(:read).with(io_object).and_return("<svg><!-- Test IO --></svg>")
-        output = helper.inline_svg(io_object)
+        output = helper.send(helper_method, io_object)
         expect(output).to eq "<svg><!-- Test IO --></svg>\n"
         expect(output).to be_html_safe
       end
 
       it 'return valid svg for file' do
-        output = helper.inline_svg(File.new(file_path))
+        output = helper.send(helper_method, File.new(file_path))
         expect(output).to eq "<svg xmlns=\"http://www.w3.org/2000/svg\" xml:lang=\"en\" role=\"presentation\"><!-- This is a test comment --></svg>\n"
         expect(output).to be_html_safe
       end
 
     end
   end
+
+  describe '#inline_svg' do
+    it_behaves_like "inline_svg helper", helper_method: :inline_svg
+  end
+
+  describe '#inline_svg_tag' do
+    it_behaves_like "inline_svg helper", helper_method: :inline_svg_tag
+  end
+
+  describe '#inline_svg_tag' do
+    it_behaves_like "inline_svg helper", helper_method: :inline_svg_pack_tag
+  end
 end