inline_forms_installer 8.1.9 → 8.1.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f4163e5ce8733e5d7f2226ce39f9a475a75860497da6d6d0ddf12575deaa661f
-  data.tar.gz: 42640181a8f3927a9e70ea3b536dfa3507eb21b0997b1fd5a4a5409668422002
+  metadata.gz: 949a3d8e8b439ac7f34a04e4acfc38974c3a7125a45a8cc6384e50bee43f9ae9
+  data.tar.gz: 7ae6307dad95185fe50df14b7f5e4b3a1f7b010bb27d9b6cdb5847f5eb61b997
 SHA512:
-  metadata.gz: 7034b106b0c14b639fff1385ef6827f5e3431fe9209e978ea932a65e28a58c97ef8a45e9c66b6cac1bbd8a1c906d8628611127714716f954d75df28ac1c232aa
-  data.tar.gz: 70ac2e021ba10ffb43fbae4f7608134b1f25ad0583d6f92658166a963aadcc8a9d7deb25b8d3389cbd575224e95f0698ba470f3b7f26f016d0dc8a03e79542f8
+  metadata.gz: 70aa006317eaab16ee0995ebe148d1296c20e52819da3f3bcce30469413287297a2918301ff68c5ddd96395bf3374d6586c1a81a47018a2da0594b23f12ae307
+  data.tar.gz: 34481743978a4551cba788d665975d57c057ac7864d3aae9f8eaf78d75c755510d82aa9b3df68ffbbf686c8417b0638b84b9433b21ec9cc1e8f84ad5f71b5de6

data/lib/inline_forms_installer/installer_core.rb

@@ -46,10 +46,28 @@ def install_prerelease_gems_from_roots!
   return if roots.empty?
 
   %w[validation_hints inline_forms inline_forms_installer].each do |name|
-    gem_file = roots.filter_map { |root|
-      files = Dir[File.join(root, "#{name}-*.gem")]
-      files.sort.last if files.any?
-    }.max
+    # Pick the *highest version*, not the highest filename. String sort
+    # placed `inline_forms-8.1.7.gem` above `inline_forms-8.1.10.gem`
+    # because "7" > "1" lexicographically — silently picking up a stale
+    # gem build on every release once minor versions cross a digit
+    # boundary. Parse the version out of the filename with Gem::Version
+    # so the comparison is numeric.
+    #
+    # Look in both the checkout root (`gem build` output) *and* `pkg/`
+    # (`rake build` output from Bundler::GemHelper.install_tasks). 8.1.10
+    # only globbed the root, so the moment a maintainer ran `rake build`
+    # the freshly-built gem ended up in `pkg/` and was invisible — the
+    # installer fell back to whatever stale `<name>-*.gem` was still
+    # sitting in the checkout root from an earlier `gem build`. That's
+    # the exact shape that bit us between 8.1.6 (default gemset's
+    # highest installer) and 8.1.10.
+    candidates = roots.flat_map { |root|
+      Dir[File.join(root, "#{name}-*.gem"), File.join(root, "pkg", "#{name}-*.gem")]
+    }
+    gem_file = candidates.max_by do |path|
+      ver_str = File.basename(path, ".gem").sub(/\A#{Regexp.escape(name)}-/, "")
+      Gem::Version.new(ver_str) rescue Gem::Version.new("0")
+    end
     next unless gem_file && File.file?(gem_file)
 
     say "- Installing #{File.basename(gem_file)} into app gemset..."
@@ -1065,7 +1083,7 @@ if ENV['install_example'] == 'true'
   # ---------------------------------------------------------------------
   say "- Generating FormElementShowcase (one resource per kept Tier 1 form_element)..."
   sleep 1
-  run %q{bundle exec rails g inline_forms FormElementShowcase title:string body_plain_area:plain_text_area count:integer_field price:decimal_field amount:money_field meeting_date:date_select meeting_time:time_select birth_month:month_select start_month:month_year_picker is_active:check_box gender:radio_button rating_int:dropdown_with_integers priority:dropdown_with_values priority2:dropdown_with_values stars:dropdown_with_values_with_stars scale_int:scale_with_integers scale_val:scale_with_values attachment:file_field jingle:audio_field cover:image_field description:rich_text locales:has_and_belongs_to_many _enabled:yes _list_order:title _list_search:title _presentation:'#{title}'}
+  run %q{bundle exec rails g inline_forms FormElementShowcase title:string body_plain_area:plain_text_area count:integer_field price:decimal_field amount:money_field latitude:decimal_field{9,6} longitude:decimal_field{10,6} meeting_date:date_select meeting_time:time_select birth_month:month_select start_month:month_year_picker is_active:check_box gender:radio_button rating_int:dropdown_with_integers priority:dropdown_with_values priority2:dropdown_with_values stars:dropdown_with_values_with_stars scale_int:scale_with_integers scale_val:scale_with_values attachment:file_field jingle:audio_field cover:image_field description:rich_text locales:has_and_belongs_to_many _enabled:yes _list_order:title _list_search:title _presentation:'#{title}'}
 
   say "- Generating Attachment + Jingle uploaders (Cover reuses ImageUploader)..."
   run "bundle exec rails generate uploader Attachment"
@@ -1127,7 +1145,11 @@ if ENV['install_example'] == 'true'
   # A `def` body is parsed but only resolved at call time, side-stepping
   # the ordering hazard.
   inject_into_file "app/models/form_element_showcase.rb",
-                   "\n  validates :count, numericality: { only_integer: true }, allow_blank: true\n  mount_uploader :attachment, AttachmentUploader\n  monetize :amount_cents\n\n  def locales_display\n    locales\n  end\n",
+                   "\n  validates :count, numericality: { only_integer: true }, allow_blank: true\n" \
+                   "  validates :price, numericality: true, allow_blank: true\n" \
+                   "  validates :latitude,  numericality: { greater_than_or_equal_to:  -90, less_than_or_equal_to:  90 }, allow_blank: true\n" \
+                   "  validates :longitude, numericality: { greater_than_or_equal_to: -180, less_than_or_equal_to: 180 }, allow_blank: true\n" \
+                   "  mount_uploader :attachment, AttachmentUploader\n  monetize :amount_cents\n\n  def locales_display\n    locales\n  end\n",
                    after: "class FormElementShowcase < ApplicationRecord\n"
 
   # Value-bearing rows for every form_element that needs a values hash
@@ -1199,6 +1221,8 @@ if ENV['install_example'] == 'true'
           amount: Amount
           meeting_date: Meeting date
           meeting_time: Meeting time
+          latitude: Latitude
+          longitude: Longitude
           birth_month: Birth month
           start_month: Start month and year
           is_active: Is active
@@ -1280,6 +1304,11 @@ if ENV['install_example'] == 'true'
           s.count           = 7
           s.price           = "12.34"
           s.amount          = Money.from_amount(99.95, "USD") if s.respond_to?(:amount=)
+          # Curaçao (Willemstad). Exactly representable in decimal(9,6)
+          # and decimal(10,6) — useful for the precision-survival test
+          # that asserts the round-trip is bit-identical, not float-fuzzy.
+          s.latitude        = BigDecimal("12.123456")
+          s.longitude       = BigDecimal("-68.987654")
           s.meeting_date    = Date.new(2026, 6, 1)
           s.meeting_time    = Time.utc(2000, 1, 1, 14, 30)
           s.birth_month     = 7
@@ -1362,12 +1391,40 @@ if ENV['install_example'] == 'true'
     create_file rel, example_user_cfg.adapt_example_test_source(File.read(abs))
   end
 
-  say "- Running example regression tests (bundle exec rails test)..."
+  # Cap test parallelism so the example-app gate fits on memory-modest
+  # machines. Rails' minitest parallelizer defaults to `workers:
+  # number_of_processors`, which on a 20-core box forks 20 full Rails
+  # processes — each ~200-300 MB resident with the example app's full
+  # gem stack (CarrierWave + Devise + PaperTrail + Foundation +
+  # tabs_on_rails + money-rails). Multiply that by 20 and you're 4-6 GB
+  # in worker processes alone, on top of the parent installer/bundler
+  # state. On a memory-pressured host systemd-oomd can kill the whole
+  # VTE/terminal session before the gate finishes, with no useful
+  # signal back to the user (one such kill happened mid-gate on
+  # 2026-05-28 07:50:35; that's what motivated this cap).
+  #
+  # `PARALLEL_WORKERS=2` keeps the worker footprint to ~600 MB and
+  # roughly doubles the wall-clock vs 20 workers — fine for a one-shot
+  # gate. The `INLINE_FORMS_TEST_WORKERS` env override lets machines
+  # with RAM headroom crank it back up (use `0` for Rails' default
+  # number_of_processors, any positive integer to pin).
+  workers_env = ENV["INLINE_FORMS_TEST_WORKERS"].to_s.strip
+  workers     = if workers_env.empty?
+                  "2"
+                elsif workers_env == "0"
+                  nil  # let Rails pick number_of_processors
+                else
+                  workers_env
+                end
+  worker_prefix = workers ? "PARALLEL_WORKERS=#{Shellwords.escape(workers)} " : ""
+
+  say "- Running example regression tests (bundle exec rails test)#{workers ? " with PARALLEL_WORKERS=#{workers}" : ""}..."
   log_path = ENV["INLINE_FORMS_INSTALLER_LOG"].to_s
+  rails_test = "#{worker_prefix}bundle exec rails test"
   test_cmd = if log_path != ""
-               "bundle exec rails test 2>&1 | tee -a #{Shellwords.escape(log_path)}"
+               "#{rails_test} 2>&1 | tee -a #{Shellwords.escape(log_path)}"
              else
-               "bundle exec rails test 2>&1"
+               "#{rails_test} 2>&1"
              end
   test_ok = system("bash", "-c", "#{test_cmd}; exit ${PIPESTATUS[0]}")
   abort "ERROR: bundle exec rails test failed during --example install. See #{log_path}" unless test_ok

data/lib/inline_forms_installer/version.rb

@@ -1,6 +1,6 @@
 # -*- encoding : utf-8 -*-
 module InlineFormsInstaller
-  VERSION = "8.1.9"
+  VERSION = "8.1.11"
 
   # Written into generated apps' `.ruby-version` (must match gemspec `required_ruby_version`).
   TARGET_RUBY_VERSION = "ruby-4.0.4"

data/lib/inline_forms_installer.rb

@@ -38,12 +38,12 @@ module InlineFormsInstaller
       6.times do
         if ENV["INLINE_FORMS_RELEASE_ROOT"].to_s == "" &&
            File.file?(File.join(dir, "inline_forms.gemspec")) &&
-           Dir[File.join(dir, "inline_forms-*.gem")].any?
+           checkout_has_built_gem?(dir, "inline_forms")
           ENV["INLINE_FORMS_RELEASE_ROOT"] = dir
         end
         if ENV["VALIDATION_HINTS_ROOT"].to_s == "" &&
            File.file?(File.join(dir, "validation_hints.gemspec")) &&
-           Dir[File.join(dir, "validation_hints-*.gem")].any?
+           checkout_has_built_gem?(dir, "validation_hints")
           ENV["VALIDATION_HINTS_ROOT"] = dir
         end
         parent = File.expand_path("..", dir)
@@ -74,9 +74,21 @@ module InlineFormsInstaller
       File.expand_path("~/#{repo_name}")
     ].uniq.find do |checkout|
       File.file?(File.join(checkout, "#{repo_name}.gemspec")) &&
-        Dir[File.join(checkout, "#{repo_name}-*.gem")].any?
+        checkout_has_built_gem?(checkout, repo_name)
     end
   end
+
+  # Look for built `<name>-*.gem` files in both the checkout root *and*
+  # `pkg/` — `gem build` writes to the root, but `rake build` (i.e.
+  # `Bundler::GemHelper.install_tasks` from the Rakefile) writes to
+  # `pkg/`. Either is a legitimate "I just built this" location; only
+  # globbing the root meant a freshly-`rake build`-ed gem was invisible
+  # to install_prerelease_gems_from_roots! and the installer would
+  # silently fall back to whatever stale `*.gem` was sitting in the
+  # checkout root from a previous `gem build` run.
+  def self.checkout_has_built_gem?(checkout, name)
+    Dir[File.join(checkout, "#{name}-*.gem"), File.join(checkout, "pkg", "#{name}-*.gem")].any?
+  end
 end
 
 require "inline_forms_installer/user_model_config"

data/lib/installer_templates/example_app_tests/test/integration/example_app_showcase_numeric_fields_test.rb

@@ -3,8 +3,10 @@
 require_relative "../example_app/example_integration_test_case"
 
 # Numeric Tier 1 helpers on FormElementShowcase:
-#   integer_field   (count)        + numericality validation regression
-#   decimal_field   (price)
+#   integer_field   (count)                  + numericality validation regression
+#   decimal_field   (price)                  default precision: 10, scale: 2
+#   decimal_field   (latitude, longitude)    explicit `{p,s}` CLI suffix:
+#                                            decimal(9,6) / decimal(10,6)
 #   money_field     (amount, money-rails `monetize :amount_cents`)
 class ExampleAppShowcaseNumericFieldsTest < ExampleAppIntegrationTestCase
   setup do
@@ -30,7 +32,11 @@ class ExampleAppShowcaseNumericFieldsTest < ExampleAppIntegrationTestCase
     assert_equal 42, @showcase.reload.count
   end
 
-  test "decimal_field price round-trips" do
+  test "decimal_field price round-trips as BigDecimal with default precision/scale" do
+    # Since 8.1.10 the registry maps :decimal_field to a real :decimal
+    # column. Bare `price:decimal_field` (no `{p,s}` suffix) defaults to
+    # precision: 10, scale: 2 — so 99.95 round-trips losslessly *and*
+    # ActiveRecord returns a BigDecimal, not a String.
     frame = "form_element_showcase_#{@showcase.id}_price"
     headers = { "Turbo-Frame" => frame, "Accept" => "text/html" }
 
@@ -44,7 +50,76 @@ class ExampleAppShowcaseNumericFieldsTest < ExampleAppIntegrationTestCase
     assert_response :success
     assert_includes @response.body, %(<turbo-frame id="#{frame}">)
     assert_includes @response.body, "99.95"
-    assert_equal "99.95", @showcase.reload.price
+    reloaded_price = @showcase.reload.price
+    assert_kind_of BigDecimal, reloaded_price,
+      "expected :decimal column to return BigDecimal, got #{reloaded_price.class}"
+    assert_equal BigDecimal("99.95"), reloaded_price
+  end
+
+  test "decimal_field{9,6} latitude round-trips at full scale (6 fractional digits)" do
+    # The `latitude:decimal_field{9,6}` CLI suffix should give us
+    # exactly 6 fractional digits of precision — enough for ~11cm
+    # accuracy in GPS terms. Pick a value that fully populates the
+    # scale so we'd catch off-by-one truncation.
+    frame = "form_element_showcase_#{@showcase.id}_latitude"
+    headers = { "Turbo-Frame" => frame, "Accept" => "text/html" }
+
+    put form_element_showcase_path(
+      @showcase,
+      attribute: "latitude",
+      form_element: "decimal_field",
+      update: frame
+    ), params: { latitude: "12.123456" }, headers: headers
+
+    assert_response :success
+    reloaded = @showcase.reload.latitude
+    assert_kind_of BigDecimal, reloaded
+    assert_equal BigDecimal("12.123456"), reloaded
+  end
+
+  test "decimal_field{10,6} longitude accepts the full ±180 range" do
+    frame = "form_element_showcase_#{@showcase.id}_longitude"
+    headers = { "Turbo-Frame" => frame, "Accept" => "text/html" }
+
+    put form_element_showcase_path(
+      @showcase,
+      attribute: "longitude",
+      form_element: "decimal_field",
+      update: frame
+    ), params: { longitude: "-179.999999" }, headers: headers
+
+    assert_response :success
+    assert_equal BigDecimal("-179.999999"), @showcase.reload.longitude
+  end
+
+  test "decimal_field price rejects non-numeric via top-level create" do
+    # Counterpart to the integer_field rejection test below. Without
+    # the `validates :price, numericality: true` line in the showcase
+    # model, ActiveRecord would silently cast "ace" to BigDecimal("0")
+    # and the create would succeed. The validation keeps the
+    # round-trip honest.
+    assert_no_difference "FormElementShowcase.count" do
+      post form_element_showcases_path(update: @list_frame),
+           params: {
+             title: "Bad Price",
+             price: "ace",
+             count: 1,
+             amount: "0.00",
+             start_month: "September 2026",
+             _form_element_showcase: {
+               rating_int: 1,
+               priority: 1,
+               priority2: 1,
+               stars: 1,
+               scale_int: 1,
+               scale_val: 1,
+             },
+           },
+           headers: @list_headers
+    end
+    assert_response :success
+    assert_match(/is not a number|price[^<]*is not a number/i, @response.body,
+      "expected numericality error to render after invalid price")
   end
 
   test "money_field amount round-trips through monetize :amount_cents" do

data/lib/installer_templates/example_app_tests/test/integration/example_app_showcase_page_render_test.rb

@@ -14,6 +14,8 @@ class ExampleAppShowcasePageRenderTest < ExampleAppIntegrationTestCase
     count
     price
     amount
+    latitude
+    longitude
     meeting_date
     meeting_time
     birth_month
@@ -66,6 +68,8 @@ class ExampleAppShowcasePageRenderTest < ExampleAppIntegrationTestCase
       s.scale_int       = 3
       s.scale_val       = 2
       s.amount          = Money.from_amount(99.95, "USD") if s.respond_to?(:amount=) && defined?(Money)
+      s.latitude        = BigDecimal("12.123456")
+      s.longitude       = BigDecimal("-68.987654")
       s.description     = "<p>A rich-text body.</p>"
     end
     @full.locales << @locale unless @full.locales.where(id: @locale.id).exists?

data/lib/installer_templates/example_app_tests/test/models/example_app_form_element_showcase_test.rb

@@ -16,6 +16,8 @@ class ExampleAppFormElementShowcaseTest < ActiveSupport::TestCase
     count
     price
     amount
+    latitude
+    longitude
     header_dates
     meeting_date
     meeting_time
@@ -82,4 +84,63 @@ class ExampleAppFormElementShowcaseTest < ActiveSupport::TestCase
     showcase = FormElementShowcase.new(title: "X", count: nil)
     assert showcase.valid?, "expected showcase to be valid with count=nil (allow_blank), got #{showcase.errors.full_messages.inspect}"
   end
+
+  # ---------------------------------------------------------------------
+  # 8.1.10: :decimal_field now maps to a real :decimal column with
+  # precision/scale instead of the legacy varchar. The migration emitter
+  # applies (10, 2) by default and reads `{p,s}` overrides from the CLI
+  # type suffix (e.g. `latitude:decimal_field{9,6}` -> decimal(9,6)).
+  # ---------------------------------------------------------------------
+
+  test "decimal_field maps to a real :decimal column with default precision/scale" do
+    price_col = FormElementShowcase.columns_hash["price"]
+    assert_not_nil price_col, "expected a :price column"
+    assert_equal :decimal, price_col.type,
+      "expected :price to be a :decimal column, got #{price_col.type.inspect} (#{price_col.sql_type.inspect})"
+    assert_equal 10, price_col.precision, "expected default precision: 10"
+    assert_equal  2, price_col.scale,     "expected default scale: 2"
+  end
+
+  test "decimal_field{p,s} CLI suffix sets precision and scale" do
+    lat = FormElementShowcase.columns_hash["latitude"]
+    lon = FormElementShowcase.columns_hash["longitude"]
+    assert_equal :decimal, lat.type
+    assert_equal :decimal, lon.type
+    assert_equal [9, 6],  [lat.precision, lat.scale],
+      "expected latitude:decimal_field{9,6} -> decimal(9,6), got decimal(#{lat.precision},#{lat.scale})"
+    assert_equal [10, 6], [lon.precision, lon.scale],
+      "expected longitude:decimal_field{10,6} -> decimal(10,6), got decimal(#{lon.precision},#{lon.scale})"
+  end
+
+  test "decimal column round-trips BigDecimal losslessly at full scale" do
+    showcase = FormElementShowcase.create!(
+      title: "decimal-roundtrip",
+      latitude:  BigDecimal("12.123456"),
+      longitude: BigDecimal("-68.987654"),
+    )
+    showcase.reload
+    assert_kind_of BigDecimal, showcase.latitude
+    assert_equal BigDecimal("12.123456"),  showcase.latitude
+    assert_equal BigDecimal("-68.987654"), showcase.longitude
+  end
+
+  test "price rejects non-numeric input with a numericality error" do
+    showcase = FormElementShowcase.new(title: "X", price: "ace")
+    assert_not showcase.valid?
+    assert_includes showcase.errors.attribute_names, :price
+    assert showcase.errors[:price].any? { |m| m.match?(/not a number/i) },
+      "expected `not a number` error on :price, got #{showcase.errors[:price].inspect}"
+  end
+
+  test "latitude rejects out-of-range values via numericality range" do
+    showcase = FormElementShowcase.new(title: "X", latitude: 91)
+    assert_not showcase.valid?
+    assert_includes showcase.errors.attribute_names, :latitude
+  end
+
+  test "longitude rejects out-of-range values via numericality range" do
+    showcase = FormElementShowcase.new(title: "X", longitude: 181)
+    assert_not showcase.valid?
+    assert_includes showcase.errors.attribute_names, :longitude
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms_installer
 version: !ruby/object:Gem::Version
-  version: 8.1.9
+  version: 8.1.11
 platform: ruby
 authors:
 - Ace Suares