inline_forms_installer 8.1.56 → 8.1.58

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9b2831a93f9f5c8b73b05ba62ff707b93b8775979e338a51573fd58074dad7ab
-  data.tar.gz: 131524c58a0db8a9cf28838baa2d4d7b70f5e66673e2fbf911c65a36a591801e
+  metadata.gz: c9e3599f9f0622e0fe6e64acfbf1679d07f83a10d5738b555404f1b2fa4a6694
+  data.tar.gz: d45293d3e30a531e61c9a10db1c31981ee58868c3d6830ee8da148eaa60919f7
 SHA512:
-  metadata.gz: a90ea3700df031e6cc35b6d9511c9551676d03de5b86a8fba118e0b6ac4603f8544e6b083e70b91da0ea2975908f29f9a291dca544ffcd2a4fe00725aeae6cba
-  data.tar.gz: b746466b0dc7eb1eb9852700af5a5ea28a4359c265d9cf81751afa54a396cb57d1d1967c4482e9704f0966baa69748c68a56dbf70850dd5935a663938a69289e
+  metadata.gz: be4bac316abc71fd2c200a10eb8d169b7aec2b3772bf44a6dfb2e35ccd1e99344f089ae790c0b6ec1a409f37ee5320ad2e1a2f9e6f3d56e682b15720b39d10fa
+  data.tar.gz: 321944c96eafdaa2ed8cd7b99825522c545aaa1dd26fc8b7604b00c0ca7727bbf87a557f2519b6bbf84ad2bec2915c7ac511334d618b162549c3619a6af752d1

data/lib/inline_forms_installer/version.rb

@@ -1,7 +1,7 @@
 # -*- encoding : utf-8 -*-
 
 module InlineFormsInstaller
-  VERSION = "8.1.56"
+  VERSION = "8.1.58"
 
   # Canonical bare Ruby version (must match gemspec `required_ruby_version`).
   # Written verbatim into generated apps' `.ruby-version` for rbenv/chruby/asdf/

data/lib/installer_templates/dartsass/inline_forms_dartsass_builds.rb

@@ -12,3 +12,19 @@ Rails.application.config.dartsass.builds = {
   "inline_forms_install/inline_forms_main.scss" => "inline_forms/inline_forms.css",
   "inline_forms_install/devise_main.scss" => "inline_forms/devise.css"
 }
+
+# SELF-IMPORT GUARD: put the inline_forms gem's stylesheet dir FIRST on the
+# Sass load path. Dartsass::Runner assembles
+#   dartsass <build_options> --load-path app/assets/stylesheets
+#            --load-path <each config.assets.paths entry> <in:out ...>
+# and Dart Sass takes the first load path that has a match. app/assets/builds
+# is on config.assets.paths BEFORE the gem, and a plain .css file is importable
+# by Sass, so `@use "inline_forms/inline_forms"` (and ".../devise") in the
+# inline_forms_install/*_main.scss entries would resolve to the PREVIOUS OUTPUT
+# app/assets/builds/inline_forms/{inline_forms,devise}.css instead of the gem's
+# .scss: from the second build on, each build re-imports its own stale result
+# and gem stylesheet changes never reach the app. build_options precede the
+# load paths in the command, so this --load-path wins. Single token on
+# purpose: the runner splits every build_options entry on whitespace.
+Rails.application.config.dartsass.build_options <<
+  "--load-path=#{InlineForms::Engine.root.join('app/assets/stylesheets')}"

data/lib/installer_templates/example_app_tests/test/integration/example_app_dartsass_build_test.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require "test_helper"
+require "dartsass/runner"
+require "sass-embedded"
+
+# config/initializers/inline_forms_dartsass_builds.rb puts the gem's
+# stylesheet dir first on the Sass load path. Without it,
+# app/assets/builds (ahead of the gem in config.assets.paths) shadows the
+# gem's .scss: `@use "inline_forms/inline_forms"` in the
+# inline_forms_install/*_main.scss entries re-imports the app's previous
+# compiled CSS, and gem stylesheet changes never reach the app after its
+# first build. test_helper runs dartsass:build, so by now builds/ already held
+# a previous build when this run's one ran.
+class ExampleAppDartsassBuildTest < ActiveSupport::TestCase
+  test "the gem stylesheet dir is the first Sass load path" do
+    command = Dartsass::Runner.dartsass_compile_command
+    first_load_path = command.index { |arg| arg == "--load-path" || arg.start_with?("--load-path=") }
+
+    assert_equal "--load-path=#{gem_stylesheets}", command[first_load_path]
+  end
+
+  %w[inline_forms devise].each do |entry|
+    test "builds/inline_forms/#{entry}.css is compiled from the gem's #{entry}.scss" do
+      built = Rails.root.join("app/assets/builds/inline_forms/#{entry}.css")
+      assert built.file?, "#{built} missing; dartsass:build did not run"
+
+      expected = Sass.compile(File.join(gem_stylesheets, "inline_forms", "#{entry}.scss"),
+                              load_paths: load_paths, style: :compressed,
+                              logger: Sass::Logger.silent).css
+      assert_equal expected.strip, built.read.strip,
+        "#{entry}.css differs from a direct compile of the gem's #{entry}.scss " \
+        "(re-imported a stale app/assets/builds/inline_forms/#{entry}.css?)"
+    end
+  end
+
+  private
+
+  def gem_stylesheets
+    InlineForms::Engine.root.join("app/assets/stylesheets").to_s
+  end
+
+  # The gem's stylesheets, then the app's asset paths without app/assets/builds.
+  def load_paths
+    [ gem_stylesheets ] + Rails.application.config.assets.paths.map(&:to_s)
+                                .reject { |path| path.end_with?("app/assets/builds") }
+  end
+end

data/lib/installer_templates/example_app_tests/test/integration/example_app_devise_sign_in_test.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+# The sign-in page (inline_forms 8.1.57): the Devise layout declares the page
+# language like the inline_forms layout, and the submit button is translated
+# (it was `f.submit :login`, an untranslated "login" in every locale).
+class ExampleAppDeviseSignInTest < ActionDispatch::IntegrationTest
+  setup do
+    host!("www.example.com")
+    @mapping = Devise.mappings.values.first
+  end
+
+  def sign_in_path
+    Rails.application.routes.url_helpers.public_send("new_#{@mapping.name}_session_path")
+  end
+
+  test "the sign-in page declares its language and translates the submit button" do
+    get sign_in_path
+
+    assert_response :success
+    assert_includes @response.body, %(<html lang="#{I18n.locale}">)
+    assert_includes @response.body, %(value="#{I18n.t('inline_forms.devise.login')}")
+  end
+
+  test "the submit label has an nl translation" do
+    assert_equal "inloggen", I18n.t("inline_forms.devise.login", locale: :nl)
+  end
+end

data/lib/installer_templates/example_app_tests/test/integration/example_app_sass_deprecations_test.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+require "test_helper"
+require "sass-embedded"
+
+# Sass @import is removed in Dart Sass 3. Since 8.1.58 the gem's entry points
+# load foundation_and_overrides with @use; the only gem @imports left are the
+# three in foundation_and_overrides.scss that wait for the Foundation decision
+# (see the module-system note in inline_forms/inline_forms.scss). Compiles
+# both entry points from the installed gem, with every deprecation reported
+# (verbose), and fails if the gem gains an @import or an entry point compiles
+# with more [import] warnings than 8.1.58 had.
+class ExampleAppSassDeprecationsTest < ActiveSupport::TestCase
+  GEM_IMPORTS_LEFT = [
+    "foundation_and_overrides.scss 'settings/settings'",
+    "foundation_and_overrides.scss 'foundation'",
+    "foundation_and_overrides.scss 'theme'"
+  ].freeze
+  # 8.1.58 with foundation-rails 6.9.0.0: the three above + 114 inside Foundation.
+  MAX_IMPORT_WARNINGS = 117
+
+  %w[inline_forms devise].each do |entry|
+    test "#{entry}.scss compiles without new @import deprecations" do
+      imports = import_deprecations(entry)
+
+      gem_imports = imports.select { |span| span.url.start_with?(gem_stylesheets_url) }
+                           .map { |span| "#{File.basename(span.url)} #{span.text}" }
+      assert_empty gem_imports - GEM_IMPORTS_LEFT,
+        "#{entry}.scss: new @import in the gem; load it with @use"
+      assert_operator imports.size, :<=, MAX_IMPORT_WARNINGS,
+        "#{entry}.scss: more [import] deprecations than 8.1.58"
+    end
+  end
+
+  private
+
+  def gem_stylesheets
+    InlineForms::Engine.root.join("app/assets/stylesheets").to_s
+  end
+
+  def gem_stylesheets_url
+    "file://#{gem_stylesheets}/"
+  end
+
+  # The gem's stylesheets first, then the app's asset paths without
+  # app/assets/builds (its compiled inline_forms/*.css would shadow the .scss).
+  def load_paths
+    [ gem_stylesheets ] + Rails.application.config.assets.paths.map(&:to_s)
+                                .reject { |path| path.end_with?("app/assets/builds") }
+  end
+
+  def import_deprecations(entry)
+    spans = []
+    logger = {
+      warn: lambda do |_message, context|
+        spans << context.span if context.deprecation && context.deprecation_type == "import"
+      end
+    }
+    Sass.compile(File.join(gem_stylesheets, "inline_forms", "#{entry}.scss"),
+                 load_paths: load_paths, style: :compressed, verbose: true, logger: logger)
+    spans
+  end
+end

data/lib/installer_templates/example_app_tests/test/integration/example_app_turbo_layout_test.rb

@@ -11,7 +11,7 @@ class ExampleAppTurboLayoutTest < ExampleAppIntegrationTestCase
     assert_response :success
 
     assert_match(
-      %r{<script\s+type="module">\s*import\s+\{\s*Turbo\s*\}\s+from\s+"[^"]*turbo\.min(?:-[a-f0-9]+)?\.js"}m,
+      %r{<script\s+type="module"[^>]*>\s*import\s+\{\s*Turbo\s*\}\s+from\s+"[^"]*turbo\.min(?:-[a-f0-9]+)?\.js"}m,
       @response.body,
       "expected the inline_forms layout to import turbo.min.js as a module"
     )

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms_installer
 version: !ruby/object:Gem::Version
-  version: 8.1.56
+  version: 8.1.58
 platform: ruby
 authors:
 - Ace Suares
@@ -97,7 +97,9 @@ files:
 - lib/installer_templates/example_app_tests/test/integration/example_app_apartment_top_level_new_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_apartment_top_level_pagination_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_apartment_versions_turbo_test.rb
+- lib/installer_templates/example_app_tests/test/integration/example_app_dartsass_build_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_devise_passwords_test.rb
+- lib/installer_templates/example_app_tests/test/integration/example_app_devise_sign_in_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_guest_access_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_layout_title_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_owner_tabs_test.rb
@@ -106,6 +108,7 @@ files:
 - lib/installer_templates/example_app_tests/test/integration/example_app_photos_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_production_ssl_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_routing_test.rb
+- lib/installer_templates/example_app_tests/test/integration/example_app_sass_deprecations_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_schema_edit_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_choice_scale_fields_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_date_time_fields_test.rb