inline_forms_installer 8.1.46 → 8.1.53

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5324f58fc1a40db3f06aabfa54d4a6d595c3e8e6664e27e14b2357472f5e8f93
-  data.tar.gz: c747d14c7ce8cdc0f7e1b83d041eba5e56e9be64bb7caab64a9f2632dbfa565b
+  metadata.gz: d6ae21066b6f0b20f52c9d8800b0e7bf580c2dbd3124c85f8521c47d7113ed98
+  data.tar.gz: 4e6d67961a89c567d52fb9efc82215eae83ebadc89c908556ed606a38268b316
 SHA512:
-  metadata.gz: a1ac87fc5d46614dc96347e5c6d17113db86294d09c3722dfdfb12aea51a0c4c4b6a8b5c8c3fbdb16cd554ef81d8b7dff272dfcf33499de65ef20ae521978fcd
-  data.tar.gz: f3e760b1aff15c1b75b01de8fb6f3c922b48d527493d6bbfebde1232c700c732c98099a30bf40167705fa9c16f7bcdb22c611bb81bca76be82817aeaedb7b0aa
+  metadata.gz: 9c8cbab1fe17fd2f2c0041580a56936529c83310fd48f23df359f2f63e748bf1f5fa9aed85dd632eb42e95dadb8492ffb7410108eaefd3bec3dee609154a5c33
+  data.tar.gz: 934023b6ec6c9ab6314573134b330e46ffbb609be112f88135ae4efae97ceed073a443cd51c630310660c61b9aed19c9f3d6d142cb7e178f47fb0f862605782d

data/lib/inline_forms_installer/installer_core.rb

@@ -571,6 +571,15 @@ generate "paper_trail:install --with-changes"
 # paper_trail emits two migrations in one second; the next generator would reuse that timestamp.
 sleep 1
 
+say "- File trash for declared file slots (simple_file_field)..."
+# Tables for InlineForms::StoredFiles: removed/replaced files stay restorable
+# for InlineForms.file_trash_retention (30 days) before the nightly sweep
+# (`rails inline_forms:file_trash:purge_expired`, from cron) purges them.
+# Plus the superadmin page listing every trashed file.
+generate "inline_forms:file_trash"
+sleep 1
+route "InlineForms.draw_file_trash_routes(self)"
+
 say "- Track ActionText (rich_text) edits with PaperTrail..."
 # `has_rich_text :foo` stores the body in the separate `action_text_rich_texts`
 # table, not on the parent model, so `has_paper_trail` on the parent never
@@ -649,6 +658,9 @@ PT_YAML
 say "- Creating application title via locales..."
 create_file "config/locales/inline_forms_local.en.yml", <<-END_LOCALE.strip_heredoc
   en:
+    # <title> of every page in the inline_forms layout (falls back to
+    # ApplicationHelper#application_name in locales that do not define it).
+    application_name: #{app_name}
     inline_forms:
       general:
         application_title: #{app_name}
@@ -847,11 +859,13 @@ copy_file File.join(INSTALLER_ROOT,'lib/installer_templates/unicorn/production.r
 
 # Schema-change GUI (dev-only authoring; InlineForms::SchemaController from
 # the inline_forms_schema_edit gem). Wired only when requested via
-# `--schema-edit` (implied by `--example`): routes + a "+ field" nav link.
+# `--schema-edit` (implied by `--example`): routes + batch tables. The
+# "+ field" nav link is example-app only (example_app_views/inline_forms/
+# _model_top_bar_left.html.erb), never in the engine's top bar.
 # Applies inline_forms_addto through the browser; does NOT run db:migrate.
 # Must precede the example section: its test gate exercises these routes.
 if ENV['install_schema_edit'] == 'true'
-  say "- Schema GUI: routes + nav link + batch tables..."
+  say "- Schema GUI: routes + batch tables..."
   # One line: the gem owns its route set, so gem upgrades can add routes
   # without editing the app's routes.rb.
   route 'InlineFormsSchemaEdit.draw_routes(self)'
@@ -1226,7 +1240,7 @@ if ENV['install_example'] == 'true'
   # ---------------------------------------------------------------------
   say "- Generating FormElementShowcase (one resource per kept Tier 1 form_element)..."
   sleep 1
-  run %q{bundle exec rails g inline_forms FormElementShowcase title:string body_plain_area:plain_text_area count:integer_field price:decimal_field amount:money_field latitude:decimal_field{9,6} longitude:decimal_field{10,6} meeting_date:date_select meeting_time:time_select birth_month:month_select start_month:month_year_picker is_active:check_box gender:radio_button rating_int:dropdown_with_integers priority:dropdown_with_values priority2:dropdown_with_values stars:dropdown_with_values_with_stars scale_int:scale_with_integers scale_val:scale_with_values attachment:file_field jingle:audio_field cover:image_field gallery:multi_image_field description:rich_text locales:has_and_belongs_to_many _enabled:yes _list_order:title _list_search:title _presentation:'#{title}'}
+  run %q{bundle exec rails g inline_forms FormElementShowcase title:string body_plain_area:plain_text_area count:integer_field price:decimal_field amount:money_field latitude:decimal_field{9,6} longitude:decimal_field{10,6} meeting_date:date_select meeting_time:time_select birth_month:month_select start_month:month_year_picker is_active:check_box gender:radio_button rating_int:dropdown_with_integers priority:dropdown_with_values priority2:dropdown_with_values stars:dropdown_with_values_with_stars scale_int:scale_with_integers scale_val:scale_with_values attachment:file_field jingle:audio_field cover:image_field gallery:multi_image_field manual:simple_file_field description:rich_text locales:has_and_belongs_to_many _enabled:yes _list_order:title _list_search:title _presentation:'#{title}'}
 
   say "- Generating Attachment + Jingle uploaders (Cover reuses ImageUploader)..."
   run "bundle exec rails generate uploader Attachment"
@@ -1385,6 +1399,7 @@ if ENV['install_example'] == 'true'
           jingle: Jingle
           cover: Cover
           gallery: Gallery (multiple images)
+          manual: Manual (file slot with trash)
           description: Description
           locales: Locales (editable)
           locales_display: Locales (read-only)

data/lib/inline_forms_installer/version.rb

@@ -1,7 +1,7 @@
 # -*- encoding : utf-8 -*-
 
 module InlineFormsInstaller
-  VERSION = "8.1.46"
+  VERSION = "8.1.53"
 
   # Canonical bare Ruby version (must match gemspec `required_ruby_version`).
   # Written verbatim into generated apps' `.ruby-version` for rbenv/chruby/asdf/

data/lib/installer_templates/example_app_tests/test/integration/example_app_layout_title_test.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+require_relative "../example_app/example_integration_test_case"
+
+# layouts/inline_forms <title> (inline_forms 8.1.53): the installer writes
+# `application_name` into config/locales/inline_forms_local.en.yml, and the
+# layout falls back to ApplicationHelper#application_name, so the title is
+# "<app name> v<version>" — never the html_safe translation_missing span.
+class ExampleAppLayoutTitleTest < ExampleAppIntegrationTestCase
+  def page_title
+    @response.body[%r{<title>(.*?)</title>}m, 1]
+  end
+
+  def expected_title
+    "#{ERB::Util.h(ApplicationController.helpers.application_name)} v#{InlineForms::VERSION}"
+  end
+
+  test "installer defines the en application_name translation" do
+    assert I18n.exists?(:application_name, :en)
+    assert_equal ApplicationController.helpers.application_name, I18n.t(:application_name, locale: :en)
+  end
+
+  test "apartments page title is the app name and version" do
+    get apartments_path
+
+    assert_response :success
+    assert_equal expected_title, page_title
+  end
+
+  test "file trash page title is the app name and version" do
+    get "/file_trash"
+
+    assert_response :success
+    assert_equal expected_title, page_title
+  end
+
+  test "title in nl falls back to the app name, not a placeholder" do
+    admin = User.find_by!(email: "admin@example.com")
+    nl = Locale.find_or_create_by!(name: "nl") { |l| l.title = "Nederlands" }
+    admin.update!(locale: nl)
+    sign_in admin
+
+    get apartments_path
+
+    assert_response :success
+    assert_includes @response.body, %(<html lang="nl">)
+    assert_equal expected_title, page_title
+  ensure
+    en = Locale.find_by(name: "en")
+    admin&.update!(locale: en) if en
+  end
+end

data/lib/installer_templates/example_app_tests/test/integration/example_app_schema_edit_test.rb

@@ -16,6 +16,13 @@ class ExampleAppSchemaEditTest < ExampleAppIntegrationTestCase
     assert_includes @response.body, "text_field"
   end
 
+  test "the example app's top bar links the schema GUI" do
+    get apartments_path
+    assert_response :success
+    assert_includes @response.body, %(href="/schema/new")
+    assert_includes @response.body, "+ field"
+  end
+
   test "schema/preview shows a new scalar field on Apartment without changing the schema" do
     refute_includes Apartment.column_names, "staff_note",
       "precondition: staff_note must not already exist"

data/lib/installer_templates/example_app_tests/test/integration/example_app_showcase_file_slot_test.rb

@@ -0,0 +1,102 @@
+# frozen_string_literal: true
+
+require_relative "../example_app/example_integration_test_case"
+
+# FormElementShowcase#manual is a declared file slot (generated from
+# `manual:simple_file_field`: InlineForms::StoredFiles, manual_data /
+# manual_content_type columns, InlineForms.file_routes in routes.rb, the
+# inline_forms:file_trash migration). Exercises the generated wiring end to
+# end as the superadmin: upload, replace, remove, undo, purge, the global
+# trash page, and that reverting an unrelated edit keeps the file.
+class ExampleAppShowcaseFileSlotTest < ExampleAppIntegrationTestCase
+  PDF = "%PDF-1.4 example file slot".b
+  OTHER = "%PDF-1.4 a different file".b
+
+  setup do
+    @showcase = FormElementShowcase.create!(title: "File slot demo")
+    @frame = "form_element_showcase_#{@showcase.id}_manual"
+  end
+
+  def upload(bytes, name)
+    Rack::Test::UploadedFile.new(StringIO.new(bytes), "application/pdf", original_filename: name)
+  end
+
+  def put_manual(bytes, name)
+    patch form_element_showcase_path(@showcase, attribute: "manual", form_element: "simple_file_field", update: @frame),
+          params: { manual: upload(bytes, name) }, headers: { "Turbo-Frame" => @frame }
+  end
+
+  def stream_headers
+    { "Turbo-Frame" => @frame, "Accept" => "text/vnd.turbo-stream.html" }
+  end
+
+  test "the generated model declares the slot and skips it in PaperTrail" do
+    assert FormElementShowcase.inline_forms_file_slot?(:manual)
+    assert_includes FormElementShowcase.paper_trail_options[:skip], "manual_data"
+  end
+
+  test "upload, replace, remove, undo and purge" do
+    put_manual(PDF, "first.pdf")
+    assert_response :success
+    assert_equal PDF, @showcase.reload.manual_data
+
+    put_manual(OTHER, "second.pdf")
+    assert_equal OTHER, @showcase.reload.manual_data
+    replaced = InlineForms::TrashedFile.trash_entries.where(reason: "replaced").sole
+    assert_equal "first.pdf", replaced.filename
+
+    post remove_file_form_element_showcase_path(@showcase, attribute: "manual", update: @frame), headers: stream_headers
+    assert_response :success
+    assert_nil @showcase.reload.manual_data
+    removed = InlineForms::TrashedFile.trash_entries.where(reason: "removed").sole
+
+    post restore_file_form_element_showcase_path(@showcase, attribute: "manual", trash_id: removed.id, update: @frame),
+         headers: stream_headers
+    assert_equal OTHER, @showcase.reload.manual_data
+
+    post purge_file_form_element_showcase_path(@showcase, attribute: "manual", trash_id: replaced.id, update: @frame),
+         headers: stream_headers
+    assert replaced.reload.purged?
+    assert_nil replaced.file_data
+  end
+
+  test "download_file sends the stored bytes" do
+    put_manual(PDF, "first.pdf")
+    get download_file_form_element_showcase_path(@showcase, attribute: "manual")
+
+    assert_response :success
+    assert_equal PDF, response.body.b
+  end
+
+  test "reverting an unrelated edit keeps the file" do
+    put_manual(PDF, "first.pdf")
+    @showcase.update!(title: "Renamed")
+    version = @showcase.versions.where(event: "update").last
+    row = "form_element_showcase_#{@showcase.id}"
+
+    post revert_form_element_showcase_path(version, update: row),
+         headers: { "Turbo-Frame" => row, "Accept" => "text/vnd.turbo-stream.html" }
+
+    @showcase.reload
+    assert_equal "File slot demo", @showcase.title
+    assert_equal PDF, @showcase.manual_data
+  end
+
+  test "the global trash page renders for the superadmin" do
+    put_manual(PDF, "first.pdf")
+    post remove_file_form_element_showcase_path(@showcase, attribute: "manual", update: @frame), headers: stream_headers
+
+    get inline_forms_file_trash_path
+    assert_response :success
+    assert_includes response.body, "first.pdf"
+  end
+
+  test "the user menu links the trash, next to logout" do
+    get form_element_showcases_path
+    assert_response :success
+
+    user_menu = response.body.scan(/<ul class="menu">(.*?)<\/ul>/m).flatten.find { |menu| menu.include?(destroy_user_session_path) }
+    assert user_menu, "no user menu with the logout link"
+    assert_includes user_menu, %(href="#{inline_forms_file_trash_path}")
+  end
+end

data/lib/installer_templates/example_app_tests/test/models/example_app_form_element_showcase_test.rb

@@ -36,6 +36,7 @@ class ExampleAppFormElementShowcaseTest < ActiveSupport::TestCase
     attachment
     jingle
     cover
+    manual
     header_rich
     description
     locales

data/lib/installer_templates/example_app_views/inline_forms/_header.html.erb

@@ -39,6 +39,9 @@
         <li>
           <a href="#"><%= current_user.name %></a>
           <ul class="menu">
+            <% if (trash_link = link_to_inline_forms_file_trash) %>
+              <li><%= trash_link %></li>
+            <% end %>
             <li>
               <%= link_to( t("common.logout"), destroy_user_session_path, :method => :delete) if current_user  %>
             </li>

data/lib/installer_templates/example_app_views/inline_forms/_model_top_bar_left.html.erb

@@ -0,0 +1,6 @@
+<%# Example app only: link to the dev-only schema GUI (inline_forms_schema_edit). %>
+<% if respond_to?(:inline_forms_schema_new_path) %>
+  <li class="menu-text">
+    <%= link_to "+ field", inline_forms_schema_new_path, data: { turbo: false }, title: "Add a field to a model (dev only)" %>
+  </li>
+<% end %>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms_installer
 version: !ruby/object:Gem::Version
-  version: 8.1.46
+  version: 8.1.53
 platform: ruby
 authors:
 - Ace Suares
@@ -98,6 +98,7 @@ files:
 - lib/installer_templates/example_app_tests/test/integration/example_app_apartment_top_level_pagination_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_apartment_versions_turbo_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_guest_access_test.rb
+- lib/installer_templates/example_app_tests/test/integration/example_app_layout_title_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_owner_tabs_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_photo_comments_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_photo_revert_test.rb
@@ -107,6 +108,7 @@ files:
 - lib/installer_templates/example_app_tests/test/integration/example_app_schema_edit_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_choice_scale_fields_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_date_time_fields_test.rb
+- lib/installer_templates/example_app_tests/test/integration/example_app_showcase_file_slot_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_gallery_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_locales_associations_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_money_update_test.rb
@@ -126,6 +128,7 @@ files:
 - lib/installer_templates/example_app_tests/test/models/example_app_plain_text_rich_text_edge_cases_test.rb
 - lib/installer_templates/example_app_views/apartments/name_list.html.erb
 - lib/installer_templates/example_app_views/inline_forms/_header.html.erb
+- lib/installer_templates/example_app_views/inline_forms/_model_top_bar_left.html.erb
 - lib/installer_templates/example_app_views/owners/_owner_tabs.html.erb
 - lib/installer_templates/example_app_views/owners/show_with_tabs.html.erb
 - lib/installer_templates/unicorn/production.rb