inline_forms_installer 8.1.40 → 8.1.42

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 94ac8df294cd719110b2360768007fbfb8c26c95749c95323a0e61b969801b4e
-  data.tar.gz: b5c245794ab67879467b227eef31fb523927f5c8f27634bb48f173222246da0c
+  metadata.gz: d09ceda3c59a9d785f9a7270e58254f1ace6e43ed605f9681e8046c1ad67f8a7
+  data.tar.gz: 35178d8b5bf044d7f941efa611bd39512f3060bc996b7669a12ed9e8c6721e6a
 SHA512:
-  metadata.gz: c8e07fcf3fa59b3a0c0a8b548ec06f78032e9659410351abe5ae13f2d03e2b8f66e4d3321f2111367dd9aec31daaa8263b1eeabfb79d2736fc2fb0745652ff12
-  data.tar.gz: 866e3d7586e1e03b3d19e5023f834f8665794d436e17b7a6d58f95a8c1aa095c3cff58687d34b18cd77be65fc875d24517a4c130d1792ee7a2c895341b903d9a
+  metadata.gz: c57d71b4fa224a31135385f43175c50fcf4e54611965797726b3a8ea4dd89233e9bcac54a2f4180fbf8a5c692f9cc0b7710adee7040bca89dd291c59c43fe178
+  data.tar.gz: 7ca6d416410ef9d1342c6bd6339b3be6f6bdda2923465d1653d357729c0b3b94a90b2f00ed98e33f855fda4722d0b5a0580436c5358fdae278119d9bf9661ce1

data/lib/inline_forms_installer/creator.rb

@@ -20,6 +20,7 @@ module InlineFormsInstaller
     DATABASE_OPTIONS = %w[sqlite mysql]
     method_option :database, aliases: "-d", banner: DATABASE_OPTIONS.join("|"), desc: "specify development database"
     method_option :example, type: :boolean, desc: "install the example app. uses sqlite as development database"
+    method_option :schema_edit, type: :boolean, default: false, desc: "mount the schema-change GUI (inline_forms_schema_edit gem); implied by --example"
     method_option :email, aliases: "-e", default: "admin@example.com", desc: "specify admin email"
     method_option :password, aliases: "-p", default: "admin999", desc: "specify admin password"
     method_option :skiprvm, aliases: "--no-rvm", type: :boolean, default: false, desc: "install inline_forms without RVM"
@@ -125,6 +126,8 @@ module InlineFormsInstaller
       ENV["using_sqlite"] = using_sqlite?.to_s
       ENV["database"] = database
       ENV["install_example"] = install_example?.to_s
+      # The example app always mounts the schema GUI (it demos + tests it).
+      ENV["install_schema_edit"] = (options[:schema_edit] || install_example?).to_s
       # Match the generated `.ruby-version` to the version manager actually in
       # use. RVM's `.ruby-version` reader needs the `ruby-X.Y.Z` form — a bare
       # `X.Y.Z` makes `rvm use .` bail with "do not know how to handle" and skip

data/lib/inline_forms_installer/installer_core.rb

@@ -45,7 +45,7 @@ def install_prerelease_gems_from_roots!
   roots.uniq!
   return if roots.empty?
 
-  %w[validation_hints inline_forms inline_forms_installer].each do |name|
+  %w[validation_hints inline_forms inline_forms_installer inline_forms_schema_edit].each do |name|
     # Pick the *highest version*, not the highest filename. String sort
     # placed `inline_forms-8.1.7.gem` above `inline_forms-8.1.10.gem`
     # because "7" > "1" lexicographically — silently picking up a stale
@@ -62,7 +62,13 @@ def install_prerelease_gems_from_roots!
     # the exact shape that bit us between 8.1.6 (default gemset's
     # highest installer) and 8.1.10.
     candidates = roots.flat_map { |root|
-      Dir[File.join(root, "#{name}-*.gem"), File.join(root, "pkg", "#{name}-*.gem")]
+      # inline_forms_schema_edit lives in a subdirectory of the inline_forms
+      # checkout with its own pkg/; glob both layouts for every name (the
+      # extra patterns simply match nothing for the root-level gems).
+      Dir[File.join(root, "#{name}-*.gem"),
+          File.join(root, "pkg", "#{name}-*.gem"),
+          File.join(root, name, "#{name}-*.gem"),
+          File.join(root, name, "pkg", "#{name}-*.gem")]
     }
     gem_file = candidates.max_by do |path|
       ver_str = File.basename(path, ".gem").sub(/\A#{Regexp.escape(name)}-/, "")
@@ -119,6 +125,18 @@ if ENV["INLINE_FORMS_GEMFILE_PATH"] && File.directory?(ENV["INLINE_FORMS_GEMFILE
 else
   gem "inline_forms", "~> 8"
 end
+# Schema-change GUI (separate mountable engine gem): only when requested via
+# `--schema-edit` (implied by `--example`). Apps that never change their own
+# schema ship without this surface entirely.
+if ENV["install_schema_edit"] == "true"
+  schema_edit_path = ENV["INLINE_FORMS_GEMFILE_PATH"] &&
+                    File.join(ENV["INLINE_FORMS_GEMFILE_PATH"], "inline_forms_schema_edit")
+  if schema_edit_path && File.directory?(schema_edit_path)
+    gem "inline_forms_schema_edit", path: schema_edit_path
+  else
+    gem "inline_forms_schema_edit", "~> 8"
+  end
+end
 # jQuery is required by Foundation 6's JS only. jQuery UI is fully gone since
 # 8.1.26 (native date/time/month inputs in 8.1.25; datalist combobox + range
 # slider in 8.1.26), as are jquery-timepicker-rails, jquery-ui-rails and
@@ -831,6 +849,32 @@ copy_file File.join(INSTALLER_ROOT,'lib/installer_templates/capistrano/Capfile')
 say "- Unicorn Config..."
 copy_file File.join(INSTALLER_ROOT,'lib/installer_templates/unicorn/production.rb'), "config/unicorn/production.rb"
 
+# Schema-change GUI (dev-only authoring; InlineForms::SchemaController from
+# the inline_forms_schema_edit gem). Wired only when requested via
+# `--schema-edit` (implied by `--example`): routes + a "+ field" nav link.
+# Applies inline_forms_addto through the browser; does NOT run db:migrate.
+# Must precede the example section: its test gate exercises these routes.
+if ENV['install_schema_edit'] == 'true'
+  say "- Schema GUI: routes + nav link + batch tables..."
+  # One line: the gem owns its route set, so gem upgrades can add routes
+  # without editing the app's routes.rb.
+  route 'InlineFormsSchemaEdit.draw_routes(self)'
+
+  # Batch-pipeline tables (drafted intents + batches). The generator writes
+  # the migration; migrate here for sqlite (mysql apps migrate by hand, same
+  # policy as the main install).
+  run "bundle exec rails g inline_forms_schema_edit:install"
+  run "bundle exec rake db:migrate" if ENV['using_sqlite'] == 'true'
+
+  if File.exist?("app/views/_inline_forms_tabs.html.erb")
+    inject_into_file "app/views/_inline_forms_tabs.html.erb",
+                     "        <li class=\"menu-text\">\n" \
+                     "          <a href=\"/schema/new\" data-turbo=\"false\" title=\"Add a field to a model (dev only)\">+ field</a>\n" \
+                     "        </li>\n",
+                     before: "      </ul>\n    </div>\n    <div class=\"top-bar-right\">"
+  end
+end
+
 # Git
 say "- adding and committing to git..."
 
@@ -1498,6 +1542,16 @@ if ENV['install_example'] == 'true'
   say "- Running showcase migrations (create table + join + seed)..."
   run "bundle exec rake db:migrate"
 
+  # End-to-end exercise of `rails g inline_forms_addto` on an existing model.
+  # Apartment is _enabled and uses the stock inline_forms show (Owner's tabbed
+  # controller whitelists fields, so a new field would be hidden there). This
+  # proves generate + migrate + boot + render + update against a real app; the
+  # accompanying integration test is example_app_apartment_addto_field_test.rb.
+  say "- addto demo: adding Apartment#internal_note via inline_forms_addto..."
+  sleep 1
+  run "bundle exec rails g inline_forms_addto Apartment internal_note:string"
+  run "bundle exec rake db:migrate"
+
   example_views_root = File.join(INSTALLER_ROOT, "lib/installer_templates/example_app_views")
   Dir.glob(File.join(example_views_root, "**", "*")).sort.each do |abs|
     next unless File.file?(abs)
@@ -1506,6 +1560,7 @@ if ENV['install_example'] == 'true'
   end
 
   route 'get "apartments/name_list", to: "apartments#name_list", as: :apartment_name_list'
+
   route "root :to => 'apartments#index'"
 
   example_tests_root = File.join(INSTALLER_ROOT, "lib/installer_templates/example_app_tests")

data/lib/inline_forms_installer/version.rb

@@ -1,7 +1,7 @@
 # -*- encoding : utf-8 -*-
 
 module InlineFormsInstaller
-  VERSION = "8.1.40"
+  VERSION = "8.1.42"
 
   # Canonical bare Ruby version (must match gemspec `required_ruby_version`).
   # Written verbatim into generated apps' `.ruby-version` for rbenv/chruby/asdf/

data/lib/installer_templates/example_app_tests/test/integration/example_app_apartment_addto_field_test.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+require_relative "../example_app/example_integration_test_case"
+
+# End-to-end coverage for `rails g inline_forms_addto Apartment
+# internal_note:string`, which the installer runs during --example. Proves the
+# generated column migrated, the new attribute_list row renders on the stock
+# show panel, and an inline edit/update round-trips through the generic
+# controller.
+class ExampleAppApartmentAddtoFieldTest < ExampleAppIntegrationTestCase
+  setup do
+    @apartment = Apartment.find_or_create_by!(name: "Addto Field Apt") do |a|
+      a.title = "Addto Field Title"
+    end
+    @frame_id = "apartment_#{@apartment.id}_internal_note"
+    @turbo_headers = { "Turbo-Frame" => @frame_id }
+  end
+
+  test "internal_note column exists after the addto migration" do
+    assert_includes Apartment.column_names, "internal_note",
+      "inline_forms_addto migration should have added the internal_note column"
+  end
+
+  test "internal_note row renders on the stock show panel" do
+    row_frame = "apartment_#{@apartment.id}"
+    get apartment_path(@apartment, update: row_frame),
+        headers: { "Turbo-Frame" => row_frame, "Accept" => "text/html" }
+
+    assert_response :success
+    assert_includes @response.body, @frame_id,
+      "the addto attribute_list row should render its own per-field turbo-frame"
+  end
+
+  test "internal_note inline edit and update round-trips" do
+    get edit_apartment_path(
+      @apartment,
+      attribute: "internal_note",
+      form_element: "text_field",
+      update: @frame_id
+    ), headers: @turbo_headers
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{@frame_id}">)
+
+    put apartment_path(
+      @apartment,
+      attribute: "internal_note",
+      form_element: "text_field",
+      update: @frame_id
+    ), params: { internal_note: "Boiler serviced 2026-07" }, headers: @turbo_headers
+    assert_response :success
+    assert_includes @response.body, "Boiler serviced 2026-07"
+    assert_equal "Boiler serviced 2026-07", @apartment.reload.internal_note
+  end
+end

data/lib/installer_templates/example_app_tests/test/integration/example_app_schema_edit_test.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+require_relative "../example_app/example_integration_test_case"
+
+# The dev-only schema-change GUI (InlineForms::SchemaController), mounted only
+# in the example app. Non-destructive coverage: the new form renders and a
+# preview of a brand-new scalar field on Apartment renders with no schema
+# change. Apply (the actual generator run) is covered by the engine dummy suite
+# (recording executor) and inline_forms_addto_generator_test, so this test does
+# not mutate the generated app during the shared gate.
+class ExampleAppSchemaEditTest < ExampleAppIntegrationTestCase
+  test "schema/new renders the add-a-field form" do
+    get "/schema/new"
+    assert_response :success
+    assert_includes @response.body, "Form element"
+    assert_includes @response.body, "text_field"
+  end
+
+  test "schema/preview shows a new scalar field on Apartment without changing the schema" do
+    refute_includes Apartment.column_names, "staff_note",
+      "precondition: staff_note must not already exist"
+
+    post "/schema/preview",
+         params: { model_name: "Apartment", attribute: "staff_note",
+                   form_element: "text_field", after: "name" }
+
+    assert_response :success
+    assert_includes @response.body, "staff_note (new)"
+    assert_includes @response.body, %(name="staff_note")
+
+    Apartment.reset_column_information
+    refute_includes Apartment.column_names, "staff_note",
+      "preview must not add a column"
+  end
+
+  # Batch pipeline (phases 1-3): the install generator created the tables,
+  # so draft -> submit -> token export works end to end in a generated app.
+  # No codegen happens (batch mode never generates in the request cycle), so
+  # this cannot mutate the app during the shared gate.
+  test "batch drafting, freeze on submit, and token-authenticated export" do
+    post "/schema/draft",
+         params: { model_name: "Apartment", attribute: "staff_note",
+                   form_element: "text_field", after: "name", label: "Staff note" }
+    assert_response :redirect
+
+    batch = InlineForms::SchemaBatch.with_status(:draft).last
+    assert_equal 1, batch.intents.count
+
+    get "/schema"
+    assert_response :success
+    assert_includes @response.body, "staff_note"
+
+    post "/schema/batch/submit"
+    batch.reload
+    assert_equal "submitted", batch.status
+    assert_match(/\Asha256:/, batch.content_digest)
+    refute batch.intents.first.update(label: "changed"), "frozen after submit"
+
+    original_token = InlineFormsSchemaEdit.export_token
+    InlineFormsSchemaEdit.export_token = "gate-test-token"
+    begin
+      get "/schema/batches/#{batch.id}/export.json"
+      assert_response :unauthorized, "token configured but not provided"
+
+      get "/schema/batches/#{batch.id}/export.json",
+          headers: { "Authorization" => "Bearer gate-test-token" }
+      assert_response :success
+      payload = JSON.parse(@response.body)
+      assert_equal batch.content_digest, payload["digest"]
+      assert_equal "staff_note", payload["intents"].first["attribute"]
+    ensure
+      InlineFormsSchemaEdit.export_token = original_token
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms_installer
 version: !ruby/object:Gem::Version
-  version: 8.1.40
+  version: 8.1.42
 platform: ruby
 authors:
 - Ace Suares
@@ -87,6 +87,7 @@ files:
 - lib/installer_templates/example_app_assets/seed_images/apt3_loft.png
 - lib/installer_templates/example_app_assets/seed_images/apt3_view.png
 - lib/installer_templates/example_app_tests/test/example_app/example_integration_test_case.rb
+- lib/installer_templates/example_app_tests/test/integration/example_app_apartment_addto_field_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_apartment_field_turbo_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_apartment_name_list_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_apartment_name_required_test.rb
@@ -103,6 +104,7 @@ files:
 - lib/installer_templates/example_app_tests/test/integration/example_app_photos_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_production_ssl_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_routing_test.rb
+- lib/installer_templates/example_app_tests/test/integration/example_app_schema_edit_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_choice_scale_fields_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_date_time_fields_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_gallery_test.rb