inline_forms_installer 8.1.18 → 8.1.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8f04e2b37e58d0c6658da6ab3cc13ae2a44e22bb898fac9e8980960fd5d61378
-  data.tar.gz: c6fe8cc0545e99c3671824b7858136ab6f36c696602c3db9ac5f0ea91c686c96
+  metadata.gz: e2acd92d33de3e1bcd824630a6a4e5166906d938ffb4baa18e8580cb9c8df63b
+  data.tar.gz: e26ce5fb20d87ac207540afa979ab716f2d5713663b3608eceb0b7185d1fab8f
 SHA512:
-  metadata.gz: 2ec0b4161bf92dcaf7de326218c891dafaaf490c5a16f4850211bbc52672b75e96ab6f55291bdc79fae8a980c4c1cb6d93c036a07384c96e3a48801cd45167dc
-  data.tar.gz: 83c865c2688e60ec6b06a0c811d7bccea25a9d252e1d2a70bf7328443dd869c438463a689f3127957c7563bc426f5434871993ea9eef8c53b46df3fbc3740456
+  metadata.gz: 40cd451d291f9920a74d09f4f7e2b61166438413b06e2c73d51463d84ddce674ac7ed88753f6276503953e0c99792761c9cfcdbd09a6290e64fcd18b47099084
+  data.tar.gz: 5a87788bf2d7c3878102d7e973f63565c12532de1677043e39c4bee61472c4ea710362ebbebc177b544242db56e9e9a0e5c8673c83a1fa9acd1216d8afcf31cd

data/lib/inline_forms_installer/version.rb

@@ -1,6 +1,6 @@
 # -*- encoding : utf-8 -*-
 module InlineFormsInstaller
-  VERSION = "8.1.18"
+  VERSION = "8.1.20"
 
   # Canonical bare Ruby version (must match gemspec `required_ruby_version`).
   # Written verbatim into generated apps' `.ruby-version` for rbenv/chruby/asdf/

data/lib/installer_templates/example_app_tests/test/integration/example_app_showcase_money_update_test.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+require_relative "../example_app/example_integration_test_case"
+
+# Regression for the inline attribute :update action.
+#
+# The bug: `update` ignored the return value of `@object.save` and always
+# re-rendered `field_show` from the in-memory `@object`. money-rails rejects
+# an unparseable amount like "99.ace99" (the monetized validator fails, so
+# `save` returns false and `amount_cents` is never written), yet the user saw
+# a "saved" show of the unsaved in-memory value. Re-opening the edit revealed
+# the old value -- the success render was a lie.
+#
+# The fix branches on `@object.save`: on failure it re-renders the EDIT field
+# (with the rejected raw input still visible) instead of a fake show.
+class ExampleAppShowcaseMoneyUpdateTest < ExampleAppIntegrationTestCase
+  setup do
+    skip "money-rails monetize not configured" unless FormElementShowcase.respond_to?(:monetized_attributes) &&
+      FormElementShowcase.monetized_attributes.key?("amount")
+
+    # Mirror the seeded "Full demo" showcase ($99.95 == 9995 cents).
+    @showcase = FormElementShowcase.find_or_create_by!(title: "Full demo")
+    @showcase.update!(amount: Money.from_amount(99.95, "USD"))
+    assert_equal 9995, @showcase.reload.amount_cents
+
+    @frame = "form_element_showcase_#{@showcase.id}_amount"
+    @headers = { "Turbo-Frame" => @frame, "Accept" => "text/html" }
+  end
+
+  test "malformed money update does not persist and re-renders the edit field, not a fake show" do
+    put form_element_showcase_path(
+      @showcase,
+      attribute: "amount",
+      form_element: "money_field",
+      update: @frame
+    ), params: { amount: "99.ace99" }, headers: @headers
+
+    assert_response :success
+
+    # The DB value is untouched -- no silent mutation, no bad write.
+    assert_equal 9995, @showcase.reload.amount_cents,
+      "malformed '99.ace99' must not persist; amount_cents should stay 9995"
+    assert_equal Money.from_amount(99.95, "USD"), @showcase.reload.amount
+
+    body = @response.body
+
+    # The response is the EDIT state (text field), not a turbo field_show.
+    assert_includes body, %(<turbo-frame id="#{@frame}">)
+    assert_includes body, "input_money_field",
+      "expected the edit text field (input_money_field) to be re-rendered"
+    # The rejected raw input stays visible so the user can correct it.
+    assert_includes body, "99.ace99",
+      "expected the rejected raw input to remain in the edit field"
+
+    # It must NOT present a saved show of the in-memory 99.99 value.
+    refute_match(/\$\s*99\.99/, body,
+      "response must not present a fake '$99.99' saved show after a failed save")
+  end
+
+  test "valid money update persists and renders the show" do
+    put form_element_showcase_path(
+      @showcase,
+      attribute: "amount",
+      form_element: "money_field",
+      update: @frame
+    ), params: { amount: "12.34" }, headers: @headers
+
+    assert_response :success
+    assert_equal 1234, @showcase.reload.amount_cents,
+      "valid '12.34' must persist as 1234 cents"
+    assert_includes @response.body, %(<turbo-frame id="#{@frame}">)
+    assert_includes @response.body, "12.34"
+    # Show state renders the humanized money, not the edit text field.
+    refute_includes @response.body, "input_money_field",
+      "valid update should render the show, not the edit field"
+  end
+end

data/lib/installer_templates/example_app_tests/test/integration/example_app_showcase_validation_hints_test.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+require_relative "../example_app/example_integration_test_case"
+
+# Regression for the 8.1.20 validation-hint fixes on FormElementShowcase:
+#
+#   * count  (integer_field, `numericality: { only_integer: true }`)
+#   * price  (decimal_field, bare `numericality: true`)
+#   * amount (money_field,  money-rails `monetize :amount_cents`, which
+#             registers a MoneyValidator on `:amount`)
+#
+# Before 8.1.20 a bare `numericality: true` emitted ZERO hint messages
+# (validation_hints dead-code bug), so `price` rendered an EMPTY
+# `validation-hints-source` div, and `amount` had no i18n mapping for the
+# money validator key. The show panel must now render a NON-EMPTY
+# `<ul class="validation-hints-list">` for all three.
+class ExampleAppShowcaseValidationHintsTest < ExampleAppIntegrationTestCase
+  setup do
+    @full = FormElementShowcase.find_or_create_by!(title: "Hints demo") do |s|
+      s.count  = 7
+      s.price  = "12.34"
+      s.amount = Money.from_amount(99.95, "USD") if s.respond_to?(:amount=) && defined?(Money)
+    end
+    @row_frame = "form_element_showcase_#{@full.id}"
+    @row_headers = { "Turbo-Frame" => @row_frame, "Accept" => "text/html" }
+  end
+
+  test "count label renders a non-empty validation-hints list" do
+    body = show_panel_body
+    assert_nonempty_hint(body, :count, "must be a number", "must be an integer")
+  end
+
+  test "price label renders a non-empty validation-hints list (bare numericality: true)" do
+    body = show_panel_body
+    assert_nonempty_hint(body, :price, "must be a number")
+  end
+
+  test "amount label renders a non-empty validation-hints list (money-rails validator)" do
+    skip "money-rails monetize not configured" unless FormElementShowcase.respond_to?(:monetized_attributes) &&
+      FormElementShowcase.monetized_attributes.key?("amount")
+
+    body = show_panel_body
+    assert_nonempty_hint(body, :amount, "must be a valid amount")
+  end
+
+  private
+
+  def show_panel_body
+    get form_element_showcase_path(@full, update: @row_frame), headers: @row_headers
+    assert_response :success
+    @response.body
+  end
+
+  # Asserts the hidden `validation-hints-source` div for +attribute+ exists
+  # AND contains a populated `<ul class="validation-hints-list">` with each
+  # expected message fragment — i.e. not the empty source div the pre-8.1.20
+  # bug produced.
+  def assert_nonempty_hint(body, attribute, *expected_messages)
+    hint_id = "validation_hints_form_element_showcase_#{@full.id}_#{attribute}"
+
+    assert_includes body, %(data-validation-hints-source="#{hint_id}"),
+      "expected has-tip trigger wired to #{hint_id}"
+
+    source = body[
+      %r{<div id="#{Regexp.escape(hint_id)}" class="validation-hints-source" hidden>(.*?)</div>}m,
+      1
+    ]
+    refute_nil source, "expected a validation-hints-source div for #{attribute}"
+    assert_includes source, '<ul class="validation-hints-list">',
+      "expected a NON-EMPTY hints list for #{attribute}, got source: #{source.inspect}"
+
+    expected_messages.each do |message|
+      assert_includes source, message,
+        "expected #{attribute} hint list to include #{message.inspect}"
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms_installer
 version: !ruby/object:Gem::Version
-  version: 8.1.18
+  version: 8.1.20
 platform: ruby
 authors:
 - Ace Suares
@@ -95,10 +95,12 @@ files:
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_choice_scale_fields_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_date_time_fields_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_locales_associations_test.rb
+- lib/installer_templates/example_app_tests/test/integration/example_app_showcase_money_update_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_numeric_fields_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_page_render_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_row_turbo_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_showcase_text_fields_test.rb
+- lib/installer_templates/example_app_tests/test/integration/example_app_showcase_validation_hints_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_turbo_layout_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_validation_hints_test.rb
 - lib/installer_templates/example_app_tests/test/models/example_app_apartment_name_validation_test.rb