inline_forms 8.1.67 → 8.1.70
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/.forgejo/brakeman-engine.sh +51 -0
- data/.forgejo/brakeman.ignore +211 -0
- data/.forgejo/workflows/ci.yml +30 -19
- data/.forgejo/workflows/full-gate.yml +40 -13
- data/.ruby-version +1 -1
- data/CHANGELOG.md +32 -0
- data/README.rdoc +3 -3
- data/inline_forms.gemspec +1 -1
- data/lib/inline_forms/version.rb +1 -1
- metadata +6 -4
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
SHA256:
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
3
|
+
metadata.gz: bba553f79844842a8f729c901f5b80e7e9648d5d3aa87f24ac27b639d912e1a6
|
|
4
|
+
data.tar.gz: 6ebc4014b08c59dc54ac2477a911fe52ce5dbec418eee026746986fe472ea295
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: 65785f30dad13fe689f34c0470542ac68472c084a40aea628a7855cd9f38a517bede9e2443f05143253531f540d890145eb3ffbce9ab6a30be7836feb6992ca1
|
|
7
|
+
data.tar.gz: 4eb53f8cf94cfedbc2fcec376e74522b002f8093dda8beee33db4a4298f12526a61f1dd465e541163df5c0ad36917f42007ee3d43c05dc301d798847fd5d10dc
|
|
@@ -0,0 +1,51 @@
|
|
|
1
|
+
#!/usr/bin/env bash
|
|
2
|
+
#
|
|
3
|
+
# Brakeman on a generated app together with the engine code.
|
|
4
|
+
#
|
|
5
|
+
# .forgejo/brakeman-engine.sh APP [extra brakeman options]
|
|
6
|
+
#
|
|
7
|
+
# Brakeman skips gem code, so scanning the app alone never looks at the
|
|
8
|
+
# engine's controllers, helpers and views. Scanning the engine alone does not
|
|
9
|
+
# work either: without an app Brakeman cannot tell the Rails version and the
|
|
10
|
+
# templates do not parse. So: a temporary copy of APP with the engine's code
|
|
11
|
+
# in engines/, scanned as one application. APP itself is not touched.
|
|
12
|
+
#
|
|
13
|
+
# Accepted warnings, each with its reason, are in brakeman.ignore beside this
|
|
14
|
+
# file; --ensure-ignore-notes fails on one without a reason, and
|
|
15
|
+
# --ensure-no-obsolete-ignore-entries on one that no longer occurs. The paths
|
|
16
|
+
# in the copy are relative and fixed (engines/...), because Brakeman's
|
|
17
|
+
# fingerprints include them.
|
|
18
|
+
#
|
|
19
|
+
# Not scanned: lib/installer_templates and lib/generators (they produce code;
|
|
20
|
+
# what they produce is in APP).
|
|
21
|
+
|
|
22
|
+
set -euo pipefail
|
|
23
|
+
|
|
24
|
+
here=$(cd "$(dirname "$0")" && pwd)
|
|
25
|
+
root=$(dirname "$here")
|
|
26
|
+
app=$(cd "${1:?usage: brakeman-engine.sh APP [brakeman options]}" && pwd)
|
|
27
|
+
shift
|
|
28
|
+
|
|
29
|
+
work=$(mktemp -d)
|
|
30
|
+
trap 'rm -rf "$work"' EXIT
|
|
31
|
+
mkdir -p "$work/app/engines/inline_forms" "$work/app/engines/inline_forms_schema_edit"
|
|
32
|
+
|
|
33
|
+
# No keys or credentials: Brakeman does not need them.
|
|
34
|
+
tar -C "$app" --exclude='*.key' --exclude='credentials*' -cf - \
|
|
35
|
+
app config lib Gemfile Gemfile.lock | tar -C "$work/app" -xf -
|
|
36
|
+
|
|
37
|
+
for part in app config lib; do
|
|
38
|
+
if [ -d "$root/$part" ]; then
|
|
39
|
+
cp -R "$root/$part" "$work/app/engines/inline_forms/"
|
|
40
|
+
fi
|
|
41
|
+
if [ -d "$root/inline_forms_schema_edit/$part" ]; then
|
|
42
|
+
cp -R "$root/inline_forms_schema_edit/$part" "$work/app/engines/inline_forms_schema_edit/"
|
|
43
|
+
fi
|
|
44
|
+
done
|
|
45
|
+
rm -rf "$work/app/engines/inline_forms/lib/installer_templates" \
|
|
46
|
+
"$work/app/engines/inline_forms/lib/generators"
|
|
47
|
+
|
|
48
|
+
brakeman --no-pager \
|
|
49
|
+
--add-engines-path engines/inline_forms,engines/inline_forms_schema_edit \
|
|
50
|
+
-i "$here/brakeman.ignore" --ensure-ignore-notes --ensure-no-obsolete-ignore-entries \
|
|
51
|
+
--path "$work/app" "$@"
|
|
@@ -0,0 +1,211 @@
|
|
|
1
|
+
{
|
|
2
|
+
"ignored_warnings": [
|
|
3
|
+
{
|
|
4
|
+
"warning_type": "SQL Injection",
|
|
5
|
+
"warning_code": 0,
|
|
6
|
+
"fingerprint": "09d9d139a9c55d2f8ddc853b4e488d8b90a22e81f9b808d5ac60503296a17c40",
|
|
7
|
+
"check_name": "SQL",
|
|
8
|
+
"message": "Possible SQL injection",
|
|
9
|
+
"file": "engines/inline_forms/app/controllers/inline_forms_controller.rb",
|
|
10
|
+
"line": 181,
|
|
11
|
+
"link": "https://brakemanscanner.org/docs/warning_types/sql_injection/",
|
|
12
|
+
"code": "(self.controller_name.classify.constantize.accessible_by(current_ability) or self.controller_name.classify.constantize.all).merge(self.controller_name.classify.constantize.inline_forms_list).merge(self.controller_name.classify.constantize.inline_forms_search(params[:search])).where((nil or [\"#{(self.controller_name.classify.constantize.reflect_on_association(params[:parent_class].underscore.to_sym).options[:foreign_key] or params[:parent_class].foreign_key)} = ?\", params[:parent_id]]))",
|
|
13
|
+
"render_path": null,
|
|
14
|
+
"location": {
|
|
15
|
+
"type": "method",
|
|
16
|
+
"class": "InlineFormsController",
|
|
17
|
+
"method": "create"
|
|
18
|
+
},
|
|
19
|
+
"user_input": "params[:parent_class].underscore.to_sym",
|
|
20
|
+
"confidence": "Medium",
|
|
21
|
+
"cwe_id": [
|
|
22
|
+
89
|
|
23
|
+
],
|
|
24
|
+
"note": "parent_class and parent_id are refused (400) by refuse_malformed_parent_params unless parent_class names a belongs_to association of the model and parent_id is all digits; foreign_key comes from the model's reflection or that class name, and parent_id is a bind value. Tests: test/integration/list_params_test.rb."
|
|
25
|
+
},
|
|
26
|
+
{
|
|
27
|
+
"warning_type": "SQL Injection",
|
|
28
|
+
"warning_code": 0,
|
|
29
|
+
"fingerprint": "0ea384debe73789ae09a12359f268b7362bec05090e670f180ab1434d822a012",
|
|
30
|
+
"check_name": "SQL",
|
|
31
|
+
"message": "Possible SQL injection",
|
|
32
|
+
"file": "engines/inline_forms/app/views/inline_forms/_list.html.erb",
|
|
33
|
+
"line": 41,
|
|
34
|
+
"link": "https://brakemanscanner.org/docs/warning_types/sql_injection/",
|
|
35
|
+
"code": "(parent_class.find(parent_id).send(attribute) or parent_class.find(parent_id).send(attribute).accessible_by(current_ability)).merge(attribute.to_s.singularize.camelcase.constantize.inline_forms_list).where([\"#{attribute.to_s.singularize.camelcase.constantize.table_name}.#{(parent_class.reflect_on_association(attribute.to_sym).options[:foreign_key] or parent_class.name.foreign_key)} = ?\", parent_id])",
|
|
36
|
+
"render_path": [
|
|
37
|
+
{
|
|
38
|
+
"type": "controller",
|
|
39
|
+
"class": "InlineFormsController",
|
|
40
|
+
"method": "index",
|
|
41
|
+
"line": 105,
|
|
42
|
+
"file": "engines/inline_forms/app/controllers/inline_forms_controller.rb",
|
|
43
|
+
"rendered": {
|
|
44
|
+
"name": "inline_forms/_list",
|
|
45
|
+
"file": "engines/inline_forms/app/views/inline_forms/_list.html.erb"
|
|
46
|
+
}
|
|
47
|
+
}
|
|
48
|
+
],
|
|
49
|
+
"location": {
|
|
50
|
+
"type": "template",
|
|
51
|
+
"template": "inline_forms/_list"
|
|
52
|
+
},
|
|
53
|
+
"user_input": "parent_class.reflect_on_association(attribute.to_sym).options[:foreign_key]",
|
|
54
|
+
"confidence": "Weak",
|
|
55
|
+
"cwe_id": [
|
|
56
|
+
89
|
|
57
|
+
],
|
|
58
|
+
"note": "In this branch parent_class is a class passed by _show.html.erb, not a param, and foreign_key is the association's foreign key or the class name's. parent_id is a bind value."
|
|
59
|
+
},
|
|
60
|
+
{
|
|
61
|
+
"warning_type": "Remote Code Execution",
|
|
62
|
+
"warning_code": 24,
|
|
63
|
+
"fingerprint": "61c8f32dd8829cb209a4136d62ff04f729a3f04ea1d1c69b64728ecabc1f4c66",
|
|
64
|
+
"check_name": "UnsafeReflection",
|
|
65
|
+
"message": "Unsafe reflection method `constantize` called on parameter value",
|
|
66
|
+
"file": "engines/inline_forms/app/views/inline_forms/_list.html.erb",
|
|
67
|
+
"line": 19,
|
|
68
|
+
"link": "https://brakemanscanner.org/docs/warning_types/remote_code_execution/",
|
|
69
|
+
"code": "params[:parent_class].constantize",
|
|
70
|
+
"render_path": [
|
|
71
|
+
{
|
|
72
|
+
"type": "controller",
|
|
73
|
+
"class": "InlineFormsController",
|
|
74
|
+
"method": "index",
|
|
75
|
+
"line": 105,
|
|
76
|
+
"file": "engines/inline_forms/app/controllers/inline_forms_controller.rb",
|
|
77
|
+
"rendered": {
|
|
78
|
+
"name": "inline_forms/_list",
|
|
79
|
+
"file": "engines/inline_forms/app/views/inline_forms/_list.html.erb"
|
|
80
|
+
}
|
|
81
|
+
}
|
|
82
|
+
],
|
|
83
|
+
"location": {
|
|
84
|
+
"type": "template",
|
|
85
|
+
"template": "inline_forms/_list"
|
|
86
|
+
},
|
|
87
|
+
"user_input": "params[:parent_class]",
|
|
88
|
+
"confidence": "High",
|
|
89
|
+
"cwe_id": [
|
|
90
|
+
470
|
|
91
|
+
],
|
|
92
|
+
"note": "@parent_class is only set in index, new and create, and the before_action refuse_malformed_parent_params covers index, new, create and show: parent_class is blank or the class name of a non-polymorphic belongs_to of the controller's model, so no other class is constantized. Tests: test/integration/list_params_test.rb."
|
|
93
|
+
},
|
|
94
|
+
{
|
|
95
|
+
"warning_type": "Dangerous Send",
|
|
96
|
+
"warning_code": 23,
|
|
97
|
+
"fingerprint": "67076d627523cb3c2746069c8e98d2261b3fcfe04a11463f6eb56e4f10e789a4",
|
|
98
|
+
"check_name": "Send",
|
|
99
|
+
"message": "User controlled method execution",
|
|
100
|
+
"file": "engines/inline_forms/app/controllers/inline_forms_controller.rb",
|
|
101
|
+
"line": 221,
|
|
102
|
+
"link": "https://brakemanscanner.org/docs/warning_types/dangerous_send/",
|
|
103
|
+
"code": "send(\"#{params[:form_element]}_update\", referenced_object, params[:attribute])",
|
|
104
|
+
"render_path": null,
|
|
105
|
+
"location": {
|
|
106
|
+
"type": "method",
|
|
107
|
+
"class": "InlineFormsController",
|
|
108
|
+
"method": "update"
|
|
109
|
+
},
|
|
110
|
+
"user_input": "params[:form_element]",
|
|
111
|
+
"confidence": "High",
|
|
112
|
+
"cwe_id": [
|
|
113
|
+
77
|
|
114
|
+
],
|
|
115
|
+
"note": "field_request_permitted?(:update) runs first and refuses (400) unless attribute and form_element name a row of the model's own attribute list, so only the *_update method of a declared form element can be called."
|
|
116
|
+
},
|
|
117
|
+
{
|
|
118
|
+
"warning_type": "Dangerous Send",
|
|
119
|
+
"warning_code": 23,
|
|
120
|
+
"fingerprint": "6988827dc9c767b44428caabc78a6c8596ad933a406ae1a32b85ae3fd4a4ed23",
|
|
121
|
+
"check_name": "Send",
|
|
122
|
+
"message": "User controlled method execution",
|
|
123
|
+
"file": "engines/inline_forms/app/controllers/inline_forms_controller.rb",
|
|
124
|
+
"line": 259,
|
|
125
|
+
"link": "https://brakemanscanner.org/docs/warning_types/dangerous_send/",
|
|
126
|
+
"code": "referenced_object.send(params[:attribute])",
|
|
127
|
+
"render_path": null,
|
|
128
|
+
"location": {
|
|
129
|
+
"type": "method",
|
|
130
|
+
"class": "InlineFormsController",
|
|
131
|
+
"method": "show"
|
|
132
|
+
},
|
|
133
|
+
"user_input": "params[:attribute]",
|
|
134
|
+
"confidence": "High",
|
|
135
|
+
"cwe_id": [
|
|
136
|
+
77
|
|
137
|
+
],
|
|
138
|
+
"note": "field_request_permitted?(:read) refuses (400) unless attribute and form_element name a row of the model's own attribute list, then authorizes the attribute. With no attribute the send is of nil, which raises. Covers the associated and has_one branches of show."
|
|
139
|
+
},
|
|
140
|
+
{
|
|
141
|
+
"warning_type": "Command Injection",
|
|
142
|
+
"warning_code": 14,
|
|
143
|
+
"fingerprint": "70ea329216e82770ca0de3975a7082e37fe86e417b021e68f95cc6e823e14a77",
|
|
144
|
+
"check_name": "Execute",
|
|
145
|
+
"message": "Possible command injection",
|
|
146
|
+
"file": "engines/inline_forms/lib/inline_forms_installer/create_log.rb",
|
|
147
|
+
"line": 55,
|
|
148
|
+
"link": "https://brakemanscanner.org/docs/warning_types/command_injection/",
|
|
149
|
+
"code": "system(\"bash\", \"-c\", \"#{shell_command} 2>&1 | tee -a #{Shellwords.escape(File.expand_path(basename_for(started_at)))}; exit ${PIPESTATUS[0]}\")",
|
|
150
|
+
"render_path": null,
|
|
151
|
+
"location": {
|
|
152
|
+
"type": "method",
|
|
153
|
+
"class": "InlineFormsInstaller::CreateLog",
|
|
154
|
+
"method": "tee_rails_new"
|
|
155
|
+
},
|
|
156
|
+
"user_input": "shell_command",
|
|
157
|
+
"confidence": "Medium",
|
|
158
|
+
"cwe_id": [
|
|
159
|
+
77
|
|
160
|
+
],
|
|
161
|
+
"note": "Installer command line, not reachable from a web request. shell_command is built by Creator#create from the rails command, the app name (checked against its regex first) and a path in the installer; the operator runs it as themself."
|
|
162
|
+
},
|
|
163
|
+
{
|
|
164
|
+
"warning_type": "Dangerous Send",
|
|
165
|
+
"warning_code": 23,
|
|
166
|
+
"fingerprint": "a858a85120c0ef89f96452d8bcb0d01664507ceb2ae4d834cfc237403b4b93a8",
|
|
167
|
+
"check_name": "Send",
|
|
168
|
+
"message": "User controlled method execution",
|
|
169
|
+
"file": "engines/inline_forms/app/controllers/inline_forms_controller.rb",
|
|
170
|
+
"line": 258,
|
|
171
|
+
"link": "https://brakemanscanner.org/docs/warning_types/dangerous_send/",
|
|
172
|
+
"code": "referenced_object.send((params[:attribute].to_s.singularize + \"_ids\"))",
|
|
173
|
+
"render_path": null,
|
|
174
|
+
"location": {
|
|
175
|
+
"type": "method",
|
|
176
|
+
"class": "InlineFormsController",
|
|
177
|
+
"method": "show"
|
|
178
|
+
},
|
|
179
|
+
"user_input": "(params[:attribute].to_s.singularize + \"_ids\")",
|
|
180
|
+
"confidence": "High",
|
|
181
|
+
"cwe_id": [
|
|
182
|
+
77
|
|
183
|
+
],
|
|
184
|
+
"note": "field_request_permitted?(:read) refuses (400) unless attribute and form_element name a row of the model's own attribute list, so only <association>_ids of a declared association is called."
|
|
185
|
+
},
|
|
186
|
+
{
|
|
187
|
+
"warning_type": "SQL Injection",
|
|
188
|
+
"warning_code": 0,
|
|
189
|
+
"fingerprint": "ad2b4dd8ced8aa1edf48bfbb80730b2bd4dadc84a15de67fd9dde25d81c46e00",
|
|
190
|
+
"check_name": "SQL",
|
|
191
|
+
"message": "Possible SQL injection",
|
|
192
|
+
"file": "engines/inline_forms/app/controllers/inline_forms_controller.rb",
|
|
193
|
+
"line": 64,
|
|
194
|
+
"link": "https://brakemanscanner.org/docs/warning_types/sql_injection/",
|
|
195
|
+
"code": "self.controller_name.classify.constantize.all.merge(self.controller_name.classify.constantize.inline_forms_list).merge(self.controller_name.classify.constantize.inline_forms_search(params[:search])).where((nil or [\"#{(self.controller_name.classify.constantize.reflect_on_association(params[:parent_class].underscore.to_sym).options[:foreign_key] or params[:parent_class].foreign_key)} = ?\", params[:parent_id]]))",
|
|
196
|
+
"render_path": null,
|
|
197
|
+
"location": {
|
|
198
|
+
"type": "method",
|
|
199
|
+
"class": "InlineFormsController",
|
|
200
|
+
"method": "index"
|
|
201
|
+
},
|
|
202
|
+
"user_input": "params[:parent_class].underscore.to_sym",
|
|
203
|
+
"confidence": "Medium",
|
|
204
|
+
"cwe_id": [
|
|
205
|
+
89
|
|
206
|
+
],
|
|
207
|
+
"note": "parent_class and parent_id are refused (400) by refuse_malformed_parent_params unless parent_class names a belongs_to association of the model and parent_id is all digits; foreign_key comes from the model's reflection or that class name, and parent_id is a bind value. Tests: test/integration/list_params_test.rb."
|
|
208
|
+
}
|
|
209
|
+
],
|
|
210
|
+
"brakeman_version": "8.1.1"
|
|
211
|
+
}
|
data/.forgejo/workflows/ci.yml
CHANGED
|
@@ -1,7 +1,9 @@
|
|
|
1
1
|
# CI for Forgejo Actions (runner on dev02, jobs run in Docker containers).
|
|
2
|
-
#
|
|
3
|
-
#
|
|
4
|
-
# checkout/cache
|
|
2
|
+
#
|
|
3
|
+
# No Node: the job runs in the official ruby image (same Ruby as these gems) and
|
|
4
|
+
# uses only shell steps. actions/checkout and actions/cache are JavaScript and
|
|
5
|
+
# need node inside the container, so the checkouts are plain git and the gems
|
|
6
|
+
# are installed fresh each run.
|
|
5
7
|
#
|
|
6
8
|
# GitHub deliberately has NO workflows (.github/workflows was removed in
|
|
7
9
|
# 8.1.34): pushing to GitHub triggers nothing; CI runs only on Forgejo.
|
|
@@ -18,29 +20,38 @@ jobs:
|
|
|
18
20
|
test:
|
|
19
21
|
runs-on: docker
|
|
20
22
|
container:
|
|
21
|
-
image:
|
|
23
|
+
image: docker.io/library/ruby:4.0.10
|
|
22
24
|
steps:
|
|
23
|
-
-
|
|
24
|
-
|
|
25
|
-
|
|
25
|
+
- name: Check out inline_forms
|
|
26
|
+
env:
|
|
27
|
+
TOKEN: ${{ github.token }}
|
|
28
|
+
SERVER: ${{ github.server_url }}
|
|
29
|
+
REPO: ${{ github.repository }}
|
|
30
|
+
SHA: ${{ github.sha }}
|
|
31
|
+
run: |
|
|
32
|
+
auth=$(printf 'x-access-token:%s' "$TOKEN" | base64 -w0)
|
|
33
|
+
git init -q inline_forms
|
|
34
|
+
cd inline_forms
|
|
35
|
+
git -c http.extraHeader="Authorization: basic $auth" fetch -q --depth 1 "$SERVER/$REPO.git" "$SHA"
|
|
36
|
+
git checkout -q FETCH_HEAD
|
|
37
|
+
git log --oneline -1
|
|
26
38
|
|
|
27
39
|
# The dev Gemfile points at the validation_hints sibling
|
|
28
40
|
# (gem "validation_hints", path: "../validation_hints"). The job's
|
|
29
41
|
# automatic token is scoped to this repo only and validation_hints is
|
|
30
42
|
# private, so the repo secret VALIDATION_HINTS (a token with read
|
|
31
43
|
# access to ace/validation_hints) authorizes the checkout.
|
|
32
|
-
-
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
|
|
37
|
-
|
|
38
|
-
|
|
39
|
-
|
|
40
|
-
|
|
41
|
-
|
|
42
|
-
|
|
43
|
-
restore-keys: gems-inline_forms-
|
|
44
|
+
- name: Check out validation_hints
|
|
45
|
+
env:
|
|
46
|
+
TOKEN: ${{ secrets.VALIDATION_HINTS }}
|
|
47
|
+
SERVER: ${{ github.server_url }}
|
|
48
|
+
run: |
|
|
49
|
+
auth=$(printf 'x-access-token:%s' "$TOKEN" | base64 -w0)
|
|
50
|
+
git init -q validation_hints
|
|
51
|
+
cd validation_hints
|
|
52
|
+
git -c http.extraHeader="Authorization: basic $auth" fetch -q --depth 1 "$SERVER/ace/validation_hints.git" HEAD
|
|
53
|
+
git checkout -q FETCH_HEAD
|
|
54
|
+
git log --oneline -1
|
|
44
55
|
|
|
45
56
|
- name: Install gems
|
|
46
57
|
working-directory: inline_forms
|
|
@@ -2,14 +2,20 @@
|
|
|
2
2
|
# generate the example app (which runs its own 150+ test suite as part of
|
|
3
3
|
# `inline_forms create`), then run Brakeman against the generated app.
|
|
4
4
|
#
|
|
5
|
-
# Brakeman is aimed at Rails *applications
|
|
6
|
-
#
|
|
7
|
-
#
|
|
8
|
-
#
|
|
5
|
+
# Brakeman is aimed at Rails *applications* and skips gem code, so it runs
|
|
6
|
+
# twice: on the generated MyApp (everything the installer writes), and on
|
|
7
|
+
# MyApp together with the engine's own controllers, helpers and views
|
|
8
|
+
# (.forgejo/brakeman-engine.sh; accepted warnings, with their reasons, in
|
|
9
|
+
# .forgejo/brakeman.ignore). bundler-audit for the engine runs in ci.yml.
|
|
9
10
|
#
|
|
10
11
|
# Heavy (~3-4 min: rails new + bundle + migrations + tests), so it runs on
|
|
11
12
|
# demand and weekly, not per push. Requires network access to rubygems.org
|
|
12
13
|
# from the runner (same as Papiamentu's bundle install).
|
|
14
|
+
#
|
|
15
|
+
# No Node: the official ruby image and plain git, as in ci.yml. The generated
|
|
16
|
+
# app's autoprefixer-rails needs a JavaScript runtime; ExecJS takes mini_racer,
|
|
17
|
+
# which `bundle install` installs because no group is excluded (it is in the
|
|
18
|
+
# app's production group).
|
|
13
19
|
name: Full gate
|
|
14
20
|
|
|
15
21
|
on:
|
|
@@ -21,17 +27,33 @@ jobs:
|
|
|
21
27
|
full-gate:
|
|
22
28
|
runs-on: docker
|
|
23
29
|
container:
|
|
24
|
-
image:
|
|
30
|
+
image: docker.io/library/ruby:4.0.10
|
|
25
31
|
steps:
|
|
26
|
-
-
|
|
27
|
-
|
|
28
|
-
|
|
32
|
+
- name: Check out inline_forms
|
|
33
|
+
env:
|
|
34
|
+
TOKEN: ${{ github.token }}
|
|
35
|
+
SERVER: ${{ github.server_url }}
|
|
36
|
+
REPO: ${{ github.repository }}
|
|
37
|
+
SHA: ${{ github.sha }}
|
|
38
|
+
run: |
|
|
39
|
+
auth=$(printf 'x-access-token:%s' "$TOKEN" | base64 -w0)
|
|
40
|
+
git init -q inline_forms
|
|
41
|
+
cd inline_forms
|
|
42
|
+
git -c http.extraHeader="Authorization: basic $auth" fetch -q --depth 1 "$SERVER/$REPO.git" "$SHA"
|
|
43
|
+
git checkout -q FETCH_HEAD
|
|
44
|
+
git log --oneline -1
|
|
29
45
|
|
|
30
|
-
-
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
|
|
34
|
-
|
|
46
|
+
- name: Check out validation_hints
|
|
47
|
+
env:
|
|
48
|
+
TOKEN: ${{ secrets.VALIDATION_HINTS }}
|
|
49
|
+
SERVER: ${{ github.server_url }}
|
|
50
|
+
run: |
|
|
51
|
+
auth=$(printf 'x-access-token:%s' "$TOKEN" | base64 -w0)
|
|
52
|
+
git init -q validation_hints
|
|
53
|
+
cd validation_hints
|
|
54
|
+
git -c http.extraHeader="Authorization: basic $auth" fetch -q --depth 1 "$SERVER/ace/validation_hints.git" HEAD
|
|
55
|
+
git checkout -q FETCH_HEAD
|
|
56
|
+
git log --oneline -1
|
|
35
57
|
|
|
36
58
|
- name: Build the four gems
|
|
37
59
|
run: |
|
|
@@ -75,3 +97,8 @@ jobs:
|
|
|
75
97
|
# Pedantic full set stays informational: it includes checks that
|
|
76
98
|
# can fire on perfectly reasonable future code.
|
|
77
99
|
brakeman --run-all-checks --no-pager || true
|
|
100
|
+
|
|
101
|
+
# ENFORCING: a warning that is not in .forgejo/brakeman.ignore fails, and
|
|
102
|
+
# so does an entry there that has no reason or no longer occurs.
|
|
103
|
+
- name: Brakeman against the app together with the engine
|
|
104
|
+
run: bash inline_forms/.forgejo/brakeman-engine.sh apps/MyApp
|
data/.ruby-version
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
ruby-4.0.
|
|
1
|
+
ruby-4.0.10
|
data/CHANGELOG.md
CHANGED
|
@@ -8,6 +8,38 @@ All notable changes to this project are documented in this file.
|
|
|
8
8
|
|
|
9
9
|
- Known issues, parked (local note `stuff/2026-10-31-dropdown-rule-3-parked.md`) with dropdown order rule 3: `includes`, `group` or `select` in `inline_forms_list` make `dropdown` and `dropdown_with_other` raise while `/index` works, so 8.1.65's fix for a list order on a joined table holds only for `joins`, `left_joins` and `eager_load`; a has_many join gives duplicate options. Present since 8.1.60. No host's list scope has these today. Parked; not changed.
|
|
10
10
|
|
|
11
|
+
## [8.1.70] - 2026-11-22
|
|
12
|
+
|
|
13
|
+
### Changed
|
|
14
|
+
|
|
15
|
+
- **Rails 8.1.4.1 is the minimum** (was 8.1.0; still `< 8.2`). Older 8.1 releases have known vulnerabilities, up to critical (Active Storage file read and write, CVE-2026-122006). A host on an older Rails updates Rails together with inline_forms: `bundle update --conservative rails inline_forms inline_forms_installer inline_forms_schema_edit validation_hints`, naming the ones it uses.
|
|
16
|
+
|
|
17
|
+
### CI
|
|
18
|
+
|
|
19
|
+
- The full gate runs Brakeman on the engine's own code too: `.forgejo/brakeman-engine.sh` scans the generated app together with the engine and `inline_forms_schema_edit`. Brakeman skips gem code, so until now the engine was not scanned. Accepted warnings are in `.forgejo/brakeman.ignore`, each with its reason.
|
|
20
|
+
|
|
21
|
+
## [8.1.69] - 2026-11-22
|
|
22
|
+
|
|
23
|
+
### Changed
|
|
24
|
+
|
|
25
|
+
- **Installer: generated apps use terser instead of uglifier,** and compress JavaScript on `assets:precompile`: the production group has `terser` next to `mini_racer` (its ExecJS runtime, so no Node), and `config/environments/production.rb` gets `config.assets.js_compressor = :terser`. Before, uglifier was in the Gemfile but nothing set a compressor. Existing apps are not changed.
|
|
26
|
+
|
|
27
|
+
### Tests
|
|
28
|
+
|
|
29
|
+
- The example app checks the setting and the production group (`example_app_production_js_compressor_test.rb`).
|
|
30
|
+
|
|
31
|
+
## [8.1.68] - 2026-11-22
|
|
32
|
+
|
|
33
|
+
### Security
|
|
34
|
+
|
|
35
|
+
- **Ruby 4.0.10 instead of 4.0.4.** Ruby 4.0.4 has eight advisories in ruby-advisory-db (31efd9aa, 2026-11-22), among them CVE-2026-132825 (heap buffer overflow in string case conversion, fixed in 4.0.10) and CVE-2026-46727 (use-after-free in `getaddrinfo`, fixed in 4.0.5). `bundler-audit` does not check the interpreter.
|
|
36
|
+
|
|
37
|
+
### Changed
|
|
38
|
+
|
|
39
|
+
- **Installer: generated apps pin Ruby 4.0.10** in `.ruby-version` (`InlineFormsInstaller::TARGET_RUBY_VERSION` and the template's fallback). That Ruby must be installed before `inline_forms create`. Existing apps keep the `.ruby-version` they have.
|
|
40
|
+
- The repo's own `.ruby-version` follows. `required_ruby_version` stays `>= 4.0.0`.
|
|
41
|
+
- **CI runs without Node.** `ci.yml`, `full-gate.yml` and the `inline_forms_schema_edit` example workflow run in the official `ruby:4.0.10` image and check out with plain git instead of `actions/checkout` and `actions/cache`, which are JavaScript. Gems are installed fresh each run.
|
|
42
|
+
|
|
11
43
|
## [8.1.67] - 2026-11-06
|
|
12
44
|
|
|
13
45
|
Fixes from a code review of 8.1.66.
|
data/README.rdoc
CHANGED
|
@@ -4,13 +4,13 @@ Inline Forms is almost a complete admin application. You can try it out easily.
|
|
|
4
4
|
|
|
5
5
|
= Requirements
|
|
6
6
|
|
|
7
|
-
* Ruby **>= 4.0** (generated apps pin **4.0.
|
|
8
|
-
* Rails **8.1.x** (+rails ~> 8.1+, +config.load_defaults 8.1+)
|
|
7
|
+
* Ruby **>= 4.0** (generated apps pin **4.0.10** via +.ruby-version+)
|
|
8
|
+
* Rails **8.1.x**, at least **8.1.4.1** (+rails ~> 8.1+, +config.load_defaults 8.1+)
|
|
9
9
|
* **validation_hints** **~> 8** (companion gem; same version line as +inline_forms+ / +inline_forms_installer+)
|
|
10
10
|
|
|
11
11
|
= Ruby version managers (RVM is optional)
|
|
12
12
|
|
|
13
|
-
+inline_forms+ does *not* require RVM. Generated apps get a +.ruby-version+ whose format matches the version manager you are using: a *bare* +4.0.
|
|
13
|
+
+inline_forms+ does *not* require RVM. Generated apps get a +.ruby-version+ whose format matches the version manager you are using: a *bare* +4.0.10+ for +rbenv+ / +chruby+ / +asdf+ / +mise+, or +ruby-4.0.10+ for RVM (whose +.ruby-version+ reader needs the +ruby-+ prefix). So any version manager — or none — works. Bundler isolates each app's gems through its own +Gemfile.lock+.
|
|
14
14
|
|
|
15
15
|
RVM integration is purely opt-in. If the +rvm+ gem is installed *and* your shell is inside an RVM environment, +inline_forms create+ additionally writes a +.ruby-gemset+ and installs into a per-app gemset. To enable that, +gem install rvm+ before creating the app. To skip RVM even when it is present, pass +--no-rvm+:
|
|
16
16
|
|
data/inline_forms.gemspec
CHANGED
|
@@ -21,7 +21,7 @@ Gem::Specification.new do |s|
|
|
|
21
21
|
s.require_paths = [ "lib" ]
|
|
22
22
|
|
|
23
23
|
s.add_dependency("validation_hints", ">= 8.1.4", "< 9.0")
|
|
24
|
-
s.add_dependency("rails", ">= 8.1", "< 8.2")
|
|
24
|
+
s.add_dependency("rails", ">= 8.1.4.1", "< 8.2")
|
|
25
25
|
s.add_dependency("rails-i18n", ">= 8.1", "< 9.0")
|
|
26
26
|
|
|
27
27
|
s.add_development_dependency("minitest", "~> 5.0")
|
data/lib/inline_forms/version.rb
CHANGED
metadata
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
|
2
2
|
name: inline_forms
|
|
3
3
|
version: !ruby/object:Gem::Version
|
|
4
|
-
version: 8.1.
|
|
4
|
+
version: 8.1.70
|
|
5
5
|
platform: ruby
|
|
6
6
|
authors:
|
|
7
7
|
- Ace Suares
|
|
@@ -37,7 +37,7 @@ dependencies:
|
|
|
37
37
|
requirements:
|
|
38
38
|
- - ">="
|
|
39
39
|
- !ruby/object:Gem::Version
|
|
40
|
-
version:
|
|
40
|
+
version: 8.1.4.1
|
|
41
41
|
- - "<"
|
|
42
42
|
- !ruby/object:Gem::Version
|
|
43
43
|
version: '8.2'
|
|
@@ -47,7 +47,7 @@ dependencies:
|
|
|
47
47
|
requirements:
|
|
48
48
|
- - ">="
|
|
49
49
|
- !ruby/object:Gem::Version
|
|
50
|
-
version:
|
|
50
|
+
version: 8.1.4.1
|
|
51
51
|
- - "<"
|
|
52
52
|
- !ruby/object:Gem::Version
|
|
53
53
|
version: '8.2'
|
|
@@ -95,6 +95,8 @@ extensions: []
|
|
|
95
95
|
extra_rdoc_files: []
|
|
96
96
|
files:
|
|
97
97
|
- ".document"
|
|
98
|
+
- ".forgejo/brakeman-engine.sh"
|
|
99
|
+
- ".forgejo/brakeman.ignore"
|
|
98
100
|
- ".forgejo/workflows/ci.yml"
|
|
99
101
|
- ".forgejo/workflows/full-gate.yml"
|
|
100
102
|
- ".gitignore"
|
|
@@ -367,7 +369,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
|
|
|
367
369
|
- !ruby/object:Gem::Version
|
|
368
370
|
version: '0'
|
|
369
371
|
requirements: []
|
|
370
|
-
rubygems_version: 4.0.
|
|
372
|
+
rubygems_version: 4.0.20
|
|
371
373
|
specification_version: 4
|
|
372
374
|
summary: Inline editing of forms for Rails 8.
|
|
373
375
|
test_files:
|