inline_forms 8.1.57 → 8.1.58

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 93e0cd0c2bc09c666bd81cf76779b780ab345f4a7e80f8a6535177d7921b150d
-  data.tar.gz: 02e8abc26971fe105a65b8bae7380d171e2635e1e51385c0849917e1a5365c16
+  metadata.gz: e989cef82d52e8f127898955b5741aa163ac8018c5d376a1031d2b7fc4606b36
+  data.tar.gz: 1dd15f90a192376d102aa5247502537a4427388517601dd3b4daba091a4a7385
 SHA512:
-  metadata.gz: ecdf5c3b1c43851b0cd0d6b05fdac85a51b227c30584a52bb395c9786c1dffdb9378e549b6d99a1faf5ff11aa8bfc7ecda01ae1b92e494cf2dfdf9750fc3fae4
-  data.tar.gz: df8a5b2b0cd7a9f21a9b14e58a086ed7ace99f9ce6380bd1e8284cae6b65183b4db72e15de2c8ffa332e9366d85780dc6ccb125e12bfa7afa4a24ed204383a7a
+  metadata.gz: aef0b60a06a818a73ebc92defa6d2466f94aede8a39865870b3b3365e508b00642afafe05614addcc3ac0e3b2bf67a0bf3659531ef834c44050014e2bf2e3401
+  data.tar.gz: 4b478b2e1854e9c6427e13014f0694883f362184c86b6dfecfa25e9c3ef71752ca60c807c66b2d00f78eaa69dbed73b29afdc1138caece51e818ac340b9e3542

data/CHANGELOG.md

@@ -4,6 +4,37 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [8.1.58] - 2026-10-21
+
+Three gem issues found in the StProject review (2026-10-04). The fourth it listed, the CSS `@import` of `http://fonts.googleapis.com`, was already fixed in 8.1.22 (self-hosted Open Sans). Also the first step of the Sass `@import` → `@use` move.
+
+### Changed
+
+- **Sass: the entry points load `foundation_and_overrides` with `@use`.** `inline_forms/inline_forms.scss` and `inline_forms/devise.scss` replace `@import 'foundation_and_overrides'` with `@use 'foundation_and_overrides' as *` plus `@forward 'foundation_and_overrides'`. Dart Sass 3 removes `@import`, and these were two of the five gem `@import`s a host build reported.
+  - The compiled `inline_forms.css` and `devise.css` are **byte-identical** to 8.1.57's (compressed, compiled with the host's dartsass-rails command; same SHA-256).
+  - One rule needed spelling out to stay identical: Foundation's flex grid makes `.columns` an alias with `.columns { @extend .column }`, which reached the gem's `.column { padding-right: 0 !important }` only while the file was `@import`ed. That rule is now `.column, .columns`.
+  - The `@forward` keeps the module's API for hosts: Foundation's members (`rem-calc`, `$global-width`, ...) stay visible through `@use "inline_forms/inline_forms" as *`, and the `!default` `$if-*` palette can still be set with `@use "inline_forms/inline_forms" with ($if-accent: ...)`. Without it, both fail to compile.
+  - The URL is relative, so it resolves next to the gem's file first, as the `@import` did; a host's `app/assets/stylesheets/inline_forms/foundation_and_overrides.scss` or anything in `app/assets/builds` cannot shadow it.
+  - Deprecations per entry point (with `--verbose`): 371 → 370 (`[import]` 118 → 117, `[if-function]` 58, `[global-builtin]` 195). Without `--verbose` Sass prints 5 per category and "356 → 355 repetitive deprecation warnings omitted".
+- **Still `@import`, inside `foundation_and_overrides.scss`:** `settings/settings` and `foundation` (foundation-rails 6.9 is `@import`-only and its settings globals feed the overrides), and `theme`. A `@use 'theme'` would have to precede the settings `@import`, which moves the theme's CSS ahead of Foundation's and runs before `$body-background` exists; `meta.load-css` keeps the position but hides the `$if-*` palette from hosts. All three wait for the Foundation decision. The remaining 114 `[import]`, and all `[if-function]` / `[global-builtin]` warnings, are inside foundation-rails. The deadline is a dartsass-rails release that allows sass-embedded ≥ 3 (0.5.1 pins `~> 1.63`), not a date. No `--quiet-deps` / `--silence-deprecation` was added.
+
+### Fixed
+
+- **`dropdown` options are sorted again.** `dropdown_edit` called `values.sort_by { _presentation }` and discarded the result, so the options came out in id order. They are now sorted by their (dropdown) presentation.
+- **The failed-create flash header is translated.** `InlineFormsController#create` set `flash[:header]` to the hard-coded Dutch `"Kan <class_name> niet aanmaken."` (with the underscored class name, e.g. `client`) in every locale. It now uses the new key `inline_forms.view.create_failed` with the model's human name: "Could not create %{model}." (en), "Kan %{model} niet aanmaken." (nl). A host with its own locale needs that key.
+- **"+" and close icons on the gold bands meet WCAG contrast.** `.new_button` / `.close_button` in the model top bar and the associated header were the accent colour on gold: 2.9:1 on the model top bar (below the 3:1 for icons), and white on hover (1.8:1). They now use two new variables, `--if-color-on-band` and `--if-color-on-band-hover` (Sass `$if-on-band` / `$if-on-band-hover`), which clear 4.5:1 on both bands in every preset theme (default, dark, sepia, high-contrast). A host that overrides `--if-color-secondary` / `--if-color-header-band` should set them too. The associated header's close-button hover rule also targeted `.new_button:focus` instead of `.close_button:focus`.
+- **Installer: generated apps compile the gem's SCSS on every Dart Sass build.** The `config/initializers/inline_forms_dartsass_builds.rb` template maps `inline_forms_install/{inline_forms,devise}_main.scss` (`@use "inline_forms/inline_forms" as *`) to `app/assets/builds/inline_forms/{inline_forms,devise}.css`. dartsass-rails passes `app/assets/stylesheets` and then every `config.assets.paths` entry as load paths, and `app/assets/builds` comes before the gem, so from the second build on the `@use` resolved to the app's previous compiled `.css` instead of the gem's `.scss`. Gem stylesheet changes stopped reaching an app after its first build (and the example-app gate did not test them). The template now adds `--load-path=<inline_forms>/app/assets/stylesheets` to `config.dartsass.build_options`, which precede the load paths, as StProject's own initializer already does. **Existing apps** generated by an earlier installer should add the same two lines to their initializer.
+
+### Tests
+
+- `dropdown_test` (options sorted by presentation), `locale_test` (failure header in en and nl, `inline_forms.view.create_failed` in both locale files).
+- Example app: `example_app_sass_deprecations_test` compiles both gem entry points with sass-embedded (verbose) and fails if the gem gains an `@import` beyond the three above, or an entry point has more than 117 `[import]` deprecations.
+- Example app: `example_app_dartsass_build_test` checks that the gem's stylesheet dir is the first load path in the dartsass command, and that `app/assets/builds/inline_forms/{inline_forms,devise}.css` match a direct compile of the gem's entry points (test_helper's `dartsass:build` runs after the installer's, so builds/ already held a previous build).
+
+### Lockstep
+
+- validation_hints 8.1.58, inline_forms_installer 8.1.58, inline_forms_schema_edit 8.1.58.
+
 ## [8.1.57] - 2026-10-05
 
 Fixes from a security/UI review of a host app (StProject), plus missing and hard-coded translations found when StProject switched to `:nl` with `raise_on_missing_translations = :strict`.

data/app/assets/stylesheets/inline_forms/_theme.scss

@@ -33,6 +33,11 @@ $if-flash-accent: #fade7a !default; // flash border band
 $if-error-bg: #a70f0f !default;
 $if-success-bg: #4f8d0d !default;
 $if-on-dark: #FFFFFF !default;      // text/icons on primary/secondary bands
+// The "+" / close icons on the gold bands (secondary, header-band). The
+// accent was 2.9:1 on the secondary gold and the white hover 1.8:1; these
+// clear 4.5:1 on both bands.
+$if-on-band: #8F2F18 !default;
+$if-on-band-hover: #4A1A0C !default;
 
 :root {
   --if-color-primary: #{$if-primary};
@@ -48,6 +53,8 @@ $if-on-dark: #FFFFFF !default;      // text/icons on primary/secondary bands
   --if-color-error-bg: #{$if-error-bg};
   --if-color-success-bg: #{$if-success-bg};
   --if-color-on-dark: #{$if-on-dark};
+  --if-color-on-band: #{$if-on-band};
+  --if-color-on-band-hover: #{$if-on-band-hover};
   // Foundation globals, bridged so body/anchors can be re-themed too.
   --if-color-body-bg: #{$body-background};
   --if-color-body-text: #{$body-font-color};
@@ -85,6 +92,8 @@ body.theme-dark {
   --if-color-input-bg-hover: #332e25;
   --if-color-input-bg-focus: #3a352b;
   --if-color-flash-accent: #7a6829;
+  --if-color-on-band: #fdeee5;
+  --if-color-on-band-hover: #ffffff;
   --if-color-body-bg: #1c1a16;
   --if-color-body-text: #e8e4da;
   --if-color-anchor: #e0a179;
@@ -108,6 +117,8 @@ body.theme-sepia {
   --if-color-input-bg-hover: #fffaf0;
   --if-color-input-bg-focus: #fffdf7;
   --if-color-flash-accent: #dcc078;
+  --if-color-on-band: #6e3a20;
+  --if-color-on-band-hover: #3a2418;
   --if-color-body-bg: #f4ecd8;
   --if-color-body-text: #5b4636;
   --if-color-anchor: #8b5e3c;
@@ -124,6 +135,8 @@ body.theme-high-contrast {
   --if-color-input-bg-hover: #f5f5f5;
   --if-color-input-bg-focus: #ffffff;
   --if-color-flash-accent: #ffd500;
+  --if-color-on-band: #b30000;
+  --if-color-on-band-hover: #000000;
   --if-color-body-bg: #ffffff;
   --if-color-body-text: #000000;
   --if-color-anchor: #0000d6;

data/app/assets/stylesheets/inline_forms/devise.scss

@@ -1,6 +1,9 @@
 // Open Sans @font-face lives in inline_forms_fonts.css.erb (self-hosted,
 // Sprockets-served; linked from the layouts) — no external font CDN.
-@import 'foundation_and_overrides';
+// @use / @forward of foundation_and_overrides: see the module-system note
+// in inline_forms.scss.
+@forward 'foundation_and_overrides';
+@use 'foundation_and_overrides' as *;
 
 // Devise pages have only `.contain-to-grid` as the top-bar wrapper (no
 // `.fixed` variant), so constrain it directly to the F5 1000px row

data/app/assets/stylesheets/inline_forms/foundation_and_overrides.scss

@@ -55,6 +55,7 @@ $body-font-family: 'Open Sans', 'Helvetica Neue', Helvetica, Roboto, Arial, sans
 
 // Theme bridge: palette as CSS custom properties (must come after
 // 'foundation' so it can read $body-background / $anchor-color).
+// Stays @import: see the module-system note in inline_forms.scss.
 @import 'theme';
 
 @import '../../../vendor/assets/stylesheets/tippy.css';

data/app/assets/stylesheets/inline_forms/inline_forms.scss

@@ -2,19 +2,34 @@
 // Open Sans @font-face lives in inline_forms_fonts.css.erb (self-hosted,
 // Sprockets-served; linked from the layouts) — no external font CDN.
 //
-// Module-system status (8.1.24): `foundation_icons` is a self-contained
-// partial and loads via @use. Everything else must stay on @import until
-// the Foundation question is settled: foundation-rails 6.9 is @import-only
-// internally and its settings globals ($body-background, rem-calc, ...)
-// flow into foundation_and_overrides/theme/devise, which @use cannot
-// replicate without a Foundation that ships a module API (it never will —
-// the framework is unmaintained). See stuff/improvement-plan.md §1.
+// Module-system status (8.1.58). Loaded with @use:
+// - `foundation_icons` (8.1.24): a self-contained partial.
+// - `foundation_and_overrides`, here and in devise.scss (8.1.58). The
+//   compiled CSS is byte-identical to the @import version (the `.columns`
+//   alias below is the one rule that needed spelling out). The relative URL
+//   resolves next to this file first, as the @import did, so a same-named
+//   host or app/assets/builds file cannot shadow it. The @forward keeps what
+//   hosts saw through `@use "inline_forms/inline_forms"` before: Foundation's
+//   members (rem-calc, $global-width, ...) and the !default `$if-*` palette,
+//   configurable with `with (...)`.
+// Still @import, inside foundation_and_overrides:
+// - 'settings/settings' and 'foundation': foundation-rails 6.9 is
+//   @import-only and its settings globals feed our overrides. Blocked by the
+//   Foundation decision (unmaintained upstream; no module API coming).
+// - 'theme': a @use must precede the settings @import, which would move the
+//   theme's CSS ahead of Foundation's and run before $body-background exists;
+//   meta.load-css keeps the position but hides the `$if-*` palette from hosts
+//   (`with ($if-accent: ...)` stops working). Moves with Foundation.
+// The deadline is a dartsass-rails release that allows sass-embedded >= 3
+// (Dart Sass 3 removes @import; 0.5.1 pins ~> 1.63), not a date.
+// See stuff/improvement-plan.md §1.
 //
 // jQuery UI SCSS (sunny theme + widget styles) was dropped in 8.1.26 along
 // with the last jQuery UI widgets (native date/time/month/range/datalist
 // inputs replaced them).
 @use 'inline_forms/foundation_icons';
-@import 'foundation_and_overrides';
+@forward 'foundation_and_overrides';
+@use 'foundation_and_overrides' as *;
 
 // Foundation 6 makes `.row` a flex container (`display: flex`); a nested
 // `.row` is therefore a flex item and shrinks to its content's intrinsic
@@ -223,12 +238,12 @@ select:hover, select:focus {
   }
   .new_button {
     background-color: var(--if-color-secondary);
-    color: var(--if-color-accent);
+    color: var(--if-color-on-band);
     font-size: 1.3rem;
     padding: 0 2rem 0 1rem;
   }
   .new_button:hover, .new_button:focus {
-    color: white;
+    color: var(--if-color-on-band-hover);
     -webkit-transition-property: color;
     transition-property: color;
   }
@@ -358,26 +373,26 @@ turbo-frame {
   .new_button  {
     background-color: var(--if-color-header-band);
     font-size: 1.5rem;
-    color: var(--if-color-accent);
+    color: var(--if-color-on-band);
     padding: 0 0.5rem 0 1rem;
     margin: 0;
   }
   .new_button:hover, .new_button:focus {
     background-color: var(--if-color-header-band);
-    color: white;
+    color: var(--if-color-on-band-hover);
     -webkit-transition-property: color;
     transition-property: color;
   }
   .close_button  {
     background-color: var(--if-color-header-band);
     font-size: 1.5rem;
-    color: var(--if-color-accent);
+    color: var(--if-color-on-band);
     padding: 0 0.5rem 0 1rem;
     margin: 0;
   }
-  .close_button:hover, .new_button:focus {
+  .close_button:hover, .close_button:focus {
     background-color: var(--if-color-header-band);
-    color: white;
+    color: var(--if-color-on-band-hover);
     -webkit-transition-property: color;
     transition-property: color;
   }
@@ -423,7 +438,11 @@ turbo-frame {
   margin-bottom: 1.5em;
 }
 
-.column {
+// `.columns` named explicitly: Foundation's flex grid aliases it with
+// `.columns { @extend .column }`, which reached this rule while
+// foundation_and_overrides was @imported. Since it is @used (8.1.58),
+// that @extend no longer crosses into this module.
+.column, .columns {
     padding-right: 0 !important;
 }
 

data/app/controllers/inline_forms_controller.rb

@@ -189,7 +189,7 @@ class InlineFormsController < ApplicationController
         format.html { render_list_frame_after_save }
       end
     else
-      flash.now[:header] = [ "Kan #{@object.class.to_s.underscore} niet aanmaken." ]
+      flash.now[:header] = [ t("inline_forms.view.create_failed", model: @object.class.model_name.human) ]
       flash.now[:error] = @object.errors.to_a
       respond_to do |format|
         @object.inline_forms_attribute_list = attributes

data/lib/inline_forms/form_elements/dropdown_helper.rb

@@ -29,7 +29,7 @@ module InlineForms
       if klass.method_defined? :disabled_for_dropdown?
         options_disabled = values.map{|v| v.id if v.disabled_for_dropdown?}.compact
       end
-      values.sort_by {|v|v.send presentation}
+      values = values.sort_by {|v|v.send presentation}
       # the leading underscore is to avoid name conflicts, like 'email' and 'email_type' will result in 'email' and 'email[email_type_id]' in the form!
       collection_select( ('_' + object.class.to_s.underscore).to_sym,
                           attribute.to_s.foreign_key.to_sym,

data/lib/inline_forms/version.rb

@@ -1,5 +1,5 @@
 # -*- encoding : utf-8 -*-
 
 module InlineForms
-  VERSION = "8.1.57"
+  VERSION = "8.1.58"
 end

data/lib/locales/inline_forms.en.yml

@@ -27,6 +27,7 @@ en:
     view:
       close: close
       add_new: make a new %{model}
+      create_failed: Could not create %{model}.
       undo: undo
       restore: restore
       trash: trash

data/lib/locales/inline_forms.nl.yml

@@ -27,6 +27,7 @@ nl:
     view:
       close: sluiten
       add_new: Maak een nieuw %{model}
+      create_failed: Kan %{model} niet aanmaken.
       undo: terughalen
       restore: terugzetten
       trash: weggooien

data/test/integration/dropdown_test.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require_relative "../integration_test_helper"
+
+# dropdown_edit sorts its options by presentation; the sort_by result used to
+# be discarded, so the options came out in id order.
+class DropdownTest < InlineFormsIntegrationTestCase
+  test "dropdown_edit lists the options sorted by presentation" do
+    %w[Zeta Alpha Mu].each { |name| Machine.create!(name: name) }
+    part = Part.create!(name: "Gear")
+
+    get machines_path
+    html = controller.view_context.dropdown_edit(part, :machine)
+
+    assert_equal %w[Alpha Mu Zeta], html.scan(%r{<option value="\d+">([^<]*)</option>}).flatten
+  end
+end

data/test/integration/locale_test.rb

@@ -17,7 +17,7 @@ class LocaleTest < InlineFormsIntegrationTestCase
     inline_forms.view.versions_old_value inline_forms.view.versions_new_value inline_forms.view.versions_empty
     inline_forms.view.versions_rich_text inline_forms.view.version_events.create
     inline_forms.view.version_events.update inline_forms.view.version_events.destroy
-    inline_forms.devise.login common.more common.logout
+    inline_forms.devise.login common.more common.logout inline_forms.view.create_failed
   ].freeze
 
   setup do
@@ -71,6 +71,24 @@ class LocaleTest < InlineFormsIntegrationTestCase
     assert_equal "Machine is aangemaakt.", controller.flash[:success]
   end
 
+  # The failure header was hard-coded Dutch with the underscored class name
+  # ("Kan machine niet aanmaken.") in every locale.
+  test "create's failure flash header translates, with the human model name" do
+    I18n.backend.store_translations(:nl, machines: "machines",
+                                         activerecord: { models: { machine: "Werkbank" } })
+    strictly(:nl) do
+      post machines_path(update: "machines_list"), params: { name: "" }, headers: frame_headers("machines_list")
+    end
+    assert_equal [ "Kan Werkbank niet aanmaken." ], controller.flash[:header]
+
+    I18n.backend.store_translations(:en, machines: "machines")
+    strictly(:en) do
+      post machines_path(update: "machines_list"), params: { name: "" }, headers: frame_headers("machines_list")
+    end
+    assert_equal [ "Could not create Machine." ], controller.flash[:header]
+    assert_includes response.body, "Could not create Machine."
+  end
+
   test "the versions panel and list are translated, with localized timestamps" do
     row = "machine_#{@machine.id}"
     strictly(:nl) do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 8.1.57
+  version: 8.1.58
 platform: ruby
 authors:
 - Ace Suares
@@ -314,6 +314,7 @@ files:
 - test/inline_forms_addto_generator_test.rb
 - test/inline_forms_generator_test.rb
 - test/integration/csp_nonce_test.rb
+- test/integration/dropdown_test.rb
 - test/integration/field_authorization_test.rb
 - test/integration/file_slots_test.rb
 - test/integration/html_refusal_test.rb
@@ -402,6 +403,7 @@ test_files:
 - test/inline_forms_addto_generator_test.rb
 - test/inline_forms_generator_test.rb
 - test/integration/csp_nonce_test.rb
+- test/integration/dropdown_test.rb
 - test/integration/field_authorization_test.rb
 - test/integration/file_slots_test.rb
 - test/integration/html_refusal_test.rb