inline_forms 8.1.5 → 8.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a67a5a2a208fff953c0ffe9145425d30e7ae8fefae955271436033c1b2a99771
-  data.tar.gz: a7b359f732f395f368be30c35277b9eecbd1cbd253e388c8f59165b207297a6c
+  metadata.gz: 6faae45fc3c25f20b57cc614e61e77a5264c1d866a5fde22a6e634c639fb54b9
+  data.tar.gz: a30324d9cc1f598b4a9c5531f0b4fa45fe47186d2a07b8fc956e38c988a52872
 SHA512:
-  metadata.gz: 49e2f7a7fb54b318959f5c003793e4190c812f527fa5a36ed9160260ee217d0761bf1f5c28bdf1cc241f650dcde82662b084140903551f17aadf7c2f0a539498
-  data.tar.gz: bc33c4b2ee408988f01c166f2fcfc5ac07e684c3b966501db41edec5b7eb0e42e8ca50904c9fa5936005974bf0ca527c9abf2086771fea6e051a8fd255ab169f
+  metadata.gz: 9777058054bb9d8e1ff3213e0fd7bf420fd060f69a43005aef71e2fc9088aa58ccfb0e60aaa5ac4d57739aaa555bb01820bb1cc328d31543295ca8377c476eff
+  data.tar.gz: 3f938ebcb879f72cecd60bd0c2e8eab47c1d01c410c7e32c137953e8f925cda614ce1b32e418bd887d0c833aaeecb0909fb9ba73c75911742473b22cfc9e186c

data/CHANGELOG.md

@@ -4,6 +4,83 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [8.1.8] - 2026-05-27
+
+### Added
+
+- **`money_field`, `scale_with_integers`, `scale_with_values` are back in the `FormElementShowcase`.** All three were dropped from 8.1.6 because their `_show` helpers crashed (`humanized_money_with_symbol` undefined, positional-index lookups against `[[key,label]]` pairs). 8.1.7 fixed the two `scale_*` helpers; 8.1.8 wires the missing money-rails dependency:
+  - **money-rails wired into the installer Gemfile** (`gem 'money-rails', '~> 3.0'`). Adds the `humanized_money_with_symbol` view helper used by `money_field_show` and the `monetize` macro used in the showcase model.
+  - **`config/initializers/money.rb` generated** with `MoneyRails.configure { default_currency = :usd }` so the showcase renders predictably under any host locale.
+  - **`amount:money_field` column rewritten to `amount_cents:integer, default: 0, null: false`** in the generated create-table migration, and `monetize :amount_cents` declared on `FormElementShowcase`. That keeps the inline_forms attribute-list entry semantically correct (`[:amount, :money_field]`) — money-rails exposes the `amount`/`amount=` Money-aware accessors on top of the `_cents` column, so `obj.amount = "12.34"` parses to a Money and stores 1234 cents, and `obj.amount` reads back as `$12.34`.
+  - **`scale_int:scale_with_integers` (`{ 1 => 'one', … 5 => 'five' }`) and `scale_val:scale_with_values` (`{ 1 => 'red', 2 => 'green', 3 => 'blue' }`)** added to the showcase with value hashes, locale labels, and seed values (`scale_int=3, scale_val=2` on the full demo; both `1` on the empty demo).
+- **Showcase regression tests cover the three re-added fields.**
+  - `money_field` round-trips `"12.34"` and asserts `amount_cents == 1234` (skipped if money-rails is not monetizing `:amount`, so the same test file still works for older host apps).
+  - `scale_with_integers` and `scale_with_values` get round-trip integration tests structurally identical to the dropdown helper tests.
+  - `EXPECTED_ATTRIBUTES` (model test) and `SHOWCASE_FIELD_ATTRIBUTES` (page-render test) updated to require all three frames to render on `/form_element_showcases/:id`.
+
+### Fixed
+
+- **`money_field_show` rendered an empty `<a>` when the value was `nil`/zero.** money-rails' `humanized_money_with_symbol(nil)` returns `""`, so the inline-edit link had no visible text. The helper now uses the standard `<i class="fi-plus">` empty-state placeholder for nil/zero values, matching `dropdown_with_values_show` / `radio_button_show` / the 8.1.7 scale fixes.
+
+### Lockstep
+
+- `inline_forms`, `inline_forms_installer`, and `validation_hints` bumped from 8.1.7 to 8.1.8 in lockstep, even though `validation_hints` has no behavior change in this release.
+
+## [8.1.7] - 2026-05-27
+
+### Fixed
+
+- **`dropdown_with_integers` / `scale_with_integers` / `scale_with_values` `_show` helpers crashed on every non-trivial value.** All three did `attribute_values(object, attribute)[object.send(attribute)][1]` (or `[…].to_s` for `scale_with_integers`), i.e. they used `Array#[N]` against the `[[key, label], …]` array returned by `attribute_values` — that indexes positionally, not by key, so the stored integer was used as an array offset. Symptoms in the wild:
+  - `dropdown_with_integers_show` on a `rating_int = 3` against `{1 => "One", 2 => "Two", 3 => "Three"}` returned `values[3]` → `nil`, then `nil[1]` raised `NoMethodError: undefined method '[]' for nil`. With smaller values it silently rendered the *next* label (`rating_int = 1` rendered `"Two"`).
+  - `scale_with_integers_show` indexed an array with a string (`values[object.send(attribute).to_s]`), which raised `TypeError: no implicit conversion of String into Integer`.
+  - `scale_with_values_show` had the same positional-index bug as `dropdown_with_integers_show` and crashed identically on out-of-range integers.
+  
+  All three now use `values.assoc(object.send(attribute))` so the stored value is matched against the *key* column of the pair, and gracefully fall back to the empty-state `<i class="fi-plus">` placeholder when no pair matches (matches the nil branch in `dropdown_with_values_show` and `radio_button_show`). Showcase row in the example app now renders `"One"` for `rating_int = 1` (was: `"Two"`), and the `scale_*` helpers no longer crash from the showcase page.
+
+- **`Versions (N)` header flickered between `N` and `N+M` when the panel was toggled.** On a record whose associated `ActionText::RichText` has at least one PaperTrail version (e.g. the empty `FormElementShowcase` after a description edit), the closed `app/views/inline_forms/_versions.html.erb` partial counted `object.versions.length` (parent only, e.g. `7`) while the open `_versions_list.html.erb` partial counted `inline_forms_versions_for(@object).length` (parent + rich_text merged, e.g. `8`). The visible count therefore changed every time the user opened or closed the panel. Closed partial now uses the same `inline_forms_versions_for(object).length` so the header is stable and matches the number of rows the open panel actually shows. Verified against the running example app at `/form_element_showcases/4` after toggle.
+
+- **`month_year_picker_update` left three debug `puts 'XXXXXX…'` lines in the helper.** They printed before/after values to STDOUT on every save (visible during `rails test` and in production logs) and added no diagnostic value. Removed. The helper now also no-ops on an empty/invalid `params[:attribute]` instead of letting `Date.parse("")` raise `Date::Error: invalid date` — the previous "always parse" version forced the showcase numericality test to thread a placeholder `start_month` through the create POST just to keep the unrelated update branch from crashing during the same controller cycle. With the rescue in place the helper degrades to `nil` and the rest of the update path keeps running.
+
+### Lockstep
+
+- `inline_forms`, `inline_forms_installer`, and `validation_hints` bumped from 8.1.6 to 8.1.7 in lockstep, even though `inline_forms_installer` and `validation_hints` have no behavior change in this release.
+
+## [8.1.6] - 2026-05-27
+
+### Added
+
+- **FormElementShowcase example resource.** `inline_forms create … --example` now generates a fourth example model, `FormElementShowcase`, that declares every kept Tier 1 form_element helper on a single object. Coverage:
+  - text-shaped: `text_field`, `plain_text_area`
+  - numeric: `integer_field`, `decimal_field`
+  - date/time: `date_select`, `time_select`, `month_select`, `month_year_picker`
+  - choice: `check_box`, `radio_button`, `dropdown_with_integers`, `dropdown_with_values` (normal + `options_disabled`), `dropdown_with_values_with_stars`
+  - files: `file_field`, `audio_field`, `image_field` (Cover reuses Photo's `ImageUploader`)
+  - rich text: `rich_text`
+  - display-only: `header` (6 section headers), `info` (`created_at`/`updated_at`), `info_list` (`has_and_belongs_to_many :roles` rendered read-only)
+- **First field-level validation in the example app.** `validates :count, numericality: { only_integer: true }, allow_blank: true` on `FormElementShowcase`. The new integration test posts `count: "abc"` through the top-level create form and asserts the response re-renders the new form with the numericality error.
+- **`dropdown_with_values_with_stars` ships its assets.** 5 small `<n>stars.png` PNGs are shipped under `lib/installer_templates/example_app_assets/` and copied into `app/assets/images/` at install time.
+- **Showcase regression tests.** New integration tests cover text, numeric (incl. numericality negative), date/time, and choice/scale helpers, plus a full-page smoke test that asserts every per-attribute `<turbo-frame>` renders and the `info_list` empty-state branch is exercised. New model test pins the attribute list, the 8.1.5 row-shape `options_disabled` slot on `:priority2`, and the new numericality validation.
+- **Showcase seed migration.** Seeds two `FormElementShowcase` rows (one fully populated with a role assigned, one empty), so the rendered demo at `/form_element_showcases/1` exercises every show branch out of the box.
+
+### Dropped from previous draft
+
+Per user choice:
+
+- `text_area`, `text_area_without_ckeditor`, `plain_text` (redundant with `plain_text_area`).
+- `ckeditor` (alias of `rich_text`; no behavior gap to exercise).
+- `slider_with_values` (deferred; complex jQuery UI wiring).
+- `multi_image_field` (deferred; needs array column + `mount_uploaders` plural override).
+
+Per implementation discovery (runtime helpers are broken under the current code base; out of scope to fix here):
+
+- `money_field` (helper calls `humanized_money_with_symbol`, a `money-rails` view helper that is not declared in the installer Gemfile).
+- `scale_with_integers` (helper indexes the array returned by `attribute_values` with a string: `values[object.send(attribute).to_s]`, which raises `TypeError: no implicit conversion of String into Integer`).
+- `scale_with_values` (helper does `values[object.send(attribute)][1]`, which raises `NoMethodError: undefined method '[]' for nil` whenever the stored integer is not a valid array index of the post-sorted values).
+
+### Lockstep
+
+- `inline_forms`, `inline_forms_installer`, and `validation_hints` bumped from 8.1.5 to 8.1.6 in lockstep, even though `validation_hints` has no behavior change in this release.
+
 ## [8.1.5] - 2026-05-27
 
 ### Changed (hard-breaking)

data/app/views/inline_forms/_versions.html.erb

@@ -1,8 +1,13 @@
 <% object = local_assigns[:object] || @object -%>
 <% css_class_id = inline_forms_versions_turbo_frame_id(object) -%>
+<%# Count the same merged set the open list does (`inline_forms_versions_for`
+    sums the parent's PaperTrail versions and the versions of any associated
+    ActionText::RichText records). Using `object.versions.length` here meant
+    the closed header showed N (parent only) and the open header showed N+M
+    (parent + rich_text), flickering as the user toggled the panel. -%>
 <div class="row form_element_header associated_auto_header callout">
   <div class='medium-11 large-11 column' >
-    <%= "Versions (#{object.versions.length})" %>
+    <%= "Versions (#{inline_forms_versions_for(object).length})" %>
   </div>
   <div class='medium-1 large-1 column'>
       <%= link_to_versions_list(

data/lib/inline_forms/form_elements/dropdown_with_integers_helper.rb

@@ -10,8 +10,14 @@ module InlineForms
     #
     # values must be a Range or a one-dimensional array of Integers
     def dropdown_with_integers_show(object, attribute)
+      # `attribute_values` returns key/label pairs (e.g. [[1,'one'],[2,'two']]);
+      # use Array#assoc so the stored integer is matched against the *key*
+      # column, not used as a positional array index (which off-by-ones and
+      # raises on out-of-range or nil).
       values = attribute_values(object, attribute)
-      link_to_inline_edit object, attribute, values[object.send(attribute)][1], from_callee: __callee__
+      pair = values.assoc(object.send(attribute))
+      label = pair ? pair[1] : "<i class='fi-plus'></i>".html_safe
+      link_to_inline_edit object, attribute, label, from_callee: __callee__
     end
     
     def dropdown_with_integers_edit(object, attribute)

data/lib/inline_forms/form_elements/money_field_helper.rb

@@ -6,13 +6,24 @@ module InlineForms
     # -*- encoding : utf-8 -*-
     
     def money_field_show(object, attribute)
-      link_to_inline_edit object, attribute, humanized_money_with_symbol(object.send attribute), from_callee: __callee__
+      # `humanized_money_with_symbol` (money-rails) returns "" for nil/blank
+      # which renders as an empty anchor — show the empty-state placeholder
+      # instead, matching the nil branch on dropdown/radio show helpers.
+      value = object.send(attribute)
+      label = if defined?(humanized_money_with_symbol) && value.respond_to?(:zero?) && !value.zero?
+                humanized_money_with_symbol(value)
+              elsif value.blank?
+                "<i class='fi-plus'></i>".html_safe
+              else
+                humanized_money_with_symbol(value)
+              end
+      link_to_inline_edit object, attribute, label, from_callee: __callee__
     end
-    
+
     def money_field_edit(object, attribute)
       text_field_tag attribute, (object.send attribute), :class => 'input_money_field'
     end
-    
+
     def money_field_update(object, attribute)
       object.send( "#{attribute}=", params[attribute])
     end

data/lib/inline_forms/form_elements/month_year_picker_helper.rb

@@ -16,10 +16,10 @@ module InlineForms
     end
     
     def month_year_picker_update(object, attribute)
-      puts 'XXXXXXXXXXXXXXXXXXXXXXXXXX' + object[attribute.to_sym].inspect
-      puts 'XXXXXXXXXXXXXXXXXXXXXXXXXX' + Date.parse(params[attribute.to_sym].to_s).strftime("%F").to_s
-      object[attribute.to_sym] = Date.parse(params[attribute.to_sym].to_s).strftime("%F").to_s
-      puts 'XXXXXXXXXXXXXXXXXXXXXXXXXX' + object[attribute.to_sym].inspect
+      raw = params[attribute.to_sym].to_s
+      object[attribute.to_sym] = raw.empty? ? nil : Date.parse(raw).strftime("%F").to_s
+    rescue Date::Error
+      object[attribute.to_sym] = nil
     end
       INLINE_FORMS_FORM_ELEMENT
     end

data/lib/inline_forms/form_elements/scale_with_integers_helper.rb

@@ -11,8 +11,13 @@ module InlineForms
     # values must be a Range or a one-dimensional array of Integers
     #
     def scale_with_integers_show(object, attribute)
+      # `attribute_values` returns key/label pairs; match by key with
+      # Array#assoc rather than Array#[N] (which would index positionally
+      # and raise on out-of-range/nil).
       values = attribute_values(object, attribute)
-      link_to_inline_edit object, attribute, values[object.send(attribute).to_s], from_callee: __callee__
+      pair = values.assoc(object.send(attribute))
+      label = pair ? pair[1] : "<i class='fi-plus'></i>".html_safe
+      link_to_inline_edit object, attribute, label, from_callee: __callee__
     end
     
     def scale_with_integers_edit(object, attribute)

data/lib/inline_forms/form_elements/scale_with_values_helper.rb

@@ -10,8 +10,14 @@ module InlineForms
     #
     # values must be a hash { integer => string, ... } or an one-dimensional array of strings
     def scale_with_values_show(object, attribute)
+      # `attribute_values` returns [[key, label], ...] pairs. With a hash
+      # input the keys are the user-defined integers; with an array input
+      # they are the positional 0..N-1. Either way Array#assoc looks up
+      # by the stored value rather than treating it as a positional index.
       values = attribute_values(object, attribute)
-      link_to_inline_edit object, attribute, values[object.send(attribute)][1], from_callee: __callee__
+      pair = values.assoc(object.send(attribute))
+      label = pair ? pair[1] : "<i class='fi-plus'></i>".html_safe
+      link_to_inline_edit object, attribute, label, from_callee: __callee__
     end
     
     def scale_with_values_edit(object, attribute)

data/lib/inline_forms/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module InlineForms
-  VERSION = "8.1.5"
+  VERSION = "8.1.8"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 8.1.5
+  version: 8.1.8
 platform: ruby
 authors:
 - Ace Suares