inline_forms 8.1.47 → 8.1.53

data/test/integration/revert_skipped_columns_test.rb

@@ -0,0 +1,59 @@
+# frozen_string_literal: true
+
+require_relative "../integration_test_helper"
+
+# Reverting a version must leave columns excluded via `has_paper_trail skip:`
+# alone. PaperTrail's reify defaults to `unversioned_attributes: :nil`, which
+# set every skipped column to nil on the live record; revert's save! then
+# persisted that, so in StProject reverting any Client edit NULLed the file
+# bytes (`*_data`) while keeping `*_filename` (downloads returned empty files).
+class RevertSkippedColumnsTest < InlineFormsIntegrationTestCase
+  BYTES = "%PDF-1.4 fake bytes \x00\x01\x02".b
+
+  setup do
+    @dossier = Dossier.create!(name: "Original", data_filename: "plan.pdf", data: BYTES)
+  end
+
+  def turbo_stream_headers(frame_id)
+    frame_headers(frame_id).merge("Accept" => "text/vnd.turbo-stream.html")
+  end
+
+  def versions_for(event)
+    PaperTrail::Version.where(item_type: "Dossier", item_id: @dossier.id, event: event)
+  end
+
+  test "the skipped column is really not versioned" do
+    refute_includes versions_for("create").last.object_changes.to_s, "fake bytes"
+  end
+
+  test "reverting an unrelated update keeps the skipped column's bytes" do
+    @dossier.update!(name: "Renamed")
+    update_version = versions_for("update").last
+    frame = "dossier_#{@dossier.id}"
+
+    post revert_dossier_path(update_version.id, update: frame),
+         headers: turbo_stream_headers(frame)
+
+    assert_response :success
+    @dossier.reload
+    assert_equal "Original", @dossier.name, "revert must restore the versioned attribute"
+    assert_equal "plan.pdf", @dossier.data_filename
+    assert_equal BYTES, @dossier.data, "revert must not NULL a has_paper_trail skip: column"
+  end
+
+  test "replaying a destroy revert on an existing row keeps the skipped column's bytes" do
+    frame = "dossier_#{@dossier.id}"
+    delete dossier_path(@dossier, update: frame), headers: frame_headers(frame)
+    destroy_version = versions_for("destroy").last
+    # The destroy snapshot cannot hold the bytes (skipped); put the row back
+    # with its file, as the user would after the first undo + re-upload.
+    Dossier.create!(id: @dossier.id, name: "Original", data_filename: "plan.pdf", data: BYTES)
+
+    post revert_dossier_path(destroy_version.id, update: "dossiers_list"),
+         headers: turbo_stream_headers("dossiers_list")
+
+    assert_response :success
+    assert_equal BYTES, Dossier.find(@dossier.id).data,
+      "idempotent destroy revert must not copy a nil skipped column onto the live row"
+  end
+end

data/test/integration_test_helper.rb

@@ -58,6 +58,59 @@ ActiveRecord::Schema.define do
     t.timestamps
   end
 
+  # Dossier: `data` is in `has_paper_trail skip:` (file bytes, as in
+  # StProject's Client/Attachment); see revert_skipped_columns_test.rb.
+  create_table :dossiers, force: true do |t|
+    t.string :name
+    t.string :data_filename
+    t.binary :data
+    t.timestamps
+  end
+
+  # Document: declared file slots (InlineForms::StoredFiles); see
+  # file_slots_test.rb. The trash tables mirror the inline_forms:file_trash
+  # generator's migration.
+  create_table :documents, force: true do |t|
+    t.string :title
+    t.string :filename
+    t.binary :data
+    t.string :content_type
+    t.string :plan_filename
+    t.binary :plan_data
+    t.string :plan_content_type
+    t.timestamps
+  end
+
+  create_table :inline_forms_trashed_files, force: true do |t|
+    t.string   :record_type, null: false
+    t.bigint   :record_id, null: false
+    t.string   :attribute_name, null: false
+    t.string   :filename
+    t.string   :content_type
+    t.bigint   :byte_size
+    t.string   :checksum, limit: 64
+    t.binary   :data
+    t.string   :reason, null: false
+    t.boolean  :redacted, null: false, default: false
+    t.bigint   :trashed_by_id
+    t.datetime :trashed_at, null: false
+    t.bigint   :restored_by_id
+    t.datetime :restored_at
+    t.bigint   :purged_by_id
+    t.datetime :purged_at
+    t.datetime :purge_after
+    t.timestamps
+  end
+  add_index :inline_forms_trashed_files, [ :record_type, :record_id, :attribute_name ]
+  add_index :inline_forms_trashed_files, [ :purged_at, :restored_at, :purge_after ]
+
+  create_table :inline_forms_file_trash_sweeps, force: true do |t|
+    t.datetime :ran_at, null: false
+    t.integer  :purged_count, null: false, default: 0
+    t.text     :error
+    t.timestamps
+  end
+
   # Schema-GUI batch pipeline (inline_forms_schema_edit). Mirrors the gem's
   # install-generator migration.
   create_table :inline_forms_schema_batches, force: true do |t|
@@ -109,11 +162,20 @@ class InlineFormsIntegrationTestCase < ActionDispatch::IntegrationTest
   end
 
   setup do
+    Ability.restrictions = nil
     Widget.delete_all
     Kind.delete_all
     Part.delete_all
     Machine.delete_all
     Gizmo.delete_all
+    Dossier.delete_all
+    Document.delete_all
+    Document.require_filename = false
+    InlineForms::TrashedFile.delete_all
+    InlineForms::FileTrashSweep.delete_all
+    InlineForms.file_trash_retention = 30.days
+    InlineForms.file_trash_redact_on_purge = false
+    InlineForms.max_file_size = nil
     PaperTrail::Version.delete_all
     InlineForms::SchemaIntentRecord.delete_all
     InlineForms::SchemaBatch.delete_all

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 8.1.47
+  version: 8.1.53
 platform: ruby
 authors:
 - Ace Suares
@@ -94,7 +94,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".claude/settings.local.json"
 - ".document"
 - ".forgejo/workflows/ci.yml"
 - ".forgejo/workflows/full-gate.yml"
@@ -103,7 +102,6 @@ files:
 - ".rubocop_todo.yml"
 - ".ruby-version"
 - CHANGELOG.md
-- CLAUDE.md
 - Gemfile
 - LICENSE.txt
 - README.rdoc
@@ -122,11 +120,18 @@ files:
 - app/assets/stylesheets/inline_forms/inline_forms.scss
 - app/assets/stylesheets/inline_forms_fonts.css.erb
 - app/controllers/concerns/cancan_concern.rb
+- app/controllers/concerns/file_slots_concern.rb
 - app/controllers/concerns/versions_concern.rb
+- app/controllers/inline_forms/file_trash_controller.rb
 - app/controllers/inline_forms_application_controller.rb
 - app/controllers/inline_forms_controller.rb
+- app/helpers/inline_forms_file_trash_helper.rb
 - app/helpers/inline_forms_helper.rb
 - app/models/concerns/inline_forms/soft_deletable.rb
+- app/models/concerns/inline_forms/stored_files.rb
+- app/models/inline_forms/current.rb
+- app/models/inline_forms/file_trash_sweep.rb
+- app/models/inline_forms/trashed_file.rb
 - app/validators/curacao_id_number_validator.rb
 - app/validators/is_curacao_phone_validator.rb
 - app/validators/is_email_address_validator.rb
@@ -147,6 +152,7 @@ files:
 - app/views/inline_forms/_attribute_label.html.erb
 - app/views/inline_forms/_close.html.erb
 - app/views/inline_forms/_edit.html.erb
+- app/views/inline_forms/_file_slot.html.erb
 - app/views/inline_forms/_flash.html.erb
 - app/views/inline_forms/_generic_search.html.erb
 - app/views/inline_forms/_header.html.erb
@@ -157,11 +163,15 @@ files:
 - app/views/inline_forms/_pending_migration_row.html.erb
 - app/views/inline_forms/_show.html.erb
 - app/views/inline_forms/_versions.html.erb
+- app/views/inline_forms/_versions_file_entry.html.erb
 - app/views/inline_forms/_versions_list.html.erb
 - app/views/inline_forms/create_list_frame.html.erb
 - app/views/inline_forms/field_edit.html.erb
 - app/views/inline_forms/field_pending.html.erb
 - app/views/inline_forms/field_show.html.erb
+- app/views/inline_forms/file_field_frame.html.erb
+- app/views/inline_forms/file_trash/index.html.erb
+- app/views/inline_forms/file_trash_panel.html.erb
 - app/views/inline_forms/new_record.html.erb
 - app/views/inline_forms/row_close.html.erb
 - app/views/inline_forms/row_destroyed.html.erb
@@ -199,6 +209,8 @@ files:
 - inline_forms.gemspec
 - lib/generators/USAGE
 - lib/generators/assets/stylesheets/inline_forms_devise.css
+- lib/generators/inline_forms/file_trash_generator.rb
+- lib/generators/inline_forms/templates/create_inline_forms_file_trash.rb.erb
 - lib/generators/inline_forms_addto/USAGE
 - lib/generators/inline_forms_addto/templates/add_columns_migration.erb
 - lib/generators/inline_forms_addto_generator.rb
@@ -264,18 +276,24 @@ files:
 - lib/otherstuff/add_roles.sql
 - lib/otherstuff/mkrole
 - lib/otherstuff/roles_users.sql
+- lib/tasks/inline_forms_files.rake
 - lib/vagrant/vagrantbox-inline_forms.zip
 - script/migrate_form_elements.rb
 - test/archived_form_elements_test.rb
 - test/attribute_list_test.rb
 - test/dummy/app/controllers/application_controller.rb
+- test/dummy/app/controllers/documents_controller.rb
+- test/dummy/app/controllers/dossiers_controller.rb
 - test/dummy/app/controllers/gizmos_controller.rb
 - test/dummy/app/controllers/machines_controller.rb
 - test/dummy/app/controllers/parts_controller.rb
 - test/dummy/app/controllers/stats_controller.rb
 - test/dummy/app/controllers/widgets_controller.rb
 - test/dummy/app/helpers/application_helper.rb
+- test/dummy/app/models/ability.rb
 - test/dummy/app/models/application_record.rb
+- test/dummy/app/models/document.rb
+- test/dummy/app/models/dossier.rb
 - test/dummy/app/models/gizmo.rb
 - test/dummy/app/models/kind.rb
 - test/dummy/app/models/machine.rb
@@ -293,12 +311,16 @@ files:
 - test/inline_edit_polymorphic_path_test.rb
 - test/inline_forms_addto_generator_test.rb
 - test/inline_forms_generator_test.rb
+- test/integration/field_authorization_test.rb
+- test/integration/file_slots_test.rb
 - test/integration/inline_forms_crud_test.rb
+- test/integration/layout_title_test.rb
 - test/integration/legacy_elements_test.rb
 - test/integration/model_top_bar_test.rb
 - test/integration/native_inputs_test.rb
 - test/integration/open_after_create_test.rb
 - test/integration/pending_migration_gate_test.rb
+- test/integration/revert_skipped_columns_test.rb
 - test/integration/schema_batch_pipeline_test.rb
 - test/integration/schema_edit_test.rb
 - test/integration/schema_preview_test.rb
@@ -340,13 +362,18 @@ test_files:
 - test/archived_form_elements_test.rb
 - test/attribute_list_test.rb
 - test/dummy/app/controllers/application_controller.rb
+- test/dummy/app/controllers/documents_controller.rb
+- test/dummy/app/controllers/dossiers_controller.rb
 - test/dummy/app/controllers/gizmos_controller.rb
 - test/dummy/app/controllers/machines_controller.rb
 - test/dummy/app/controllers/parts_controller.rb
 - test/dummy/app/controllers/stats_controller.rb
 - test/dummy/app/controllers/widgets_controller.rb
 - test/dummy/app/helpers/application_helper.rb
+- test/dummy/app/models/ability.rb
 - test/dummy/app/models/application_record.rb
+- test/dummy/app/models/document.rb
+- test/dummy/app/models/dossier.rb
 - test/dummy/app/models/gizmo.rb
 - test/dummy/app/models/kind.rb
 - test/dummy/app/models/machine.rb
@@ -364,12 +391,16 @@ test_files:
 - test/inline_edit_polymorphic_path_test.rb
 - test/inline_forms_addto_generator_test.rb
 - test/inline_forms_generator_test.rb
+- test/integration/field_authorization_test.rb
+- test/integration/file_slots_test.rb
 - test/integration/inline_forms_crud_test.rb
+- test/integration/layout_title_test.rb
 - test/integration/legacy_elements_test.rb
 - test/integration/model_top_bar_test.rb
 - test/integration/native_inputs_test.rb
 - test/integration/open_after_create_test.rb
 - test/integration/pending_migration_gate_test.rb
+- test/integration/revert_skipped_columns_test.rb
 - test/integration/schema_batch_pipeline_test.rb
 - test/integration/schema_edit_test.rb
 - test/integration/schema_preview_test.rb

data/.claude/settings.local.json

@@ -1,9 +0,0 @@
-{
-  "permissions": {
-    "allow": [
-      "Bash(git ls-tree *)",
-      "Bash(git checkout *)",
-      "Bash(git merge *)"
-    ]
-  }
-}

data/CLAUDE.md

@@ -1,68 +0,0 @@
-# CLAUDE.md — inline_forms
-
-Instructions for any work in the inline_forms repo (`/home/code/inline_forms`).
-These apply to all work here and take precedence over global defaults where they
-conflict. Consolidated from the former `stuff/prompt/workflow.md` and
-`stuff/prompt/test-the-example-app.md`.
-
-## Workflow after any significant change
-
-1. Run the full example-app test (see **Testing the example app** below). Keep
-   improving until all tests succeed.
-2. Bump the **patch** version. Stay in the **8.1** line until further notice.
-   Never bump the minor version — even for big or breaking changes.
-   - Change the version in **all four gems** so they stay in lockstep, always,
-     even if nothing changed in some of them:
-     `validation_hints`, `inline_forms`, `inline_forms_installer`, and
-     `inline_forms_schema_edit` (in this repo under `inline_forms_schema_edit/`).
-3. Update the Changelog of all four gems.
-4. Commit everything.
-5. After committing, push to the `forgejo` remote
-   (`ssh://forgejo@dev02:2222/ace/...`) in **both repos** (inline_forms and
-   validation_hints) so every commit runs through CI (Forgejo Actions on dev02).
-   - Check the run at http://dev02:3300/ace/inline_forms/actions and fix
-     failures.
-6. Never push to `origin` (GitHub). Only Ace pushes there, and GitHub must not
-   run anything (no `.github/workflows`).
-
-## Testing the example app
-
-Goal: build the current gem, install it into `/home/code/testInline`, recreate
-`MyApp` from scratch using `--example`, and verify it with Rails tests.
-
-Do all steps end-to-end without asking for confirmation unless a command fails.
-
-### Steps
-
-1. In `/home/code/inline_forms`:
-   - Ensure the latest code is used.
-   - Run: `rvm use .`
-   - Build gems:
-     `gem build inline_forms.gemspec && gem build inline_forms_installer.gemspec && (cd inline_forms_schema_edit && gem build inline_forms_schema_edit.gemspec)`
-   - Confirm the built file names/versions
-     (`inline_forms-<version>.gem`, `inline_forms_installer-<version>.gem`,
-     `inline_forms_schema_edit/inline_forms_schema_edit-<version>.gem`).
-
-2. In `/home/code/testInline`:
-   - Remove the old app if present: `/home/code/testInline/MyApp`
-   - Run: `rvm use .`
-   - Install the freshly built gems from
-     `/home/code/inline_forms/inline_forms-<version>.gem`,
-     `inline_forms_installer-<version>.gem`, and
-     `inline_forms_schema_edit/inline_forms_schema_edit-<version>.gem`.
-
-3. Still in `/home/code/testInline`:
-   - Generate a fresh example app:
-     `inline_forms create MyApp -d sqlite --example`
-
-4. In `/home/code/testInline/MyApp`:
-   - Run: `rvm use .`
-   - Run verification: `rails test`
-
-### Output requirements
-
-- Briefly report each phase result (build, install, app generation, test run).
-- Include the exact commands run.
-- Include the test summary (runs/assertions/failures/errors/skips).
-- If anything fails, stop at the failing step and include the exact error and
-  the next corrective command you recommend.