inline_forms 8.1.45 → 8.1.47

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e972af3c243b856d22f2d070a2b2499250aee36a480f2a91747748849588c040
-  data.tar.gz: 154f76c200bb124fb4db651c720e23db9170ee9c0dd9c809256be33d3401526c
+  metadata.gz: a4f5d1ebb432475fd4db2c7eb7e92962b408b30a602c387f06af0b64a338cc4b
+  data.tar.gz: ac8c2e604daa44def24c578fced85d308c2ab7fe1b4f8f023af11e470ed97a50
 SHA512:
-  metadata.gz: 1a0a82d1235c438a8e6bc14eab60086b86ced441f6bd8ced137cd9c5a85d76fbf6cf49b60ace8beabac928c223c4128122fbaf159bd9e3847f91d9620b0d9a1f
-  data.tar.gz: 0f83cf85fb2f8e25109d1e9197222bad148c85f91e074b570082c8605d8f6541d95d304ed5c72c49c9a9d053d76e4abb37e61b8bb2325019cbd1dc1cb6cfc198
+  metadata.gz: 9717b909093e9b6c48db6a9325093bfbfc738b18f25d495a28095109b54e51e1671fa97df157570a85e55ef6f4ca278f340fbb7d1d58f6e73a05bf8cb7009f65
+  data.tar.gz: 3559bac6657e4ca87d33dc952d9031305db0682d6b1538e373c8193bc4e546f58d470949117d54a261676292f4fd48adb92f915cc096e76b4d69768e7de8fa92

data/CHANGELOG.md

@@ -4,6 +4,26 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [8.1.47] - 2026-07-25
+
+### Fixed
+
+- **Inline-edit save failures now show validation errors in the editor.** `InlineFormsController#update` already set `flash.now[:error]` on a failed save, but `field_edit` never rendered it (and `_edit` deliberately skips flash to avoid session notices leaking into the field). `field_edit` now displays `:error` only, inside the turbo-frame, with compact `.inline_forms_field_error` styling.
+
+### Lockstep
+
+- validation_hints 8.1.47, inline_forms_installer 8.1.47, inline_forms_schema_edit 8.1.47.
+
+## [8.1.46] - 2026-07-24
+
+### Fixed
+
+- **Model top bar no longer crashes when `@Klass` is nil.** Bespoke admin pages that render `layouts/inline_forms` from a non-`InlineFormsController` (e.g. a Stats/report controller) now show title-only chrome instead of raising on `new__path` / `link_to_new_record`. The new-record link is guarded with `<% if @Klass %>` as the per-app header did before 8.1.45.
+
+### Lockstep
+
+- validation_hints 8.1.46, inline_forms_installer 8.1.46, inline_forms_schema_edit 8.1.46.
+
 ## [8.1.45] - 2026-07-24
 
 ### Added

data/app/assets/stylesheets/inline_forms/inline_forms.scss

@@ -468,6 +468,21 @@ turbo-frame {
   padding: 0.3em;
   margin-bottom: 0.5em;
 }
+
+// Inline-edit validation feedback (flash.now[:error] on failed field save).
+// Shown in field_edit only; _edit deliberately skips flash to avoid session notices.
+.inline_forms_field_error {
+  font-size: 100%;
+  font-weight: normal;
+  line-height: 1.3;
+  margin: 0 0 0.4em;
+  padding: 0.35em 0.5em;
+
+  ul {
+    margin: 0;
+    padding-left: 1.2em;
+  }
+}
 .success {
   color: var(--if-color-on-dark);
   font-weight: bold;

data/app/views/inline_forms/_model_top_bar.html.erb

@@ -28,9 +28,11 @@
             <%= render "inline_forms/generic_search" %>
           </li>
         <% end %>
-        <li>
-          <%= link_to_new_record(@Klass, "new_#{@Klass.to_s.singularize.underscore}_path", @Klass.to_s.pluralize.downcase + "_list") %>
-        </li>
+        <% if @Klass %>
+          <li>
+            <%= link_to_new_record(@Klass, "new_#{@Klass.to_s.singularize.underscore}_path", @Klass.to_s.pluralize.downcase + "_list") %>
+          </li>
+        <% end %>
       </ul>
     </div>
   </nav>

data/app/views/inline_forms/field_edit.html.erb

@@ -1,3 +1,9 @@
 <turbo-frame id="<%= @update_span %>">
+  <% field_errors = flash[:error] %>
+  <% if field_errors.present? %>
+    <div class="flash error inline_forms_field_error" role="alert">
+      <ul><% Array(field_errors).each do |m| %><li><%= m %></li><% end %></ul>
+    </div>
+  <% end %>
   <%= render partial: "inline_forms/edit" %>
 </turbo-frame>

data/lib/inline_forms/version.rb

@@ -1,5 +1,5 @@
 # -*- encoding : utf-8 -*-
 
 module InlineForms
-  VERSION = "8.1.45"
+  VERSION = "8.1.47"
 end

data/test/dummy/app/controllers/stats_controller.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+# Bespoke report page: uses the inline_forms admin layout but is not an
+# InlineFormsController, so @Klass is never set (mirrors StProject Stats).
+class StatsController < ApplicationController
+  layout "inline_forms"
+
+  def show
+  end
+end

data/test/dummy/app/models/widget.rb

@@ -6,6 +6,7 @@ class Widget < ApplicationRecord
   belongs_to :kind, optional: true
 
   validates :name, presence: true
+  validates :notes, length: { minimum: 10 }, allow_blank: true
 
   scope :inline_forms_list, -> { order(:name, :id) }
   inline_forms_search_on :name

data/test/dummy/app/views/stats/show.html.erb

@@ -0,0 +1 @@
+<p id="stats_report">Stats report</p>

data/test/dummy/config/routes.rb

@@ -25,6 +25,8 @@ Rails.application.routes.draw do
     get "list_versions", on: :member
   end
 
+  get "stats", to: "stats#show"
+
   # Schema-change GUI (opt-in in real installs; routed here for the engine's
   # fast test suite). One line, so gem upgrades can add routes freely.
   InlineFormsSchemaEdit.draw_routes(self)

data/test/integration/inline_forms_crud_test.rb

@@ -71,6 +71,30 @@ class InlineFormsCrudTest < InlineFormsIntegrationTestCase
     assert_equal "Alpha", @widget.reload.name, "blank name must not persist"
     assert_includes response.body, %(name="name"),
       "expected the edit input to be re-rendered after a failed save"
+    assert_includes response.body, "inline_forms_field_error"
+    assert_includes response.body, "can&#39;t be blank"
+  end
+
+  test "failed save with invalid value shows validation errors in the editor" do
+    frame = "widget_#{@widget.id}_notes"
+    put widget_path(@widget, attribute: "notes", form_element: "plain_text_area",
+                    update: frame),
+        params: { notes: "short" }, headers: frame_headers(frame)
+
+    assert_response :success
+    assert_nil @widget.reload.notes
+    assert_includes response.body, "inline_forms_field_error"
+    assert_includes response.body, "is too short"
+  end
+
+  test "edit render shows no field error when flash is empty" do
+    frame = "widget_#{@widget.id}_name"
+    get edit_widget_path(@widget, attribute: "name", form_element: "text_field",
+                         update: frame),
+        headers: frame_headers(frame)
+
+    assert_response :success
+    refute_includes response.body, "inline_forms_field_error"
   end
 
   test "destroy responds with the destroyed-row state and an undo pointing at the destroy version" do

data/test/integration/model_top_bar_test.rb

@@ -43,4 +43,14 @@ class ModelTopBarTest < InlineFormsIntegrationTestCase
     assert_includes response.body, "Alpha"
     refute_includes response.body, "Beta"
   end
+
+  test "non-model page with no @Klass renders title only, no new-record link" do
+    get stats_path
+
+    assert_response :success
+    assert_includes response.body, %(id="inline_forms_model_top_bar")
+    assert_includes response.body, %(id="stats_report")
+    refute_includes response.body, "new_button"
+    refute_includes response.body, %(id="input_search")
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 8.1.45
+  version: 8.1.47
 platform: ruby
 authors:
 - Ace Suares
@@ -272,6 +272,7 @@ files:
 - test/dummy/app/controllers/gizmos_controller.rb
 - test/dummy/app/controllers/machines_controller.rb
 - test/dummy/app/controllers/parts_controller.rb
+- test/dummy/app/controllers/stats_controller.rb
 - test/dummy/app/controllers/widgets_controller.rb
 - test/dummy/app/helpers/application_helper.rb
 - test/dummy/app/models/application_record.rb
@@ -281,6 +282,7 @@ files:
 - test/dummy/app/models/part.rb
 - test/dummy/app/models/widget.rb
 - test/dummy/app/views/_gizmos_search.html.erb
+- test/dummy/app/views/stats/show.html.erb
 - test/dummy/config/application.rb
 - test/dummy/config/database.yml
 - test/dummy/config/environment.rb
@@ -341,6 +343,7 @@ test_files:
 - test/dummy/app/controllers/gizmos_controller.rb
 - test/dummy/app/controllers/machines_controller.rb
 - test/dummy/app/controllers/parts_controller.rb
+- test/dummy/app/controllers/stats_controller.rb
 - test/dummy/app/controllers/widgets_controller.rb
 - test/dummy/app/helpers/application_helper.rb
 - test/dummy/app/models/application_record.rb
@@ -350,6 +353,7 @@ test_files:
 - test/dummy/app/models/part.rb
 - test/dummy/app/models/widget.rb
 - test/dummy/app/views/_gizmos_search.html.erb
+- test/dummy/app/views/stats/show.html.erb
 - test/dummy/config/application.rb
 - test/dummy/config/database.yml
 - test/dummy/config/environment.rb