inline_forms 8.1.42 → 8.1.44

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 11df5d86221aad276d5bf2d4878702ce6651b595bd84f4911534922da817e07a
-  data.tar.gz: 14ac9ad9346af55d6573926f46f8fd907bf7d86e9eb695887d45e9abd5f67e58
+  metadata.gz: e8208cb1ccfd70968b65e5a5245b30586ab35034059749a20b4dc27ffde59bbe
+  data.tar.gz: 91f66242ff63e1d1c7ff22aa744939b05140f8b95cb8ac009956a1e70a2c9ca9
 SHA512:
-  metadata.gz: 5f5b578c9c304f90509dc7fc1fe5a226b6f1b954eb11a451053f5107c474278caecc7fcf456f339794b34014078c38205a30ad786acd426d269ef6cff9096614
-  data.tar.gz: af1a4a4a228b4b3be79e5d71ab0b2ef6f2f02fb662032bad0b9ba40b285de548abbcb31c8adb501e990dd0d02ac3532819e3acee09334cc83f4899d8f42f8fc7
+  metadata.gz: 6c7060b4c597512ab705c0eb8f104dbdb754ca4aa121e9214906e15e8ba3c64a942159e1a2d6312509465c02ab72f5299973742f317746d6f5ee99399283460f
+  data.tar.gz: 4411cae2c459f7de8b46651abe65a12360854d7434232b6a283c29a9fae4647cc5b49b548ab87fced3847f4e155975de8cf44d5b6d9ff5c610e83248b197edb8

data/.claude/settings.local.json

@@ -0,0 +1,9 @@
+{
+  "permissions": {
+    "allow": [
+      "Bash(git ls-tree *)",
+      "Bash(git checkout *)",
+      "Bash(git merge *)"
+    ]
+  }
+}

data/CHANGELOG.md

@@ -4,6 +4,32 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [8.1.44] - 2026-07-24
+
+### Fixed
+
+- **`simple_file_field` download link bypasses Turbo and uses the correct route segment.** When a file is present, the show link now carries `data-turbo="false"` so the browser handles the host controller's `send_data` response natively instead of Turbo loading binary content into the frame. The href route method is read from the raw values hash entry (e.g. `{ 0 => "download" }`) instead of through `attribute_values`, which translated the segment via `t()` and produced broken URLs. Integration test in `legacy_elements_test.rb`.
+
+### Lockstep
+
+- validation_hints 8.1.44, inline_forms_installer 8.1.44, inline_forms_schema_edit 8.1.44.
+
+## [8.1.43] - 2026-07-22
+
+### Fixed
+
+- **Native date/time/month/week/colour pickers show their picker control again.** Foundation's form reset (`_forms.scss`) applies `appearance: none` to a shared list of input types that includes `date`, `datetime-local`, `month`, `week`, `time`, and `color`. For plain text inputs that is harmless, but for the native `<input type="…">` pickers introduced in 8.1.25/8.1.26 (which replaced the jQuery UI date/time/month widgets) it stripped the browser's calendar/clock/month/colour indicator, leaving a bare text box with no way to open the picker. `inline_forms.scss` now restores `appearance: auto` for these input types (the `input[type=…]` selector outranks Foundation's `[type=…]`, so it wins regardless of source order).
+
+### Merged
+
+- Merges the `feature/schema-gui-pipeline` line (schema-GUI extraction, batch
+  pipeline, and the 8.1.42 `gem build` / release fixes) into `master` alongside
+  the picker fix above, so both lines ship together going forward.
+
+### Lockstep
+
+- validation_hints 8.1.43, inline_forms_installer 8.1.43, inline_forms_schema_edit 8.1.43.
+
 ## [8.1.42] - 2026-07-22
 
 ### Fixed

data/app/assets/stylesheets/inline_forms/inline_forms.scss

@@ -145,6 +145,25 @@ input {
   margin: 2px 0 !important;
 }
 
+// Foundation's form reset (_forms.scss) lumps the native temporal/colour
+// input types in with plain text inputs and applies `appearance: none` to
+// normalize them. For the native <input type="date|time|month|week|color">
+// pickers (8.1.25+, which replaced the jQuery UI date/time/month widgets)
+// that strips the browser's calendar/clock/month/colour picker indicator,
+// so the field renders as a bare text box with no way to open the picker.
+// Restore the native appearance for these so their picker control shows.
+// (`input[type=...]` is more specific than Foundation's `[type=...]`, so
+// this wins regardless of source order.)
+input[type="date"],
+input[type="datetime-local"],
+input[type="month"],
+input[type="week"],
+input[type="time"],
+input[type="color"] {
+  -webkit-appearance: auto;
+  appearance: auto;
+}
+
 select {
   background-color: var(--if-color-input-bg) !important;
   border: 0 !important;

data/lib/inline_forms/form_elements/simple_file_field_helper.rb

@@ -7,11 +7,14 @@ module InlineForms
     
     def simple_file_field_show(object, attribute)
       o = object.send(attribute)
-      method = attribute_values(object, attribute)[0][1]
+      attributes = @inline_forms_attribute_list || object.inline_forms_attribute_list
+      values = attributes.assoc(attribute.to_sym)[2]
+      raise "inline_forms: no values defined in #{object.class} for #{attribute} (add a values hash to the inline_forms_attribute_list row)" if values.nil?
+      method = values.is_a?(Hash) ? values.sort_by { |k, _| k }.first[1] : values.first
       if o.send(:present?)
         filename = o.to_s
         model = object.class.to_s.pluralize.underscore
-        link_to filename, "/#{model}/#{method}/#{object.id}" # route must exist!!
+        link_to filename, "/#{model}/#{method}/#{object.id}", data: { turbo: false } # route must exist!! turbo:false so the browser downloads send_data natively instead of Turbo loading it into the frame
       else
         link_to_inline_edit object, attribute, "<i class='fi-plus'></i>".html_safe, from_callee: __callee__
       end

data/lib/inline_forms/version.rb

@@ -1,5 +1,5 @@
 # -*- encoding : utf-8 -*-
 
 module InlineForms
-  VERSION = "8.1.42"
+  VERSION = "8.1.44"
 end

data/test/integration/legacy_elements_test.rb

@@ -20,6 +20,18 @@ class LegacyElementsTest < InlineFormsIntegrationTestCase
     assert_includes response.body, "fi-plus"
   end
 
+  test "simple_file_field present state download link bypasses Turbo" do
+    @widget.update!(manual: "Lida.png")
+    frame = "widget_#{@widget.id}"
+    get widget_path(@widget, update: frame), headers: frame_headers(frame)
+
+    assert_response :success
+    # The download link must carry data-turbo="false" so the browser handles
+    # the send_data response natively instead of Turbo loading the binary into
+    # the frame (a no-op). The route method comes from the values entry.
+    assert_match %r{<a[^>]*data-turbo="false"[^>]*href="/widgets/download/#{@widget.id}"}, response.body
+  end
+
   test "simple_file_field edit renders a file input" do
     frame = "widget_#{@widget.id}_manual"
     get edit_widget_path(@widget, attribute: "manual",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 8.1.42
+  version: 8.1.44
 platform: ruby
 authors:
 - Ace Suares
@@ -94,6 +94,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".claude/settings.local.json"
 - ".document"
 - ".forgejo/workflows/ci.yml"
 - ".forgejo/workflows/full-gate.yml"