inline_forms 8.1.40 → 8.1.42

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6e2f71a943f446268125b1012392c5156bcc5cbfc1df84385b4fc10225545135
-  data.tar.gz: ee90225c78498b2a1b0759805363e7871b772c79cdc2f41620a4470e2ed01e2b
+  metadata.gz: 11df5d86221aad276d5bf2d4878702ce6651b595bd84f4911534922da817e07a
+  data.tar.gz: 14ac9ad9346af55d6573926f46f8fd907bf7d86e9eb695887d45e9abd5f67e58
 SHA512:
-  metadata.gz: 4aded88b4f1ffeb2c4509505c16ef2e362e9bc89b86dc526fde9f83680750f850dad489a45d2067db754e558e05cd8d3871eb3dc48ec71e09e0d6e02f24c6717
-  data.tar.gz: 318a3f451539ae8a3a0775053b1a6f3f422759114cb4587f7ba89fd2d225a1186904e600a4e6f86c9f1424c9c2784975d3aaf595062722fb83ecc8b74126d3ea
+  metadata.gz: 5f5b578c9c304f90509dc7fc1fe5a226b6f1b954eb11a451053f5107c474278caecc7fcf456f339794b34014078c38205a30ad786acd426d269ef6cff9096614
+  data.tar.gz: af1a4a4a228b4b3be79e5d71ab0b2ef6f2f02fb662032bad0b9ba40b285de548abbcb31c8adb501e990dd0d02ac3532819e3acee09334cc83f4899d8f42f8fc7

data/.forgejo/workflows/full-gate.yml

@@ -33,17 +33,19 @@ jobs:
           token: ${{ secrets.VALIDATION_HINTS }}
           path: validation_hints
 
-      - name: Build the three gems
+      - name: Build the four gems
         run: |
           cd validation_hints && gem build validation_hints.gemspec && cd ..
           cd inline_forms && gem build inline_forms.gemspec && gem build inline_forms_installer.gemspec
+          cd inline_forms_schema_edit && gem build inline_forms_schema_edit.gemspec
 
       - name: Install built gems
         run: |
           gem install --no-document \
             validation_hints/validation_hints-*.gem \
             inline_forms/inline_forms-*.gem \
-            inline_forms/inline_forms_installer-*.gem
+            inline_forms/inline_forms_installer-*.gem \
+            inline_forms/inline_forms_schema_edit/inline_forms_schema_edit-*.gem
 
       # The installer git-inits the generated app and makes an initial commit
       # (installer_core.rb: `git add .` + `git commit`); a bare container has

data/.gitignore

@@ -21,10 +21,14 @@ pkg
 # Builds
 *.gem
 
+# Scratch / local notes and secrets (e.g. stuff/forgejo-token). Kept in-repo
+# .gitignore on purpose: the global excludes file that also ignores this is
+# per-machine and is absent on the release box, which let stuff/ leak into
+# `gem build`. Do not rely on the global ignore alone.
+stuff/
+
 Gemfile.lock
 
-# Local notes / analysis (not tracked)
-stuff/
 
 
 # test/dummy runtime artifacts (in-memory DB; only logs/tmp may appear)

data/.rubocop.yml

@@ -14,6 +14,7 @@ AllCops:
   TargetRubyVersion: 3.3
   Exclude:
     - "pkg/**/*"
+    - "inline_forms_schema_edit/pkg/**/*"
     - "vendor/**/*"
     - "archived/**/*"            # frozen historical code; linting defeats the purpose
     - "lib/installer_templates/**/*" # templates for *generated apps*, not engine style

data/CHANGELOG.md

@@ -4,6 +4,50 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [8.1.42] - 2026-07-22
+
+### Fixed
+
+- **`gem build` no longer packages the `stuff/` scratch dir (and its secrets).**
+  `InlineFormsGemFiles.gem_files` sweeps untracked files, so it depended on
+  `stuff/` being git-ignored. That ignore lived only in the per-machine global
+  excludes file, which is absent on the release box — so `stuff/forgejo-token`
+  (mode 0600) leaked into the file list and `gem build` died with `Errno::EACCES`.
+  `stuff/` is now excluded in `gem_files` itself, independent of any ignore
+  config, and re-added to the repo `.gitignore` as a second line of defense.
+
+### Changed
+
+- **Schema-change GUI extracted into its own gem** (`inline_forms_schema_edit`,
+  same repo, own gemspec; phase 0 of
+  `stuff/2026-07-11-schema-gui-gem-and-automated-pipeline-plan.md`).
+  `InlineForms::SchemaController`, its views and the `inline_forms_schema`
+  layout move out of the engine; the staging services (`SchemaIntent`,
+  `SchemaPreview`, `SchemaApply`, `SchemaLabel`) stay. The installer gains a
+  `--schema-edit` flag (default off, implied by `--example`) that adds the gem
+  to the generated Gemfile and wires the schema routes + "+ field" nav link;
+  apps created without it ship no schema-GUI surface at all.
+
+## [8.1.41] - 2026-07-11
+
+### Changed
+
+- **`inline_forms_addto` hardened** (see `stuff/2026-07-11-add-scalar-attribute-to-existing-model.md`). Adding a field to an existing model is now safer:
+  - **Smarter row placement.** New `inline_forms_attribute_list` rows land above the trailing metadata block (the first `:info` / `created_at` / `updated_at` row, and a `:header` directly above it) instead of at the very end, so an editable field no longer drops into the read-only info section. New `--before=ATTR` / `--after=ATTR` options place the row explicitly (warn + fall back to the default when the anchor is missing).
+  - **Robust model rewriting.** The greedy `]…end` regex is replaced by a bracket-depth scan from `@inline_forms_attribute_list ||= [` to its matching `]`, which survives `].freeze`, trailing comments, methods defined after the list, and nested `[ ]` in choice rows.
+  - **Value-bearing elements.** Choice elements (`dropdown_with_values`, `dropdown_with_integers`, `dropdown_with_values_with_stars`, `radio_button`, `check_box`, `scale_with_integers`, `scale_with_values`) now emit a placeholder `{ 1 => 'one', 2 => 'two' }` values hash and a warning instead of a bare 2-element row that raised at show time.
+  - **Collision-free migration timestamps.** Migration filenames use `max(now, highest_existing + 1)` so back-to-back runs (or a run right after another generator in the same second) never collide.
+  - **"Run db:migrate" reminder** printed after generation, since the attribute_list row is written immediately but its column only exists after migrating.
+
+### Added
+
+- Example app now exercises `inline_forms_addto` end to end: the installer adds `Apartment#internal_note` via `rails g inline_forms_addto` + `db:migrate`, and `example_app_apartment_addto_field_test.rb` asserts the column migrated, the row renders on the stock show panel, and an inline update round-trips.
+- Generator unit tests for the above (smart/explicit placement, `].freeze` + trailing-method robustness, value-bearing placeholder, timestamp uniqueness, and applying the generated migration to an in-memory sqlite DB).
+
+### Lockstep
+
+- validation_hints 8.1.41, inline_forms_installer 8.1.41.
+
 ## [8.1.40] - 2026-07-10
 
 ### Added

data/CLAUDE.md

@@ -0,0 +1,68 @@
+# CLAUDE.md — inline_forms
+
+Instructions for any work in the inline_forms repo (`/home/code/inline_forms`).
+These apply to all work here and take precedence over global defaults where they
+conflict. Consolidated from the former `stuff/prompt/workflow.md` and
+`stuff/prompt/test-the-example-app.md`.
+
+## Workflow after any significant change
+
+1. Run the full example-app test (see **Testing the example app** below). Keep
+   improving until all tests succeed.
+2. Bump the **patch** version. Stay in the **8.1** line until further notice.
+   Never bump the minor version — even for big or breaking changes.
+   - Change the version in **all four gems** so they stay in lockstep, always,
+     even if nothing changed in some of them:
+     `validation_hints`, `inline_forms`, `inline_forms_installer`, and
+     `inline_forms_schema_edit` (in this repo under `inline_forms_schema_edit/`).
+3. Update the Changelog of all four gems.
+4. Commit everything.
+5. After committing, push to the `forgejo` remote
+   (`ssh://forgejo@dev02:2222/ace/...`) in **both repos** (inline_forms and
+   validation_hints) so every commit runs through CI (Forgejo Actions on dev02).
+   - Check the run at http://dev02:3300/ace/inline_forms/actions and fix
+     failures.
+6. Never push to `origin` (GitHub). Only Ace pushes there, and GitHub must not
+   run anything (no `.github/workflows`).
+
+## Testing the example app
+
+Goal: build the current gem, install it into `/home/code/testInline`, recreate
+`MyApp` from scratch using `--example`, and verify it with Rails tests.
+
+Do all steps end-to-end without asking for confirmation unless a command fails.
+
+### Steps
+
+1. In `/home/code/inline_forms`:
+   - Ensure the latest code is used.
+   - Run: `rvm use .`
+   - Build gems:
+     `gem build inline_forms.gemspec && gem build inline_forms_installer.gemspec && (cd inline_forms_schema_edit && gem build inline_forms_schema_edit.gemspec)`
+   - Confirm the built file names/versions
+     (`inline_forms-<version>.gem`, `inline_forms_installer-<version>.gem`,
+     `inline_forms_schema_edit/inline_forms_schema_edit-<version>.gem`).
+
+2. In `/home/code/testInline`:
+   - Remove the old app if present: `/home/code/testInline/MyApp`
+   - Run: `rvm use .`
+   - Install the freshly built gems from
+     `/home/code/inline_forms/inline_forms-<version>.gem`,
+     `inline_forms_installer-<version>.gem`, and
+     `inline_forms_schema_edit/inline_forms_schema_edit-<version>.gem`.
+
+3. Still in `/home/code/testInline`:
+   - Generate a fresh example app:
+     `inline_forms create MyApp -d sqlite --example`
+
+4. In `/home/code/testInline/MyApp`:
+   - Run: `rvm use .`
+   - Run verification: `rails test`
+
+### Output requirements
+
+- Briefly report each phase result (build, install, app generation, test run).
+- Include the exact commands run.
+- Include the test summary (runs/assertions/failures/errors/skips).
+- If anything fails, stop at the failing step and include the exact error and
+  the next corrective command you recommend.

data/Gemfile

@@ -13,6 +13,10 @@ group :test do
   gem "will_paginate", "~> 4.0"
   gem "paper_trail", "~> 17.0"
   gem "turbo-rails"
+  # The schema-GUI engine gem (same repo, own gemspec). Test group so the
+  # dummy app's `Bundler.require(*Rails.groups)` loads it and the engine's
+  # schema_edit integration tests exercise the extracted controller/views.
+  gem "inline_forms_schema_edit", path: "inline_forms_schema_edit"
 end
 
 group :development, :test do

data/Rakefile

@@ -7,11 +7,18 @@ namespace :installer do
   Bundler::GemHelper.install_tasks name: "inline_forms_installer"
 end
 
+namespace :schema_edit do
+  # The schema-GUI gem lives in its own subdirectory (own gemspec, own pkg/).
+  Bundler::GemHelper.install_tasks dir: File.expand_path("inline_forms_schema_edit", __dir__),
+                                   name: "inline_forms_schema_edit"
+end
+
 def inline_forms_pkg_gems
-  pkg = File.expand_path("pkg", __dir__)
   version = InlineForms::VERSION
-  %w[inline_forms inline_forms_installer].map do |name|
-    path = File.join(pkg, "#{name}-#{version}.gem")
+  { "inline_forms" => "pkg",
+    "inline_forms_installer" => "pkg",
+    "inline_forms_schema_edit" => "inline_forms_schema_edit/pkg" }.map do |name, pkg|
+    path = File.expand_path(File.join(pkg, "#{name}-#{version}.gem"), __dir__)
     raise "Missing #{path}. Run rake build:all first." unless File.file?(path)
     path
   end
@@ -25,8 +32,8 @@ def validation_hints_pkg_gem
   ].find { |path| File.file?(path) }
 end
 
-desc "Build both inline_forms and inline_forms_installer into pkg/"
-task "build:all" => [ "build", "installer:build" ]
+desc "Build inline_forms, inline_forms_installer and inline_forms_schema_edit"
+task "build:all" => [ "build", "installer:build", "schema_edit:build" ]
 
 desc "Install freshly built gems from pkg/ into the current gemset (required before inline_forms create)"
 task "install:local" => [ "build:all" ] do
@@ -38,16 +45,50 @@ task "install:local" => [ "build:all" ] do
   puts "Verify: inline_forms --version 2>/dev/null || gem which inline_forms_installer"
 end
 
-# Release inline_forms + inline_forms_installer only (build, git tag/push, RubyGems push).
-# Does not run inline_forms create, MyApp, or tests. validation_hints is a separate
-# repo: cd ../validation_hints && rake release (same version number).
-desc "Release inline_forms and inline_forms_installer to RubyGems (no app generation)"
+# Release inline_forms + inline_forms_installer + inline_forms_schema_edit
+# (build, git tag/push, RubyGems push). Does not run inline_forms create,
+# MyApp, or tests. validation_hints is a separate repo:
+# cd ../validation_hints && rake release (same version number).
+# Release git-push ALWAYS targets `origin` (GitHub) only.
+#
+# Do NOT use Bundler's stock `release:source_control_push`: it pushes to the
+# CURRENT BRANCH's tracking remote (`git config branch.<branch>.remote`).
+# Feature branches in this repo track `forgejo` (dev02) because that's where
+# CI runs, so a release cut from a feature branch would push the release commit
+# and version tag to forgejo instead of GitHub. `origin` is the only place
+# release commits/tags belong; `forgejo` is CI-only. This task is also
+# idempotent on the tag, so a re-run after a failed push still lands the tag on
+# origin (Bundler's version skips entirely once the tag exists locally).
+# Also override the bare `release` task (from install_tasks above) so a stray
+# `rake release` can't push to a feature branch's forgejo tracking remote
+# either. The intended entry point is `release:all`, but this closes the
+# footgun on both.
+Rake::Task["release"].clear if Rake::Task.task_defined?("release")
+desc "Build inline_forms, tag, push to origin (GitHub) and push the gem to RubyGems"
+task "release" => [ "build", "release:guard_clean",
+                    "release:push_to_origin", "release:rubygem_push" ]
+
+desc "Tag the release and push the commit + tag to origin (GitHub) only"
+task "release:push_to_origin" do
+  version = InlineForms::VERSION
+  tag     = "v#{version}"
+  branch  = `git rev-parse --abbrev-ref HEAD`.strip
+  unless system("git", "rev-parse", "-q", "--verify", "refs/tags/#{tag}",
+                out: File::NULL, err: File::NULL)
+    sh "git", "tag", tag
+  end
+  sh "git", "push", "origin", "refs/heads/#{branch}"
+  sh "git", "push", "origin", "refs/tags/#{tag}"
+end
+
+desc "Release inline_forms, inline_forms_installer and inline_forms_schema_edit to RubyGems (no app generation)"
 task "release:all" => [
   "build:all",
   "release:guard_clean",
-  "release:source_control_push",
+  "release:push_to_origin",
   "release:rubygem_push",
-  "installer:release:rubygem_push"
+  "installer:release:rubygem_push",
+  "schema_edit:release:rubygem_push"
 ]
 
 require "rake/testtask"

data/app/controllers/inline_forms_controller.rb

@@ -137,6 +137,11 @@ class InlineFormsController < ApplicationController
     @update_span = params[:update]
     attributes = @inline_forms_attribute_list || @object.inline_forms_attribute_list
     attributes.each do | attribute, form_element |
+      # Skip a row whose column is not migrated yet (model edited, migration
+      # not run). Writing it would raise; the new form shows it as a pending
+      # placeholder and does not submit a value for it.
+      next if InlineForms.attribute_pending_migration?(@object, attribute, form_element)
+
       InlineForms.assert_plain_text_column!(object: @object, attribute: attribute, form_element: form_element)
       send("#{form_element}_update", @object, attribute) unless form_element == :associated || (cancan_enabled? && cannot?(:read, @object, attribute))
     end
@@ -186,6 +191,16 @@ class InlineFormsController < ApplicationController
     @form_element = params[:form_element]
     @sub_id = params[:sub_id]
     @update_span = params[:update]
+    # Defense-in-depth: the UI renders a pending field as a read-only
+    # placeholder (never links to edit/update), but a hand-crafted request
+    # could still target a column that is not migrated yet. Refuse cleanly
+    # instead of 500ing on the missing column.
+    if InlineForms.attribute_pending_migration?(@object, @attribute, @form_element)
+      respond_to do |format|
+        format.html { render "inline_forms/field_pending", layout: "turbo_rails/frame", status: :unprocessable_entity }
+      end
+      return
+    end
     InlineForms.assert_plain_text_column!(object: @object, attribute: @attribute, form_element: @form_element)
     send("#{@form_element}_update", @object, @attribute)
     # Branch on the actual save result. Previously the return value of

data/app/views/inline_forms/_new.html.erb

@@ -42,7 +42,10 @@
     <% attributes.each do | attribute, form_element | -%>
       <% unless form_element.to_sym == :associated || (cancan_enabled? && cannot?(:read, @object, attribute)) -%>
         <% css_class_id = "attribute_#{attribute}_#{@object.id}" -%>
-        <% if form_element && form_element.to_sym == :header %>
+        <% if InlineForms.attribute_pending_migration?(@object, attribute, form_element) %>
+          <%= render partial: "inline_forms/pending_migration_row",
+                locals: { object: @object, attribute: attribute } %>
+        <% elsif form_element && form_element.to_sym == :header %>
           <div class="row form_element_header" >
             <div class='large-12 column<%= " attribute_name attribute_#{attribute} form_element_#{form_element}" -%>' >
               <%= @object.human_attribute_name(attribute) -%>

data/app/views/inline_forms/_pending_migration_row.html.erb

@@ -0,0 +1,15 @@
+<%# Rendered in place of a field whose column does not exist yet (the model
+    file has the attribute_list row but its migration has not run). Read-only,
+    harmless, self-explanatory — see InlineForms.attribute_pending_migration?. %>
+<div class="row pending_migration_row <%= cycle('odd', 'even') %>">
+  <div class='medium-5 large-5 column'>
+    <%= render partial: "inline_forms/attribute_label",
+          locals: { object: object, attribute: attribute } -%>
+  </div>
+  <div class='medium-7 large-7 column'>
+    <span class="pending_migration_notice">
+      <%= t("inline_forms.pending_migration.notice",
+            default: "pending migration \u2014 run rails db:migrate") -%>
+    </span>
+  </div>
+</div>

data/app/views/inline_forms/_show.html.erb

@@ -23,7 +23,10 @@
     <% attributes.each do | attribute, form_element | -%>
       <% if cancan_disabled? || can?(:read, @object, attribute) %>
         <% css_class_id = "#{@object.class.name.underscore}_#{@object.id}_#{attribute}" -%>
-        <% if form_element == :header %>
+        <% if InlineForms.attribute_pending_migration?(@object, attribute, form_element) %>
+          <%= render partial: "inline_forms/pending_migration_row",
+                locals: { object: @object, attribute: attribute } %>
+        <% elsif form_element == :header %>
           <div class="row form_element_header">
             <div class='large-12 column' >
               <%= @object.class.human_attribute_name(attribute) -%>

data/app/views/inline_forms/field_pending.html.erb

@@ -0,0 +1,10 @@
+<%# Turbo-frame response for a forced field request (show/edit/update) against
+    an attribute whose column does not exist yet. The UI never links here (the
+    row renders as a pending placeholder in _show), so this is defense-in-depth
+    for a hand-crafted request during the pre-migrate window. %>
+<turbo-frame id="<%= @update_span %>">
+  <span class="pending_migration_notice">
+    <%= t("inline_forms.pending_migration.notice",
+          default: "pending migration \u2014 run rails db:migrate") -%>
+  </span>
+</turbo-frame>

data/lib/generators/inline_forms_addto/USAGE

@@ -13,6 +13,37 @@ Description:
     rejected. `_presentation`, `_list_order`, `_list_search`, and `_order` are
     skipped unless you pass `--replace`.
 
+Placement:
+    By default a new attribute_list row is inserted above the model's trailing
+    "metadata" block (its `:info` rows / created_at / updated_at, and a
+    `:header` directly above them) rather than at the very end, so an editable
+    field does not land inside the read-only info section. Override with:
+
+      --before=ATTR   insert the new row before an existing attribute
+      --after=ATTR    insert the new row after an existing attribute
+
+    If the named anchor is not found, the generator warns and falls back to the
+    default placement.
+
+Value-bearing form elements:
+    Choice elements (dropdown_with_values, dropdown_with_integers,
+    dropdown_with_values_with_stars, radio_button, check_box,
+    scale_with_integers, scale_with_values) need a values hash as the 3rd row
+    element. The generator inserts a placeholder `{ 1 => 'one', 2 => 'two' }`
+    and warns; edit it to your real values.
+
+Constraints and caveats:
+    - Additive only: the generated migration uses `add_column` / `add_reference`
+      (nullable, no default). Renaming, dropping, or making a column NOT NULL
+      (and the SQLite table-rebuild that would require) is out of scope; do
+      those by hand.
+    - Run `bundle exec rails db:migrate` after generating: the model row is
+      written immediately, but the column only exists once the migration runs.
+    - PaperTrail: versions recorded before this migration have no value for the
+      new column, so reverting an old record leaves the new column at its
+      default (nil), and the versions panel shows no history for it prior to
+      the migration.
+
 Example:
     rails generate inline_forms_addto User occupation:text_field birthdate:date organization:dropdown bio:rich_text