inline_forms 8.1.4 → 8.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 312520779c0b8e5a1d2ac65ae7baceaaf2c855dd200b0ea26d41920e48a8854d
-  data.tar.gz: 62441eb7d1dde51a0479c3f7225ff8a13cb7d6e6d72a5a23ce595a14c5b74aef
+  metadata.gz: 9493a835a60cc7791e52ea91cb2716a72c3f5e5581fcb6b17b14d31bb8aaa512
+  data.tar.gz: d8d4df01e059f92d7dee2da87e4ac7291d276d609f52f15d6bc81229d8a1472d
 SHA512:
-  metadata.gz: 3bf891bc7e1c84468cd5685fd73d238f4faa80779386d04dd45ef64f7057c1758b6ff8c2d294a745fe2c0e128cc2b0db28273a0ee4ed42cea4afa464c89f4fb3
-  data.tar.gz: a6f5f42359b955b53dcd907b44cf07ee3a96081f666edb2e7a01f266c4879973af34db664daed3270c392567734e1dfcdb8daf55d2fd64856f9102296c4f10f4
+  metadata.gz: 83979c7e18016408c1b19fc15b4c93798708939cc91903e8d26500ba581c31b6833ee046ee22e9771f173cea2fc190e88fce5d255ba6e838a8ee2cadf6c8786b
+  data.tar.gz: 3a6b1df0d6ff46044b225bb8dbe89ae2b64219350df5fbe0db2c942c1ec61052ae4de97bced9d805c64e46199e2f7bc2d48a54c716ce7b31349655539df019bf

data/CHANGELOG.md

@@ -4,6 +4,91 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [8.1.6] - 2026-05-27
+
+### Added
+
+- **FormElementShowcase example resource.** `inline_forms create … --example` now generates a fourth example model, `FormElementShowcase`, that declares every kept Tier 1 form_element helper on a single object. Coverage:
+  - text-shaped: `text_field`, `plain_text_area`
+  - numeric: `integer_field`, `decimal_field`
+  - date/time: `date_select`, `time_select`, `month_select`, `month_year_picker`
+  - choice: `check_box`, `radio_button`, `dropdown_with_integers`, `dropdown_with_values` (normal + `options_disabled`), `dropdown_with_values_with_stars`
+  - files: `file_field`, `audio_field`, `image_field` (Cover reuses Photo's `ImageUploader`)
+  - rich text: `rich_text`
+  - display-only: `header` (6 section headers), `info` (`created_at`/`updated_at`), `info_list` (`has_and_belongs_to_many :roles` rendered read-only)
+- **First field-level validation in the example app.** `validates :count, numericality: { only_integer: true }, allow_blank: true` on `FormElementShowcase`. The new integration test posts `count: "abc"` through the top-level create form and asserts the response re-renders the new form with the numericality error.
+- **`dropdown_with_values_with_stars` ships its assets.** 5 small `<n>stars.png` PNGs are shipped under `lib/installer_templates/example_app_assets/` and copied into `app/assets/images/` at install time.
+- **Showcase regression tests.** New integration tests cover text, numeric (incl. numericality negative), date/time, and choice/scale helpers, plus a full-page smoke test that asserts every per-attribute `<turbo-frame>` renders and the `info_list` empty-state branch is exercised. New model test pins the attribute list, the 8.1.5 row-shape `options_disabled` slot on `:priority2`, and the new numericality validation.
+- **Showcase seed migration.** Seeds two `FormElementShowcase` rows (one fully populated with a role assigned, one empty), so the rendered demo at `/form_element_showcases/1` exercises every show branch out of the box.
+
+### Dropped from previous draft
+
+Per user choice:
+
+- `text_area`, `text_area_without_ckeditor`, `plain_text` (redundant with `plain_text_area`).
+- `ckeditor` (alias of `rich_text`; no behavior gap to exercise).
+- `slider_with_values` (deferred; complex jQuery UI wiring).
+- `multi_image_field` (deferred; needs array column + `mount_uploaders` plural override).
+
+Per implementation discovery (runtime helpers are broken under the current code base; out of scope to fix here):
+
+- `money_field` (helper calls `humanized_money_with_symbol`, a `money-rails` view helper that is not declared in the installer Gemfile).
+- `scale_with_integers` (helper indexes the array returned by `attribute_values` with a string: `values[object.send(attribute).to_s]`, which raises `TypeError: no implicit conversion of String into Integer`).
+- `scale_with_values` (helper does `values[object.send(attribute)][1]`, which raises `NoMethodError: undefined method '[]' for nil` whenever the stored integer is not a valid array index of the post-sorted values).
+
+### Lockstep
+
+- `inline_forms`, `inline_forms_installer`, and `validation_hints` bumped from 8.1.5 to 8.1.6 in lockstep, even though `validation_hints` has no behavior change in this release.
+
+## [8.1.5] - 2026-05-27
+
+### Changed (hard-breaking)
+
+- **`inline_forms_attribute_list` rows are now 2-element by default.** The empty 2nd element (the unused human-name string) has been removed from every row across the gem, installer, generators, helpers, views, validators, tests, and docs. Labels have come from `Klass.human_attribute_name(attribute)` via locale files for a long time, so the slot was redundant. The migration in 8.1.5 makes that explicit by dropping the slot entirely.
+
+  Old shape:
+
+  ```ruby
+  [ :name, "name", :text_field ],
+  [ :sex, "sex", :radio_button, { 1 => 'f', 2 => 'm' } ],
+  [ :sex, "sex", :dropdown_with_values, values_hash, options_disabled ],
+  ```
+
+  New shape:
+
+  ```ruby
+  [ :name, :text_field ],
+  [ :sex, :radio_button, { 1 => 'f', 2 => 'm' } ],
+  [ :sex, :dropdown_with_values, values_hash, options_disabled ],
+  ```
+
+  **This is a hard break.** Consumers that read positions inside the row (`attributes.assoc(:foo)[3]` for `attribute_values`, `attributes.assoc(:foo)[4]` for `dropdown_with_values`' `options_disabled`) have shifted to `[2]` / `[3]`. Any model file left in the old 3/4/5-element shape will silently misbehave (the empty string `""` will be returned where the values hash or `options_disabled` array used to be), so every existing `inline_forms_attribute_list` in downstream apps must be rewritten.
+
+  Minimal migration for the common 3-element shape — run this once over `app/models/**/*.rb`:
+
+  ```ruby
+  # In your app's root, with a backup or in a clean git tree:
+  Dir.glob("app/models/**/*.rb").each do |path|
+    src = File.read(path)
+    new = src.gsub(/\[\s*(:\w+)\s*,\s*["'][^"']*["']\s*,\s*(:\w+)\s*\]/) { "[ #{$1}, #{$2} ]" }
+    File.write(path, new) if new != src
+  end
+  ```
+
+  For 4/5-element rows (`dropdown_with_values`, `radio_button`, `scale_*`, `slider_*`, `check_box`, `simple_file_field`, `must_be_a_value` validator targets), drop only the empty 2nd element and keep the trailing `values` / `options_disabled` arguments unchanged.
+
+### Changed (mechanical follow-through)
+
+- **`InlineFormsGenerator`** and **`InlineFormsAddtoGenerator`** emit the new 2-element row shape.
+- **Installer** (`inline_forms_installer/installer_core.rb`): hand-written `User` / `<custom>` model `inline_forms_attribute_list` rewritten; `gsub_file` injections for `Apartment#owner` and `Owner#apartments` updated to the new shape.
+- **Runtime consumers** (`InlineFormsController#create`, `app/views/inline_forms/_show.html.erb`, `_new.html.erb`, `_new_nested.html.erb`, `InlineForms.validate_plain_text_configuration_for!`, `InlineForms.validate_no_archived_form_elements_for!`) updated their row destructuring to `|attribute, form_element|`.
+- **Positional lookups** in `InlineFormsHelper#attribute_values`, `MustBeAValueValidator#attribute_values`, and `DropdownWithValuesHelper#…_edit` shifted from `[3]` / `[4]` to `[2]` / `[3]`.
+- **Tests & docs:** all fixtures, assertions, and code samples (USAGE files, READMEs, `archived/*/README.md`) updated to the new shape.
+
+### Notes
+
+- **Example app gate (recorded):** `inline_forms create MyApp -d sqlite --example` against the freshly built **8.1.5** gem trio: install in ~73s, `bundle check: ok`, **88 runs, 502 assertions, 0 failures, 0 errors, 0 skips**. Gem unit tests: 42 runs, 240 assertions, 0 failures.
+
 ## [8.1.4] - 2026-05-26
 
 ### Fixed

data/README.rdoc

@@ -62,7 +62,7 @@ You can install the example application manually if you like:
  rails g migration AddOwnerToApartments owner:references
  # Then in app/models/apartment.rb, add (under has_paper_trail):
  #   belongs_to :owner, optional: true
- # and prepend `[ :owner, "owner", :dropdown ],` to inline_forms_attribute_list.
+ # and prepend `[ :owner, :dropdown ],` to inline_forms_attribute_list.
  bundle exec rake db:migrate
  rails s
 
@@ -208,7 +208,7 @@ Active-tab highlighting is unchanged from upstream (still driven by +set_tab :fo
          tab = ALL_TABS.include?(params[:tab].to_s) ? params[:tab].to_s : ALL_TABS.first
          set_tab tab.to_sym
          @inline_forms_attribute_list = TAB_FIELDS.fetch(tab).map { |a|
-           @object.inline_forms_attribute_list.find { |attr, _, _| attr == a }
+           @object.inline_forms_attribute_list.find { |attr, _| attr == a }
          }
          render "clients/show_with_tabs",
                 layout: turbo_frame_request? ? "turbo_rails/frame" : "inline_forms"

data/app/controllers/inline_forms_controller.rb

@@ -135,7 +135,7 @@ class InlineFormsController < ApplicationController
     @object ||= @Klass.new
     @update_span = params[:update]
     attributes = @inline_forms_attribute_list || @object.inline_forms_attribute_list
-    attributes.each do | attribute, name, form_element |
+    attributes.each do | attribute, form_element |
       InlineForms.assert_plain_text_column!(object: @object, attribute: attribute, form_element: form_element)
       send("#{form_element.to_s}_update", @object, attribute) unless form_element == :associated || (cancan_enabled? && cannot?(:read, @object, attribute))
     end

data/app/helpers/inline_forms_helper.rb

@@ -310,7 +310,7 @@ module InlineFormsHelper
     # if we have a hash { 0=>'a', 2=>'b', 3=>'d' } will result in [[0,'a'],[2,'b'],[3,'d']] (it will keep the index and sort on the index)
     # TODO work this out better!
     # 2012-01-23 Use Cases
-    # [ :sex , "sex", :radio_button, { 1 => 'f', 2 => 'm' } ],
+    # [ :sex, :radio_button, { 1 => 'f', 2 => 'm' } ],
     # in this case we want the attribute in the database to be 1 or 2. From that attribute, we need to find the value.
     # using an array, won't work, since [ 'f', 'm' ][1] would be 'm' in stead of 'f'
     # so values should be a hash. BUT since we don't have sorted hashes (ruby 1,.8.7), the order of the values in the edit screen will be random.
@@ -326,10 +326,13 @@ module InlineFormsHelper
     # In the dropdown (or the slider) we definately need the order preserverd.
     # attribulte_values turns this into
     # [ [0,'???'], [1, '--'] .... [5, '++'] ]
-
+    #
+    # Row shape (since 8.1.x): [ :attr, :form_element, values, options_disabled ].
+    # `values` lives at index 2 (was index 3 before the empty label string was
+    # dropped in 8.1.x).
 
     attributes = @inline_forms_attribute_list || object.inline_forms_attribute_list # if we do this as a form_element, @inline.. is nil!!!
-    values = attributes.assoc(attribute.to_sym)[3]
+    values = attributes.assoc(attribute.to_sym)[2]
     raise t("fatal.no_values_defined_in", @Klass, attribute) if values.nil?
     if values.is_a?(Hash)
       temp = Array.new

data/app/validators/must_be_a_value_validator.rb

@@ -28,7 +28,7 @@ class MustBeAValueValidator < ActiveModel::EachValidator
     # if we have a hash { 0=>'a', 2=>'b', 3=>'d' } will result in [[0,'a'],[2,'b'],[3,'d']] (it will keep the index and sort on the index)
     # TODO work this out better!
     # 2012-01-23 Use Cases
-    # [ :sex , "sex", :radio_button, { 1 => 'f', 2 => 'm' } ],
+    # [ :sex, :radio_button, { 1 => 'f', 2 => 'm' } ],
     # in this case we want the attribute in the database to be 1 or 2. From that attribute, we need to find the value.
     # using an array, won't work, since [ 'v', 'm' ][1] would be 'm' in stead of 'v'
     # so values should be a hash. BUT since we don't have sorted hashes (ruby 1,.8.7), the order of the values in the edit screen will be random.
@@ -40,8 +40,11 @@ class MustBeAValueValidator < ActiveModel::EachValidator
     # like value=values.assoc(attribute_from_database)[1] (the [1] is needed since the result of #assoc = [1,'v'] and we need the 'v')
     # I feel it's ugly but it works.
 
+    # Row shape (since 8.1.x): [ :attr, :form_element, values, options_disabled ].
+    # `values` lives at index 2 (was index 3 before the empty label string was
+    # dropped in 8.1.x).
     attributes = @inline_forms_attribute_list || object.inline_forms_attribute_list # if we do this as a form_element, @inline.. is nil!!!
-    values = attributes.assoc(attribute.to_sym)[3]
+    values = attributes.assoc(attribute.to_sym)[2]
     raise "No Values defined in #{@Klass}, #{attribute}" if values.nil?
     if values.is_a?(Hash)
       temp = Array.new

data/app/views/inline_forms/_new.html.erb

@@ -39,7 +39,7 @@
         parent_id: @parent_id),
       new_form_opts do -%>
     <% attributes = @inline_forms_attribute_list || @object.inline_forms_attribute_list -%>
-    <% attributes.each do | attribute, name, form_element | -%>
+    <% attributes.each do | attribute, form_element | -%>
       <% unless form_element.to_sym == :associated || (cancan_enabled? && cannot?(:read, @object, attribute)) -%>
         <% css_class_id = "attribute_#{attribute}_#{@object.id}" -%>
         <% if form_element && form_element.to_sym == :header %>

data/app/views/inline_forms/_new_nested.html.erb

@@ -14,7 +14,7 @@ This goes in _new.html.erb
     </div>
   </div>
     <% nested_attributes = @nested_object.inline_forms_attribute_list -%>
-    <% nested_attributes.each do | nested_attribute, nested_name, nested_form_element | -%>
+    <% nested_attributes.each do | nested_attribute, nested_form_element | -%>
     <% @nested_form_element = nested_form_element %>
     <% @nested_attribute = nested_attribute %>
       <% unless @nested_form_element.to_sym == :associated -%>

data/app/views/inline_forms/_show.html.erb

@@ -20,7 +20,7 @@
     </div>
     <% end %>
     <% attributes = @inline_forms_attribute_list || @object.inline_forms_attribute_list -%>
-    <% attributes.each do | attribute, name, form_element | -%>
+    <% attributes.each do | attribute, form_element | -%>
       <% if cancan_disabled? || can?(:read, @object, attribute) %>
         <% css_class_id = "#{@object.class.name.underscore}_#{@object.id}_#{attribute}" -%>
         <% if form_element == :header %>

data/archived/form_elements/tree/README.md

@@ -5,7 +5,7 @@
 
 ## What it did
 
-Declare in `inline_forms_attribute_list`, e.g. `[ :children, "Children", :tree ]`:
+Declare in `inline_forms_attribute_list`, e.g. `[ :children, :tree ]`:
 
 - **`_show.html.erb`:** header “Children”, `+` for new child, `<turbo-frame>` wrapping **`_tree.html.erb`**.
 - **`_tree.html.erb`:** lists `parent.children` with Turbo row open, list-frame pagination (`update=…_list`).

data/lib/generators/USAGE

@@ -16,14 +16,14 @@ This will create:
           def _presentation
             #define your presentation here
           end
-          def inline_forms_field_list
-            [
-                [ :name, 'name', :text_field ],
-                [ :description, 'description', :plain_text ],
-                [ :yesno, 'yesno', :check_box ],
-                [ :gender, 'gender', :boolean_with_values ],
+          def inline_forms_attribute_list
+            @inline_forms_attribute_list ||= [
+                [ :name, :text_field ],
+                [ :description, :plain_text ],
+                [ :yesno, :check_box ],
+                [ :gender, :boolean_with_values ],
             ]
-         end
+          end
         end
 
         app/controllers/things_controller.rb

data/lib/generators/inline_forms_addto/USAGE

@@ -0,0 +1,46 @@
+Description:
+    Add fields to an existing inline_forms model. The model file must already
+    exist (from `rails g inline_forms` or the installer). Generates an additive
+    migration (`add_column`, `add_reference` for belongs_to/dropdown, a single
+    :string column for image_field/audio_field; no column for rich_text /
+    has_many / has_one / habtm) and updates the model: associations,
+    `has_rich_text`, `mount_uploader`, and new rows in `inline_forms_attribute_list`.
+
+    Does NOT create routes, a controller, or MODEL_TABS — those stay as-is for
+    the existing model. Use `rails g inline_forms` to scaffold new models.
+
+    Install-time-only names (`_no_model`, `_no_migration`, `_id`, `_enabled`) are
+    rejected. `_presentation`, `_list_order`, `_list_search`, and `_order` are
+    skipped unless you pass `--replace`.
+
+Example:
+    rails generate inline_forms_addto User occupation:text_field birthdate:date organization:dropdown bio:rich_text
+
+This will create:
+      create  db/migrate/20260527120000_inline_forms_add_to_users_occupation_birthdate.rb
+      insert  app/models/user.rb
+
+      db/migrate/..._inline_forms_add_to_users_occupation_birthdate.rb:
+        class InlineFormsAddToUsersOccupationBirthdate < ActiveRecord::Migration[8.1]
+          def change
+            add_column :users, :occupation, :string
+            add_column :users, :birthdate, :date
+            add_reference :users, :organization, foreign_key: true
+          end
+        end
+
+      app/models/user.rb (excerpt):
+        class User < ApplicationRecord
+          belongs_to :organization
+          has_rich_text :bio
+
+          def inline_forms_attribute_list
+            @inline_forms_attribute_list ||= [
+              ...
+              [ :occupation, :text_field ],
+              [ :birthdate, :date ],
+              [ :organization, :dropdown ],
+              [ :bio, :rich_text ],
+            ]
+          end
+        end

data/lib/generators/inline_forms_addto_generator.rb

@@ -39,7 +39,7 @@ class InlineFormsAddtoGenerator < Rails::Generators::NamedBase
     class_option :replace, type: :boolean, default: false,
                  desc: "Replace existing _presentation/_list_order/_list_search instead of skipping."
 
-    source_root File.expand_path("templates", __dir__)
+    source_root File.expand_path("inline_forms_addto/templates", __dir__)
 
     def validate!
       unless File.exist?(File.join(destination_root, model_file_path))
@@ -209,7 +209,7 @@ class InlineFormsAddtoGenerator < Rails::Generators::NamedBase
     # `ApplicationRecord`) and no body.
     def add_attribute_list_row!(attribute)
       content = File.read(File.join(destination_root, model_file_path))
-      row = "      [ :#{attribute.name} , \"#{attribute.name}\", :#{attribute.attribute_type} ],\n"
+      row = "      [ :#{attribute.name}, :#{attribute.attribute_type} ],\n"
 
       if content.match?(/@inline_forms_attribute_list \|\|=\s*\[/)
         if content.match?(/\[\s*:#{Regexp.escape(attribute.name)}\s*,/)
@@ -235,7 +235,7 @@ class InlineFormsAddtoGenerator < Rails::Generators::NamedBase
 
           def inline_forms_attribute_list
             @inline_forms_attribute_list ||= [
-              [ :#{attribute.name} , "#{attribute.name}", :#{attribute.attribute_type} ],
+              [ :#{attribute.name}, :#{attribute.attribute_type} ],
             ]
           end
         RUBY

data/lib/generators/inline_forms_generator.rb

@@ -123,8 +123,7 @@ module InlineForms
             @inline_forms_attribute_list << commenter +
               '     [ :' +
               attribute.name +
-              ' , "' + attribute.name +
-              '", :' + attribute.attribute_type.to_s +
+              ', :' + attribute.attribute_type.to_s +
               " ], \n"
           end
         end

data/lib/inline_forms/archived_form_elements.rb

@@ -50,7 +50,7 @@ module InlineForms
   def self.validate_no_archived_form_elements_for!(klass)
     return unless klass.instance_methods.include?(:inline_forms_attribute_list)
 
-    klass.new.inline_forms_attribute_list.each do |attribute, _label, form_element|
+    klass.new.inline_forms_attribute_list.each do |attribute, form_element|
       key = form_element.to_sym
       next unless ARCHIVED_FORM_ELEMENTS.key?(key)
 

data/lib/inline_forms/form_elements/dropdown_with_values_helper.rb

@@ -16,7 +16,7 @@ module InlineForms
       values = attribute_values(object, attribute)
     
       attributes = @inline_forms_attribute_list || object.inline_forms_attribute_list
-      options_disabled = attributes.assoc(attribute.to_sym)[4]
+      options_disabled = attributes.assoc(attribute.to_sym)[3]
     
       collection_select(  ('_' + object.class.to_s.underscore).to_sym,
                           attribute.to_sym,

data/lib/inline_forms/form_elements/radio_button_helper.rb

@@ -6,7 +6,7 @@ module InlineForms
     # -*- encoding : utf-8 -*-
     # radio buttons are integers in this version
     # us like this:
-    #   [ :sex , "gender", :radio_button, { 1 => 'male', 2 => 'female' } ],
+    #   [ :sex, :radio_button, { 1 => 'male', 2 => 'female' } ],
     
     def radio_button_show(object, attribute)
       values = attribute_values(object, attribute)

data/lib/inline_forms/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module InlineForms
-  VERSION = "8.1.4"
+  VERSION = "8.1.6"
 end

data/lib/inline_forms.rb

@@ -58,10 +58,10 @@ module InlineForms
   #
   #    class Example < ApplicationRecord
   #      def inline_forms_attribute_list
-  #        {
-  #          :name  => [ "name", :text_field ],
-  #          :price => [ "price", :text_field ],
-  #        }
+  #        [
+  #          [ :name,  :text_field ],
+  #          [ :price, :text_field ],
+  #        ]
   #      end
   #    end
   # as you see, both :string and :integer are mapped to a :text_field
@@ -92,7 +92,7 @@ module InlineForms
   #   t.belongs_to :country
   # to the migration. (In fact AR will add t.integer :country_id). And
   # it will add
-  #   :country => [ "country", :dropdown ],
+  #   [ :country, :dropdown ],
   # to the inline_forms_attribute_list in the model.
   #
   SPECIAL_COLUMN_TYPES = {
@@ -127,7 +127,7 @@ module InlineForms
     return unless klass.table_exists?
 
     attributes = klass.new.inline_forms_attribute_list
-    attributes.each do |attribute, _label, form_element|
+    attributes.each do |attribute, form_element|
       next unless plain_text_form_element?(form_element)
       next if klass.column_names.include?(attribute.to_s)
 

data/test/archived_form_elements_test.rb

@@ -6,13 +6,13 @@ require "inline_forms/archived_form_elements"
 class ArchivedFormElementsTest < Minitest::Test
   class ModelWithArchivedElement
     def inline_forms_attribute_list
-      [[:address, "Address", :geo_code_curacao]]
+      [[:address, :geo_code_curacao]]
     end
   end
 
   class ModelWithArchivedTree
     def inline_forms_attribute_list
-      [[:children, "Children", :tree]]
+      [[:children, :tree]]
     end
   end
 

data/test/inline_forms_addto_generator_test.rb

@@ -17,8 +17,8 @@ class InlineFormsAddtoGeneratorTest < Minitest::Test
 
       def inline_forms_attribute_list
         @inline_forms_attribute_list ||= [
-          [ :name , "name", :text_field ],
-          [ :category , "category", :belongs_to ],
+          [ :name, :text_field ],
+          [ :category, :belongs_to ],
         ]
       end
 
@@ -38,13 +38,13 @@ class InlineFormsAddtoGeneratorTest < Minitest::Test
 
       def inline_forms_attribute_list
         @inline_forms_attribute_list ||= [
-          [ :header_user_login,         '', :header ],
-          [ :name,                      '', :text_field ],
-          [ :email,                     '', :text_field ],
-          [ :locale ,                   '', :dropdown ],
-          [ :password,                  '', :devise_password_field ],
-          [ :header_user_roles,         '', :header ],
-          [ :roles,                     '', :check_list ],
+          [ :header_user_login, :header ],
+          [ :name,              :text_field ],
+          [ :email,             :text_field ],
+          [ :locale,            :dropdown ],
+          [ :password,          :devise_password_field ],
+          [ :header_user_roles, :header ],
+          [ :roles,             :check_list ],
         ]
       end
 
@@ -94,13 +94,13 @@ class InlineFormsAddtoGeneratorTest < Minitest::Test
     assert_includes(model, "belongs_to :supplier")
     assert_includes(model, "has_rich_text :bio")
     assert_includes(model, "mount_uploader :avatar, AvatarUploader")
-    assert_includes(model, '[ :occupation , "occupation", :text_field ]')
+    assert_includes(model, '[ :occupation, :text_field ]')
     # :belongs_to is a relation -> no row in inline_forms_attribute_list
     # (matches InlineFormsGenerator semantics). :dropdown is not a relation
     # at lookup time, so it does get a row.
-    refute_includes(model, '[ :organization , "organization", :belongs_to ]')
-    assert_includes(model, '[ :supplier , "supplier", :dropdown ]')
-    assert_includes(model, '[ :avatar , "avatar", :image_field ]')
+    refute_includes(model, '[ :organization, :belongs_to ]')
+    assert_includes(model, '[ :supplier, :dropdown ]')
+    assert_includes(model, '[ :avatar, :image_field ]')
 
     assert_includes(migration, "add_column :widgets, :occupation, :string")
     assert_includes(migration, "add_reference :widgets, :organization, foreign_key: true")
@@ -120,7 +120,7 @@ class InlineFormsAddtoGeneratorTest < Minitest::Test
     model = read("app/models/widget.rb")
 
     assert_equal(1, model.scan("belongs_to :organization").size)
-    assert_equal(1, model.scan('[ :occupation , "occupation", :text_field ]').size)
+    assert_equal(1, model.scan('[ :occupation, :text_field ]').size)
   end
 
   def test_appends_row_to_installer_shaped_user_attribute_list
@@ -130,8 +130,8 @@ class InlineFormsAddtoGeneratorTest < Minitest::Test
 
     model = read("app/models/user.rb")
 
-    assert_includes(model, '[ :occupation , "occupation", :text_field ]')
-    assert_includes(model, '[ :birthdate , "birthdate", :date_select ]')
+    assert_includes(model, '[ :occupation, :text_field ]')
+    assert_includes(model, '[ :birthdate, :date_select ]')
     refute_match(/\]\s*\n\s*\[\s*:occupation/, model)
 
     user_array_section = model[/@inline_forms_attribute_list \|\|=\s*\[(.|\n)*?\n\s*\]/]
@@ -150,7 +150,7 @@ class InlineFormsAddtoGeneratorTest < Minitest::Test
 
     assert_includes(out, "no inline_forms_attribute_list found")
     assert_includes(model, "def inline_forms_attribute_list")
-    assert_includes(model, '[ :occupation , "occupation", :text_field ]')
+    assert_includes(model, '[ :occupation, :text_field ]')
   end
 
   def test_unknown_type_raises_thor_error_by_default
@@ -174,7 +174,7 @@ class InlineFormsAddtoGeneratorTest < Minitest::Test
     model = read("app/models/widget.rb")
     migration = read_single_addto_migration_for("widgets")
 
-    assert_includes(model, '[ :payload , "payload", :unknown ]')
+    assert_includes(model, '[ :payload, :unknown ]')
     assert_includes(migration, "#    add_column :widgets, :payload, :unknown")
   end
 

data/test/inline_forms_generator_test.rb

@@ -44,8 +44,8 @@ class InlineFormsGeneratorTest < Minitest::Test
     refute_includes(model, "scope :inline_forms_search")
     assert_includes(model, "belongs_to :category")
     assert_includes(model, "has_many :photos")
-    assert_includes(model, "[ :name , \"name\", :text_field ]")
-    assert_includes(model, "[ :category , \"category\", :dropdown ]")
+    assert_includes(model, "[ :name, :text_field ]")
+    assert_includes(model, "[ :category, :dropdown ]")
 
     assert_includes(controller, "class ThingsController < InlineFormsController")
     assert_includes(controller, "set_tab :thing")
@@ -91,7 +91,7 @@ class InlineFormsGeneratorTest < Minitest::Test
     model = read("app/models/mystery.rb")
     migration = read_single_migration_for("mysteries")
 
-    assert_includes(model, "#     [ :payload , \"payload\", :unknown ]")
+    assert_includes(model, "#     [ :payload, :unknown ]")
     assert_includes(migration, "#     t.unknown :payload")
   end
 
@@ -167,7 +167,7 @@ class InlineFormsGeneratorTest < Minitest::Test
     model = read("app/models/note.rb")
     migration = read_single_migration_for("notes")
 
-    assert_includes(model, "[ :description , \"description\", :plain_text ]")
+    assert_includes(model, "[ :description, :plain_text ]")
     assert_includes(migration, "t.text :description")
   end
 

data/test/plain_text_configuration_test.rb

@@ -20,7 +20,7 @@ class PlainTextConfigurationTest < Minitest::Test
 
     def inline_forms_attribute_list
       [
-        [:description, "description", :plain_text]
+        [:description, :plain_text]
       ]
     end
   end
@@ -40,7 +40,7 @@ class PlainTextConfigurationTest < Minitest::Test
 
     def inline_forms_attribute_list
       [
-        [:description, "description", :plain_text]
+        [:description, :plain_text]
       ]
     end
   end
@@ -56,7 +56,7 @@ class PlainTextConfigurationTest < Minitest::Test
 
     def inline_forms_attribute_list
       [
-        [:description, "description", :rich_text]
+        [:description, :rich_text]
       ]
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 8.1.4
+  version: 8.1.6
 platform: ruby
 authors:
 - Ace Suares
@@ -495,11 +495,12 @@ files:
 - inline_forms.gemspec
 - lib/generators/USAGE
 - lib/generators/assets/stylesheets/inline_forms_devise.css
+- lib/generators/inline_forms_addto/USAGE
+- lib/generators/inline_forms_addto/templates/add_columns_migration.erb
 - lib/generators/inline_forms_addto_generator.rb
 - lib/generators/inline_forms_attribute_overrides.rb
 - lib/generators/inline_forms_generator.rb
 - lib/generators/templates/_inline_forms_tabs.html.erb
-- lib/generators/templates/add_columns_migration.erb
 - lib/generators/templates/application_record.rb
 - lib/generators/templates/controller.erb
 - lib/generators/templates/migration.erb