inline_forms 8.1.3 → 8.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 977ef4ea7379846bb2c176ef945cdaddb16816aed800d283b0655d08f0e0cfa8
-  data.tar.gz: 5dc4778948c43efa3b4348f7c906137aae4e25545229727ed83172bab4d776f2
+  metadata.gz: 312520779c0b8e5a1d2ac65ae7baceaaf2c855dd200b0ea26d41920e48a8854d
+  data.tar.gz: 62441eb7d1dde51a0479c3f7225ff8a13cb7d6e6d72a5a23ce595a14c5b74aef
 SHA512:
-  metadata.gz: 513ca378e912320a20a982210cad7f625788f79858a75310ea04e164de83a6124ca25ce43af7162065efc161e8693ec0464ac8f96e05659b46b53a2564647ba2
-  data.tar.gz: e4ec7479913bdeaa570064e1946884d00481774a07758af7e86170342464a55f2269c029822edecaf4f31130c3e822ca18338e8a34d2ef5d60e8d240e170525f
+  metadata.gz: 3bf891bc7e1c84468cd5685fd73d238f4faa80779386d04dd45ef64f7057c1758b6ff8c2d294a745fe2c0e128cc2b0db28273a0ee4ed42cea4afa464c89f4fb3
+  data.tar.gz: a6f5f42359b955b53dcd907b44cf07ee3a96081f666edb2e7a01f266c4879973af34db664daed3270c392567734e1dfcdb8daf55d2fd64856f9102296c4f10f4

data/CHANGELOG.md

@@ -4,6 +4,24 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [8.1.4] - 2026-05-26
+
+### Fixed
+
+- **Search box on `/users` (or `/members`, etc.) silently returned the full list.** The installer-generated user model declared `scope :inline_forms_list, -> { order(:name, :id) }` but **no** `inline_forms_search` scope, so `InlineFormsController#index`'s `merge(@Klass.inline_forms_search(params[:search]))` fell through to the `ApplicationRecord` no-op (`scope :inline_forms_search, ->(_q) { all }`) and emitted `SELECT … FROM users ORDER BY name ASC, id ASC LIMIT 7` — no `WHERE`, no filter, regardless of the search query. Installer's `User` / `<custom>` model template now ships `scope :inline_forms_search, ->(q) { where("name LIKE :q OR email LIKE :q", q: "%#{q}%") }`, so `/users?search=ad` now returns rows whose name or email matches `%ad%`. Custom user-model classes via `-U <Class>` get the same scope.
+- **Top-bar "More" dropdown was empty in every generated app** (long-standing latent bug). `lib/generators/inline_forms_generator.rb#add_tab` looked for the marker `ActionView::CompiledTemplates::MODEL_TABS = %w(` in `app/controllers/application_controller.rb`, but the installer wrote the initializer at `config/initializers/inline_forms.rb` with the marker `MODEL_TABS = %w(` and the application controller had no marker at all. Thor's `inject_into_file` silently skipped (no error, no message), so `MODEL_TABS` stayed `%w()` through every `rails g inline_forms` call. The header partial (`app/views/inline_forms/_header.html.erb`) iterated an empty list and the dropdown rendered just the chevron with no children — for years.
+  - `add_tab` now targets `config/initializers/inline_forms.rb` with the simpler marker `MODEL_TABS = %w(`, no-ops if the file or marker is missing (so consumers running `rails g inline_forms` in a non-installer-shaped app still work), and stays idempotent on re-run (skips the token if already present).
+  - Installer's initializer is now created **before** the `Locale` / `Role` `generate "inline_forms"` calls (was created at the end of the run), and is pre-seeded with the user-model's pluralised route — `MODEL_TABS = %w(<plural_route> )` — because the user model is hand-written by the installer (not generated) and would otherwise never be added.
+  - Net effect on a fresh `inline_forms create MyApp -d sqlite --example`: `MODEL_TABS = %w(owners apartments roles locales users )` (with `-U Member`: `… members `). The top-bar "More" dropdown now lists every HTML-reachable model the current `current_user` `can? :update`.
+
+### Changed
+
+- **Test skeleton (`test/inline_forms_generator_test.rb#build_destination_skeleton!`)** writes `config/initializers/inline_forms.rb` with `MODEL_TABS = %w()` (matching the installer) instead of the legacy `ActionView::CompiledTemplates::MODEL_TABS = %w()` in `application_controller.rb`. `test_generates_model_controller_route_migration_and_tab_injection` now asserts the token lands in the initializer.
+
+### Notes
+
+- **Example app gate (recorded):** `inline_forms create MyApp -d sqlite --example` against the freshly built **8.1.4** gem trio: install in ~71s, `bundle check: ok`, `MODEL_TABS = %w(owners apartments roles locales users )` in the initializer, **88 runs, 502 assertions, 0 failures, 0 errors, 0 skips**. Same result with `-U Member`, with `users → members` in `MODEL_TABS`.
+
 ## [8.1.3] - 2026-05-26
 
 ### Changed

data/inline_forms.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
   s.test_files = s.files.grep(%r{^(test|spec|features)/})
   s.require_paths = ["lib"]
 
-  s.add_dependency("validation_hints", ">= 8.1.3", "< 9.0")
+  s.add_dependency("validation_hints", ">= 8.1.4", "< 9.0")
   s.add_dependency("rails", ">= 8.1", "< 8.2")
   s.add_dependency("rails-i18n", ">= 8.1", "< 9.0")
 

data/lib/generators/inline_forms_generator.rb

@@ -186,11 +186,22 @@ module InlineForms
     def add_tab
       return if @flag_not_accessible_through_html
 
-      relative_path = "app/controllers/application_controller.rb"
-      marker = "ActionView::CompiledTemplates::MODEL_TABS = %w("
+      # The installer seeds `MODEL_TABS = %w(<user_model_route> )` in
+      # `config/initializers/inline_forms.rb` before any `rails g inline_forms`
+      # runs. Inject each generated model's pluralised route token into that
+      # list so the inline_forms top-bar dropdown (rendered by
+      # `app/views/inline_forms/_header.html.erb`) surfaces every
+      # HTML-reachable model. No-op when the initializer is absent (e.g. a
+      # consumer running `rails g inline_forms` in a non-installer-shaped app)
+      # or when the token is already present (idempotent re-run).
+      relative_path = "config/initializers/inline_forms.rb"
+      marker = "MODEL_TABS = %w("
       tab_token = "#{name.pluralize.underscore} "
       full_path = File.join(destination_root, relative_path)
+      return unless File.exist?(full_path)
+
       content = File.read(full_path)
+      return unless content.include?(marker)
       return if content.include?(tab_token.rstrip)
 
       inject_into_file relative_path, tab_token, after: marker

data/lib/inline_forms/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module InlineForms
-  VERSION = "8.1.3"
+  VERSION = "8.1.4"
 end

data/test/inline_forms_generator_test.rb

@@ -32,7 +32,7 @@ class InlineFormsGeneratorTest < Minitest::Test
     model = read("app/models/thing.rb")
     controller = read("app/controllers/things_controller.rb")
     routes = read("config/routes.rb")
-    application_controller = read("app/controllers/application_controller.rb")
+    inline_forms_initializer = read("config/initializers/inline_forms.rb")
     migration = read_single_migration_for("things")
 
     assert_includes(model, "class Thing < ApplicationRecord")
@@ -54,7 +54,7 @@ class InlineFormsGeneratorTest < Minitest::Test
     assert_includes(routes, "post 'revert', :on => :member")
     assert_includes(routes, "get 'list_versions', :on => :member")
 
-    assert_includes(application_controller, "MODEL_TABS = %w(things ")
+    assert_includes(inline_forms_initializer, "MODEL_TABS = %w(things ")
 
     assert_includes(migration, "class InlineFormsCreateThings < ActiveRecord::Migration[8.1]")
     assert_includes(migration, "create_table :things do |t|")
@@ -175,6 +175,7 @@ class InlineFormsGeneratorTest < Minitest::Test
 
   def build_destination_skeleton!
     mkdir_p("config")
+    mkdir_p("config/initializers")
     mkdir_p("app/controllers")
     mkdir_p("app/models")
     mkdir_p("db/migrate")
@@ -192,7 +193,17 @@ class InlineFormsGeneratorTest < Minitest::Test
       "app/controllers/application_controller.rb",
       <<~RUBY
         class ApplicationController < ActionController::Base
-          ActionView::CompiledTemplates::MODEL_TABS = %w()
+        end
+      RUBY
+    )
+
+    # Matches the file the installer writes; the generator's `add_tab` step
+    # injects `<plural_route> ` tokens after the `MODEL_TABS = %w(` marker.
+    write(
+      "config/initializers/inline_forms.rb",
+      <<~RUBY
+        Rails.application.reloader.to_prepare do
+          MODEL_TABS = %w()
         end
       RUBY
     )

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 8.1.3
+  version: 8.1.4
 platform: ruby
 authors:
 - Ace Suares
@@ -17,7 +17,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 8.1.3
+        version: 8.1.4
     - - "<"
       - !ruby/object:Gem::Version
         version: '9.0'
@@ -27,7 +27,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 8.1.3
+        version: 8.1.4
     - - "<"
       - !ruby/object:Gem::Version
         version: '9.0'