inline_forms 8.1.21 → 8.1.42

data/CHANGELOG.md

@@ -4,6 +4,311 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [8.1.42] - 2026-07-22
+
+### Fixed
+
+- **`gem build` no longer packages the `stuff/` scratch dir (and its secrets).**
+  `InlineFormsGemFiles.gem_files` sweeps untracked files, so it depended on
+  `stuff/` being git-ignored. That ignore lived only in the per-machine global
+  excludes file, which is absent on the release box — so `stuff/forgejo-token`
+  (mode 0600) leaked into the file list and `gem build` died with `Errno::EACCES`.
+  `stuff/` is now excluded in `gem_files` itself, independent of any ignore
+  config, and re-added to the repo `.gitignore` as a second line of defense.
+
+### Changed
+
+- **Schema-change GUI extracted into its own gem** (`inline_forms_schema_edit`,
+  same repo, own gemspec; phase 0 of
+  `stuff/2026-07-11-schema-gui-gem-and-automated-pipeline-plan.md`).
+  `InlineForms::SchemaController`, its views and the `inline_forms_schema`
+  layout move out of the engine; the staging services (`SchemaIntent`,
+  `SchemaPreview`, `SchemaApply`, `SchemaLabel`) stay. The installer gains a
+  `--schema-edit` flag (default off, implied by `--example`) that adds the gem
+  to the generated Gemfile and wires the schema routes + "+ field" nav link;
+  apps created without it ship no schema-GUI surface at all.
+
+## [8.1.41] - 2026-07-11
+
+### Changed
+
+- **`inline_forms_addto` hardened** (see `stuff/2026-07-11-add-scalar-attribute-to-existing-model.md`). Adding a field to an existing model is now safer:
+  - **Smarter row placement.** New `inline_forms_attribute_list` rows land above the trailing metadata block (the first `:info` / `created_at` / `updated_at` row, and a `:header` directly above it) instead of at the very end, so an editable field no longer drops into the read-only info section. New `--before=ATTR` / `--after=ATTR` options place the row explicitly (warn + fall back to the default when the anchor is missing).
+  - **Robust model rewriting.** The greedy `]…end` regex is replaced by a bracket-depth scan from `@inline_forms_attribute_list ||= [` to its matching `]`, which survives `].freeze`, trailing comments, methods defined after the list, and nested `[ ]` in choice rows.
+  - **Value-bearing elements.** Choice elements (`dropdown_with_values`, `dropdown_with_integers`, `dropdown_with_values_with_stars`, `radio_button`, `check_box`, `scale_with_integers`, `scale_with_values`) now emit a placeholder `{ 1 => 'one', 2 => 'two' }` values hash and a warning instead of a bare 2-element row that raised at show time.
+  - **Collision-free migration timestamps.** Migration filenames use `max(now, highest_existing + 1)` so back-to-back runs (or a run right after another generator in the same second) never collide.
+  - **"Run db:migrate" reminder** printed after generation, since the attribute_list row is written immediately but its column only exists after migrating.
+
+### Added
+
+- Example app now exercises `inline_forms_addto` end to end: the installer adds `Apartment#internal_note` via `rails g inline_forms_addto` + `db:migrate`, and `example_app_apartment_addto_field_test.rb` asserts the column migrated, the row renders on the stock show panel, and an inline update round-trips.
+- Generator unit tests for the above (smart/explicit placement, `].freeze` + trailing-method robustness, value-bearing placeholder, timestamp uniqueness, and applying the generated migration to an in-memory sqlite DB).
+
+### Lockstep
+
+- validation_hints 8.1.41, inline_forms_installer 8.1.41.
+
+## [8.1.40] - 2026-07-10
+
+### Added
+
+- **Example app demonstrates nesting-in-nesting** (Apartment → Photo → Comment): the installer now generates a `Comment` model (`body:text_area photo:belongs_to`, not accessible through top-level HTML, like Photo) and gives Photo `comments:has_many comments:associated`, so opening a photo row inside an apartment's photos panel exposes a second-level comments panel with its own nested new/create/open/close flows. The seed migration puts two comments on each seeded apartment's first photo so the panel is visibly populated out of the box (and removes them in `down`).
+- Example-app test `example_app_photo_comments_test.rb`: comments blocked as a standalone HTML resource, comments panel + new link inside the opened nested photo row, panel lists existing comments, nested new/create with the photo FK, comment row open/close. Also documents that open-after-create does not fire for nested creates (Comment has no `:associated` panel; the nested flow keeps the plain frame response).
+
+### Lockstep
+
+- validation_hints 8.1.40, inline_forms_installer 8.1.40 (no changes of their own).
+
+## [8.1.39] - 2026-07-10
+
+### Added
+
+- **"Open after create"** (Option A of `stuff/2026-07-10-nested-creation-options.md`): a successful *top-level* create of a model whose attribute list contains an `:associated` (has_many) panel now responds with Turbo Streams that refresh the list **and** open the freshly created record's row. The user lands directly where the nested panel — which only exists on a persisted record — is usable (e.g. create an Apartment, immediately add Photos), instead of hunting for the new row in the closed list. Nested creates, models without `:associated` panels, failed saves, and clients without a turbo-stream Accept header keep the existing list-frame HTML responses. If the new record sorts onto a different page of the list, the row-open stream finds no target and degrades silently to the old list-refresh behavior. (`InlineFormsController#open_created_row?` / `#render_created_row_open_streams`.)
+- Engine test coverage: new dummy models `Machine`/`Part` (mirroring Apartment/Photo) plus `test/integration/open_after_create_test.rb` (stream response, html fallback, no-associated fallback, nested create unchanged, failed create unchanged). The dummy host app gained the minimal chrome the full `inline_forms` layout needs (current_user stub with `role?`, `application_name` helper, `_inline_forms_tabs` partial, empty `MODEL_TABS`, devise logout route stand-in), so create/new HTML flows are now testable in the fast engine suite at all.
+- Example-app test: `example_app_apartment_top_level_new_test.rb` verifies the turbo-stream create response opens the new Apartment's row with the photos panel and its "new photo" link.
+
+### Lockstep
+
+- validation_hints 8.1.39, inline_forms_installer 8.1.39 (no changes of their own).
+
+## [8.1.38] - 2026-07-07
+
+### Changed
+
+- **RuboCop todo shrunk from 590 to 196 offenses (54 → 40 files, all heredoc-bearing).** Every heredoc-free file was safe-autocorrected in reviewed batches (engine tests green after each): validators, gemspecs, Rakefile, dummy-app models, engine core (`lib/inline_forms.rb`, form-element registry, turbo tabs builder), controller/helpers, installer `creator.rb`/`user_model_config.rb`, and the archived-elements list — bracket spacing, hash syntax (`:a => 1` → `a: 1`), string quotes, comment spacing, `%q{}` → `%q()`. One manual fix: the `if/else` alignment in `turbo_tabs_builder.rb` that autocorrect mangled cosmetically (rewritten as an indented assignment).
+- **Heredoc policy, made explicit:** files whose heredocs emit generated-app code (installer core, generators, form-element helpers, generator tests) are deliberately untouched — autocorrect near heredocs risks changing emitted code. `Layout/TrailingWhitespace` now runs with `AllowInHeredoc: true` (heredoc bodies are generated-file content); outside heredocs the tree is whitespace-clean. The remaining todo entries are per-file excludes on exactly those 40 heredoc files.
+- Full example-app gate passed: MyApp generated from the 8.1.38 gems, 157 runs / 960 assertions / 0 failures.
+
+### Lockstep
+
+- validation_hints 8.1.38, inline_forms_installer 8.1.38 (no changes of their own).
+
+## [8.1.37] - 2026-07-06
+
+### Lockstep
+
+- **validation_hints 8.1.37**: RuboCop todo eliminated — all 22 grandfathered offenses autocorrected (style-only: bracket spacing, magic-comment blank line, one trailing comma), `.rubocop_todo.yml` deleted. inline_forms and inline_forms_installer have no changes of their own. (inline_forms' own 590-offense todo remains; it shrinks incrementally as files get cleaned.)
+
+## [8.1.36] - 2026-07-06
+
+### Changed
+
+- **Generated apps force SSL in production** (`config.assume_ssl = true` + `config.force_ssl = true`). `rails new` only enables these when Kamal is skipped; generated apps deploy through the shipped Capistrano/Unicorn setup behind an SSL-terminating proxy, and the injected Devise mailer config already assumed https. This was the **only finding of the first Brakeman baseline** (full-gate CI run 6 against the generated app: default check set 0 warnings, `--run-all-checks` exactly this one High/ForceSSL). Internal plain-HTTP apps can re-comment the two lines in their own `production.rb`.
+- **full-gate CI: Brakeman's default check set is now enforcing** (baseline is clean); the pedantic `--run-all-checks` pass stays informational.
+
+### Added
+
+- Regression test `example_app_production_ssl_test.rb`: the generated `production.rb` must enable `assume_ssl`/`force_ssl` (guards the installer's gsub against Rails template drift).
+
+### Lockstep
+
+- validation_hints 8.1.36, inline_forms_installer 8.1.36 (no changes of their own).
+
+## [8.1.35] - 2026-07-06
+
+### Fixed
+
+- **Example-app photo seeding no longer depends on a maintainer-only local folder.** The installer looked for gallery images in a *gitignored* `pics/` folder (falling back to the hardcoded `/home/code/inline_forms/pics`), which exists only on the maintainer's machine — any gem install elsewhere (first exposed by the Forgejo `full-gate` CI run) silently seeded **zero** photos and failed 12 gallery/pagination/revert tests. Nine CC0 placeholder PNGs (~4 KB each, solid pastel with an "Apt N / Room" label, generated with ImageMagick) now ship inside the installer under `lib/installer_templates/example_app_assets/seed_images/`, so every install gets the same gallery. `INLINE_FORMS_SEED_PICS` still overrides with a custom folder; the old `pics/` convention is retired.
+- **`full-gate` CI workflow: git identity.** The installer's initial `git commit` in the generated app failed in the bare job container (`unable to auto-detect email address`); the workflow now sets a CI git identity first.
+
+### Lockstep
+
+- validation_hints 8.1.35, inline_forms_installer 8.1.35 (no changes of their own).
+
+## [8.1.34] - 2026-07-06
+
+### Added
+
+- **CI moved to Forgejo Actions** (`.forgejo/workflows/`, plan: `stuff/2026-07-06-forgejo-ci-rubocop-brakeman.md`). `ci.yml` runs the engine suite, RuboCop, and bundler-audit per push on the dev02 runner (shared `papiamentu-ci:ruby-4.0.4-node20` image); `full-gate.yml` (manual + weekly) rebuilds all three gems, generates the example app — whose embedded 150+-test run is the release gate — and runs **Brakeman against the generated app** (report-only until the baseline is triaged). `.github/workflows/` was **deleted**: pushing to GitHub deliberately triggers nothing.
+- **RuboCop** (Rails omakase preset, same recipe as Papiamentu) in the dev bundle, with all 590 pre-existing offenses grandfathered in `.rubocop_todo.yml` (delete entries as files get cleaned; new code is linted). Generated-app territory is excluded (`lib/installer_templates/`, `archived/`, …). `bundle exec rubocop`: 91 files, no offenses.
+
+### Lockstep
+
+- validation_hints 8.1.34 (same CI + RuboCop treatment: 12 files, 22 offenses grandfathered), inline_forms_installer 8.1.34.
+
+## [8.1.33] - 2026-07-06
+
+### Changed
+
+- **README refresh** (docs only; the README ships inside the gem). Tabs sections now describe the vendored `InlineForms::Tabs` instead of the removed `tabs_on_rails` gem; the example-app model list includes `FormElementShowcase`; new sections document the native inputs (post-jQuery UI) and the per-user theme / custom colors / locale features with the host-app opt-in contract (`#inline_forms_theme`, `#inline_forms_color_overrides`).
+
+### Lockstep
+
+- validation_hints 8.1.33, inline_forms_installer 8.1.33 (no code changes in any gem).
+
+## [8.1.32] - 2026-07-06
+
+### Added
+
+- **Theming Pattern 2: per-user color overrides** (completes the `stuff/user-preferences-and-theming.md` baseline of Pattern 1 + 2).
+  - New engine helper `inline_forms_user_color_overrides_style`, rendered in the layouts' `<head>`: when `current_user` responds to `#inline_forms_color_overrides` (a hash of `--if-color-` suffix => `"#rrggbb"`), it emits one scoped inline `<style>` (`body.theme-<name> { --if-color-primary: …; }`) so user colors win over the preset palette while the main CSS stays fully cached. Keys and values are strictly re-validated before interpolation; no style tag is emitted when there are no overrides.
+  - **New Tier 1 form element `:color_field`** — native `<input type="color">` editing a `"#rrggbb"` string column; show renders a color swatch + hex, update normalizes to lowercase and rejects anything that is not a 6-digit hex (stored as `nil`). Registered as `:string` in the generator registry.
+  - Installer: generated user models get `primary_color` / `accent_color` columns with format validations, `#inline_forms_color_overrides`, and two `color_field` rows on the user panel.
+  - Tests: dummy-harness color_field render/round-trip/junk-rejection; example-app tests for the scoped override style, the no-overrides case, and the user-panel rows.
+
+### Lockstep
+
+- validation_hints 8.1.32, inline_forms_installer 8.1.32.
+
+## [8.1.31] - 2026-07-06
+
+### Added
+
+- **Per-user locale.** The user model has always carried a `locale` association (`[:locale, :dropdown]` on the user panel), but nothing read it. Generated apps' `ApplicationController` now wraps every request in `I18n.with_locale(current_user.locale.name)` (`around_action :switch_locale`): unknown/blank names fall back to `I18n.default_locale`, and `with_locale` restores afterwards so nothing leaks across requests. The old commented subdomain-based `set_locale` sample was replaced with an `I18n.with_locale`-based variant.
+- Example-app regression tests (`example_app_user_locale_test.rb`): default `<html lang="en">`, `nl` switching, unknown-name fallback.
+
+### Changed
+
+- **Engine layout `<html lang>` follows `I18n.locale`** (was hardcoded `"en"` in `layouts/inline_forms.html.erb`).
+
+### Fixed
+
+- **`InlineFormsApplicationController` no longer clobbers `I18n.available_locales`.** It hard-assigned `[:en, :nl, :pp]` at class-load time — which in development happens *after* app initializers, silently stomping any `config.i18n.available_locales` the host configured. Hosts that relied on the implicit `[:en, :nl, :pp]` restriction should set it explicitly in `config/application.rb`.
+
+### Lockstep
+
+- validation_hints 8.1.31, inline_forms_installer 8.1.31.
+
+## [8.1.30] - 2026-07-06
+
+### Removed
+
+- **App-specific form elements `:question_list` and `:dnsrecords` archived.** `question_list` hardcoded a host `Question` model with `subquestions` (survey app); `dnsrecords` called host `a_records` / `djbdns_line` APIs (DNS-admin app) and was never even in the generator registry (its helper methods were named `dnsrecords_*`). Neither had any example-app or test coverage, and neither can render outside its original host schema. Models still declaring the symbols raise `InlineForms::ArchivedFormElementError` at boot with restore instructions; source lives under `archived/form_elements/{question_list,dns_records}/` with per-element READMEs.
+
+### Lockstep
+
+- validation_hints 8.1.30, inline_forms_installer 8.1.30.
+
+## [8.1.29] - 2026-07-06
+
+### Added
+
+- **Per-user preset themes (Pattern 1 of `stuff/user-preferences-and-theming.md`), built on the 8.1.24 CSS-variable bridge.**
+  - Engine `_theme.scss` ships three preset palettes — `theme-dark`, `theme-sepia`, `theme-high-contrast` — as `body.<class>` blocks overriding the `--if-color-*` custom properties (`theme-default` is the `:root` palette). Dark also patches input/textarea/trix backgrounds (Foundation compiles those from the light Sass palette); high-contrast underlines links.
+  - Engine layouts emit `<body class="theme-<name>">` via the new `inline_forms_body_theme_class` helper. The host opts in by having `current_user` respond to `#inline_forms_theme` (one of `default|dark|sepia|high-contrast`); anonymous users and non-opted hosts get `theme-default`, and the class name is validated against a safe pattern before interpolation.
+  - Installer: generated user models get an integer `theme` column (default 0), an `INLINE_FORMS_THEMES` map, `#inline_forms_theme`, and a `[:theme, :dropdown_with_values, …]` row on the user panel — so picking a theme is ordinary inline editing, stored on the user record (no localStorage; per the design doc's "Rejected" list).
+  - Example-app regression tests (`example_app_user_theme_test.rb`): default body class, dark/high-contrast switching, and the theme dropdown frame on the user panel.
+
+### Lockstep
+
+- validation_hints 8.1.29, inline_forms_installer 8.1.29.
+
+## [8.1.28] - 2026-07-06
+
+### Added
+
+- **`multi_image_field` joins the FormElementShowcase** as `gallery` (deferred item from the original showcase plan): `mount_uploaders :gallery, ImageUploader` with the filename array JSON-serialized into a `text` column, a seeded one-image gallery on "Full demo", a `Gallery (multiple images)` label, and a new `example_app_showcase_gallery_test.rb` (array show render, `gallery[]` multiple file input, empty-state plus link).
+- Dummy-harness render coverage for `simple_file_field` and `pdf_link` (`test/integration/legacy_elements_test.rb`) — first tests these two legacy elements have ever had.
+
+### Fixed
+
+- **`multi_image_field_show` crashed the moment the column actually held images.** A `mount_uploaders` (plural) reader returns an *array* of uploaders; the old code called `.url` on that array (`NoMethodError`). It now renders every image in the array (using the `palm` thumb version when defined) and still accepts a bare single uploader.
+- **`multi_image_field_edit` lost all but the last chosen file.** The input was named `gallery` (no `[]`), so Rack kept only the final part of a multiple-file submission; it now submits `gallery[]` and the update assigns the full array (ignoring blank submissions instead of clearing).
+- **`attribute_values`' error path raised the wrong error.** `raise t("fatal.no_values_defined_in", @Klass, attribute)` passed positional args to Rails' `translate` (key + kwargs API) and died with `ArgumentError (given 3, expected 1)` instead of the intended message. Now raises a plain descriptive RuntimeError naming the model and attribute.
+
+### Lockstep
+
+- validation_hints 8.1.28, inline_forms_installer 8.1.28.
+
+## [8.1.27] - 2026-07-06
+
+### Added
+
+- **In-repo integration test harness (`test/dummy` + `test/integration/`).** A minimal host app (in-memory SQLite, will_paginate + paper_trail + turbo-rails from the dev bundle, no Devise/CanCanCan/Sprockets/ActionText) boots the engine so `InlineFormsController`, the Turbo-frame views, and the form-element helpers can be exercised in ~1.5 s via `bundle exec rake test` — previously every such regression needed the full release gate (build gems → `inline_forms create MyApp --example` → app test suite, minutes). 19 new tests cover list/search/show/edit/update, the 8.1.19 failed-save behavior, destroy + undo, 8.1.13 destroy-version targeting, 8.1.17 revert idempotency, the versions panel, and every 8.1.25/8.1.26 native input. The example-app gate remains the release check.
+- **GitHub Actions workflow** (`.github/workflows/ci.yml`): engine tests + `bundler-audit` (checks out the `validation_hints` sibling for the path dependency).
+
+### Fixed
+
+Latent engine bugs on hosts without the full Devise+CanCanCan stack, found by the new harness (generated apps always bundle that stack, so they never hit these):
+
+- `_show.html.erb` called `can?(:list_versions, …)` and `link_to_versions_list` called `can?` without the `cancan_disabled?` guard every other call site uses — `NoMethodError` when CanCanCan is absent.
+- `destroy` and `revert` called `current_user.role?(:superadmin)` unguarded — `NoMethodError` on `nil.role?` for hosts without Devise/roles (or a signed-out replay). Both now use `destroy_permitted?`: superadmin-only when the host's user responds to `role?` (generated-app behavior unchanged), no extra gate otherwise (CanCan's `load_and_authorize_resource` still applies where enabled).
+- `slider_with_values` show/edit crashed with `NoMethodError` on `nil[1]` when the stored value has no entry in the values hash (e.g. `1..5` scale with the column still `nil`/`0` — exactly the state a fresh row is in); it now falls back to the bare number.
+- The engine's asset-precompile initializer assumed a Sprockets-style `config.assets`; it now skips hosts without one.
+
+### Lockstep
+
+- validation_hints 8.1.27, inline_forms_installer 8.1.27.
+
+## [8.1.26] - 2026-07-06
+
+### Changed
+
+- **jQuery UI is fully removed** (follow-up to 8.1.25's native pickers; jQuery itself remains only because Foundation 6's JS requires it):
+  - **`dropdown_with_other`** now renders a native combobox — a text input backed by a `<datalist>` of the existing records — instead of a hidden `<select>` plus the jQuery UI autocomplete "custom.combobox" widget and its ~100-line inline `<script>` (the last inline script emitted by any form element). Typing a listed name picks that record; any other text becomes the free-form `<attribute>_other` value. The submitted field is unchanged (`_<model>[<attribute>_other]`) and `dropdown_with_other_update` is behaviorally identical (it never read the posted foreign key; it re-derives it by name lookup). Two stray `puts` debug lines removed from the update path.
+  - **`slider_with_values`** now renders a native `<input type="range">` on edit (labels ride in `data-slider-values`; an `<output>` shows the current label, kept in sync by `initSliderValueLabels` in `inline_forms.js`) and a non-interactive `<progress>` bar on show (a disabled range input would swallow the click-to-edit). No more jQuery UI slider or per-field scripts; the old hardcoded `max: 5` on edit now derives from the values hash.
+  - **Removed from the engine:** `//= require jquery.ui.all`, `//= require autocomplete-rails`, the vendored jQuery UI SCSS (`app/assets/stylesheets/jquery_ui/`, sunny theme) and theme images (`app/assets/images/jquery-ui/`, ~70 files), the `inline_forms.jquery_ui_stylesheet_path` initializer, and the dead `.custom-combobox` CSS.
+  - **Removed from generated Gemfiles:** `jquery-ui-rails`, `rails-jquery-autocomplete`.
+
+### Lockstep
+
+- validation_hints 8.1.26, inline_forms_installer 8.1.26.
+
+## [8.1.25] - 2026-07-06
+
+### Changed
+
+- **Date/time/month pickers are native HTML inputs; jQuery UI datepicker and the jquery.timepicker plugin are gone.**
+  - `date_select` edit renders `<input type="date">` (was `text_field_tag class="datepicker"` + jQuery UI datepicker). The browser shows a locale-formatted picker with month/year dropdowns built in; the wire format is ISO 8601 (`YYYY-MM-DD`), which Active Record casts directly — sturdier than the old `dd-mm-yy` text parsing.
+  - `time_select` edit renders `<input type="time">` (was `class="timepicker"` + jquery.timepicker); submits 24h `HH:MM`. Value now pre-fills as `09:15` instead of `" 9:15am"`; the show format (`%l:%M%P`) is unchanged.
+  - `month_year_picker` edit renders `<input type="month">` (was the jQuery UI `MM yy` datepicker hack with the onClose month/year scrape); submits `YYYY-MM`. `month_year_picker_update` parses `YYYY-MM` via `Date.strptime` (Ruby's `Date.parse` raises on it) and still accepts the legacy `"September 2026"` display format as a fallback.
+  - Edit-input CSS classes renamed to match the form element names (`date_select`, `time_select`, `month_year_picker`); the old `datepicker`/`timepicker`/`datepicker-month-year` hooks are gone so host-app JS that still binds jQuery pickers to them will not double-bind against the native inputs.
+  - `initInlineFormsWidgets` now wires only validation-hint tooltips; `$.datepicker.setDefaults` and all picker init removed from `inline_forms.js`. `jquery.ui.all` stays in the bundle solely for the autocomplete widget (`dropdown_with_other`) and `slider_with_values`.
+  - Installer: **`jquery-timepicker-rails` removed** from generated Gemfiles.
+
+### Added
+
+- Example-app regression tests: native `type="date"`/`type="time"`/`type="month"` edits with ISO value prefill, plus round-trips for a native `HH:MM` time submission, a native `YYYY-MM` month submission, the legacy `"November 2027"` month fallback, and an ISO date submission.
+
+### Lockstep
+
+- validation_hints 8.1.25, inline_forms_installer 8.1.25.
+
+## [8.1.24] - 2026-07-06
+
+### Added
+
+- **Theme bridge: the admin-chrome palette is now exposed as CSS custom properties** (new `_theme.scss`, emitted into both `inline_forms.css` and `devise.css`). Every hardcoded chrome color in `inline_forms.scss` / `devise.scss` (dark-red `#A3381E`, brick `#B94C32`, gold `#E1C150`, header band `rgb(239,202,75)`, zebra rows `#FBE38E`/`#FBEEC1`, input backgrounds, flash/error/success colors) moved to `var(--if-color-*)` with identical build-time values — the rendered UI is unchanged until a host app overrides a variable (e.g. `:root { --if-color-primary: #2563eb; }` or a `body.theme-dark` block). This is the prerequisite bridging layer for per-user theming (`stuff/user-preferences-and-theming.md`); Foundation's own components still compile from Sass settings.
+- Body background/text and anchor color are bridged too (`--if-color-body-bg`, `--if-color-body-text`, `--if-color-anchor`), sourced from Foundation's `$body-background` / `$body-font-color` / `$anchor-color` at build time.
+
+### Changed
+
+- **Sass module-system status made explicit.** `foundation_icons` now loads via `@use`; `lighten()` calls replaced with `color.adjust` (kills the Dart Sass color-functions deprecation). The remaining `@import`s cannot convert while the stack sits on foundation-rails 6.9, whose Sass is `@import`-only and feeds globals (`$body-background`, `rem-calc`, …) into our overrides — documented in `inline_forms.scss` and `stuff/improvement-plan.md` §1. Remaining deprecation warnings (import/global-builtin/if-function) originate inside foundation-rails itself.
+
+### Lockstep
+
+- validation_hints 8.1.24, inline_forms_installer 8.1.24 (no changes of their own).
+
+## [8.1.23] - 2026-07-06
+
+### Changed
+
+- **`tabs_on_rails` is no longer a dependency; tabs support is vendored.** The gem (last released 2017, unmaintained) provided four things inline_forms used: the controller `set_tab` DSL, the `current_tab` / `current_tab?` helpers, the `tabs_tag` view helper, and the `TabsBuilder` base class that `InlineForms::TurboTabsBuilder` subclasses. All four are now ported into the engine as `InlineForms::Tabs` (`lib/inline_forms/tabs.rb`, API-compatible; MIT attribution retained) and included into `ActionController::Base` by an engine initializer. It was also an *undeclared* dependency: the engine `require`d `tabs_on_rails` at load time but never listed it in the gemspec — only the installer-written app Gemfile made that work. The installer no longer writes `gem 'tabs_on_rails'`; apps generated before 8.1.23 keep working because the initializer skips the vendored controller include when the gem's own `TabsOnRails::ActionController` is present.
+
+### Added
+
+- **Unit tests** (`test/tabs_test.rb`) for the vendored default builder (active `current` class, `<span>` for the active tab), custom `active_class`, the `TurboTabsBuilder` contract (threads `link_options:`/`data-turbo-frame` onto the anchor, `aria-current`/`aria-selected` state, href-less active tab), and the `set_tab`/`current_tab?` namespace semantics.
+
+### Lockstep
+
+- validation_hints 8.1.23, inline_forms_installer 8.1.23.
+
+## [8.1.22] - 2026-07-06
+
+### Changed
+
+- **Trix is vendored; unpkg CDN tags removed.** All layouts loaded Trix from `https://unpkg.com/trix@1.3.1/dist/trix.{css,js}` — a 2020-era version and a hard runtime dependency on a third-party CDN. Trix **2.1.19** now ships in the engine (`vendor/assets/javascripts/trix.min.js`, `vendor/assets/stylesheets/trix.css`) and is served through Sprockets (`javascript_include_tag "trix.min"` / `stylesheet_link_tag "trix"`). The Trix 1-era manual re-init in `initInlineFormsWidgets` (`new Trix.Editor(el)`) was dropped: Trix 2's `<trix-editor>` is a custom element the browser upgrades automatically after Turbo frame swaps.
+- **Open Sans is self-hosted; no more `http://fonts.googleapis.com`.** `inline_forms.scss` and `devise.scss` imported Open Sans over plain HTTP at runtime. The latin 400/400-italic woff2 files (v44) now live in `app/assets/fonts/`, declared in a new Sprockets-served `inline_forms_fonts.css.erb` (ERB so `asset_path` emits digested URLs) linked from all three layouts.
+- **Installer Gemfile: last floating gems pinned** — `cancancan '~> 3.6'`, `will_paginate '~> 4.0'` (the versions generated apps already resolve).
+
+### Fixed
+
+- **Foundation Icons `@font-face` 404.** The `@font-face` lived in the Dart Sass-built `inline_forms.css`, which is served from `/assets/inline_forms/…`; its relative `url("foundation-icons.woff")` therefore resolved to `/assets/inline_forms/foundation-icons.woff` — a 404 (the fonts' logical paths are flat: `/assets/foundation-icons.woff`). Icon glyphs (`fi-*`) silently fell back to the text font. The declaration moved into `inline_forms_fonts.css.erb` with proper `asset_path` URLs; the fonts (and Open Sans) are added to the precompile list.
+
+### Lockstep
+
+- validation_hints 8.1.22, inline_forms_installer 8.1.22 (no changes of their own).
+
 ## [8.1.21] - 2026-06-03
 
 ### Removed

data/CLAUDE.md

@@ -0,0 +1,68 @@
+# CLAUDE.md — inline_forms
+
+Instructions for any work in the inline_forms repo (`/home/code/inline_forms`).
+These apply to all work here and take precedence over global defaults where they
+conflict. Consolidated from the former `stuff/prompt/workflow.md` and
+`stuff/prompt/test-the-example-app.md`.
+
+## Workflow after any significant change
+
+1. Run the full example-app test (see **Testing the example app** below). Keep
+   improving until all tests succeed.
+2. Bump the **patch** version. Stay in the **8.1** line until further notice.
+   Never bump the minor version — even for big or breaking changes.
+   - Change the version in **all four gems** so they stay in lockstep, always,
+     even if nothing changed in some of them:
+     `validation_hints`, `inline_forms`, `inline_forms_installer`, and
+     `inline_forms_schema_edit` (in this repo under `inline_forms_schema_edit/`).
+3. Update the Changelog of all four gems.
+4. Commit everything.
+5. After committing, push to the `forgejo` remote
+   (`ssh://forgejo@dev02:2222/ace/...`) in **both repos** (inline_forms and
+   validation_hints) so every commit runs through CI (Forgejo Actions on dev02).
+   - Check the run at http://dev02:3300/ace/inline_forms/actions and fix
+     failures.
+6. Never push to `origin` (GitHub). Only Ace pushes there, and GitHub must not
+   run anything (no `.github/workflows`).
+
+## Testing the example app
+
+Goal: build the current gem, install it into `/home/code/testInline`, recreate
+`MyApp` from scratch using `--example`, and verify it with Rails tests.
+
+Do all steps end-to-end without asking for confirmation unless a command fails.
+
+### Steps
+
+1. In `/home/code/inline_forms`:
+   - Ensure the latest code is used.
+   - Run: `rvm use .`
+   - Build gems:
+     `gem build inline_forms.gemspec && gem build inline_forms_installer.gemspec && (cd inline_forms_schema_edit && gem build inline_forms_schema_edit.gemspec)`
+   - Confirm the built file names/versions
+     (`inline_forms-<version>.gem`, `inline_forms_installer-<version>.gem`,
+     `inline_forms_schema_edit/inline_forms_schema_edit-<version>.gem`).
+
+2. In `/home/code/testInline`:
+   - Remove the old app if present: `/home/code/testInline/MyApp`
+   - Run: `rvm use .`
+   - Install the freshly built gems from
+     `/home/code/inline_forms/inline_forms-<version>.gem`,
+     `inline_forms_installer-<version>.gem`, and
+     `inline_forms_schema_edit/inline_forms_schema_edit-<version>.gem`.
+
+3. Still in `/home/code/testInline`:
+   - Generate a fresh example app:
+     `inline_forms create MyApp -d sqlite --example`
+
+4. In `/home/code/testInline/MyApp`:
+   - Run: `rvm use .`
+   - Run verification: `rails test`
+
+### Output requirements
+
+- Briefly report each phase result (build, install, app generation, test run).
+- Include the exact commands run.
+- Include the test summary (runs/assertions/failures/errors/skips).
+- If anything fails, stop at the failing step and include the exact error and
+  the next corrective command you recommend.

data/Gemfile

@@ -5,5 +5,21 @@ gemspec name: "inline_forms"
 # Local sibling until validation_hints 8.0.0 is on RubyGems (maintainer dev only).
 gem "validation_hints", path: "../validation_hints"
 
-# Engine loads TurboTabsBuilder at require time (used in generated apps).
-gem "tabs_on_rails", "~> 3.0"
+# test/dummy host-app stand-ins: the engine expects the host to supply these
+# (generated apps get them from the installer Gemfile). Used only by the
+# integration tests under test/integration/.
+group :test do
+  gem "sqlite3", ">= 2.1"
+  gem "will_paginate", "~> 4.0"
+  gem "paper_trail", "~> 17.0"
+  gem "turbo-rails"
+  # The schema-GUI engine gem (same repo, own gemspec). Test group so the
+  # dummy app's `Bundler.require(*Rails.groups)` loads it and the engine's
+  # schema_edit integration tests exercise the extracted controller/views.
+  gem "inline_forms_schema_edit", path: "inline_forms_schema_edit"
+end
+
+group :development, :test do
+  # Rails omakase style; offenses grandfathered in .rubocop_todo.yml.
+  gem "rubocop-rails-omakase", require: false
+end

data/README.rdoc

@@ -46,17 +46,18 @@ The installer emits +devise_for :users, class_name: "Member", path: "members"+ (
 
 Then point your browser to http://localhost:3000/apartments and log in with admin@example.com / admin999. The example also adds integration and model tests; run +bundle exec rails test+ in +MyApp+, then start the server with +bundle exec rails s+ when you want the UI.
 
-The example app now ships three models:
+The example app ships four demo models (plus the +User+ / +Role+ / +Locale+ auth trio):
 
 * +Apartment+ — top-level resource at +/apartments+ (root).
 * +Photo+ — nested under Apartment (+has_many+ / +belongs_to+).
 * +Owner+ — top-level resource at +/owners+. An Owner +has_many+ Apartments; an Apartment +belongs_to+ a single (optional) Owner. The Owner detail panel at +/owners/:id+ ships two sub-tabs, +NAW+ (name, birthdate, address, city, country) and +Apartments+ (name + the owned-apartments checklist). +name+ deliberately appears on both tabs.
+* +FormElementShowcase+ — one row per kept Tier 1 form element (numbers, dates, choices, scales, uploads incl. a +multi_image_field+ gallery, rich text, HABTM checklist), seeded as "Full demo" / "Empty demo" so every show/edit branch renders and is regression-tested.
 
 On the +Apartments+ tab, +Owner#apartments+ is rendered as a +:check_list+ of *existing* apartments rather than the default +:associated+ "build new nested row" panel, so the user re-assigns the +apartments.owner_id+ FK by ticking checkboxes (using Rails' built-in +apartment_ids=+ setter on +has_many+).
 
-The tabs are wired with +tabs_on_rails+ (+set_tab+ / +current_tab?+) and +InlineForms::TurboTabsBuilder+, a small subclass of +TabsOnRails::Tabs::TabsBuilder+ that threads HTML options through to the tab's +<a>+ (upstream 3.0 can only annotate the +<li>+). Each tab link carries +data-turbo-frame+ targeting the surrounding row +<turbo-frame>+, so switching tabs is a single Turbo partial swap — no UJS, no +data-remote+. The active tab is emitted as an hrefless +<a aria-current="page" aria-selected="true">+ inside +<li class="tabs-title is-active">+ so Foundation 6's tabs CSS (+.tabs-title.is-active > a+ / +[aria-selected='true']+) styles it without needing custom overrides.
+The tabs are wired with +InlineForms::Tabs+ (+set_tab+ / +current_tab?+ / +tabs_tag+ — vendored into the engine since 8.1.23, replacing the unmaintained +tabs_on_rails+ gem with the same API) and +InlineForms::TurboTabsBuilder+, a small subclass of +InlineForms::Tabs::TabsBuilder+ that threads HTML options through to the tab's +<a>+ (the classic builder can only annotate the +<li>+). Each tab link carries +data-turbo-frame+ targeting the surrounding row +<turbo-frame>+, so switching tabs is a single Turbo partial swap — no UJS, no +data-remote+. The active tab is emitted as an hrefless +<a aria-current="page" aria-selected="true">+ inside +<li class="tabs-title is-active">+ so Foundation 6's tabs CSS (+.tabs-title.is-active > a+ / +[aria-selected='true']+) styles it without needing custom overrides.
 
-The example app also seeds three apartments (+Apt 1+, +Apt 2+, +Apt 3+, each with three CC0 placeholder photos from the gem's +pics/+ folder) and three owners — +Maria Martinez+ (owns +Apt 1+ + +Apt 2+), +Jean-Pierre Dupont+ (owns +Apt 3+), and +Akira Tanaka+ (owns none) — so the +has_many+ panel has at least one zero / one / many case to click through.
+The example app also seeds three apartments (+Apt 1+, +Apt 2+, +Apt 3+, each with three CC0 placeholder photos shipped with the installer — labeled pastel PNGs like "Apt 1 / Living Room"; override with your own folder via +INLINE_FORMS_SEED_PICS+) and three owners — +Maria Martinez+ (owns +Apt 1+ + +Apt 2+), +Jean-Pierre Dupont+ (owns +Apt 3+), and +Akira Tanaka+ (owns none) — so the +has_many+ panel has at least one zero / one / many case to click through.
 
 You can install the example application manually if you like:
 
@@ -78,9 +79,9 @@ Then point your browser to http://localhost:3000/apartments and log in with admi
 
 == Per-resource Turbo tabs (+InlineForms::TurboTabsBuilder+)
 
-Upstream +tabs_on_rails 3.0+ (+TabsOnRails::Tabs::TabsBuilder#tab_for(tab, name, url_options, item_options = {})+) only applies the 4th argument to the +<li>+ wrapper; nothing is forwarded to the +<a>+. That used to be fine under Rails UJS (every link with +data-remote="true"+ was hijacked into an XHR regardless), but Turbo needs the data attribute on the +<a>+ itself (typically +data-turbo-frame="..."+).
+The classic builder API (+tab_for(tab, name, url_options, item_options = {})+, inherited from the retired +tabs_on_rails+ gem and preserved verbatim in the vendored +InlineForms::Tabs::TabsBuilder+) only applies the 4th argument to the +<li>+ wrapper; nothing is forwarded to the +<a>+. That used to be fine under Rails UJS (every link with +data-remote="true"+ was hijacked into an XHR regardless), but Turbo needs the data attribute on the +<a>+ itself (typically +data-turbo-frame="..."+).
 
-The old +acesuares/tabs_on_rails+ fork (+update_remote_before_action+) patched +tab_for+ to thread html options into +link_to+. That fork was retired in 7.13.5; +InlineForms::TurboTabsBuilder+ is its Turbo-shaped replacement. It accepts a new +:link_options+ key on the per-tab call and forwards it to +link_to+:
+The old +acesuares/tabs_on_rails+ fork (+update_remote_before_action+) patched +tab_for+ to thread html options into +link_to+. That fork was retired in 7.13.5 (and the gem itself was vendored away in 8.1.23); +InlineForms::TurboTabsBuilder+ is its Turbo-shaped replacement. It accepts a new +:link_options+ key on the per-tab call and forwards it to +link_to+:
 
  <%= tabs_tag builder: InlineForms::TurboTabsBuilder,
               active_class: "is-active",
@@ -101,7 +102,7 @@ Active-tab highlighting is unchanged from upstream (still driven by +set_tab :fo
 
 === Where to put the +tabs_tag+ block (four patterns)
 
-+tabs_on_rails+ and +InlineForms::TurboTabsBuilder+ don't care where you call +tabs_tag+ — they just produce the +<ul class="tabs">+ wherever you put the block. The example app's split into +show_with_tabs.html.erb+ + +_owner_tabs.html.erb+ is a stylistic choice; below are the four common shapes, from most-inline to most-decoupled. Pick whichever fits your app:
++InlineForms::Tabs+ and +InlineForms::TurboTabsBuilder+ don't care where you call +tabs_tag+ — they just produce the +<ul class="tabs">+ wherever you put the block. The example app's split into +show_with_tabs.html.erb+ + +_owner_tabs.html.erb+ is a stylistic choice; below are the four common shapes, from most-inline to most-decoupled. Pick whichever fits your app:
 
 1. *Inlined in the show view* — drop the +tabs_tag+ block straight into +app/views/<resource>/show_with_tabs.html.erb+ (or similar) and skip the partial entirely.
 
@@ -282,6 +283,22 @@ For long text fields, use +:plain_text+ for a plain textarea backed by a DB +tex
 
 Note: generated apps also depend on ActiveStorage transitively because the +:rich_text+ form element uses ActionText (+active_storage:install+ runs during +inline_forms create+). Image uploads still go through CarrierWave; ActiveStorage is only there to back ActionText embeds.
 
+== Native inputs (no jQuery UI)
+
+Since 8.1.25/8.1.26 the date/time widgets are native HTML inputs — +:date_select+ renders +<input type="date">+, +:time_select+ +<input type="time">+, +:month_year_picker+ +<input type="month">+, +:slider_with_values+ +<input type="range">+, +:dropdown_with_other+ an +<input list>+ + +<datalist>+ combobox, and the new +:color_field+ (8.1.32) +<input type="color">+. jQuery UI, its themes and the +jquery-ui-rails+ / +rails-jquery-autocomplete+ / +jquery-timepicker-rails+ gems are gone; jQuery itself remains only because Foundation 6's JS requires it.
+
+== Per-user themes, colors and locale
+
+Generated apps let each user pick, on their own user panel:
+
+* a *preset theme* (+default+ / +dark+ / +sepia+ / +high-contrast+): an integer +theme+ column mapped to a +theme-<name>+ body class; palettes are CSS custom properties (+--if-color-*+) in the engine's +_theme.scss+ (8.1.29);
+* *custom colors* (+primary_color+ / +accent_color+, edited with +:color_field+): rendered as one scoped inline +<style>+ of +--if-color-*+ overrides, so the main stylesheet stays fully cacheable (8.1.32);
+* a *locale*: the existing +locale+ association now drives +I18n.with_locale+ per request via +around_action :switch_locale+ (8.1.31).
+
+Host apps that are not generated by the installer opt in by making +current_user+ respond to +inline_forms_theme+ (String) and/or +inline_forms_color_overrides+ (Hash of +--if-color-+ suffix => +"#rrggbb"+). Everything is validated before interpolation. To re-theme an app globally instead, override the variables in your own CSS:
+
+ :root { --if-color-primary: #2563eb; }
+
 = Build a vagrant virtualbox box for easier development
 
 Go ahead and unzip lib/vagrant/vagrantbox-inline_forms.zip. Enter the created directory with

data/Rakefile

@@ -7,11 +7,18 @@ namespace :installer do
   Bundler::GemHelper.install_tasks name: "inline_forms_installer"
 end
 
+namespace :schema_edit do
+  # The schema-GUI gem lives in its own subdirectory (own gemspec, own pkg/).
+  Bundler::GemHelper.install_tasks dir: File.expand_path("inline_forms_schema_edit", __dir__),
+                                   name: "inline_forms_schema_edit"
+end
+
 def inline_forms_pkg_gems
-  pkg = File.expand_path("pkg", __dir__)
   version = InlineForms::VERSION
-  %w[inline_forms inline_forms_installer].map do |name|
-    path = File.join(pkg, "#{name}-#{version}.gem")
+  { "inline_forms" => "pkg",
+    "inline_forms_installer" => "pkg",
+    "inline_forms_schema_edit" => "inline_forms_schema_edit/pkg" }.map do |name, pkg|
+    path = File.expand_path(File.join(pkg, "#{name}-#{version}.gem"), __dir__)
     raise "Missing #{path}. Run rake build:all first." unless File.file?(path)
     path
   end
@@ -25,11 +32,11 @@ def validation_hints_pkg_gem
   ].find { |path| File.file?(path) }
 end
 
-desc "Build both inline_forms and inline_forms_installer into pkg/"
-task "build:all" => ["build", "installer:build"]
+desc "Build inline_forms, inline_forms_installer and inline_forms_schema_edit"
+task "build:all" => [ "build", "installer:build", "schema_edit:build" ]
 
 desc "Install freshly built gems from pkg/ into the current gemset (required before inline_forms create)"
-task "install:local" => ["build:all"] do
+task "install:local" => [ "build:all" ] do
   gems = inline_forms_pkg_gems
   vh = validation_hints_pkg_gem
   gems << vh if vh
@@ -38,16 +45,50 @@ task "install:local" => ["build:all"] do
   puts "Verify: inline_forms --version 2>/dev/null || gem which inline_forms_installer"
 end
 
-# Release inline_forms + inline_forms_installer only (build, git tag/push, RubyGems push).
-# Does not run inline_forms create, MyApp, or tests. validation_hints is a separate
-# repo: cd ../validation_hints && rake release (same version number).
-desc "Release inline_forms and inline_forms_installer to RubyGems (no app generation)"
+# Release inline_forms + inline_forms_installer + inline_forms_schema_edit
+# (build, git tag/push, RubyGems push). Does not run inline_forms create,
+# MyApp, or tests. validation_hints is a separate repo:
+# cd ../validation_hints && rake release (same version number).
+# Release git-push ALWAYS targets `origin` (GitHub) only.
+#
+# Do NOT use Bundler's stock `release:source_control_push`: it pushes to the
+# CURRENT BRANCH's tracking remote (`git config branch.<branch>.remote`).
+# Feature branches in this repo track `forgejo` (dev02) because that's where
+# CI runs, so a release cut from a feature branch would push the release commit
+# and version tag to forgejo instead of GitHub. `origin` is the only place
+# release commits/tags belong; `forgejo` is CI-only. This task is also
+# idempotent on the tag, so a re-run after a failed push still lands the tag on
+# origin (Bundler's version skips entirely once the tag exists locally).
+# Also override the bare `release` task (from install_tasks above) so a stray
+# `rake release` can't push to a feature branch's forgejo tracking remote
+# either. The intended entry point is `release:all`, but this closes the
+# footgun on both.
+Rake::Task["release"].clear if Rake::Task.task_defined?("release")
+desc "Build inline_forms, tag, push to origin (GitHub) and push the gem to RubyGems"
+task "release" => [ "build", "release:guard_clean",
+                    "release:push_to_origin", "release:rubygem_push" ]
+
+desc "Tag the release and push the commit + tag to origin (GitHub) only"
+task "release:push_to_origin" do
+  version = InlineForms::VERSION
+  tag     = "v#{version}"
+  branch  = `git rev-parse --abbrev-ref HEAD`.strip
+  unless system("git", "rev-parse", "-q", "--verify", "refs/tags/#{tag}",
+                out: File::NULL, err: File::NULL)
+    sh "git", "tag", tag
+  end
+  sh "git", "push", "origin", "refs/heads/#{branch}"
+  sh "git", "push", "origin", "refs/tags/#{tag}"
+end
+
+desc "Release inline_forms, inline_forms_installer and inline_forms_schema_edit to RubyGems (no app generation)"
 task "release:all" => [
   "build:all",
   "release:guard_clean",
-  "release:source_control_push",
+  "release:push_to_origin",
   "release:rubygem_push",
-  "installer:release:rubygem_push"
+  "installer:release:rubygem_push",
+  "schema_edit:release:rubygem_push"
 ]
 
 require "rake/testtask"