inline_forms 8.1.19 → 8.1.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fb00bfea980d5563c8c6efdccfec5f570bf143487d0d25ddb790d38e8bb1e5a6
-  data.tar.gz: d843e74f5c4677993a8bc82454adb48db73477f3182dffe56dd0b9a389263258
+  metadata.gz: dcda1708a5210f445c14024312d495fe28821927ccc6fb816f410110c47190e0
+  data.tar.gz: 7d47792cc13d0423639152ee2005287b369f4e1cf542e4195e4b92b027e5bf93
 SHA512:
-  metadata.gz: b3864e91f61f48eeb3d6914c2f5651dec600ab4de3aeff91ee3bcbc4fa685603cfce59429d4baa7169d761d9e052891e03b8f6b070e693929a7c2638ecd1b70f
-  data.tar.gz: d279266cd6030c0464f2db416b4d50da554b539fc8382e77e78c75633d159057b42b7c7d81e671bfe884f598b1180816fca4af79d4e7d69bd6aa0e899ec41794
+  metadata.gz: 7ba52c31b810465c24b2c5e4d63cee7aaca6e424a1a436ead90d2c7e90a4a13fcfb9c67fbd9cb3f04459c5be9ec4b5604088491fdc8b92f909df32f973c6bc37
+  data.tar.gz: d96895cd2923769b62a597c5ad7bf26446180cfd8b2d2bfafa17c6c48cfa2f6f564063cd1b15e2340a94026c6d360db423f14244389d3d60b831c9a9d4fdc258

data/CHANGELOG.md

@@ -4,6 +4,26 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [8.1.21] - 2026-06-03
+
+### Removed
+
+- **CKEditor-era form elements `:ckeditor` and `:text_area_without_ckeditor`.** These were legacy aliases (delegating to `:rich_text` and `:plain_text` respectively) kept since CKEditor was dropped in 7.3.0. Models still declaring either symbol now raise `InlineForms::ArchivedFormElementError` at boot. Migrate to `:rich_text` (ActionText) or `:plain_text` / `:plain_text_area`. Source lives under `archived/form_elements/ckeditor/`.
+
+## [8.1.20] - 2026-05-29
+
+### Fixed
+
+- **`price` and `amount` showcase labels now render a non-empty validation-hint tooltip, like `count`.** On the `FormElementShowcase` show panel the `price` (`decimal_field`, bare `validates :price, numericality: true`) and `amount` (`money_field`, money-rails `monetize :amount_cents`) labels rendered the `has-tip` trigger but an **empty** `validation-hints-source` div, so hovering showed nothing. The root cause was a dead-code bug in the companion **validation_hints 8.1.20** gem: a bare `numericality: true` emitted zero hint messages (the `numericality.must_be_a_number` base key was computed but then skipped). With validation_hints fixed, `price` now shows `["must be a number"]`, and money-rails' `MoneyValidator` on `:amount` now maps to a new `"must be a valid amount"` hint. `count` is unchanged behaviorally but now also lists `"must be a number"` ahead of `"must be an integer"`; `latitude`/`longitude` range hints are likewise prefixed with `"must be a number"`.
+
+### Changed
+
+- **`decimal_field` / `money_field` edit inputs deliberately remain `text_field_tag` (not `number_field_tag`).** `integer_field_edit` uses `number_field_tag` (`<input type="number">`, which adds browser-native validation popups on bad input), but switching `decimal_field`/`money_field` to a numeric input is unsafe: a strict `type="number"` rejects valid fixed-point decimals rendered via `BigDecimal#to_s("F")` and the money-rails currency string forms (`"99.95"`, grouped/symbol input). Cross-field consistency for malformed input is instead provided by the server-side validation hint (label tooltip) + the 8.1.19 "edit stays open on a failed save" behavior, which is retained.
+
+### Added
+
+- **Regression test:** `example_app_showcase_validation_hints_test.rb` GETs the `FormElementShowcase` "Hints demo" show panel and asserts the hidden `validation-hints-source` div for `count`, `price`, and `amount` each contains a populated `<ul class="validation-hints-list">` (e.g. `"must be a number"` for `price`, `"must be a valid amount"` for `amount`) — i.e. not the empty source div the pre-8.1.20 bug produced.
+
 ## [8.1.19] - 2026-05-28
 
 ### Fixed

data/archived/README.md

@@ -11,6 +11,7 @@ This directory is the **versioned archive** for inline_forms capabilities that a
 | `:kansen_slider` | **Archived** | **7.6.0** | [`form_elements/kansen_slider/`](form_elements/kansen_slider/) |
 | `:tree`, `:move` | **Archived** | **7.7.0** | [`form_elements/tree/`](form_elements/tree/) — host `#children`, `#hash_tree_to_collection`, `#add_child` |
 | `:absence_list` | **Removed** (source not in repo) | **6.3.0** | See [CHANGELOG](../CHANGELOG.md#630---2026-05-03); vendor from git history or app copy |
+| `:ckeditor`, `:text_area_without_ckeditor` | **Archived** | **8.1.21** | [`form_elements/ckeditor/`](form_elements/ckeditor/) — use `:rich_text` or `:plain_text` / `:plain_text_area` |
 
 Programmatic registry: `InlineForms::ARCHIVED_FORM_ELEMENTS` in `lib/inline_forms.rb` (boot-time check if a model still declares an archived symbol).
 

data/archived/form_elements/ckeditor/README.md

@@ -0,0 +1,26 @@
+# CKEditor-era form elements (archived)
+
+**Archived in gem version:** 8.1.21  
+**Reason:** CKEditor was removed in 7.3.0; these symbols were thin legacy aliases kept for backward compatibility.
+
+| Symbol | Was | Use instead |
+|--------|-----|-------------|
+| `:ckeditor` | Delegated to `:rich_text` | `:rich_text` (ActionText / Trix) |
+| `:text_area_without_ckeditor` | Delegated to `:plain_text` | `:plain_text` or `:plain_text_area` |
+
+## Restore
+
+Copy helpers back into the gem:
+
+```bash
+cp archived/form_elements/ckeditor/lib/inline_forms/form_elements/ckeditor_helper.rb \
+   lib/inline_forms/form_elements/
+cp archived/form_elements/ckeditor/lib/inline_forms/form_elements/text_area_without_ckeditor_helper.rb \
+   lib/inline_forms/form_elements/
+```
+
+Re-add registry entries in `lib/inline_forms/form_element_registry.rb` and remove the symbols from `InlineForms::ARCHIVED_FORM_ELEMENTS`.
+
+## Turbo
+
+No special Turbo concerns; these were delegators to `:rich_text` and `:plain_text`.

data/lib/inline_forms/archived_form_elements.rb

@@ -45,6 +45,16 @@ module InlineForms
       archive_path: nil,
       summary: "Project-specific absence list UI; removed without a copy in this repo (see CHANGELOG 6.3.0).",
     },
+    ckeditor: {
+      archived_in_version: "8.1.21",
+      archive_path: "archived/form_elements/ckeditor",
+      summary: "Legacy CKEditor form element; use :rich_text (ActionText) instead.",
+    },
+    text_area_without_ckeditor: {
+      archived_in_version: "8.1.21",
+      archive_path: "archived/form_elements/ckeditor",
+      summary: "Legacy plain-text alias; use :plain_text or :plain_text_area instead.",
+    },
   }.freeze
 
   def self.validate_no_archived_form_elements_for!(klass)

data/lib/inline_forms/form_element_registry.rb

@@ -6,7 +6,6 @@ module InlineForms
       :audio_field => :string,
       :check_box => :boolean,
       :check_list => :no_migration,
-      :ckeditor => :text,
       :date_select => :date,
       :decimal_field => :decimal,
       :devise_password_field => :string,
@@ -34,7 +33,6 @@ module InlineForms
       :simple_file_field => :string,
       :slider_with_values => :integer,
       :text_area => :text,
-      :text_area_without_ckeditor => :text,
       :text_field => :string,
       :time_select => :time,
     }.freeze

data/lib/inline_forms/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module InlineForms
-  VERSION = "8.1.19"
+  VERSION = "8.1.21"
 end

data/lib/inline_forms.rb

@@ -102,7 +102,6 @@ module InlineForms
   PLAIN_TEXT_FORM_ELEMENTS = %i[
     plain_text
     plain_text_area
-    text_area_without_ckeditor
   ].freeze
 
   def self.plain_text_form_element?(form_element)

data/test/archived_form_elements_test.rb

@@ -16,6 +16,18 @@ class ArchivedFormElementsTest < Minitest::Test
     end
   end
 
+  class ModelWithArchivedCkeditor
+    def inline_forms_attribute_list
+      [[:body, :ckeditor]]
+    end
+  end
+
+  class ModelWithArchivedTextAreaWithoutCkeditor
+    def inline_forms_attribute_list
+      [[:notes, :text_area_without_ckeditor]]
+    end
+  end
+
   def test_raises_when_model_declares_archived_geo_code_curacao
     err = assert_raises(InlineForms::ArchivedFormElementError) do
       InlineForms.validate_no_archived_form_elements_for!(ModelWithArchivedElement)
@@ -33,6 +45,24 @@ class ArchivedFormElementsTest < Minitest::Test
     assert_includes err.message, "archived/form_elements/tree"
   end
 
+  def test_raises_when_model_declares_archived_ckeditor
+    err = assert_raises(InlineForms::ArchivedFormElementError) do
+      InlineForms.validate_no_archived_form_elements_for!(ModelWithArchivedCkeditor)
+    end
+    assert_includes err.message, "ckeditor"
+    assert_includes err.message, "8.1.21"
+    assert_includes err.message, "archived/form_elements/ckeditor"
+  end
+
+  def test_raises_when_model_declares_archived_text_area_without_ckeditor
+    err = assert_raises(InlineForms::ArchivedFormElementError) do
+      InlineForms.validate_no_archived_form_elements_for!(ModelWithArchivedTextAreaWithoutCkeditor)
+    end
+    assert_includes err.message, "text_area_without_ckeditor"
+    assert_includes err.message, "8.1.21"
+    assert_includes err.message, "archived/form_elements/ckeditor"
+  end
+
   def test_archived_registry_documents_absence_list_without_path
     meta = InlineForms::ARCHIVED_FORM_ELEMENTS[:absence_list]
     assert_equal "6.3.0", meta[:removed_in_version]

data/test/form_element_from_callee_test.rb

@@ -45,9 +45,9 @@ class FormElementFromCalleeTest < Minitest::Test
   end
 
   def test_multi_word_element_name_underscores_preserved
-    got = InlineForms.form_element_string_from_callee(:text_area_without_ckeditor_show)
+    got = InlineForms.form_element_string_from_callee(:dropdown_with_values_show)
     assert_equal(
-      "text_area_without_ckeditor",
+      "dropdown_with_values",
       got,
       "Form element names with underscores must survive unchanged except for _show."
     )

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 8.1.19
+  version: 8.1.21
 platform: ruby
 authors:
 - Ace Suares
@@ -480,6 +480,9 @@ files:
 - archived/form_elements/chicas/app/helpers/form_elements/chicas_dropdown_with_family_members.rb
 - archived/form_elements/chicas/app/helpers/form_elements/chicas_family_photo_list.rb
 - archived/form_elements/chicas/app/helpers/form_elements/chicas_photo_list.rb
+- archived/form_elements/ckeditor/README.md
+- archived/form_elements/ckeditor/lib/inline_forms/form_elements/ckeditor_helper.rb
+- archived/form_elements/ckeditor/lib/inline_forms/form_elements/text_area_without_ckeditor_helper.rb
 - archived/form_elements/geo_code_curacao/README.md
 - archived/form_elements/geo_code_curacao/app/controllers/geo_code_curacao_controller.rb
 - archived/form_elements/geo_code_curacao/app/helpers/form_elements/geo_code_curacao.rb
@@ -514,7 +517,6 @@ files:
 - lib/inline_forms/form_elements/audio_field_helper.rb
 - lib/inline_forms/form_elements/check_box_helper.rb
 - lib/inline_forms/form_elements/check_list_helper.rb
-- lib/inline_forms/form_elements/ckeditor_helper.rb
 - lib/inline_forms/form_elements/date_helper.rb
 - lib/inline_forms/form_elements/decimal_field_helper.rb
 - lib/inline_forms/form_elements/devise_password_field_helper.rb
@@ -546,7 +548,6 @@ files:
 - lib/inline_forms/form_elements/simple_file_field_helper.rb
 - lib/inline_forms/form_elements/slider_with_values_helper.rb
 - lib/inline_forms/form_elements/text_area_helper.rb
-- lib/inline_forms/form_elements/text_area_without_ckeditor_helper.rb
 - lib/inline_forms/form_elements/text_field_helper.rb
 - lib/inline_forms/form_elements/time_helper.rb
 - lib/inline_forms/gem_files.rb