inline_forms 8.1.13 → 8.1.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ae9fa81e904412a8066f7b989cc62d751ecd2ec388e86280a9f29c40c71066c
-  data.tar.gz: a1ef139cf1a6ab1827a79dfe4b13b83cc106dbaf4618f3840a4f00c623139d30
+  metadata.gz: a523b9082f8bf1ada004984c1d3cc66e745cae0e525e36acbf66df97b7015e98
+  data.tar.gz: d82f9950bde7f293ea70ef2e63162bcb304a0fac44eb6c8f645f88bbefe947da
 SHA512:
-  metadata.gz: 87a7b60dbc16267a2b1415374747785df190d82fb00d9df751dd6b3c47e9f02a82e2d2127ff04784fe659d6709ffd64044952c013c11fc49af0bad47284a29c7
-  data.tar.gz: 4452500f6fa5b2e6f1010a61e3a5f30ba755b44de4861a09868787136a4f06aa4873d545b03e68af782d0239bd8d55289c60cbdce22fde565d26d4ccda24a28f
+  metadata.gz: 275bec7794f426e5131ae69843dfcb9bd2cec55ae9124075bc59ae0e171fc6df3d406ae776d78526a918a12dbc87aa41b0b12ade138fd4f520d75254570e6b01
+  data.tar.gz: 33bb93de6e2f017d664b610e07105afea73708b5ee67a269b48bd68de6b3d0fa8b9688eab4c21882ea408a8fc7ab68fcf6e2a18ff733d56fad29110e5863790e

data/CHANGELOG.md

@@ -4,6 +4,32 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [8.1.16] - 2026-05-28
+
+### Fixed
+
+- **`RecordNotUnique` on `action_text_rich_texts.id` when undoing a delete more than once.** Restoring rich text after parent undo used `reify.save!`, which INSERTs the old primary key. A second delete/undo cycle (or an already-restored row) hit SQLite's unique constraint. Restoration now upserts by `(record_type, record_id, name)` and copies `body` only, and only the latest PaperTrail `destroy` version per attribute is applied.
+
+### Added
+
+- **Regression test:** nested Photo delete → undo → delete → undo.
+
+## [8.1.15] - 2026-05-28
+
+### Fixed
+
+- **Post-delete undo on Apartment/Photo (and any model with `rich_text`) left `description` empty.** Undo only reified the parent row; ActionText bodies live in `action_text_rich_texts` and are removed on `destroy`, with separate PaperTrail `destroy` versions. `revert` now also reifies and saves each `ActionText::RichText` destroy snapshot that belonged to the restored parent (Apartment, nested Photo, `FormElementShowcase#description`, etc.).
+
+### Added
+
+- **Regression tests:** apartment row destroy+undo with `description` rich text; nested photo destroy+undo with `description` rich text.
+
+## [8.1.14] - 2026-05-28
+
+### Fixed
+
+- **`example_app_showcase_row_turbo_test` broke `--example` installs.** The Empty-demo undo regression parsed the undo URL as `/revert/:id`, but member routes are `/form_element_showcases/:id/revert`. The installer gate failed (`131 runs, 1 failure`) and surfaced the misleading “Rails could not create the app 'MyApp', maybe because it is a reserved word…” message even though the app was generated. The test now matches the real path and loads the destroy version from PaperTrail.
+
 ## [8.1.13] - 2026-05-28
 
 ### Fixed

data/app/controllers/inline_forms_controller.rb

@@ -320,12 +320,63 @@ class InlineFormsController < ApplicationController
     else
       @parent = @object
       @parent.save!
+      restore_rich_texts_for_reverted_parent!(@parent)
+      @parent.reload
     end
     render_revert_response if row_html_turbo_allowed?
   end
 
   private
 
+  # Undoing a parent +destroy+ reifies the Apartment/Photo row only. ActionText
+  # bodies live in +action_text_rich_texts+ and get their own PaperTrail
+  # +destroy+ versions; those rows are gone after +parent.destroy+, so we also
+  # reify each matching +ActionText::RichText+ destroy snapshot.
+  #
+  # Use +find_or_initialize_by(record_type, record_id, name)+ and copy +body+
+  # only. Reified rows carry the old PK; +save!+ on a new record would INSERT
+  # that id and raise +RecordNotUnique+ on a second delete/undo cycle when the
+  # row already exists. Only the newest destroy version per attribute name is
+  # applied (repeat delete/undo leaves multiple RT destroy versions in the table).
+  def restore_rich_texts_for_reverted_parent!(parent)
+    return unless defined?(ActionText::RichText)
+
+    record_type = parent.class.base_class.name
+    record_id = parent.id
+    versions_by_name = {}
+
+    PaperTrail::Version
+      .where(item_type: "ActionText::RichText", event: "destroy")
+      .order(id: :desc)
+      .each do |version|
+        attrs = version.object_deserialized
+        next unless attrs.is_a?(Hash)
+
+        type = attrs["record_type"] || attrs[:record_type]
+        rid = attrs["record_id"] || attrs[:record_id]
+        next unless type == record_type && rid.to_i == record_id
+
+        name = (attrs["name"] || attrs[:name]).to_s
+        next if name.empty?
+
+        versions_by_name[name] ||= version
+      end
+
+    versions_by_name.each_value do |version|
+      reified = version.reify
+      next unless reified
+
+      name = reified.name.to_s
+      record = ActionText::RichText.find_or_initialize_by(
+        record_type: record_type,
+        record_id: record_id,
+        name: name
+      )
+      record.body = reified.body if reified.respond_to?(:body)
+      record.save!
+    end
+  end
+
   # +revert+ is excluded from +load_and_authorize_resource+; +authorize!+ runs in the
   # action. +check_authorization+ on ApplicationController still requires that flag.
   def revert_authorization_subject(version)

data/lib/inline_forms/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module InlineForms
-  VERSION = "8.1.13"
+  VERSION = "8.1.16"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 8.1.13
+  version: 8.1.16
 platform: ruby
 authors:
 - Ace Suares