inline_forms 8.0.4 → 8.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 83fc3ebab88e414806da9e2c7f9a47088eb1d69579f607af783e647f374ada2b
-  data.tar.gz: 76348168e6d35fb88a7142e66e92938ae6938b83cd606a894f1985c37c7cd219
+  metadata.gz: b3b934b94b7f4b5298dea2e2a51b8c97c37c06969a3484d528e336edf17ddfde
+  data.tar.gz: fedfafb7fba445712299b4c240fc905418c665d8f29e139c17cb9abc4138fe36
 SHA512:
-  metadata.gz: d3d2b9b5a2cc0239857123cf16cd6605f58d27e324accddb8232015445767e3b06214c4c869d6089218b42aa72f737a11611d83abc3b53e731573ea628987944
-  data.tar.gz: 29d10dd86bb1c3bff98a5653b513de213e08250ab43b3fd3969e1aeaa71cd690f73f9034f51c64e775debeff69abd6180b5895867e7c4ca0a9aa10bda879fe07
+  metadata.gz: b9d1abfecdf6fa9c75c4d79967e8604e0bb408a40a08475fb7106e12b0b301a437e8192f836a39b9b5c75261ac97d5dfade6f2ba5ecea9005015814bd257028f
+  data.tar.gz: 5f62f997de89dd93334a6324d2d02fe3bd283036d3f68ee39947cd400ab57f6d3a2d959745498d2b7f5e5c567889cd02e258ed7c15fef3cf3f051f3a21ee3d60

data/CHANGELOG.md

@@ -4,6 +4,38 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [8.1.0] - 2026-05-25
+
+### Added
+
+- **`ApplicationRecord` template carries shared model behavior:** `has_paper_trail on: [:create, :update, :destroy]`, `attr_writer :inline_forms_attribute_list`, `self.per_page = 7`, `human_attribute_name` instance wrapper, and `def self.not_accessible_through_html?` default. Generated models inherit all of this; `lib/generators/templates/model.erb` only emits per-model differences (associations, `inline_forms_attribute_list`, `_presentation`, `<=>`, `not_accessible_through_html?` override when `_enabled` is absent).
+- **`scope :inline_forms_list, -> { all }` and `scope :inline_forms_search, ->(_q) { all }`** on `ApplicationRecord`. Both are no-ops by default; subclasses opt in. Replaces the old `def self.order_by_clause` contract with composable Active Record relations.
+- **Generator flags `_list_order:col` and `_list_search:col`:** emit `scope :inline_forms_list, -> { order(:col, :id) }` and `scope :inline_forms_search, ->(q) { where("col LIKE ?", "%#{q}%") }` respectively. `_list_order` also still emits `def <=>(other)` for in-memory sort on associations (used by `check_list` show). Tie-break on `:id` is added automatically so will_paginate pages stay stable.
+- **`SPECIAL_GENERATOR_NAMES` constant** in `InlineForms::InlineFormsGenerator` consolidates `_presentation`, `_order`, `_list_order`, `_list_search`, `_enabled`, `_id`, `_no_migration`, `_no_model` so `migration?` / `attribute?` no longer drift.
+
+### Changed
+
+- **`order_by_clause` is gone from the gem.** `InlineFormsController#index` / `#create`, `check_list_helper.rb`, and `app/views/inline_forms/_list.html.erb` now compose `merge(@Klass.inline_forms_list)` and `merge(@Klass.inline_forms_search(params[:search]))` instead of building raw `"table.col"` strings. Search and order are now independent (one column had to do both jobs before); models can declare each separately or neither.
+- **Per-page pagination fix in `ApplicationRecord`:** `self.per_page = 7` (class-level, what will_paginate's `class_attribute :per_page` reads). The old `attr_reader :per_page` + `@per_page = 7` instance pair on every generated model was a no-op (described at length in 8.0.x notes); models that need a different value override with `self.per_page = N` (Photo uses `5`). The installer’s Photo override now uses `inject_into_class "app/models/photo.rb", "Photo", "  self.per_page = 5\n"` instead of patching the legacy `attr_reader` block out.
+- **`_order:col` is deprecated as an alias for `_list_order:col`.** Still works (emits the same scope plus `<=>`); the generator prints `say_status :deprecated, "_order:col is deprecated; use _list_order:col"` so existing scripts keep generating but the migration path is visible.
+- **Installer User model:** dropped `default_scope { order :name }` and the `def self.order_by_clause; nil; end` stub. Added `scope :inline_forms_list, -> { order(:name, :id) }` with a comment about why named scopes beat `default_scope` (no `unscope`/`reorder` foot-guns; cleaner `update_all` / association inheritance).
+- **Installer example-app generator calls** for `Locale`, `Role`, `Photo`, `Apartment`, `Owner` now pass `_list_order:name` (and `_list_search:name` for the searchable top-level models `Apartment` and `Owner`) to declare ordering and search explicitly. Replaces the implicit `order_by_clause = "name"` default that the old generator produced.
+
+### Removed
+
+- **`lib/generators/assets/javascripts/`** (including the empty `ckeditor/` subfolder). Leftover from the CKEditor era; nothing in the gem or installer copied from it. The engine still ships JS under `app/assets/javascripts/` and `vendor/assets/javascripts/`.
+- **`lib/generators/assets/stylesheets/inline_forms.scss`** mirror. The installer doesn't copy it; the gem stylesheet at `app/assets/stylesheets/inline_forms/inline_forms.scss` is the single source consumed via `@use "inline_forms/inline_forms"`. `inline_forms_devise.css` stays — it is the host-app override hook copied by the installer and linked from `layouts/devise.html.erb`.
+
+### Migration notes
+
+Existing apps upgrading from 8.0.x:
+
+1. Replace your `app/models/application_record.rb` with the contents of `lib/generators/templates/application_record.rb` (or just merge in the new `has_paper_trail`, `self.per_page`, `inline_forms_list` / `inline_forms_search` scopes, and `not_accessible_through_html?` default).
+2. For each model that had `def self.order_by_clause; "col"; end`, replace with `scope :inline_forms_list, -> { order(:col, :id) }`. Drop the old method; the gem no longer reads it.
+3. If you used `default_scope { order(:name) }` for inline_forms list ordering, swap to the named scope above.
+4. Per-model `attr_reader :per_page` / `@per_page = N` pairs are no-ops; replace with `self.per_page = N` (or remove and inherit `7` from `ApplicationRecord`).
+5. `_order:col` in your generator scripts still works but emits a deprecation notice; switch to `_list_order:col` and add `_list_search:col` if you want the search box to filter on that column.
+
 ## [8.0.4] - 2026-05-24
 
 ### Added

data/app/controllers/inline_forms_controller.rb

@@ -36,14 +36,12 @@ class InlineFormsController < ApplicationController
     @parent_class = params[:parent_class]
     @parent_id = params[:parent_id]
     @ul_needed = params[:ul_needed]
-    # if the parent_class is not nill, we are in associated list and we don't search there.
-    # also, make sure the Model that you want to do a search on has a :name attribute. TODO
-    conditions = nil
-    if @parent_class.nil? || @Klass.reflect_on_association(@parent_class.underscore.to_sym).nil?
-      conditions = [ @Klass.table_name + "." + @Klass.order_by_clause + " like ?", "%#{params[:search]}%" ] if @Klass.respond_to?(:order_by_clause) && ! @Klass.order_by_clause.nil?
-    else
+    # Nested associated lists scope to the parent FK. Top-level lists may
+    # apply the model's `inline_forms_search` scope when ?search= is passed.
+    fk_conditions = nil
+    if @parent_class.present? && @Klass.reflect_on_association(@parent_class.underscore.to_sym)
       foreign_key = @Klass.reflect_on_association(@parent_class.underscore.to_sym).options[:foreign_key] || @parent_class.foreign_key
-      conditions =  [ "#{foreign_key} = ?", @parent_id ]
+      fk_conditions = [ "#{foreign_key} = ?", @parent_id ]
     end
     # CanCan's load_and_authorize_resource sets @apartments (etc.); keep @objects in sync.
     collection_ivar = :"@#{controller_name}"
@@ -52,9 +50,13 @@ class InlineFormsController < ApplicationController
       @objects = loaded unless loaded.nil?
     end
     @objects ||= @Klass.accessible_by(current_ability) if cancan_enabled?
-    @objects ||= @Klass
-    @objects = @objects.order(@Klass.table_name + "." + @Klass.order_by_clause) if @Klass.respond_to?(:order_by_clause) && ! @Klass.order_by_clause.nil?
-    @objects = @objects.where(conditions).paginate(:page => params[:page])
+    @objects ||= @Klass.all
+    @objects = @objects.merge(@Klass.inline_forms_list) if @Klass.respond_to?(:inline_forms_list)
+    if fk_conditions.nil? && params[:search].present? && @Klass.respond_to?(:inline_forms_search)
+      @objects = @objects.merge(@Klass.inline_forms_search(params[:search]))
+    end
+    @objects = @objects.where(fk_conditions) if fk_conditions
+    @objects = @objects.paginate(:page => params[:page])
     respond_to do |format|
       # `not_accessible_through_html?` is about preventing direct top-level
       # HTML CRUD on this resource (e.g. /photos when only Apartment is the
@@ -139,22 +141,23 @@ class InlineFormsController < ApplicationController
     end
     @parent_class = params[:parent_class]
     @parent_id = params[:parent_id]
-    # for the logic behind the :conditions see the #index method.
-    conditions = nil
-    if @parent_class.nil? || @Klass.reflect_on_association(@parent_class.underscore.to_sym).nil?
-      conditions = [ @Klass.table_name + "." + @Klass.order_by_clause + " like ?", "%#{params[:search]}%" ] if @Klass.respond_to?(:order_by_clause) && ! @Klass.order_by_clause.nil?
-    else
+    # See #index for the order/search/parent-fk decomposition.
+    fk_conditions = nil
+    if @parent_class.present? && @Klass.reflect_on_association(@parent_class.underscore.to_sym)
       foreign_key = @Klass.reflect_on_association(@parent_class.underscore.to_sym).options[:foreign_key] || @parent_class.foreign_key
-      conditions =  [ "#{foreign_key} = ?", @parent_id ]
+      fk_conditions = [ "#{foreign_key} = ?", @parent_id ]
       @object[foreign_key] = @parent_id
     end
 
     if @object.save
       flash.now[:success] = t('success', :message => @object.class.model_name.human)
-      @objects = @Klass
-      @objects = @Klass.accessible_by(current_ability) if cancan_enabled?
-      @objects = @objects.order(@Klass.table_name + "." + @Klass.order_by_clause) if @Klass.respond_to?(:order_by_clause) && ! @Klass.order_by_clause.nil?
-      @objects = @objects.where(conditions).paginate(:page => params[:page])
+      @objects = cancan_enabled? ? @Klass.accessible_by(current_ability) : @Klass.all
+      @objects = @objects.merge(@Klass.inline_forms_list) if @Klass.respond_to?(:inline_forms_list)
+      if fk_conditions.nil? && params[:search].present? && @Klass.respond_to?(:inline_forms_search)
+        @objects = @objects.merge(@Klass.inline_forms_search(params[:search]))
+      end
+      @objects = @objects.where(fk_conditions) if fk_conditions
+      @objects = @objects.paginate(:page => params[:page])
       @object = nil
       respond_to do |format|
         format.html { render_list_frame_after_save } if html_list_flow_allowed?

data/app/views/inline_forms/_list.html.erb

@@ -34,9 +34,10 @@
     <% foreign_key = parent_class.reflect_on_association(attribute.to_sym).options[:foreign_key] || parent_class.name.foreign_key -%>
     <% model = attribute.to_s.singularize.camelcase.constantize %>
     <% conditions =  [ "#{model.table_name}.#{foreign_key} = ?", parent_id ] %>
+    <% klass = attribute.to_s.singularize.camelcase.constantize %>
     <% objects = parent_class.find(parent_id).send(attribute) %>
     <% objects = parent_class.find(parent_id).send(attribute).accessible_by(current_ability) if cancan_enabled? %>
-    <% objects = objects.order(attribute.to_s.singularize.camelcase.constantize.order_by_clause) if attribute.to_s.singularize.camelcase.constantize.respond_to?(:order_by_clause) && ! attribute.to_s.singularize.camelcase.constantize.order_by_clause.nil? %>
+    <% objects = objects.merge(klass.inline_forms_list) if klass.respond_to?(:inline_forms_list) %>
     <% objects = objects.where(conditions).paginate(:page => params[:page]) %>
   <% end %>
 <% end %>

data/inline_forms.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
   s.test_files = s.files.grep(%r{^(test|spec|features)/})
   s.require_paths = ["lib"]
 
-  s.add_dependency("validation_hints", ">= 8.0.4", "< 9.0")
+  s.add_dependency("validation_hints", ">= 8.1.0", "< 9.0")
   s.add_dependency("rails", ">= 8.0", "< 8.1")
   s.add_dependency("rails-i18n", ">= 8.0", "< 9.0")
 

data/lib/generators/inline_forms_generator.rb

@@ -64,19 +64,26 @@ module InlineForms
         RELATIONS.has_key?(type) || special_relation?
       end
 
+      # Special "attribute" names that drive the generator (presentation,
+      # ordering, search, etc.) but never become real columns or fields.
+      SPECIAL_GENERATOR_NAMES = %w[
+        _presentation
+        _order
+        _list_order
+        _list_search
+        _enabled
+        _id
+        _no_migration
+        _no_model
+      ].freeze
+
       def migration?
         not ( column_type == :no_migration  ||
-            name == "_presentation"       ||
-            name == "_order"              ||
-            name == "_enabled"            ||
-            name == "_id" )
+            SPECIAL_GENERATOR_NAMES.include?(name) )
       end
 
       def attribute?
-        not ( name == '_presentation'       ||
-            name == '_order'              ||
-            name == '_enabled'            ||
-            name == "_id"                 ||
+        not ( SPECIAL_GENERATOR_NAMES.include?(name) ||
             relation? )
       end
 
@@ -126,10 +133,7 @@ module InlineForms
         @has_attached_files       = "\n"
         @presentation             = "\n"
         @order                    = "\n"
-        @order_by_clause          = "  def self.order_by_clause\n" +
-          "    \"name\"\n" +
-          "  end\n" +
-          "\n"
+        @list_scopes              = ""
         @carrierwave_mounters     = "\n"
         @inline_forms_attribute_list  = String.new
 
@@ -165,15 +169,23 @@ module InlineForms
               "  end\n" +
               "\n"
           end
-          if attribute.name == '_order'
+          # `_list_order:col` (preferred) and the legacy alias `_order:col`
+          # both emit the inline_forms_list scope plus a Ruby `<=>` for
+          # in-memory sort (used by check_list show on the association).
+          if attribute.name == '_order' || attribute.name == '_list_order'
+            if attribute.name == '_order'
+              say_status :deprecated,
+                         "_order:#{attribute.type} is deprecated; use _list_order:#{attribute.type}",
+                         :yellow
+            end
             @order <<         "  def <=>(other)\n" +
               "    self.#{attribute.type} <=> other.#{attribute.type}\n" +
               "  end\n" +
               "\n"
-            @order_by_clause = "  def self.order_by_clause\n" +
-              "    \"#{attribute.type}\"\n" +
-              "  end\n" +
-              "\n"
+            @list_scopes << "  scope :inline_forms_list, -> { order(:#{attribute.type}, :id) }\n"
+          end
+          if attribute.name == '_list_search'
+            @list_scopes << "  scope :inline_forms_search, ->(q) { where(\"#{attribute.type} LIKE ?\", \"%\#{q}%\") }\n"
           end
           if attribute.attribute?
             attribute.attribute_type == :unknown ? commenter = '#' : commenter = ' '

data/lib/generators/templates/application_record.rb

@@ -1,9 +1,41 @@
 class ApplicationRecord < ActiveRecord::Base
   self.abstract_class = true
 
+  # PaperTrail 16 defaults to `on: [:create, :update, :destroy, :touch]`.
+  # ActionText's `belongs_to :record, polymorphic: true, touch: true` (set by
+  # `has_rich_text`) calls `parent.touch` on every rich-text save, which
+  # produced a parent-side `update` version with an empty changeset — visible
+  # in the inline_forms versions panel as a meaningless "empty" row whose
+  # Restore link reifies the same state (no-op). Excluding `:touch` here
+  # suppresses that noise without affecting real attribute updates.
+  has_paper_trail on: [:create, :update, :destroy]
+
+  attr_writer :inline_forms_attribute_list
+
+  # will_paginate reads Klass.per_page (class level), not instance ivars.
+  self.per_page = 7
+
+  # Default list ordering for inline_forms #index/#create and nested
+  # associated lists. Subclasses override via
+  #   scope :inline_forms_list, -> { order(:col, :id) }
+  # (typically emitted by `rails g inline_forms <Model> _list_order:<col>`).
+  # `all` is a no-op so the gem adds no ORDER BY by default; pair with
+  # explicit named scopes rather than `default_scope` so callers can
+  # `unscope`/`reorder` cleanly.
+  scope :inline_forms_list, -> { all }
+
+  # Default list search; no-op so the gem's search box is inert until a model
+  # opts in via
+  #   scope :inline_forms_search, ->(q) { where("col LIKE ?", "%#{q}%") }
+  # (emitted by `_list_search:<col>` in the generator).
+  scope :inline_forms_search, ->(_q) { all }
+
   # Wrapper for @model.human_attribute_name -> Model.human_attribute_name
   def human_attribute_name(*args)
     self.class.human_attribute_name(*args)
   end
 
+  def self.not_accessible_through_html?
+    false
+  end
 end

data/lib/generators/templates/model.erb

@@ -1,15 +1,4 @@
 class <%= name %> < ApplicationRecord
-  attr_reader :per_page
-  @per_page = 7
-  attr_writer :inline_forms_attribute_list
-  # PaperTrail 16 defaults to `on: [:create, :update, :destroy, :touch]`.
-  # ActionText's `belongs_to :record, polymorphic: true, touch: true` (set by
-  # `has_rich_text`) calls `parent.touch` on every rich-text save, which
-  # produced a parent-side `update` version with an empty changeset — visible
-  # in the inline_forms versions panel as a meaningless "empty" row whose
-  # Restore link reifies the same state (no-op). Excluding `:touch` here
-  # suppresses that noise without affecting real attribute updates.
-  has_paper_trail on: [:create, :update, :destroy]
 <%= @carrierwave_mounters if @carrierwave_mounters.length > 1 -%>
 <%= @belongs_to if @belongs_to.length > 1 -%>
 <%= @has_many if @has_many.length > 1 -%>
@@ -17,14 +6,18 @@ class <%= name %> < ApplicationRecord
 <%= @habtm if @habtm.length > 1 -%>
 <%= @has_rich_text if @has_rich_text.length > 1 -%>
 <%= @has_attached_files if @has_attached_files.length > 1 -%>
+<% if @list_scopes && !@list_scopes.empty? -%>
+
+<%= @list_scopes -%>
+<% end -%>
 <%= @presentation  if @presentation.length > 1 -%>
 <%= @inline_forms_attribute_list -%>
 <%= @order  if @order.length > 1 -%>
+<% if @flag_not_accessible_through_html -%>
 
   def self.not_accessible_through_html?
-    <%= @flag_not_accessible_through_html %>
+    true
   end
-
-<%= @order_by_clause -%>
+<% end -%>
 
 end

data/lib/inline_forms/form_elements/check_list_helper.rb

@@ -19,11 +19,9 @@ module InlineForms
     
     def check_list_edit(object, attribute)
       object.send(attribute).build  if object.send(attribute).empty?
-      if cancan_enabled?
-        values = object.send(attribute).first.class.name.constantize.accessible_by(current_ability).order(attribute.to_s.singularize.camelcase.constantize.order_by_clause)
-      else
-        values = object.send(attribute).first.class.name.constantize.order(attribute.to_s.singularize.camelcase.constantize.order_by_clause)
-      end
+      klass = object.send(attribute).first.class
+      values = cancan_enabled? ? klass.accessible_by(current_ability) : klass.all
+      values = values.merge(klass.inline_forms_list) if klass.respond_to?(:inline_forms_list)
       out = ''
       values.each do | item |
         out << "<div class='row #{cycle('odd', 'even')}'>"

data/lib/inline_forms/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module InlineForms
-  VERSION = "8.0.4"
+  VERSION = "8.1.0"
 end

data/test/inline_forms_generator_test.rb

@@ -36,6 +36,12 @@ class InlineFormsGeneratorTest < Minitest::Test
     migration = read_single_migration_for("things")
 
     assert_includes(model, "class Thing < ApplicationRecord")
+    refute_includes(model, "has_paper_trail")
+    refute_includes(model, "attr_reader :per_page")
+    refute_includes(model, 'def self.not_accessible_through_html?')
+    refute_includes(model, "def self.order_by_clause")
+    refute_includes(model, "scope :inline_forms_list")
+    refute_includes(model, "scope :inline_forms_search")
     assert_includes(model, "belongs_to :category")
     assert_includes(model, "has_many :photos")
     assert_includes(model, "[ :name , \"name\", :text_field ]")
@@ -100,6 +106,61 @@ class InlineFormsGeneratorTest < Minitest::Test
     refute_includes(migration, "t.text :content")
   end
 
+  def test_not_accessible_and_list_order_emits_scope_and_spaceship
+    run_generator(
+      "Photo",
+      "name:string",
+      "album:belongs_to",
+      "_presentation:\\#{name}",
+      "_list_order:caption"
+    )
+
+    model = read("app/models/photo.rb")
+    assert_includes(model, "def self.not_accessible_through_html?\n    true")
+    assert_includes(model, "scope :inline_forms_list, -> { order(:caption, :id) }")
+    assert_includes(model, "def <=>(other)")
+    assert_includes(model, "self.caption <=> other.caption")
+    refute_includes(model, "def self.order_by_clause")
+    refute_includes(model, "has_paper_trail")
+  end
+
+  def test_legacy_order_alias_still_emits_scope_with_deprecation_warning
+    stdout, stderr = capture_io do
+      run_generator(
+        "Photo",
+        "name:string",
+        "_presentation:\\#{name}",
+        "_order:caption"
+      )
+    end
+
+    output = "#{stdout}#{stderr}"
+    assert_includes(output, "_order:caption is deprecated")
+    assert_includes(output, "_list_order:caption")
+
+    model = read("app/models/photo.rb")
+    assert_includes(model, "scope :inline_forms_list, -> { order(:caption, :id) }")
+    refute_includes(model, "def self.order_by_clause")
+  end
+
+  def test_list_search_emits_search_scope
+    run_generator(
+      "Apartment",
+      "name:string",
+      "_enabled:yes",
+      "_list_order:name",
+      "_list_search:name",
+      "_presentation:\\#{name}"
+    )
+
+    model = read("app/models/apartment.rb")
+    assert_includes(model, "scope :inline_forms_list, -> { order(:name, :id) }")
+    assert_includes(model, "scope :inline_forms_search, ->(q) { where(\"name LIKE ?\", \"%\#{q}%\") }")
+    migration = read_single_migration_for("apartments")
+    refute_includes(migration, "_list_order")
+    refute_includes(migration, "_list_search")
+  end
+
   def test_plain_text_generates_text_column_and_plain_text_form_element
     run_generator("Note", "title:string", "description:plain_text")
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 8.0.4
+  version: 8.1.0
 platform: ruby
 authors:
 - Ace Suares
@@ -17,7 +17,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 8.0.4
+        version: 8.1.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '9.0'
@@ -27,7 +27,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 8.0.4
+        version: 8.1.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '9.0'
@@ -492,18 +492,8 @@ files:
 - archived/form_elements/tree/app/helpers/form_elements/move.rb
 - archived/form_elements/tree/app/views/inline_forms/_show_tree.html.erb
 - archived/form_elements/tree/app/views/inline_forms/_tree.html.erb
-- docs/git-deps-assessment.md
-- docs/jquery-widgets.md
-- docs/prompt/.gitignore
-- docs/prompt/test-the-example-app.md
-- docs/rails-8-phase4-audit.md
-- docs/rails-8-release.md
-- docs/turbo-stream-audit.md
-- docs/ujs-to-turbo.md
-- docs/zeitwerk-and-load-paths.md
 - inline_forms.gemspec
 - lib/generators/USAGE
-- lib/generators/assets/stylesheets/inline_forms.scss
 - lib/generators/assets/stylesheets/inline_forms_devise.css
 - lib/generators/inline_forms_generator.rb
 - lib/generators/templates/_inline_forms_tabs.html.erb

data/docs/git-deps-assessment.md

@@ -1,93 +0,0 @@
-# Git-sourced installer dependencies — assessment
-
-**Date:** 2026-05-19  
-**Context:** Generated apps from `inline_forms create` used three non-RubyGems pins: `tabs_on_rails` (git + branch), `i18n-active_record` (git), and a commented `will_paginate` fork. This doc records why they existed and what replaced them.
-
-**Related (risk callouts only):** `validation_hints/stuff/rails-7.2-zeitwerk-plan.md` (Track A3), `validation_hints/stuff/rails-8-checklist.md` (Phase 3).
-
----
-
-## Summary (7.13.5+)
-
-| Gem | Was | Now | Reason |
-|-----|-----|-----|--------|
-| `will_paginate` | RubyGems + commented acesuares fork | RubyGems only | Fork never active; comment removed |
-| `tabs_on_rails` | `acesuares/tabs_on_rails` branch `update_remote_before_action` | `~> 3.0` (weppos, RubyGems) | Fork only added unused `:remote` on tab links; upstream 3.0.0 already uses `before_action` |
-| `i18n-active_record` | `acesuares/i18n-active_record` (2012) | **Removed** (7.13.18: no DB translation tables) | Never configured `I18n.backend`; DB tables/view and `extract_translations` removed |
-
-**No generated-app Gemfile should use `:git` for these anymore.**
-
----
-
-## `will_paginate`
-
-- **Fork:** `https://github.com/acesuares/will_paginate.git` (commented out for years).
-- **Usage:** Nested/top-level list pagination in `_list.html.erb`; Turbo Frame nav since 7.5.x (no `:remote => true`).
-- **Verdict:** RubyGems `will_paginate` is sufficient. No acesuares-specific behavior required.
-
----
-
-## `tabs_on_rails`
-
-### Why the fork existed
-
-Branch `update_remote_before_action` on `acesuares/tabs_on_rails` (2019) did two things:
-
-1. `before_filter` → `before_action` (Rails 4+ rename).
-2. Optional `:remote => true` on `tab_for` links (`tabs_builder.rb`).
-
-### What inline_forms actually uses
-
-- Controllers call **`set_tab :resource`** only (generator template + installer).
-- Top bar is **not** built with `tabs_tag` / `tab_for`; `_inline_forms_tabs.html.erb` is a Foundation top-bar with search + new button.
-- Turbo migration removed **`data-remote`** from inline UI; no code passes `:remote` into tabs.
-
-### Upstream today
-
-- **RubyGems:** `tabs_on_rails` **3.0.0** (weppos, 2017).
-- **`set_tab`** already uses **`before_action`** in `lib/tabs_on_rails/action_controller.rb`.
-- **Missing vs fork:** `:remote` on tab links only — **unused by inline_forms**.
-
-### Verdict
-
-**Use `gem 'tabs_on_rails', '~> 3.0'`.** No runtime dependency on the fork. Re-test on Rails 7.2+ / 8.0 when upgrading (gem is unmaintained but tiny).
-
----
-
-## `i18n-active_record`
-
-### History
-
-- Fork existed because MySQL reserves `KEY`; acesuares fork used **`thekey`**.
-- **7.13.5–7.13.17:** gem removed from Gemfile; installer still generated locale/key/translation tables + `translations` view; **`InlineForms::TranslationRecord`** read the view; **`extract_translations`** exported YAML (never routed by default).
-- **`I18n.backend` was never** `I18n::Backend::ActiveRecord` in generated apps.
-
-### Verdict (7.13.18+)
-
-**No DB translation layer.** Generated apps use Rails I18n YAML only (`config/locales/inline_forms_local.en.yml`, etc.). If **I18n::Backend::ActiveRecord** is needed later, add **`i18n-active_record ~> 1.4`** and migrations separately—not via inline_forms installer.
-
----
-
-## Previously removed forks (reference)
-
-| Gem | Removed in | Replacement |
-|-----|------------|-------------|
-| `devise-i18n` | 7.3.4 / 7.10+ | RubyGems `~> 1.16` |
-| `paper_trail` | 7.0.x | RubyGems `~> 16.0` |
-| `switch_user` | 7.2.x | Removed from installer |
-
----
-
-## Verification
-
-After changing `installer_core.rb`:
-
-```bash
-cd /home/code/inline_forms && rvm use . && gem build inline_forms.gemspec && gem build inline_forms_installer.gemspec
-cd /home/code/testInline && rvm use .
-gem install /home/code/inline_forms/inline_forms-*.gem /home/code/inline_forms/inline_forms_installer-*.gem
-rm -rf MyApp && inline_forms create MyApp -d sqlite --example
-cd MyApp && rvm use . && bundle exec rails test
-```
-
-Expect **0 failures**; `Gemfile.lock` should list `tabs_on_rails (3.0.0)` and **no** `i18n-active_record` git source.

data/docs/jquery-widgets.md

@@ -1,25 +0,0 @@
-# jQuery widget migration (Phase 4)
-
-UJS removal (7.8.0) is complete. These jQuery-based widgets remain in the Sprockets bundle:
-
-| Widget | Asset | Status |
-|--------|-------|--------|
-| Datepicker | `jquery.ui.all` | **Centralized** — `initInlineFormsWidgets` in `inline_forms.js`; helpers use `class="datepicker"` only |
-| Month/year picker | jQuery UI datepicker | **Centralized** — `class="datepicker datepicker-month-year"` |
-| Timepicker | `jquery.timepicker.js` | **Centralized** — `class="timepicker"` |
-| Autocomplete | `autocomplete-rails` + inline scripts in `dropdown_with_other` | Still inline / jQuery UI |
-| Foundation | `foundation` jQuery plugin | Required for layout chrome |
-
-## Central init (7.9.8+)
-
-`initInlineFormsWidgets(root)` runs on:
-
-- DOM ready (after `$.datepicker.setDefaults`)
-- `turbo:load`
-- `turbo:frame-load`
-
-Form element `_edit` helpers must **not** emit per-field `<script>` tags; class hooks only.
-
-## Future removal (not started)
-
-Replace with Stimulus or vanilla + `turbo:frame-load` one widget at a time; keep example-app tests green after each.

data/docs/prompt/.gitignore

@@ -1,5 +0,0 @@
-# Keep this directory for checked-in prompt docs.
-# Ignore local scratch files by default.
-*
-!.gitignore
-!*.md

data/docs/prompt/test-the-example-app.md

@@ -1,32 +0,0 @@
-You are in the inline_forms gem repo at /home/code/inline_forms.
-
-Goal:
-Build the current gem, install it into /home/code/testInline, recreate MyApp from scratch using --example, and verify it with Rails tests.
-
-Do all steps end-to-end without asking for confirmation unless a command fails.
-
-Steps:
-1) In /home/code/inline_forms:
-   - Ensure latest code is used.
-   - Run: rvm use .
-   - Build gems: gem build inline_forms.gemspec && gem build inline_forms_installer.gemspec
-   - Confirm the built file names/versions (inline_forms-<version>.gem, inline_forms_installer-<version>.gem).
-
-2) In /home/code/testInline:
-   - Remove old app if present: /home/code/testInline/MyApp
-   - Run: rvm use .
-   - Install the freshly built gems from /home/code/inline_forms/inline_forms-<version>.gem and inline_forms_installer-<version>.gem
-
-3) Still in /home/code/testInline:
-   - Generate fresh example app:
-     inline_forms create MyApp -d sqlite --example
-
-4) In /home/code/testInline/MyApp:
-   - Run: rvm use .
-   - Run verification: bundle exec rails test
-
-Output requirements:
-- Briefly report each phase result (build, install, app generation, test run).
-- Include exact commands run.
-- Include test summary (runs/assertions/failures/errors/skips).
-- If anything fails, stop at the failing step and include the exact error and the next corrective command you recommend.

data/docs/rails-8-phase4-audit.md

@@ -1,39 +0,0 @@
-# Rails 8 — Phase 4 audit (framework defaults & cleanup)
-
-**Date:** 2026-05-22  
-**Scope:** Post–Phase 3 (`inline_forms` 8.0.2 installer + example app gate).
-
-## 4.1 Framework defaults (`rails new` 8.0.5)
-
-Vanilla `rails _8.0.5_ new` (importmap, `--skip-bundle`):
-
-- `config/application.rb`: `config.load_defaults 8.0`, `config.autoload_lib(ignore: %w[assets tasks])`
-- Generator **removes** `config/initializers/new_framework_defaults_8_0.rb` (opt-in flags live only in the railties template until uncommented)
-- Optional 8.0 toggles (all commented in upstream template): `active_support.to_time_preserves_timezone`, `action_dispatch.strict_freshness`, `Regexp.timeout`
-
-**Installer decision:** Match vanilla Rails 8 — rely on `load_defaults 8.0` only; do **not** ship `new_framework_defaults_8_0.rb` in generated apps. Keep a belt-and-suspenders `gsub` to `load_defaults 8.0` if an older `rails new` left another minor.
-
-## 4.2 Rails 8 API / deprecation grep
-
-| Area | Result |
-|------|--------|
-| `form_with` / `model: nil` | No engine usage; inline fields use custom helpers / Turbo, not `form_with` |
-| `form_for` | Devise templates only (upstream Devise 5) |
-| `ActiveRecord::Base.connection` | Unicorn `before_fork` template updated → `connection_pool.disconnect!` |
-| `ActionController` deprecated flags | None in `lib/` |
-| Generator migrations | `ActiveRecord::Migration[8.0]` (tests assert) |
-
-## 4.3 Dart Sass / SCSS
-
-Foundation + engine SCSS still emit Dart Sass 1.x deprecation warnings during `dartsass:build`. Accepted for 8.0 ship; migrate to `@use` / `color.scale` before Dart Sass 3.0 (see `stuff/pipeline.md`).
-
-## 4.4 bundler-audit
-
-| Lockfile | Result (2026-05-22) |
-|----------|---------------------|
-| `validation_hints/Gemfile.lock` | No vulnerabilities found |
-| Example app `MyApp/Gemfile.lock` | No vulnerabilities found (`bundler-audit` on default gemset) |
-
-## 4.5 Example app gate (unchanged baseline)
-
-`inline_forms create MyApp -d sqlite --example` → **88 runs, 502 assertions, 0 failures, 0 errors, 0 skips** (Phase 3, Rails 8.0.5 stack).