inline_forms 8.0.3 → 8.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dbf71e495b41149f884052c32a5cfb1a0d01148c2cc957373e63803ac4bc7c00
-  data.tar.gz: 108b9f3bdd412bbff043bea5808a5920172a7c33f3ff126afa209684af33fb3e
+  metadata.gz: b3b934b94b7f4b5298dea2e2a51b8c97c37c06969a3484d528e336edf17ddfde
+  data.tar.gz: fedfafb7fba445712299b4c240fc905418c665d8f29e139c17cb9abc4138fe36
 SHA512:
-  metadata.gz: c10d87d29d229849facdb2b06e0403de7ad6cb0442eb3f10126dc723894b2c28a0cd1e0e76a3c4acad9a7e4efa3fd292bc53604293eb124cd99b0de1d76d45a8
-  data.tar.gz: 202650e4e15e768e585110e94f8901498f6ae718f35c47c2f81c9f18e94d38350fb1a4a3fbf8cc33b2f8976d90bd9db0daca322fdb901e1873afc13b6b3ca950
+  metadata.gz: b9d1abfecdf6fa9c75c4d79967e8604e0bb408a40a08475fb7106e12b0b301a437e8192f836a39b9b5c75261ac97d5dfade6f2ba5ecea9005015814bd257028f
+  data.tar.gz: 5f62f997de89dd93334a6324d2d02fe3bd283036d3f68ee39947cd400ab57f6d3a2d959745498d2b7f5e5c567889cd02e258ed7c15fef3cf3f051f3a21ee3d60

data/CHANGELOG.md

@@ -4,13 +4,61 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [8.1.0] - 2026-05-25
+
+### Added
+
+- **`ApplicationRecord` template carries shared model behavior:** `has_paper_trail on: [:create, :update, :destroy]`, `attr_writer :inline_forms_attribute_list`, `self.per_page = 7`, `human_attribute_name` instance wrapper, and `def self.not_accessible_through_html?` default. Generated models inherit all of this; `lib/generators/templates/model.erb` only emits per-model differences (associations, `inline_forms_attribute_list`, `_presentation`, `<=>`, `not_accessible_through_html?` override when `_enabled` is absent).
+- **`scope :inline_forms_list, -> { all }` and `scope :inline_forms_search, ->(_q) { all }`** on `ApplicationRecord`. Both are no-ops by default; subclasses opt in. Replaces the old `def self.order_by_clause` contract with composable Active Record relations.
+- **Generator flags `_list_order:col` and `_list_search:col`:** emit `scope :inline_forms_list, -> { order(:col, :id) }` and `scope :inline_forms_search, ->(q) { where("col LIKE ?", "%#{q}%") }` respectively. `_list_order` also still emits `def <=>(other)` for in-memory sort on associations (used by `check_list` show). Tie-break on `:id` is added automatically so will_paginate pages stay stable.
+- **`SPECIAL_GENERATOR_NAMES` constant** in `InlineForms::InlineFormsGenerator` consolidates `_presentation`, `_order`, `_list_order`, `_list_search`, `_enabled`, `_id`, `_no_migration`, `_no_model` so `migration?` / `attribute?` no longer drift.
+
+### Changed
+
+- **`order_by_clause` is gone from the gem.** `InlineFormsController#index` / `#create`, `check_list_helper.rb`, and `app/views/inline_forms/_list.html.erb` now compose `merge(@Klass.inline_forms_list)` and `merge(@Klass.inline_forms_search(params[:search]))` instead of building raw `"table.col"` strings. Search and order are now independent (one column had to do both jobs before); models can declare each separately or neither.
+- **Per-page pagination fix in `ApplicationRecord`:** `self.per_page = 7` (class-level, what will_paginate's `class_attribute :per_page` reads). The old `attr_reader :per_page` + `@per_page = 7` instance pair on every generated model was a no-op (described at length in 8.0.x notes); models that need a different value override with `self.per_page = N` (Photo uses `5`). The installer’s Photo override now uses `inject_into_class "app/models/photo.rb", "Photo", "  self.per_page = 5\n"` instead of patching the legacy `attr_reader` block out.
+- **`_order:col` is deprecated as an alias for `_list_order:col`.** Still works (emits the same scope plus `<=>`); the generator prints `say_status :deprecated, "_order:col is deprecated; use _list_order:col"` so existing scripts keep generating but the migration path is visible.
+- **Installer User model:** dropped `default_scope { order :name }` and the `def self.order_by_clause; nil; end` stub. Added `scope :inline_forms_list, -> { order(:name, :id) }` with a comment about why named scopes beat `default_scope` (no `unscope`/`reorder` foot-guns; cleaner `update_all` / association inheritance).
+- **Installer example-app generator calls** for `Locale`, `Role`, `Photo`, `Apartment`, `Owner` now pass `_list_order:name` (and `_list_search:name` for the searchable top-level models `Apartment` and `Owner`) to declare ordering and search explicitly. Replaces the implicit `order_by_clause = "name"` default that the old generator produced.
+
+### Removed
+
+- **`lib/generators/assets/javascripts/`** (including the empty `ckeditor/` subfolder). Leftover from the CKEditor era; nothing in the gem or installer copied from it. The engine still ships JS under `app/assets/javascripts/` and `vendor/assets/javascripts/`.
+- **`lib/generators/assets/stylesheets/inline_forms.scss`** mirror. The installer doesn't copy it; the gem stylesheet at `app/assets/stylesheets/inline_forms/inline_forms.scss` is the single source consumed via `@use "inline_forms/inline_forms"`. `inline_forms_devise.css` stays — it is the host-app override hook copied by the installer and linked from `layouts/devise.html.erb`.
+
+### Migration notes
+
+Existing apps upgrading from 8.0.x:
+
+1. Replace your `app/models/application_record.rb` with the contents of `lib/generators/templates/application_record.rb` (or just merge in the new `has_paper_trail`, `self.per_page`, `inline_forms_list` / `inline_forms_search` scopes, and `not_accessible_through_html?` default).
+2. For each model that had `def self.order_by_clause; "col"; end`, replace with `scope :inline_forms_list, -> { order(:col, :id) }`. Drop the old method; the gem no longer reads it.
+3. If you used `default_scope { order(:name) }` for inline_forms list ordering, swap to the named scope above.
+4. Per-model `attr_reader :per_page` / `@per_page = N` pairs are no-ops; replace with `self.per_page = N` (or remove and inherit `7` from `ApplicationRecord`).
+5. `_order:col` in your generator scripts still works but emits a deprecation notice; switch to `_list_order:col` and add `_list_search:col` if you want the search box to filter on that column.
+
+## [8.0.4] - 2026-05-24
+
+### Added
+
+- **`inline_forms create --user-model` (`-U`):** choose the Devise-backed model class (e.g. `Member`). Default remains `User`. Non-default models use `devise_for :users, class_name: "…", path: "…"` so Warden scope stays `:user` (`current_user`, `destroy_user_session_path`, etc.). Installer generates matching table, routes, controller, Locale/Role associations, HABTM join table (`members_roles`, etc.), seeds, Ability guest user, and `--example` test substitutions.
+
+### Changed
+
+- **`version_modified_by`:** resolves the auth model via `Devise.mappings[:users]` instead of hard-coding `User` (PaperTrail “modified by” on custom auth models).
+
 ## [8.0.3] - 2026-05-22
 
+### Added
+
+- **Rails 8 release docs (Phase 5):** [`docs/rails-8-release.md`](docs/rails-8-release.md) (gate results, stack table); [`docs/zeitwerk-and-load-paths.md`](docs/zeitwerk-and-load-paths.md) (intentional ignores vs autoloaded paths).
+- **Example app gate (recorded):** `inline_forms create MyApp -d sqlite --example` → **88 runs, 502 assertions, 0 failures**; `rails zeitwerk:check` → clean.
+
 ### Changed
 
 - **Rails 8 (Phase 4):** framework-defaults audit documented in [`docs/rails-8-phase4-audit.md`](docs/rails-8-phase4-audit.md); generated apps stay on `load_defaults 8.0` only (no `new_framework_defaults_8_0.rb`, matching `rails new` 8.0.5).
 - **Unicorn template:** `before_fork` uses `ActiveRecord::Base.connection_pool.disconnect!` (Rails 8–compatible).
 - **README.rdoc:** requirements table for Ruby 4 / Rails 8 / validation_hints 8; remove stale “broken after 6.2.14” notice; `rails-i18n ~> 8.0` narrative.
+- **`inline_forms.gemspec`:** summary/description updated for Rails 8 (remove stale “broken after 6.2.14” text).
 
 ## [8.0.2] - 2026-05-22
 

data/README.rdoc

@@ -30,6 +30,12 @@ If you want to install the example application:
 
  inline_forms create MyApp -d sqlite --example
 
+To use a different Devise model (e.g. +Member+ on a +members+ table) while keeping Warden scope +:user+ so +current_user+ works in inline_forms:
+
+ inline_forms create MyApp -d sqlite --example --user-model Member
+
+The installer emits +devise_for :users, class_name: "Member", path: "members"+ (sign-in at +/auth/members/sign_in+), +resources :members+, and the usual +authenticate_user!+ / +destroy_user_session_path+ helpers.
+
 Then point your browser to http://localhost:3000/apartments and log in with admin@example.com / admin999. The example also adds integration and model tests; run +bundle exec rails test+ in +MyApp+, then start the server with +bundle exec rails s+ when you want the UI.
 
 The example app now ships three models:

data/app/controllers/inline_forms_controller.rb

@@ -36,14 +36,12 @@ class InlineFormsController < ApplicationController
     @parent_class = params[:parent_class]
     @parent_id = params[:parent_id]
     @ul_needed = params[:ul_needed]
-    # if the parent_class is not nill, we are in associated list and we don't search there.
-    # also, make sure the Model that you want to do a search on has a :name attribute. TODO
-    conditions = nil
-    if @parent_class.nil? || @Klass.reflect_on_association(@parent_class.underscore.to_sym).nil?
-      conditions = [ @Klass.table_name + "." + @Klass.order_by_clause + " like ?", "%#{params[:search]}%" ] if @Klass.respond_to?(:order_by_clause) && ! @Klass.order_by_clause.nil?
-    else
+    # Nested associated lists scope to the parent FK. Top-level lists may
+    # apply the model's `inline_forms_search` scope when ?search= is passed.
+    fk_conditions = nil
+    if @parent_class.present? && @Klass.reflect_on_association(@parent_class.underscore.to_sym)
       foreign_key = @Klass.reflect_on_association(@parent_class.underscore.to_sym).options[:foreign_key] || @parent_class.foreign_key
-      conditions =  [ "#{foreign_key} = ?", @parent_id ]
+      fk_conditions = [ "#{foreign_key} = ?", @parent_id ]
     end
     # CanCan's load_and_authorize_resource sets @apartments (etc.); keep @objects in sync.
     collection_ivar = :"@#{controller_name}"
@@ -52,9 +50,13 @@ class InlineFormsController < ApplicationController
       @objects = loaded unless loaded.nil?
     end
     @objects ||= @Klass.accessible_by(current_ability) if cancan_enabled?
-    @objects ||= @Klass
-    @objects = @objects.order(@Klass.table_name + "." + @Klass.order_by_clause) if @Klass.respond_to?(:order_by_clause) && ! @Klass.order_by_clause.nil?
-    @objects = @objects.where(conditions).paginate(:page => params[:page])
+    @objects ||= @Klass.all
+    @objects = @objects.merge(@Klass.inline_forms_list) if @Klass.respond_to?(:inline_forms_list)
+    if fk_conditions.nil? && params[:search].present? && @Klass.respond_to?(:inline_forms_search)
+      @objects = @objects.merge(@Klass.inline_forms_search(params[:search]))
+    end
+    @objects = @objects.where(fk_conditions) if fk_conditions
+    @objects = @objects.paginate(:page => params[:page])
     respond_to do |format|
       # `not_accessible_through_html?` is about preventing direct top-level
       # HTML CRUD on this resource (e.g. /photos when only Apartment is the
@@ -139,22 +141,23 @@ class InlineFormsController < ApplicationController
     end
     @parent_class = params[:parent_class]
     @parent_id = params[:parent_id]
-    # for the logic behind the :conditions see the #index method.
-    conditions = nil
-    if @parent_class.nil? || @Klass.reflect_on_association(@parent_class.underscore.to_sym).nil?
-      conditions = [ @Klass.table_name + "." + @Klass.order_by_clause + " like ?", "%#{params[:search]}%" ] if @Klass.respond_to?(:order_by_clause) && ! @Klass.order_by_clause.nil?
-    else
+    # See #index for the order/search/parent-fk decomposition.
+    fk_conditions = nil
+    if @parent_class.present? && @Klass.reflect_on_association(@parent_class.underscore.to_sym)
       foreign_key = @Klass.reflect_on_association(@parent_class.underscore.to_sym).options[:foreign_key] || @parent_class.foreign_key
-      conditions =  [ "#{foreign_key} = ?", @parent_id ]
+      fk_conditions = [ "#{foreign_key} = ?", @parent_id ]
       @object[foreign_key] = @parent_id
     end
 
     if @object.save
       flash.now[:success] = t('success', :message => @object.class.model_name.human)
-      @objects = @Klass
-      @objects = @Klass.accessible_by(current_ability) if cancan_enabled?
-      @objects = @objects.order(@Klass.table_name + "." + @Klass.order_by_clause) if @Klass.respond_to?(:order_by_clause) && ! @Klass.order_by_clause.nil?
-      @objects = @objects.where(conditions).paginate(:page => params[:page])
+      @objects = cancan_enabled? ? @Klass.accessible_by(current_ability) : @Klass.all
+      @objects = @objects.merge(@Klass.inline_forms_list) if @Klass.respond_to?(:inline_forms_list)
+      if fk_conditions.nil? && params[:search].present? && @Klass.respond_to?(:inline_forms_search)
+        @objects = @objects.merge(@Klass.inline_forms_search(params[:search]))
+      end
+      @objects = @objects.where(fk_conditions) if fk_conditions
+      @objects = @objects.paginate(:page => params[:page])
       @object = nil
       respond_to do |format|
         format.html { render_list_frame_after_save } if html_list_flow_allowed?

data/app/helpers/inline_forms_helper.rb

@@ -347,9 +347,14 @@ module InlineFormsHelper
     values
   end
 
-  def version_modified_by id
-    user = User.find_by_id id
-    user.nil? ? 'Unknown' : user.name
+  def version_modified_by(id)
+    return "Unknown" if id.blank?
+
+    user_class = Devise.mappings[:users]&.to
+    return "Unknown" unless user_class
+
+    user = user_class.find_by(id: id)
+    user.nil? ? "Unknown" : user.name
   end
 
 end

data/app/views/inline_forms/_list.html.erb

@@ -34,9 +34,10 @@
     <% foreign_key = parent_class.reflect_on_association(attribute.to_sym).options[:foreign_key] || parent_class.name.foreign_key -%>
     <% model = attribute.to_s.singularize.camelcase.constantize %>
     <% conditions =  [ "#{model.table_name}.#{foreign_key} = ?", parent_id ] %>
+    <% klass = attribute.to_s.singularize.camelcase.constantize %>
     <% objects = parent_class.find(parent_id).send(attribute) %>
     <% objects = parent_class.find(parent_id).send(attribute).accessible_by(current_ability) if cancan_enabled? %>
-    <% objects = objects.order(attribute.to_s.singularize.camelcase.constantize.order_by_clause) if attribute.to_s.singularize.camelcase.constantize.respond_to?(:order_by_clause) && ! attribute.to_s.singularize.camelcase.constantize.order_by_clause.nil? %>
+    <% objects = objects.merge(klass.inline_forms_list) if klass.respond_to?(:inline_forms_list) %>
     <% objects = objects.where(conditions).paginate(:page => params[:page]) %>
   <% end %>
 <% end %>

data/inline_forms.gemspec

@@ -10,8 +10,8 @@ Gem::Specification.new do |s|
   s.authors     = ["Ace Suares", "Lemuel Boyce", "Manuel Ortega"]
   s.email       = ["ace@suares.com"]
   s.homepage    = %q{http://github.com/acesuares/inline_forms}
-  s.summary     = %q{Inline editing of forms. Versions after 6.2.14 are currently broken.}
-  s.description = %q{Inline Forms aims to ease the setup of forms that provide inline editing. The field list can be specified in the model. Versions after 6.2.14 are currently broken, and we will post a notice when the gem is good again.}
+  s.summary     = %q{Inline editing of forms for Rails 8.}
+  s.description = %q{Inline Forms eases setup of admin-style forms with inline editing. Field lists are declared on the model. Requires Rails 8.0.x, Ruby >= 4.0, and validation_hints ~> 8.}
   s.licenses    = ["MIT"]
   s.required_ruby_version = ">= 4.0.0"
 
@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
   s.test_files = s.files.grep(%r{^(test|spec|features)/})
   s.require_paths = ["lib"]
 
-  s.add_dependency("validation_hints", ">= 8.0.2", "< 9.0")
+  s.add_dependency("validation_hints", ">= 8.1.0", "< 9.0")
   s.add_dependency("rails", ">= 8.0", "< 8.1")
   s.add_dependency("rails-i18n", ">= 8.0", "< 9.0")
 

data/lib/generators/inline_forms_generator.rb

@@ -64,19 +64,26 @@ module InlineForms
         RELATIONS.has_key?(type) || special_relation?
       end
 
+      # Special "attribute" names that drive the generator (presentation,
+      # ordering, search, etc.) but never become real columns or fields.
+      SPECIAL_GENERATOR_NAMES = %w[
+        _presentation
+        _order
+        _list_order
+        _list_search
+        _enabled
+        _id
+        _no_migration
+        _no_model
+      ].freeze
+
       def migration?
         not ( column_type == :no_migration  ||
-            name == "_presentation"       ||
-            name == "_order"              ||
-            name == "_enabled"            ||
-            name == "_id" )
+            SPECIAL_GENERATOR_NAMES.include?(name) )
       end
 
       def attribute?
-        not ( name == '_presentation'       ||
-            name == '_order'              ||
-            name == '_enabled'            ||
-            name == "_id"                 ||
+        not ( SPECIAL_GENERATOR_NAMES.include?(name) ||
             relation? )
       end
 
@@ -126,10 +133,7 @@ module InlineForms
         @has_attached_files       = "\n"
         @presentation             = "\n"
         @order                    = "\n"
-        @order_by_clause          = "  def self.order_by_clause\n" +
-          "    \"name\"\n" +
-          "  end\n" +
-          "\n"
+        @list_scopes              = ""
         @carrierwave_mounters     = "\n"
         @inline_forms_attribute_list  = String.new
 
@@ -165,15 +169,23 @@ module InlineForms
               "  end\n" +
               "\n"
           end
-          if attribute.name == '_order'
+          # `_list_order:col` (preferred) and the legacy alias `_order:col`
+          # both emit the inline_forms_list scope plus a Ruby `<=>` for
+          # in-memory sort (used by check_list show on the association).
+          if attribute.name == '_order' || attribute.name == '_list_order'
+            if attribute.name == '_order'
+              say_status :deprecated,
+                         "_order:#{attribute.type} is deprecated; use _list_order:#{attribute.type}",
+                         :yellow
+            end
             @order <<         "  def <=>(other)\n" +
               "    self.#{attribute.type} <=> other.#{attribute.type}\n" +
               "  end\n" +
               "\n"
-            @order_by_clause = "  def self.order_by_clause\n" +
-              "    \"#{attribute.type}\"\n" +
-              "  end\n" +
-              "\n"
+            @list_scopes << "  scope :inline_forms_list, -> { order(:#{attribute.type}, :id) }\n"
+          end
+          if attribute.name == '_list_search'
+            @list_scopes << "  scope :inline_forms_search, ->(q) { where(\"#{attribute.type} LIKE ?\", \"%\#{q}%\") }\n"
           end
           if attribute.attribute?
             attribute.attribute_type == :unknown ? commenter = '#' : commenter = ' '

data/lib/generators/templates/application_record.rb

@@ -1,9 +1,41 @@
 class ApplicationRecord < ActiveRecord::Base
   self.abstract_class = true
 
+  # PaperTrail 16 defaults to `on: [:create, :update, :destroy, :touch]`.
+  # ActionText's `belongs_to :record, polymorphic: true, touch: true` (set by
+  # `has_rich_text`) calls `parent.touch` on every rich-text save, which
+  # produced a parent-side `update` version with an empty changeset — visible
+  # in the inline_forms versions panel as a meaningless "empty" row whose
+  # Restore link reifies the same state (no-op). Excluding `:touch` here
+  # suppresses that noise without affecting real attribute updates.
+  has_paper_trail on: [:create, :update, :destroy]
+
+  attr_writer :inline_forms_attribute_list
+
+  # will_paginate reads Klass.per_page (class level), not instance ivars.
+  self.per_page = 7
+
+  # Default list ordering for inline_forms #index/#create and nested
+  # associated lists. Subclasses override via
+  #   scope :inline_forms_list, -> { order(:col, :id) }
+  # (typically emitted by `rails g inline_forms <Model> _list_order:<col>`).
+  # `all` is a no-op so the gem adds no ORDER BY by default; pair with
+  # explicit named scopes rather than `default_scope` so callers can
+  # `unscope`/`reorder` cleanly.
+  scope :inline_forms_list, -> { all }
+
+  # Default list search; no-op so the gem's search box is inert until a model
+  # opts in via
+  #   scope :inline_forms_search, ->(q) { where("col LIKE ?", "%#{q}%") }
+  # (emitted by `_list_search:<col>` in the generator).
+  scope :inline_forms_search, ->(_q) { all }
+
   # Wrapper for @model.human_attribute_name -> Model.human_attribute_name
   def human_attribute_name(*args)
     self.class.human_attribute_name(*args)
   end
 
+  def self.not_accessible_through_html?
+    false
+  end
 end

data/lib/generators/templates/model.erb

@@ -1,15 +1,4 @@
 class <%= name %> < ApplicationRecord
-  attr_reader :per_page
-  @per_page = 7
-  attr_writer :inline_forms_attribute_list
-  # PaperTrail 16 defaults to `on: [:create, :update, :destroy, :touch]`.
-  # ActionText's `belongs_to :record, polymorphic: true, touch: true` (set by
-  # `has_rich_text`) calls `parent.touch` on every rich-text save, which
-  # produced a parent-side `update` version with an empty changeset — visible
-  # in the inline_forms versions panel as a meaningless "empty" row whose
-  # Restore link reifies the same state (no-op). Excluding `:touch` here
-  # suppresses that noise without affecting real attribute updates.
-  has_paper_trail on: [:create, :update, :destroy]
 <%= @carrierwave_mounters if @carrierwave_mounters.length > 1 -%>
 <%= @belongs_to if @belongs_to.length > 1 -%>
 <%= @has_many if @has_many.length > 1 -%>
@@ -17,14 +6,18 @@ class <%= name %> < ApplicationRecord
 <%= @habtm if @habtm.length > 1 -%>
 <%= @has_rich_text if @has_rich_text.length > 1 -%>
 <%= @has_attached_files if @has_attached_files.length > 1 -%>
+<% if @list_scopes && !@list_scopes.empty? -%>
+
+<%= @list_scopes -%>
+<% end -%>
 <%= @presentation  if @presentation.length > 1 -%>
 <%= @inline_forms_attribute_list -%>
 <%= @order  if @order.length > 1 -%>
+<% if @flag_not_accessible_through_html -%>
 
   def self.not_accessible_through_html?
-    <%= @flag_not_accessible_through_html %>
+    true
   end
-
-<%= @order_by_clause -%>
+<% end -%>
 
 end

data/lib/inline_forms/form_elements/check_list_helper.rb

@@ -19,11 +19,9 @@ module InlineForms
     
     def check_list_edit(object, attribute)
       object.send(attribute).build  if object.send(attribute).empty?
-      if cancan_enabled?
-        values = object.send(attribute).first.class.name.constantize.accessible_by(current_ability).order(attribute.to_s.singularize.camelcase.constantize.order_by_clause)
-      else
-        values = object.send(attribute).first.class.name.constantize.order(attribute.to_s.singularize.camelcase.constantize.order_by_clause)
-      end
+      klass = object.send(attribute).first.class
+      values = cancan_enabled? ? klass.accessible_by(current_ability) : klass.all
+      values = values.merge(klass.inline_forms_list) if klass.respond_to?(:inline_forms_list)
       out = ''
       values.each do | item |
         out << "<div class='row #{cycle('odd', 'even')}'>"

data/lib/inline_forms/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module InlineForms
-  VERSION = "8.0.3"
+  VERSION = "8.1.0"
 end

data/test/inline_forms_generator_test.rb

@@ -36,6 +36,12 @@ class InlineFormsGeneratorTest < Minitest::Test
     migration = read_single_migration_for("things")
 
     assert_includes(model, "class Thing < ApplicationRecord")
+    refute_includes(model, "has_paper_trail")
+    refute_includes(model, "attr_reader :per_page")
+    refute_includes(model, 'def self.not_accessible_through_html?')
+    refute_includes(model, "def self.order_by_clause")
+    refute_includes(model, "scope :inline_forms_list")
+    refute_includes(model, "scope :inline_forms_search")
     assert_includes(model, "belongs_to :category")
     assert_includes(model, "has_many :photos")
     assert_includes(model, "[ :name , \"name\", :text_field ]")
@@ -100,6 +106,61 @@ class InlineFormsGeneratorTest < Minitest::Test
     refute_includes(migration, "t.text :content")
   end
 
+  def test_not_accessible_and_list_order_emits_scope_and_spaceship
+    run_generator(
+      "Photo",
+      "name:string",
+      "album:belongs_to",
+      "_presentation:\\#{name}",
+      "_list_order:caption"
+    )
+
+    model = read("app/models/photo.rb")
+    assert_includes(model, "def self.not_accessible_through_html?\n    true")
+    assert_includes(model, "scope :inline_forms_list, -> { order(:caption, :id) }")
+    assert_includes(model, "def <=>(other)")
+    assert_includes(model, "self.caption <=> other.caption")
+    refute_includes(model, "def self.order_by_clause")
+    refute_includes(model, "has_paper_trail")
+  end
+
+  def test_legacy_order_alias_still_emits_scope_with_deprecation_warning
+    stdout, stderr = capture_io do
+      run_generator(
+        "Photo",
+        "name:string",
+        "_presentation:\\#{name}",
+        "_order:caption"
+      )
+    end
+
+    output = "#{stdout}#{stderr}"
+    assert_includes(output, "_order:caption is deprecated")
+    assert_includes(output, "_list_order:caption")
+
+    model = read("app/models/photo.rb")
+    assert_includes(model, "scope :inline_forms_list, -> { order(:caption, :id) }")
+    refute_includes(model, "def self.order_by_clause")
+  end
+
+  def test_list_search_emits_search_scope
+    run_generator(
+      "Apartment",
+      "name:string",
+      "_enabled:yes",
+      "_list_order:name",
+      "_list_search:name",
+      "_presentation:\\#{name}"
+    )
+
+    model = read("app/models/apartment.rb")
+    assert_includes(model, "scope :inline_forms_list, -> { order(:name, :id) }")
+    assert_includes(model, "scope :inline_forms_search, ->(q) { where(\"name LIKE ?\", \"%\#{q}%\") }")
+    migration = read_single_migration_for("apartments")
+    refute_includes(migration, "_list_order")
+    refute_includes(migration, "_list_search")
+  end
+
   def test_plain_text_generates_text_column_and_plain_text_form_element
     run_generator("Note", "title:string", "description:plain_text")
 

data/test/user_model_config_test.rb

@@ -0,0 +1,43 @@
+# -*- encoding : utf-8 -*-
+require "minitest/autorun"
+require "inline_forms_installer/user_model_config"
+
+class UserModelConfigTest < Minitest::Test
+  def test_default_user
+    cfg = InlineFormsInstaller::UserModelConfig.from_name("User")
+    assert cfg.default?
+    assert_equal "users", cfg.table_name
+    assert_equal "devise_for :users, :path_prefix => 'auth'", cfg.devise_route_line
+    assert_equal "/auth/users/sign_in", cfg.sign_in_path_fragment
+  end
+
+  def test_member
+    cfg = InlineFormsInstaller::UserModelConfig.from_name("Member")
+    refute cfg.default?
+    assert_equal "Member", cfg.class_name
+    assert_equal "members", cfg.table_name
+    assert_equal "member_id", cfg.foreign_key
+    assert_equal "members_roles", cfg.join_table
+    assert_equal "MembersController", cfg.controller_name
+    assert_includes cfg.devise_route_line, 'class_name: "Member"'
+    assert_includes cfg.devise_route_line, 'path: "members"'
+    assert_equal "/auth/members/sign_in", cfg.sign_in_path_fragment
+  end
+
+  def test_adapts_example_tests
+    cfg = InlineFormsInstaller::UserModelConfig.from_name("Member")
+    src = "user = User.find_or_initialize_by(email: \"admin@example.com\")\n"
+    assert_includes cfg.adapt_example_test_source(src), "Member.find_or_initialize_by"
+    guest = "assert_match %r{/auth/users/sign_in}, @response.redirect_url\n"
+    assert_includes cfg.adapt_example_test_source(guest), "/auth/members/sign_in"
+  end
+
+  def test_rejects_invalid_constant
+    assert_raises(ArgumentError) { InlineFormsInstaller::UserModelConfig.from_name("not-a-class") }
+  end
+
+  def test_from_env_defaults_to_user
+    env = { "user_model" => "" }
+    assert InlineFormsInstaller::UserModelConfig.from_env(env).default?
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 8.0.3
+  version: 8.1.0
 platform: ruby
 authors:
 - Ace Suares
@@ -17,7 +17,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 8.0.2
+        version: 8.1.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '9.0'
@@ -27,7 +27,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 8.0.2
+        version: 8.1.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '9.0'
@@ -85,9 +85,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.0'
-description: Inline Forms aims to ease the setup of forms that provide inline editing.
-  The field list can be specified in the model. Versions after 6.2.14 are currently
-  broken, and we will post a notice when the gem is good again.
+description: Inline Forms eases setup of admin-style forms with inline editing. Field
+  lists are declared on the model. Requires Rails 8.0.x, Ruby >= 4.0, and validation_hints
+  ~> 8.
 email:
 - ace@suares.com
 executables: []
@@ -492,16 +492,8 @@ files:
 - archived/form_elements/tree/app/helpers/form_elements/move.rb
 - archived/form_elements/tree/app/views/inline_forms/_show_tree.html.erb
 - archived/form_elements/tree/app/views/inline_forms/_tree.html.erb
-- docs/git-deps-assessment.md
-- docs/jquery-widgets.md
-- docs/prompt/.gitignore
-- docs/prompt/test-the-example-app.md
-- docs/rails-8-phase4-audit.md
-- docs/turbo-stream-audit.md
-- docs/ujs-to-turbo.md
 - inline_forms.gemspec
 - lib/generators/USAGE
-- lib/generators/assets/stylesheets/inline_forms.scss
 - lib/generators/assets/stylesheets/inline_forms_devise.css
 - lib/generators/inline_forms_generator.rb
 - lib/generators/templates/_inline_forms_tabs.html.erb
@@ -569,6 +561,7 @@ files:
 - test/inline_forms_generator_test.rb
 - test/plain_text_configuration_test.rb
 - test/test_helper.rb
+- test/user_model_config_test.rb
 - vendor/assets/javascripts/popper.min.js
 - vendor/assets/javascripts/tippy-bundle.umd.min.js
 - vendor/assets/stylesheets/tippy.css
@@ -592,7 +585,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 rubygems_version: 4.0.10
 specification_version: 4
-summary: Inline editing of forms. Versions after 6.2.14 are currently broken.
+summary: Inline editing of forms for Rails 8.
 test_files:
 - test/archived_form_elements_test.rb
 - test/form_element_from_callee_test.rb
@@ -600,3 +593,4 @@ test_files:
 - test/inline_forms_generator_test.rb
 - test/plain_text_configuration_test.rb
 - test/test_helper.rb
+- test/user_model_config_test.rb