inline_forms 8.0.2 → 8.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7678c685b9cc14f088b696037a582cc0214072597f29b66704ffb40b47ddece5
-  data.tar.gz: ae6e2d7efd33d4223c352c86d541d39be967a8fea67fa2bbf7e6fce353870bcb
+  metadata.gz: 83fc3ebab88e414806da9e2c7f9a47088eb1d69579f607af783e647f374ada2b
+  data.tar.gz: 76348168e6d35fb88a7142e66e92938ae6938b83cd606a894f1985c37c7cd219
 SHA512:
-  metadata.gz: c17abcf5d7d4d7c482ebce2f5ce0e65ee96ce99022dc6099a42002425bf9fb3dffc52eabb0a88b7ed41c243a3ddbd38d5bdae41b34edd63509a294c2ea1d7860
-  data.tar.gz: 7921ace1de20cad8132c7d62fc815c8de8bcc598b3a3634de4f291b4f01cae5714d44b7f69669906f80d32a0e9235aad9220e56e366bdccd60da8cf867e8469f
+  metadata.gz: d3d2b9b5a2cc0239857123cf16cd6605f58d27e324accddb8232015445767e3b06214c4c869d6089218b42aa72f737a11611d83abc3b53e731573ea628987944
+  data.tar.gz: 29d10dd86bb1c3bff98a5653b513de213e08250ab43b3fd3969e1aeaa71cd690f73f9034f51c64e775debeff69abd6180b5895867e7c4ca0a9aa10bda879fe07

data/CHANGELOG.md

@@ -4,6 +4,30 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [8.0.4] - 2026-05-24
+
+### Added
+
+- **`inline_forms create --user-model` (`-U`):** choose the Devise-backed model class (e.g. `Member`). Default remains `User`. Non-default models use `devise_for :users, class_name: "…", path: "…"` so Warden scope stays `:user` (`current_user`, `destroy_user_session_path`, etc.). Installer generates matching table, routes, controller, Locale/Role associations, HABTM join table (`members_roles`, etc.), seeds, Ability guest user, and `--example` test substitutions.
+
+### Changed
+
+- **`version_modified_by`:** resolves the auth model via `Devise.mappings[:users]` instead of hard-coding `User` (PaperTrail “modified by” on custom auth models).
+
+## [8.0.3] - 2026-05-22
+
+### Added
+
+- **Rails 8 release docs (Phase 5):** [`docs/rails-8-release.md`](docs/rails-8-release.md) (gate results, stack table); [`docs/zeitwerk-and-load-paths.md`](docs/zeitwerk-and-load-paths.md) (intentional ignores vs autoloaded paths).
+- **Example app gate (recorded):** `inline_forms create MyApp -d sqlite --example` → **88 runs, 502 assertions, 0 failures**; `rails zeitwerk:check` → clean.
+
+### Changed
+
+- **Rails 8 (Phase 4):** framework-defaults audit documented in [`docs/rails-8-phase4-audit.md`](docs/rails-8-phase4-audit.md); generated apps stay on `load_defaults 8.0` only (no `new_framework_defaults_8_0.rb`, matching `rails new` 8.0.5).
+- **Unicorn template:** `before_fork` uses `ActiveRecord::Base.connection_pool.disconnect!` (Rails 8–compatible).
+- **README.rdoc:** requirements table for Ruby 4 / Rails 8 / validation_hints 8; remove stale “broken after 6.2.14” notice; `rails-i18n ~> 8.0` narrative.
+- **`inline_forms.gemspec`:** summary/description updated for Rails 8 (remove stale “broken after 6.2.14” text).
+
 ## [8.0.2] - 2026-05-22
 
 ### Changed

data/README.rdoc

@@ -2,11 +2,11 @@
 
 Inline Forms is almost a complete admin application. You can try it out easily.
 
-= Release status notice
+= Requirements
 
-All gem versions after +6.2.14+ are currently broken.
-
-We will post a notice when the gem is good again.
+* Ruby **>= 4.0** (generated apps pin **ruby-4.0.4**)
+* Rails **8.0.x** (+rails ~> 8.0+, +config.load_defaults 8.0+)
+* **validation_hints** **~> 8** (companion gem; same version line as +inline_forms+ / +inline_forms_installer+)
 
 = Usage
 
@@ -14,7 +14,7 @@ The +inline_forms create+ CLI ships in the +inline_forms_installer+ gem (not in
 
  gem install inline_forms_installer
 
-Generated apps pin +inline_forms+ and +validation_hints+ at +~> 7+ (Bundler picks the latest 7.x). The three gems (+inline_forms+, +inline_forms_installer+, +validation_hints+) are released together with the same version number; use a current +inline_forms_installer+ so the installer template matches current Rails pins. To add the engine to an existing Rails app without the CLI:
+Generated apps pin +inline_forms+ and +validation_hints+ at +~> 8+ (Bundler picks the latest 8.x). The three gems (+inline_forms+, +inline_forms_installer+, +validation_hints+) are released together with the same version number; use a current +inline_forms_installer+ so the installer template matches current Rails pins. To add the engine to an existing Rails app without the CLI:
 
  gem install inline_forms inline_forms_installer
 
@@ -30,6 +30,12 @@ If you want to install the example application:
 
  inline_forms create MyApp -d sqlite --example
 
+To use a different Devise model (e.g. +Member+ on a +members+ table) while keeping Warden scope +:user+ so +current_user+ works in inline_forms:
+
+ inline_forms create MyApp -d sqlite --example --user-model Member
+
+The installer emits +devise_for :users, class_name: "Member", path: "members"+ (sign-in at +/auth/members/sign_in+), +resources :members+, and the usual +authenticate_user!+ / +destroy_user_session_path+ helpers.
+
 Then point your browser to http://localhost:3000/apartments and log in with admin@example.com / admin999. The example also adds integration and model tests; run +bundle exec rails test+ in +MyApp+, then start the server with +bundle exec rails s+ when you want the UI.
 
 The example app now ships three models:
@@ -246,7 +252,7 @@ In every case the Turbo wiring is the same: +link_options: { data: { turbo_frame
 
 == Generated application +rails-i18n+
 
-New apps get +rails-i18n+ from RubyGems (+ '~> 7.0'+), not from the +svenfuchs/rails-i18n+ Git repository. Release line 7.0.x declares +railties+ between 6 and 8, which matches the installer template’s pinned +rails ~> 7.2.3+ (with +config.load_defaults 7.2+). The upstream repository’s default branch is aimed at newer Rails and would pull in +railties+ 8+, which cannot be resolved together with that pin.
+New apps get +rails-i18n+ from RubyGems (+ '~> 8.0'+), not from the +svenfuchs/rails-i18n+ Git repository. The installer pins +rails ~> 8.0+ with +config.load_defaults 8.0+; the published +rails-i18n+ 8.x line matches that stack.
 
 == File uploads (CarrierWave)
 

data/app/helpers/inline_forms_helper.rb

@@ -347,9 +347,14 @@ module InlineFormsHelper
     values
   end
 
-  def version_modified_by id
-    user = User.find_by_id id
-    user.nil? ? 'Unknown' : user.name
+  def version_modified_by(id)
+    return "Unknown" if id.blank?
+
+    user_class = Devise.mappings[:users]&.to
+    return "Unknown" unless user_class
+
+    user = user_class.find_by(id: id)
+    user.nil? ? "Unknown" : user.name
   end
 
 end

data/docs/rails-8-phase4-audit.md

@@ -0,0 +1,39 @@
+# Rails 8 — Phase 4 audit (framework defaults & cleanup)
+
+**Date:** 2026-05-22  
+**Scope:** Post–Phase 3 (`inline_forms` 8.0.2 installer + example app gate).
+
+## 4.1 Framework defaults (`rails new` 8.0.5)
+
+Vanilla `rails _8.0.5_ new` (importmap, `--skip-bundle`):
+
+- `config/application.rb`: `config.load_defaults 8.0`, `config.autoload_lib(ignore: %w[assets tasks])`
+- Generator **removes** `config/initializers/new_framework_defaults_8_0.rb` (opt-in flags live only in the railties template until uncommented)
+- Optional 8.0 toggles (all commented in upstream template): `active_support.to_time_preserves_timezone`, `action_dispatch.strict_freshness`, `Regexp.timeout`
+
+**Installer decision:** Match vanilla Rails 8 — rely on `load_defaults 8.0` only; do **not** ship `new_framework_defaults_8_0.rb` in generated apps. Keep a belt-and-suspenders `gsub` to `load_defaults 8.0` if an older `rails new` left another minor.
+
+## 4.2 Rails 8 API / deprecation grep
+
+| Area | Result |
+|------|--------|
+| `form_with` / `model: nil` | No engine usage; inline fields use custom helpers / Turbo, not `form_with` |
+| `form_for` | Devise templates only (upstream Devise 5) |
+| `ActiveRecord::Base.connection` | Unicorn `before_fork` template updated → `connection_pool.disconnect!` |
+| `ActionController` deprecated flags | None in `lib/` |
+| Generator migrations | `ActiveRecord::Migration[8.0]` (tests assert) |
+
+## 4.3 Dart Sass / SCSS
+
+Foundation + engine SCSS still emit Dart Sass 1.x deprecation warnings during `dartsass:build`. Accepted for 8.0 ship; migrate to `@use` / `color.scale` before Dart Sass 3.0 (see `stuff/pipeline.md`).
+
+## 4.4 bundler-audit
+
+| Lockfile | Result (2026-05-22) |
+|----------|---------------------|
+| `validation_hints/Gemfile.lock` | No vulnerabilities found |
+| Example app `MyApp/Gemfile.lock` | No vulnerabilities found (`bundler-audit` on default gemset) |
+
+## 4.5 Example app gate (unchanged baseline)
+
+`inline_forms create MyApp -d sqlite --example` → **88 runs, 502 assertions, 0 failures, 0 errors, 0 skips** (Phase 3, Rails 8.0.5 stack).

data/docs/rails-8-release.md

@@ -0,0 +1,56 @@
+# Rails 8.0 release (8.0.x line)
+
+**Shipped:** 2026-05-22  
+**Tags:** `v8.0.3` (inline_forms, inline_forms_installer, validation_hints)
+
+## Stack
+
+| Component | Constraint |
+|-----------|------------|
+| Ruby | `>= 4.0` (generated apps: `ruby-4.0.4`) |
+| Rails | `>= 8.0`, `< 8.1` |
+| rails-i18n | `>= 8.0`, `< 9.0` |
+| validation_hints | `>= 8.0.2`, `< 9.0` (release **8.0.3** lockstep) |
+
+Install CLI:
+
+```bash
+gem install inline_forms_installer
+inline_forms create MyApp -d sqlite --example
+```
+
+Pre-release local builds: installer auto-installs `*.gem` from `~/inline_forms` / `~/validation_hints` when present (no `path:` in consumer Gemfiles).
+
+## Verification gate (2026-05-22)
+
+| Check | Result |
+|-------|--------|
+| validation_hints `rake test` | 24 runs, 50 assertions, 0 failures |
+| inline_forms `rake test` | 24 runs, 89 assertions, 0 failures |
+| `inline_forms create MyApp -d sqlite --example` | OK (Rails 8.0.5) |
+| `bundle exec rails zeitwerk:check` | All is good! |
+| `bundle exec rails test` (MyApp) | **88 runs, 502 assertions, 0 failures, 0 errors, 0 skips** |
+| `bundler-audit` (validation_hints lockfile) | No vulnerabilities found |
+
+## Migration phases (maintainer runbook)
+
+Canonical step-by-step: `stuff/rails8forReal.md` (local; gitignored in this repo). Mirror checklist: `validation_hints/stuff/rails-8-checklist.md`.
+
+| Phase | Status |
+|-------|--------|
+| 0 Baseline | Done |
+| 1 validation_hints → AR 8 | Done (8.0.1+) |
+| 2 inline_forms engine → Rails 8 | Done (8.0.1+) |
+| 3 Installer + example app | Done (8.0.2+) |
+| 4 Framework defaults + audit | Done (8.0.3) — [`rails-8-phase4-audit.md`](rails-8-phase4-audit.md) |
+| 5 Release + docs | Done (8.0.3) — this file |
+
+## Zeitwerk
+
+See [`zeitwerk-and-load-paths.md`](zeitwerk-and-load-paths.md). No remaining active code on pre-Zeitwerk `app/helpers/form_elements/` paths.
+
+## Deferred
+
+- Dart Sass 3.0 (`@import` removal) — not released; deprecations only on Dart Sass 1.x
+- [`stuff/towards_rails_8.md`](../stuff/towards_rails_8.md) product bets (auth, encryption, …) — post-ship
+- Asset pipeline (`stuff/pipeline.md`) — orthogonal

data/docs/zeitwerk-and-load-paths.md

@@ -0,0 +1,49 @@
+# Zeitwerk and load paths (inline_forms + validation_hints)
+
+**Last verified:** 2026-05-22 — `bundle exec rails zeitwerk:check` on a fresh **`inline_forms create MyApp -d sqlite --example`** app (Rails **8.0.5**): **All is good!**
+
+## inline_forms engine
+
+### Autoloaded by Zeitwerk (host app eager load)
+
+Under the engine’s `app/` tree:
+
+- `app/controllers/` — `InlineFormsController`, concerns
+- `app/helpers/inline_forms_helper.rb`
+- `app/models/concerns/inline_forms/soft_deletable.rb`
+- `app/validators/*` — custom validators
+
+### Intentionally **not** Zeitwerk-autoloaded
+
+| Path | Mechanism | Why |
+|------|-----------|-----|
+| `lib/inline_forms/form_elements/*_helper.rb` | `Rails.autoloaders.main.ignore` + `FormElements.load_helpers!` (`Dir[]` + `require`) | Historical top-level helper method names (`text_field_show`, …); `_helper.rb` filenames do not map to Zeitwerk constants |
+| `lib/inline_forms.rb` boot | Explicit `require` of version, registry, `form_elements`, `turbo_tabs_builder`, `archived_form_elements` | Boot order before engine initializers |
+| `lib/generators/` | Rails generator autoload | Not part of host app Zeitwerk |
+| `archived/form_elements/` | Not required | Legacy project-specific elements; registry blocks use in `inline_forms_attribute_list` |
+
+Track B migration (7.13.x): moved active elements from `app/helpers/form_elements/*.rb` to `lib/inline_forms/form_elements/*_helper.rb`. See `CHANGELOG.md` (Zeitwerk / form elements).
+
+### Nothing left on the old path
+
+There is **no** `app/helpers/form_elements/` in the shipped gem (only under `archived/`).
+
+## validation_hints
+
+| Path | Mechanism | Why |
+|------|-----------|-----|
+| `lib/active_model/hints.rb` | Explicit `require` in `lib/validation_hints.rb` | Defines `ActiveModel::Hints` in the `ActiveModel` namespace (collapse); not under `validation_hints/` |
+| `lib/validation_hints/validations_patch.rb` | Explicit `require` | Patches applied via `ActiveSupport.on_load(:active_model)` |
+| `lib/validation_hints/railtie.rb` | Loaded when `Rails::Railtie` is defined | Standard gem entry |
+
+Non-Rails use: `require "validation_hints"` loads hints + patch + I18n without Zeitwerk.
+
+## Host app checklist
+
+After upgrading or generating an app:
+
+```bash
+cd MyApp && rvm use . && bundle exec rails zeitwerk:check
+```
+
+If you vendor custom form-element helpers into the host app, keep them under `app/helpers/` with Zeitwerk-friendly names or add `config.autoload_lib` / ignores as needed.

data/inline_forms.gemspec

@@ -10,8 +10,8 @@ Gem::Specification.new do |s|
   s.authors     = ["Ace Suares", "Lemuel Boyce", "Manuel Ortega"]
   s.email       = ["ace@suares.com"]
   s.homepage    = %q{http://github.com/acesuares/inline_forms}
-  s.summary     = %q{Inline editing of forms. Versions after 6.2.14 are currently broken.}
-  s.description = %q{Inline Forms aims to ease the setup of forms that provide inline editing. The field list can be specified in the model. Versions after 6.2.14 are currently broken, and we will post a notice when the gem is good again.}
+  s.summary     = %q{Inline editing of forms for Rails 8.}
+  s.description = %q{Inline Forms eases setup of admin-style forms with inline editing. Field lists are declared on the model. Requires Rails 8.0.x, Ruby >= 4.0, and validation_hints ~> 8.}
   s.licenses    = ["MIT"]
   s.required_ruby_version = ">= 4.0.0"
 
@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
   s.test_files = s.files.grep(%r{^(test|spec|features)/})
   s.require_paths = ["lib"]
 
-  s.add_dependency("validation_hints", ">= 8.0.1", "< 9.0")
+  s.add_dependency("validation_hints", ">= 8.0.4", "< 9.0")
   s.add_dependency("rails", ">= 8.0", "< 8.1")
   s.add_dependency("rails-i18n", ">= 8.0", "< 9.0")
 

data/lib/inline_forms/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module InlineForms
-  VERSION = "8.0.2"
+  VERSION = "8.0.4"
 end

data/test/user_model_config_test.rb

@@ -0,0 +1,43 @@
+# -*- encoding : utf-8 -*-
+require "minitest/autorun"
+require "inline_forms_installer/user_model_config"
+
+class UserModelConfigTest < Minitest::Test
+  def test_default_user
+    cfg = InlineFormsInstaller::UserModelConfig.from_name("User")
+    assert cfg.default?
+    assert_equal "users", cfg.table_name
+    assert_equal "devise_for :users, :path_prefix => 'auth'", cfg.devise_route_line
+    assert_equal "/auth/users/sign_in", cfg.sign_in_path_fragment
+  end
+
+  def test_member
+    cfg = InlineFormsInstaller::UserModelConfig.from_name("Member")
+    refute cfg.default?
+    assert_equal "Member", cfg.class_name
+    assert_equal "members", cfg.table_name
+    assert_equal "member_id", cfg.foreign_key
+    assert_equal "members_roles", cfg.join_table
+    assert_equal "MembersController", cfg.controller_name
+    assert_includes cfg.devise_route_line, 'class_name: "Member"'
+    assert_includes cfg.devise_route_line, 'path: "members"'
+    assert_equal "/auth/members/sign_in", cfg.sign_in_path_fragment
+  end
+
+  def test_adapts_example_tests
+    cfg = InlineFormsInstaller::UserModelConfig.from_name("Member")
+    src = "user = User.find_or_initialize_by(email: \"admin@example.com\")\n"
+    assert_includes cfg.adapt_example_test_source(src), "Member.find_or_initialize_by"
+    guest = "assert_match %r{/auth/users/sign_in}, @response.redirect_url\n"
+    assert_includes cfg.adapt_example_test_source(guest), "/auth/members/sign_in"
+  end
+
+  def test_rejects_invalid_constant
+    assert_raises(ArgumentError) { InlineFormsInstaller::UserModelConfig.from_name("not-a-class") }
+  end
+
+  def test_from_env_defaults_to_user
+    env = { "user_model" => "" }
+    assert InlineFormsInstaller::UserModelConfig.from_env(env).default?
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 8.0.2
+  version: 8.0.4
 platform: ruby
 authors:
 - Ace Suares
@@ -17,7 +17,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 8.0.1
+        version: 8.0.4
     - - "<"
       - !ruby/object:Gem::Version
         version: '9.0'
@@ -27,7 +27,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 8.0.1
+        version: 8.0.4
     - - "<"
       - !ruby/object:Gem::Version
         version: '9.0'
@@ -85,9 +85,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.0'
-description: Inline Forms aims to ease the setup of forms that provide inline editing.
-  The field list can be specified in the model. Versions after 6.2.14 are currently
-  broken, and we will post a notice when the gem is good again.
+description: Inline Forms eases setup of admin-style forms with inline editing. Field
+  lists are declared on the model. Requires Rails 8.0.x, Ruby >= 4.0, and validation_hints
+  ~> 8.
 email:
 - ace@suares.com
 executables: []
@@ -496,8 +496,11 @@ files:
 - docs/jquery-widgets.md
 - docs/prompt/.gitignore
 - docs/prompt/test-the-example-app.md
+- docs/rails-8-phase4-audit.md
+- docs/rails-8-release.md
 - docs/turbo-stream-audit.md
 - docs/ujs-to-turbo.md
+- docs/zeitwerk-and-load-paths.md
 - inline_forms.gemspec
 - lib/generators/USAGE
 - lib/generators/assets/stylesheets/inline_forms.scss
@@ -568,6 +571,7 @@ files:
 - test/inline_forms_generator_test.rb
 - test/plain_text_configuration_test.rb
 - test/test_helper.rb
+- test/user_model_config_test.rb
 - vendor/assets/javascripts/popper.min.js
 - vendor/assets/javascripts/tippy-bundle.umd.min.js
 - vendor/assets/stylesheets/tippy.css
@@ -591,7 +595,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 rubygems_version: 4.0.10
 specification_version: 4
-summary: Inline editing of forms. Versions after 6.2.14 are currently broken.
+summary: Inline editing of forms for Rails 8.
 test_files:
 - test/archived_form_elements_test.rb
 - test/form_element_from_callee_test.rb
@@ -599,3 +603,4 @@ test_files:
 - test/inline_forms_generator_test.rb
 - test/plain_text_configuration_test.rb
 - test/test_helper.rb
+- test/user_model_config_test.rb