inline_forms 7.5.2 → 7.9.1

data/bin/inline_forms_installer_core.rb

@@ -57,7 +57,6 @@ gem 'rails-i18n', '~> 7.0'
 gem 'rails-jquery-autocomplete'
 gem 'rails', '~> 7.0.0'
 gem 'rake'
-gem 'remotipart', '~> 1.0'
 gem 'rvm'
 gem 'dartsass-rails'
 # Rails 7 no longer adds sprockets-rails to the default Gemfile; declare it
@@ -66,10 +65,9 @@ gem 'dartsass-rails'
 gem 'sprockets-rails'
 # Rails 7 default JavaScript tooling: importmap-rails replaces Webpacker.
 gem 'importmap-rails'
-# Hotwire/Turbo. Loaded into the Sprockets bundle by inline_forms.js with
-# Turbo Drive disabled by default so existing UJS-driven links/forms keep
-# working; turbo-rails also registers the `turbo_stream` Mime type and view
-# format so future controllers can opt in to Turbo Stream responses.
+# Hotwire/Turbo. Loaded from layouts as `<script type="module">`; inline flows
+# use `<turbo-frame>` + HTML responses (see docs/ujs-to-turbo.md). Registers the
+# `turbo_stream` MIME type for optional stream responses.
 gem 'turbo-rails'
 gem 'tabs_on_rails', :git => 'https://github.com/acesuares/tabs_on_rails.git', :branch => 'update_remote_before_action'
 gem 'unicorn'
@@ -682,6 +680,73 @@ if ENV['install_example'] == 'true'
   run 'bundle exec rails generate uploader Image'
   run 'bundle exec rails g inline_forms Apartment name:string title:string description:rich_text photos:has_many photos:associated _enabled:yes _presentation:\'#{name}\''
 
+  say "- Apartment name is required..."
+  inject_into_file "app/models/apartment.rb",
+                   "\n  validates :name, presence: true\n",
+                   after: "  has_paper_trail\n"
+
+  # CarrierWave + PaperTrail history.
+  # PaperTrail snapshots the column scalar (the stored filename) on update,
+  # but CarrierWave's default `remove_previously_stored_files_after_update`
+  # deletes the old file on disk and re-uses the same filename, so a
+  # PaperTrail revert restores a filename whose bytes are gone.
+  # We keep every uploaded file on disk and namespace filenames with a
+  # per-upload token so successive uploads do not collide. See
+  # https://stackoverflow.com/questions/9423279/papertrail-and-carrierwave
+  # (Answers 2, 4 and 5).
+  say "- Configuring CarrierWave to keep previously stored files (PaperTrail history)..."
+  create_file "config/initializers/carrierwave.rb", <<-CWINIT.strip_heredoc
+    # Keep previously stored files on disk so PaperTrail-driven restore
+    # actually returns the previous image bytes. See
+    # https://stackoverflow.com/questions/9423279/papertrail-and-carrierwave
+    # The per-uploader overrides in app/uploaders/image_uploader.rb
+    # complement this by giving every upload a unique on-disk filename
+    # and by no-op'ing `remove!` so destroyed records keep their files.
+    CarrierWave.configure do |config|
+      config.remove_previously_stored_files_after_update = false
+    end
+  CWINIT
+
+  inject_into_file "app/uploaders/image_uploader.rb",
+                   after: "class ImageUploader < CarrierWave::Uploader::Base\n" do
+    <<-RUBY.strip_heredoc.gsub(/^/, "  ")
+      # PaperTrail history support. CarrierWave's default behaviour wipes the
+      # previous file on update and reuses the same filename; PaperTrail only
+      # stores the column scalar, so a plain `version.reify; save!` restores a
+      # filename whose bytes are gone. The knobs below preserve every byte:
+      #
+      #   * `remove_previously_stored_files_after_update = false` is set
+      #     globally in config/initializers/carrierwave.rb (covers
+      #     `multi_image_field` uploaders too).
+      #   * `remove!` is a no-op so hard-destroyed records keep their files
+      #     and revert-after-destroy still finds the bytes on disk.
+      #   * `filename` is prefixed with a per-upload UUID so successive
+      #     uploads never collide on disk.
+      #
+      # Trade-off: files accumulate on disk; sweeping is out of scope.
+      # Source: https://stackoverflow.com/questions/9423279/papertrail-and-carrierwave
+      def remove!
+        # no-op: keep the file so PaperTrail revert can restore it.
+      end
+
+      def filename
+        # CarrierWave 3.x calls `filename` again after storing to record the
+        # persisted name; at that point `original_filename` may be nil and we
+        # must still return the memoized name (see
+        # https://github.com/carrierwaveuploader/carrierwave/issues/2708).
+        @name ||= "\#{secure_token}-\#{original_filename}" if original_filename
+        @name
+      end
+
+      private
+
+      def secure_token
+        var = :"@\#{mounted_as}_secure_token"
+        model.instance_variable_get(var) || model.instance_variable_set(var, SecureRandom.uuid)
+      end
+    RUBY
+  end
+
   say "- Lower Photo.per_page so the seeded gallery paginates..."
   # The model template (lib/generators/templates/model.erb) emits
   #   attr_reader :per_page

data/docs/ujs-to-turbo.md

@@ -2,11 +2,11 @@
 
 Track progress toward full Turbo integration and removal of jQuery UJS from inline_forms generated apps.
 
-**Current gem version:** see `lib/inline_forms/version.rb` (Step 3 complete in **7.5.0** except tree-related `*.js.erb` — Step 4)
+**Current gem version:** see `lib/inline_forms/version.rb` (**Step 5** — Turbo Drive on, jquery-ujs / remotipart removed in **7.8.0**)
 
-**Architecture today:** almost every inline interaction is `remote: true` → `format.js` → `*.js.erb` doing `$('#<update_span>').html(...)`. Turbo is loaded as an ES module with **`Turbo.session.drive = false`**. One vertical slice (nested has_many list pagination) uses **`<turbo-frame>`**.
+**Architecture today:** inline interactions use **`<turbo-frame>`** + **`format.html`** (and optional **`format.turbo_stream`**). Turbo loads as an ES module from the layouts; **Turbo Drive** uses the library default (**enabled**). No `*.js.erb` in active engine views; no `jquery_ujs` or `jquery.remotipart` in the Sprockets bundle.
 
-**Target end state:** Turbo Frames/Streams for all swaps; **`format.html`** / **`format.turbo_stream`** responses; no `*.js.erb`; no `jquery_ujs` or `jquery.remotipart`; Drive enabled.
+**Target end state:** Stock flows use Turbo Frames + HTML; optional `turbo_stream` where it simplifies a response. jQuery UJS and `*.js.erb` are gone from the engine.
 
 ---
 
@@ -14,7 +14,7 @@ Track progress toward full Turbo integration and removal of jQuery UJS from inli
 
 - [x] `gem 'turbo-rails'` in installer Gemfile (`bin/inline_forms_installer_core.rb`)
 - [x] Turbo loaded as `<script type="module">` in `layouts/inline_forms.html.erb` and `layouts/application.html.erb`
-- [x] `Turbo.session.drive = false` (UJS still owns navigation)
+- [x] `Turbo.session.drive` uses the **default (enabled)** — **7.8.0** (was disabled while UJS coexisted)
 - [x] Turbo **not** in Sprockets bundle (`app/assets/javascripts/inline_forms/inline_forms.js`) — ESM parse-error lesson from 7.1.1
 - [x] Smoke test: `lib/installer_templates/example_app_tests/test/integration/example_app_turbo_layout_test.rb`
 
@@ -47,12 +47,12 @@ Convert the **`show → edit → update → show_element → close`** cycle with
 
 - [x] Wrap each top-level list row in `<turbo-frame id="apartment_<id>">` (`_list.html.erb` when `parent_class` is nil)
 - [x] Row title link: GET `show` → HTML `row_show` / `_show` inside frame (no `:remote`; `data-turbo` + `data-turbo-frame`)
-- [x] `InlineFormsController#show` (full record, no `params[:attribute]`): `format.html` → `row_show` / `row_close` + `turbo_rails/frame` when `turbo_frame_request?`, else full `inline_forms` layout; `format.js` still renders `show.js.erb` / `close.js.erb` for legacy callers
+- [x] `InlineFormsController#show` (full record, no `params[:attribute]`): `format.html` → `row_show` / `row_close` + `turbo_rails/frame` when `turbo_frame_request?`, else full `inline_forms` layout
 - [x] `close_link` and `_close` presentation link: Turbo when `@inline_forms_turbo_row` (row HTML path)
-- [x] `soft_delete`, `soft_restore`, `destroy`, `revert`: `format.html` → `row_close` / `row_destroyed` (+ Turbo toolbar links); `format.js` kept for non-frame callers only
+- [x] `soft_delete`, `soft_restore`, `destroy`, `revert`: `format.html` → `row_close` / `row_destroyed` (+ Turbo toolbar links)
 - [x] Remove `edit.js.erb`, `update.js.erb`, `show_element.js.erb` (field lifecycle is Turbo HTML only)
-- [ ] Remove `show.js.erb`, `close.js.erb`, `record_destroyed.js.erb`, `show_undo.js.erb` — **`_tree.html.erb` still uses UJS row open (Step 4)**
-- [x] Remove `:remote => true` from nested `_list` / `_close` / toolbar where migrated (row toolbar, versions, nested `+` use Turbo; `_tree` / top-level `new` UJS deferred to Step 4)
+- [x] Remove `show.js.erb`, `close.js.erb`, `record_destroyed.js.erb`, `show_undo.js.erb` (7.7.0; tree migrated)
+- [x] Remove `:remote => true` from nested `_list` / `_close` / toolbar where migrated (row toolbar, versions, nested `+` use Turbo; top-level `new` was Step 4)
 - [x] Remove `data-turbo="false"` from nested rows once nested inline-edit is Turbo-native (7.4.2)
 
 ### Nested associated lists (e.g. Apartment → Photo)
@@ -77,7 +77,7 @@ Convert the **`show → edit → update → show_element → close`** cycle with
 
 ### Helpers (`app/helpers/inline_forms_helper.rb`)
 
-- [x] `close_link`, `link_to_soft_delete`, `link_to_destroy`, `link_to_new_record`, `link_to_versions_list`, `close_versions_list_link`: Turbo when `turbo_row:` (default **true**); legacy `remote: true` only when `turbo_row: false`
+- [x] `close_link`, `link_to_soft_delete`, `link_to_destroy`, `link_to_new_record`, `link_to_versions_list`, `close_versions_list_link`: Turbo frame attrs only (**7.8.0**; `turbo_row:` retained for API compat)
 
 ### Tests
 
@@ -96,49 +96,48 @@ Convert the **`show → edit → update → show_element → close`** cycle with
 
 ### Lists and create flow
 
-- [ ] Top-level index: wrap in `<turbo-frame id="apartments_list">`; in-frame pagination
-- [ ] `new` / `create`: frame refresh or stream replacing list container
-- [ ] Remove `new.js.erb`, `list.js.erb` (keep `format.js` only until Step 5 if needed for overlap)
-- [ ] `_new.html.erb`: drop `:remote => true`
+- [x] Top-level index: wrap in `<turbo-frame id="apartments_list">`; in-frame pagination (7.7.0)
+- [x] `new` / `create`: frame refresh replacing list container (7.7.0)
+- [x] Remove `new.js.erb`, `list.js.erb` (7.7.0)
+- [x] `_new.html.erb`: Turbo path when `@turbo_frame` (no `:remote` on cancel)
 
 ### Tree
 
-- [ ] `_tree.html.erb`: same frame pattern as `_list`; remote pagination → frame pagination
-- [ ] Remove tree-related UJS if any dedicated `*.js.erb` remain
+- [x] ~~`:tree` / `_tree.html.erb`~~ — **archived in 7.7.0** (`archived/form_elements/tree/`); needs host tree gem/APIs. Turbo-ready partial kept in archive.
 
 ### Versions panel
 
-- [ ] `VersionsConcern#list_versions`: HTML frame / stream
-- [ ] Remove `versions.js.erb`, `versions_list.js.erb`
-- [ ] `_versions_list.html.erb`: drop `:remote => true` on revert links (or stream revert)
+- [x] `VersionsConcern#list_versions`: HTML frame (`versions_panel` / `versions_list_panel`, `turbo_rails/frame` layout) — **7.7.3** drops `format.js`
+- [x] Remove `versions.js.erb`, `versions_list.js.erb` (**7.7.3**)
+- [x] `_versions_list.html.erb`: revert uses `inline_forms_turbo_link_data` (row frame), not `:remote => true`
 
 ### Geo / misc
 
-- [ ] `geo_code_curacao/list_streets.js.erb`: frame or stream for street dropdown
+- [x] ~~`geo_code_curacao`~~ — **archived in 7.6.0** (`archived/form_elements/geo_code_curacao/`). If restored, migrate `list_streets.js.erb` to frame or stream.
 
 ### Controller cleanup
 
-- [ ] Every action in `InlineFormsController` + `VersionsConcern` has a non-JS response path
-- [ ] Audit `respond_to` blocks: parallel `format.turbo_stream` where stream is cleaner than full frame
+- [x] Every action in `InlineFormsController` + `VersionsConcern` has a non-JS response path (**7.8.0** audit)
+- [ ] Audit `respond_to` blocks: parallel `format.turbo_stream` where stream is cleaner than full frame (optional)
 
 ### Tests
 
-- [ ] Top-level list pagination in frame
-- [ ] Create apartment → list frame updates
-- [ ] Versions panel open/close
-- [ ] Assert zero `data-remote="true"` in rendered HTML for inline_forms flows
+- [x] Top-level list pagination in frame (`example_app_apartment_top_level_pagination_test.rb`)
+- [x] Create apartment → list frame updates (`example_app_apartment_top_level_new_test.rb`)
+- [x] Versions panel open/close + revert from list (`example_app_apartment_versions_turbo_test.rb`, **7.7.3**)
+- [x] Assert zero `data-remote="true"` in rendered HTML for inline_forms flows (helpers + `_new` / `_close` no longer fall back to UJS — **7.8.0**)
 
 ---
 
-## Step 5 — Enable Drive, remove UJS
+## Step 5 — Enable Drive, remove UJS (DONE in **7.8.0**)
 
-- [ ] Remove `Turbo.session.drive = false` from both layouts
-- [ ] Delete `//= require jquery_ujs` from `inline_forms.js`
-- [ ] Delete `//= require jquery.remotipart` from `inline_forms.js`
-- [ ] Delete all `app/views/inline_forms/*.js.erb` (and geo `list_streets.js.erb`)
-- [ ] Remove `format.js` branches from controllers (or empty stubs, then delete)
-- [ ] Update `example_app_turbo_layout_test.rb`: Drive enabled (or line removed)
-- [ ] Full `bundle exec rails test` in `--example` app
+- [x] Remove `Turbo.session.drive = false` from both layouts (Drive default **on**)
+- [x] Delete `//= require jquery_ujs` from `inline_forms.js`
+- [x] Delete `//= require jquery.remotipart` from `inline_forms.js`
+- [x] Delete all `app/views/inline_forms/*.js.erb` (completed by **7.7.3**)
+- [x] Remove `format.js` branches from controllers (none remain on stock actions)
+- [x] Update `example_app_turbo_layout_test.rb`: refute `Turbo.session.drive = false`
+- [x] Full `bundle exec rails test` in `--example` app (before release)
 
 ### jQuery (optional follow-up — not required to drop UJS)
 
@@ -166,13 +165,13 @@ These can remain while UJS is gone; separate migration if desired:
 | `close.js.erb` | Fade + `_close` partial |
 | `record_destroyed.js.erb` | Fade out row |
 | `show_undo.js.erb` | Undo link after destroy |
-| `versions.js.erb` | Fade + versions partial |
-| `versions_list.js.erb` | Versions table |
-| `geo_code_curacao/list_streets.js.erb` | Street list dropdown |
+| ~~`versions.js.erb`~~ | Removed **7.7.3** — versions panel HTML frame |
+| ~~`versions_list.js.erb`~~ | Removed **7.7.3** — versions list HTML frame |
+| ~~`geo_code_curacao/list_streets.js.erb`~~ | Archived 7.6.0 — street autocomplete JSON |
 
 ### Controller actions still on `format.js`
 
-`index`, `show`, `edit`, `update`, `new`, `create`, `soft_delete`, `soft_restore`, `destroy`, `revert`, `list_versions`
+None on `InlineFormsController` / `VersionsConcern` stock actions (**7.8.0**). Host app controllers may still use `format.js`.
 
 ### Key files
 

data/lib/generators/assets/stylesheets/inline_forms.scss

@@ -224,13 +224,14 @@ select:hover, select:focus {
   font-size: 110%;
 }
 // Custom elements default to `display: inline`, which collapses the row layout
-// of an empty/just-mounted top-level `<turbo-frame id="apartments_list">` and
-// hides its rows under the fixed top bar. Force block layout so frames behave
-// like the legacy `<div class="list_container">` and `<div class="row">` they
-// replaced (see app/views/inline_forms/_list.html.erb).
+// of a top-level `<turbo-frame id="apartments_list">` inside `#outer_container`.
 turbo-frame {
   display: block;
 }
+#outer_container > turbo-frame.list_container {
+  display: block;
+  width: 100%;
+}
 .list_container {
   .row {
     font-size: 1.2rem;

data/lib/inline_forms/archived_form_elements.rb

@@ -0,0 +1,70 @@
+# -*- encoding : utf-8 -*-
+module InlineForms
+  class ArchivedFormElementError < StandardError; end
+
+  # Retired form-element symbols. Full source for entries with +archive_path+ lives
+  # under archived/form_elements/<name>/ — see archived/README.md.
+  ARCHIVED_FORM_ELEMENTS = {
+    geo_code_curacao: {
+      archived_in_version: "7.6.0",
+      archive_path: "archived/form_elements/geo_code_curacao",
+      summary: "Curaçao street geocode (MySQL Zones/Buurten/Straatcode, jQuery autocomplete, UJS list_streets).",
+    },
+    chicas_photo_list: {
+      archived_in_version: "7.6.0",
+      archive_path: "archived/form_elements/chicas",
+      summary: "Chicas app read-only member photo gallery (show-only).",
+    },
+    chicas_family_photo_list: {
+      archived_in_version: "7.6.0",
+      archive_path: "archived/form_elements/chicas",
+      summary: "Chicas app read-only family member photo gallery (show-only).",
+    },
+    chicas_dropdown_with_family_members: {
+      archived_in_version: "7.6.0",
+      archive_path: "archived/form_elements/chicas",
+      summary: "Chicas client picker via family.clients; moves CarrierWave upload dir on update.",
+    },
+    kansen_slider: {
+      archived_in_version: "7.6.0",
+      archive_path: "archived/form_elements/kansen_slider",
+      summary: "jQuery UI slider for integer-coded chance scale; uses model attribute_values.",
+    },
+    tree: {
+      archived_in_version: "7.7.0",
+      archive_path: "archived/form_elements/tree",
+      summary: "Self-referential children list via parent.children; requires host tree APIs (see README).",
+    },
+    move: {
+      archived_in_version: "7.7.0",
+      archive_path: "archived/form_elements/tree",
+      summary: "Reparent via hash_tree_to_collection + add_child (host must implement; pairs with :tree).",
+    },
+    absence_list: {
+      removed_in_version: "6.3.0",
+      archive_path: nil,
+      summary: "Project-specific absence list UI; removed without a copy in this repo (see CHANGELOG 6.3.0).",
+    },
+  }.freeze
+
+  def self.validate_no_archived_form_elements_for!(klass)
+    return unless klass.instance_methods.include?(:inline_forms_attribute_list)
+
+    klass.new.inline_forms_attribute_list.each do |attribute, _label, form_element|
+      key = form_element.to_sym
+      next unless ARCHIVED_FORM_ELEMENTS.key?(key)
+
+      meta = ARCHIVED_FORM_ELEMENTS[key]
+      version = meta[:archived_in_version] || meta[:removed_in_version]
+      hint = if meta[:archive_path]
+        "Restore from #{meta[:archive_path]}/README.md or vendor into your app."
+      else
+        "See archived/README.md and CHANGELOG #{version}."
+      end
+
+      raise ArchivedFormElementError,
+        "#{klass.name} inline_forms_attribute_list declares #{attribute}:#{form_element}, " \
+        "which was retired in inline_forms #{version} (#{meta[:summary]}). #{hint}"
+    end
+  end
+end

data/lib/inline_forms/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module InlineForms
-  VERSION = "7.5.2"
+  VERSION = "7.9.1"
 end

data/lib/inline_forms.rb

@@ -1,6 +1,7 @@
 # -*- encoding : utf-8 -*-
 require ('inline_forms/version.rb')
 require_relative ('inline_forms/form_element_from_callee')
+require_relative ('inline_forms/archived_form_elements')
 # InlineForms is a Rails Engine that let you setup an admin interface quick and
 # easy. Please install it as a gem or include it in your Gemfile.
 module InlineForms
@@ -204,8 +205,9 @@ module InlineForms
 
       ActiveRecord::Base.descendants.each do |klass|
         begin
+          InlineForms.validate_no_archived_form_elements_for!(klass)
           InlineForms.validate_plain_text_configuration_for!(klass)
-        rescue InlineForms::PlainTextColumnMissingError
+        rescue InlineForms::PlainTextColumnMissingError, InlineForms::ArchivedFormElementError
           raise
         rescue StandardError
           # Some descendants might be abstract or temporarily unresolved while

data/lib/installer_templates/example_app_tests/test/integration/example_app_apartment_field_turbo_test.rb

@@ -13,16 +13,15 @@ class ExampleAppApartmentFieldTurboTest < ExampleAppIntegrationTestCase
     @turbo_headers = { "Turbo-Frame" => @frame_id }
   end
 
-  test "show panel partial wraps scalar fields in turbo-frame" do
-    get apartment_path(@apartment, update: "apartment_#{@apartment.id}"),
-        headers: {
-          "Accept" => "text/javascript, application/javascript",
-          "X-Requested-With" => "XMLHttpRequest"
-        }
+  test "show panel opens as HTML inside row turbo-frame" do
+    row_frame = "apartment_#{@apartment.id}"
+    get apartment_path(@apartment, update: row_frame),
+        headers: { "Turbo-Frame" => row_frame, "Accept" => "text/html" }
 
     assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{row_frame}">)
     assert_includes @response.body, "turbo-frame",
-      "UJS show.js.erb should embed _show with turbo-frame field wrappers"
+      "row show should embed _show with per-field turbo-frame wrappers"
     assert_includes @response.body, @frame_id
   end
 

data/lib/installer_templates/example_app_tests/test/integration/example_app_apartment_name_required_test.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require_relative "../example_app/example_integration_test_case"
+
+class ExampleAppApartmentNameRequiredTest < ExampleAppIntegrationTestCase
+  setup do
+    @frame = "apartments_list"
+    @frame_headers = { "Turbo-Frame" => @frame, "Accept" => "text/html" }
+  end
+
+  test "top-level create without name does not persist" do
+    assert_no_difference("Apartment.count") do
+      post apartments_path(update: @frame),
+        params: { title: "Missing name" },
+        headers: @frame_headers
+    end
+    assert_response :success
+    assert_includes @response.body, 'name="name"'
+    assert_includes @response.body, 'class="edit_form"'
+  end
+end

data/lib/installer_templates/example_app_tests/test/integration/example_app_apartment_photos_pagination_test.rb

@@ -220,6 +220,34 @@ class ExampleAppApartmentPhotosPaginationTest < ExampleAppIntegrationTestCase
     assert_select %(turbo-frame##{sample_row_id} a[data-turbo='true'][data-turbo-frame='#{sample_row_id}']), minimum: 1
   end
 
+  test "nested Photo versions restore targets nested row turbo-frame not bare photo id" do
+    photo = @apartment.photos.first!
+    original_name = photo.name
+    photo.update!(name: "#{original_name}-changed")
+    row_id = "apartment_#{@apartment.id}_photo_#{photo.id}"
+    versions_frame = "photo_#{photo.id}_versions"
+    version = photo.versions.where(event: "update").order(:id).last
+    assert version, "expected an update version to revert"
+
+    get list_versions_photo_path(photo, update: versions_frame),
+        headers: { "Turbo-Frame" => versions_frame, "Accept" => "text/html" }
+    assert_response :success
+    assert_includes @response.body, "data-turbo-frame=\"#{row_id}\"",
+      "restore must target the nested row frame (#{row_id}), not photo_#{photo.id}"
+
+    # 7.9.0: revert always responds with turbo-stream (the legacy
+    # `format.html` fallback was dropped).
+    post revert_photo_path(version.id, update: row_id),
+         headers: {
+           "Turbo-Frame" => versions_frame,
+           "Accept" => "text/vnd.turbo-stream.html"
+         }
+    assert_response :success
+    assert_includes @response.body, %(action="replace")
+    assert_includes @response.body, %(target="#{row_id}")
+    assert_equal original_name, photo.reload.name
+  end
+
   test "nested Photo row opens and closes via Turbo HTML (not_accessible_through_html model)" do
     photo = @apartment.photos.first!
     row_id = "apartment_#{@apartment.id}_photo_#{photo.id}"

data/lib/installer_templates/example_app_tests/test/integration/example_app_apartment_row_turbo_test.rb

@@ -79,16 +79,25 @@ class ExampleAppApartmentRowTurboTest < ExampleAppIntegrationTestCase
     doomed = Apartment.create!(name: "Turbo Revert Me", title: "Y")
     apt_id = doomed.id
     frame = "apartment_#{apt_id}"
-    headers = { "Turbo-Frame" => frame, "Accept" => "text/html" }
+    delete_headers = { "Turbo-Frame" => frame, "Accept" => "text/html" }
 
-    delete apartment_path(doomed, update: frame), headers: headers
+    delete apartment_path(doomed, update: frame), headers: delete_headers
     assert_response :success
 
+    # 7.9.0 dropped the `format.html` fallback in `revert`; restore links
+    # always request a turbo-stream now (the response replaces both the
+    # row and the versions panel in one stream).
+    versions_frame = "#{frame}_versions"
     destroy_version = PaperTrail::Version.where(item_type: "Apartment", item_id: apt_id).order(:id).last
-    post revert_apartment_path(destroy_version.id, update: frame), headers: headers
+    post revert_apartment_path(destroy_version.id, update: frame),
+         headers: {
+           "Turbo-Frame" => versions_frame,
+           "Accept" => "text/vnd.turbo-stream.html"
+         }
     assert_response :success
     assert Apartment.where(name: "Turbo Revert Me").exists?
-    assert_includes @response.body, %(<turbo-frame id="#{frame}">)
-    refute_includes @response.body, "object_presentation"
+    assert_includes @response.body, %(action="replace")
+    assert_includes @response.body, %(target="#{frame}")
+    assert_includes @response.body, %(target="#{versions_frame}")
   end
 end

data/lib/installer_templates/example_app_tests/test/integration/example_app_apartment_top_level_new_test.rb

@@ -2,99 +2,69 @@
 
 require_relative "../example_app/example_integration_test_case"
 
-# 7.5.2: top-level Apartment +new+ / +cancel+ / +create+ keep the legacy UJS
-# (+remote: true+) contract. 7.5.1 emitted +data-turbo-frame="apartments_list"+
-# on the +"+ new"+ link, but the index page wraps the list in a plain
-# +<div id="apartments_list">+ (not a +<turbo-frame>+) -- so:
-#
-# * +cancel+ / +create+ targeted a frame the page did not have, and Turbo
-#   logged "Content missing" and dropped the response;
-# * the +"+ new"+ click itself either fell back to a full-page navigation or
-#   landed in that broken state.
-#
-# Wrapping the top-level list in a real +<turbo-frame>+ regresses layout
-# (the frame collapses inside +position: absolute+ +#outer_container+), so
-# the fix keeps top-level behind UJS: +link_to_new_record+ omits Turbo data
-# attributes when no +parent_class+ is provided, and +new.js.erb+ /
-# +list.js.erb+ swap +#apartments_list+ contents in place.
+# Step 4: top-level `/apartments` list, +new, cancel, and create use Turbo Frames
+# (`<turbo-frame id="apartments_list">`) instead of UJS + new.js.erb / list.js.erb.
 class ExampleAppApartmentTopLevelNewTest < ExampleAppIntegrationTestCase
   setup do
     @frame = "apartments_list"
+    @frame_headers = { "Turbo-Frame" => @frame, "Accept" => "text/html" }
+    @apartment = Apartment.find_or_create_by!(name: "Top Level List Apt") do |a|
+      a.title = "Top level list seed"
+    end
   end
 
-  test "top-level apartments index keeps the legacy <div> wrapper (no <turbo-frame> for the list root)" do
+  test "top-level apartments index wraps list in turbo-frame" do
     get apartments_path
     assert_response :success
     assert_match(
-      %r{<div[^>]+class="list_container"[^>]+id="#{Regexp.escape(@frame)}"},
-      @response.body,
-      "top-level list must stay a <div id=\"apartments_list\"> for UJS swaps; " \
-      "wrapping in a <turbo-frame> at this position breaks layout"
+      %r{<turbo-frame[^>]+id="#{Regexp.escape(@frame)}"[^>]*class="list_container"},
+      @response.body
     )
     refute_match(
-      %r{<turbo-frame\s+id="#{Regexp.escape(@frame)}"},
+      %r{<div[^>]+id="#{Regexp.escape(@frame)}"[^>]*class="list_container"},
       @response.body,
-      "top-level list root should NOT be a <turbo-frame> -- doing so regresses " \
-      "layout (frame collapses under fixed top bars) and orphans cancel/create"
+      "list root must be turbo-frame, not legacy div"
     )
   end
 
-  test "top-level + new link uses UJS (data-remote), not Turbo" do
+  test "top-level + new link uses Turbo not UJS remote" do
     get apartments_path
     assert_response :success
     assert_match(
-      %r{<a [^>]*class="button new_button"[^>]*data-remote="true"[^>]*href="/apartments/new\?update=apartments_list"},
-      @response.body,
-      "top-level + must POST via UJS (no <turbo-frame> on the page to target); " \
-      "data-turbo* on this link causes 'Content missing' on cancel/create"
+      %r{<a [^>]*class="button new_button"[^>]*data-turbo="true"[^>]*data-turbo-frame="#{Regexp.escape(@frame)}"[^>]*href="/apartments/new\?update=apartments_list"},
+      @response.body
     )
     refute_match(
-      %r{<a [^>]*class="button new_button"[^>]*data-turbo-frame="#{Regexp.escape(@frame)}"},
-      @response.body,
-      "top-level + must NOT carry data-turbo-frame=apartments_list (no matching frame)"
+      %r{<a [^>]*class="button new_button"[^>]*data-remote="true"},
+      @response.body
     )
   end
 
-  test "top-level new returns JS that swaps #apartments_list with the form (UJS)" do
-    get new_apartment_path(update: @frame), xhr: true
+  test "top-level new returns new form inside matching turbo-frame" do
+    get new_apartment_path(update: @frame), headers: @frame_headers
     assert_response :success
-    assert_includes @response.content_type, "javascript",
-      "UJS XHR must hit format.js"
-    assert_match(
-      %r{\$\('#apartments_list'\)\.html\(},
-      @response.body,
-      "UJS new.js.erb must swap #apartments_list with the rendered form"
-    )
-    assert_includes @response.body, 'name=\"name\"'
-    assert_includes @response.body, 'class=\"edit_form\"'
+    assert_includes @response.body, %(<turbo-frame id="#{@frame}">)
+    assert_includes @response.body, 'name="name"'
+    assert_includes @response.body, 'class="edit_form"'
+    refute_includes @response.content_type.to_s, "javascript"
   end
 
-  test "top-level cancel returns JS that swaps #apartments_list back to the list (UJS)" do
-    get apartments_path(update: @frame, ul_needed: true), xhr: true
+  test "top-level cancel returns list inside matching turbo-frame" do
+    get apartments_path(update: @frame, ul_needed: true), headers: @frame_headers
     assert_response :success
-    assert_includes @response.content_type, "javascript",
-      "UJS XHR must hit format.js"
-    assert_match(
-      %r{\$\('#apartments_list'\)\.html\(},
-      @response.body,
-      "UJS list.js.erb must swap #apartments_list back to the list"
-    )
+    assert_includes @response.body, %(<turbo-frame id="#{@frame}")
+    assert_includes @response.body, "<turbo-frame id=\"apartment_"
   end
 
-  test "top-level create via UJS persists and returns the list swap" do
+  test "top-level create via Turbo persists and returns the list frame" do
     name = "TopLevelNewApt-#{SecureRandom.hex(4)}"
     assert_difference("Apartment.count", 1) do
       post apartments_path(update: @frame),
         params: { name: name, title: "Top level new test" },
-        xhr: true
+        headers: @frame_headers
     end
     assert_response :success
-    assert_includes @response.content_type, "javascript"
-    assert_match(
-      %r{\$\('#apartments_list'\)\.html\(},
-      @response.body
-    )
-    assert_includes @response.body, name,
-      "expected the newly-created Apartment to appear in the swapped list"
+    assert_includes @response.body, %(<turbo-frame id="#{@frame}">)
+    assert_includes @response.body, name
   end
 end