inline_forms 7.2.11 → 7.9.1

data/lib/installer_templates/example_app_tests/test/integration/example_app_apartment_versions_turbo_test.rb

@@ -0,0 +1,120 @@
+# frozen_string_literal: true
+
+require_relative "../example_app/example_integration_test_case"
+
+class ExampleAppApartmentVersionsTurboTest < ExampleAppIntegrationTestCase
+  setup do
+    @apartment = Apartment.first || Apartment.create!(name: "Versions Turbo", title: "T")
+    @versions_frame = "apartment_#{@apartment.id}_versions"
+    @headers = { "Turbo-Frame" => @versions_frame, "Accept" => "text/html" }
+  end
+
+  test "versions list opens inside matching turbo-frame" do
+    get list_versions_apartment_path(@apartment, update: @versions_frame), headers: @headers
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{@versions_frame}">)
+    assert_includes @response.body, "Changeset"
+    refute_includes @response.body, 'data-remote="true"'
+  end
+
+  test "versions list close returns panel header inside turbo-frame" do
+    get list_versions_apartment_path(@apartment, update: @versions_frame, close: true),
+        headers: @headers
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{@versions_frame}">)
+    refute_includes @response.body, "Changeset"
+  end
+
+  test "expanded row versions open link uses Turbo not UJS remote" do
+    row_frame = "apartment_#{@apartment.id}"
+    get apartment_path(@apartment, update: row_frame),
+        headers: { "Turbo-Frame" => row_frame, "Accept" => "text/html" }
+    assert_response :success
+    assert_select "turbo-frame##{@versions_frame} a[data-turbo='true'][data-turbo-frame='#{@versions_frame}']", minimum: 1
+    refute_select "turbo-frame##{@versions_frame} a[data-remote='true']"
+  end
+
+  test "restore link in versions list requests turbo-stream (nested versions frame)" do
+    apt = Apartment.create!(name: "Stream Link", title: "T")
+    apt.update!(title: "T2")
+    vf = "apartment_#{apt.id}_versions"
+    get list_versions_apartment_path(apt, update: vf),
+        headers: { "Turbo-Frame" => vf, "Accept" => "text/html" }
+    assert_response :success
+    assert_match(/data-turbo-stream="true"/, @response.body,
+      "restore from inside …_versions must use turbo-stream to avoid Turbo-Frame mismatch")
+  end
+
+  test "revert from versions list closes row via turbo-stream when Turbo-Frame is versions" do
+    apt = Apartment.create!(name: "Versions Stream Revert", title: "Before")
+    apt.update!(title: "After")
+    row_frame = "apartment_#{apt.id}"
+    versions_frame = "#{row_frame}_versions"
+    version = apt.versions.where(event: "update").order(:id).last
+    assert version, "expected an update version to revert"
+
+    post revert_apartment_path(version.id, update: row_frame),
+         headers: {
+           "Turbo-Frame" => versions_frame,
+           "Accept" => "text/vnd.turbo-stream.html"
+         }
+    assert_response :success
+    assert_includes @response.body, %(action="replace")
+    assert_includes @response.body, %(target="#{row_frame}")
+    assert_includes @response.body, %(target="#{versions_frame}")
+    assert_equal "Before", apt.reload.title
+  end
+
+  test "revert from versions list closes row via Turbo POST on row frame" do
+    apt = Apartment.create!(name: "Versions Revert", title: "Before")
+    apt.update!(title: "After")
+    row_frame = "apartment_#{apt.id}"
+    versions_frame = "#{row_frame}_versions"
+    # 7.9.0 dropped the `format.html` fallback in `revert`; the restore link
+    # always requests a turbo-stream now, even when the click happened on
+    # the row frame, so the test mirrors that contract.
+    row_headers = {
+      "Turbo-Frame" => row_frame,
+      "Accept" => "text/vnd.turbo-stream.html"
+    }
+
+    version = apt.versions.where(event: "update").order(:id).last
+    assert version, "expected an update version to revert"
+
+    post revert_apartment_path(version.id, update: row_frame), headers: row_headers
+    assert_response :success
+    assert_includes @response.body, %(action="replace")
+    assert_includes @response.body, %(target="#{row_frame}")
+    assert_includes @response.body, %(target="#{versions_frame}")
+    assert_equal "Before", apt.reload.title
+  end
+
+  test "revert from versions list restores rich_text body via turbo-stream" do
+    apt = Apartment.create!(name: "RichText Revert", title: "T")
+    apt.update!(description: "<p>old body</p>")
+    apt.update!(description: "<p>new body</p>")
+
+    rich_text = ActionText::RichText.find_by!(
+      record_type: Apartment.name, record_id: apt.id, name: "description"
+    )
+    rich_text_version = rich_text.versions.where(event: "update").order(:id).last
+    assert rich_text_version,
+      "expected a PaperTrail update version on ActionText::RichText for the description edit"
+
+    row_frame = "apartment_#{apt.id}"
+    versions_frame = "#{row_frame}_versions"
+    post revert_apartment_path(rich_text_version.id, update: row_frame),
+         headers: {
+           "Turbo-Frame" => versions_frame,
+           "Accept" => "text/vnd.turbo-stream.html"
+         }
+    assert_response :success
+    assert_includes @response.body, %(action="replace")
+    assert_includes @response.body, %(target="#{row_frame}")
+    assert_includes @response.body, %(target="#{versions_frame}")
+
+    apt.reload
+    assert_includes apt.description.body.to_html, "old body",
+      "rich_text revert should restore the previous body content"
+  end
+end

data/lib/installer_templates/example_app_tests/test/integration/example_app_photo_revert_test.rb

@@ -0,0 +1,94 @@
+# frozen_string_literal: true
+
+require_relative "../example_app/example_integration_test_case"
+
+# 7.9.0 regression: revert from the versions panel for a Photo whose
+# `image` column changed must put back the previous CarrierWave file
+# bytes, not just the previous filename string. Relies on the
+# `ImageUploader` knobs the installer ships:
+#
+#   * `CarrierWave.configure { config.remove_previously_stored_files_after_update = false }`
+#     (config/initializers/carrierwave.rb)
+#   * `remove!` no-op
+#   * unique per-upload filename prefix
+#
+# See https://stackoverflow.com/questions/9423279/papertrail-and-carrierwave
+class ExampleAppPhotoRevertTest < ExampleAppIntegrationTestCase
+  # Mirror the setup of ExampleAppApartmentPhotosPaginationTest: re-seed
+  # Konferensha photos from db/seed_images/ so the test asserts against
+  # real CarrierWave file mounts without depending on dev DB state.
+  setup do
+    @apartment = Apartment.find_or_create_by!(name: "Konferensha") do |a|
+      a.title = "Konferensha sobre Papiamentu"
+    end
+    seed_dir = Rails.root.join("db", "seed_images")
+    if seed_dir.directory?
+      Dir.glob(seed_dir.join("*.{jpg,jpeg,png,gif}"), File::FNM_CASEFOLD).sort.each do |abs|
+        base = File.basename(abs)
+        next if Photo.exists?(name: base, apartment_id: @apartment.id)
+        File.open(abs, "rb") do |io|
+          Photo.create!(
+            name: base,
+            caption: "Konferensha foto #{base}",
+            apartment: @apartment,
+            image: io
+          )
+        end
+      end
+    end
+  end
+
+  test "revert restores previous CarrierWave file bytes on disk" do
+    photo = @apartment.photos.first!
+    original_identifier = photo.image.identifier
+    original_path = photo.image.path
+    assert File.exist?(original_path), "expected seeded photo file on disk: #{original_path}"
+    original_size = File.size(original_path)
+
+    seed_dir = Rails.root.join("db", "seed_images")
+    jpgs = Dir.glob(seed_dir.join("*.{jpg,jpeg}"), File::FNM_CASEFOLD).sort
+    replacement = jpgs.find { |abs| File.basename(abs) != photo.name } || jpgs.last
+    assert replacement, "need at least one seed jpg different from the photo's current mount"
+    refute_equal File.size(replacement), original_size,
+      "test needs a replacement file with a different byte length so the assertion is meaningful"
+
+    frame_id = "apartment_#{@apartment.id}_photo_#{photo.id}_image"
+    turbo_headers = { "Turbo-Frame" => frame_id, "Accept" => "text/html" }
+    uploaded = Rack::Test::UploadedFile.new(replacement, "image/jpeg")
+    put photo_path(
+      photo,
+      attribute: "image",
+      form_element: "image_field",
+      update: frame_id
+    ),
+        params: { image: uploaded },
+        headers: turbo_headers
+    assert_response :success
+    photo.reload
+    refute_equal original_identifier, photo.image.identifier,
+      "update should have changed the image identifier"
+
+    version = photo.versions.where(event: "update").order(:id).last
+    assert version, "expected a Photo update version after the image PUT"
+
+    row_frame = "apartment_#{@apartment.id}_photo_#{photo.id}"
+    versions_frame = "apartment_#{@apartment.id}_photo_#{photo.id}_versions"
+    post revert_photo_path(version.id, update: row_frame),
+         headers: {
+           "Turbo-Frame" => versions_frame,
+           "Accept" => "text/vnd.turbo-stream.html"
+         }
+    assert_response :success
+    assert_includes @response.body, %(action="replace")
+    assert_includes @response.body, %(target="#{row_frame}")
+    assert_includes @response.body, %(target="#{versions_frame}")
+
+    photo.reload
+    assert_equal original_identifier, photo.image.identifier,
+      "revert should restore the previous CarrierWave identifier"
+    assert File.exist?(photo.image.path),
+      "revert should leave the previous file bytes on disk (carrierwave config)"
+    assert_equal original_size, File.size(photo.image.path),
+      "previous file bytes must be byte-identical to the original"
+  end
+end

data/lib/installer_templates/example_app_tests/test/integration/example_app_turbo_layout_test.rb

@@ -2,14 +2,11 @@
 
 require_relative "../example_app/example_integration_test_case"
 
-# Smoke test for rollout step 1 of stuff/ujs-to-turbo.md (gem-side):
-# the layout loads Turbo as an ES module and disables Drive so existing
-# UJS-driven links/forms keep working unchanged. If this asserts ever
-# fails, frame/stream conversions in later slices will silently fall
-# back to full-page navigation (Turbo not loaded) instead of using the
-# `<turbo-frame>` fast path.
+# Smoke test: layouts load Turbo as an ES module (no Sprockets ESM parse error).
+# Step 5 (7.8.0) leaves Turbo Drive at its default (enabled); inline flows use
+# `<turbo-frame>` + HTML, not jquery-ujs.
 class ExampleAppTurboLayoutTest < ExampleAppIntegrationTestCase
-  test "inline_forms layout loads turbo.min.js as an ES module with drive disabled" do
+  test "inline_forms layout loads turbo.min.js as an ES module" do
     get apartments_path
     assert_response :success
 
@@ -19,10 +16,10 @@ class ExampleAppTurboLayoutTest < ExampleAppIntegrationTestCase
       "expected the inline_forms layout to import turbo.min.js as a module"
     )
 
-    assert_match(
+    refute_match(
       /Turbo\.session\.drive\s*=\s*false/,
       @response.body,
-      "expected Turbo.session.drive = false so existing UJS keeps working"
+      "Step 5 enables Turbo Drive by default; disabling it would regress full-page Turbo"
     )
   end
 end

data/lib/installer_templates/example_app_tests/test/models/example_app_apartment_name_validation_test.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class ExampleAppApartmentNameValidationTest < ActiveSupport::TestCase
+  test "apartment requires name" do
+    apartment = Apartment.new(title: "No name")
+    assert_not apartment.valid?
+    assert_includes apartment.errors[:name], "can't be blank"
+  end
+
+  test "apartment is valid with name" do
+    apartment = Apartment.new(name: "North", title: "Tower")
+    assert apartment.valid?
+  end
+end

data/lib/installer_templates/example_app_tests/test/models/example_app_plain_text_rich_text_edge_cases_test.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class ExampleAppPlainTextRichTextEdgeCasesTest < ActiveSupport::TestCase
+  def with_temporary_inline_forms_attribute_list(klass, temporary_list)
+    original = klass.instance_method(:inline_forms_attribute_list)
+    klass.define_method(:inline_forms_attribute_list) { temporary_list }
+    yield
+  ensure
+    klass.define_method(:inline_forms_attribute_list, original)
+  end
+
+  test "plain_text mapped to actiontext-backed attribute raises configuration error" do
+    with_temporary_inline_forms_attribute_list(
+      Apartment,
+      [[:description, "description", :plain_text]]
+    ) do
+      error = assert_raises(InlineForms::PlainTextColumnMissingError) do
+        InlineForms.validate_plain_text_configuration_for!(Apartment)
+      end
+      assert_includes(error.message, "description")
+      assert_includes(error.message, ":rich_text")
+    end
+  end
+
+  test "plain_text runtime guard raises before assigning unknown DB attribute" do
+    apartment = Apartment.create!(name: "Mismatch", title: "Check")
+    assert_raises(InlineForms::PlainTextColumnMissingError) do
+      InlineForms.assert_plain_text_column!(
+        object: apartment,
+        attribute: :description,
+        form_element: :plain_text
+      )
+    end
+  end
+
+  test "switching text column field from plain_text to rich_text does not raise" do
+    with_temporary_inline_forms_attribute_list(
+      Role,
+      [[:description, "description", :rich_text]]
+    ) do
+      InlineForms.validate_plain_text_configuration_for!(Role)
+    end
+  end
+end

data/lib/installer_templates/example_app_views/apartments/name_list.html.erb

@@ -0,0 +1,26 @@
+<% @inline_forms_turbo_field = true %>
+<div class="row">
+  <div class="small-12 columns">
+    <h2>Apartment names (first 10)</h2>
+    <p>
+      <%= link_to "Back to full apartment list", apartments_path %>
+    </p>
+    <p class="help-text">
+      Each name is an inline edit via <code>text_field_show</code> — no stock
+      <code>_show</code> panel. Click a name to edit it in place.
+    </p>
+  </div>
+</div>
+
+<% @apartments.each do |apartment| %>
+  <div class="row">
+    <div class="small-2 columns">
+      <%= apartment.id %>
+    </div>
+    <div class="small-10 columns">
+      <turbo-frame id="apartment_<%= apartment.id %>_name">
+        <%= text_field_show(apartment, :name) %>
+      </turbo-frame>
+    </div>
+  </div>
+<% end %>

data/lib/installer_templates/example_app_views/inline_forms/_header.html.erb

@@ -0,0 +1,45 @@
+<div class="contain-to-grid fixed">
+  <nav id='inline_forms_application_top_bar' class="top-bar">
+    <div class="top-bar-left">
+      <ul class="menu">
+        <li class="menu-text">
+          <h1 style="margin: 0; font-size: inherit;"><a href="/"><%= application_name %> v<%= inline_forms_version %> <%= current_user.name %></a></h1>
+        </li>
+      </ul>
+    </div>
+    <div class="top-bar-right">
+      <ul class="dropdown menu" data-dropdown-menu>
+        <% if current_user.role?(:admin) || current_user.role?(:superadmin) %>
+          <li>
+            <a href="#"><%= t 'common.more' %></a>
+            <ul class="menu">
+              <% MODEL_TABS.each do |m| %>
+                <% model = m.singularize.camelcase.constantize rescue nil %>
+                  <% unless model.nil? || model.not_accessible_through_html? %>
+                  <% if can? :update, model %>
+                  <li>
+                    <%= link_to model.model_name.human, '/' +  m %>
+                  </li>
+                  <% end %>
+                <% end %>
+              <% end %>
+              <% if can? :read, Apartment %>
+              <li>
+                <%= link_to "Apartment names (first 10)", apartment_name_list_path %>
+              </li>
+              <% end %>
+            </ul>
+          </li>
+        <% end %>
+        <li>
+          <a href="#"><%= current_user.name %></a>
+          <ul class="menu">
+            <li>
+              <%= link_to( t("common.logout"), destroy_user_session_path, :method => :delete) if current_user  %>
+            </li>
+          </ul>
+        </li>
+      </ul>
+    </div>
+  </nav>
+</div>

data/test/archived_form_elements_test.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require_relative "test_helper"
+require "inline_forms/archived_form_elements"
+
+class ArchivedFormElementsTest < Minitest::Test
+  class ModelWithArchivedElement
+    def inline_forms_attribute_list
+      [[:address, "Address", :geo_code_curacao]]
+    end
+  end
+
+  class ModelWithArchivedTree
+    def inline_forms_attribute_list
+      [[:children, "Children", :tree]]
+    end
+  end
+
+  def test_raises_when_model_declares_archived_geo_code_curacao
+    err = assert_raises(InlineForms::ArchivedFormElementError) do
+      InlineForms.validate_no_archived_form_elements_for!(ModelWithArchivedElement)
+    end
+    assert_includes err.message, "geo_code_curacao"
+    assert_includes err.message, "7.6.0"
+    assert_includes err.message, "archived/form_elements/geo_code_curacao"
+  end
+
+  def test_raises_when_model_declares_archived_tree
+    err = assert_raises(InlineForms::ArchivedFormElementError) do
+      InlineForms.validate_no_archived_form_elements_for!(ModelWithArchivedTree)
+    end
+    assert_includes err.message, "tree"
+    assert_includes err.message, "archived/form_elements/tree"
+  end
+
+  def test_archived_registry_documents_absence_list_without_path
+    meta = InlineForms::ARCHIVED_FORM_ELEMENTS[:absence_list]
+    assert_equal "6.3.0", meta[:removed_in_version]
+    assert_nil meta[:archive_path]
+  end
+end

data/test/form_element_from_callee_test.rb

@@ -45,9 +45,9 @@ class FormElementFromCalleeTest < Minitest::Test
   end
 
   def test_multi_word_element_name_underscores_preserved
-    got = InlineForms.form_element_string_from_callee(:chicas_dropdown_with_family_members_show)
+    got = InlineForms.form_element_string_from_callee(:text_area_without_ckeditor_show)
     assert_equal(
-      "chicas_dropdown_with_family_members",
+      "text_area_without_ckeditor",
       got,
       "Form element names with underscores must survive unchanged except for _show."
     )

data/test/inline_forms_generator_test.rb

@@ -100,6 +100,16 @@ class InlineFormsGeneratorTest < Minitest::Test
     refute_includes(migration, "t.text :content")
   end
 
+  def test_plain_text_generates_text_column_and_plain_text_form_element
+    run_generator("Note", "title:string", "description:plain_text")
+
+    model = read("app/models/note.rb")
+    migration = read_single_migration_for("notes")
+
+    assert_includes(model, "[ :description , \"description\", :plain_text ]")
+    assert_includes(migration, "t.text :description")
+  end
+
   private
 
   def build_destination_skeleton!

data/test/plain_text_configuration_test.rb

@@ -0,0 +1,90 @@
+# frozen_string_literal: true
+
+require_relative "test_helper"
+require "rails"
+require "inline_forms"
+
+class PlainTextConfigurationTest < Minitest::Test
+  class PlainTextModelWithColumn
+    def self.table_exists?
+      true
+    end
+
+    def self.column_names
+      %w[id description]
+    end
+
+    def self.table_name
+      "plain_text_model_with_columns"
+    end
+
+    def inline_forms_attribute_list
+      [
+        [:description, "description", :plain_text]
+      ]
+    end
+  end
+
+  class PlainTextModelWithoutColumn
+    def self.table_exists?
+      true
+    end
+
+    def self.column_names
+      %w[id]
+    end
+
+    def self.table_name
+      "plain_text_model_without_columns"
+    end
+
+    def inline_forms_attribute_list
+      [
+        [:description, "description", :plain_text]
+      ]
+    end
+  end
+
+  class RichTextModelWithoutColumn
+    def self.table_exists?
+      true
+    end
+
+    def self.column_names
+      %w[id]
+    end
+
+    def inline_forms_attribute_list
+      [
+        [:description, "description", :rich_text]
+      ]
+    end
+  end
+
+  def test_plain_text_column_check_passes_when_column_exists
+    model = PlainTextModelWithColumn.new
+    InlineForms.assert_plain_text_column!(object: model, attribute: :description, form_element: :plain_text)
+  end
+
+  def test_plain_text_column_check_raises_when_column_missing
+    model = PlainTextModelWithoutColumn.new
+    error = assert_raises(InlineForms::PlainTextColumnMissingError) do
+      InlineForms.assert_plain_text_column!(object: model, attribute: :description, form_element: :plain_text)
+    end
+    assert_includes(error.message, "has no DB column")
+  end
+
+  def test_configuration_check_raises_for_plain_text_without_column
+    assert_raises(InlineForms::PlainTextColumnMissingError) do
+      InlineForms.validate_plain_text_configuration_for!(PlainTextModelWithoutColumn)
+    end
+  end
+
+  def test_configuration_check_allows_rich_text_without_column
+    InlineForms.validate_plain_text_configuration_for!(RichTextModelWithoutColumn)
+  end
+
+  def test_text_area_alias_is_not_treated_as_plain_text_column_requirement
+    refute InlineForms.plain_text_form_element?(:text_area)
+  end
+end