inline_forms 7.13.4 → 7.13.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8a68d0c92e72d9f2a1adb026157f51097a12f77fa704be1c25c934178a540142
-  data.tar.gz: eeb3d95f3e6e1f988a3a5cad6a176ff4c503f8a6efab22f8ca9e03029457ae8e
+  metadata.gz: 1852b024dd7d8d0b8f7b6d76e2ca17d4f8b9ad85dc6d2db6a4d11195164469e9
+  data.tar.gz: 6b9cfc0e042dc2d0146b282c779cc1cfaa547c7aaf0495bf897c125feaa16b45
 SHA512:
-  metadata.gz: b3411a60ef7e26d8994a47daf32ca10455ac6aee511f35b198afaa0ea53172cd009c5dd9632d069f05039ecd24ffca0508d2e3fbcd0b2ce93712e351a8f919d0
-  data.tar.gz: 01b8cff956c04ae458e1ea5b76534a5e741fb4845b518021cad5d6253693f54a8782ae802b504984ef3136a80fd3446a4db99e1584a3c0162e39ddec08f4c031
+  metadata.gz: e6ddeccc3034c47c4e0ebd087e90222b3589b767bc24891f73f8caedd89cc24d06b3cd02b8242075ca8e2c27710aee494084b422eca61e6c8b110c7dc3ecac5a
+  data.tar.gz: 01b1d421b8d8ec544c4b41cb42e13d0f58634aee2ff07021edc5219adbd2b3cc4f6f4b5a0f7d8308e6a6e82eb457081965735a285065e465c3c36a716a33f71e

data/CHANGELOG.md

@@ -4,6 +4,28 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [7.13.5] - 2026-05-19
+
+### Changed
+
+- **Generated app Gemfile — no more git forks for `tabs_on_rails` / `i18n-active_record`.**
+  - **`tabs_on_rails`:** `gem 'tabs_on_rails', '~> 3.0'` from RubyGems (weppos 3.0.0). The acesuares fork only added unused `:remote` on tab links; inline_forms uses `set_tab` only.
+  - **`i18n-active_record`:** removed. Generated apps never configured `I18n.backend`; only `extract_translations` read the `translations` SQL view. Replaced with **`InlineForms::TranslationRecord`** (`lib/inline_forms/translation_record.rb`) — read-only AR on the existing view (`thekey` column kept for MySQL).
+  - **`will_paginate`:** dropped commented acesuares git line; RubyGems only.
+
+### Added
+
+- **`docs/git-deps-assessment.md`** — fork history and verification notes (local copy also under `stuff/`, gitignored).
+
+### Changed (also)
+
+- **`InlineForms::VERSION`** and **`InlineFormsInstaller::VERSION`** → `7.13.5`.
+
+### Verified
+
+- `gem build inline_forms.gemspec` → `inline_forms-7.13.5.gem`; `gem build inline_forms_installer.gemspec` → `inline_forms_installer-7.13.5.gem`.
+- `inline_forms create MyApp -d sqlite --example` → `bundle exec rails test` — **83 runs, 461 assertions, 0 failures, 0 errors, 0 skips** (Ruby 4.0.4 / Rails 7.2.3.1). `Gemfile.lock`: `tabs_on_rails (3.0.0)` from rubygems.org; no `i18n-active_record` git source.
+
 ## [7.13.4] - 2026-05-19
 
 ### Fixed

data/app/controllers/inline_forms_controller.rb

@@ -323,7 +323,7 @@ class InlineFormsController < ApplicationController
 
   def extract_translations
     keys_array = []
-    I18n::Backend::ActiveRecord::Translation.order(:locale, :thekey).each do |t|
+    InlineForms::TranslationRecord.order(:locale, :thekey).each do |t|
       keys_array << deep_hashify([ t.locale, t.thekey.split('.'), t.value ].flatten)
     end
     keys_hash = {}

data/docs/git-deps-assessment.md

@@ -0,0 +1,106 @@
+# Git-sourced installer dependencies — assessment
+
+**Date:** 2026-05-19  
+**Context:** Generated apps from `inline_forms create` used three non-RubyGems pins: `tabs_on_rails` (git + branch), `i18n-active_record` (git), and a commented `will_paginate` fork. This doc records why they existed and what replaced them.
+
+**Related (risk callouts only):** `validation_hints/stuff/rails-7.2-zeitwerk-plan.md` (Track A3), `validation_hints/stuff/rails-8-checklist.md` (Phase 3).
+
+---
+
+## Summary (7.13.5+)
+
+| Gem | Was | Now | Reason |
+|-----|-----|-----|--------|
+| `will_paginate` | RubyGems + commented acesuares fork | RubyGems only | Fork never active; comment removed |
+| `tabs_on_rails` | `acesuares/tabs_on_rails` branch `update_remote_before_action` | `~> 3.0` (weppos, RubyGems) | Fork only added unused `:remote` on tab links; upstream 3.0.0 already uses `before_action` |
+| `i18n-active_record` | `acesuares/i18n-active_record` (2012) | **Removed** — `InlineForms::TranslationRecord` | App never sets `I18n.backend`; only reads the `translations` **view** via AR |
+
+**No generated-app Gemfile should use `:git` for these anymore.**
+
+---
+
+## `will_paginate`
+
+- **Fork:** `https://github.com/acesuares/will_paginate.git` (commented out for years).
+- **Usage:** Nested/top-level list pagination in `_list.html.erb`; Turbo Frame nav since 7.5.x (no `:remote => true`).
+- **Verdict:** RubyGems `will_paginate` is sufficient. No acesuares-specific behavior required.
+
+---
+
+## `tabs_on_rails`
+
+### Why the fork existed
+
+Branch `update_remote_before_action` on `acesuares/tabs_on_rails` (2019) did two things:
+
+1. `before_filter` → `before_action` (Rails 4+ rename).
+2. Optional `:remote => true` on `tab_for` links (`tabs_builder.rb`).
+
+### What inline_forms actually uses
+
+- Controllers call **`set_tab :resource`** only (generator template + installer).
+- Top bar is **not** built with `tabs_tag` / `tab_for`; `_inline_forms_tabs.html.erb` is a Foundation top-bar with search + new button.
+- Turbo migration removed **`data-remote`** from inline UI; no code passes `:remote` into tabs.
+
+### Upstream today
+
+- **RubyGems:** `tabs_on_rails` **3.0.0** (weppos, 2017).
+- **`set_tab`** already uses **`before_action`** in `lib/tabs_on_rails/action_controller.rb`.
+- **Missing vs fork:** `:remote` on tab links only — **unused by inline_forms**.
+
+### Verdict
+
+**Use `gem 'tabs_on_rails', '~> 3.0'`.** No runtime dependency on the fork. Re-test on Rails 7.2+ / 8.0 when upgrading (gem is unmaintained but tiny).
+
+---
+
+## `i18n-active_record`
+
+### Why the fork existed
+
+- Upstream expects a `translations` table with column **`key`**.
+- MySQL reserves `KEY`; acesuares fork renamed to **`thekey`** with `alias_attribute :key, :thekey`.
+- Fork is **Rails 3 era** (`set_table_name`, `attr_protected`, last push 2012).
+
+### What inline_forms actually uses
+
+- Installer builds **InlineFormsKey / Locale / Translation** tables, then a SQL **VIEW** `translations` with columns `locale`, **`thekey`**, `value`, `interpolations`, `is_proc`.
+- **`I18n.backend` is never configured** to `I18n::Backend::ActiveRecord` in generated apps.
+- Only consumer: **`InlineFormsController#extract_translations`** (admin export of keys); not wired in default routes/tests.
+
+### Upstream today
+
+- **RubyGems:** `i18n-active_record` **1.4.0** (2024), Rails 7.1+ YAML serializers, column **`key`**, optional `scope`.
+- Adopting it would require renaming the view column to `key` (backtick on MySQL) and dropping the stale fork API.
+
+### Verdict
+
+**Drop the gem.** Add **`InlineForms::TranslationRecord`** (`lib/inline_forms/translation_record.rb`) as a read-only AR model on the existing view with **`thekey`**. Same behavior, no git dep, Rails 7.2-safe.
+
+If full **I18n::Backend::ActiveRecord** is needed later, pin **`i18n-active_record ~> 1.4`** and align the view schema to upstream (`key` column + initializer), not the 2012 fork.
+
+---
+
+## Previously removed forks (reference)
+
+| Gem | Removed in | Replacement |
+|-----|------------|-------------|
+| `devise-i18n` | 7.3.4 / 7.10+ | RubyGems `~> 1.16` |
+| `paper_trail` | 7.0.x | RubyGems `~> 16.0` |
+| `switch_user` | 7.2.x | Removed from installer |
+
+---
+
+## Verification
+
+After changing `installer_core.rb`:
+
+```bash
+cd /home/code/inline_forms && rvm use . && gem build inline_forms.gemspec && gem build inline_forms_installer.gemspec
+cd /home/code/testInline && rvm use .
+gem install /home/code/inline_forms/inline_forms-*.gem /home/code/inline_forms/inline_forms_installer-*.gem
+rm -rf MyApp && inline_forms create MyApp -d sqlite --example
+cd MyApp && rvm use . && bundle exec rails test
+```
+
+Expect **0 failures**; `Gemfile.lock` should list `tabs_on_rails (3.0.0)` and **no** `i18n-active_record` git source.

data/lib/inline_forms/translation_record.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+module InlineForms
+  # Read-only adapter for the +translations+ SQL view created by the installer
+  # (+inline_forms_create_view_for_translations+). The view exposes +thekey+
+  # (not +key+) so it works on MySQL where +key+ is reserved.
+  class TranslationRecord < ActiveRecord::Base
+    self.table_name = "translations"
+
+    def readonly?
+      true
+    end
+  end
+end

data/lib/inline_forms/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module InlineForms
-  VERSION = "7.13.4"
+  VERSION = "7.13.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 7.13.4
+  version: 7.13.5
 platform: ruby
 authors:
 - Ace Suares
@@ -493,6 +493,7 @@ files:
 - archived/form_elements/tree/app/helpers/form_elements/move.rb
 - archived/form_elements/tree/app/views/inline_forms/_show_tree.html.erb
 - archived/form_elements/tree/app/views/inline_forms/_tree.html.erb
+- docs/git-deps-assessment.md
 - docs/jquery-widgets.md
 - docs/prompt/.gitignore
 - docs/prompt/test-the-example-app.md
@@ -553,6 +554,7 @@ files:
 - lib/inline_forms/form_elements/text_field_helper.rb
 - lib/inline_forms/form_elements/time_helper.rb
 - lib/inline_forms/gem_files.rb
+- lib/inline_forms/translation_record.rb
 - lib/inline_forms/version.rb
 - lib/locales/inline_forms.en.yml
 - lib/locales/inline_forms.nl.yml