inline_forms 7.13.3 → 7.13.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ec05aa4e1a1a1f21dcd041e8022943ec84af7c9b1ad4ccd90a6f57721f1732cd
-  data.tar.gz: 05fac9919e1730afa9797d2b343a0c76484cf28c6ac0ca210daed96312699902
+  metadata.gz: 1852b024dd7d8d0b8f7b6d76e2ca17d4f8b9ad85dc6d2db6a4d11195164469e9
+  data.tar.gz: 6b9cfc0e042dc2d0146b282c779cc1cfaa547c7aaf0495bf897c125feaa16b45
 SHA512:
-  metadata.gz: 927830ff6c84fa2642f243df6956725584b990814ffc10a357983b253117cb2c1c99f3dc7b304438becd1a20e962cae72df6714f4b570cac4c1a54fe65dc3134
-  data.tar.gz: ad534d4e02d38e4dc6d607e18a92725cda21334a73b5a41bbea096dd5bb830fc23697a58928345ac32426fe5c3939a46106fb176068e1aa696637f2a7e7dcd6b
+  metadata.gz: e6ddeccc3034c47c4e0ebd087e90222b3589b767bc24891f73f8caedd89cc24d06b3cd02b8242075ca8e2c27710aee494084b422eca61e6c8b110c7dc3ecac5a
+  data.tar.gz: 01b1d421b8d8ec544c4b41cb42e13d0f58634aee2ff07021edc5219adbd2b3cc4f6f4b5a0f7d8308e6a6e82eb457081965735a285065e465c3c36a716a33f71e

data/CHANGELOG.md

@@ -4,6 +4,53 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [7.13.5] - 2026-05-19
+
+### Changed
+
+- **Generated app Gemfile — no more git forks for `tabs_on_rails` / `i18n-active_record`.**
+  - **`tabs_on_rails`:** `gem 'tabs_on_rails', '~> 3.0'` from RubyGems (weppos 3.0.0). The acesuares fork only added unused `:remote` on tab links; inline_forms uses `set_tab` only.
+  - **`i18n-active_record`:** removed. Generated apps never configured `I18n.backend`; only `extract_translations` read the `translations` SQL view. Replaced with **`InlineForms::TranslationRecord`** (`lib/inline_forms/translation_record.rb`) — read-only AR on the existing view (`thekey` column kept for MySQL).
+  - **`will_paginate`:** dropped commented acesuares git line; RubyGems only.
+
+### Added
+
+- **`docs/git-deps-assessment.md`** — fork history and verification notes (local copy also under `stuff/`, gitignored).
+
+### Changed (also)
+
+- **`InlineForms::VERSION`** and **`InlineFormsInstaller::VERSION`** → `7.13.5`.
+
+### Verified
+
+- `gem build inline_forms.gemspec` → `inline_forms-7.13.5.gem`; `gem build inline_forms_installer.gemspec` → `inline_forms_installer-7.13.5.gem`.
+- `inline_forms create MyApp -d sqlite --example` → `bundle exec rails test` — **83 runs, 461 assertions, 0 failures, 0 errors, 0 skips** (Ruby 4.0.4 / Rails 7.2.3.1). `Gemfile.lock`: `tabs_on_rails (3.0.0)` from rubygems.org; no `i18n-active_record` git source.
+
+## [7.13.4] - 2026-05-19
+
+### Fixed
+
+- **Restore on a rich_text `create` version was asymmetric** depending on what the first save of the field happened to look like. If the field's first rich_text save was empty (e.g. opening the inline editor and saving without typing — common on top-level Apartments), the user later got a `create` (body: nil -> "") plus an `update` (body: "" -> "...") and could click Restore on the update to clear the field. If the first save already had content (more common on nested Photo descriptions), the field had only the `create` version and the 7.13.2 hide-Restore-on-create rule meant there was no Restore link at all — the user reported "I can restore the empty value on Apartments but not on the nested Photo".
+  - **`app/views/inline_forms/_versions_list.html.erb`**: show the Restore link on `:rich_text` `create` rows (still hide it on `:primary` `create` rows — those would mean destroying the parent record, which is the Destroy button's job).
+  - **`app/controllers/inline_forms_controller.rb#revert`**: when `reify` is nil and `@version.item` is an `ActionText::RichText`, treat the revert as "undo the creation" — destroy the rich_text row, `touch` the parent, and respond with the existing turbo-stream replacing the row + versions frames. Primary `create` reverts (only reachable via replayed URLs since the view hides the link) still no-op cleanly through the same handler.
+
+### Added
+
+- **`test/integration/example_app_apartment_versions_turbo_test.rb`** (installer template):
+  - `revert on rich_text create destroys the rich_text record so the field becomes empty` — pins the Apartment-side fix.
+  - `revert on nested Photo rich_text create destroys the rich_text record` — pins the originally reported nested-Photo case.
+  - `versions list shows Restore link on rich_text create rows` — pins the view-side link surfacing.
+  - `versions list hides Restore link on primary create rows but keeps it on update rows` — clarifies the asymmetry between `:primary` and `:rich_text` create rows (renames the earlier test).
+
+### Changed
+
+- **`InlineForms::VERSION`** and **`InlineFormsInstaller::VERSION`** -> `7.13.4`. Companion `validation_hints` release will follow in lockstep.
+
+### Verified
+
+- `gem build inline_forms.gemspec` -> `inline_forms-7.13.4.gem`; `gem build inline_forms_installer.gemspec` -> `inline_forms_installer-7.13.4.gem`.
+- `inline_forms create MyApp -d sqlite --example` -> `bundle exec rails test` -- **83 runs, 0 failures, 0 errors, 0 skips** (Ruby 4.0.4 / Rails 7.2.3.1).
+
 ## [7.13.3] - 2026-05-19
 
 ### Fixed

data/app/controllers/inline_forms_controller.rb

@@ -276,14 +276,27 @@ class InlineFormsController < ApplicationController
       # case a request was bookmarked or replayed: render close on the
       # current parent without mutating anything.
       if @object.nil?
+        # reify returns nil for `create` events (no prior state). For a
+        # rich_text create, reverting means "undo the creation" -> destroy
+        # the ActionText::RichText row so the parent's field reverts to
+        # empty (symmetric with reverting an update on a rich_text that
+        # was first saved empty). For a primary record we never offer
+        # Restore on `create` in the view; this branch only runs for
+        # replayed/bookmarked URLs and must remain a no-op response keyed
+        # off the parent.
         item = @version.item
-        @parent = if defined?(ActionText::RichText) && item.is_a?(ActionText::RichText)
-                    item.record
-                  else
-                    item
-                  end
-        return unless @parent
-        authorize!(:revert, @parent) if cancan_enabled?
+        if defined?(ActionText::RichText) && item.is_a?(ActionText::RichText)
+          @rich_text_record = item
+          @parent = @rich_text_record.record
+          return unless @parent
+          authorize!(:revert, @parent) if cancan_enabled?
+          @rich_text_record.destroy
+          @parent.touch if @parent.respond_to?(:touch)
+        else
+          @parent = item
+          return unless @parent
+          authorize!(:revert, @parent) if cancan_enabled?
+        end
         return unless row_html_turbo_allowed?
         respond_to do |format|
           format.turbo_stream { render_revert_turbo_streams }
@@ -310,7 +323,7 @@ class InlineFormsController < ApplicationController
 
   def extract_translations
     keys_array = []
-    I18n::Backend::ActiveRecord::Translation.order(:locale, :thekey).each do |t|
+    InlineForms::TranslationRecord.order(:locale, :thekey).each do |t|
       keys_array << deep_hashify([ t.locale, t.thekey.split('.'), t.value ].flatten)
     end
     keys_hash = {}

data/app/views/inline_forms/_versions_list.html.erb

@@ -51,11 +51,18 @@
           parent's controller, so the same path works for both kinds.
 
           PaperTrail's `reify` returns nil for `create` versions (no prior
-          state to roll back to). Reverting a `create` would mean destroying
-          the record — primary records already have a dedicated Destroy
-          button (superadmin), and rich_text content can be cleared by
-          editing. Omitting the link here keeps the UI consistent and
-          avoids a NoMethodError in the controller's `save!`.
+          state to roll back to). Reverting a `create`:
+            * on a :rich_text entry  -> destroy the ActionText::RichText
+              record, i.e. clear the field. The Restore link is shown so
+              the user can symmetrically undo "I added content" the same
+              way they can undo "I edited content" — without this, a
+              field whose rich_text was first saved with non-empty content
+              had no Restore link at all (asymmetric with parents whose
+              first save happened to be empty).
+            * on a :primary entry  -> would mean destroying the parent
+              record itself. Primary records already have a dedicated
+              Destroy button (superadmin); the Restore link stays hidden
+              so the action is never offered ambiguously here.
 
           Empty-changeset update rows (e.g. PaperTrail `touch` events from
           `belongs_to ..., touch: true` on associated ActionText::RichText
@@ -64,7 +71,7 @@
           tracking (`has_paper_trail on: [:create, :update, :destroy]`),
           but legacy apps still have these rows in the audit trail; the
           link is hidden here so the action is never offered. -%>
-      <% if version.event == "create" %>
+      <% if version.event == "create" && entry[:kind] != :rich_text %>
         &nbsp;
       <% elsif version.changeset.nil? || version.changeset.except("updated_at").empty? %>
         &nbsp;

data/docs/git-deps-assessment.md

@@ -0,0 +1,106 @@
+# Git-sourced installer dependencies — assessment
+
+**Date:** 2026-05-19  
+**Context:** Generated apps from `inline_forms create` used three non-RubyGems pins: `tabs_on_rails` (git + branch), `i18n-active_record` (git), and a commented `will_paginate` fork. This doc records why they existed and what replaced them.
+
+**Related (risk callouts only):** `validation_hints/stuff/rails-7.2-zeitwerk-plan.md` (Track A3), `validation_hints/stuff/rails-8-checklist.md` (Phase 3).
+
+---
+
+## Summary (7.13.5+)
+
+| Gem | Was | Now | Reason |
+|-----|-----|-----|--------|
+| `will_paginate` | RubyGems + commented acesuares fork | RubyGems only | Fork never active; comment removed |
+| `tabs_on_rails` | `acesuares/tabs_on_rails` branch `update_remote_before_action` | `~> 3.0` (weppos, RubyGems) | Fork only added unused `:remote` on tab links; upstream 3.0.0 already uses `before_action` |
+| `i18n-active_record` | `acesuares/i18n-active_record` (2012) | **Removed** — `InlineForms::TranslationRecord` | App never sets `I18n.backend`; only reads the `translations` **view** via AR |
+
+**No generated-app Gemfile should use `:git` for these anymore.**
+
+---
+
+## `will_paginate`
+
+- **Fork:** `https://github.com/acesuares/will_paginate.git` (commented out for years).
+- **Usage:** Nested/top-level list pagination in `_list.html.erb`; Turbo Frame nav since 7.5.x (no `:remote => true`).
+- **Verdict:** RubyGems `will_paginate` is sufficient. No acesuares-specific behavior required.
+
+---
+
+## `tabs_on_rails`
+
+### Why the fork existed
+
+Branch `update_remote_before_action` on `acesuares/tabs_on_rails` (2019) did two things:
+
+1. `before_filter` → `before_action` (Rails 4+ rename).
+2. Optional `:remote => true` on `tab_for` links (`tabs_builder.rb`).
+
+### What inline_forms actually uses
+
+- Controllers call **`set_tab :resource`** only (generator template + installer).
+- Top bar is **not** built with `tabs_tag` / `tab_for`; `_inline_forms_tabs.html.erb` is a Foundation top-bar with search + new button.
+- Turbo migration removed **`data-remote`** from inline UI; no code passes `:remote` into tabs.
+
+### Upstream today
+
+- **RubyGems:** `tabs_on_rails` **3.0.0** (weppos, 2017).
+- **`set_tab`** already uses **`before_action`** in `lib/tabs_on_rails/action_controller.rb`.
+- **Missing vs fork:** `:remote` on tab links only — **unused by inline_forms**.
+
+### Verdict
+
+**Use `gem 'tabs_on_rails', '~> 3.0'`.** No runtime dependency on the fork. Re-test on Rails 7.2+ / 8.0 when upgrading (gem is unmaintained but tiny).
+
+---
+
+## `i18n-active_record`
+
+### Why the fork existed
+
+- Upstream expects a `translations` table with column **`key`**.
+- MySQL reserves `KEY`; acesuares fork renamed to **`thekey`** with `alias_attribute :key, :thekey`.
+- Fork is **Rails 3 era** (`set_table_name`, `attr_protected`, last push 2012).
+
+### What inline_forms actually uses
+
+- Installer builds **InlineFormsKey / Locale / Translation** tables, then a SQL **VIEW** `translations` with columns `locale`, **`thekey`**, `value`, `interpolations`, `is_proc`.
+- **`I18n.backend` is never configured** to `I18n::Backend::ActiveRecord` in generated apps.
+- Only consumer: **`InlineFormsController#extract_translations`** (admin export of keys); not wired in default routes/tests.
+
+### Upstream today
+
+- **RubyGems:** `i18n-active_record` **1.4.0** (2024), Rails 7.1+ YAML serializers, column **`key`**, optional `scope`.
+- Adopting it would require renaming the view column to `key` (backtick on MySQL) and dropping the stale fork API.
+
+### Verdict
+
+**Drop the gem.** Add **`InlineForms::TranslationRecord`** (`lib/inline_forms/translation_record.rb`) as a read-only AR model on the existing view with **`thekey`**. Same behavior, no git dep, Rails 7.2-safe.
+
+If full **I18n::Backend::ActiveRecord** is needed later, pin **`i18n-active_record ~> 1.4`** and align the view schema to upstream (`key` column + initializer), not the 2012 fork.
+
+---
+
+## Previously removed forks (reference)
+
+| Gem | Removed in | Replacement |
+|-----|------------|-------------|
+| `devise-i18n` | 7.3.4 / 7.10+ | RubyGems `~> 1.16` |
+| `paper_trail` | 7.0.x | RubyGems `~> 16.0` |
+| `switch_user` | 7.2.x | Removed from installer |
+
+---
+
+## Verification
+
+After changing `installer_core.rb`:
+
+```bash
+cd /home/code/inline_forms && rvm use . && gem build inline_forms.gemspec && gem build inline_forms_installer.gemspec
+cd /home/code/testInline && rvm use .
+gem install /home/code/inline_forms/inline_forms-*.gem /home/code/inline_forms/inline_forms_installer-*.gem
+rm -rf MyApp && inline_forms create MyApp -d sqlite --example
+cd MyApp && rvm use . && bundle exec rails test
+```
+
+Expect **0 failures**; `Gemfile.lock` should list `tabs_on_rails (3.0.0)` and **no** `i18n-active_record` git source.

data/lib/inline_forms/translation_record.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+module InlineForms
+  # Read-only adapter for the +translations+ SQL view created by the installer
+  # (+inline_forms_create_view_for_translations+). The view exposes +thekey+
+  # (not +key+) so it works on MySQL where +key+ is reserved.
+  class TranslationRecord < ActiveRecord::Base
+    self.table_name = "translations"
+
+    def readonly?
+      true
+    end
+  end
+end

data/lib/inline_forms/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module InlineForms
-  VERSION = "7.13.3"
+  VERSION = "7.13.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 7.13.3
+  version: 7.13.5
 platform: ruby
 authors:
 - Ace Suares
@@ -493,6 +493,7 @@ files:
 - archived/form_elements/tree/app/helpers/form_elements/move.rb
 - archived/form_elements/tree/app/views/inline_forms/_show_tree.html.erb
 - archived/form_elements/tree/app/views/inline_forms/_tree.html.erb
+- docs/git-deps-assessment.md
 - docs/jquery-widgets.md
 - docs/prompt/.gitignore
 - docs/prompt/test-the-example-app.md
@@ -553,6 +554,7 @@ files:
 - lib/inline_forms/form_elements/text_field_helper.rb
 - lib/inline_forms/form_elements/time_helper.rb
 - lib/inline_forms/gem_files.rb
+- lib/inline_forms/translation_record.rb
 - lib/inline_forms/version.rb
 - lib/locales/inline_forms.en.yml
 - lib/locales/inline_forms.nl.yml