inline_forms 7.13.17 → 7.13.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e6d9090a4647004676dcd2301ae2fe4e4cf6be16bbd64cb88f84e3dc3aa3bcc7
-  data.tar.gz: 629d640307657cac5175ea3687c8ee429ec97f31b7e1aff7b8d1831de856d2b3
+  metadata.gz: 899f49c45deb98aa07e86729fc4086d739d4afe73ffaea0bdc73ad1ce0f2a667
+  data.tar.gz: f6b30e56aef71c6ce4097702fd2af8e0d8a224a77e7859350f77dfc9df52466e
 SHA512:
-  metadata.gz: a687a847ca5160a286833c3d31e30a4252575835caffe22685d6d28b068630df17fc80c46ddb1191505556b40f38d3b3744a034c0ca27778070e014ce184aad4
-  data.tar.gz: 25ea25595e6daedacc3af36bdbf7bc9ad1b0c4c71f841ff77e092f5e59d1380f025a3754c95df9e5e84a23cbbfe93e9462f9467b6a3f7ee41886c3c93d6b584b
+  metadata.gz: 98dc21591bfe38e86e110905ca1bad96e4e58e121d718acc07d6af4bfe4278eb0c6912d5c36d9884ccacf3ce00aeb7790ae00e1de6127b8bec9a8bfd4e4c9cbc
+  data.tar.gz: c2bab0e4ba2ed6654e324d941ced0b98e71a4183e88fb787f9af0d80c8d6310543dbe30716ac7e4bfc2dbcbfea702291d2447373512939933f8acb2290dc17ea

data/CHANGELOG.md

@@ -4,6 +4,16 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [7.13.18] - 2026-05-22
+
+### Removed
+
+- **DB-backed translations:** installer no longer generates `InlineFormsLocale`, `InlineFormsKey`, `InlineFormsTranslation`, or the `translations` SQL view migration. Removed `InlineForms::TranslationRecord`, `InlineFormsController#extract_translations`, its view, and YAML-export helpers (`deep_hashify`, `deep_merge`, `unravel`). Apps use standard Rails I18n YAML under `config/locales/` (e.g. `inline_forms_local.en.yml`); the old `i18n-active_record` path was never wired.
+
+### Changed
+
+- **`InlineForms::VERSION`** and **`InlineFormsInstaller::VERSION`** → **7.13.18** (lockstep with **validation_hints**).
+
 ## [7.13.17] - 2026-05-21
 
 ### Fixed

data/app/controllers/inline_forms_controller.rb

@@ -321,18 +321,6 @@ class InlineFormsController < ApplicationController
     end
   end
 
-  def extract_translations
-    keys_array = []
-    InlineForms::TranslationRecord.order(:locale, :thekey).each do |t|
-      keys_array << deep_hashify([ t.locale, t.thekey.split('.'), t.value ].flatten)
-    end
-    keys_hash = {}
-    keys_array.each do |h|
-      keys_hash = deep_merge(keys_hash, h)
-    end
-    @display_array = unravel(keys_hash)
-  end
-
   private
 
   # Versions list lives in +<turbo-frame id="…_versions">+; POST +restore+ would otherwise
@@ -478,26 +466,6 @@ class InlineFormsController < ApplicationController
     params.require(:id)
   end
 
-  def deep_hashify(ary)
-    return ary.to_s if ary.length == 1
-    { ary.shift => deep_hashify(ary) }
-  end
-
-  def deep_merge(h1, h2)
-    return h1.merge(h2) unless h2.first[1].is_a? Hash
-    h1.merge(h2){|key, first, second| deep_merge(first, second)}
-  end
-
-  def unravel(deep_hash, level=-1)
-    level += 1
-    return "#{'  '*level}\"#{deep_hash.first[0]}\": \"#{deep_hash.first[1]}\"\n" unless deep_hash.first[1].is_a? Hash
-    a = "#{'  '*level}\"#{deep_hash.first[0]}\":\n"
-    deep_hash.first[1].each do |k,v|
-      a << unravel( { k => v}, level)
-    end
-    a
-  end
-
   def revert_params
     params.require(:id).permit(:update)
   end

data/docs/git-deps-assessment.md

@@ -13,7 +13,7 @@
 |-----|-----|-----|--------|
 | `will_paginate` | RubyGems + commented acesuares fork | RubyGems only | Fork never active; comment removed |
 | `tabs_on_rails` | `acesuares/tabs_on_rails` branch `update_remote_before_action` | `~> 3.0` (weppos, RubyGems) | Fork only added unused `:remote` on tab links; upstream 3.0.0 already uses `before_action` |
-| `i18n-active_record` | `acesuares/i18n-active_record` (2012) | **Removed** — `InlineForms::TranslationRecord` | App never sets `I18n.backend`; only reads the `translations` **view** via AR |
+| `i18n-active_record` | `acesuares/i18n-active_record` (2012) | **Removed** (7.13.18: no DB translation tables) | Never configured `I18n.backend`; DB tables/view and `extract_translations` removed |
 
 **No generated-app Gemfile should use `:git` for these anymore.**
 
@@ -56,28 +56,15 @@ Branch `update_remote_before_action` on `acesuares/tabs_on_rails` (2019) did two
 
 ## `i18n-active_record`
 
-### Why the fork existed
-
-- Upstream expects a `translations` table with column **`key`**.
-- MySQL reserves `KEY`; acesuares fork renamed to **`thekey`** with `alias_attribute :key, :thekey`.
-- Fork is **Rails 3 era** (`set_table_name`, `attr_protected`, last push 2012).
-
-### What inline_forms actually uses
-
-- Installer builds **InlineFormsKey / Locale / Translation** tables, then a SQL **VIEW** `translations` with columns `locale`, **`thekey`**, `value`, `interpolations`, `is_proc`.
-- **`I18n.backend` is never configured** to `I18n::Backend::ActiveRecord` in generated apps.
-- Only consumer: **`InlineFormsController#extract_translations`** (admin export of keys); not wired in default routes/tests.
+### History
 
-### Upstream today
-
-- **RubyGems:** `i18n-active_record` **1.4.0** (2024), Rails 7.1+ YAML serializers, column **`key`**, optional `scope`.
-- Adopting it would require renaming the view column to `key` (backtick on MySQL) and dropping the stale fork API.
-
-### Verdict
+- Fork existed because MySQL reserves `KEY`; acesuares fork used **`thekey`**.
+- **7.13.5–7.13.17:** gem removed from Gemfile; installer still generated locale/key/translation tables + `translations` view; **`InlineForms::TranslationRecord`** read the view; **`extract_translations`** exported YAML (never routed by default).
+- **`I18n.backend` was never** `I18n::Backend::ActiveRecord` in generated apps.
 
-**Drop the gem.** Add **`InlineForms::TranslationRecord`** (`lib/inline_forms/translation_record.rb`) as a read-only AR model on the existing view with **`thekey`**. Same behavior, no git dep, Rails 7.2-safe.
+### Verdict (7.13.18+)
 
-If full **I18n::Backend::ActiveRecord** is needed later, pin **`i18n-active_record ~> 1.4`** and align the view schema to upstream (`key` column + initializer), not the 2012 fork.
+**No DB translation layer.** Generated apps use Rails I18n YAML only (`config/locales/inline_forms_local.en.yml`, etc.). If **I18n::Backend::ActiveRecord** is needed later, add **`i18n-active_record ~> 1.4`** and migrations separately—not via inline_forms installer.
 
 ---
 

data/lib/inline_forms/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module InlineForms
-  VERSION = "7.13.17"
+  VERSION = "7.13.18"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 7.13.17
+  version: 7.13.18
 platform: ruby
 authors:
 - Ace Suares
@@ -457,7 +457,6 @@ files:
 - app/views/inline_forms/_versions.html.erb
 - app/views/inline_forms/_versions_list.html.erb
 - app/views/inline_forms/create_list_frame.html.erb
-- app/views/inline_forms/extract_translations.erb
 - app/views/inline_forms/field_edit.html.erb
 - app/views/inline_forms/field_show.html.erb
 - app/views/inline_forms/new_record.html.erb
@@ -548,14 +547,11 @@ files:
 - lib/inline_forms/form_elements/text_field_helper.rb
 - lib/inline_forms/form_elements/time_helper.rb
 - lib/inline_forms/gem_files.rb
-- lib/inline_forms/translation_record.rb
 - lib/inline_forms/turbo_tabs_builder.rb
 - lib/inline_forms/version.rb
 - lib/locales/inline_forms.en.yml
 - lib/locales/inline_forms.nl.yml
-- lib/otherstuff/20120310065554_inline_forms_create_view_for_translations.rb
 - lib/otherstuff/add_roles.sql
-- lib/otherstuff/mkiftrans
 - lib/otherstuff/mkrole
 - lib/otherstuff/roles_users.sql
 - lib/vagrant/vagrantbox-inline_forms.zip

data/app/views/inline_forms/extract_translations.erb

@@ -1,4 +0,0 @@
-
-<pre>
-<%= @display_array%>
-</pre>

data/lib/inline_forms/translation_record.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-module InlineForms
-  # Read-only adapter for the +translations+ SQL view created by the installer
-  # (+inline_forms_create_view_for_translations+). The view exposes +thekey+
-  # (not +key+) so it works on MySQL where +key+ is reserved.
-  class TranslationRecord < ActiveRecord::Base
-    self.table_name = "translations"
-
-    def readonly?
-      true
-    end
-  end
-end

data/lib/otherstuff/20120310065554_inline_forms_create_view_for_translations.rb

@@ -1,16 +0,0 @@
-class InlineFormsCreateViewForTranslations < ActiveRecord::Migration
-
-execute 'CREATE VIEW translations  ( locale, thekey, value, interpolations, is_proc )
-              AS
-              SELECT L.name, K.name, T.value, T.interpolations, T.is_proc
-              FROM if_keys K, if_locales L, if_translations T
-              WHERE T.if_key_id = K.id AND T.i_locale_id = L.id '
-
-  end
-
-  def self.down
-    execute 'DROP VIEW translations'
-  end
-
-
-end

data/lib/otherstuff/mkiftrans

@@ -1,21 +0,0 @@
-#!/bin/bash
-rails g inline_forms IFLocale \
-  name:string \
-  if_translations:belongs_to \
-  _enabled:yes _presentation:'#{name}' -f
-
-rails g inline_forms IFKey \
-  name:string \
-  if_translations:has_many if_translations:associated \
-  _enabled:yes _presentation:'#{name}' -f
-
-rails g inline_forms IFTranslation \
-  if_key:belongs_to \
-  if_locale:dropdown \
-  value:text \
-  interpolations:text \
-  is_proc:boolean \
-  _presentation:'#{value}' -f
-
-bundle exec rake db:migrate
-