inline_forms 7.10.2 → 7.11.0

data/lib/installer_templates/example_app_tests/test/integration/example_app_apartment_versions_turbo_test.rb

@@ -1,120 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../example_app/example_integration_test_case"
-
-class ExampleAppApartmentVersionsTurboTest < ExampleAppIntegrationTestCase
-  setup do
-    @apartment = Apartment.first || Apartment.create!(name: "Versions Turbo", title: "T")
-    @versions_frame = "apartment_#{@apartment.id}_versions"
-    @headers = { "Turbo-Frame" => @versions_frame, "Accept" => "text/html" }
-  end
-
-  test "versions list opens inside matching turbo-frame" do
-    get list_versions_apartment_path(@apartment, update: @versions_frame), headers: @headers
-    assert_response :success
-    assert_includes @response.body, %(<turbo-frame id="#{@versions_frame}">)
-    assert_includes @response.body, "Changeset"
-    refute_includes @response.body, 'data-remote="true"'
-  end
-
-  test "versions list close returns panel header inside turbo-frame" do
-    get list_versions_apartment_path(@apartment, update: @versions_frame, close: true),
-        headers: @headers
-    assert_response :success
-    assert_includes @response.body, %(<turbo-frame id="#{@versions_frame}">)
-    refute_includes @response.body, "Changeset"
-  end
-
-  test "expanded row versions open link uses Turbo not UJS remote" do
-    row_frame = "apartment_#{@apartment.id}"
-    get apartment_path(@apartment, update: row_frame),
-        headers: { "Turbo-Frame" => row_frame, "Accept" => "text/html" }
-    assert_response :success
-    assert_select "turbo-frame##{@versions_frame} a[data-turbo='true'][data-turbo-frame='#{@versions_frame}']", minimum: 1
-    refute_select "turbo-frame##{@versions_frame} a[data-remote='true']"
-  end
-
-  test "restore link in versions list requests turbo-stream (nested versions frame)" do
-    apt = Apartment.create!(name: "Stream Link", title: "T")
-    apt.update!(title: "T2")
-    vf = "apartment_#{apt.id}_versions"
-    get list_versions_apartment_path(apt, update: vf),
-        headers: { "Turbo-Frame" => vf, "Accept" => "text/html" }
-    assert_response :success
-    assert_match(/data-turbo-stream="true"/, @response.body,
-      "restore from inside …_versions must use turbo-stream to avoid Turbo-Frame mismatch")
-  end
-
-  test "revert from versions list closes row via turbo-stream when Turbo-Frame is versions" do
-    apt = Apartment.create!(name: "Versions Stream Revert", title: "Before")
-    apt.update!(title: "After")
-    row_frame = "apartment_#{apt.id}"
-    versions_frame = "#{row_frame}_versions"
-    version = apt.versions.where(event: "update").order(:id).last
-    assert version, "expected an update version to revert"
-
-    post revert_apartment_path(version.id, update: row_frame),
-         headers: {
-           "Turbo-Frame" => versions_frame,
-           "Accept" => "text/vnd.turbo-stream.html"
-         }
-    assert_response :success
-    assert_includes @response.body, %(action="replace")
-    assert_includes @response.body, %(target="#{row_frame}")
-    assert_includes @response.body, %(target="#{versions_frame}")
-    assert_equal "Before", apt.reload.title
-  end
-
-  test "revert from versions list closes row via Turbo POST on row frame" do
-    apt = Apartment.create!(name: "Versions Revert", title: "Before")
-    apt.update!(title: "After")
-    row_frame = "apartment_#{apt.id}"
-    versions_frame = "#{row_frame}_versions"
-    # 7.9.0 dropped the `format.html` fallback in `revert`; the restore link
-    # always requests a turbo-stream now, even when the click happened on
-    # the row frame, so the test mirrors that contract.
-    row_headers = {
-      "Turbo-Frame" => row_frame,
-      "Accept" => "text/vnd.turbo-stream.html"
-    }
-
-    version = apt.versions.where(event: "update").order(:id).last
-    assert version, "expected an update version to revert"
-
-    post revert_apartment_path(version.id, update: row_frame), headers: row_headers
-    assert_response :success
-    assert_includes @response.body, %(action="replace")
-    assert_includes @response.body, %(target="#{row_frame}")
-    assert_includes @response.body, %(target="#{versions_frame}")
-    assert_equal "Before", apt.reload.title
-  end
-
-  test "revert from versions list restores rich_text body via turbo-stream" do
-    apt = Apartment.create!(name: "RichText Revert", title: "T")
-    apt.update!(description: "<p>old body</p>")
-    apt.update!(description: "<p>new body</p>")
-
-    rich_text = ActionText::RichText.find_by!(
-      record_type: Apartment.name, record_id: apt.id, name: "description"
-    )
-    rich_text_version = rich_text.versions.where(event: "update").order(:id).last
-    assert rich_text_version,
-      "expected a PaperTrail update version on ActionText::RichText for the description edit"
-
-    row_frame = "apartment_#{apt.id}"
-    versions_frame = "#{row_frame}_versions"
-    post revert_apartment_path(rich_text_version.id, update: row_frame),
-         headers: {
-           "Turbo-Frame" => versions_frame,
-           "Accept" => "text/vnd.turbo-stream.html"
-         }
-    assert_response :success
-    assert_includes @response.body, %(action="replace")
-    assert_includes @response.body, %(target="#{row_frame}")
-    assert_includes @response.body, %(target="#{versions_frame}")
-
-    apt.reload
-    assert_includes apt.description.body.to_html, "old body",
-      "rich_text revert should restore the previous body content"
-  end
-end

data/lib/installer_templates/example_app_tests/test/integration/example_app_guest_access_test.rb

@@ -1,21 +0,0 @@
-# frozen_string_literal: true
-
-require "test_helper"
-require "devise/test/integration_helpers"
-
-class ExampleAppGuestAccessTest < ActionDispatch::IntegrationTest
-  include Devise::Test::IntegrationHelpers
-
-  setup { host!("www.example.com") }
-
-  test "apartments index redirects when not signed in" do
-    get apartments_path
-    assert_response :redirect
-    assert_match %r{/auth/users/sign_in}, @response.redirect_url
-  end
-
-  test "root redirects when not signed in" do
-    get root_path
-    assert_response :redirect
-  end
-end

data/lib/installer_templates/example_app_tests/test/integration/example_app_photo_revert_test.rb

@@ -1,94 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../example_app/example_integration_test_case"
-
-# 7.9.0 regression: revert from the versions panel for a Photo whose
-# `image` column changed must put back the previous CarrierWave file
-# bytes, not just the previous filename string. Relies on the
-# `ImageUploader` knobs the installer ships:
-#
-#   * `CarrierWave.configure { config.remove_previously_stored_files_after_update = false }`
-#     (config/initializers/carrierwave.rb)
-#   * `remove!` no-op
-#   * unique per-upload filename prefix
-#
-# See https://stackoverflow.com/questions/9423279/papertrail-and-carrierwave
-class ExampleAppPhotoRevertTest < ExampleAppIntegrationTestCase
-  # Mirror the setup of ExampleAppApartmentPhotosPaginationTest: re-seed
-  # Konferensha photos from db/seed_images/ so the test asserts against
-  # real CarrierWave file mounts without depending on dev DB state.
-  setup do
-    @apartment = Apartment.find_or_create_by!(name: "Konferensha") do |a|
-      a.title = "Konferensha sobre Papiamentu"
-    end
-    seed_dir = Rails.root.join("db", "seed_images")
-    if seed_dir.directory?
-      Dir.glob(seed_dir.join("*.{jpg,jpeg,png,gif}"), File::FNM_CASEFOLD).sort.each do |abs|
-        base = File.basename(abs)
-        next if Photo.exists?(name: base, apartment_id: @apartment.id)
-        File.open(abs, "rb") do |io|
-          Photo.create!(
-            name: base,
-            caption: "Konferensha foto #{base}",
-            apartment: @apartment,
-            image: io
-          )
-        end
-      end
-    end
-  end
-
-  test "revert restores previous CarrierWave file bytes on disk" do
-    photo = @apartment.photos.first!
-    original_identifier = photo.image.identifier
-    original_path = photo.image.path
-    assert File.exist?(original_path), "expected seeded photo file on disk: #{original_path}"
-    original_size = File.size(original_path)
-
-    seed_dir = Rails.root.join("db", "seed_images")
-    jpgs = Dir.glob(seed_dir.join("*.{jpg,jpeg}"), File::FNM_CASEFOLD).sort
-    replacement = jpgs.find { |abs| File.basename(abs) != photo.name } || jpgs.last
-    assert replacement, "need at least one seed jpg different from the photo's current mount"
-    refute_equal File.size(replacement), original_size,
-      "test needs a replacement file with a different byte length so the assertion is meaningful"
-
-    frame_id = "apartment_#{@apartment.id}_photo_#{photo.id}_image"
-    turbo_headers = { "Turbo-Frame" => frame_id, "Accept" => "text/html" }
-    uploaded = Rack::Test::UploadedFile.new(replacement, "image/jpeg")
-    put photo_path(
-      photo,
-      attribute: "image",
-      form_element: "image_field",
-      update: frame_id
-    ),
-        params: { image: uploaded },
-        headers: turbo_headers
-    assert_response :success
-    photo.reload
-    refute_equal original_identifier, photo.image.identifier,
-      "update should have changed the image identifier"
-
-    version = photo.versions.where(event: "update").order(:id).last
-    assert version, "expected a Photo update version after the image PUT"
-
-    row_frame = "apartment_#{@apartment.id}_photo_#{photo.id}"
-    versions_frame = "apartment_#{@apartment.id}_photo_#{photo.id}_versions"
-    post revert_photo_path(version.id, update: row_frame),
-         headers: {
-           "Turbo-Frame" => versions_frame,
-           "Accept" => "text/vnd.turbo-stream.html"
-         }
-    assert_response :success
-    assert_includes @response.body, %(action="replace")
-    assert_includes @response.body, %(target="#{row_frame}")
-    assert_includes @response.body, %(target="#{versions_frame}")
-
-    photo.reload
-    assert_equal original_identifier, photo.image.identifier,
-      "revert should restore the previous CarrierWave identifier"
-    assert File.exist?(photo.image.path),
-      "revert should leave the previous file bytes on disk (carrierwave config)"
-    assert_equal original_size, File.size(photo.image.path),
-      "previous file bytes must be byte-identical to the original"
-  end
-end

data/lib/installer_templates/example_app_tests/test/integration/example_app_photos_test.rb

@@ -1,22 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../example_app/example_integration_test_case"
-
-class ExampleAppPhotosTest < ExampleAppIntegrationTestCase
-  setup do
-    @apartment = Apartment.create!(name: "Beach", title: "Ocean view")
-  end
-
-  test "photos are not served as standalone html resource" do
-    assert Photo.not_accessible_through_html?
-    assert_raises(ActionController::UnknownFormat) do
-      get photos_path
-    end
-  end
-
-  test "can create a photo for an apartment" do
-    assert_difference("Photo.count", 1) do
-      Photo.create!(name: "Sunset", apartment: @apartment)
-    end
-  end
-end

data/lib/installer_templates/example_app_tests/test/integration/example_app_routing_test.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../example_app/example_integration_test_case"
-
-class ExampleAppRoutingTest < ExampleAppIntegrationTestCase
-  test "root routes to apartments index" do
-    get root_path
-    assert_response :success
-  end
-
-  test "apartments index is reachable when signed in" do
-    get apartments_path
-    assert_response :success
-  end
-end

data/lib/installer_templates/example_app_tests/test/integration/example_app_turbo_layout_test.rb

@@ -1,25 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../example_app/example_integration_test_case"
-
-# Smoke test: layouts load Turbo as an ES module (no Sprockets ESM parse error).
-# Step 5 (7.8.0) leaves Turbo Drive at its default (enabled); inline flows use
-# `<turbo-frame>` + HTML, not jquery-ujs.
-class ExampleAppTurboLayoutTest < ExampleAppIntegrationTestCase
-  test "inline_forms layout loads turbo.min.js as an ES module" do
-    get apartments_path
-    assert_response :success
-
-    assert_match(
-      %r{<script\s+type="module">\s*import\s+\{\s*Turbo\s*\}\s+from\s+"[^"]*turbo\.min(?:-[a-f0-9]+)?\.js"}m,
-      @response.body,
-      "expected the inline_forms layout to import turbo.min.js as a module"
-    )
-
-    refute_match(
-      /Turbo\.session\.drive\s*=\s*false/,
-      @response.body,
-      "Step 5 enables Turbo Drive by default; disabling it would regress full-page Turbo"
-    )
-  end
-end

data/lib/installer_templates/example_app_tests/test/integration/example_app_validation_hints_test.rb

@@ -1,40 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../example_app/example_integration_test_case"
-
-class ExampleAppValidationHintsTest < ExampleAppIntegrationTestCase
-  setup do
-    @apartment = Apartment.find_or_create_by!(name: "Konferensha") do |a|
-      a.title = "Konferensha sobre Papiamentu"
-    end
-    @row_frame = "apartment_#{@apartment.id}"
-    @row_headers = { "Turbo-Frame" => @row_frame, "Accept" => "text/html" }
-    @list_frame = "apartments_list"
-    @list_headers = { "Turbo-Frame" => @list_frame, "Accept" => "text/html" }
-  end
-
-  test "show panel name label uses hidden HTML source not title attribute" do
-    get apartment_path(@apartment, update: @row_frame), headers: @row_headers
-    assert_response :success
-
-    hint_id = "validation_hints_apartment_#{@apartment.id}_name"
-    assert_includes @response.body, %(class="validation-hint-trigger has-tip tip-top")
-    assert_includes @response.body, %(data-validation-hints-source="#{hint_id}")
-    assert_includes @response.body, %(id="#{hint_id}")
-    assert_includes @response.body, "Name can&#39;t be blank"
-    assert_includes @response.body, '<ul class="validation-hints-list">'
-    refute_match(%r{title="&lt;ul}, @response.body)
-    refute_match(%r{title='<ul}, @response.body)
-  end
-
-  test "new apartment form shows validation hint on name" do
-    get new_apartment_path(update: @list_frame), headers: @list_headers
-    assert_response :success
-
-    hint_id = "validation_hints_apartment_new_name"
-    assert_includes @response.body, %(data-validation-hints-source="#{hint_id}")
-    assert_includes @response.body, %(id="#{hint_id}")
-    assert_includes @response.body, "Name can&#39;t be blank"
-    assert_includes @response.body, '<ul class="validation-hints-list">'
-  end
-end

data/lib/installer_templates/example_app_tests/test/models/example_app_apartment_name_validation_test.rb

@@ -1,16 +0,0 @@
-# frozen_string_literal: true
-
-require "test_helper"
-
-class ExampleAppApartmentNameValidationTest < ActiveSupport::TestCase
-  test "apartment requires name" do
-    apartment = Apartment.new(title: "No name")
-    assert_not apartment.valid?
-    assert_includes apartment.errors[:name], "can't be blank"
-  end
-
-  test "apartment is valid with name" do
-    apartment = Apartment.new(name: "North", title: "Tower")
-    assert apartment.valid?
-  end
-end

data/lib/installer_templates/example_app_tests/test/models/example_app_apartment_photo_test.rb

@@ -1,26 +0,0 @@
-# frozen_string_literal: true
-
-require "test_helper"
-
-class ExampleAppApartmentPhotoTest < ActiveSupport::TestCase
-  setup do
-    @apartment = Apartment.create!(name: "North", title: "Tower")
-    @photo = Photo.create!(name: "Lobby", apartment: @apartment)
-  end
-
-  test "photo belongs to apartment" do
-    assert_equal @apartment, @photo.apartment
-  end
-
-  test "apartment has many photos" do
-    assert_includes @apartment.photos.to_a, @photo
-  end
-
-  test "photo model hides resource from standalone html crud" do
-    assert Photo.not_accessible_through_html?
-  end
-
-  test "apartment model allows standalone html crud" do
-    assert_not Apartment.not_accessible_through_html?
-  end
-end

data/lib/installer_templates/example_app_tests/test/models/example_app_paper_trail_changeset_test.rb

@@ -1,78 +0,0 @@
-# frozen_string_literal: true
-
-require "test_helper"
-
-# Regression: PaperTrail (>= 13) deserializes `versions.object_changes` via
-# `YAML.safe_load`, using `ActiveRecord.yaml_column_permitted_classes` as the
-# allow-list. Rails 7's default is `[Symbol]`, so any update that touches
-# `updated_at` (an `ActiveSupport::TimeWithZone`) raises `Psych::DisallowedClass`
-# inside `version.changeset`, and PaperTrail rescues that into `{}`. The
-# inline_forms versions list then renders every changeset as `empty`.
-#
-# The installer ships `config/initializers/paper_trail_yaml_safe_load.rb`,
-# which extends the allow-list. This test fails if that initializer is
-# missing or insufficient.
-class ExampleAppPaperTrailChangesetTest < ActiveSupport::TestCase
-  test "version.changeset round-trips a normal update" do
-    PaperTrail.request.whodunnit = "test"
-
-    apartment = Apartment.create!(name: "Original", title: "Old Title")
-    apartment.update!(name: "Renamed", title: "New Title")
-
-    version = apartment.versions.last
-    assert_equal "update", version.event,
-      "expected an update version to be recorded by paper_trail"
-
-    changeset = version.changeset
-    assert_kind_of Hash, changeset
-    refute_empty changeset,
-      "version.changeset is empty; PaperTrail's YAML.safe_load probably hit a " \
-      "DisallowedClass and returned {}. Check " \
-      "config/initializers/paper_trail_yaml_safe_load.rb and the Rails " \
-      "ActiveRecord.yaml_column_permitted_classes setting."
-
-    assert_equal ["Original", "Renamed"], changeset["name"]
-    assert_equal ["Old Title", "New Title"], changeset["title"]
-  end
-
-  # `has_rich_text :description` lives in the `action_text_rich_texts` table,
-  # so `has_paper_trail` on Apartment cannot see body edits. The installer adds
-  # `config/initializers/rich_text_paper_trail.rb` (which declares
-  # `has_paper_trail` on `ActionText::RichText`), and `inline_forms_versions_for`
-  # merges rich-text versions into the parent's history. This test fails if
-  # either piece regresses.
-  test "rich_text edits surface in the merged versions list for the parent" do
-    PaperTrail.request.whodunnit = "test"
-
-    apartment = Apartment.create!(name: "RT", title: "RT", description: "v1 body")
-    apartment.update!(description: "v2 body")
-
-    rich_text = ActionText::RichText.find_by!(
-      record_type: Apartment.name, record_id: apartment.id, name: "description"
-    )
-    assert rich_text.respond_to?(:versions),
-      "ActionText::RichText is missing has_paper_trail; check " \
-      "config/initializers/rich_text_paper_trail.rb"
-    refute_empty rich_text.versions,
-      "no PaperTrail versions on ActionText::RichText; the on_load hook " \
-      "in config/initializers/rich_text_paper_trail.rb did not fire or " \
-      "has_paper_trail was not applied"
-
-    helper = Class.new { include InlineFormsHelper }.new
-    entries = helper.inline_forms_versions_for(apartment)
-
-    rich_text_entries = entries.select { |e| e[:kind] == :rich_text }
-    refute_empty rich_text_entries,
-      "inline_forms_versions_for did not return any rich_text entries"
-
-    body_changes = rich_text_entries
-      .map { |e| e[:version].changeset }
-      .select { |cs| cs && cs["body"].is_a?(Array) }
-      .map { |cs| cs["body"] }
-
-    refute_empty body_changes,
-      "no body changesets recorded for ActionText::RichText"
-    assert body_changes.any? { |old, new_| old.to_s.include?("v1 body") && new_.to_s.include?("v2 body") },
-      "expected an entry whose body change moves from 'v1 body' to 'v2 body'; got #{body_changes.inspect}"
-  end
-end

data/lib/installer_templates/example_app_tests/test/models/example_app_plain_text_rich_text_edge_cases_test.rb

@@ -1,46 +0,0 @@
-# frozen_string_literal: true
-
-require "test_helper"
-
-class ExampleAppPlainTextRichTextEdgeCasesTest < ActiveSupport::TestCase
-  def with_temporary_inline_forms_attribute_list(klass, temporary_list)
-    original = klass.instance_method(:inline_forms_attribute_list)
-    klass.define_method(:inline_forms_attribute_list) { temporary_list }
-    yield
-  ensure
-    klass.define_method(:inline_forms_attribute_list, original)
-  end
-
-  test "plain_text mapped to actiontext-backed attribute raises configuration error" do
-    with_temporary_inline_forms_attribute_list(
-      Apartment,
-      [[:description, "description", :plain_text]]
-    ) do
-      error = assert_raises(InlineForms::PlainTextColumnMissingError) do
-        InlineForms.validate_plain_text_configuration_for!(Apartment)
-      end
-      assert_includes(error.message, "description")
-      assert_includes(error.message, ":rich_text")
-    end
-  end
-
-  test "plain_text runtime guard raises before assigning unknown DB attribute" do
-    apartment = Apartment.create!(name: "Mismatch", title: "Check")
-    assert_raises(InlineForms::PlainTextColumnMissingError) do
-      InlineForms.assert_plain_text_column!(
-        object: apartment,
-        attribute: :description,
-        form_element: :plain_text
-      )
-    end
-  end
-
-  test "switching text column field from plain_text to rich_text does not raise" do
-    with_temporary_inline_forms_attribute_list(
-      Role,
-      [[:description, "description", :rich_text]]
-    ) do
-      InlineForms.validate_plain_text_configuration_for!(Role)
-    end
-  end
-end

data/lib/installer_templates/example_app_views/apartments/name_list.html.erb

@@ -1,26 +0,0 @@
-<% @inline_forms_turbo_field = true %>
-<div class="row">
-  <div class="small-12 columns">
-    <h2>Apartment names (first 10)</h2>
-    <p>
-      <%= link_to "Back to full apartment list", apartments_path %>
-    </p>
-    <p class="help-text">
-      Each name is an inline edit via <code>text_field_show</code> — no stock
-      <code>_show</code> panel. Click a name to edit it in place.
-    </p>
-  </div>
-</div>
-
-<% @apartments.each do |apartment| %>
-  <div class="row">
-    <div class="small-2 columns">
-      <%= apartment.id %>
-    </div>
-    <div class="small-10 columns">
-      <turbo-frame id="apartment_<%= apartment.id %>_name">
-        <%= text_field_show(apartment, :name) %>
-      </turbo-frame>
-    </div>
-  </div>
-<% end %>

data/lib/installer_templates/example_app_views/inline_forms/_header.html.erb

@@ -1,45 +0,0 @@
-<div class="contain-to-grid fixed">
-  <nav id='inline_forms_application_top_bar' class="top-bar">
-    <div class="top-bar-left">
-      <ul class="menu">
-        <li class="menu-text">
-          <h1 style="margin: 0; font-size: inherit;"><a href="/"><%= application_name %> v<%= inline_forms_version %> <%= current_user.name %></a></h1>
-        </li>
-      </ul>
-    </div>
-    <div class="top-bar-right">
-      <ul class="dropdown menu" data-dropdown-menu>
-        <% if current_user.role?(:admin) || current_user.role?(:superadmin) %>
-          <li>
-            <a href="#"><%= t 'common.more' %></a>
-            <ul class="menu">
-              <% MODEL_TABS.each do |m| %>
-                <% model = m.singularize.camelcase.constantize rescue nil %>
-                  <% unless model.nil? || model.not_accessible_through_html? %>
-                  <% if can? :update, model %>
-                  <li>
-                    <%= link_to model.model_name.human, '/' +  m %>
-                  </li>
-                  <% end %>
-                <% end %>
-              <% end %>
-              <% if can? :read, Apartment %>
-              <li>
-                <%= link_to "Apartment names (first 10)", apartment_name_list_path %>
-              </li>
-              <% end %>
-            </ul>
-          </li>
-        <% end %>
-        <li>
-          <a href="#"><%= current_user.name %></a>
-          <ul class="menu">
-            <li>
-              <%= link_to( t("common.logout"), destroy_user_session_path, :method => :delete) if current_user  %>
-            </li>
-          </ul>
-        </li>
-      </ul>
-    </div>
-  </nav>
-</div>