inheritance_integer_type 0.1.3 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e932d673791b85556b6b801aaa5c95bac18874349a439f66a5f8e0caa86b057f
-  data.tar.gz: cba578bdfa831665545c8d434d217352d7cacb5e5d6e127be56f2752e6dce438
+  metadata.gz: 5eed88208785bd41ac4e3b7959526aaa500c744d1d00e0914df67fc3d4595e37
+  data.tar.gz: b5309eae3ff8d8b826497ec05390a12b709d3b00fb9e3a6a28be89954b981101
 SHA512:
-  metadata.gz: 995c8ac0ec86a511f2e3be2af931edea4b60e0989a509807b51e3f3ea5258145919921808bea74ad8267e767d464b53b814fdb9c9999c2bb3619018cffd9844f
-  data.tar.gz: 8c87eba6859ed899affdd8ffa2344bc93d38d5631855a3057eced8efb223b17e8df3a5abaacd638814f2a4bf8ce6aeb85dad4530ec5284bbf2e9af25aab585e4
+  metadata.gz: 1bbd3b8a7f178423902628e11598c65352350c0f8c509e484597c003cee66b2decfa8cdb8fba5a0e322330211d71b3069ff99ba455df0edda2778389a28cb3b0
+  data.tar.gz: afba16f3559dc14dd7cae13c8bbdea82a12f9bd0860a6517d0e0971cb0dcf898a3cd3cbdb8530145254c683922c689c7b15791bb54ba58da4d98fe3c5d8daa8e

data/.github/workflows/ci.yaml

@@ -0,0 +1,47 @@
+---
+name: CI
+
+on:
+  workflow_dispatch:
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby-version:
+          - 3.0
+          - 3.1
+          - 3.2
+        active-record-version:
+          - 6.1.0
+          - 7.0.0
+          - 7.1.0
+        exclude:
+          - ruby-version: 3.2
+            active-record-version: 6.0.0
+          - ruby-version: 3.2
+            active-record-version: 6.1.0
+          - ruby-version: 3.2
+            active-record-version: 7.0.0
+          - ruby-version: 3.1
+            active-record-version: 6.0.0
+          - ruby-version: 3.1
+            active-record-version: 6.1.0
+          - ruby-version: 3.0
+            active-record-version: 6.0.0
+    env:
+      ACTIVE_RECORD_VERSION: "${{ matrix.active-record-version }}"
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: "${{ matrix.ruby-version }}"
+          bundler-cache: true
+      - name: Run tests
+        run: bundle exec rspec --format documentation

data/.github/workflows/gem-push.yaml

@@ -0,0 +1,30 @@
+name: Ruby Gem
+
+on:
+  release:
+    types: [ published ]
+
+jobs:
+  build:
+    name: Build + Publish
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Ruby 3.1
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 3.1
+
+    - name: Publish to RubyGems
+      env:
+        GEM_HOST_API_KEY: "${{secrets.RUBYGEMS_AUTH_TOKEN}}"
+      run: |
+        mkdir -p $HOME/.gem
+        touch $HOME/.gem/credentials
+        chmod 0600 $HOME/.gem/credentials
+        printf -- "---\n:rubygems_api_key: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
+        gem build *.gemspec
+        gem push *.gem

data/.gitignore

@@ -24,6 +24,8 @@ build/
 /.bundle/
 /lib/bundler/man/
 
+Gemfile.lock
+
 # for a library or gem, you might want to ignore these files since the code is
 # intended to run in multiple environments; otherwise, check them in:
 # Gemfile.lock

data/.ruby-version

@@ -0,0 +1 @@
+3.1.4

data/Gemfile

@@ -2,3 +2,16 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in inheritance_integer_type.gemspec
 gemspec
+
+ar_version = ENV["ACTIVE_RECORD_VERSION"] || "default"
+
+ar = case ar_version
+when "master"
+  { github: "rails/rails" }
+when "default"
+  ">= 6.0"
+else
+  "~> #{ar_version}"
+end
+
+gem "activerecord", ar

data/README.md

@@ -22,10 +22,12 @@ class CreateCompanies < ActiveRecord::Migration
 end
 ```
 
-The problem with this approach is that `type` is a string (and by default it is 255 characters). This is a little ridiculous. For comparison, if we had a state machine with X states, would we describe the states with strings `"State1", "State2", etc` or would we just enumerate the state column and make it an integer? This gem will allow us to use an integer for the `type` column. 
+The problem with this approach is that `type` is a string (and by default it is 255 characters). This is a little ridiculous. For comparison, if we had a state machine with X states, would we describe the states with strings `"State1", "State2", etc` or would we just enumerate the state column and make it an integer? This gem will allow us to use an integer for the `type` column.
 
 ## Installation
 
+_Current versions of this gem (>= v0.2.0) only support Ruby 3+ and ActiveRecord >= v6.1. For Ruby <= v2.7 or ActiveRecord <= 6.0, use v0.1.3._
+
 Add this line to your application's Gemfile:
 
     gem 'inheritance_integer_type'
@@ -42,28 +44,28 @@ Or install it yourself as:
 
 The gem is pretty straightforward to use.
 
-First, set the `integer_inheritance` value on each of the subclasses. 
+First, set the `integer_inheritance` value on each of the subclasses.
 ```ruby
 class Firm < Company
   self.integer_inheritance = 1
 end
- 
+
 class Client < Company
   self.integer_inheritance = 2
 end
- 
+
 class PriorityClient < Client
   self.integer_inheritance = 3
 end
 ```
 
 
-Note: The mapping here can start from whatever integer you wish, but I would advise not using 0. The reason being that if you had a new class, for instance `PriorityFirm`,  but forgot to include set the mapping, it would effectively get `to_i` called on it and stored in the database. `"Priority".to_i == 0`, so if your mapping included 0, this would create a weird bug. 
+Note: The mapping here can start from whatever integer you wish, but I would advise not using 0. The reason being that if you had a new class, for instance `PriorityFirm`,  but forgot to include set the mapping, it would effectively get `to_i` called on it and stored in the database. `"Priority".to_i == 0`, so if your mapping included 0, this would create a weird bug.
 
 If you want to convert a polymorphic association that is already a string, you'll need to set up a migration. (Assuming SQL for the time being, but this should be pretty straightforward.)
 ```ruby
 class CompanyToIntegerType < ActiveRecord::Migration
-  
+
   def up
     change_table :companies do |t|
       t.integer :new_type

data/dev.yml

@@ -0,0 +1,11 @@
+---
+version: "2.0"
+
+setup:
+  ruby: 3.1.4
+  bundler: 2.4.21
+
+commands:
+  test:
+    summary: Run the project's specs
+    command: bundle exec rspec spec/

data/inheritance_integer_type.gemspec

@@ -18,10 +18,10 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.6"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
-  spec.add_development_dependency "activerecord"
-  spec.add_development_dependency "sqlite3", "~> 1.3.6"
+  spec.add_development_dependency "activerecord", ">= 5.2"
+  spec.add_development_dependency "sqlite3", "~> 1.4"
   spec.add_development_dependency "pry"
 end

data/lib/inheritance_integer_type/extensions.rb

@@ -13,7 +13,7 @@ module InheritanceIntegerType
         else
           begin
             if store_full_sti_class
-              ActiveSupport::Dependencies.constantize(lookup)
+              lookup.constantize
             else
               compute_type(lookup)
             end

data/lib/inheritance_integer_type/version.rb

@@ -1,3 +1,3 @@
 module InheritanceIntegerType
-  VERSION = "0.1.3"
+  VERSION = "0.2.0"
 end

data/overlord.yml

@@ -0,0 +1,3 @@
+tier: 3
+owner: backend-infrastructure
+classification: library

data/spec/inheritance_integer_type_spec.rb

@@ -48,7 +48,7 @@ describe InheritanceIntegerType do
     describe "Has many associations" do
       let(:other) { Other.create }
       before do
-        [base, left, deep].each{|a| a.update_attributes(other: other) }
+        [base, left, deep].each{|a| a.update_attribute(:other, other) }
       end
       subject { other }
       it "properly finds the classes through the association" do

data/spec/spec_helper.rb

@@ -9,7 +9,7 @@ require 'support/belongs_to'
 
 RSpec.configure do |config|
   config.before(:suite) do
-    ActiveRecord::MigrationContext.new("#{File.dirname(__FILE__)}/support/migrations").migrate
+    ActiveRecord::MigrationContext.new("#{File.dirname(__FILE__)}/support/migrations", ::ActiveRecord::SchemaMigration).migrate
   end
 
   # No need to return the run the down migration after the test

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: inheritance_integer_type
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.0
 platform: ruby
 authors:
 - Kyle d'Oliveira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-29 00:00:00.000000000 Z
+date: 2024-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -58,28 +58,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.6
+        version: '1.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.6
+        version: '1.4'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -102,17 +102,21 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yaml"
+- ".github/workflows/gem-push.yaml"
 - ".gitignore"
+- ".ruby-version"
 - Gemfile
-- Gemfile.lock
 - LICENSE
 - LICENSE.txt
 - README.md
 - Rakefile
+- dev.yml
 - inheritance_integer_type.gemspec
 - lib/inheritance_integer_type.rb
 - lib/inheritance_integer_type/extensions.rb
 - lib/inheritance_integer_type/version.rb
+- overlord.yml
 - spec/inheritance_integer_type_spec.rb
 - spec/spec_helper.rb
 - spec/spec_helper~
@@ -145,7 +149,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.3.27
 signing_key: 
 specification_version: 4
 summary: Allow the type field in teh DB to be an integer rather than a string

data/Gemfile.lock

@@ -1,62 +0,0 @@
-PATH
-  remote: .
-  specs:
-    inheritance_integer_type (0.1.2)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activemodel (5.2.0)
-      activesupport (= 5.2.0)
-    activerecord (5.2.0)
-      activemodel (= 5.2.0)
-      activesupport (= 5.2.0)
-      arel (>= 9.0)
-    activesupport (5.2.0)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    arel (9.0.0)
-    coderay (1.1.2)
-    concurrent-ruby (1.0.5)
-    diff-lcs (1.2.5)
-    i18n (1.0.0)
-      concurrent-ruby (~> 1.0)
-    method_source (0.9.0)
-    minitest (5.11.3)
-    pry (0.11.3)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    rake (10.3.2)
-    rspec (3.0.0)
-      rspec-core (~> 3.0.0)
-      rspec-expectations (~> 3.0.0)
-      rspec-mocks (~> 3.0.0)
-    rspec-core (3.0.0)
-      rspec-support (~> 3.0.0)
-    rspec-expectations (3.0.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.0.0)
-    rspec-mocks (3.0.1)
-      rspec-support (~> 3.0.0)
-    rspec-support (3.0.0)
-    sqlite3 (1.3.13)
-    thread_safe (0.3.6)
-    tzinfo (1.2.5)
-      thread_safe (~> 0.1)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activerecord
-  bundler (~> 1.6)
-  inheritance_integer_type!
-  pry
-  rake
-  rspec
-  sqlite3 (~> 1.3.6)
-
-BUNDLED WITH
-   1.16.6