infostrada 0.1.26 → 0.1.27

data/lib/infostrada/team_info.rb

@@ -11,7 +11,7 @@ module Infostrada
     def self.fetch(team_id)
       info_hash = get!(URL, query: { teamid: team_id.to_i })
 
-      info_hash.first ? self.new(info_hash.first.merge({ 'teamid' => team_id.to_i })) : nil
+      info_hash.first ? new(info_hash.first.merge({ 'teamid' => team_id.to_i })) : nil
     end
 
     def initialize(hash)

data/lib/infostrada/team_request.rb

@@ -9,12 +9,9 @@ module Infostrada
     def self.get_edition(edition_id)
       list = get!(URLS[:list], query: { editionid: edition_id.to_i })
 
-      teams = []
-      list.each do |team_hash|
-        teams << Team.new(team_hash.merge('edition_id' => edition_id.to_i), '')
+      list.map do |team_hash|
+        Team.new(team_hash.merge('edition_id' => edition_id.to_i), '')
       end
-
-      teams
     end
   end
 end

data/lib/infostrada/version.rb

@@ -1,3 +1,3 @@
 module Infostrada
-  VERSION = '0.1.26'
+  VERSION = '0.1.27'
 end

data/spec/base_request_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+RSpec.describe Infostrada::BaseRequest do
+  let(:path) { 'GetEditionList' }
+  let(:auth_uri) { "#{@base_url}/#{path}?#{@default_params}" }
+  let(:base_request) { Infostrada::BaseRequest }
+
+  before do
+    stub_request(:get, auth_uri)
+      .to_return(status: 200, body: [])
+  end
+
+  describe '.get!' do
+    it 'http basic authenticates' do
+      result = base_request.get!("/#{path}")
+      expect(result.body).to eq([])
+    end
+  end
+end

data/spec/competition_spec.rb

@@ -0,0 +1,67 @@
+require 'spec_helper'
+
+RSpec.describe Infostrada::Competition do
+  let(:default) { JSONHelper::Competition.get(:default) }
+
+  let(:without_nation) do
+    JSONHelper::Competition.get(:without_nation)
+  end
+
+  let(:serialized) do
+    Infostrada::Competition.new(default.clone).as_json
+  end
+
+  describe '#initialize' do
+    it 'has id' do
+      result = Infostrada::Competition.new(default.clone)
+      expect(result.id).to be(default['n_CompetitionID'])
+    end
+
+    it 'has name' do
+      result = Infostrada::Competition.new(default.clone)
+      expect(result.name).to be(default['c_Competition'])
+    end
+
+    it 'has nation' do
+      result = Infostrada::Competition.new(default.clone)
+      expect(result.nation).to_not be(nil)
+    end
+
+    context 'missing nation' do
+      it 'doesn\'t fail' do
+        result = Infostrada::Competition.new(without_nation.clone)
+
+        expect(result).not_to be(nil)
+        expect(result.id).to be(without_nation['n_CompetitionID'])
+        expect(result.name).to be(without_nation['c_Competition'])
+      end
+    end
+  end
+
+  describe '.from_json' do
+    it 'has id' do
+      result = Infostrada::Competition.from_json(serialized)
+      expect(result.id).to be(serialized['id'])
+    end
+
+    it 'has name' do
+      result = Infostrada::Competition.from_json(serialized)
+      expect(result.name).to be(serialized['name'])
+    end
+
+    it 'has nation' do
+      result = Infostrada::Competition.from_json(serialized)
+      expect(result.nation).to_not be(nil)
+    end
+
+    context 'missing nation' do
+      it 'doesn\'t fail' do
+        result = Infostrada::Competition.from_json(serialized)
+
+        expect(result).not_to be(nil)
+        expect(result.id).to be(serialized['id'])
+        expect(result.name).to be(serialized['name'])
+      end
+    end
+  end
+end

data/spec/edition_request_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+RSpec.describe Infostrada::EditionRequest do
+  let(:default) { JSONHelper::EditionRequest.get(:default) }
+  let(:path) { 'GetEditionList' }
+  let(:uri) { "#{@base_url}/#{path}?#{@default_params}" }
+
+  before do
+    stub_request(:get, uri)
+      .to_return(status: 200, body: default.to_json)
+  end
+
+  describe '.get_list' do
+    it 'returns array of editions' do
+      result = Infostrada::EditionRequest.get_list
+      expect(result).not_to be(nil)
+      expect(result.count).to equal(default.count)
+    end
+  end
+end

data/spec/edition_spec.rb

@@ -0,0 +1,111 @@
+require 'spec_helper'
+
+RSpec.describe Infostrada::Edition do
+  let(:default) { JSONHelper::Edition.get(:default) }
+  let(:without_start_date) { JSONHelper::Edition.get(:without_start_date) }
+  let(:without_end_date) { JSONHelper::Edition.get(:without_end_date) }
+
+  describe '#initialize' do
+    context 'with complete edition' do
+      let(:default_edition) { Infostrada::Edition.new(default.clone) }
+
+      it 'has id' do
+        expect(default_edition.id).to be(default['n_EditionID'])
+      end
+
+      it 'has season' do
+        expect(default_edition.season).to be(default['c_Season'])
+      end
+
+      it 'has start_date' do
+        expect(default_edition.start_date).not_to be_nil
+      end
+
+      it 'has end_date' do
+        expect(default_edition.end_date).not_to be_nil
+      end
+
+      it 'has competition' do
+        expect(default_edition.competition).not_to be_nil
+      end
+    end
+
+    context 'wihtout start_date' do
+      let(:no_start_edition) { Infostrada::Edition.new(without_start_date.clone) }
+
+      it 'doesn\'t fail' do
+        expect(no_start_edition).not_to be_nil
+      end
+
+      it 'not_has end_date' do
+        expect(no_start_edition.start_date).to be_nil
+      end
+    end
+
+    context 'wihtout end_date' do
+      let(:no_end_edition) { Infostrada::Edition.new(without_end_date.clone) }
+
+      it 'doesn\'t fail' do
+        expect(no_end_edition).not_to be_nil
+      end
+
+      it 'doesn\' have end_date' do
+        expect(no_end_edition.end_date).to be_nil
+      end
+    end
+  end
+
+  describe '.from_json' do
+    let(:json_default) { Infostrada::Edition.new(default.clone).as_json }
+    let(:json_without_end_date) { Infostrada::Edition.new(without_end_date.clone).as_json }
+    let(:json_without_start_date) { Infostrada::Edition.new(without_start_date.clone).as_json }
+
+    context 'with complete edition' do
+      let(:from_json_edition) { Infostrada::Edition.from_json(json_default.clone) }
+
+      it 'has id' do
+        expect(from_json_edition.id).to be(json_default['id'])
+      end
+
+      it 'has season' do
+        expect(from_json_edition.season).to be(json_default['season'])
+      end
+
+      it 'has start_date' do
+        expect(from_json_edition.start_date).not_to be_nil
+      end
+
+      it 'has end_date' do
+        expect(from_json_edition.end_date).not_to be_nil
+      end
+
+      it 'has competition' do
+        expect(from_json_edition.competition).not_to be_nil
+      end
+    end
+
+    context 'wihtout start_date' do
+      let(:from_json_no_start_edition) { Infostrada::Edition.from_json(json_without_start_date.clone) }
+
+      it 'doesn\'t fail' do
+        expect(from_json_no_start_edition).not_to be_nil
+      end
+
+      it 'not_has end_date' do
+        expect(from_json_no_start_edition.start_date).to be_nil
+      end
+    end
+
+    context 'wihtout end_date' do
+      let(:from_json_no_end_edition) { Infostrada::Edition.from_json(json_without_end_date.clone) }
+
+      it 'doesn\'t fail' do
+        expect(from_json_no_end_edition).not_to be_nil
+      end
+
+      it 'not_has end_date' do
+        expect(from_json_no_end_edition.end_date).to be_nil
+      end
+    end
+  end
+end

data/spec/endpoint_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper'
+
+RSpec.describe Infostrada::Endpoint do
+  let(:endpoints)   { JSONHelper::Endpoint.get(:endpoints)   }
+  let(:live_table)  { JSONHelper::Endpoint.get(:live_table)  }
+  let(:match_info)  { JSONHelper::Endpoint.get(:match_info)  }
+  let(:action_list) { JSONHelper::Endpoint.get(:action_list) }
+  let(:endpoint) { Infostrada::Endpoint }
+
+  def all_from_endpoints
+    endpoints.map { |e| endpoint.new(e) }
+  end
+
+  describe '#initialize' do
+    it 'has method' do
+      result = all_from_endpoints
+
+      result.each_with_index do |endpoint, i|
+        expect(endpoint.method).not_to be_nil
+        expect(endpoint.method).to equal(endpoints[i]['c_Method'])
+      end
+    end
+
+    it 'has last_modified' do
+      result = all_from_endpoints
+
+      result.each do |endpoint|
+        expect(endpoint.last_modified).not_to be_nil
+      end
+    end
+
+    it 'has query string' do
+      result = all_from_endpoints
+
+      result.each_with_index do |endpoint, i|
+        expect(endpoint.query_string).not_to be_nil
+        expect(endpoint.query_string).to equal(endpoints[i]['c_QueryString'])
+      end
+    end
+
+    context 'with live table' do
+      it 'has phase id' do
+        res = endpoint.new(live_table)
+        expect(res.phase_id.to_i).to equal(109223)
+      end
+    end
+
+    context 'with match info' do
+      it 'has match id' do
+        res = endpoint.new(match_info)
+        expect(res.match_id.to_i).to equal(1877488)
+      end
+    end
+
+    context 'with action list' do
+      it 'has match id' do
+        res = endpoint.new(match_info)
+        expect(res.match_id.to_i).to equal(1877488)
+      end
+    end
+  end
+end

data/spec/formatter_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+RSpec.describe Infostrada::Formatter do
+  let(:formatter) { Infostrada::Formatter }
+
+  describe '.format_date' do
+    it 'parses date' do
+      date = '/Date(1428426230563+0200)/'
+      expect(formatter.format_date(date).to_i).to eq(Time.parse('2015-04-07 19:03:50 UTC').to_i)
+    end
+  end
+end

data/spec/helpers/json_helper.rb

@@ -0,0 +1,41 @@
+# Automatically loads json files with an associated class for loading fixture
+module JSONHelper
+  class << self
+    # Uhuhuh! What a cache!
+    def cache
+      @cache ||= {}
+    end
+
+    def cache_or_load(path)
+      cache[path] ||= begin
+        file = File.read(path)
+        JSON.parse(file).symbolize_keys
+      end
+    end
+
+    def load_file(name)
+      path = File.expand_path("../../json/#{name}", __FILE__)
+      cache_or_load(path)
+    end
+  end
+
+  # TODO: Better way to deal with this.
+  # Declaring a class for each one was too much.
+  # With this, it works, but is too meta, I think.
+  class Generic
+    def self.get(name)
+      new.get(name)
+    end
+
+    def get(name)
+      file_name = "#{File.basename(self.class.name.info_underscore)}.json"
+      fixtures = ::JSONHelper.load_file(file_name)
+      fixtures[name.to_sym].clone
+    end
+  end
+
+  Dir[File.expand_path('../../json/*.json', __FILE__)].each do |file_name|
+    klass_name = "#{File.basename(file_name, '.json').info_camelize}"
+    JSONHelper.const_set(klass_name, Class.new(Generic))
+  end
+end

data/spec/json/competition.json

@@ -0,0 +1,55 @@
+{
+  "default": {
+    "n_CompetitionID": 290,
+    "c_Competition": "Community Shield",
+    "n_CompetitionSet": 2,
+    "n_CompetitionNatioGeoID": 2208,
+    "c_CompetitionNatio": "England",
+    "c_CompetitionNatioShort": "ENG",
+    "n_CompetitionLevel": 0,
+    "n_EditionID": 21053,
+    "c_Season": "2014/2015",
+    "d_EditionStartDate": "/Date(1407621600000+0200)/",
+    "d_EditionEndDate": "/Date(1407621600000+0200)/",
+    "n_PhaseID": null
+  },
+  "without_nation": {
+    "n_CompetitionID": 290,
+    "c_Competition": "Community Shield",
+    "n_CompetitionSet": 2,
+    "n_CompetitionLevel": 0,
+    "n_EditionID": 21053,
+    "c_Season": "2014/2015",
+    "d_EditionStartDate": "/Date(1407621600000+0200)/",
+    "d_EditionEndDate": "/Date(1407621600000+0200)/",
+    "n_PhaseID": null
+  },
+  "another": {
+    "n_CompetitionID": 199,
+    "c_Competition": "S\u00e9rie A",
+    "n_CompetitionSet": 1,
+    "n_CompetitionNatioGeoID": 2235,
+    "c_CompetitionNatio": "Brazil",
+    "c_CompetitionNatioShort": "BRA",
+    "n_CompetitionLevel": 1,
+    "n_EditionID": 21594,
+    "c_Season": "2015",
+    "d_EditionStartDate": "/Date(1431122400000+0200)/",
+    "d_EditionEndDate": "/Date(1449356400000+0100)/",
+    "n_PhaseID": null
+  },
+  "league": {
+    "n_CompetitionID": 199,
+    "c_Competition": "S\u00e9rie A",
+    "n_CompetitionSet": 1,
+    "n_CompetitionNatioGeoID": 2235,
+    "c_CompetitionNatio": "Brazil",
+    "c_CompetitionNatioShort": "BRA",
+    "n_CompetitionLevel": 1,
+    "n_EditionID": 21594,
+    "c_Season": "2015",
+    "d_EditionStartDate": "/Date(1431122400000+0200)/",
+    "d_EditionEndDate": "/Date(1449356400000+0100)/",
+    "n_PhaseID": null
+  }
+}

data/spec/json/edition.json

@@ -0,0 +1,61 @@
+{
+    "default": {
+      "n_CompetitionID": 255,
+      "c_Competition": "Supercopa de Espana",
+      "n_CompetitionSet": 2,
+      "n_CompetitionNatioGeoID": 2203,
+      "c_CompetitionNatio": "Spain",
+      "c_CompetitionNatioShort": "ESP",
+      "n_CompetitionLevel": 0,
+      "n_EditionID": 21056,
+      "c_Season": "2014/2015",
+      "d_EditionStartDate": "/Date(1408399200000+0200)/",
+      "d_EditionEndDate": "/Date(1408658400000+0200)/",
+      "n_PhaseID": null
+    },
+
+    "without_competition": {
+      "n_CompetitionID": 67,
+      "c_Competition": "Liga BBVA",
+      "n_CompetitionSet": 1,
+      "n_CompetitionNatioGeoID": 2203,
+      "c_CompetitionNatio": "Spain",
+      "c_CompetitionNatioShort": "ESP",
+      "n_CompetitionLevel": 1,
+      "n_EditionID": 21411,
+      "c_Season": "2014/2015",
+      "d_EditionStartDate": "/Date(1408744800000+0200)/",
+      "d_EditionEndDate": "/Date(1432418400000+0200)/",
+      "n_PhaseID": null
+    },
+
+    "without_start_date": {
+      "n_CompetitionID": 255,
+      "c_Competition": "Supercopa de Espana",
+      "n_CompetitionSet": 2,
+      "n_CompetitionNatioGeoID": 2203,
+      "c_CompetitionNatio": "Spain",
+      "c_CompetitionNatioShort": "ESP",
+      "n_CompetitionLevel": 0,
+      "n_EditionID": 21056,
+      "c_Season": "2014/2015",
+      "d_EditionStartDate": null,
+      "d_EditionEndDate": "/Date(1408658400000+0200)/",
+      "n_PhaseID": null
+    },
+
+    "without_end_date": {
+      "n_CompetitionID": 255,
+      "c_Competition": "Supercopa de Espana",
+      "n_CompetitionSet": 2,
+      "n_CompetitionNatioGeoID": 2203,
+      "c_CompetitionNatio": "Spain",
+      "c_CompetitionNatioShort": "ESP",
+      "n_CompetitionLevel": 0,
+      "n_EditionID": 21056,
+      "c_Season": "2014/2015",
+      "d_EditionStartDate": "/Date(1408399200000+0200)/",
+      "d_EditionEndDate": null,
+      "n_PhaseID": null
+    }
+}