infopark_reactor 1.27.0.rc8 → 1.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 6b05ba4bdbbf52467a1c669a7f9780e11aa4ce26
-  data.tar.gz: 74cc85311a53fc90b845452a9fee5e7a4418efdd
+SHA256:
+  metadata.gz: d702e2d26e5067f61edcbfa124db36effe8ba4b8d5293d855f7e90ad41b151ce
+  data.tar.gz: e8b270ff8d5b435271342bd7e4120582ff544ea759839450e966467b15954d82
 SHA512:
-  metadata.gz: 8818f97d7cd145f35d2a08a7cd88c346a2c36db4aa9f8aa1e9d7c82cd38eaedda877121ca1afcb0e617e73a3154ba3eb37cda54ba7429327a04856f0e4fe151a
-  data.tar.gz: 76fa00c68403f1eeebb8f6178c5de9516b71d22832d8133b9dc285047a93657f0b25b65b43801bb6fd964a6628b7e00ee3e41c56f6770ab00d3fba578bc44217
+  metadata.gz: 58cfbe5e0dd7688605bc2e3353466218cae8f0dc4cba2a417f213960d411a4f92acbbbb19714dea6b86cca4a39566ce4aa6eb7c4fadfb49185c3714ce8b580f2
+  data.tar.gz: ef5c34686380f1c6be310a67b6e0440af9632ea63c23aea8c311a6449ef3f6de0afcff88152925fa96593ae70e6fb3941ce2aad82d9ef215884db7621ef358e2

data/.rubocop_todo.yml

@@ -1,11 +1,18 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude`
-# on 2020-07-17 11:04:06 UTC using RuboCop version 0.87.1.
+# on 2022-05-05 11:51:54 UTC using RuboCop version 0.89.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'infopark_reactor.gemspec'
+
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
@@ -42,6 +49,12 @@ Lint/LiteralAsCondition:
   Exclude:
     - 'lib/reactor/persistence.rb'
 
+# Offense count: 2
+Lint/MissingSuper:
+  Exclude:
+    - 'lib/reactor/cm/object_base.rb'
+    - 'lib/reactor/workflow/empty.rb'
+
 # Offense count: 2
 Lint/ShadowingOuterLocalVariable:
   Exclude:
@@ -66,10 +79,10 @@ Lint/UselessAssignment:
     - 'lib/reactor/plans/update_attribute.rb'
     - 'lib/reactor/plans/update_obj_class.rb'
 
-# Offense count: 47
+# Offense count: 43
 # Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
-  Max: 54
+  Max: 60
 
 # Offense count: 5
 # Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods.
@@ -94,11 +107,10 @@ Metrics/ClassLength:
     - 'lib/reactor/cm/object_base.rb'
     - 'lib/reactor/tools/workflow_generator.rb'
 
-# Offense count: 12
+# Offense count: 11
 # Configuration parameters: IgnoredMethods, Max.
 Metrics/CyclomaticComplexity:
   Exclude:
-    - 'lib/reactor/attributes/date_serializer.rb'
     - 'lib/reactor/attributes/link_list_extender.rb'
     - 'lib/reactor/attributes_handlers.rb'
     - 'lib/reactor/cm/obj.rb'
@@ -123,15 +135,19 @@ Metrics/ModuleLength:
     - 'lib/reactor/attributes.rb'
     - 'lib/reactor/persistence.rb'
 
-# Offense count: 5
+# Offense count: 10
 # Configuration parameters: IgnoredMethods, Max.
 Metrics/PerceivedComplexity:
   Exclude:
     - 'lib/reactor/attributes/date_serializer.rb'
+    - 'lib/reactor/attributes/link_list_extender.rb'
+    - 'lib/reactor/attributes_handlers.rb'
     - 'lib/reactor/cm/obj.rb'
+    - 'lib/reactor/cm/obj_class.rb'
     - 'lib/reactor/legacy.rb'
+    - 'lib/reactor/persistence.rb'
     - 'lib/reactor/tools/smart_xml_logger.rb'
-    - 'lib/reactor/tools/sower.rb'
+    - 'lib/reactor/validations.rb'
 
 # Offense count: 7
 Naming/AccessorMethodName:
@@ -167,7 +183,7 @@ Naming/MemoizedInstanceVariableName:
 
 # Offense count: 5
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
 Naming/MethodParameterName:
   Exclude:
     - 'lib/reactor/cm/bridge.rb'
@@ -205,12 +221,29 @@ Security/YAMLLoad:
   Exclude:
     - 'lib/reactor/tools/versioner.rb'
 
+# Offense count: 5
+# Cop supports --auto-correct.
+Style/ArrayCoercion:
+  Exclude:
+    - 'lib/reactor/cm/bridge.rb'
+    - 'lib/reactor/cm/log_entry.rb'
+    - 'lib/reactor/cm/obj_class.rb'
+    - 'lib/reactor/cm/xml_single_request_error.rb'
+    - 'lib/reactor/tools/where_query.rb'
+
 # Offense count: 1
 # Configuration parameters: AllowedChars.
 Style/AsciiComments:
   Exclude:
     - 'lib/reactor/cm/language.rb'
 
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/CaseLikeIf:
+  Exclude:
+    - 'lib/reactor/attributes/date_serializer.rb'
+    - 'lib/reactor/cm/xml_markup.rb'
+
 # Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
@@ -243,6 +276,13 @@ Style/EvalWithLocation:
     - 'lib/reactor/attributes_handlers.rb'
     - 'lib/reactor/cm/object_base.rb'
 
+# Offense count: 7
+# Cop supports --auto-correct.
+Style/ExplicitBlockArgument:
+  Exclude:
+    - 'lib/reactor/cm/multi_xml_request.rb'
+    - 'lib/reactor/cm/xml_markup.rb'
+
 # Offense count: 115
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
@@ -297,11 +337,6 @@ Style/InverseMethods:
   Exclude:
     - 'lib/reactor/plans/prepared.rb'
 
-# Offense count: 1
-Style/MethodMissingSuper:
-  Exclude:
-    - 'lib/reactor/migration.rb'
-
 # Offense count: 1
 Style/MissingRespondToMissing:
   Exclude:
@@ -314,6 +349,13 @@ Style/NonNilCheck:
   Exclude:
     - 'lib/reactor/permission.rb'
 
+# Offense count: 6
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'lib/reactor/cm/obj.rb'
+    - 'lib/reactor/persistence.rb'
+    - 'lib/reactor/session/observers.rb'
+
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: .
@@ -321,6 +363,15 @@ Style/NonNilCheck:
 Style/SpecialGlobalVars:
   EnforcedStyle: use_perl_names
 
+# Offense count: 5
+# Cop supports --auto-correct.
+Style/StringConcatenation:
+  Exclude:
+    - 'lib/reactor/attributes_handlers.rb'
+    - 'lib/reactor/tools/migrator.rb'
+    - 'lib/reactor/tools/sower.rb'
+    - 'lib/reactor/tools/versioner.rb'
+
 # Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoredMethods.

data/infopark_reactor.gemspec

@@ -7,10 +7,10 @@ Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Tomasz Przedmojski", "Anton Mezin", "Roman Lemekha"]
   s.email       = ["tomasz.przedmojski@infopark.de", "anton.mezin@infopark.de", "roman.lemekha@infopark.de"]
-  s.homepage    = ""
+  s.homepage    = "https://www.justrelate.com/"
   s.summary     = "Write into CM in familiar, Rails-like way"
   s.description = "Use the ActiveRecord mimicking API to write into CM and enjoy all the benefits of callbacks, validations and permission checking"
-  s.license     = "LGPL-3"
+  s.license     = "LGPL-3.0"
 
   # s.rubyforge_project = "infopark_reactor"
 
@@ -19,12 +19,12 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  s.add_dependency "infopark_fiona_connector", "~> 7.0.1.5.2.4.rc1"
+  s.add_dependency "infopark_fiona_connector", "~> 7.0.1.5.2.7.rc1"
   s.add_dependency "nokogiri", "~> 1"
   s.add_dependency "rails", "~> 5.0"
 
   s.add_development_dependency "rspec", "~> 3"
-  s.add_development_dependency "rubocop", "~> 0.87.1"
+  s.add_development_dependency "rubocop", "~> 0.89.1"
   s.add_development_dependency "rubocop-performance", "~> 1"
   s.add_development_dependency "yard", ">= 0"
 end

data/lib/reactor/persistence.rb

@@ -63,7 +63,7 @@ module Reactor
       # @raise [Reactor::NotPermitted] current user lacks required permissions
       def release!(comment = nil)
         run_callbacks(:release) do
-          raise(Reactor::AlreadyReleased) unless really_edited?
+          raise(Reactor::AlreadyReleased) unless edited_or_committed?
 
           crul_obj.release!(comment)
           reload
@@ -237,11 +237,13 @@ module Reactor
         end
       end
 
-      # Equivalent to Obj#edited?
       def really_edited?
         # check if really edited with curl request
         crul_obj.edited?
-        # self.edited?
+      end
+
+      def edited_or_committed?
+        really_edited? || committed?
       end
 
       # Returns an array of errors

data/lib/reactor/validations.rb

@@ -40,7 +40,8 @@ module Reactor
 
         cms_attributes = __cms_attributes(subclass).values
         # Add validation for linklist & multienum [minSize/maxSize]
-        array_attributes = cms_attributes.select { |attr| %w(linklist multienum).include?(attr.attribute_type) }
+        array_attr = %w(linklist multienum)
+        array_attributes = cms_attributes.select { |attr| array_attr.include?(attr.attribute_type) }
         array_attributes.each do |attr|
           length_hash = {}
           if attr.min_size && "linklist" != attr.attribute_type

data/lib/reactor/version.rb

@@ -1,3 +1,3 @@
 module Reactor
-  VERSION = "1.27.0.rc8".freeze
+  VERSION = "1.28.0".freeze
 end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: infopark_reactor
 version: !ruby/object:Gem::Version
-  version: 1.27.0.rc8
+  version: 1.28.0
 platform: ruby
 authors:
 - Tomasz Przedmojski
 - Anton Mezin
 - Roman Lemekha
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-08-25 00:00:00.000000000 Z
+date: 2022-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: infopark_fiona_connector
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.0.1.5.2.4.rc1
+        version: 7.0.1.5.2.7.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.0.1.5.2.4.rc1
+        version: 7.0.1.5.2.7.rc1
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -74,14 +74,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.87.1
+        version: 0.89.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.87.1
+        version: 0.89.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -241,11 +241,11 @@ files:
 - lib/reactor/workflow/standard.rb
 - lib/tasks/cm_migrate.rake
 - lib/tasks/cm_seeds.rake
-homepage: ''
+homepage: https://www.justrelate.com/
 licenses:
-- LGPL-3
+- LGPL-3.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -256,13 +256,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: Write into CM in familiar, Rails-like way
 test_files: []