infopark_reactor 1.26.1 → 1.27.0.rc4

data/lib/reactor/plans/common_attribute.rb

@@ -1,17 +1,16 @@
-# -*- encoding : utf-8 -*-
 module Reactor
   module Plans
     class CommonAttribute
       include Prepared
 
-      ALLOWED_PARAMS = [:callback, :helpText, :maxSize, :minSize,
-        :title, :values]
+      ALLOWED_PARAMS = %i(callback helpText maxSize minSize
+                          title values).freeze
 
       def initialize
         @params = {}
       end
 
-      def set(key,value)
+      def set(key, value)
         @params[key.to_sym] = value
       end
 
@@ -20,12 +19,13 @@ module Reactor
       end
 
       protected
-      def prepare_params!(attribute=nil)
-        @params.keys.each{|k| error("unknown parameter: #{k}") unless ALLOWED_PARAMS.include? k}
+
+      def prepare_params!(_attribute = nil)
+        @params.keys.each { |k| error("unknown parameter: #{k}") unless ALLOWED_PARAMS.include? k }
       end
 
       def migrate_params!(attribute)
-        @params.each{|k,v|attribute.set(k,v)}
+        @params.each { |k, v| attribute.set(k, v) }
         attribute.save!
       end
     end

data/lib/reactor/plans/common_attribute_group.rb

@@ -1,16 +1,15 @@
-# -*- encoding : utf-8 -*-
 module Reactor
   module Plans
     class CommonAttributeGroup
       include Prepared
 
-      ALLOWED_PARAMS = [:title, :index]
+      ALLOWED_PARAMS = %i(title index).freeze
 
       def initialize
         @params = {}
       end
 
-      def set(key,value)
+      def set(key, value)
         key = key.to_sym
         if key == :attributes
           @attributes = value
@@ -32,8 +31,9 @@ module Reactor
       end
 
       protected
-      def prepare_params!(attribute=nil)
-        @params.keys.each{|k| error("unknown parameter: #{k}") unless ALLOWED_PARAMS.include? k}
+
+      def prepare_params!(_attribute = nil)
+        @params.keys.each { |k| error("unknown parameter: #{k}") unless ALLOWED_PARAMS.include? k }
       end
 
       def migrate_params!(attribute)
@@ -44,7 +44,7 @@ module Reactor
           attribute.remove_attributes(previous_attributes)
           attribute.add_attributes(@attributes)
         end
-        @params.each{|k,v|attribute.set(k,v)}
+        @params.each { |k, v| attribute.set(k, v) }
         attribute.save!
       end
     end

data/lib/reactor/plans/common_channel.rb

@@ -1,16 +1,15 @@
-# -*- encoding : utf-8 -*-
 module Reactor
   module Plans
     class CommonChannel
       include Prepared
 
-      ALLOWED_PARAMS = [:title]
+      ALLOWED_PARAMS = [:title].freeze
 
       def initialize
         @params = {}
       end
 
-      def set(key,value)
+      def set(key, value)
         @params[key.to_sym] = value
       end
 
@@ -19,12 +18,13 @@ module Reactor
       end
 
       protected
-      def prepare_params!(channel=nil)
-        @params.keys.each{|k| error("unknown parameter: #{k}") unless ALLOWED_PARAMS.include? k}
+
+      def prepare_params!(_channel = nil)
+        @params.keys.each { |k| error("unknown parameter: #{k}") unless ALLOWED_PARAMS.include? k }
       end
 
       def migrate_params!(channel)
-        @params.each{|k,v|channel.send(:"#{k}=",v)}
+        @params.each { |k, v| channel.send(:"#{k}=", v) }
         channel.save!
       end
     end

data/lib/reactor/plans/common_group.rb

@@ -1,18 +1,14 @@
-# -*- encoding : utf-8 -*-
 module Reactor
-
   module Plans
-
     class CommonGroup
-
       include Prepared
 
-      ALLOWED_PARAMS = [
-        :users, 
-        :global_permissions, 
-        :real_name, 
-        :owner,
-      ]
+      ALLOWED_PARAMS = %i(
+        users
+        global_permissions
+        real_name
+        owner
+      ).freeze
 
       def initialize
         @params = {}
@@ -28,7 +24,7 @@ module Reactor
 
       protected
 
-      def prepare_params!(group = nil)
+      def prepare_params!(_group = nil)
         @params.keys.each { |key| error("unknown parameter: #{key}") unless ALLOWED_PARAMS.include?(key) }
       end
 
@@ -37,9 +33,6 @@ module Reactor
 
         group.save!
       end
-
     end
-
   end
-
 end

data/lib/reactor/plans/common_job.rb

@@ -1,16 +1,15 @@
-# -*- encoding : utf-8 -*-
 module Reactor
   module Plans
     class CommonJob
       include Prepared
 
-      ALLOWED_PARAMS = [:title, :is_active, :comment, :exec_login, :exec_perm, :schedule, :script]
+      ALLOWED_PARAMS = %i(title is_active comment exec_login exec_perm schedule script).freeze
 
       def initialize
         @params = {}
       end
 
-      def set(key,value)
+      def set(key, value)
         @params[key.to_sym] = value
       end
 
@@ -19,12 +18,13 @@ module Reactor
       end
 
       protected
-      def prepare_params!(job=nil)
-        @params.keys.each{|k| error("unknown parameter: #{k}") unless ALLOWED_PARAMS.include? k}
+
+      def prepare_params!(_job = nil)
+        @params.keys.each { |k| error("unknown parameter: #{k}") unless ALLOWED_PARAMS.include? k }
       end
 
       def migrate_params!(job)
-        @params.each{|k,v|job.send(:"#{k}=",v)}
+        @params.each { |k, v| job.send(:"#{k}=", v) }
         job.save!
       end
     end

data/lib/reactor/plans/common_obj_class.rb

@@ -1,11 +1,10 @@
-# -*- encoding : utf-8 -*-
 module Reactor
   module Plans
     class CommonObjClass
       include Prepared
 
-      ALLOWED_PARAMS = [:completionCheck, :isEnabled, :recordSetCallback, :title,
-        :validContentTypes, :workflowModification]
+      ALLOWED_PARAMS = %i(completionCheck isEnabled recordSetCallback title
+                          validContentTypes workflowModification).freeze
 
       def initialize
         @take_attrs = []
@@ -17,7 +16,7 @@ module Reactor
         @params_options = {}
       end
 
-      def set(key, value, options={})
+      def set(key, value, options = {})
         @params_options[key.to_sym] = options
         @params[key.to_sym] = value
       end
@@ -26,7 +25,7 @@ module Reactor
         @preset_attrs[attribute] = value
       end
 
-      def take(attr_name, opts={})
+      def take(attr_name, opts = {})
         attr_name = attr_name.to_s
         @take_attrs << attr_name
         @drop_attrs.delete(attr_name)
@@ -35,7 +34,7 @@ module Reactor
         @preset_attrs[attr_name] = opts[:preset] if opts.key? :preset
       end
 
-      def drop(attr_name, opts={})
+      def drop(attr_name, _opts = {})
         attr_name = attr_name.to_s
         @drop_attrs << attr_name
         @take_attrs.delete(attr_name)
@@ -48,14 +47,15 @@ module Reactor
       end
 
       protected
-      def prepare_attrs!(klass=nil)
+
+      def prepare_attrs!(_klass = nil)
         @take_attrs.each do |attr|
           error("attribute doesn't exist #{attr}") unless Reactor::Cm::Attribute.exists?(attr)
         end
       end
 
-      def prepare_params!(klass=nil)
-        @params.keys.each{|k| error("unknown parameter: #{k}") unless ALLOWED_PARAMS.include? k}
+      def prepare_params!(_klass = nil)
+        @params.keys.each { |k| error("unknown parameter: #{k}") unless ALLOWED_PARAMS.include? k }
       end
 
       def migrate_attrs!(klass)
@@ -65,8 +65,8 @@ module Reactor
       end
 
       def migrate_params!(klass)
-        @params.each{|k,v|klass.set(k,v,@params_options[k])}
-        klass.preset_attributes.merge(@preset_attrs).each{|k,v|klass.preset(k,v)}
+        @params.each { |k, v| klass.set(k, v, @params_options[k]) }
+        klass.preset_attributes.merge(@preset_attrs).each { |k, v| klass.preset(k, v) }
         klass.save!
       end
     end

data/lib/reactor/plans/create_attribute.rb

@@ -1,5 +1,4 @@
-# -*- encoding : utf-8 -*-
-require 'reactor/plans/common_attribute'
+require "reactor/plans/common_attribute"
 
 module Reactor
   module Plans
@@ -27,7 +26,6 @@ module Reactor
         attrib = Reactor::Cm::Attribute.create(@name, @type)
         migrate_params!(attrib)
       end
-
     end
   end
 end

data/lib/reactor/plans/create_attribute_group.rb

@@ -1,5 +1,4 @@
-# -*- encoding : utf-8 -*-
-require 'reactor/plans/common_attribute_group'
+require "reactor/plans/common_attribute_group"
 
 module Reactor
   module Plans
@@ -22,7 +21,6 @@ module Reactor
         attrib = Reactor::Cm::AttributeGroup.create(@obj_class, @name, @index)
         migrate_params!(attrib)
       end
-
     end
   end
 end

data/lib/reactor/plans/create_channel.rb

@@ -1,6 +1,5 @@
-# -*- encoding : utf-8 -*-
-require 'reactor/cm/channel'
-require 'reactor/plans/common_channel'
+require "reactor/cm/channel"
+require "reactor/plans/common_channel"
 
 module Reactor
   module Plans

data/lib/reactor/plans/create_group.rb

@@ -1,16 +1,12 @@
-# -*- encoding : utf-8 -*-
-require 'reactor/plans/common_group'
+require "reactor/plans/common_group"
 
 module Reactor
-
   module Plans
-
     class CreateGroup < CommonGroup
-
       def initialize(*args)
         super()
 
-        (name, _), options = separate_arguments(*args)
+        (name,), options = separate_arguments(*args)
 
         @name = name || options[:name]
 
@@ -18,7 +14,7 @@ module Reactor
      end
 
       def prepare!
-        error('name is nil') if @name.nil?
+        error("name is nil") if @name.nil?
         error("group #{@name} already exists") if Reactor::Cm::Group.exists?(@name)
 
         prepare_params!(nil)
@@ -27,9 +23,6 @@ module Reactor
       def migrate!
         Reactor::Cm::Group.create(@params)
       end
-
     end
-
   end
-
 end

data/lib/reactor/plans/create_job.rb

@@ -1,6 +1,5 @@
-# -*- encoding : utf-8 -*-
-require 'reactor/cm/job'
-require 'reactor/plans/common_job'
+require "reactor/cm/job"
+require "reactor/plans/common_job"
 
 module Reactor
   module Plans
@@ -16,7 +15,7 @@ module Reactor
       end
 
       def migrate!
-        job = Reactor::Cm::Job.create(@name, @params)
+        Reactor::Cm::Job.create(@name, @params)
       end
     end
   end

data/lib/reactor/plans/create_obj.rb

@@ -1,13 +1,11 @@
-# -*- encoding : utf-8 -*-
 module Reactor
   module Plans
     class CreateObj
-
       def set(key, value)
         @attrs[key.to_sym] = value
       end
 
-      def initialize(opts={})
+      def initialize(opts = {})
         @name = opts[:name]
         @parent = opts[:parent]
         @objClass = opts[:objClass]
@@ -19,22 +17,23 @@ module Reactor
         raise "#{self.class.name}: name is nil" if @name.nil?
         raise "#{self.class.name}: parent is nil" if @parent.nil?
         raise "#{self.class.name}: objClass is nil" if @objClass.nil?
-        raise "#{self.class.name}: parent does not exist" if not Reactor::Cm::Obj.exists?(@parent)
-        raise "#{self.class.name}: obj with name #{@name} already exists" if (!@ignoreExisting) && Reactor::Cm::Obj.exists?(path)
-=begin
-        raise "#{self.class.name}: objClass #{@objClass} not found" if not Reactor::Cm::ObjClass.exists?(@objClass)
-        @attrs.keys.each do |attr|
-          raise "#{self.class.name}: attr #{attr} not found for objClass #{@objClass}" if not Reactor::Cm::ObjClass.has_attribute?(attr)
+        raise "#{self.class.name}: parent does not exist" unless Reactor::Cm::Obj.exists?(@parent)
+        if !@ignoreExisting && Reactor::Cm::Obj.exists?(path)
+          raise "#{self.class.name}: obj with name #{@name} already exists"
         end
-=end
+        #         raise "#{self.class.name}: objClass #{@objClass} not found" if not Reactor::Cm::ObjClass.exists?(@objClass)
+        #         @attrs.keys.each do |attr|
+        #           raise "#{self.class.name}: attr #{attr} not found for objClass #{@objClass}" if not Reactor::Cm::ObjClass.has_attribute?(attr)
+        #         end
         # ...?
       end
 
       def migrate!
-        return true if (@ignoreExisting) && Reactor::Cm::Obj.exists?(path)
+        return true if @ignoreExisting && Reactor::Cm::Obj.exists?(path)
+
         @obj = Cm::Obj.create(@name, @parent, @objClass)
-        @attrs.each do |key,value|
-          @obj.set(key,value)
+        @attrs.each do |key, value|
+          @obj.set(key, value)
         end
         @obj.save!
         @obj.release!
@@ -43,7 +42,6 @@ module Reactor
       def path
         File.join(@parent, @name)
       end
-
     end
   end
 end

data/lib/reactor/plans/create_obj_class.rb

@@ -1,5 +1,4 @@
-# -*- encoding : utf-8 -*-
-require 'reactor/plans/common_obj_class'
+require "reactor/plans/common_obj_class"
 
 module Reactor
   module Plans

data/lib/reactor/plans/delete_attribute.rb

@@ -1,4 +1,3 @@
-# -*- encoding : utf-8 -*-
 module Reactor
   module Plans
     class DeleteAttribute < CommonAttribute
@@ -10,7 +9,7 @@ module Reactor
 
       def prepare!
         error("name is nil") if @name.nil?
-        error("attribute #{@name} does not exist") if not Reactor::Cm::Attribute.exists?(@name)
+        error("attribute #{@name} does not exist") unless Reactor::Cm::Attribute.exists?(@name)
         # TODO: check used..
       end
 
@@ -18,7 +17,6 @@ module Reactor
         attrib = Reactor::Cm::Attribute.get(@name)
         attrib.delete!
       end
-
     end
   end
 end

data/lib/reactor/plans/delete_attribute_group.rb

@@ -1,5 +1,4 @@
-# -*- encoding : utf-8 -*-
-require 'reactor/plans/common_attribute_group'
+require "reactor/plans/common_attribute_group"
 
 module Reactor
   module Plans
@@ -15,14 +14,13 @@ module Reactor
       def prepare!
         error("name ist nil") if @name.nil?
         error("obj_class is nil") if @obj_class.nil?
-        error("attribute group #{@pk} does not exist") if not Reactor::Cm::AttributeGroup.exists?(@pk)
+        error("attribute group #{@pk} does not exist") unless Reactor::Cm::AttributeGroup.exists?(@pk)
       end
 
       def migrate!
         attrib = Reactor::Cm::AttributeGroup.get(@pk)
         attrib.delete!
       end
-
     end
   end
 end