infopark_reactor 1.25.2 → 1.27.0.rc8

data/lib/reactor/link/internal.rb

@@ -1,15 +1,18 @@
-# -*- encoding : utf-8 -*-
 module Reactor
   module Link
     class Internal
       attr_accessor :destination_object
 
-      def external? ; false ; end
-      def internal? ; true  ; end
+      def external?
+        false
+      end
+
+      def internal?
+        true
+      end
 
-      def initialize(anything)
+      def initialize(_anything)
         raise TypeError, "#{self.class.name} is deprecated!"
-        self.destination_object = Obj.obj_from_anything(anything)
       end
 
       def id

data/lib/reactor/link/temporary_link.rb

@@ -1,44 +1,43 @@
-# -*- encoding : utf-8 -*-
 module Reactor
   module Link
     class TemporaryLink
       attr_reader   :url
-      attr_accessor :title
-      attr_accessor :target
+      attr_accessor :title, :target
 
-      def external? ; raise TypeError, "This link needs to be persisted to gain any meaningful information" ; end
-      def internal? ; false ; end
+      def external?
+        raise TypeError, "This link needs to be persisted to gain any meaningful information"
+      end
+
+      def internal?
+        false
+      end
 
       def initialize(anything)
         link_data = {}
-        
+
         case anything
         when Hash
           link_data = anything
-        when Fixnum
+        when Integer
           link_data[:url] = RailsConnector::AbstractObj.find(anything).path
         else
           link_data[:url] = anything
         end
 
-        self.url    = link_data[:url] || link_data[:destination_object]
-        if link_data[:search].present?
-          self.url = "#{self.url}?#{link_data[:search]}"
-        end
-        if link_data[:fragment].present?
-          self.url = "#{self.url}##{link_data[:fragment]}"
-        end
+        self.url = link_data[:url] || link_data[:destination_object]
+        self.url = "#{url}?#{link_data[:search]}" if link_data[:search].present?
+        self.url = "#{url}##{link_data[:fragment]}" if link_data[:fragment].present?
         self.target = link_data[:target] if link_data.key?(:target)
         self.title  = link_data[:title] if link_data.key?(:title)
       end
 
       def url=(some_target)
         @url = case some_target
-        when RailsConnector::AbstractObj
-          @destination_object = some_target
-          some_target.path
-        else
-          some_target
+               when RailsConnector::AbstractObj
+                 @destination_object = some_target
+                 some_target.path
+               else
+                 some_target
         end
       end
 

data/lib/reactor/main.rb

@@ -1,21 +1,17 @@
-require 'reactor/rails_connector_meta'
-require 'reactor/legacy'
-require 'reactor/attributes'
-require 'reactor/persistence'
-require 'reactor/validations'
-require 'reactor/permission'
-require 'reactor/workflow'
-require 'reactor/streaming_upload'
-
 module Reactor
   module Main
     def self.included(base)
-      [RailsConnector::Meta, Reactor::Legacy::Base,
-       Reactor::Attributes::Base, Reactor::Persistence::Base,
-       Reactor::Validations::Base, Reactor::Permission::Base,
-       Reactor::Workflow::Base, Reactor::StreamingUpload::Base].each do |mod|
-         base.send(:include, mod)
-       end
+      [
+        Reactor::Legacy::Base,
+        Reactor::Attributes::Base,
+        Reactor::Persistence::Base,
+        Reactor::Validations::Base,
+        Reactor::Permission::Base,
+        Reactor::Workflow::Base,
+        Reactor::StreamingUpload::Base
+      ].each do |mod|
+        base.send(:include, mod)
+      end
     end
   end
 end

data/lib/reactor/migration.rb

@@ -1,52 +1,57 @@
-# -*- encoding : utf-8 -*-
-require 'reactor/plans/create_obj'
-require 'reactor/plans/delete_obj'
-require 'reactor/plans/update_obj'
-require 'reactor/plans/create_obj_class'
-require 'reactor/plans/delete_obj_class'
-require 'reactor/plans/update_obj_class'
-require 'reactor/plans/rename_obj_class'
-require 'reactor/plans/create_attribute'
-require 'reactor/plans/delete_attribute'
-require 'reactor/plans/update_attribute'
-require 'reactor/plans/create_attribute_group'
-require 'reactor/plans/delete_attribute_group'
-require 'reactor/plans/update_attribute_group'
-require 'reactor/plans/create_group'
-require 'reactor/plans/update_group'
-require 'reactor/plans/delete_group'
-require 'reactor/plans/rename_group'
-require 'reactor/plans/create_channel'
-require 'reactor/plans/delete_channel'
+require "reactor/plans/create_obj"
+require "reactor/plans/delete_obj"
+require "reactor/plans/update_obj"
+require "reactor/plans/create_obj_class"
+require "reactor/plans/delete_obj_class"
+require "reactor/plans/update_obj_class"
+require "reactor/plans/rename_obj_class"
+require "reactor/plans/create_attribute"
+require "reactor/plans/delete_attribute"
+require "reactor/plans/update_attribute"
+require "reactor/plans/create_attribute_group"
+require "reactor/plans/delete_attribute_group"
+require "reactor/plans/update_attribute_group"
+require "reactor/plans/create_group"
+require "reactor/plans/update_group"
+require "reactor/plans/delete_group"
+require "reactor/plans/rename_group"
+require "reactor/plans/create_channel"
+require "reactor/plans/delete_channel"
+require "reactor/plans/create_job"
+require "reactor/plans/update_job"
+require "reactor/plans/delete_job"
 
 module Reactor
   class Migration
     METHODS = {
-      :create_obj => Plans::CreateObj,
-      :delete_obj => Plans::DeleteObj,
-      :update_obj => Plans::UpdateObj,
-      :create_class => Plans::CreateObjClass,
-      :delete_class => Plans::DeleteObjClass,
-      :update_class => Plans::UpdateObjClass,
-      :rename_class => Plans::RenameObjClass,
-      :create_attribute => Plans::CreateAttribute,
-      :delete_attribute => Plans::DeleteAttribute,
-      :update_attribute => Plans::UpdateAttribute,
-      :create_attribute_group => Plans::CreateAttributeGroup,
-      :delete_attribute_group => Plans::DeleteAttributeGroup,
-      :update_attribute_group => Plans::UpdateAttributeGroup,
-      :create_group => Plans::CreateGroup,
-      :delete_group => Plans::DeleteGroup,
-      :update_group => Plans::UpdateGroup,
-      :rename_group => Plans::RenameGroup,
-      :create_channel => Plans::CreateChannel,
-      :delete_channel => Plans::DeleteChannel
-    }
+      create_obj: Plans::CreateObj,
+      delete_obj: Plans::DeleteObj,
+      update_obj: Plans::UpdateObj,
+      create_class: Plans::CreateObjClass,
+      delete_class: Plans::DeleteObjClass,
+      update_class: Plans::UpdateObjClass,
+      rename_class: Plans::RenameObjClass,
+      create_attribute: Plans::CreateAttribute,
+      delete_attribute: Plans::DeleteAttribute,
+      update_attribute: Plans::UpdateAttribute,
+      create_attribute_group: Plans::CreateAttributeGroup,
+      delete_attribute_group: Plans::DeleteAttributeGroup,
+      update_attribute_group: Plans::UpdateAttributeGroup,
+      create_group: Plans::CreateGroup,
+      delete_group: Plans::DeleteGroup,
+      update_group: Plans::UpdateGroup,
+      rename_group: Plans::RenameGroup,
+      create_channel: Plans::CreateChannel,
+      delete_channel: Plans::DeleteChannel,
+      create_job: Plans::CreateJob,
+      delete_job: Plans::DeleteJob,
+      update_job: Plans::UpdateJob
+    }.freeze
 
     def self.method_missing(name, *args, &block)
-      if METHODS.key? name.to_sym then
-        instance = init(name,*args)
-        plan(instance,&block)
+      if METHODS.key? name.to_sym
+        instance = init(name, *args)
+        plan(instance, &block)
         prepare(instance)
         migrate(instance)
       else
@@ -70,12 +75,11 @@ module Reactor
       @contained || []
     end
 
-    protected
-    def self.init(name,*args)
+    def self.init(name, *args)
       METHODS[name.to_sym].new(*args)
     end
 
-    def self.plan(instance,&block)
+    def self.plan(instance, &block)
       instance.instance_eval(&block) if block_given?
     end
 
@@ -88,6 +92,7 @@ module Reactor
     end
 
     private
-    def initialize ; end
+
+    def initialize; end
   end
 end

data/lib/reactor/no_working_version.rb

@@ -1,2 +1 @@
-# -*- encoding : utf-8 -*-
-class Reactor::NoWorkingVersion < StandardError ; end
+class Reactor::NoWorkingVersion < StandardError; end

data/lib/reactor/not_permitted.rb

@@ -1,2 +1 @@
-# -*- encoding : utf-8 -*-
-class Reactor::NotPermitted < StandardError ; end
+class Reactor::NotPermitted < StandardError; end

data/lib/reactor/permission.rb

@@ -1,10 +1,8 @@
-# -*- encoding : utf-8 -*-
-require 'reactor/session'
-require 'reactor/cache/permission'
-require 'reactor/cache/user'
+require "reactor/session"
+require "reactor/cache/permission"
+require "reactor/cache/user"
 
 module Reactor
-
   # This module adds #permission method to obj that act as a gateway for permission checking,
   # see documentation for [Permission::PermissionProxy] for more details.
   # @see [Permission::PermissionProxy]
@@ -16,9 +14,7 @@ module Reactor
   #
   # Therefore if the user lacks permissions no futher actions are executed.
   module Permission
-
     module Base
-
       # @see [PermissionProxy]
       def permission
         @permission ||= PermissionProxy.new(self)
@@ -29,7 +25,7 @@ module Reactor
       # @raise [Reactor::NotPermitted] user lacks neccessary permission
       def release!(*args)
         ensure_permission_granted(:release)
-        return super
+        super
       end
 
       # Wraps around Reactor::Persistence::Base#take! and ensures
@@ -37,7 +33,7 @@ module Reactor
       # @raise [Reactor::NotPermitted] user lacks neccessary permission
       def take!(*args)
         ensure_permission_granted(:take)
-        return super
+        super
       end
 
       # Wraps around Reactor::Persistence::Base#revert! and ensures
@@ -45,7 +41,7 @@ module Reactor
       # @raise [Reactor::NotPermitted] user lacks neccessary permission
       def revert!(*args)
         ensure_permission_granted(:revert)
-        return super
+        super
       end
 
       # Wraps around Reactor::Persistence::Base#edit! and ensures
@@ -53,7 +49,7 @@ module Reactor
       # @raise [Reactor::NotPermitted] user lacks neccessary permission
       def edit!(*args)
         ensure_permission_granted(:edit)
-        return super
+        super
       end
 
       # Wraps around ActiveRecord::Persistence#save and ensures
@@ -63,11 +59,11 @@ module Reactor
         if persisted?
           ensure_permission_granted(:write)
         else
-          ensure_create_permission_granted(self.parent_obj_id)
+          ensure_create_permission_granted(parent_obj_id)
         end
-        return super
+        super
       rescue Reactor::NotPermitted
-        return false
+        false
       end
 
       # Wraps around ActiveRecord::Persistence#save! and ensures
@@ -77,9 +73,9 @@ module Reactor
         if persisted?
           ensure_permission_granted(:write)
         else
-          ensure_create_permission_granted(self.parent_obj_id)
+          ensure_create_permission_granted(parent_obj_id)
         end
-        return super
+        super
       end
 
       # Wraps around Reactor::Persistence::Base#resolve_refs! and ensures
@@ -87,22 +83,29 @@ module Reactor
       # @raise [Reactor::NotPermitted] user lacks neccessary permission
       def resolve_refs!
         ensure_permission_granted(:write)
-        return super
+        super
       end
 
       private
 
       def ensure_permission_granted(type)
-        raise Reactor::NotPermitted, "#{self.path} lacks neccessary permissions for #{type}" unless self.permission.send("#{type}?")
-        return true
+        unless permission.send("#{type}?")
+          raise Reactor::NotPermitted, "#{path} lacks neccessary permissions for #{type}"
+        end
+
+        true
       end
 
       def ensure_create_permission_granted(obj_id)
-        raise RuntimeError, "Permission check for object with id=#{obj_id.inspect} which does not exist" unless RailsConnector::AbstractObj.exists?(obj_id)
-        raise Reactor::NotPermitted, 'Obj lacks neccessary permissions for creation' unless RailsConnector::AbstractObj.find(obj_id).permission.create_children?
-        return true
-      end
+        unless RailsConnector::AbstractObj.exists?(obj_id)
+          raise "Permission check for object with id=#{obj_id.inspect} which does not exist"
+        end
+        unless RailsConnector::AbstractObj.find(obj_id).permission.create_children?
+          raise Reactor::NotPermitted, "Obj lacks neccessary permissions for creation"
+        end
 
+        true
+      end
     end
 
     # This class acts as a proxy to underlying permission checking classes.
@@ -111,7 +114,6 @@ module Reactor
     # 2. Given user has the permission
     # 3. Given user doesn't have the permission
     class PermissionProxy
-
       def initialize(obj) #:nodoc:
         @obj = obj
         @cache = Reactor::Cache::Permission.instance
@@ -119,7 +121,7 @@ module Reactor
       end
 
       # Returns true if given user (or current user, if none given) has 'live' permission
-      def live?(user=nil)
+      def live?(user = nil)
         granted?(user, :live)
       end
 
@@ -180,7 +182,7 @@ module Reactor
       def set(permission, groups)
         identifier = identifier(permission)
 
-        groups = [groups] if groups.kind_of?(::String)
+        groups = [groups] if groups.is_a?(::String)
         crul_obj.permission_set(identifier, groups)
       end
 
@@ -189,7 +191,7 @@ module Reactor
       def grant(permission, groups)
         identifier = identifier(permission)
 
-        groups = [groups] if groups.kind_of?(::String)
+        groups = [groups] if groups.is_a?(::String)
         crul_obj.permission_grant(identifier, groups)
       end
 
@@ -198,7 +200,7 @@ module Reactor
       def revoke(permission, groups)
         identifier = identifier(permission)
 
-        groups = [groups] if groups.kind_of?(::String)
+        groups = [groups] if groups.is_a?(::String)
         crul_obj.permission_revoke(identifier, groups)
       end
 
@@ -228,7 +230,7 @@ module Reactor
         end
       rescue Reactor::Cm::MissingCredentials
         raise
-      rescue => e
+      rescue StandardError => e
         Rails.logger.error("Error looking up #{user}'s permission for #{permission} operation on #{obj.path} :\n#{e.message}")
         false
       end
@@ -236,11 +238,11 @@ module Reactor
       # A table with all available permissions and their identifier.
       def self.permissions
         @permissions ||= {
-          :read => 'permissionRead',
-          :root => 'permissionRoot',
-          :live => 'permissionLiveServerRead',
-          :write => 'permissionWrite',
-          :create_children => 'permissionCreateChildren',
+          read: "permissionRead",
+          root: "permissionRoot",
+          live: "permissionLiveServerRead",
+          write: "permissionWrite",
+          create_children: "permissionCreateChildren"
         }
       end
 
@@ -263,7 +265,6 @@ module Reactor
     end
 
     class PermissionLookup
-
       def initialize(obj)
         @obj = obj
         @cache = Reactor::Cache::User.instance
@@ -290,9 +291,6 @@ module Reactor
       def user_in_groups(user, groups)
         groups(user).detect { |user_group| groups.include?(user_group) } != nil
       end
-
     end
-
   end
-
 end