infopark_reactor 1.25.0 → 1.27.0.rc4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0239fbc0807b9a31e6fa80298930ca37465af29d
-  data.tar.gz: 73f6561b9a114871fce30a050ca677e828e6ecf4
+  metadata.gz: 89c72df0c5a6bd7e4cf4dd7ff29322d969f36587
+  data.tar.gz: 506449b0a149136c8a82a974f907b7456facf6d2
 SHA512:
-  metadata.gz: f7bf7b6f924abb2bba8b8d6dd916641c407d99cd6644812005689a1e78cf288871a67e7393db59623e50a6cbc66faa6ecf9e5befa9b4009a628d901a7e230c4b
-  data.tar.gz: 4760a747861ac8d05d4b315cfddf3a3820a76213146eb11b08208ab03b98e120c5438abd3738b94337a65a2693d6c22a190f0569b1c9f4c6996a6fc728c3f8b0
+  metadata.gz: 3d2c5f856c7a87fdc5d64b53b08c2b6ec08cf691acfba972f26142cde57bad0f38e08895365a7e4baf0107dcff0a9e4c3a77fd393efd046b0e49def557828d8f
+  data.tar.gz: beaf24b211c41d1227b253ff2f181f8ab107ae750f764946c786a2f66c9f47cd5df0e485cd4ed1698354eb850284793fd9cc5d83438133e0290231f82a4159af

data/.rubocop.yml

@@ -0,0 +1,25 @@
+inherit_from: .rubocop_todo.yml
+
+require:
+  - rubocop-performance
+
+AllCops:
+  NewCops: enable
+  Exclude:
+    - lib/generators/cm/migration/templates/**/*
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+Style/StringLiteralsInInterpolation:
+  EnforcedStyle: double_quotes
+Style/PercentLiteralDelimiters:
+  PreferredDelimiters:
+    "%i": "()"
+    "%w": "()"
+    "%W": "()"
+Style/Alias:
+  EnforcedStyle: prefer_alias_method
+Style/RedundantBegin:
+  Enabled: false
+Style/StructInheritance:
+  Enabled: false

data/.rubocop_todo.yml

@@ -0,0 +1,363 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config --auto-gen-only-exclude`
+# on 2020-07-17 11:04:06 UTC using RuboCop version 0.87.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
+# SupportedStylesAlignWith: start_of_line, def
+Layout/DefEndAlignment:
+  Exclude:
+    - 'lib/reactor/cm/user.rb'
+    - 'lib/reactor/plans/create_group.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
+# SupportedStylesAlignWith: keyword, variable, start_of_line
+Layout/EndAlignment:
+  Exclude:
+    - 'lib/reactor/attributes.rb'
+    - 'lib/reactor/link/temporary_link.rb'
+    - 'lib/reactor/tools/smart_xml_logger.rb'
+    - 'lib/reactor/tools/workflow_generator.rb'
+
+# Offense count: 9
+Lint/IneffectiveAccessModifier:
+  Exclude:
+    - 'lib/reactor/cm/editorial_group.rb'
+    - 'lib/reactor/cm/group.rb'
+    - 'lib/reactor/cm/live_group.rb'
+    - 'lib/reactor/cm/obj.rb'
+    - 'lib/reactor/cm/user.rb'
+    - 'lib/reactor/permission.rb'
+    - 'lib/reactor/tools/uploader.rb'
+
+# Offense count: 1
+Lint/LiteralAsCondition:
+  Exclude:
+    - 'lib/reactor/persistence.rb'
+
+# Offense count: 2
+Lint/ShadowingOuterLocalVariable:
+  Exclude:
+    - 'lib/reactor/cm/group.rb'
+    - 'lib/reactor/cm/obj_class.rb'
+
+# Offense count: 2
+# Configuration parameters: AllowComments.
+Lint/SuppressedException:
+  Exclude:
+    - 'lib/reactor/tools/sower.rb'
+
+# Offense count: 8
+Lint/UselessAssignment:
+  Exclude:
+    - 'lib/reactor/plans/create_channel.rb'
+    - 'lib/reactor/plans/create_job.rb'
+    - 'lib/reactor/plans/delete_attribute.rb'
+    - 'lib/reactor/plans/delete_channel.rb'
+    - 'lib/reactor/plans/delete_job.rb'
+    - 'lib/reactor/plans/delete_obj_class.rb'
+    - 'lib/reactor/plans/update_attribute.rb'
+    - 'lib/reactor/plans/update_obj_class.rb'
+
+# Offense count: 47
+# Configuration parameters: IgnoredMethods.
+Metrics/AbcSize:
+  Max: 54
+
+# Offense count: 5
+# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods.
+# ExcludedMethods: refine
+Metrics/BlockLength:
+  Exclude:
+    - '**/*.gemspec'
+    - 'lib/reactor/attributes/link_list_extender.rb'
+    - 'lib/reactor/attributes_handlers.rb'
+    - 'lib/reactor/cm/obj_class.rb'
+    - 'lib/tasks/cm_seeds.rake'
+
+# Offense count: 7
+# Configuration parameters: CountComments, Max, CountAsOne.
+Metrics/ClassLength:
+  Exclude:
+    - 'lib/reactor/attributes_handlers.rb'
+    - 'lib/reactor/cm/group.rb'
+    - 'lib/reactor/cm/link.rb'
+    - 'lib/reactor/cm/obj.rb'
+    - 'lib/reactor/cm/obj_class.rb'
+    - 'lib/reactor/cm/object_base.rb'
+    - 'lib/reactor/tools/workflow_generator.rb'
+
+# Offense count: 12
+# Configuration parameters: IgnoredMethods, Max.
+Metrics/CyclomaticComplexity:
+  Exclude:
+    - 'lib/reactor/attributes/date_serializer.rb'
+    - 'lib/reactor/attributes/link_list_extender.rb'
+    - 'lib/reactor/attributes_handlers.rb'
+    - 'lib/reactor/cm/obj.rb'
+    - 'lib/reactor/cm/obj_class.rb'
+    - 'lib/reactor/legacy.rb'
+    - 'lib/reactor/link/temporary_link.rb'
+    - 'lib/reactor/persistence.rb'
+    - 'lib/reactor/tools/response_handler/xml_attribute.rb'
+    - 'lib/reactor/tools/smart_xml_logger.rb'
+    - 'lib/reactor/tools/where_query.rb'
+    - 'lib/reactor/validations.rb'
+
+# Offense count: 55
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
+Metrics/MethodLength:
+  Max: 79
+
+# Offense count: 2
+# Configuration parameters: CountComments, Max, CountAsOne.
+Metrics/ModuleLength:
+  Exclude:
+    - 'lib/reactor/attributes.rb'
+    - 'lib/reactor/persistence.rb'
+
+# Offense count: 5
+# Configuration parameters: IgnoredMethods, Max.
+Metrics/PerceivedComplexity:
+  Exclude:
+    - 'lib/reactor/attributes/date_serializer.rb'
+    - 'lib/reactor/cm/obj.rb'
+    - 'lib/reactor/legacy.rb'
+    - 'lib/reactor/tools/smart_xml_logger.rb'
+    - 'lib/reactor/tools/sower.rb'
+
+# Offense count: 7
+Naming/AccessorMethodName:
+  Exclude:
+    - 'lib/reactor/cm/group.rb'
+    - 'lib/reactor/cm/obj.rb'
+    - 'lib/reactor/cm/object_base.rb'
+    - 'lib/reactor/cm/permissions.rb'
+    - 'lib/reactor/cm/xml_markup.rb'
+    - 'lib/reactor/persistence.rb'
+
+# Offense count: 1
+Naming/ConstantName:
+  Exclude:
+    - 'app/models/rails_connector/abstract_obj.rb'
+
+# Offense count: 9
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+Naming/HeredocDelimiterNaming:
+  Exclude:
+    - 'lib/reactor/attributes_handlers.rb'
+    - 'lib/reactor/cm/object_base.rb'
+
+# Offense count: 4
+# Configuration parameters: EnforcedStyleForLeadingUnderscores.
+# SupportedStylesForLeadingUnderscores: disallowed, required, optional
+Naming/MemoizedInstanceVariableName:
+  Exclude:
+    - 'lib/reactor/attributes.rb'
+    - 'lib/reactor/attributes/date_serializer.rb'
+    - 'lib/reactor/session_helper/rsession_helper.rb'
+
+# Offense count: 5
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+Naming/MethodParameterName:
+  Exclude:
+    - 'lib/reactor/cm/bridge.rb'
+    - 'lib/reactor/cm/obj.rb'
+    - 'lib/reactor/tools/sower.rb'
+
+# Offense count: 9
+# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
+# NamePrefix: is_, has_, have_
+# ForbiddenPrefixes: is_, has_, have_
+# AllowedMethods: is_a?
+# MethodDefinitionMacros: define_method, define_singleton_method
+Naming/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/reactor/cm/link.rb'
+    - 'lib/reactor/cm/obj_class.rb'
+    - 'lib/reactor/cm/user.rb'
+    - 'lib/reactor/permission.rb'
+    - 'lib/reactor/persistence.rb'
+
+# Offense count: 15
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: snake_case, camelCase
+Naming/VariableName:
+  Exclude:
+    - 'lib/reactor/cm/bridge.rb'
+    - 'lib/reactor/cm/obj.rb'
+    - 'lib/reactor/plans/create_obj.rb'
+    - 'lib/reactor/tools/sower.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Security/YAMLLoad:
+  Exclude:
+    - 'lib/reactor/tools/versioner.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowedChars.
+Style/AsciiComments:
+  Exclude:
+    - 'lib/reactor/cm/language.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle.
+# SupportedStyles: nested, compact
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'lib/reactor/no_working_version.rb'
+    - 'lib/reactor/not_permitted.rb'
+    - 'lib/reactor/session.rb'
+
+# Offense count: 2
+Style/ClassVars:
+  Exclude:
+    - 'lib/reactor/cache/permission.rb'
+    - 'lib/reactor/cache/user.rb'
+
+# Offense count: 2
+Style/CommentedKeyword:
+  Exclude:
+    - 'lib/reactor/cm/obj.rb'
+    - 'lib/reactor/validations.rb'
+
+# Offense count: 118
+Style/Documentation:
+  Enabled: false
+
+# Offense count: 2
+Style/EvalWithLocation:
+  Exclude:
+    - 'lib/reactor/attributes_handlers.rb'
+    - 'lib/reactor/cm/object_base.rb'
+
+# Offense count: 115
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Offense count: 4
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'lib/reactor/attributes/link_list_extender.rb'
+    - 'lib/reactor/cm/log_entry.rb'
+    - 'lib/reactor/plans/create_obj.rb'
+    - 'lib/reactor/tools/uploader.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+Style/HashEachMethods:
+  Exclude:
+    - 'lib/reactor/permission.rb'
+    - 'lib/reactor/plans/common_attribute.rb'
+    - 'lib/reactor/plans/common_attribute_group.rb'
+    - 'lib/reactor/plans/common_channel.rb'
+    - 'lib/reactor/plans/common_group.rb'
+    - 'lib/reactor/plans/common_job.rb'
+    - 'lib/reactor/plans/common_obj_class.rb'
+    - 'lib/reactor/tools/workflow_generator.rb'
+
+# Offense count: 4
+Style/IdenticalConditionalBranches:
+  Exclude:
+    - 'lib/reactor/tools/workflow_generator.rb'
+    - 'lib/reactor/tools/xml_attributes.rb'
+
+# Offense count: 9
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'lib/reactor/attributes.rb'
+    - 'lib/reactor/cm/obj.rb'
+    - 'lib/reactor/permission.rb'
+    - 'lib/reactor/persistence.rb'
+    - 'lib/reactor/plans/create_obj.rb'
+    - 'lib/reactor/tools/sower.rb'
+    - 'lib/reactor/validations.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: InverseMethods, InverseBlocks.
+Style/InverseMethods:
+  Exclude:
+    - 'lib/reactor/plans/prepared.rb'
+
+# Offense count: 1
+Style/MethodMissingSuper:
+  Exclude:
+    - 'lib/reactor/migration.rb'
+
+# Offense count: 1
+Style/MissingRespondToMissing:
+  Exclude:
+    - 'lib/reactor/migration.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: IncludeSemanticChanges.
+Style/NonNilCheck:
+  Exclude:
+    - 'lib/reactor/permission.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: .
+# SupportedStyles: use_perl_names, use_english_names
+Style/SpecialGlobalVars:
+  EnforcedStyle: use_perl_names
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoredMethods.
+# IgnoredMethods: respond_to, define_method
+Style/SymbolProc:
+  Exclude:
+    - 'lib/reactor/cm/obj.rb'
+    - 'lib/reactor/cm/obj_class.rb'
+    - 'lib/reactor/tools/smart_xml_logger.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, AllowSafeAssignment.
+# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
+Style/TernaryParentheses:
+  Exclude:
+    - 'lib/reactor/cm/obj.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, AllowedMethods.
+# AllowedMethods: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
+Style/TrivialAccessors:
+  Exclude:
+    - 'lib/reactor/plans/common_attribute_group.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: forbid_for_all_comparison_operators, forbid_for_equality_operators_only, require_for_all_comparison_operators, require_for_equality_operators_only
+Style/YodaCondition:
+  Exclude:
+    - 'lib/reactor/validations.rb'
+
+# Offense count: 29
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 248

data/Rakefile

@@ -1,25 +1,22 @@
-require 'bundler'
-#require 'yard'
+require "bundler"
+# require 'yard'
 Bundler::GemHelper.install_tasks
 
-#YARD::Rake::YardocTask.new do |t|
+# YARD::Rake::YardocTask.new do |t|
 #  t.files   = ['lib/**/*.rb']   # optional
 ##  t.options = ['--any', '--extra', '--opts'] # optional
-#end
-
+# end
 
 # remove this task, when this gem is distributed as a `real` gem (and not included in Gemfile through `:path =>` )
 task :update_gemspec_for_distribution do
-
-  fn = Dir[File.expand_path('../*.gemspec', __FILE__)].first
+  fn = Dir[File.expand_path("*.gemspec", __dir__)].first
   source_gemspec = File.read(fn)
 
-  source_gemspec.gsub!(/^([\t ]*)((s.files\s*=)[^\n]+\n)/m) {|s| "#{$1}##{$2}#{$1}#{$3} #{`git ls-files`.split("\n").inspect}\n"}
-  source_gemspec.gsub!(/^([\t ]*)((s.test_files\s*=)[^\n]+\n)/m) {|s| "#{$1}##{$2}#{$1}#{$3} #{`git ls-files -- {test,spec,features}/*`.split("\n").inspect}\n"}
-  source_gemspec.gsub!(/^([\t ]*)((s.executables\s*=)[^\n]+\n)/m) {|s| "#{$1}##{$2}#{$1}#{$3} #{`git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }.inspect}\n"}
+  source_gemspec.gsub!(/^([\t ]*)((s.files\s*=)[^\n]+\n)/m) { |_s| "#{Regexp.last_match(1)}##{Regexp.last_match(2)}#{Regexp.last_match(1)}#{Regexp.last_match(3)} #{`git ls-files`.split("\n").inspect}\n" }
+  source_gemspec.gsub!(/^([\t ]*)((s.test_files\s*=)[^\n]+\n)/m) { |_s| "#{Regexp.last_match(1)}##{Regexp.last_match(2)}#{Regexp.last_match(1)}#{Regexp.last_match(3)} #{`git ls-files -- {test,spec,features}/*`.split("\n").inspect}\n" }
+  source_gemspec.gsub!(/^([\t ]*)((s.executables\s*=)[^\n]+\n)/m) { |_s| "#{Regexp.last_match(1)}##{Regexp.last_match(2)}#{Regexp.last_match(1)}#{Regexp.last_match(3)} #{`git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }.inspect}\n" }
 
-  File.open("#{fn}.resolved", 'w') do |f|
+  File.open("#{fn}.resolved", "w") do |f|
     f.write source_gemspec
   end
-
-end
+end

data/app/models/rails_connector/abstract_obj.rb

@@ -1,3 +1,4 @@
+# TODO: RailsConnector for rails version 5 has only support for newer version of RailsConnector
 module RailsConnector
   # This trick is a workaround to provide compatiblity with both
   # ObjExtensions-enabled versions (older versions) and ObjExtensions-deprecated
@@ -25,7 +26,7 @@ module RailsConnector
 
   class AbstractObj
     def self.compute_type(type_name)
-      try_type { type_name.constantize } || self 
+      try_type { type_name.constantize } || self
     end
   end
 end