infopark-politics 0.2.9 → 0.2.10

data/lib/politics/static_queue_worker.rb

@@ -57,39 +57,32 @@ module Politics
   # Note: process_bucket never returns i.e. this should be the main loop of your processing daemon.
   #
   module StaticQueueWorker
-
-    def self.included(model) #:nodoc:
-      model.class_eval do
-        attr_accessor :group_name, :iteration_length, :uri
-      end
-    end
+    attr_reader :group_name, :iteration_length, :dictatorship_length, :uri, :buckets
 
     # Register this process as able to work on buckets.
-    def register_worker(name, bucket_count, config={})
+    def register_worker(name, bucket_count, config = {})
       options = {
-            :iteration_length => 60,
+            :iteration_length => 10,
             :servers => ['127.0.0.1:11211']
-          }
-      options.merge!(config)
+          }.merge(config)
 
-      self.group_name = name
-      self.iteration_length = options[:iteration_length]
+      @group_name = name
+      @iteration_length = options[:iteration_length]
       @memcache_client = client_for(Array(options[:servers]))
       @nominated_at = Time.now
       # FIXME: Tests
       @domain = options[:domain]
+      @dictatorship_length = options[:dictatorship_length]
 
       @buckets = []
       @bucket_count = bucket_count
 
       register_with_bonjour
-      log.progname = @uri
+      log.progname = uri
       log.info { "Registered in group #{group_name} at port #{@port}" }
     end
 
     # Fetch a bucket out of the queue and pass it to the given block to be processed.
-    #
-    # +bucket+::            The bucket number to process, within the range 0...TOTAL_BUCKETS
     def process_bucket(&block)
       log.debug "start bucket processing"
       raise ArgumentError, "process_bucket requires a block!" unless block_given?
@@ -104,20 +97,8 @@ module Politics
         begin
           nominate
           if leader?
-            # Drb thread handles leader duties
             log.info { "has been elected leader" }
-            initialize_buckets
-            # keeping leader state as long as buckets are available by renominating before
-            # nomination times out
-            while !@buckets.empty? do
-              log.debug { "relaxes half the time until next iteration" }
-              relax(until_next_iteration / 2)
-              log.debug { "renew nomination too keep the hat and finish the work" }
-              @memcache_client.set(token, @uri, iteration_length)
-              @nominated_at = Time.now
-              log.error { "tried to staying leader but failed" } unless leader?
-            end
-            relax until_next_iteration
+            perform_leader_duties
           else
             # Get a bucket from the leader and process it
             begin
@@ -135,6 +116,37 @@ module Politics
       end while loop?
     end
 
+    def as_dictator(&block)
+      duration = dictatorship_length || (iteration_length * 10)
+      log.debug { "become dictator for up to #{duration} seconds" }
+      seize_leadership duration
+      yield
+      raise "lost leadership while being dictator for #{duration} seconds" unless leader?
+      seize_leadership
+    end
+
+    def seize_leadership(duration = nil)
+      @memcache_client.set(token, uri, duration || iteration_length)
+      @nominated_at = Time.now
+    end
+
+    def perform_leader_duties
+      # Drb thread handles requests to leader
+      as_dictator do
+        initialize_buckets
+      end
+      # keeping leader state as long as buckets are available by renominating before nomination
+      # times out
+      while !buckets.empty? do
+        log.debug { "relaxes half the time until next iteration" }
+        relax(until_next_iteration / 2)
+        as_dictator do
+          update_buckets
+        end
+      end
+      relax until_next_iteration
+    end
+
     def bucket_request(requestor_uri)
       if leader?
         log.debug "delivering bucket request"
@@ -186,6 +198,9 @@ module Politics
       @bucket_count.times { |idx| @buckets << idx }
     end
 
+    def update_buckets
+    end
+
     def replicas
       @replicas ||= []
     end
@@ -226,7 +241,7 @@ module Politics
     def nominate
       log.debug("try to nominate")
       @nominated_at = Time.now
-      @memcache_client.add(token, @uri, iteration_length)
+      @memcache_client.add(token, uri, iteration_length)
       @leader_uri = nil
     end
 
@@ -237,7 +252,7 @@ module Politics
     # Check to see if we are leader by looking at the process name
     # associated with the token.
     def leader?
-      until_next_iteration > 0 && @uri == leader_uri
+      until_next_iteration > 0 && uri == leader_uri
     end
 
     # Easy to mock or monkey-patch if another MemCache client is preferred.
@@ -258,7 +273,7 @@ module Politics
       @port = URI.parse(DRb.uri).port
 
       # Register our DRb server with Bonjour.
-      name = "#{self.group_name}-#{local_ip}-#{$$}"
+      name = "#{group_name}-#{local_ip}-#{$$}"
       type = "_#{group_name}._tcp"
       domain = "local"
       log.debug "register service #{name} of type #{type} within domain #{domain} at port #{@port}"

data/spec/static_queue_worker_spec.rb

@@ -4,6 +4,8 @@ $:.unshift(File.dirname(__FILE__) + '/../lib')
 require File.dirname(__FILE__) + '/../lib/init'
 Politics::log.level = Logger::FATAL
 
+@@memcache_client = nil
+
 class Worker
   include Politics::StaticQueueWorker
   def initialize
@@ -16,10 +18,15 @@ class Worker
       sleep 0.1
     end
   end
+
+  def client_for(servers)
+    @@memcache_client
+  end
 end
 
 describe Worker do
   before do
+    @@memcache_client = mock('memcache', :set => nil, :get => nil)
     @worker = Worker.new
   end
 
@@ -40,7 +47,7 @@ describe Worker do
     @worker.should be_alive
   end
 
-  describe Worker, "when processing bucket" do
+  describe "when processing bucket" do
     before do
       DRbObject.stub!(:new).with(nil, @worker.uri).
           and_return(@worker_drb = mock('drb', :alive? => true))
@@ -74,6 +81,17 @@ describe Worker do
         @worker.start
       end
 
+      describe "as leader" do
+        before do
+          @worker.stub!(:leader?).and_return true
+        end
+
+        it "should do leader duties" do
+          @worker.should_receive(:perform_leader_duties).exactly(4).times
+          @worker.start
+        end
+      end
+
       describe "as follower" do
         before do
           @worker.stub!(:leader?).and_return false
@@ -90,7 +108,7 @@ describe Worker do
     end
   end
 
-  describe Worker, "when handling a bucket request" do
+  describe "when handling a bucket request" do
     describe "as leader" do
       before do
         @worker.stub!(:leader?).and_return true
@@ -112,4 +130,55 @@ describe Worker do
       end
     end
   end
+
+  describe "when performing leader duties" do
+    before do
+      @worker.stub!(:until_next_iteration).and_return 0
+      @worker.stub!(:leader?).and_return true
+      @worker.stub!(:dictatorship_length).and_return 666
+      @worker.stub!(:iteration_length).and_return 5
+    end
+
+    it "should initialize buckets as dictator" do
+      @worker.should_receive(:seize_leadership).with(666).ordered
+      @worker.should_receive(:initialize_buckets).ordered
+      @worker.should_receive(:seize_leadership).ordered
+      @worker.perform_leader_duties
+    end
+
+    describe "as long as there are buckets" do
+      before do
+        @worker.stub!(:buckets).and_return([1], [2], [3], [4], [])
+        @worker.stub!(:relax)
+      end
+
+      it "should update buckets periodically" do
+        @worker.should_receive(:update_buckets).exactly(4).times
+        @worker.perform_leader_duties
+      end
+
+      it "should relax half of the time to the next iteration" do
+        @worker.stub!(:until_next_iteration).and_return(6)
+        @worker.should_receive(:relax).with(3).exactly(4).times
+        @worker.perform_leader_duties
+      end
+
+      it "should seize the leadership periodically" do
+        @worker.should_receive(:seize_leadership).at_least(4).times
+        @worker.perform_leader_duties
+      end
+    end
+
+    describe "if there are no more buckets" do
+      before do
+        @worker.stub!(:buckets).and_return([])
+      end
+
+      it "should relax until next iteration" do
+        @worker.stub!(:until_next_iteration).and_return(6)
+        @worker.should_receive(:relax).with(6).once
+        @worker.perform_leader_duties
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: infopark-politics
 version: !ruby/object:Gem::Version 
-  version: 0.2.9
+  version: 0.2.10
 platform: ruby
 authors: 
 - Mike Perham
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-05-30 00:00:00 -07:00
+date: 2009-06-29 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency