infopark-aws_utils 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fd62159a173f03f500066e9abfdaa4c07ab91437
-  data.tar.gz: 07053c3acbeeaa985256b30dbb8d8299922c0c9a
+  metadata.gz: 006b2100b6b073324eaca1778953e0145be0fd50
+  data.tar.gz: 81aef7b6cb4db98985357c06a27ac58309541b3a
 SHA512:
-  metadata.gz: 4650e70e0480fa700d93cd1fab9393fd67cfa1fe76725a21dc69167260f82507bd1cbd0bd1121dc7e19e90408ab192453beb212e7a98b29e73774dc2a1d5f6bf
-  data.tar.gz: 9c409dd94f8874f69fc176876bfe30b20a0a32bf4897940c4018e434a2379a5a6e1cde4e91ed05987b6d66f249e6c010044012da3407d9758eb7447c1f3134ff
+  metadata.gz: 32e2faf37d95a697c58fa97cbe3460cf2024e42ab098c34127ad31703cc64ef4ce63176d038946d29972d6fdf2d6e69142abaefc97ccf7328c8972fc8cef0b3c
+  data.tar.gz: a185ecc2feabf5fb080c00f2b754720e857c10ef7dc2a9f071ddb26ce06d20c5d085bfeb24a66cb9bfae49c5ee2baa21cfc2667c8dd34f7dc5d4d8d8732ff87f

data/.travis.yml

@@ -1,14 +1,7 @@
 language: ruby
 rvm:
-- 2.2
-- 2.3
+- 2.4
+- 2.5
+- 2.6
 script:
 - bundle exec rspec spec
-deploy:
-  provider: rubygems
-  api_key:
-    secure: e4QeU1KKglgUR6y0kWCxGTjjhmC1Txmw4p1PiWt5Sj+dg3eSnr5PO5cCU+YsBo1fVBOhxpcZXwDk0iv8q0s3SqWbask6awXCBh9I7nnstLI5HgoR0ydS6rVsOUX7tWSPHVwHFUBL83iArHkuFRvsCZl2HQr3YecvBAQzXVc7EsPfvu1Rpfjyz3N4wWzpkItge+j5m6uX80dacOpPd9YXOMMd1qMzAB3VbySN8KUXszJL3YgMV/MAaEc4djj+s3GiPCnVjTPVdIb5ZVl0HH+LtkXfgVgxHMyDhwPflBmgg/lnYQG51DcrlHn8mNsJOO0crgqc/B6xqjAalaRLf6iBDqSdx08TulgwQeBlhuq+YWBsV7ZL39NZgZiXLU+NW9ZW9iXy1I7z0PAhHlx1JaCVpNxUlG5fGvPkvOywo368taFJaYvdiTjW+IyaPO5UwcxTlWZlR+vQD/QEc7dsIHXu9/pWxfyycZI/hSnGJwa3lOx+mnU8GZbtufWsIRqnfxM6X0BVWS2BNLlK5drluj+jt0aW8tLSiYRNSY1DuL8U2CM9p3TjeOWvgBPGGzwApBI9/2RRP/E4KtW6ms+YnjT5veXE5rz1z/WmCoyWPdVfchd9J421+QGpq8WNGxnYImug0/mZtkGNkHg0b6nRWuorao/fxWkkDstjK/tk7T0iTug=
-  gem: cloudscopes
-  on:
-    tags: true
-    repo: infopark/aws_utils

data/lib/infopark/aws_utils/env.rb

@@ -26,10 +26,21 @@ class Env
 
   def initialize(profile_name = nil)
     @credentials = Aws::SharedCredentials.new(profile_name: profile_name)
+    if @credentials.credentials.nil?
+      raise "No credentials for AWS profile “#{profile_name}” found."\
+          " Please provide them via ~/.aws/credentials."
+    end
+
+    region = Aws.shared_config.region(profile: profile_name)
+    if region.nil?
+      raise "No region for AWS profile “#{profile_name}” found."\
+          " Please provide them via ~/.aws/config."
+    end
+
     @clients = Hash.new do |clients, mod|
       clients[mod] = mod.const_get(:Client).new(
         credentials: @credentials,
-        region: Aws.shared_config.region(profile: profile_name),
+        region: region,
       )
     end
   end

data/lib/infopark/aws_utils/version.rb

@@ -1,5 +1,5 @@
 module Infopark
   module AwsUtils
-    VERSION = "0.8.0"
+    VERSION = "0.8.1"
   end
 end

data/spec/env_spec.rb

@@ -1,7 +1,7 @@
 RSpec.describe Infopark::AwsUtils::Env do
   let(:account_id) { nil }
   let(:sts) do
-    Aws::STS::Client.new.tap do |client|
+    Aws::STS::Client.new(region: "eu-west-1").tap do |client|
       allow(client).to receive(:get_caller_identity)
           .and_return(double(:caller_identity, account: account_id))
     end
@@ -18,8 +18,16 @@ RSpec.describe Infopark::AwsUtils::Env do
     subject { Infopark::AwsUtils::Env.profile(requested_profile) }
 
     before do
-      allow(Aws::SharedCredentials).to receive(:new).with(profile_name: requested_profile).
-          and_return(instance_double(Aws::SharedCredentials, profile_name: requested_profile))
+      allow(Aws::SharedCredentials).to receive(:new).with(profile_name: requested_profile)
+        .and_return(
+          instance_double(
+            Aws::SharedCredentials,
+            profile_name: requested_profile,
+            credentials: instance_double(Aws::Credentials),
+          ),
+        )
+      allow(Aws.shared_config).to receive(:region).with(profile: requested_profile)
+        .and_return("eu-west-1")
     end
 
     it { is_expected.to be_a(Infopark::AwsUtils::Env) }
@@ -42,14 +50,55 @@ RSpec.describe Infopark::AwsUtils::Env do
       end
     end
 
+    context "when requested profile has no credentials configured" do
+      before do
+        allow(Aws::SharedCredentials).to receive(:new).with(profile_name: requested_profile)
+          .and_return(
+            instance_double(
+              Aws::SharedCredentials,
+              profile_name: requested_profile,
+              credentials: nil,
+            ),
+          )
+      end
+
+      it "raises an error, asking for the credentials to be configured" do
+        expect {
+          subject
+        }.to raise_error("No credentials for AWS profile “#{requested_profile}” found."\
+                         " Please provide them via ~/.aws/credentials.")
+      end
+    end
+
+    context "when requested profile has no region configured" do
+      before do
+        allow(Aws.shared_config).to receive(:region).with(profile: requested_profile)
+          .and_return(nil)
+      end
+
+      it "raises an error, asking for the region to be configured" do
+        expect {
+          subject
+        }.to raise_error("No region for AWS profile “#{requested_profile}” found."\
+                         " Please provide them via ~/.aws/config.")
+      end
+    end
+
     context "when environment variable is set" do
       let(:value) { "#{requested_profile}_by_env" }
 
       before do
         allow(ENV).to receive(:[]).and_call_original
         allow(ENV).to receive(:[]).with(env_var).and_return(value)
-        allow(Aws::SharedCredentials).to receive(:new).with(profile_name: value).
-            and_return(instance_double(Aws::SharedCredentials, profile_name: value))
+        allow(Aws::SharedCredentials).to receive(:new).with(profile_name: value).and_return(
+          instance_double(
+            Aws::SharedCredentials,
+            profile_name: value,
+            credentials: instance_double(Aws::Credentials),
+          ),
+        )
+        allow(Aws.shared_config).to receive(:region).with(profile: value)
+          .and_return("eu-west-1")
       end
 
       it "uses credentials for this profile" do
@@ -73,6 +122,17 @@ RSpec.describe Infopark::AwsUtils::Env do
   end
 
   describe "#account_type" do
+    before do
+      allow(Aws::SharedCredentials).to receive(:new).and_return(
+        instance_double(
+          Aws::SharedCredentials,
+          profile_name: "foo",
+          credentials: instance_double(Aws::Credentials),
+        ),
+      )
+      allow(Aws.shared_config).to receive(:region).and_return("eu-west-1")
+    end
+
     subject(:account_type) { env.account_type }
 
     context "for profile in development account" do
@@ -99,6 +159,17 @@ RSpec.describe Infopark::AwsUtils::Env do
   end
 
   describe "#dev_account?" do
+    before do
+      allow(Aws::SharedCredentials).to receive(:new).and_return(
+        instance_double(
+          Aws::SharedCredentials,
+          profile_name: "foo",
+          credentials: instance_double(Aws::Credentials),
+        ),
+      )
+      allow(Aws.shared_config).to receive(:region).and_return("eu-west-1")
+    end
+
     subject { env.dev_account? }
 
     context "for development account" do
@@ -121,6 +192,17 @@ RSpec.describe Infopark::AwsUtils::Env do
   end
 
   describe "#prod_account?" do
+    before do
+      allow(Aws::SharedCredentials).to receive(:new).and_return(
+        instance_double(
+          Aws::SharedCredentials,
+          profile_name: "foo",
+          credentials: instance_double(Aws::Credentials),
+        ),
+      )
+      allow(Aws.shared_config).to receive(:region).and_return("eu-west-1")
+    end
+
     subject { env.prod_account? }
 
     context "for development account" do
@@ -154,6 +236,17 @@ RSpec.describe Infopark::AwsUtils::Env do
     [:sts, Aws::STS],
   ].each do |_client, _mod|
     describe "##{_client}" do
+      before do
+        allow(Aws::SharedCredentials).to receive(:new).and_return(
+          instance_double(
+            Aws::SharedCredentials,
+            profile_name: "foo",
+            credentials: instance_double(Aws::Credentials),
+          ),
+        )
+        allow(Aws.shared_config).to receive(:region).and_return("eu-west-1")
+      end
+
       subject(:client) { env.send(_client) }
 
       it { is_expected.to be_a(_mod.const_get("Client")) }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: infopark-aws_utils
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Tilo Prütz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-11 00:00:00.000000000 Z
+date: 2020-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-applicationautoscaling