influxdb-rails 1.0.0.beta4 → 1.0.1

data/.travis.yml

@@ -1,37 +0,0 @@
-sudo: required
-dist: trusty
-language: ruby
-before_install:
-  - gem update --system --no-doc
-  - gem install bundler --no-doc
-  - gem update bundler --no-doc
-rvm:
-  - ruby-head
-  - "2.6"
-  - "2.5"
-  - "2.4"
-  - "2.3"
-gemfile:
-  - gemfiles/Gemfile.rails-5.2.x
-  - gemfiles/Gemfile.rails-5.1.x
-  - gemfiles/Gemfile.rails-5.0.x
-  - gemfiles/Gemfile.rails-4.2.x
-env:
-  - TEST_TASK=spec
-matrix:
-  allow_failures:
-    - rvm: ruby-head
-  include:
-    - { rvm: "2.6",   gemfile: "Gemfile", env: [TEST_TASK=rubocop] }
-  exclude:
-    # Rails < 5 not on MRI 2.4+
-    - { rvm: ruby-head, gemfile: "gemfiles/Gemfile.rails-4.2.x" }
-    - { rvm: "2.6",   gemfile: "gemfiles/Gemfile.rails-4.2.x" }
-    - { rvm: "2.5",   gemfile: "gemfiles/Gemfile.rails-4.2.x" }
-    - { rvm: "2.4",   gemfile: "gemfiles/Gemfile.rails-4.2.x" }
-addons:
-  apt:
-    packages:
-      - haveged
-      - libgmp-dev
-script: bundle exec rake $TEST_TASK

data/gemfiles/Gemfile.rails-4.2.x

@@ -1,7 +0,0 @@
-source "https://rubygems.org"
-
-gem 'actionpack', '~> 4.2.0'
-gem 'activesupport', '~> 4.2.0'
-gem 'activemodel', '~> 4.2.0'
-
-gemspec :path => '../'

data/gemfiles/Gemfile.rails-5.0.x

@@ -1,7 +0,0 @@
-source "https://rubygems.org"
-
-gem 'actionpack', '~> 5.0.0'
-gem 'activesupport', '~> 5.0.0'
-gem 'activemodel', '~> 5.0.0'
-
-gemspec :path => '../'

data/gemfiles/Gemfile.rails-5.1.x

@@ -1,7 +0,0 @@
-source "https://rubygems.org"
-
-gem 'actionpack', '~> 5.1.0'
-gem 'activesupport', '~> 5.1.0'
-gem 'activemodel', '~> 5.1.0'
-
-gemspec :path => '../'

data/lib/influxdb/rails/instrumentation.rb

@@ -1,34 +0,0 @@
-module InfluxDB
-  module Rails
-    module Instrumentation
-      def benchmark_for_instrumentation # rubocop:disable Metrics/MethodLength
-        start = Time.now
-        yield
-
-        c = InfluxDB::Rails.configuration
-        return if c.ignore_current_environment?
-
-        InfluxDB::Rails.client.write_point \
-          "instrumentation".freeze,
-          values: {
-            value: ((Time.now - start) * 1000).ceil,
-          },
-          tags:   c.tags_middleware.call(
-            method: "#{controller_name}##{action_name}",
-            server: Socket.gethostname
-          )
-      end
-
-      def self.included(base)
-        base.extend(ClassMethods)
-      end
-
-      module ClassMethods
-        def instrument(methods = [])
-          methods = [methods] unless methods.is_a?(Array)
-          around_filter :benchmark_for_instrumentation, only: methods
-        end
-      end
-    end
-  end
-end

data/lib/influxdb/rails/middleware/simple_subscriber.rb

@@ -1,33 +0,0 @@
-require "influxdb/rails/middleware/subscriber"
-
-module InfluxDB
-  module Rails
-    module Middleware
-      # Subscriber acts as base class for different *Subscriber classes,
-      # which are intended as ActiveSupport::Notifications.subscribe
-      # consumers.
-      class SimpleSubscriber < Subscriber
-        def call(_name, started, finished, _id, payload)
-          return unless enabled?
-
-          InfluxDB::Rails.client.write_point \
-            configuration.measurement_name,
-            values:    values(started, finished, payload),
-            tags:      tags(payload),
-            timestamp: timestamp(finished)
-        rescue StandardError => e
-          ::Rails.logger.error("[InfluxDB::Rails] Unable to write points: #{e.message}")
-        end
-
-        private
-
-        def values(started, finished, _payload)
-          result = { value: ((finished - started) * 1000).ceil }
-          result.merge(InfluxDB::Rails.current.values).reject do |_, value|
-            value.nil? || value == ""
-          end
-        end
-      end
-    end
-  end
-end

data/spec/controllers/widgets_controller_spec.rb

@@ -1,15 +0,0 @@
-require "spec_helper"
-
-RSpec.describe WidgetsController, type: :controller do
-  describe "#new" do
-    it "should raise an exception" do
-      expect { get :new }.to raise_error(ZeroDivisionError)
-    end
-  end
-
-  describe "#index" do
-    it "should not raise an exception" do
-      expect { get :index }.to_not raise_error
-    end
-  end
-end

data/spec/integration/integration_helper.rb

@@ -1 +0,0 @@
-require File.dirname(__FILE__) + "/../spec_helper"

data/spec/integration/metrics_spec.rb

@@ -1,27 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + "/integration_helper")
-
-RSpec.describe "User visits widgets", type: :request do
-  before do
-    allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:ignored_environments).and_return(%w[development])
-  end
-
-  describe "in a normal request" do
-    it "should result in attempts to write metrics via the client" do
-      expect(InfluxDB::Rails.client).to receive(:write_point).exactly(5).times
-      get "/widgets"
-    end
-
-    context "additional values" do
-      it "should result in attempts to write metrics via the client" do
-        allow_any_instance_of(ActionDispatch::Request).to receive(:request_id).and_return(:request_id)
-        expect(InfluxDB::Rails.client).to receive(:write_point).with(
-          "rails", a_hash_including(
-                     tags:   a_hash_including(method: "WidgetsController#index", hook: "process_action"),
-                     values: a_hash_including(request_id: :request_id, key: :value)
-                   )
-        )
-        get "/widgets"
-      end
-    end
-  end
-end

data/spec/shared_examples/data.rb

@@ -1,61 +0,0 @@
-require "spec_helper"
-
-RSpec.shared_examples_for "with additional data" do
-  context "values" do
-    let(:additional_values) do
-      { another: :value }
-    end
-
-    after do
-      InfluxDB::Rails.current.reset
-    end
-
-    it "does include the tags" do
-      InfluxDB::Rails.current.values = additional_values
-
-      expect_any_instance_of(InfluxDB::Client).to receive(:write_point).with(config.measurement_name, hash_including(values: hash_including(another: :value)))
-
-      subject.call("unused", start, finish, "unused", payload)
-    end
-  end
-
-  context "tags" do
-    context "when tags_middleware is overwritten" do
-      before do
-        allow(config).to receive(:tags_middleware).and_return(tags_middleware)
-      end
-
-      let(:tags_middleware) { ->(tags) { tags.merge(static: "value", nil: nil, empty: "") } }
-
-      it "processes tags throught the middleware" do
-        tags = data[:tags].merge(static: "value")
-
-        expect_any_instance_of(InfluxDB::Client).to receive(:write_point).with(config.measurement_name, include(tags: tags))
-
-        subject.call("unused", start, finish, "unused", payload)
-      end
-    end
-
-    context "when tags are set in the current context" do
-      let(:input) do
-        { another: :value, nil: nil, empty: "" }
-      end
-      let(:output) do
-        { another: :value }
-      end
-
-      after do
-        InfluxDB::Rails.current.reset
-      end
-
-      it "does include the tags" do
-        InfluxDB::Rails.current.tags = input
-        tags = data[:tags].merge(output)
-
-        expect_any_instance_of(InfluxDB::Client).to receive(:write_point).with(config.measurement_name, include(tags: tags))
-
-        subject.call("unused", start, finish, "unused", payload)
-      end
-    end
-  end
-end

data/spec/support/rails4/app.rb

@@ -1,48 +0,0 @@
-require "action_controller/railtie"
-require "active_record"
-
-app = Class.new(Rails::Application)
-app.config.secret_key_base = "1234567890abcdef1234567890abcdef"
-app.config.secret_token = "1234567890abcdef1234567890abcdef"
-app.config.session_store :cookie_store, key: "_myapp_session"
-app.config.active_support.deprecation = :log
-app.config.eager_load = false
-app.config.root = __dir__
-Rails.backtrace_cleaner.remove_silencers!
-app.initialize!
-
-app.routes.draw do
-  resources :widgets
-end
-
-InfluxDB::Rails.configure do |config|
-end
-
-ActiveRecord::Base.establish_connection(adapter: "sqlite3", database: ":memory:")
-ActiveRecord::Schema.define do
-  create_table :widgets, force: true do |t|
-    t.string :title
-
-    t.timestamps
-  end
-end
-
-class Widget < ActiveRecord::Base; end
-class ApplicationController < ActionController::Base; end
-class WidgetsController < ApplicationController
-  prepend_view_path File.join(__dir__, "..", "views")
-
-  before_action do
-    InfluxDB::Rails.current.values = { key: :value }
-  end
-
-  def index
-    Widget.create!(title: "test")
-  end
-
-  def new
-    1 / 0
-  end
-end
-
-Object.const_set(:ApplicationHelper, Module.new)

data/spec/unit/context_spec.rb

@@ -1,40 +0,0 @@
-require "spec_helper"
-
-RSpec.describe InfluxDB::Rails::Context do
-  subject { described_class.new }
-
-  describe "#controller" do
-    it "does set and get" do
-      subject.controller = "Controller"
-      expect(subject.controller).to eq("Controller")
-    end
-  end
-
-  describe "#action" do
-    it "does get and set" do
-      subject.action = "action"
-      expect(subject.action).to eq("action")
-    end
-  end
-
-  describe "#location" do
-    before do
-      subject.controller = "Controller"
-      subject.action = "action"
-    end
-
-    it { expect(subject.location).to eq("Controller#action") }
-  end
-
-  describe "#reset" do
-    before do
-      subject.controller = "Controller"
-      subject.action = "action"
-    end
-
-    it "does reset the location" do
-      subject.reset
-      expect(subject.location).to be_empty
-    end
-  end
-end

data/spec/unit/middleware/render_subscriber_spec.rb

@@ -1,96 +0,0 @@
-require "spec_helper"
-require "shared_examples/data"
-
-RSpec.describe InfluxDB::Rails::Middleware::RenderSubscriber do
-  let(:config) { InfluxDB::Rails::Configuration.new }
-  let(:logger) { double(:logger) }
-
-  before do
-    allow(config).to receive(:application_name).and_return("my-rails-app")
-    allow(config).to receive(:ignored_environments).and_return([])
-    allow(config.client).to receive(:time_precision).and_return("ms")
-  end
-
-  describe ".call" do
-    let(:start)   { Time.at(1_517_567_368) }
-    let(:finish)  { Time.at(1_517_567_370) }
-    let(:hook_name) { "render_partial.action_view" }
-    let(:payload) { { identifier: "index.html", count: 43, cache_hits: 42 } }
-    let(:data) do
-      {
-        values:    {
-          value:      2000,
-          count:      43,
-          cache_hits: 42
-        },
-        tags:      {
-          filename: "index.html",
-          location: "Foo#bar",
-          hook:     "render_partial",
-        },
-        timestamp: 1_517_567_370_000
-      }
-    end
-
-    subject { described_class.new(config, hook_name) }
-
-    before do
-      InfluxDB::Rails.current.controller = "Foo"
-      InfluxDB::Rails.current.action = "bar"
-    end
-
-    after do
-      InfluxDB::Rails.current.reset
-    end
-
-    context "successfully" do
-      it "writes to InfluxDB" do
-        expect_any_instance_of(InfluxDB::Client).to receive(:write_point).with(
-          config.measurement_name, data
-        )
-        subject.call("name", start, finish, "id", payload)
-      end
-
-      it_behaves_like "with additional data"
-
-      context "with an empty value" do
-        before do
-          payload[:count] = nil
-          data[:values].delete(:count)
-        end
-
-        it "does not write empty value" do
-          expect_any_instance_of(InfluxDB::Client).to receive(:write_point).with(
-            config.measurement_name, data
-          )
-          subject.call("name", start, finish, "id", payload)
-        end
-      end
-
-      context "disabled" do
-        before do
-          allow(config).to receive(:ignored_hooks).and_return(["render_partial.action_view"])
-        end
-
-        subject { described_class.new(config, nil) }
-
-        it "does not write a data point" do
-          expect_any_instance_of(InfluxDB::Client).not_to receive(:write_point)
-          subject.call("name", start, finish, "id", payload)
-        end
-      end
-    end
-
-    context "unsuccessfully" do
-      before do
-        InfluxDB::Rails.configuration = config
-      end
-
-      it "does log exceptions" do
-        allow_any_instance_of(InfluxDB::Client).to receive(:write_point).and_raise("boom")
-        expect(::Rails.logger).to receive(:error).with(/boom/)
-        subject.call("name", start, finish, "id", payload)
-      end
-    end
-  end
-end

data/spec/unit/middleware/request_subscriber_spec.rb

@@ -1,103 +0,0 @@
-require "spec_helper"
-require "shared_examples/data"
-
-RSpec.describe InfluxDB::Rails::Middleware::RequestSubscriber do
-  let(:config) { InfluxDB::Rails::Configuration.new }
-
-  before do
-    allow(config.client).to receive(:time_precision).and_return("ms")
-    allow(config).to receive(:environment).and_return("production")
-  end
-
-  subject { described_class.new(config, "process_action.action_controller") }
-
-  describe "#call" do
-    let(:start)   { Time.at(1_517_567_368) }
-    let(:finish)  { Time.at(1_517_567_370) }
-    let(:payload) { { view_runtime: 2, db_runtime: 2, controller: "MyController", action: "show", method: "GET", format: "*/*", status: 200 } }
-    let(:data)    do
-      {
-        values:    {
-          controller: 2,
-          started:    InfluxDB.convert_timestamp(start.utc, config.client.time_precision),
-        },
-        tags:      {
-          method:      "MyController#show",
-          hook:        "process_action",
-          status:      200,
-          format:      "*/*",
-          http_method: "GET",
-          server:      Socket.gethostname,
-          app_name:    "my-rails-app",
-        },
-        timestamp: 1_517_567_370_000
-      }
-    end
-
-    context "application_name is set" do
-      before do
-        allow(config).to receive(:application_name).and_return("my-rails-app")
-      end
-
-      it "sends metrics with taggings and timestamps" do
-        expect_any_instance_of(InfluxDB::Client).to receive(:write_point).with(
-          config.measurement_name, data.deep_merge(values: { controller: 2000, db: 2, view: 2 })
-        )
-
-        subject.call("unused", start, finish, "unused", payload)
-      end
-
-      it_behaves_like "with additional data", ["requests"]
-    end
-
-    context "application_name is nil" do
-      let(:tags) do
-        {
-          method:      "MyController#show",
-          hook:        "process_action",
-          status:      200,
-          format:      "*/*",
-          http_method: "GET",
-          server:      Socket.gethostname,
-        }
-      end
-
-      before do
-        allow(config).to receive(:application_name).and_return(nil)
-      end
-
-      it "does not add the app_name tag to metrics" do
-        expect_any_instance_of(InfluxDB::Client).to receive(:write_point).with(
-          config.measurement_name, data.merge(tags: tags).deep_merge(values: { controller: 2000, db: 2, view: 2 })
-        )
-
-        subject.call("unused", start, finish, "unused", payload)
-      end
-    end
-
-    context "not successfull" do
-      before do
-        InfluxDB::Rails.configuration = config
-      end
-
-      it "does log an error" do
-        allow_any_instance_of(InfluxDB::Client).to receive(:write_point).and_raise("boom")
-        expect(::Rails.logger).to receive(:error).with(/boom/)
-        subject.call("name", start, finish, "id", payload)
-      end
-    end
-
-    context "disabled" do
-      before do
-        allow(config).to receive(:ignored_hooks).and_return(["process_action.action_controller"])
-      end
-
-      subject { described_class.new(config, "process_action.action_controller") }
-
-      it "does not write a data point" do
-        expect_any_instance_of(InfluxDB::Client).not_to receive(:write_point)
-        subject.call("name", start, finish, "id", payload)
-      end
-    end
-  end
-end