index_shotgun 0.2.0 → 1.0.1

data/gemfiles/common.gemfile

@@ -0,0 +1,15 @@
+if Gem::Version.create(RUBY_VERSION) < Gem::Version.create("2.4.0")
+  # byebug v11.1.0+ requires Ruby 2.4.0+
+  gem "byebug", "< 11.1.0"
+
+  # simplecov-html v0.12.3+ requires Ruby 2.4.0+
+  gem "simplecov-html", "< 0.12.3"
+
+  # parallel v1.20.0 requires Ruby 2.5.0+ and parallel v1.20.1+ requires Ruby 2.4.0+
+  gem "parallel", "< 1.20.0"
+end
+
+if Gem::Version.create(RUBY_VERSION) < Gem::Version.create("2.4.4")
+  # zeitwerk requires Ruby 2.4.4+
+  gem "activesupport", "< 6.0.0"
+end

data/index_shotgun.gemspec

@@ -1,5 +1,4 @@
-# coding: utf-8
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "index_shotgun/version"
 
@@ -14,32 +13,30 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/sue445/index_shotgun"
   spec.license       = "MIT"
 
-  # Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or
-  # delete this section to allow pushing this gem to any host.
-  if spec.respond_to?(:metadata)
-    spec.metadata["allowed_push_host"] = "https://rubygems.org"
-  else
-    raise "RubyGems 2.0 or newer is required to protect against public gem pushes."
-  end
+  spec.metadata["homepage_uri"] = spec.homepage
+  spec.metadata["source_code_uri"] = spec.homepage
+  spec.metadata["changelog_uri"] = "#{spec.homepage}/blob/master/CHANGELOG.md"
+  spec.metadata["rubygems_mfa_required"] = "true"
 
-  spec.required_ruby_version = ">= 2.1.0"
+  spec.required_ruby_version = ">= 2.4.0"
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.files         = `git ls-files -z`.split("\x0").reject {|f| f.match(%r{^(test|spec|features)/}) }
   spec.bindir        = "exe"
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.executables   = spec.files.grep(%r{^exe/}) {|f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activerecord"
+  spec.add_dependency "activerecord", ">= 5.0.0"
   spec.add_dependency "thor"
 
-  spec.add_development_dependency "bundler", "~> 1.10"
-  spec.add_development_dependency "codeclimate-test-reporter"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "coveralls"
-  spec.add_development_dependency "pry-byebug"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rake_shared_context"
+  spec.add_development_dependency "onkcop", "0.53.0.2"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rake_shared_context", "0.2.2"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "rspec-its"
   spec.add_development_dependency "rspec-power_assert"
-  spec.add_development_dependency "rubocop", "0.31.0"
+  spec.add_development_dependency "rubocop", "0.62.0"
+  spec.add_development_dependency "rubocop_auto_corrector"
+  spec.add_development_dependency "simplecov", "< 0.18.0"
 end

data/lib/index_shotgun/analyzer.rb

@@ -1,14 +1,30 @@
 module IndexShotgun
-  module Analyzer
+  module Analyzer # rubocop:disable Metrics/ModuleLength
     require "index_shotgun/array_start_with"
 
+    class Response
+      attr_accessor :message, :duplicate_index_count, :total_index_count, :total_table_count
+
+      def successful?
+        duplicate_index_count == 0
+      end
+
+      def exit_if_failure!
+        exit(1) unless successful?
+      end
+    end
+
     class << self
       using IndexShotgun::ArrayStartWith
 
       # Search duplicate index
-      # @return [String] result message
+      # @return [IndexShotgun::Analyzer::Response]
       def perform
-        tables = ActiveRecord::Base.connection.tables
+        tables =
+          ActiveSupport::Deprecation.silence do
+            ActiveRecord::Base.connection.tables
+          end
+        tables.reject! {|table| exclude_tables.include?(table.downcase) }
 
         duplicate_indexes =
           tables.each_with_object([]) do |table, array|
@@ -17,8 +33,8 @@ module IndexShotgun
           end
 
         message =
-          duplicate_indexes.each_with_object("") do |info, message|
-            message << <<-EOS.strip_heredoc
+          duplicate_indexes.each_with_object("") do |info, str|
+            str << <<~MSG
               # =============================
               # #{info[:index].table}
               # =============================
@@ -27,11 +43,11 @@ module IndexShotgun
               # To remove this duplicate index, execute:
               ALTER TABLE `#{info[:index].table}` DROP INDEX `#{info[:index].name}`;
 
-            EOS
+            MSG
           end
 
-        total_index_count = tables.map { |table| table_indexes(table).count }.sum
-        message << <<-EOS.strip_heredoc
+        total_index_count = tables.map {|table| table_indexes(table).count }.sum
+        message << <<~MSG
           # ########################################################################
           # Summary of indexes
           # ########################################################################
@@ -40,9 +56,15 @@ module IndexShotgun
           # Total Indexes            #{total_index_count}
           # Total Tables             #{tables.count}
 
-        EOS
+        MSG
 
-        message
+        response = Response.new
+        response.duplicate_index_count = duplicate_indexes.count
+        response.message               = message
+        response.total_index_count     = total_index_count
+        response.total_table_count     = tables.count
+
+        response
       end
 
       # check duplicate indexes of table
@@ -76,6 +98,196 @@ module IndexShotgun
       def table_indexes(table)
         ActiveRecord::Base.connection.indexes(table)
       end
+
+      ORACLE_SYSTEM_TABLES = %w[
+        AQ$DEF$_AQCALL
+        AQ$DEF$_AQERROR
+        AQ$_DEF$_AQCALL_F
+        AQ$_DEF$_AQERROR_F
+        AQ$_INTERNET_AGENTS
+        AQ$_INTERNET_AGENT_PRIVS
+        AQ$_QUEUES
+        AQ$_QUEUE_TABLES
+        AQ$_SCHEDULES
+        CATALOG
+        COL
+        DEF$_AQCALL
+        DEF$_AQERROR
+        DEF$_CALLDEST
+        DEF$_DEFAULTDEST
+        DEF$_DESTINATION
+        DEF$_ERROR
+        DEF$_LOB
+        DEF$_ORIGIN
+        DEF$_PROPAGATOR
+        DEF$_PUSHED_TRANSACTIONS
+        HELP
+        LOGMNRC_DBNAME_UID_MAP
+        LOGMNRC_GSBA
+        LOGMNRC_GSII
+        LOGMNRC_GTCS
+        LOGMNRC_GTLO
+        LOGMNRP_CTAS_PART_MAP
+        LOGMNRT_MDDL$
+        LOGMNR_AGE_SPILL$
+        LOGMNR_ATTRCOL$
+        LOGMNR_ATTRIBUTE$
+        LOGMNR_CCOL$
+        LOGMNR_CDEF$
+        LOGMNR_COL$
+        LOGMNR_COLTYPE$
+        LOGMNR_DICTIONARY$
+        LOGMNR_DICTSTATE$
+        LOGMNR_ENC$
+        LOGMNR_ERROR$
+        LOGMNR_FILTER$
+        LOGMNR_GLOBAL$
+        LOGMNR_GT_TAB_INCLUDE$
+        LOGMNR_GT_USER_INCLUDE$
+        LOGMNR_GT_XID_INCLUDE$
+        LOGMNR_ICOL$
+        LOGMNR_IND$
+        LOGMNR_INDCOMPART$
+        LOGMNR_INDPART$
+        LOGMNR_INDSUBPART$
+        LOGMNR_INTEGRATED_SPILL$
+        LOGMNR_KOPM$
+        LOGMNR_LOB$
+        LOGMNR_LOBFRAG$
+        LOGMNR_LOG$
+        LOGMNR_LOGMNR_BUILDLOG
+        LOGMNR_NTAB$
+        LOGMNR_OBJ$
+        LOGMNR_OPQTYPE$
+        LOGMNR_PARAMETER$
+        LOGMNR_PARTOBJ$
+        LOGMNR_PROCESSED_LOG$
+        LOGMNR_PROPS$
+        LOGMNR_REFCON$
+        LOGMNR_RESTART_CKPT$
+        LOGMNR_RESTART_CKPT_TXINFO$
+        LOGMNR_SEED$
+        LOGMNR_SESSION$
+        LOGMNR_SESSION_ACTIONS$
+        LOGMNR_SESSION_EVOLVE$
+        LOGMNR_SPILL$
+        LOGMNR_SUBCOLTYPE$
+        LOGMNR_TAB$
+        LOGMNR_TABCOMPART$
+        LOGMNR_TABPART$
+        LOGMNR_TABSUBPART$
+        LOGMNR_TS$
+        LOGMNR_TYPE$
+        LOGMNR_UID$
+        LOGMNR_USER$
+        LOGSTDBY$APPLY_MILESTONE
+        LOGSTDBY$APPLY_PROGRESS
+        LOGSTDBY$EDS_TABLES
+        LOGSTDBY$EVENTS
+        LOGSTDBY$FLASHBACK_SCN
+        LOGSTDBY$HISTORY
+        LOGSTDBY$PARAMETERS
+        LOGSTDBY$PLSQL
+        LOGSTDBY$SCN
+        LOGSTDBY$SKIP
+        LOGSTDBY$SKIP_SUPPORT
+        LOGSTDBY$SKIP_TRANSACTION
+        MVIEW$_ADV_AJG
+        MVIEW$_ADV_BASETABLE
+        MVIEW$_ADV_CLIQUE
+        MVIEW$_ADV_ELIGIBLE
+        MVIEW$_ADV_EXCEPTIONS
+        MVIEW$_ADV_FILTER
+        MVIEW$_ADV_FILTERINSTANCE
+        MVIEW$_ADV_FJG
+        MVIEW$_ADV_GC
+        MVIEW$_ADV_INFO
+        MVIEW$_ADV_JOURNAL
+        MVIEW$_ADV_LEVEL
+        MVIEW$_ADV_LOG
+        MVIEW$_ADV_OUTPUT
+        MVIEW$_ADV_PARAMETERS
+        MVIEW$_ADV_PLAN
+        MVIEW$_ADV_PRETTY
+        MVIEW$_ADV_ROLLUP
+        MVIEW$_ADV_SQLDEPEND
+        MVIEW$_ADV_TEMP
+        MVIEW$_ADV_WORKLOAD
+        MVIEW_EVALUATIONS
+        MVIEW_EXCEPTIONS
+        MVIEW_FILTER
+        MVIEW_FILTERINSTANCE
+        MVIEW_LOG
+        MVIEW_RECOMMENDATIONS
+        MVIEW_WORKLOAD
+        OL$
+        OL$HINTS
+        OL$NODES
+        PRODUCT_PRIVS
+        PRODUCT_USER_PROFILE
+        PUBLICSYN
+        REPCAT$_AUDIT_ATTRIBUTE
+        REPCAT$_AUDIT_COLUMN
+        REPCAT$_COLUMN_GROUP
+        REPCAT$_CONFLICT
+        REPCAT$_DDL
+        REPCAT$_EXCEPTIONS
+        REPCAT$_EXTENSION
+        REPCAT$_FLAVORS
+        REPCAT$_FLAVOR_OBJECTS
+        REPCAT$_GENERATED
+        REPCAT$_GROUPED_COLUMN
+        REPCAT$_INSTANTIATION_DDL
+        REPCAT$_KEY_COLUMNS
+        REPCAT$_OBJECT_PARMS
+        REPCAT$_OBJECT_TYPES
+        REPCAT$_PARAMETER_COLUMN
+        REPCAT$_PRIORITY
+        REPCAT$_PRIORITY_GROUP
+        REPCAT$_REFRESH_TEMPLATES
+        REPCAT$_REPCAT
+        REPCAT$_REPCATLOG
+        REPCAT$_REPCOLUMN
+        REPCAT$_REPGROUP_PRIVS
+        REPCAT$_REPOBJECT
+        REPCAT$_REPPROP
+        REPCAT$_REPSCHEMA
+        REPCAT$_RESOLUTION
+        REPCAT$_RESOLUTION_METHOD
+        REPCAT$_RESOLUTION_STATISTICS
+        REPCAT$_RESOL_STATS_CONTROL
+        REPCAT$_RUNTIME_PARMS
+        REPCAT$_SITES_NEW
+        REPCAT$_SITE_OBJECTS
+        REPCAT$_SNAPGROUP
+        REPCAT$_TEMPLATE_OBJECTS
+        REPCAT$_TEMPLATE_PARMS
+        REPCAT$_TEMPLATE_REFGROUPS
+        REPCAT$_TEMPLATE_SITES
+        REPCAT$_TEMPLATE_STATUS
+        REPCAT$_TEMPLATE_TARGETS
+        REPCAT$_TEMPLATE_TYPES
+        REPCAT$_USER_AUTHORIZATIONS
+        REPCAT$_USER_PARM_VALUES
+        SQLPLUS_PRODUCT_PROFILE
+        SYSCATALOG
+        SYSFILES
+        TAB
+        TABQUOTAS
+      ].freeze
+
+      def exclude_tables
+        return @exclude_tables if @exclude_tables
+
+        # Rails default tables
+        tables = %w[ar_internal_metadata schema_migrations]
+
+        # Oracle system tables
+        tables += ORACLE_SYSTEM_TABLES
+
+        @exclude_tables = tables.map(&:downcase)
+        @exclude_tables
+      end
     end
   end
 end

data/lib/index_shotgun/cli.rb

@@ -56,22 +56,24 @@ module IndexShotgun
 
     private
 
-    def analyze(adapter_name, gem_name = nil)
-      gem_name ||= adapter_name
-      begin
-        require gem_name
-      rescue LoadError
-        puts "[ERROR] #{adapter_name} is not installed. Please run `gem install #{gem_name}` and install gem"
-        exit!
-      end
+      def analyze(adapter_name, gem_name = nil)
+        gem_name ||= adapter_name
+        begin
+          require gem_name
+        rescue LoadError
+          puts "[ERROR] #{adapter_name} is not installed. Please run `gem install #{gem_name}` and install gem"
+          exit!
+        end
 
-      config = options.reverse_merge(adapter: adapter_name)
+        config = options.reverse_merge(adapter: adapter_name)
 
-      ask_password = config.delete("ask_password")
-      config[:password] = ask("Input password (hidden):", echo: false) if ask_password
+        ask_password = config.delete("ask_password")
+        config[:password] = ask("Input password (hidden):", echo: false) if ask_password
 
-      ActiveRecord::Base.establish_connection(config)
-      puts IndexShotgun::Analyzer.perform
-    end
+        ActiveRecord::Base.establish_connection(config)
+        response = IndexShotgun::Analyzer.perform
+        puts response.message
+        response.exit_if_failure!
+      end
   end
 end

data/lib/index_shotgun/tasks/index_shotgun.rake

@@ -1,6 +1,8 @@
 namespace :index_shotgun do
   desc "Search duplicate indexes"
   task :fire => :environment do
-    puts IndexShotgun::Analyzer.perform
+    response = IndexShotgun::Analyzer.perform
+    puts response.message
+    response.exit_if_failure!
   end
 end

data/lib/index_shotgun/version.rb

@@ -1,3 +1,3 @@
 module IndexShotgun
-  VERSION = "0.2.0"
+  VERSION = "1.0.1".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: index_shotgun
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 1.0.1
 platform: ruby
 authors:
 - sue445
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2015-11-09 00:00:00.000000000 Z
+date: 2021-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
@@ -42,18 +42,18 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,21 +67,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: onkcop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.53.0.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.53.0.2
 - !ruby/object:Gem::Dependency
-  name: pry-byebug
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,21 +95,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rake_shared_context
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 0.2.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 0.2.2
 - !ruby/object:Gem::Dependency
-  name: rake_shared_context
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -123,7 +123,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -137,7 +137,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-its
+  name: rspec-power_assert
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -151,7 +151,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-power_assert
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.62.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.62.0
+- !ruby/object:Gem::Dependency
+  name: rubocop_auto_corrector
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -165,19 +179,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.31.0
+        version: 0.18.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.31.0
+        version: 0.18.0
 description: duplicate index checker
 email:
 - sue445@sue445.net
@@ -187,12 +201,11 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".coveralls.yml"
+- ".github/workflows/test.yml"
+- ".github_changelog_generator"
 - ".gitignore"
-- ".hound.yml"
 - ".rspec"
 - ".rubocop.yml"
-- ".rubocop_standard.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -200,7 +213,20 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
+- ci/build.sh
+- ci/database.yml.mysql
+- ci/database.yml.oracle
+- ci/database.yml.postgresql
+- ci/database.yml.sqlite3
+- ci/install.sh
 - exe/index_shotgun
+- gemfiles/activerecord_5_0.gemfile
+- gemfiles/activerecord_5_1.gemfile
+- gemfiles/activerecord_5_2.gemfile
+- gemfiles/activerecord_6_0.gemfile
+- gemfiles/activerecord_6_1.gemfile
+- gemfiles/activerecord_7_0.gemfile
+- gemfiles/common.gemfile
 - index_shotgun.gemspec
 - lib/index_shotgun.rb
 - lib/index_shotgun/analyzer.rb
@@ -210,16 +236,15 @@ files:
 - lib/index_shotgun/tasks.rb
 - lib/index_shotgun/tasks/index_shotgun.rake
 - lib/index_shotgun/version.rb
-- travis_ci/build.sh
-- travis_ci/database.yml.mysql
-- travis_ci/database.yml.postgresql
-- travis_ci/database.yml.sqlite3
 homepage: https://github.com/sue445/index_shotgun
 licenses:
 - MIT
 metadata:
-  allowed_push_host: https://rubygems.org
-post_install_message: 
+  homepage_uri: https://github.com/sue445/index_shotgun
+  source_code_uri: https://github.com/sue445/index_shotgun
+  changelog_uri: https://github.com/sue445/index_shotgun/blob/master/CHANGELOG.md
+  rubygems_mfa_required: 'true'
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -227,16 +252,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5.1
-signing_key: 
+rubygems_version: 3.2.22
+signing_key:
 specification_version: 4
 summary: duplicate index checker
 test_files: []

data/.hound.yml

@@ -1,2 +0,0 @@
-ruby:
-  config_file: .rubocop.yml