increase 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9520a7eb024d05477e162e1158a07f54167a6a89297f44d3a71caa01a40599cf
-  data.tar.gz: 273bb964f85fb97660212f6a2046a58caf4e7302d07859fe3d562afe8269922d
+  metadata.gz: 316c9f7266fa873bde94e93509769dc4883691aa435da355d636a94f9c48b762
+  data.tar.gz: c38729a1d10974a7e46911e834c539b9931f18380d9e20aedcc71bc810fdb22d
 SHA512:
-  metadata.gz: d4b399cda4f620ca00549831546a4992069eb17cb84f08ce9aa0039744e7d3ea4868dd3498ee593c001678633bf708a6e8257ee093f75922996c0f1012f9aa6d
-  data.tar.gz: bfd03c310aaf256d89228e6bcd0da10e3505004ab958c10c30baa51dd6df1c22d09ca974bcd61def524888dc9203a00fef78a51082991d2dd3aa8701f6060294
+  metadata.gz: d7b31744c795da1c21e7f7dc85721bfeacdf115de67dee45a2751adc1a4e1d97d8a8fe69bac13d658921aeaf42873bbbe400d835e9f1a1a6e77941a19f5154bb
+  data.tar.gz: 1f89985c494abd6b3e50df9d24a21cc1d0078b576b20010a04a11ab666ad3c8f55e910fc7959d0ae10ed72dd40bd8eae6fdc7f91dbfe71e5f91c14cd7d756da9

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.3.2] - 2023-03-24
+
+### Fixes
+
+- Updated `Increase::Webhook::Signature#verify` to
+  raise `WebhookSignatureVerificationError` when arguments are `nil`
+
 ## [0.3.1] - 2023-03-23
 
 ### Enhancements

data/README.md

@@ -19,14 +19,14 @@ Bare-Metal Banking APIs!
 Install the gem and add to the application's Gemfile by executing:
 
 ```sh
-$ bundle add increase -v 0.3.1
+$ bundle add increase -v 0.3.2
 ```
 
 If bundler is not being used to manage dependencies, install the gem by
 executing:
 
 ```sh
-$ gem install increase -v 0.3.1
+$ gem install increase -v 0.3.2
 ```
 
 ## Usage
@@ -326,14 +326,15 @@ to run the console with your Increase sandbox API key pre-filled.
 
 To install this gem onto your local machine, run `bundle exec rake install`.
 
-To release a new version, update the version number in `version.rb`, and then
-run `bundle exec rake release`, which will create a git tag for the version,
-push git commits and the created tag, and push the `.gem` file
-to [rubygems.org](https://rubygems.org).
+To release a new version:
 
-Alternatively, use [`gem-release`](https://github.com/svenfuchs/gem-release) and
-run `gem bump --version patch|minor|major`. Then release the gem by
-running `bundle exec rake release`.
+- `gem bump --version patch|minor|major`
+    - Make sure you
+      have [`gem-release`](https://github.com/svenfuchs/gem-release)
+      installed
+- Update the CHANGELOG and README if necessary
+- `bundle exec rake release`
+- Create release on GitHub from newly created tag
 
 ## Contributing
 

data/lib/increase/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Increase
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

data/lib/increase/webhook/signature.rb

@@ -23,7 +23,7 @@ module Increase
         end
 
         # Parse header
-        sig_values = signature_header.split(",").map { |pair| pair.split("=") }.to_h
+        sig_values = signature_header&.split(",")&.map { |pair| pair.split("=") }&.to_h || {}
 
         # Extract values
         t = sig_values["t"] # Should be a string (ISO-8601 timestamp)
@@ -32,6 +32,8 @@ module Increase
         raise sig_error.call("No signature found with scheme #{scheme} in signature header") if sig.nil?
 
         # Check signature
+        raise sig_error.call("Webhook secret is required") if secret.nil?
+        raise sig_error.call("Payload is required") if payload.nil?
         expected_sig = compute_signature(timestamp: t, payload: payload, secret: secret)
         matches = Util.secure_compare(expected_sig, sig)
         raise sig_error.call("Signature mismatch") unless matches
@@ -56,6 +58,10 @@ module Increase
       end
 
       def self.compute_signature(timestamp:, payload:, secret:)
+        raise ArgumentError, "timestamp is required" if timestamp.nil?
+        raise ArgumentError, "payload is required" if payload.nil?
+        raise ArgumentError, "secret is required" if secret.nil?
+
         signed_payload = timestamp.to_s + "." + payload.to_s
         OpenSSL::HMAC.hexdigest("SHA256", secret, signed_payload)
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: increase
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Gary Tou