increase 0.3.0 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a945cde9440a62a76cd7a95c5bc91b7dfea452fada50349e3d749c6fc95fa72e
-  data.tar.gz: b6ce6f53d72e35e027287feff54fc47c7e855fa364fc11040646efd92c8ce028
+  metadata.gz: 316c9f7266fa873bde94e93509769dc4883691aa435da355d636a94f9c48b762
+  data.tar.gz: c38729a1d10974a7e46911e834c539b9931f18380d9e20aedcc71bc810fdb22d
 SHA512:
-  metadata.gz: 30fb2ded08ba6aa27adfa4f85932e941d4e727ae069ab8df915c2dd001cdd35779b8b58090e29695100270ec66da45cd6d495efdd0b7acc4bf747473b3a5970a
-  data.tar.gz: 5a591e007db71c14a1a4e827650bea8a6eda56d68e248eb2988e02380c6de4ccdc5054963c09bda8f2797c36a7dc148fb5a14de58105ff535cbc56bd137f7698
+  metadata.gz: d7b31744c795da1c21e7f7dc85721bfeacdf115de67dee45a2751adc1a4e1d97d8a8fe69bac13d658921aeaf42873bbbe400d835e9f1a1a6e77941a19f5154bb
+  data.tar.gz: 1f89985c494abd6b3e50df9d24a21cc1d0078b576b20010a04a11ab666ad3c8f55e910fc7959d0ae10ed72dd40bd8eae6fdc7f91dbfe71e5f91c14cd7d756da9

data/CHANGELOG.md

@@ -0,0 +1,97 @@
+# Changelog
+
+## [0.3.2] - 2023-03-24
+
+### Fixes
+
+- Updated `Increase::Webhook::Signature#verify` to
+  raise `WebhookSignatureVerificationError` when arguments are `nil`
+
+## [0.3.1] - 2023-03-23
+
+### Enhancements
+
+- Support Faraday >= 1.0.1 (https://github.com/garyhtou/increase-ruby/pull/8)
+
+
+## [0.3.0] - 2023-03-23
+
+### Enhancements
+
+- Better developer experience for file uploads (9fc40df62a537ed3402a0c0deb5bee908d84b671)
+
+### Documentation
+
+- Pin gem version in install command (2127f5a04be8832ba5c5c42476e2844fb6ca9c24)
+- Update README to reflect new file upload DX (9fc40df62a537ed3402a0c0deb5bee908d84b671)
+
+
+## [0.2.0] - 2023-03-21
+
+### Enhancements
+
+- Made webhook verification `verify` raise an error, but `verify?` return a bool (58d462fc648cafdcfdb7b8d2c0e0ec1f45362984)
+- Wrote a generator to generate API resource classes from the OpenAPI spec (8eedc2d4a5daecd97c156546c649f27376eb9762)
+- Added all API resources (2a04096dea06a34ba8ff1d5061475ed1a2354ac2)
+- Supported getting response from `list` operation (a2141f034a4f29cfee0222a4fac32949581adbc6)
+
+### Fixes
+
+- Use `ArgumentError` when unknown config passed to `Configuration` (cdd0703febd6f9dec0ecd4ac34fe465697edbf08)
+- File uploads! Increase::Files.create now works (236cad5011b996b40793abe85698ba47fa1ba3f8)
+
+### Documentation
+
+- Updated error handling example to be more clear (85d8d6ff102a8ef502040322537b79085f89779d)
+- Fixed idempotency example (343ae6d4cb1b8216192e2f820836ca87cc3a9a36)
+- Added example for passing hash to `with_config` (b82fac134c813d03a31466e83341acc891c1deb6)
+- Updated Rails config example to use Rails credentials (2b4fec9c1d52d04e42760a9889ba1cb313b5bd18)
+- Added list filtering example (6333f982062b2527f676a6aade4e5abf01a7816b)
+- Added table of contents (88e9b6ae05aaa62974514a6c318f35e708e49fb5)
+- Added full example for Idempotency keys (6d5ce8bdd3d4baf13c4d0800a159c784bc1bdc78)
+- Added manual pagination example using `next_cursor` (57157e2965904c9150676696e8567b5518892945)
+
+
+## [0.1.3] - 2023-03-20
+
+### Enhancements
+
+- Added `Limits` resource (98654433812b202ecfd31ba35d520981529f2e2b)
+- Added `CheckTransfers` resource (a899c9ca6206af78df23ba8b62c8dfc88b7fc22d)
+- Added `RoutingNumbers` resource (209e7f279a1ff648142ac6aca6cfe946fc653845)
+
+### Documentation
+
+- Added section about webhook signature verification (650aed416ab820ed55f0ed8936f201274964fc37)
+- Added section about Rails configuration (650aed416ab820ed55f0ed8936f201274964fc37)
+
+## [0.1.2] - 2023-03-20
+
+### Enhancements
+
+- Added webhook verification support (ce193fb8888d497817ab5551bf8e9096c5bf7e26)
+- Added user agent to requests (ce44249ead32ba4055b13ba576f0b91f20493cfc)
+- Update supported Ruby version to >= 2.7.4 (c404f8ddc4762615bac660edabf0385716b4bd74)
+
+### Fixes
+
+- Always apply default configuration options (079f0ca603a80dd2c9523df23244b64e2e0a5772)
+
+### Documentation
+
+- Wrote the README! (aa7c778834cd268ab1318e44fceea0b062a5c5df)
+
+
+## [0.1.1] - 2023-03-19
+
+### Enhancements
+- Added client-wide configuration options (c47e32c93371b43f2e0a3ac49525e46fbe9ef326)
+- Load `INCREASE_API_KEY` and `INCREASE_BASE_URL` from environment variables (2e6cbe21a2b37c230dc3f2382613b98ffc3ea4d8, 24cea582c03b64018ed2f0997f99f4bae581a1fa, 4a80e4263c7917bbfa1371c70752476d7f7f0695)
+- Added the following API resources:
+  - `AccountNumbers` (209b155c0fa3977c2c19602a2239c8b27001935e)
+  - `AccountTransfers` (6065a932522bd582aa4f177037a5eca8e5d1647d)
+  - `AchTransfers` (caef61c36bfffc780016880959f067b59bfa288e)
+  - `Cards` (b58bccc8aab00fd2ee69f2973898e6a13c1b2544)
+  - `Events` (dd3312638227be47f04c8bd740c3dd25104959e7)
+  - `PendingTransactions` (b6f4b2c02a9108603b4d1feee9a39c1a7f1086ef)
+  - `Transaction` (b6f4b2c02a9108603b4d1feee9a39c1a7f1086ef)

data/README.md

@@ -19,14 +19,14 @@ Bare-Metal Banking APIs!
 Install the gem and add to the application's Gemfile by executing:
 
 ```sh
-$ bundle add increase -v 0.3.0
+$ bundle add increase -v 0.3.2
 ```
 
 If bundler is not being used to manage dependencies, install the gem by
 executing:
 
 ```sh
-$ gem install increase -v 0.3.0
+$ gem install increase -v 0.3.2
 ```
 
 ## Usage
@@ -326,14 +326,15 @@ to run the console with your Increase sandbox API key pre-filled.
 
 To install this gem onto your local machine, run `bundle exec rake install`.
 
-To release a new version, update the version number in `version.rb`, and then
-run `bundle exec rake release`, which will create a git tag for the version,
-push git commits and the created tag, and push the `.gem` file
-to [rubygems.org](https://rubygems.org).
+To release a new version:
 
-Alternatively, use [`gem-release`](https://github.com/svenfuchs/gem-release) and
-run `gem bump --version patch|minor|major`. Then release the gem by
-running `bundle exec rake release`.
+- `gem bump --version patch|minor|major`
+    - Make sure you
+      have [`gem-release`](https://github.com/svenfuchs/gem-release)
+      installed
+- Update the CHANGELOG and README if necessary
+- `bundle exec rake release`
+- Create release on GitHub from newly created tag
 
 ## Contributing
 

data/lib/increase/client.rb

@@ -1,13 +1,18 @@
 # frozen_string_literal: true
 
 require "increase/configuration"
+require "increase/middleware/raise_api_error"
 
 require "faraday"
-require "faraday/follow_redirects"
-require "faraday/multipart"
-
-# Custom Faraday Middleware to handle raising errors
-require "faraday/raise_increase_api_error"
+require "faraday/follow_redirects" # Supports both Faraday 1.0 and 2.0
+if Gem::Version.new(Faraday::VERSION) >= Gem::Version.new("2.0")
+  # In Faraday 2.0, multipart support is no longer included by default
+  require "faraday/multipart"
+else
+  # In Faraday 1.0, the JSON middleware is not included by default
+  require "increase/middleware/encode_json"
+  require "increase/middleware/parse_json"
+end
 
 module Increase
   class Client
@@ -38,7 +43,7 @@ module Increase
         if @configuration.raise_api_errors
           # This custom middleware for raising Increase API errors must be
           # located before the JSON response middleware.
-          f.use FaradayMiddleware::RaiseIncreaseApiError
+          f.use Increase::Middleware::RaiseApiError
         end
 
         f.response :json

data/lib/increase/file_upload.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-require 'tempfile'
-require 'marcel'
-require 'faraday'
-require 'pathname'
+require "tempfile"
+require "marcel"
+require "faraday"
+require "pathname"
 
 module Increase
   class FileUpload
@@ -33,11 +33,19 @@ module Increase
     end
 
     def file_part
-      Faraday::Multipart::FilePart.new(
-        @file,
-        @content_type,
-        @filename
-      )
+      if Gem::Version.new(Faraday::VERSION) >= Gem::Version.new("2.0")
+        Faraday::Multipart::FilePart.new(
+          @file,
+          @content_type,
+          @filename
+        )
+      else
+        Faraday::FilePart.new(
+          @file,
+          @content_type,
+          @filename
+        )
+      end
     end
 
     private
@@ -45,6 +53,5 @@ module Increase
     def default_filename
       "file upload #{Time.now}"
     end
-
   end
 end

data/lib/increase/middleware/encode_json.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+require "faraday"
+
+module Increase
+  module Middleware
+    # JSON request middleware for Faraday 1.0
+    # In Faraday 2.0, the JSON middleware is bundled with the Faraday gem itself
+    #
+    # This middleware is from
+    # https://github.com/lostisland/faraday_middleware/blob/main/lib/faraday_middleware/request/encode_json.rb
+    class EncodeJson < Faraday::Middleware
+      CONTENT_TYPE = "Content-Type"
+      MIME_TYPE = "application/json"
+      MIME_TYPE_REGEX = %r{^application/(vnd\..+\+)?json$}.freeze
+
+      dependency do
+        require "json" unless defined?(::JSON)
+      end
+
+      def call(env)
+        match_content_type(env) do |data|
+          env[:body] = encode data
+        end
+        @app.call env
+      end
+
+      def encode(data)
+        ::JSON.generate data
+      end
+
+      def match_content_type(env)
+        return unless process_request?(env)
+
+        env[:request_headers][CONTENT_TYPE] ||= MIME_TYPE
+        yield env[:body] unless env[:body].respond_to?(:to_str)
+      end
+
+      def process_request?(env)
+        type = request_type(env)
+        has_body?(env) && (type.empty? || MIME_TYPE_REGEX =~ type)
+      end
+
+      def has_body?(env)
+        (body = env[:body]) && !(body.respond_to?(:to_str) && body.empty?)
+      end
+
+      def request_type(env)
+        type = env[:request_headers][CONTENT_TYPE].to_s
+        type = type.split(";", 2).first if type.index(";")
+        type
+      end
+    end
+  end
+end
+
+Faraday::Request.register_middleware(json: Increase::Middleware::EncodeJson)

data/lib/increase/middleware/parse_json.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require "faraday"
+require "json"
+
+module Increase
+  module Middleware
+    # JSON response middleware for Faraday 1.0
+    # In Faraday 2.0, the JSON middleware is bundled with the Faraday gem itself
+    #
+    # This middleware is from
+    # https://github.com/jsmestad/jsonapi-consumer/blob/7d9721ea7feb888ea1e43edb9f1c0c38334762ed/lib/jsonapi/consumer/middleware/parse_json.rb
+    class ParseJson < Faraday::Middleware
+      def call(environment)
+        @app.call(environment).on_complete do |env|
+          if process_response_type?(response_type(env))
+            env[:raw_body] = env[:body]
+            env[:body] = parse(env[:body])
+          end
+        end
+      end
+
+      private
+
+      def parse(body)
+        ::JSON.parse(body) unless body.strip.empty?
+      end
+
+      def response_type(env)
+        type = env[:response_headers]["Content-Type"].to_s
+        type = type.split(";", 2).first if type.index(";")
+        type
+      end
+
+      def process_response_type?(type)
+        !!type.match(/\bjson$/)
+      end
+    end
+  end
+end
+
+Faraday::Response.register_middleware(json: Increase::Middleware::ParseJson)

data/lib/increase/middleware/raise_api_error.rb

@@ -0,0 +1,13 @@
+require "faraday"
+
+module Increase
+  module Middleware
+    class RaiseApiError < Faraday::Middleware
+      def on_complete(env)
+        return if env[:status] < 400
+
+        raise Increase::ApiError.from_response(env)
+      end
+    end
+  end
+end

data/lib/increase/resource.rb

@@ -29,7 +29,7 @@ module Increase
       with = [with].flatten.compact
 
       # TODO: This doesn't support multiple path params
-      is_id = ->(path_segment) { path_segment.is_a?(Symbol) && path_segment.to_s.end_with?('id') }
+      is_id = ->(path_segment) { path_segment.is_a?(Symbol) && path_segment.to_s.end_with?("id") }
       has_id = path.any? is_id
 
       request_method = :request

data/lib/increase/response_array.rb

@@ -13,7 +13,7 @@ module Increase
     end
 
     def next_cursor
-      wrapped&.dig('next_cursor')
+      wrapped&.dig("next_cursor")
     end
   end
 end

data/lib/increase/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Increase
-  VERSION = "0.3.0"
+  VERSION = "0.3.2"
 end

data/lib/increase/webhook/signature.rb

@@ -23,7 +23,7 @@ module Increase
         end
 
         # Parse header
-        sig_values = signature_header.split(",").map { |pair| pair.split("=") }.to_h
+        sig_values = signature_header&.split(",")&.map { |pair| pair.split("=") }&.to_h || {}
 
         # Extract values
         t = sig_values["t"] # Should be a string (ISO-8601 timestamp)
@@ -32,6 +32,8 @@ module Increase
         raise sig_error.call("No signature found with scheme #{scheme} in signature header") if sig.nil?
 
         # Check signature
+        raise sig_error.call("Webhook secret is required") if secret.nil?
+        raise sig_error.call("Payload is required") if payload.nil?
         expected_sig = compute_signature(timestamp: t, payload: payload, secret: secret)
         matches = Util.secure_compare(expected_sig, sig)
         raise sig_error.call("Signature mismatch") unless matches
@@ -56,6 +58,10 @@ module Increase
       end
 
       def self.compute_signature(timestamp:, payload:, secret:)
+        raise ArgumentError, "timestamp is required" if timestamp.nil?
+        raise ArgumentError, "payload is required" if payload.nil?
+        raise ArgumentError, "secret is required" if secret.nil?
+
         signed_payload = timestamp.to_s + "." + payload.to_s
         OpenSSL::HMAC.hexdigest("SHA256", secret, signed_payload)
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: increase
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.2
 platform: ruby
 authors:
 - Gary Tou
@@ -14,30 +14,36 @@ dependencies:
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: 1.0.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.1
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: faraday-follow_redirects
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: '0.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: '0.3'
 - !ruby/object:Gem::Dependency
   name: faraday-multipart
   requirement: !ruby/object:Gem::Requirement
@@ -159,6 +165,7 @@ extra_rdoc_files: []
 files:
 - ".rspec"
 - ".standard.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - OPENAPI_VERSION
@@ -167,12 +174,14 @@ files:
 - bin/generate
 - bin/setup
 - generate/resource.rb.erb
-- lib/faraday/raise_increase_api_error.rb
 - lib/increase.rb
 - lib/increase/client.rb
 - lib/increase/configuration.rb
 - lib/increase/errors.rb
 - lib/increase/file_upload.rb
+- lib/increase/middleware/encode_json.rb
+- lib/increase/middleware/parse_json.rb
+- lib/increase/middleware/raise_api_error.rb
 - lib/increase/resource.rb
 - lib/increase/resources.rb
 - lib/increase/resources/account_numbers.rb

data/lib/faraday/raise_increase_api_error.rb

@@ -1,11 +0,0 @@
-require "faraday"
-
-module FaradayMiddleware
-  class RaiseIncreaseApiError < Faraday::Middleware
-    def on_complete(env)
-      return if env[:status] < 400
-
-      raise Increase::ApiError.from_response(env)
-    end
-  end
-end