incrdecr_cached_counts 0.5.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c0a0f2090aabd3b286436ad4bce2dca587f003cb5c19307be1d7974c84894ab
-  data.tar.gz: 546850171cb6d859149155acd0a6c3cc4697702306c7e7d7015c6a6e86bc4066
+  metadata.gz: 65f000f6f11bec569b0c22d96041b54a76c7ae97fa8cad585f9652e1ccc298ea
+  data.tar.gz: 1f16dee9e6cef13c66c96de022a894461769ee09fc47871ee6c68645d7efee22
 SHA512:
-  metadata.gz: dc5aa5c3e0977528853821aa6d11484f1bfccbb8c435c003ea4c90856cac06933448c52707884dd182a5727f04c701ff5a5bf21d8454b695637a62fd0860ed72
-  data.tar.gz: 7ce3ec421d5bea4a5f6e1a5a80c341fcb603f8288a13751058afb9ced3aea58ceae75668a42522132d3f3246e5955a60a16ecf80f6b9a1b6d6017a1286e9f9b1
+  metadata.gz: 44a2889f0308a275bac293e526106ddedeffd947224737613a7dec6c050d07e4b9e8a2c3ab2326a6cdc321fad3bbbc8bd3078a0c6d240fab6cd5427968d5ea01
+  data.tar.gz: 8beafe928a06926c652e3130e41aab35fc5f362b1fa56189c0d04bda9cf52904eadc9b741f48d664f331b6aa2a5ec7ad0bbe1513fd387af292119217de904dff

data/incrdecr_cached_counts.gemspec

@@ -21,6 +21,7 @@ Gem::Specification.new do |s|
 
   s.add_dependency "rails", ">= 5.2"
   s.add_dependency "dalli"
+  s.add_dependency "concurrent-ruby", "1.3.4"
 
   s.add_development_dependency "sqlite3"
   s.add_development_dependency "rspec"

data/lib/cached_counts/version.rb

@@ -1,3 +1,3 @@
 module CachedCounts
-  VERSION = "0.5.0"
+  VERSION = "0.7.0"
 end

data/lib/cached_counts.rb

@@ -156,19 +156,9 @@ module CachedCounts
     end
 
     def default_race_condition_fallback_proc(key, relation, options)
-      fallback = Rails.cache.read(key)
+      fallback = Rails.cache.read(key, raw: true)
       fallback = fallback.value if fallback.is_a?(ActiveSupport::Cache::Entry)
 
-      if fallback.nil?
-        begin
-          fallback = relation.count
-        rescue ActiveRecord::StatementInvalid => e
-          fallback = 0
-        end
-
-        Rails.cache.write key, fallback, expires_in: options.fetch(:expires_in, 1.week), raw: true
-      end
-
       -> { fallback }
     end
 
@@ -186,7 +176,7 @@ module CachedCounts
 
         # Try to fetch values for ids from the cache. If it's a miss return the default value
         define_singleton_method "try_#{attr_name}_counts_for" do |ids, default=nil|
-          raw_result = Rails.cache.read_multi(*ids.map{|id| association_count_key(id, attribute_name, version)})
+          raw_result = Rails.cache.read_multi(*ids.map{|id| association_count_key(id, attribute_name, version)}, raw: true)
 
           result = {}
           ids.each do |id|
@@ -253,13 +243,16 @@ module CachedCounts
             # Ensure that other reads find something in the cache, but
             # continue calculating here because the default is likely inaccurate.
             fallback_value = instance_exec &race_condition_fallback
-            CachedCounts.logger.warn "Setting #{fallback_value} as race_condition_fallback for #{send(key_method)}"
-            Rails.cache.write(
-              send(key_method),
-              fallback_value.to_i,
-              expires_in: 30.seconds,
-              raw: true
-            )
+
+            if fallback_value
+              CachedCounts.logger.warn "Setting #{fallback_value} as race_condition_fallback for #{send(key_method)}"
+              Rails.cache.write(
+                send(key_method),
+                fallback_value.to_i,
+                expires_in: 30.seconds,
+                raw: true
+              )
+            end
           end
 
           relation = instance_exec(&relation_getter)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: incrdecr_cached_counts
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.7.0
 platform: ruby
 authors:
 - David Judd
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-13 00:00:00.000000000 Z
+date: 2025-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -38,6 +38,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: concurrent-ruby
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.3.4
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.3.4
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -143,7 +157,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.4.10
 signing_key: 
 specification_version: 4
 summary: A replacement for Rails' counter caches using memcached (via Dalli)