incline 0.1.5

data/test/extensions/action_view_base_extensions_test.rb

@@ -0,0 +1,267 @@
+require 'test_helper'
+require 'cgi/util'
+
+class ActionViewBaseExtensionsTest < ActiveSupport::TestCase
+
+  class TestModel
+    def errors
+      @errors ||= TestErrors.new
+    end
+  end
+
+  class TestErrors
+    def any?
+      true
+    end
+    def count
+      10
+    end
+    def full_messages
+      @full_messages ||= (1..10).to_a.map{ |v| "This is error ##{v}." }
+    end
+  end
+
+
+  def setup
+    @view = ActionView::Base.new
+  end
+
+  test 'should have extension methods' do
+    assert @view.respond_to?(:full_title)
+    assert @view.respond_to?(:show_check_if)
+    assert @view.respond_to?(:glyph)
+    assert @view.respond_to?(:render_alert)
+    assert @view.respond_to?(:error_summary)
+    assert @view.respond_to?(:fmt_date)
+    assert @view.respond_to?(:fmt_num)
+    assert @view.respond_to?(:gravatar_for)
+    assert @view.respond_to?(:panel)
+  end
+
+  test 'full_title should work as expected' do
+    app_name = Rails.application.app_name.strip
+    assert_equal app_name, @view.full_title
+    assert_equal "Hello World | #{app_name}", @view.full_title('Hello World')
+  end
+
+  test 'show_check_if should work as expected' do
+    # false should be nil.
+    assert_nil @view.show_check_if(false)
+    assert_nil @view.show_check_if(nil)
+
+    # true should not be nil.
+    expected = '<i class="glyphicon glyphicon-ok glyphicon-small"></i>'
+    val = @view.show_check_if(true)
+    assert_not val.blank?
+    assert_equal expected, val
+    assert val.html_safe?
+
+    # values that convert to true should also work.
+    assert_equal val, @view.show_check_if(:true)
+    assert_equal val, @view.show_check_if('true')
+    assert_equal val, @view.show_check_if('yes')
+    assert_equal val, @view.show_check_if('1')
+    assert_equal val, @view.show_check_if(1)
+
+    # and those that convert to false should be nil
+    assert_nil @view.show_check_if(:false)
+    assert_nil @view.show_check_if('false')
+    assert_nil @view.show_check_if('no')
+    assert_nil @view.show_check_if('0')
+    assert_nil @view.show_check_if(0)
+  end
+
+  test 'glyph should work as expected' do
+    # blank values should return nil.
+    assert_nil @view.glyph(nil)
+    assert_nil @view.glyph('')
+    assert_nil @view.glyph('   ')
+
+    expected = '<i class="glyphicon glyphicon-ok"></i>'
+    assert_equal expected, @view.glyph(:ok)
+    assert_equal expected, @view.glyph('ok')
+    assert_equal expected, @view.glyph(' ok ')
+    assert_equal expected, @view.glyph(:ok, :normal)  # invalid size
+    assert_equal expected, @view.glyph(:ok, :big)     # invalid size
+    assert_equal expected, @view.glyph(:ok, :tiny)    # invalid size
+
+    expected = '<i class="glyphicon glyphicon-cloud glyphicon-small"></i>'
+    assert_equal expected, @view.glyph(:cloud, :small)
+    assert_equal expected, @view.glyph('cloud', 'small')
+    assert_equal expected, @view.glyph(:cloud, 'sm')
+    assert_equal expected, @view.glyph('cloud', :sm)
+
+    expected = '<i class="glyphicon glyphicon-remove glyphicon-large"></i>'
+    assert_equal expected, @view.glyph(:remove, :large)
+    assert_equal expected, @view.glyph(:remove, 'lg')
+  end
+
+  test 'fmt_date should work as expected' do
+    assert_nil @view.fmt_date(nil)
+    assert_nil @view.fmt_date('')
+    assert_nil @view.fmt_date('  ')
+
+    # test the string formats.
+    assert_equal '1/1/2017', @view.fmt_date('1/1/2017')
+    assert_equal '12/31/2017', @view.fmt_date('12/31/2017')
+    assert_equal '1/1/2017', @view.fmt_date('2017-01-01')
+    assert_equal '12/31/2017', @view.fmt_date('2017-12-31')
+    assert_equal '1/1/2017', @view.fmt_date('2017-1-1 12:30 PM')
+    assert_equal '12/31/2017', @view.fmt_date('12/31/2017 12:30 PM')
+
+    val = Time.parse('2016-05-08')
+    assert_equal '5/8/2016', @view.fmt_date(val)
+
+    val = Date.new(2016,12,31)
+    assert_equal '12/31/2016', @view.fmt_date(val)
+
+    val = Time.parse('2016-12-31 23:00:00 -04:00')
+    assert_equal '12/31/2016', @view.fmt_date(val)
+    assert_equal '1/1/2017', @view.fmt_date(val.utc)
+  end
+
+  test 'fmt_num should work as expected' do
+    assert_nil @view.fmt_num(nil)
+    assert_nil @view.fmt_num('')
+    assert_nil @view.fmt_num('  ')
+
+    assert_equal '0.00', @view.fmt_num(0)
+    assert_equal '0.00', @view.fmt_num('0')
+
+    assert_equal '1.50', @view.fmt_num(1.499997)
+    assert_equal '123.45', @view.fmt_num('123.450678')
+
+    assert_equal '150', @view.fmt_num(150, 0)
+    assert_equal '123', @view.fmt_num(123.456, 0)
+
+    assert_equal '1.0000', @view.fmt_num(1, 4)
+    assert_equal '123.4567', @view.fmt_num(123.4567, 4)
+  end
+
+  test 'render_alert accepts valid alert types' do
+    {
+        :success => :success,
+        :info => :info,
+        :warning => :warning,
+        :danger => :danger,
+        :notice => :info,
+        :alert => :danger,
+        :error => :danger,
+        :warn => :warning,
+        :safe_success => :success,
+        :safe_info => :info,
+        :safe_warning => :warning,
+        :safe_danger => :danger,
+        :safe_notice => :info,
+        :safe_alert => :danger,
+        :safe_error => :danger,
+        :safe_warn => :warning
+    }.each do |type, klass|
+      expected = "<div class=\"alert alert-#{klass} alert-dismissible\">" +
+          '<button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>' +
+          '<span>Hello World</span>' +
+          '</div>'
+      assert_equal expected, @view.render_alert(type, 'Hello World'), "Mismatch for #{type.inspect}"
+    end
+  end
+
+  test 'render_alert converts invalid alert types to info' do
+    [
+        :good, :not_good, :fatal, :information, :xyz
+    ].each do |type|
+      expected = '<div class="alert alert-info alert-dismissible">' +
+          '<button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>' +
+          '<span>Hello World</span>' +
+          '</div>'
+      assert_equal expected, @view.render_alert(type, 'Hello World')
+    end
+  end
+
+  test 'render_alert supports simple markdown' do
+    expected = '<div class="alert alert-info alert-dismissible">' +
+        '<button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>' +
+        '<span><strong>Hello</strong> World</span>' +
+        '</div>'
+    assert_equal expected, @view.render_alert(:info, '__Hello__ World')
+  end
+
+  test 'render_alert handles arrays correctly' do
+    expected = '<div class="alert alert-info alert-dismissible">' +
+        '<button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>' +
+        '<span>Line 1</span><br>' +
+        '<span>Line 2</span>' +
+        '</div>'
+    assert_equal expected, @view.render_alert(:info, [ 'Line 1', 'Line 2' ])
+  end
+
+  test 'render_alert handles hashes correctly' do
+    expected = '<div class="alert alert-danger alert-dismissible">' +
+            '<button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>' +
+            '<div>Name<ul><li>cannot be blank</li><li>must be unique</li></ul></div>' +
+            '<div>Age<ul><li>must be greater than 18</li></ul></div>' +
+            '</div>'
+    assert_equal expected, @view.render_alert(:error, { :name => [ 'cannot be blank', 'must be unique' ], :age => 'must be greater than 18' })
+  end
+
+  test 'render_alert handles mixed message correctly' do
+    expected = '<div class="alert alert-danger alert-dismissible">' +
+        '<button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>' +
+        '<span><strong>The model could not be saved.</strong></span><br>' +
+        '<div>Name<ul><li>cannot be blank</li><li>must be unique</li></ul></div>' +
+        '<div>Age<ul><li>must be greater than 18</li></ul></div>' +
+        '</div>'
+    assert_equal expected, @view.render_alert(:error, [ '__The model could not be saved.__', { :name => [ 'cannot be blank', 'must be unique' ], :age => 'must be greater than 18' } ])
+  end
+
+  test 'render_alert safe vs unsafe test' do
+
+    text = 'This is <em>my</em> test value &#9786;<br>There is <strong>nothing</strong> you can do about it.'
+    safe_text = CGI::escape_html(text)
+
+    expected = '<div class="alert alert-info alert-dismissible">' +
+        '<button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>' +
+        "<span>#{safe_text}</span>" +
+        '</div>'
+    assert_equal expected, @view.render_alert(:info, text)
+
+    expected = '<div class="alert alert-info alert-dismissible">' +
+        '<button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>' +
+        "<span>#{text}</span>" +
+        '</div>'
+    assert_equal expected, @view.render_alert(:safe_info, text)
+  end
+
+  test 'error_summary should work as expected' do
+    expected = "<div id=\"error_explanation\"><div class=\"alert alert-danger\">" +
+        "<div><strong>The form contains 10 errors.</strong><ul>" +
+        "<li>This is error #1.</li><li>This is error #2.</li><li>This is error #3.</li><li>This is error #4.</li>" +
+        "<li>This is error #5.</li>" +
+        "<li class=\"alert_52444_show\"><a href=\"javascript:show_alert_52444()\" title=\"Show 5 more\">... plus 5 more</a></li>" +
+        "<li class=\"alert_52444\" style=\"display: none;\">This is error #6.</li>" +
+        "<li class=\"alert_52444\" style=\"display: none;\">This is error #7.</li>" +
+        "<li class=\"alert_52444\" style=\"display: none;\">This is error #8.</li>" +
+        "<li class=\"alert_52444\" style=\"display: none;\">This is error #9.</li>" +
+        "<li class=\"alert_52444\" style=\"display: none;\">This is error #10.</li>" +
+        "</ul></div>" +
+        "<script type=\"text/javascript\">\n<![CDATA[\nfunction show_alert_52444() { $('.alert_52444_show').hide(); $('.alert_52444').show(); }\n\n]]>\n</script>\n" +
+        "</div></div>"
+
+    val = @view.error_summary(TestModel.new)
+
+    assert val
+    assert val =~ /show_alert_([0-9a-fA-F]{5})\(\)/
+    id = $1
+    expected = expected.gsub('52444', id)
+
+    assert_equal expected, val
+  end
+
+  test 'gravatar_for should work as expected' do
+    # TODO: Fill in test.
+  end
+
+  test 'panel should work as expected' do
+    # TODO: Fill in test.
+  end
+
+end

data/test/extensions/active_record_extensions_test.rb

@@ -0,0 +1,173 @@
+require 'test_helper'
+
+class ActiveRecordExtensionsTest < ActiveSupport::TestCase
+
+  TEST_TABLE_NAME = "test_table_#{SecureRandom.random_number(1<<16).to_s(16).rjust(4,'0')}"
+  TEST_TABLE_CLASS = TEST_TABLE_NAME.classify.to_sym
+
+  def setup
+    # Create a test table.
+    silence_stream STDOUT do
+      ActiveRecord::Migration::create_table TEST_TABLE_NAME do |t|
+        t.string :name
+      end
+    end
+
+    # And then create a test model.
+    eval <<-EOM
+class #{TEST_TABLE_CLASS} < ActiveRecord::Base
+  self.table_name = #{TEST_TABLE_NAME.inspect}
+end
+    EOM
+
+    # Store the model class for use.
+    @model_class = self.class.const_get TEST_TABLE_CLASS
+
+    # Add a few records just to have something to play with.
+    @model_class.create name: 'Item 1'
+    @model_class.create name: 'Item 2'
+    @model_class.create name: 'Item 3'
+    @model_class.create name: 'Item 2'  # one duplicate name...
+  end
+
+  def teardown
+    # Undefine the model class (or at least remove it from the Object namespace).
+    self.class.send :remove_const, TEST_TABLE_CLASS
+
+    # Remove the table from the database.
+    silence_stream STDOUT do
+      ActiveRecord::Migration::drop_table TEST_TABLE_NAME
+    end
+  end
+
+  test 'has extension methods' do
+    assert @model_class.respond_to?(:get_id)
+    assert @model_class.respond_to?(:get)
+    assert @model_class.respond_to?('[]')
+  end
+
+  test 'to_s and inspect are overridden' do
+    item = @model_class.first
+    assert_equal item.name, item.to_s
+    assert_equal "#<#{item.class}:#{item.object_pointer} #{item.to_s}>", item.inspect
+  end
+
+  test 'get_id returns ids' do
+    item = @model_class.first
+    # recognize a model and return the ID.
+    assert_equal item.id, @model_class.get_id(item)
+
+    # return the integer value unmodified.
+    assert_equal item.id, @model_class.get_id(item.id)
+
+    # recognize an integer string and return the integer value.
+    assert_equal item.id, @model_class.get_id(item.id.to_s)
+
+    # locate the item by name and return the ID.
+    assert_equal item.id, @model_class.get_id(item.name)
+
+    # do it all again with arrays.
+    assert_equal [ item.id ], @model_class.get_id([ item ])
+    assert_equal [ item.id ], @model_class.get_id([ item.id ])
+    assert_equal [ item.id ], @model_class.get_id([ item.id.to_s ])
+    assert_equal [ item.id ], @model_class.get_id([ item.name ])
+
+    # does not validate integers.
+    assert_equal 99, @model_class.get_id(99)
+
+    # Searches by :code and :name attributes if the model has them.
+    # This is apparent where we are searching with the item name.
+    # However if the name doesn't match, nil should be returned.
+    assert_nil @model_class.get_id('Item 4')
+  end
+
+  test 'get works as expected' do
+    # get() will always return an array unless there are no results.
+    # It will search by :code and :name attributes if the model has them.
+
+    # There should be two items named 'Item 2'.
+    ids = @model_class.get_id('Item 2')
+    assert_equal 2, ids.count
+
+    items = @model_class.get('Item 2')
+    assert items
+    assert_equal 2, items.count
+    assert_equal ids, items.map{|i| i.id}
+
+    items = @model_class.get(ids)
+    assert items
+    assert_equal 2, items.count
+    assert_equal ids, items.map{|i| i.id}
+
+    # There should only be one item named 'Item 3'.
+    ids = @model_class.get_id('Item 3')
+    assert ids.is_a?(::Integer)
+
+    items = @model_class.get('Item 3')
+    assert items
+    assert_equal 1, items.count
+    assert_equal ids, items.first.id
+
+    items = @model_class.get(ids)
+    assert items
+    assert_equal 1, items.count
+    assert_equal ids, items.first.id
+
+    # Should allow an array as an argument.
+    items = @model_class.get(['Item 1', 'Item 3'])
+    assert items
+    assert_equal 2, items.count
+    assert items.find{|i| i.name == 'Item 1'}
+    assert items.find{|i| i.name == 'Item 3'}
+
+    # There should be no item named 'Item 4'.
+    assert_nil @model_class.get('Item 4')
+
+    # There should be no ID of 99.
+    assert_nil @model_class.get(99)
+  end
+
+  test '[] works as expected' do
+    # [] will always return one item if any items are found or nil if none are found.
+    # It will search by :code and :name attributes if the model has them.
+
+    # There should be two items named 'Item 2'.
+    # But [] will only return the first, sorted by ID since the name is the same.
+    ids = @model_class.get_id('Item 2')
+    assert_equal 2, ids.count
+
+    item = @model_class['Item 2']
+    assert item
+    assert_equal ids.first, item.id
+
+    # Even when an array is used for the argument, only one item will be returned.
+    item = @model_class[ids]
+    assert item
+    assert_equal ids.first, item.id
+
+    # There should only be one item named 'Item 3'.
+    id = @model_class.get_id('Item 3')
+    assert id.is_a?(::Integer)
+
+    item = @model_class['Item 3']
+    assert item
+    assert_equal id, item.id
+
+    item = @model_class[id]
+    assert item
+    assert_equal id, item.id
+
+    # Should allow an array as an argument, but only the first item will be returned.
+    item = @model_class[['Item 1', 'Item 3']]
+    assert item
+    assert_equal @model_class.get_id('Item 1'), item.id
+
+    # There should be no item named 'Item 4'.
+    assert_nil @model_class['Item 4']
+
+    # There should be no ID of 99.
+    assert_nil @model_class[99]
+  end
+
+
+end

data/test/extensions/application_configuration_extensions_test.rb

@@ -0,0 +1,46 @@
+require 'test_helper'
+
+class ApplicationConfigurationExtensionsTest < ActiveSupport::TestCase
+
+  test 'Rails.application.config has extension' do
+    cfg = Rails.application&.config
+    skip unless cfg
+    assert cfg.respond_to?(:incline_appconfig_original_database_configuration)
+  end
+
+  test 'provide default when config missing' do
+    cfg = Rails::Application::Configuration.new
+
+    # method must already be defined.
+    assert cfg.methods.include?(:incline_appconfig_original_database_configuration)
+
+    # first we'll confirm that the overridden method is getting called.
+    silence_warnings do
+      def cfg.incline_appconfig_original_database_configuration
+        raise 'Just Testing'
+      end
+    end
+
+    begin
+      cfg.database_configuration
+      assert false
+    rescue
+      assert $!.message =~ /just testing/i
+    end
+
+    # now we'll pretend there is no configuration file.
+    silence_warnings do
+      def cfg.incline_appconfig_original_database_configuration
+        raise 'Could not load database configuration. No such file - fake/database.yml'
+      end
+    end
+
+    db_cfg = cfg.database_configuration
+
+    assert db_cfg.is_a?(::Hash)
+    assert db_cfg['test']
+    assert db_cfg['development']
+    assert_nil db_cfg['production']
+  end
+
+end

data/test/extensions/application_extensions_test.rb

@@ -0,0 +1,23 @@
+require 'test_helper'
+
+class ApplicationExtensionsTest < ActiveSupport::TestCase
+
+  test 'should have extension methods' do
+    app = Rails.application
+    skip unless app
+    assert app.respond_to?(:running?)
+    assert app.respond_to?(:app_name)
+    assert app.respond_to?(:app_instance_name)
+    assert app.respond_to?(:app_version)
+    assert app.respond_to?(:app_company)
+    assert app.respond_to?(:app_info)
+    assert app.respond_to?(:app_copyright_year)
+    assert app.respond_to?(:app_copyright)
+    assert app.respond_to?(:restart_pending?)
+    assert app.respond_to?(:request_restart!)
+    assert app.respond_to?(:cookie_name)
+  end
+
+  # TODO: Test output of various methods.
+
+end

data/test/extensions/connection_adapter_extensions_test.rb

@@ -0,0 +1,54 @@
+require 'test_helper'
+
+class ConnectionAdapterExtensionsTest < ActiveSupport::TestCase
+
+  TEST_OBJECT_NAME = "test_object_#{SecureRandom.random_number(1<<16).to_s(16).rjust(4, '0')}"
+
+  def setup
+    @conn = ActiveRecord::Base::connection
+  end
+
+  test 'should have extension methods' do
+    assert @conn.respond_to?(:object_exists?)
+    assert @conn.respond_to?(:exec_sp)
+  end
+
+  test 'should be able to determine existence' do
+    assert_not @conn.object_exists?(TEST_OBJECT_NAME)
+    @conn.execute "CREATE TABLE #{TEST_OBJECT_NAME} ( some_value INTEGER NOT NULL )"
+    begin
+      assert @conn.object_exists?(TEST_OBJECT_NAME)
+    ensure
+      @conn.execute "DROP TABLE #{TEST_OBJECT_NAME}"
+    end
+  end
+
+  test 'should be able to execute a stored proc' do
+    skip if MsSqlTestConn.skip_tests?
+    @conn = MsSqlTestConn.connection
+
+    assert_not @conn.object_exists?(TEST_OBJECT_NAME)
+
+    @conn.execute <<-EOS
+CREATE PROCEDURE #{TEST_OBJECT_NAME}
+  @i_val INTEGER
+AS
+BEGIN
+  SET NOCOUNT ON;
+  DECLARE @d_val INTEGER;
+  SELECT @d_val = ISNULL(@i_val, 0) + 55;
+  RETURN @d_val;
+END
+    EOS
+    begin
+      # It should exist now.
+      assert @conn.object_exists?(TEST_OBJECT_NAME)
+      # And it should retrieve the return value.
+      assert_equal 55, @conn.exec_sp("exec #{TEST_OBJECT_NAME} NULL")
+      assert_equal 100, @conn.exec_sp("exec #{TEST_OBJECT_NAME} 45")
+    ensure
+      @conn.execute "DROP PROCEDURE #{TEST_OBJECT_NAME}"
+    end
+  end
+
+end

data/test/extensions/date_time_value_extensions_test.rb

@@ -0,0 +1,104 @@
+require 'test_helper'
+
+class DateTimeValueExtensionsTest < ActiveSupport::TestCase
+
+  TEST_TABLE_NAME = "test_table_#{SecureRandom.random_number(1<<16).to_s(16).rjust(4,'0')}"
+  TEST_TABLE_CLASS = TEST_TABLE_NAME.classify.to_sym
+
+  def setup
+    # Create a test table.
+    silence_stream STDOUT do
+      ActiveRecord::Migration::create_table TEST_TABLE_NAME do |t|
+        t.datetime :tz_value
+        t.datetime :utc_value
+      end
+    end
+
+    # And then create a test model.
+    eval <<-EOM
+class #{TEST_TABLE_CLASS} < ActiveRecord::Base
+  self.table_name = #{TEST_TABLE_NAME.inspect}
+  self.time_zone_aware_attributes = true
+  self.skip_time_zone_conversion_for_attributes << :utc_value
+end
+    EOM
+
+    @backup_ar_tz = ActiveRecord::Base.default_timezone
+    @backup_tm_tz = Time.zone.name
+    ActiveRecord::Base.default_timezone = :utc
+    Time.zone = 'EST'
+
+    # Store the model class for use.
+    @model_class = self.class.const_get TEST_TABLE_CLASS
+    @item = @model_class.new
+  end
+
+  def teardown
+    # Undefine the model class (or at least remove it from the Object namespace).
+    self.class.send :remove_const, TEST_TABLE_CLASS
+
+    # Remove the table from the database.
+    silence_stream STDOUT do
+      ActiveRecord::Migration::drop_table TEST_TABLE_NAME
+    end
+
+    ActiveRecord::Base.default_timezone = @backup_ar_tz
+    Time.zone = @backup_tm_tz
+  end
+
+  test 'uses correct types' do
+    col = @model_class.columns.find{|c| c.name == 'tz_value'}
+    assert col
+    assert col.cast_type.is_a?(::ActiveRecord::AttributeMethods::TimeZoneConversion::TimeZoneConverter)
+    col = @model_class.columns.find{|c| c.name == 'utc_value'}
+    assert col
+    assert_not col.cast_type.is_a?(::ActiveRecord::AttributeMethods::TimeZoneConversion::TimeZoneConverter)
+    assert col.cast_type.is_a?(::ActiveRecord::Type::DateTime)
+  end
+
+  test 'accepts valid values' do
+    {
+        '2016-12-31' => Time.utc(2016,12,31),
+        '12/31/2016' => Time.utc(2016,12,31),
+        '16-12-31' => Time.utc(2016,12,31),
+        '12/31/16' => Time.utc(2016,12,31),
+        '2016-12-31 1:20' => Time.utc(2016,12,31,1,20),
+        '12/31/2016 1:20' => Time.utc(2016,12,31,1,20),
+        '12/31/2016 1:20 PM' => Time.utc(2016,12,31,13,20),
+        '12/31/2016 12:20 AM' => Time.utc(2016,12,31,0,20),
+        '12/31/2016 12:20 PM' => Time.utc(2016,12,31,12,20),
+        '12/31/2016 24:00' => Time.utc(2017,1,1,0,0),
+        '2016-12-31T24:00' => Time.utc(2017,1,1,0,0),
+        '2016-12-31 24:00+01:00' => Time.utc(2016,12,31,23,0),
+    }.each do |s,v|
+      @item.utc_value = s
+      assert_equal v, @item.utc_value, "Should have accepted #{s.inspect}"
+      @item.tz_value = s
+      assert_equal v.in_time_zone, @item.tz_value, "Should have accepted #{s.inspect}"
+    end
+
+  end
+
+  test 'rejects invalid values' do
+
+    [
+        '',
+        '  ',
+        '0000-00-00',
+        '0000-00-00 00:00:00',
+        '2016-13-31',
+        '2016-12-32',
+        '2016-02-30',
+        '2/30/2016',
+        '1/1/2017 24:01',
+        '12:30'
+    ].each do |val|
+      @item.tz_value = val
+      assert_nil @item.tz_value, "Should have rejected #{val.inspect}"
+      @item.utc_value = val
+      assert_nil @item.utc_value, "Should have rejected #{val.inspect}"
+    end
+
+  end
+
+end