inch 0.5.0.rc3 → 0.5.0.rc4

data/test/test_helper.rb

@@ -1,12 +1,12 @@
-require 'simplecov'
+require "simplecov"
 
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
 
-require 'minitest/autorun'
-require 'bundler'
+require "minitest/autorun"
+require "bundler"
 Bundler.require
-require 'inch'
-require 'inch/cli'
+require "inch"
+require "inch/cli"
 
 def assert_roles(object, expected, unexpected)
   roles = object.roles.map(&:class)
@@ -28,8 +28,8 @@ def find_roles(object, role_class, object_name = nil)
   end
 end
 
-def fixture_path(name)
-  File.join(File.dirname(__FILE__), "fixtures", name.to_s)
+def fixture_path(language, name)
+  File.join(File.dirname(__FILE__), "fixtures", language.to_s, name.to_s)
 end
 
 module Inch
@@ -37,19 +37,19 @@ module Inch
     class << self
       attr_accessor :object_providers
 
-      def codebase(name)
-        Inch::Codebase::Proxy.new object_provider(name)
+      def codebase(language, name)
+        Inch::Codebase::Proxy.new language, object_provider(language, name)
       end
 
-      def object_provider(name)
+      def object_provider(language, name)
         self.object_providers ||= {}
-        self.object_providers[name] ||= ::Inch::CodeObject::Provider.parse(fixture_path(name))
+        self.object_providers[name] ||= ::Inch::CodeObject::Provider.parse(fixture_path(language, name))
       end
     end
   end
 end
 
 def test_codebase(name)
-  codebase = Inch::Test.codebase(name)
+  codebase = Inch::Test.codebase(:ruby, name)
   codebase
 end

data/test/unit/api/filter_test.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
 describe ::Inch::API::Filter do
   before do
@@ -13,37 +13,37 @@ describe ::Inch::API::Filter do
   end
 
   it "should work with option: visibility == :public" do
-    @options = {:visibility => [:public]}
+    @options = { visibility: [:public] }
     @context = ::Inch::API::Filter.new @codebase, @options
     assert @context.objects.all? { |o| o.public? }
   end
 
   it "should work with option: visibility == :protected" do
-    @options = {:visibility => [:protected]}
+    @options = { visibility: [:protected] }
     @context = ::Inch::API::Filter.new @codebase, @options
     assert @context.objects.all? { |o| o.protected? }
   end
 
   it "should work with option: visibility == :private" do
-    @options = {:visibility => [:private]}
+    @options = { visibility: [:private] }
     @context = ::Inch::API::Filter.new @codebase, @options
     assert @context.objects.all? { |o| o.private? || o.tagged_as_private? }
   end
 
   it "should work with option: namespaces == :only" do
-    @options = {:namespaces => :only}
+    @options = { namespaces: :only }
     @context = ::Inch::API::Filter.new @codebase, @options
     assert @context.objects.all? { |o| o.namespace? }
   end
 
   it "should work with option: undocumented == :only" do
-    @options = {:undocumented => :only}
+    @options = { undocumented: :only }
     @context = ::Inch::API::Filter.new @codebase, @options
     assert @context.objects.all? { |o| o.undocumented? }
   end
 
   it "should work with option: depth == 2" do
-    @options = {:depth => 2}
+    @options = { depth: 2 }
     @context = ::Inch::API::Filter.new @codebase, @options
     refute @context.objects.any? { |o| o.depth > 2 }
   end

data/test/unit/api/get_test.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
 describe ::Inch::API::Get do
   before do

data/test/unit/api/list_test.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
 describe ::Inch::API::List do
   before do

data/test/unit/api/options/base_test.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../../test_helper")
 
 describe ::Inch::API::Options::Base do
   class APIOptionsTest < ::Inch::API::Options::Base
@@ -8,7 +8,7 @@ describe ::Inch::API::Options::Base do
   end
 
   it "should work with a Hash or Struct" do
-    @options_hash = {:foo => "foo", :baz => 42}
+    @options_hash = { foo: "foo", baz: 42 }
     @options_struct = OpenStruct.new(@options_hash)
 
     @options1 = APIOptionsTest.new @options_hash
@@ -21,7 +21,7 @@ describe ::Inch::API::Options::Base do
   end
 
   it "should return default values" do
-    @options_hash = {:baz => 42}
+    @options_hash = { baz: 42 }
     @options = APIOptionsTest.new @options_hash
 
     assert_equal :bar, @options.foo

data/test/unit/api/stats_test.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
 describe ::Inch::API::Stats do
   before do

data/test/unit/api/suggest_test.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
 describe ::Inch::API::Suggest do
   before do
@@ -13,10 +13,10 @@ describe ::Inch::API::Suggest do
   end
 
   it "should work with option: object_count" do
-    @options = {:object_count => 10}
+    @options = { object_count: 10 }
     @context = ::Inch::API::Suggest.new @codebase, @options
 
-    @options2 = {:object_count => 20}
+    @options2 = { object_count: 20 }
     @context2 = ::Inch::API::Suggest.new @codebase, @options2
 
     assert_equal 10, @context.objects.size

data/test/unit/cli/arguments_test.rb

@@ -1,8 +1,8 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
 describe ::Inch::CLI::Arguments do
   before do
-    Dir.chdir fixture_path(:simple)
+    Dir.chdir fixture_path(:ruby, :simple)
     assert File.file?("README")
   end
 

data/test/unit/cli/command/base_test.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../../test_helper")
 
 describe ::Inch::CLI::Command::Console do
   before do

data/test/unit/cli/command/options/base_list_test.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../../../test_helper")
 
 describe ::Inch::CLI::Command::Options::BaseList do
   it "should run parse without errors" do
@@ -10,7 +10,7 @@ describe ::Inch::CLI::Command::Options::BaseList do
     assert @options.undocumented.nil?
     assert @options.depth.nil?
   end
-  
+
   it "should run parse twice without affecting the second run" do
     @options = ::Inch::CLI::Command::Options::BaseList.new
     @options.parse(["--no-public", "--no-protected", "--private"])

data/test/unit/cli/command/options/base_object_test.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../../../test_helper")
 
 describe ::Inch::CLI::Command::Options::BaseObject do
   it "should run parse without errors" do

data/test/unit/cli/command/options/base_test.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../../../test_helper")
 
 describe ::Inch::CLI::Command::Options::Base do
   it "should run parse without errors" do

data/test/unit/cli/command_parser_test.rb

@@ -1,14 +1,14 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
 describe ::Inch::CLI::CommandParser do
   before do
-    Dir.chdir fixture_path(:simple)
+    Dir.chdir fixture_path(:ruby, :simple)
     @command_parser = ::Inch::CLI::CommandParser
   end
 
   it "should run without args" do
     out, err = capture_io do
-      @command = @command_parser.run()
+      @command = @command_parser.run
     end
     refute out.empty?, "there should be some output"
     assert err.empty?, "there should be no errors"

data/test/unit/cli/trace_helper_test.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
 class Tracer
   include ::Inch::CLI::TraceHelper

data/test/unit/cli/yardopts_helper_test.rb

@@ -1,15 +1,15 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
 describe ::Inch::CLI::YardoptsHelper do
   before do
-    Dir.chdir fixture_path(:yardopts)
+    Dir.chdir fixture_path(:ruby, :yardopts)
     assert File.file?(".yardopts")
     @command = ::Inch::CLI::Command::List
   end
 
   it "should run without args" do
     out, err = capture_io do
-      @command.run()
+      @command.run
     end
     refute out.empty?, "there should be some output"
     assert err.empty?, "there should be no errors"
@@ -56,14 +56,15 @@ describe ::Inch::CLI::YardoptsHelper do
     end
     refute out.empty?, "there should be some output"
     assert_match /\bUsage\b.+list/, out
-    #assert_match /\b\-\-\[no\-\]yardopts\b/, out, "--[no-]yardopts should be mentioned"
+    # assert_match /\b\-\-\[no\-\]yardopts\b/, out,
+    #              "--[no-]yardopts should be mentioned"
     assert err.empty?, "there should be no errors"
   end
 end
 
 describe ::Inch::CLI::YardoptsHelper do
   before do
-    Dir.chdir fixture_path(:simple)
+    Dir.chdir fixture_path(:ruby, :simple)
     refute File.file?(".yardopts")
     refute File.file?(".document")
     @command = ::Inch::CLI::Command::List

data/test/unit/code_object/converter_test.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
 describe ::Inch::CodeObject::Converter do
   class MockObject

data/test/unit/code_object/provider_test.rb

@@ -1,9 +1,9 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
 describe ::Inch::CodeObject::Provider do
   it "should parse all objects" do
     Dir.chdir File.dirname(__FILE__)
-    @provider = ::Inch::CodeObject::Provider.parse(fixture_path(:simple))
+    @provider = ::Inch::CodeObject::Provider.parse(fixture_path(:ruby, :simple))
     refute @provider.objects.empty?
   end
 end

data/test/unit/code_object/proxy_test.rb

@@ -1,6 +1,6 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
-describe ::Inch::CodeObject::Proxy::Base do
+describe ::Inch::CodeObject::Proxy do
   before do
     @codebase = test_codebase(:code_examples)
     @objects = @codebase.objects

data/test/unit/codebase/objects_test.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
 describe ::Inch::Codebase::Objects do
   before do
@@ -18,7 +18,7 @@ describe ::Inch::Codebase::Objects do
 
   it "should support iteration" do
     sum = 0
-    @objects.each do |o|
+    @objects.each do
       sum += 1
     end
     assert_equal @objects.size, sum

data/test/unit/codebase/proxy_test.rb

@@ -1,16 +1,18 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
 describe ::Inch::Codebase::Proxy do
   it "should parse all objects" do
-    dir = fixture_path(:simple)
-    config = Inch::Config::Codebase.new(["lib/**/*.rb"])
+    dir = fixture_path(:ruby, :simple)
+    config = Inch::Config::Codebase.new(:ruby, ["lib/**/*.rb"])
+    config.object_provider :YARD
     @codebase = Inch::Codebase::Proxy.parse dir, config
     refute_nil @codebase.objects
   end
 
   it "should parse given paths" do
-    dir = fixture_path(:simple)
-    config = Inch::Config::Codebase.new(["app/**/*.rb"])
+    dir = fixture_path(:ruby, :simple)
+    config = Inch::Config::Codebase.new(:ruby, ["app/**/*.rb"])
+    config.object_provider :YARD
     @codebase = Inch::Codebase::Proxy.parse dir, config
     assert @codebase.objects.empty?
   end

data/test/unit/config/codebase_test.rb

@@ -1,16 +1,16 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
 describe ::Inch::Config::Codebase do
   it "should parse .inch.yml" do
-    dir = fixture_path(:simple)
+    dir = fixture_path(:ruby, :simple)
     config = Inch::Config::Codebase.new
     config.update_via_yaml(dir)
     assert config.included_files.empty?
     assert config.excluded_files.empty?
   end
 
-  it "should parse .inch.yml" do
-    dir = fixture_path(:"inch-yml")
+  it "should parse .inch.yml if present" do
+    dir = fixture_path(:ruby, :"inch-yml")
     config = Inch::Config::Codebase.new
     config.update_via_yaml(dir)
     refute config.included_files.empty?

data/test/unit/config_test.rb

@@ -0,0 +1,28 @@
+require File.expand_path(File.dirname(__FILE__) + "/../test_helper")
+
+describe ::Inch::Config do
+  it "should return config for :ruby" do
+    config = Inch::Config.for(:ruby)
+    refute config.codebase.included_files.empty?
+    assert config.codebase.excluded_files.empty?
+  end
+
+  it "should parse .inch.yml if present" do
+    dir = fixture_path(:ruby, :"inch-yml")
+    config = Inch::Config.for(:ruby, dir)
+    refute config.codebase.included_files.empty?
+    refute config.codebase.excluded_files.empty?
+
+    # Assert that this is another conf, unaltered
+    # by the conf loading before
+    config = Inch::Config.for(:ruby)
+    refute config.codebase.included_files.empty?
+    assert config.codebase.excluded_files.empty?
+  end
+
+  it "should return config.evaluation for :ruby" do
+    config = Inch::Config.for(:ruby)
+    refute_nil config.evaluation.criteria_for(:MethodObject)
+  end
+
+end

data/test/unit/evaluation/{role/base_test.rb → role_test.rb}

@@ -1,19 +1,19 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../test_helper")
 
-class MockPrivateRole < ::Inch::Evaluation::Role::Base
+class MockPrivateRole < ::Inch::Evaluation::Role
   applicable_if :private?
 end
 
-class MockNotPrivateRole < ::Inch::Evaluation::Role::Base
+class MockNotPrivateRole < ::Inch::Evaluation::Role
   applicable_unless :private?
 end
 
-class MockPublicRole < ::Inch::Evaluation::Role::Base
+class MockPublicRole < ::Inch::Evaluation::Role
   applicable_if { |o| o.public? }
 end
 
-class MockIndifferentRole < ::Inch::Evaluation::Role::Base
-  def self.applicable?(object)
+class MockIndifferentRole < ::Inch::Evaluation::Role
+  def self.applicable?(_object)
     true
   end
 end
@@ -38,7 +38,7 @@ class MockPublicObject
   end
 end
 
-describe ::Inch::Evaluation::Role::Base do
+describe ::Inch::Evaluation::Role do
   describe ".applicable" do
     let(:private_object) { MockPrivateObject.new }
     let(:public_object) { MockPublicObject.new }

data/test/unit/{code_object/proxy → language/ruby/code_object}/method_object_test.rb

@@ -1,6 +1,6 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../../test_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../../../test_helper")
 
-describe ::Inch::CodeObject::Proxy::MethodObject do
+describe ::Inch::Language::Ruby::CodeObject::MethodObject do
   before do
     @codebase = test_codebase(:simple)
     @objects = @codebase.objects
@@ -99,6 +99,15 @@ describe ::Inch::CodeObject::Proxy::MethodObject do
       refute m.has_doc?
       refute m.has_parameters?
       assert m.return_mentioned?
+      refute m.return_described?
+
+      assert m.score
+    end
+
+    it "should handle unusable return value when only @return [void] is given" do
+      m = @objects.find("Foo::Bar#method_without_usable_return_value")
+      assert m.return_mentioned?
+      assert m.return_described?
 
       assert m.score
     end
@@ -129,6 +138,18 @@ describe ::Inch::CodeObject::Proxy::MethodObject do
       assert m.score
     end
 
+    it "should handle yet other RDoc styles" do
+      m = @objects.find("Foo::Bar#method_with_yet_another_rdoc_doc")
+      assert m.has_doc?
+      assert m.has_parameters?
+      p = m.parameter(:param1)
+      assert p.mentioned?         # mentioned in docs, correctly
+      p = m.parameter(:param2)
+      assert p.mentioned?         # mentioned in docs, correctly
+
+      assert m.score
+    end
+
     it "should handle unstructured doc styles" do
       m = @objects.find("Foo::Bar#method_with_unstructured_doc")
       assert m.has_doc?
@@ -151,7 +172,8 @@ describe ::Inch::CodeObject::Proxy::MethodObject do
       assert m.score
     end
 
-    it "should handle methods (without parameters) that have only a docstring (text comment)" do
+    it "should handle methods (without parameters) that have only a docstring" \
+       " (text comment)" do
       m = @objects.find("Foo::Bar#method_without_params_or_return_type")
       assert m.has_doc?
       refute m.has_parameters?
@@ -203,7 +225,8 @@ describe ::Inch::CodeObject::Proxy::MethodObject do
       assert_equal 0, m.score
     end
 
-    it "should recognize a getter in a getter/setter pair defined via attr_accessor" do
+    it "should recognize a getter in a getter/setter pair defined via" \
+       " attr_accessor" do
       m = @objects.find("InchTest#attr_getset")
       assert m.getter?, "should be a getter"
       refute m.setter?
@@ -211,7 +234,8 @@ describe ::Inch::CodeObject::Proxy::MethodObject do
       assert_equal 0, m.score
     end
 
-    it "should recognize a setter in a getter/setter pair defined via attr_accessor" do
+    it "should recognize a setter in a getter/setter pair defined via" \
+       " attr_accessor" do
       m = @objects.find("InchTest#attr_getset=")
       refute m.getter?
       assert m.setter?, "should be a setter"
@@ -235,13 +259,15 @@ describe ::Inch::CodeObject::Proxy::MethodObject do
       assert_equal 0, m.score
     end
 
-    it "should recognize docs on a getter in a getter/setter pair defined via attr_accessor" do
+    it "should recognize docs on a getter in a getter/setter pair defined via" \
+       " attr_accessor" do
       m = @objects.find("Attributes#username")
       refute_equal 0, m.score
       refute m.undocumented?
     end
 
-    it "should recognize docs on a setter in a getter/setter pair defined via attr_accessor" do
+    it "should recognize docs on a setter in a getter/setter pair defined via" \
+       " attr_accessor" do
       m = @objects.find("Attributes#username=")
       refute_equal 0, m.score
       refute m.undocumented?
@@ -275,7 +301,7 @@ describe ::Inch::CodeObject::Proxy::MethodObject do
     it "should work as a writer" do
       m = @objects.find("Attributes#email=")
       refute_equal 0, m.score
-      #refute m.undocumented?
+      # refute m.undocumented?
       # NOTE: this is undocumented since there is no original_docstring
     end
   end
@@ -302,18 +328,23 @@ describe ::Inch::CodeObject::Proxy::MethodObject do
     end
 
     it "should work with several overload tags on the same method" do
+      skip
       m = @objects.find("Overloading#many_overloads")
-      assert_equal 1, count_roles(m, Inch::Evaluation::Role::Method::WithoutReturnDescription)
-      assert_equal 1, count_roles(m, Inch::Evaluation::Role::Method::WithoutReturnType)
-      assert_equal 1, count_roles(m, Inch::Evaluation::Role::MethodParameter::WithoutMention, 'block')
+      assert_equal 1, count_roles(
+        m, Inch::Language::Ruby::Evaluation::Role::Method::WithoutReturnDescription)
+      assert_equal 1, count_roles(
+        m, Inch::Language::Ruby::Evaluation::Role::Method::WithoutReturnType)
+      assert_equal 1, count_roles(
+        m, Inch::Language::Ruby::Evaluation::Role::MethodParameter::WithoutMention, "block")
     end
 
-    it "should work if @param tags are only present in the @overload tags, but not on the actual method" do
+    it "should work if @param tags are only present in the @overload tags," \
+       " but not on the actual method" do
       m = @objects.find("Overloading#params_only_in_overloads")
       unexpected_roles = [
-        Inch::Evaluation::Role::Object::WithoutCodeExample,
-        Inch::Evaluation::Role::MethodParameter::WithoutMention,
-        Inch::Evaluation::Role::MethodParameter::WithoutType,
+        Inch::Language::Ruby::Evaluation::Role::Object::WithoutCodeExample,
+        Inch::Language::Ruby::Evaluation::Role::MethodParameter::WithoutMention,
+        Inch::Language::Ruby::Evaluation::Role::MethodParameter::WithoutType
       ]
       assert_roles m, [], unexpected_roles
     end
@@ -321,11 +352,11 @@ describe ::Inch::CodeObject::Proxy::MethodObject do
     it "should work with one param missing in the overload tag" do
       m = @objects.find("Overloading#one_param_missing_in_overload")
       unexpected_roles = [
-        Inch::Evaluation::Role::Object::WithoutCodeExample,
+        Inch::Language::Ruby::Evaluation::Role::Object::WithoutCodeExample
       ]
       expected_roles = [
-        Inch::Evaluation::Role::MethodParameter::WithoutMention,
-        Inch::Evaluation::Role::MethodParameter::WithoutType,
+        Inch::Language::Ruby::Evaluation::Role::MethodParameter::WithoutMention,
+        Inch::Language::Ruby::Evaluation::Role::MethodParameter::WithoutType
       ]
       assert_roles m, expected_roles, unexpected_roles
     end
@@ -334,10 +365,23 @@ describe ::Inch::CodeObject::Proxy::MethodObject do
   describe "MISC" do
     #
     it "should recognize named parameters in Ruby 2.1" do
+      skip # unless RUBY_VERSION =~ /^2/
+
       m = @objects.find("Foo#method_with_named_parameter")
       unexpected_roles = [
-        Inch::Evaluation::Role::MethodParameter::WithoutMention,
-        Inch::Evaluation::Role::MethodParameter::WithoutType,
+        Inch::Language::Ruby::Evaluation::Role::MethodParameter::WithoutMention,
+        Inch::Language::Ruby::Evaluation::Role::MethodParameter::WithoutType
+      ]
+      assert_roles m, [], unexpected_roles
+    end
+
+    it "should recognize indented parameter documentation" do
+      skip # YARD cannot parse this
+
+      m = @objects.find("Foo#method_with_indented_param_tag")
+      unexpected_roles = [
+        Inch::Language::Ruby::Evaluation::Role::MethodParameter::WithoutMention,
+        Inch::Language::Ruby::Evaluation::Role::MethodParameter::WithoutType
       ]
       assert_roles m, [], unexpected_roles
     end
@@ -401,7 +445,8 @@ describe ::Inch::CodeObject::Proxy::MethodObject do
       assert m.score >= 50 # TODO: don't use magic numbers
     end
 
-    it "should recognize question mark methods with description and parameters" do
+    it "should recognize question mark methods with description and" \
+       " parameters" do
       m = @objects.find("InchTest#method_with_description_and_parameters?")
       refute m.has_doc?
       assert m.has_parameters?